- wine-gitlab - winehq.org

Re: [PATCH v5 0/4] MR6442: winedmo: Introduce a new DLL as a MF FFmpeg backend.
by Galcian79 (＠Galcian79) 24 Sep '24

24 Sep '24

On Tue Sep 24 22:54:03 2024 +0000, Shmerl wrote: > registry / regedit is a way to handle wine settings. That's not limited > to winedmo. Though naming could be a bit better. I was trying to dig > through it using ffmpeg as a filter, while the key is > DisableGstByteStreamHandler. I.e. may be instead of negative it could be > positive `UseFfmpeg...` or something.. Yes i know. But they use to make them into "Settings" when they are broadly used (i.e. gamers). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6442#note_83282

1 0

Re: [PATCH v5 0/4] MR6442: winedmo: Introduce a new DLL as a MF FFmpeg backend.
by Shmerl (＠shmerl) 24 Sep '24

24 Sep '24

registry / regedit is a way to handle wine settings. That's not limited to winedmo. Though naming could be a bit better. I was trying to dig through it using ffmpeg as a filter, while the key is DisableGstByteStreamHandler. I.e. may be instead of negative it could be positive `UseFfmpeg...` or something.. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6442#note_83281

1 0

Re: [PATCH v5 0/4] MR6442: winedmo: Introduce a new DLL as a MF FFmpeg backend.
by Galcian79 (＠Galcian79) 24 Sep '24

24 Sep '24

Just an humble question. Could you make winedmo into a wine (experimental) setting, instead of just rely on wine regedit? This would make it easier for users to set. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6442#note_83280

1 0

[PATCH v3 0/2] MR6543: ntdll: Print error on failure to dlopen builtin shared object.
by Bernhard Übelacker (＠bernhardu) 24 Sep '24

24 Sep '24

Currently trying to dlopen winealsa.so, without having the matching libasound.so.2 installed, fails silently. This should make users aware of the missing dependency. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57206 -- v3: mmdevapi: Add error if no driver could be initialized. ntdll: Add warning if dlopen of unixlib failed. https://gitlab.winehq.org/wine/wine/-/merge_requests/6543

2 3

Re: [PATCH v3 0/1] MR6552: server: Move last_active variable initialization (Valgrind). - approved
by Alexandre Julliard (＠julliard) 24 Sep '24

24 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6552

1 0

Re: [PATCH v6 0/6] MR6446: ntdll: Support process instrumentation callback. - approved
by Alexandre Julliard (＠julliard) 24 Sep '24

24 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6446

1 0

Re: [PATCH v4 0/1] MR6533: winegstreamer: Tweak h264 caps conversion. - approved
by Alexandre Julliard (＠julliard) 24 Sep '24

24 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6533

1 0

Re: [PATCH v2 0/2] MR6541: wininet: Only include non-empty session user agent string in request headers. - approved
by Alexandre Julliard (＠julliard) 24 Sep '24

24 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6541

1 0

Re: [PATCH v2 0/5] MR6544: dplayx, dpwsockx: Open() part 1. - approved
by Alexandre Julliard (＠julliard) 24 Sep '24

24 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6544

1 0

Re: [PATCH v8 0/9] MR6323: winewayland: Support GL/VK rendering in child windows (alt). - approved
by Alexandre Julliard (＠julliard) 24 Sep '24

24 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6323

1 0

Re: [PATCH v4 0/1] MR6348: ntdll: Match the new ARM64 KiUserExceptionDispatcher stack layout. - approved
by Alexandre Julliard (＠julliard) 24 Sep '24

24 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6348

1 0

[PATCH v3 0/1] MR6348: ntdll: Match the new ARM64 KiUserExceptionDispatcher stack layout.
by Billy Laws (＠bylaws) 24 Sep '24

24 Sep '24

This is used starting from around build 27686. -- v3: ntdll: Match the new ARM64 KiUserExceptionDispatcher stack layout. https://gitlab.winehq.org/wine/wine/-/merge_requests/6348

2 1

Re: [PATCH v2 0/1] MR6550: winex11: Avoid recreating the offscreen GL window if not necessary. - approved
by Alexandre Julliard (＠julliard) 24 Sep '24

24 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6550

1 0

Re: [PATCH v2 0/2] MR6546: ODBC fixes - approved
by Alexandre Julliard (＠julliard) 24 Sep '24

24 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6546

1 0

[PATCH v3 0/3] MR6553: ntdll: make GetDriveType prioritize mount managers' config
by Robert Ayrapetyan (＠rayrapetyan) 24 Sep '24

24 Sep '24

The current implementation of the GetDriveTypeW/A function relies on native system calls (such as fstatfs() in Linux) to determine the actual type of the drive, disregarding any configuration set through the mounts manager (wincfg). This patch changes the priority, giving precedence to the mounts manager configuration, making the user responsible for mapping drives. System calls will only be used if the drive is not explicitly configured by the user. I acknowledge that this is a breaking change, but I believe it enforces the correct behavior for GetDriveType. Resolves: https://forum.winehq.org/viewtopic.php?t=38909 -- v3: fix: strlen -> wcslen https://gitlab.winehq.org/wine/wine/-/merge_requests/6553

2 3

[PATCH v2 0/2] MR6553: ntdll: make GetDriveType prioritize mount managers' config
by Robert Ayrapetyan (＠rayrapetyan) 24 Sep '24

24 Sep '24

The current implementation of the GetDriveTypeW/A function relies on native system calls (such as fstatfs() in Linux) to determine the actual type of the drive, disregarding any configuration set through the mounts manager (wincfg). This patch changes the priority, giving precedence to the mounts manager configuration, making the user responsible for mapping drives. System calls will only be used if the drive is not explicitly configured by the user. I acknowledge that this is a breaking change, but I believe it enforces the correct behavior for GetDriveType. Resolves: https://forum.winehq.org/viewtopic.php?t=38909 -- v2: fix: passing wrong roots for get_mountmgr_drive_type https://gitlab.winehq.org/wine/wine/-/merge_requests/6553

2 2

[PATCH 0/1] MR6553: ntdll: make GetDriveType prioritize mount managers' config
by Robert Ayrapetyan (＠rayrapetyan) 24 Sep '24

24 Sep '24

The current implementation of the GetDriveTypeW/A function relies on native system calls (such as fstatfs() in Linux) to determine the actual type of the drive, disregarding any configuration set through the mounts manager (wincfg). This patch changes the priority, giving precedence to the mounts manager configuration, making the user responsible for mapping drives. System calls will only be used if the drive is not explicitly configured by the user. I acknowledge that this is a breaking change, but I believe it enforces the correct behavior for GetDriveType. Resolves: https://forum.winehq.org/viewtopic.php?t=38909 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6553

3 2

[PATCH 0/2] MR6541: wininet: Only include non-empty session user agent string in request headers.
by Andrew Nguyen (＠arethusa) 24 Sep '24

24 Sep '24

The WordSmith application downloads an update information file with wininet, but it fails to receive the correct data because the remote HTTP server returns a 503 error page, as it does not tolerate receiving a User-Agent header with a blank value in the request. Tests show that when a blank user agent string is passed to InternetOpen, a request created from the resulting session handle should not include a User-Agent header at all. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56875 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6541

4 4

[PATCH v5 0/6] MR6446: ntdll: Support process instrumentation callback.
by Paul Gofman (＠gofman) 24 Sep '24

24 Sep '24

-- v5: ntdll: Support old parameter layout for NtSetInformationProcess( ProcessInstrumentationCallback ). ntdll: Call instrumentation callback for KiUserModeCallback on x64. ntdll: Call instrumentation callback for LdrInitializeThunk on x64. ntdll: Call instrumentation callback for KiUserExceptionDispatcher on x64. ntdll: Call instrumentation callback from wine_syscall_dispatcher on x64. ntdll/tests: Add more tests for process instrumentation callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/6446

3 8

[PATCH v2 0/1] MR6552: server: Move last_active variable initialization (Valgrind).
by Aida Jonikienė (＠DodoGTA) 24 Sep '24

24 Sep '24

Fixes: 5b56bad50b8 ("server: Make window struct a server object.") -- v2: server: Move last_active variable initialization (Valgrind). https://gitlab.winehq.org/wine/wine/-/merge_requests/6552

2 1

[PATCH 0/1] MR6552: server: Move last_active variable initialization (Valgrind).
by Aida Jonikienė (＠DodoGTA) 24 Sep '24

24 Sep '24

Fixes: 5b56bad50b8 ("server: Make window struct a server object.") -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6552

3 3

[PATCH v7 0/1] MR5523: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW().
by Vijay Kiran Kamuju (＠infyquest) 24 Sep '24

24 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56576 -- v7: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5523

2 1

[PATCH v2 0/8] MR6551: winedmo: Convert H264 streams to Annex B format.
by Rémi Bernon (＠rbernon) 24 Sep '24

24 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57204 -- v2: winedmo: Convert H264 streams to Annex B format. winedmo: Pass demuxer packets through the bitstream filters. winedmo: Create bitstream filters for demuxer streams. winedmo: Move the last packet to the demuxer struct. winedmo: Allocate a dedicated demuxer structure. winedmo: Simplify demuxer creation error handling. winedmo: Hoist the demuxer input format. mfsrcsnk: Serialize stream sample requests with the state callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/6551

2 8

Re: [PATCH v6 0/7] MR6360: d3dx9: Beginning of pixel format handling changes.
by Matteo Bruni (＠Mystral) 24 Sep '24

24 Sep '24

On Tue Sep 24 12:38:50 2024 +0000, Connor McAdams wrote: > There was a time where I was using it because of floating point error, > but I've since removed that code and if that was something that needed > to be addressed again it would probably be better served by a `ulp` > argument in that structure somewhere. It'd also need a separate path > instead of just comparing pixels with `memcmp`. > I can remove this in my next patch series if that would make things > cleaner. :) Just let me know. It looks like Alexandre already got rid of `match_count` while merging this :smile: As for `partial_todo`, we can probably drop it next time we touch the test, just to keep it all tidy :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6360#note_83204

1 0

[PATCH 0/5] MR6544: dplayx, dpwsockx: Open() part 1.
by Anton Baskanov (＠baskanov) 24 Sep '24

24 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6544

4 7

[PATCH v7 0/9] MR6323: winewayland: Support GL/VK rendering in child windows (alt).
by Rémi Bernon (＠rbernon) 24 Sep '24

24 Sep '24

-- v7: winewayland: Let the render threads commit changes to client surfaces. winewayland: Attach client client surfaces to their toplevel surface. winewayland: Pass the client surface rect to wayland_surface_reconfigure_client. winewayland: Split wayland_win_data_update_wayland_surface helper. winewayland: Update the client separately from the window surface updates. winewayland: Keep the toplevel hwnd on the wayland_client_surface. winewayland: Call ensure_window_surface_contents with the toplevel window. winewayland: Use window DPI for the OpenGL client surface size. win32u: Notify drivers of the child surfaces state when their ancestor moves. https://gitlab.winehq.org/wine/wine/-/merge_requests/6323

3 11

[PATCH v3 0/1] MR6533: winegstreamer: Tweak h264 caps conversion.
by Rémi Bernon (＠rbernon) 24 Sep '24

24 Sep '24

-- v3: winegstreamer: Pass H264 codec data as streamheader. https://gitlab.winehq.org/wine/wine/-/merge_requests/6533

2 3

[PATCH 0/7] MR6551: winedmo: Convert H264 streams to Annex B format.
by Rémi Bernon (＠rbernon) 24 Sep '24

24 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57204 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6551

2 7

Re: [PATCH v6 0/7] MR6360: d3dx9: Beginning of pixel format handling changes.
by Connor McAdams (＠cmcadams) 24 Sep '24

24 Sep '24

On Mon Sep 23 21:04:28 2024 +0000, Alexandre Julliard wrote: > changed this line in [version 6 of the diff](/wine/wine/-/merge_requests/6360/diffs?diff_id=133886&start_sha=f960633327fa75a92f98dd32216545f535666144#d49071753fdf2ab21d518dbd8c720b48c7c732fc_1040_1040) There was a time where I was using it because of floating point error, but I've since removed that code and if that was something that needed to be addressed again it would probably be better served by a `ulp` argument in that structure somewhere. It'd also need a separate path instead of just comparing pixels with `memcmp`. I can remove this in my next patch series if that would make things cleaner. :) Just let me know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6360#note_83167

1 0

[PATCH v3 0/2] MR6514: comctl32: Implement MSAA events for buttons.
by Esme Povirk (＠madewokherd) 24 Sep '24

24 Sep '24

-- v3: comctl32/tests: Test MSAA events for buttons. https://gitlab.winehq.org/wine/wine/-/merge_requests/6514

4 4

[PATCH v2 0/6] MR6543: ntdll: Print error on failure to dlopen builtin shared object.
by Bernhard Übelacker (＠bernhardu) 24 Sep '24

24 Sep '24

Currently trying to dlopen winealsa.so, without having the matching libasound.so.2 installed, fails silently. This should make users aware of the missing dependency. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57206 -- v2: mmdevapi: Add error if no driver could be initialized. ntdll: Add warning if dlopen of unixlib failed. winecoreaudio.drv: Add warning if loading unixlib failed. wineoss.drv: Add warning if loading unixlib failed. winealsa.drv: Add warning if loading unixlib failed. winepulse.drv: Add warning if loading unixlib failed. https://gitlab.winehq.org/wine/wine/-/merge_requests/6543

3 8

[PATCH v4 0/6] MR6446: ntdll: Support process instrumentation callback.
by Paul Gofman (＠gofman) 24 Sep '24

24 Sep '24

-- v4: ntdll: Support old parameter layout for NtSetInformationProcess( ProcessInstrumentationCallback ). ntdll: Call instrumentation callback for KiUserModeCallback on x64. ntdll: Call instrumentation callback for LdrInitializeThunk on x64. ntdll: Call instrumentation callback for KiUserExceptionDispatcher on x64. ntdll: Call instrumentation callback from wine_syscall_dispatcher on x64. ntdll/tests: Add more tests for process instrumentation callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/6446

4 9

[PATCH 0/1] MR6550: winex11: Avoid recreating the offscreen GL window if not necessary.
by Rémi Bernon (＠rbernon) 24 Sep '24

24 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57215 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6550

2 1

[PATCH 0/2] MR6546: ODBC fixes
by Owen Rudge (＠orudge) 24 Sep '24

24 Sep '24

If no native ODBC library exists, this can result in a buffer overflow as the error message is (on macOS at least) too long. The second patch fixes an incorrect return value when `SQLGetDiagRec` is called without a connection being set up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6546

3 3

[PATCH 0/4] MR6549: ntdll: Implement NtSetInformationProcess( ProcessTlsInformation ) and use that in loader.
by Paul Gofman (＠gofman) 24 Sep '24

24 Sep '24

Test Driver Unlimited Solar Crown depends on that (both calling ProcessTlsInformation and hotpatches the same to fixup the thread local storage allocation from ntdll). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6549

3 6

[PATCH 0/1] MR6547: uxtheme: Better detect the presence of default transparent colour in prepare_alpha().
by Paul Gofman (＠gofman) 24 Sep '24

24 Sep '24

Fixes a regression introduced by c0bf67636ab3de46c67b8d02e44fb39b5853384a. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6547

3 6

Re: [PATCH v6 0/7] MR6360: d3dx9: Beginning of pixel format handling changes. - approved
by Alexandre Julliard (＠julliard) 23 Sep '24

23 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6360

1 0

Re: [PATCH v4 0/2] MR6548: nsiproxy: Only set the connection count from tcp_conns_enumerate_all/udp_endpoint_enumerate_all when appropriate. - approved
by Alexandre Julliard (＠julliard) 23 Sep '24

23 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6548

1 0

Re: [PATCH v2 0/4] MR6545: mfsrcsnk: Improve EOS handling and expose unknown streams. - approved
by Alexandre Julliard (＠julliard) 23 Sep '24

23 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6545

1 0

Re: [PATCH v2 0/6] MR6537: Cmd engine rewrite (part XXV) - approved
by Alexandre Julliard (＠julliard) 23 Sep '24

23 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6537

1 0

Re: [PATCH v25 0/12] MR6402: bluetoothapis: Implement basic SDP methods. - approved
by Alexandre Julliard (＠julliard) 23 Sep '24

23 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

1 0

Re: [PATCH v3 0/2] MR6536: mfplat: Fill user data when converting VIDEOINFOHEADER formats. - approved
by Alexandre Julliard (＠julliard) 23 Sep '24

23 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6536

1 0

Re: [PATCH v2 0/6] MR6539: ntdll: Implement RTL RB tree and use it in the loader. - approved
by Alexandre Julliard (＠julliard) 23 Sep '24

23 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6539

1 0

Re: [PATCH v4 0/1] MR6542: winedump: Dump CLR metadata. - approved
by Alexandre Julliard (＠julliard) 23 Sep '24

23 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6542

1 0

[PATCH v2 0/1] MR6533: Draft: winegstreamer: Tweak h264 caps conversion.
by Rémi Bernon (＠rbernon) 23 Sep '24

23 Sep '24

-- v2: winegstreamer: Pass H264 codec data as streamheader if it's not parsed yet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6533

3 4

[PATCH 0/1] MR6543: ntdll: Print error on failure to dlopen builtin shared object.
by Bernhard Übelacker (＠bernhardu) 23 Sep '24

23 Sep '24

Currently trying to dlopen winealsa.so, without having the matching libasound.so.2 installed, fails silently. This should make users aware of the missing dependency. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57206 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6543

3 3

[PATCH v5 0/7] MR6360: d3dx9: Beginning of pixel format handling changes.
by Connor McAdams (＠cmcadams) 23 Sep '24

23 Sep '24

This is the initial set of patches for handling new pixel format types. I've pushed a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/commits/WIP/d3dx-shared-sou… containing the rest of my current patches if additional context would be useful, the new format handling patches end with `ed7022a0838b346f4fa2b229ce7e8e6b8ebc2244`. -- v5: d3dx9: Use format_from_d3dx_color() instead of fill_texture(). d3dx9: Add support for D3DFMT_V8U8. d3dx9: Add support for D3DFMT_Q8W8V8U8. d3dx9: Store pixel value range alongside pixel values when reading pixels. d3dx9: Clamp source components to unorm range. d3dx9/tests: Add format conversion tests for premultiplied alpha DXTn formats. d3dx9/tests: Add more d3d format conversion tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6360

3 12

[PATCH v3 0/2] MR6548: nsiproxy: Only set the connection count from tcp_conns_enumerate_all/udp_endpoint_enumerate_all when appropriate.
by Tim Clem (＠tclem) 23 Sep '24

23 Sep '24

Fixes heap corruption downstream in NsiEnumerateObjectsAllParametersEx. Fixes regressions from 9085bc7b87f and a3f737f6143. --- I missed this piece of logic in MR !6399. The original line that implemented it is this: https://gitlab.winehq.org/wine/wine/-/blob/1d05064e747f9998fd705345659030e6… -- v3: nsiproxy: Only set the endpoint count from udp_endpoint_enumerate_all when appropriate. nsiproxy: Only set the connection count from tcp_conns_enumerate_all when appropriate. https://gitlab.winehq.org/wine/wine/-/merge_requests/6548

4 4

[PATCH v2 0/2] MR6548: nsiproxy: Only set the connection count from tcp_conns_enumerate_all/udp_endpoint_enumerate_all when appropriate.
by Tim Clem (＠tclem) 23 Sep '24

23 Sep '24

Fixes heap corruption downstream in NsiEnumerateObjectsAllParametersEx. Fixes regressions from 9085bc7b87f and a3f737f6143. --- I missed this piece of logic in MR !6399. The original line that implemented it is this: https://gitlab.winehq.org/wine/wine/-/blob/1d05064e747f9998fd705345659030e6… -- v2: nsiproxy: Only set the connection count from udp_endpoint_enumerate_all when appropriate. https://gitlab.winehq.org/wine/wine/-/merge_requests/6548

3 3

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Paul Gofman (＠gofman) 23 Sep '24

23 Sep '24

On Mon Sep 23 16:17:10 2024 +0000, Zephyr Lykos wrote: > Thanks! Thanks for letting me know and bisecting! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83050

1 0

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Zephyr Lykos (＠self) 23 Sep '24

23 Sep '24

On Mon Sep 23 16:13:24 2024 +0000, Paul Gofman wrote: > I sent a fix: https://gitlab.winehq.org/wine/wine/-/merge_requests/6547 Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83049

1 0

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Paul Gofman (＠gofman) 23 Sep '24

23 Sep '24

On Mon Sep 23 15:39:41 2024 +0000, Paul Gofman wrote: > Nevermind, I think I reproduced it (downloaded the theme from somewhere > and it looks like it is not supposed to be pink). I'll take a look. I sent a fix: https://gitlab.winehq.org/wine/wine/-/merge_requests/6547 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83046

1 0

[PATCH v6 0/9] MR6323: winewayland: Support GL/VK rendering in child windows (alt).
by Rémi Bernon (＠rbernon) 23 Sep '24

23 Sep '24

-- v6: winewayland: Let the render threads commit changes to client surfaces. winewayland: Attach client client surfaces to their toplevel surface. winewayland: Pass the client surface rect to wayland_surface_reconfigure_client. winewayland: Split wayland_win_data_update_wayland_surface helper. winewayland: Update the client separately from the window surface updates. winewayland: Keep the toplevel hwnd on the wayland_client_surface. winewayland: Call ensure_window_surface_contents with the toplevel window. winewayland: Use window DPI for the OpenGL client surface size. win32u: Notify drivers of the child surfaces state when their ancestor moves. https://gitlab.winehq.org/wine/wine/-/merge_requests/6323

3 13

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Paul Gofman (＠gofman) 23 Sep '24

23 Sep '24

On Mon Sep 23 15:19:03 2024 +0000, Paul Gofman wrote: > > This breaks `Luna.msstyles`: > Could you please give the full details how can I reproduce the issue: > - Wine doesn't have Luna mssstyle, how do you get and install it exactly? > - What is the exact problem, it is not apparent to me from the screenshot? Nevermind, I think I reproduced it (downloaded the theme from somewhere and it looks like it is not supposed to be pink). I'll take a look. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83038

1 0

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Paul Gofman (＠gofman) 23 Sep '24

23 Sep '24

> This breaks `Luna.msstyles`: Could you please give the full details how can I reproduce the issue: - Wine doesn't have Luna mssstyle, how do you get and install it exactly? - What is the exact problem, it is not apparent to me from the screenshot? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_83035

1 0

[PATCH v10 0/11] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 23 Sep '24

23 Sep '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan -- v10: wlanapi/tests: Add unit tests for WlanGetProfileList. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

3 12

[PATCH v9 0/11] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 23 Sep '24

23 Sep '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan -- v9: wlanapi/tests: Add unit tests for WlanGetProfileList. wlanapi: Add stub for WlanGetProfileList. wlanapi: Add NetworkManager backed implementation for WlanScan. wlanapi/tests: Add unit tests for WlanScan. wlanapi: Add NetworkManager backed implementation for WlanGetNetworkBssList. wlanapi/tests: Add unit test for test_WlanGetNetworkBssList. wlanapi: Add stub for WlanGetNetworkBssList. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

3 12

[PATCH v8 0/9] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 23 Sep '24

23 Sep '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan -- v8: wlanapi: Add stub for WlanGetProfileList. wlanapi: Add NetworkManager backed implementation for WlanScan. wlanapi/tests: Add unit tests for WlanScan. wlanapi: Add NetworkManager backed implementation for WlanGetNetworkBssList. wlanapi/tests: Add unit test for test_WlanGetNetworkBssList. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

3 10

[PATCH 0/4] MR6545: mfsrcsnk: Improve EOS handling and expose unknown streams.
by Rémi Bernon (＠rbernon) 23 Sep '24

23 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6545

2 4

[PATCH v2 0/2] MR6536: mfplat: Fill user data when converting VIDEOINFOHEADER formats.
by Rémi Bernon (＠rbernon) 23 Sep '24

23 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56975 -- v2: mfplat: Fill user data when converting VIDEOINFOHEADER formats. mfplat/tests: Add tests for VIDEOINFOHEADER(2) user data conversion. https://gitlab.winehq.org/wine/wine/-/merge_requests/6536

3 4

[PATCH v24 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 23 Sep '24

23 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v24: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. bluetoothapis: Add stub for BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetContainerElementData. bluetoothapis: Add stub for BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

3 14

[PATCH v3 0/1] MR6542: winedump: Dump CLR metadata.
by Hans Leidekker (＠hans) 23 Sep '24

23 Sep '24

-- v3: winedump: Dump CLR metadata. https://gitlab.winehq.org/wine/wine/-/merge_requests/6542

2 1

[PATCH v2 0/1] MR6542: winedump: Dump CLR metadata.
by Hans Leidekker (＠hans) 23 Sep '24

23 Sep '24

-- v2: winedump: Dump CLR metadata. https://gitlab.winehq.org/wine/wine/-/merge_requests/6542

2 1

[PATCH 0/1] MR6542: winedump: Dump CLR metadata.
by Hans Leidekker (＠hans) 23 Sep '24

23 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6542

2 1

[PATCH v3 0/12] MR6369: Draft: Refactor the async state flags
by Jinoh Kang (＠iamahuman) 22 Sep '24

22 Sep '24

-- v3: server: Eliminate async_alerted() helper function. server: Eliminate async_unknown_status() helper function. server: Remove "unknown_status" field from struct async. server: Remove "alerted" field from struct async. server: Remove "terminated" field from struct async. server: Remove "signaled" field from struct async. server: Remove "direct_result" field from struct async. server: Signal async unconditionally in async_set_result(). server: Introduce a new async state enum. https://gitlab.winehq.org/wine/wine/-/merge_requests/6369

2 12

[PATCH v6 0/8] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 22 Sep '24

22 Sep '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan -- v6: wlanapi: Add NetworkManager backed implementation for WlanScan. wlanapi/tests: Add unit tests for WlanScan. wlanapi: Add NetworkManager backed implementation for WlanGetNetworkBssList. wlanapi/tests: Add unit test for test_WlanGetNetworkBssList. wlanapi: Add NetworkManager backed implementation for WlanGetAvailableNetworkList. wlanapi/tests: Add unit test for WlanGetAvailableNetworkList. wlanapi: Add NetworkManager backed implementation for WlanEnumInterfaces. wlanapi: Add a basic unixlib implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

3 9

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Zephyr Lykos (＠self) 22 Sep '24

22 Sep '24

cc @gofman - any thoughts for a fix that does not affect performance too much? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_82962

1 0

Re: [PATCH v3 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Zephyr Lykos (＠mochaaP) 22 Sep '24

22 Sep '24

This breaks `Luna.msstyles`: ![luna.msstyles broken on 9.18](/uploads/83a195c4a2dc65cdd1c80754b7bbc86a/image.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6401#note_82961

1 0

[PATCH v23 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 21 Sep '24

21 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v23: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 13

[PATCH v22 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 21 Sep '24

21 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v22: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. bluetoothapis: Add stub for BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetContainerElementData. bluetoothapis: Add stub for BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 12

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Philipp Knechtges (＠d1saster) 21 Sep '24

21 Sep '24

On Wed Sep 18 15:58:22 2024 +0000, Nikolay Sivov wrote: > I think it is, because it will produce incorrect rendering. First > priority is to have it working correctly, then we can deal with possible duplication. TBH, I do not really know what to make of this assessment. Looking at the d2d1 tests it feels like, correctness is at best achieved approximately, and then the question arises what is the metric in which "correctness" is assessed? Unarguably, the tests as a metric are a moving target, depending on when which tests are added, thus making it a subjective choice at times. In my book, the patch at hand makes the rendering more correct in many cases. To be precise in all cases in which the individual geometries in the geometry group do not intersect, and thus the fill mode does not matter. Would you consider the patch sufficient, if it would (approximately) check for intersections and only copy if there are none, and falling back to old behavior (rendering just nothing) in case there are any (potentially false-positive) intersections? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_82945

1 0

[PATCH v21 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 21 Sep '24

21 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v21: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. bluetoothapis: Add stub for BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetContainerElementData. bluetoothapis: Add stub for BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 17

[PATCH v18 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 21 Sep '24

21 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v18: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. bluetoothapis: Add stub for BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetContainerElementData. bluetoothapis: Add stub for BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

3 14

[PATCH v2 0/12] MR6369: Draft: Refactor the async state flags
by Jinoh Kang (＠iamahuman) 21 Sep '24

21 Sep '24

-- v2: server: Eliminate async_alerted() helper function. server: Eliminate async_unknown_status() helper function. server: Remove "unknown_status" field from struct async. server: Remove "alerted" field from struct async. server: Remove "terminated" field from struct async. server: Remove "signaled" field from struct async. server: Remove "direct_result" field from struct async. server: Signal async unconditionally in async_set_result(). server: Introduce a new async state enum. server: Introduce async_unknown_status() helper to compute the 'unknown_status' flag. server: Introduce async_alerted() helper to compute the 'alerted' flag. server: Introduce async_terminated() helper to compute the 'terminated' flag. https://gitlab.winehq.org/wine/wine/-/merge_requests/6369

3 13

[PATCH v17 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 21 Sep '24

21 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v17: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. bluetoothapis: Add stub for BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetContainerElementData. bluetoothapis: Add stub for BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 12

[PATCH v16 0/12] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 21 Sep '24

21 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v16: bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add tests for BluetoothSdpGetAttributeValue. bluetoothapis: Add stub for BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes. bluetoothapis: Add stub for BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetContainerElementData. bluetoothapis: Add stub for BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. bluetoothapis/tests: Add tests for BluetoothSdpGetElementData. bluetoothapis: Add stub for BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 12

[PATCH v2 0/1] MR6540: localspl: Avoid crash when driver_load fails.
by Etaash Mathamsetty (＠etaash.mathamsetty) 21 Sep '24

21 Sep '24

-- v2: localspl: Avoid crash when driver_load fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/6540

3 2

[PATCH 0/1] MR6535: ntdll: Set correct MaximumLength when current directory path is longer than MAX_PATH.
by Owen Rudge (＠orudge) 21 Sep '24

21 Sep '24

Calls to `CreateProcessW` where the current directory is a path that exceeds `MAX_PATH` can result in `Length` exceeding `MaximumLength`, causing corruption in `alloc_process_params` when `append_unicode_string` copies the string according to `Length`, but only allocates `MaximumLength` of storage. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6535

3 4

[PATCH 0/6] MR6539: ntdll: Implement RTL RB tree and use it in the loader.
by Paul Gofman (＠gofman) 21 Sep '24

21 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6539

3 8

[PATCH v2 0/4] MR6526: Draft: propsys: Initially implement PropVariantToVariant.
by Ziqing Hui (＠zhui) 20 Sep '24

20 Sep '24

-- v2: propsys: Initially implement PropVariantToVariant. propsys: Support converting clsid to string for PropVariant. propsys/tests: Test converting clsid to string. propsys/tests: Add tests for PropVariantToVariant. https://gitlab.winehq.org/wine/wine/-/merge_requests/6526

3 7

[PATCH v15 0/6] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) 20 Sep '24

20 Sep '24

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v15: bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes and BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add unit tests for BluetoothSdpGetContainerElementData and BluetoothSdpGetElementData. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

3 35

Re: [PATCH v3 0/6] MR6534: dplayx: EnumSessions() part 4 - approved
by Alexandre Julliard (＠julliard) 20 Sep '24

20 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6534

1 0

Re: [PATCH v2 0/1] MR6531: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 20 Sep '24

20 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6531

1 0

Re: [PATCH v2 0/1] MR6528: netapi32: Add a stub NetFreeAadJoinInformation function.
by Louis Lenders (＠xe) 20 Sep '24

20 Sep '24

>It gracefully handles our ERROR_CALL_NOT_IMPLEMENTED from NetGetAadJoinInformation. Why is does it return ERROR_CALL_NOT_IMPLEMENTED when this is a HRESULT? Shouldn't it return E_NOTIMPL? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6528#note_82773

1 0

[PATCH v5 0/4] MR4443: Do not release media session topologies until the media session is shutdown.
by Santino Mazza (＠tati1454) 20 Sep '24

20 Sep '24

-- v5: mf: Shutdown all used topologies by media session. mf/tests: Test how session releases not queued topologies. mf: Only shutdown current topology when session is shutdown. mf/tests: Test for topology reuse after session ends. https://gitlab.winehq.org/wine/wine/-/merge_requests/4443

3 6

[PATCH 0/6] MR6537: Cmd engine rewrite (part XXV)
by eric pouech (＠epo) 20 Sep '24

20 Sep '24

This is part XXV of command engine rewrite. This MR tackles three items: - fixing some corner cases in variable expansion. Note, there's still todo_wine in the non regression tests, but I don't feel like fixing them for now (like an un-paired ! within double quotes when delayed expansion is enabled - which behaves differently then not within double quotes) - breaking out of FOR loops with 'EXIT /B'. I'm damn sure I dealt with this earlier on, it likely fails into the cracks during some rebase. - somme builtin commands behave differently when run from .BAT or .CMD files. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6537

3 7

[PATCH 0/1] MR6536: mfplat: Fill user data when converting VIDEOINFOHEADER formats.
by Rémi Bernon (＠rbernon) 20 Sep '24

20 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56975 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6536

3 2

[PATCH v2 0/6] MR6534: dplayx: EnumSessions() part 4
by Anton Baskanov (＠baskanov) 20 Sep '24

20 Sep '24

-- v2: dplayx: Check ENUMSESSIONSREPLY size before access. dplayx: Check the message size before access. dplayx/tests: Correctly compute session enumeration reply size. dplayx: Send password in session enumeration request. dplayx: Reduce nesting of the async enumeration code. https://gitlab.winehq.org/wine/wine/-/merge_requests/6534

4 10

Re: [PATCH v3 0/7] MR6517: mfsrcsnk: Read samples from the media source demuxer.
by Derek Lesho (＠dlesho) 20 Sep '24

20 Sep '24

On Wed Sep 18 13:32:52 2024 +0000, Rémi Bernon wrote: > Maybe, but I don't think it matters so much here. It's just reading > compressed samples here, so copy size stays relatively small. Do you intend on also enabling protonvideoconvert through winedmo? If so, wouldn't we have to do it in the demuxer (doesn't mp4 demuxer also require steam://unlockh264), at which point this might be relavant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6517#note_82731

1 0

[PATCH 0/6] MR6534: dplayx: EnumSessions() part 4
by Anton Baskanov (＠baskanov) 20 Sep '24

20 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6534

3 7

[PATCH 0/2] MR6533: winegstreamer: Tweak h264 caps conversion.
by Rémi Bernon (＠rbernon) 20 Sep '24

20 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6533

4 4

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Rémi Bernon (＠rbernon) 19 Sep '24

19 Sep '24

Virtualizing the swapchain is the better and more general plan and something we'd need to do for Wayland cross-process rendering anyway. Implementing composition on the win32u level will take care of it in a generic way, though we probably want to keep the direct rendering path as a default and best option. This current approach is a best effort with what we have right now, it unlocks various applications which required VK child window rendering, and is cheap enough and doesn't introduce much problems as it simply does the same as GL. Both GL and VK would then be addressed the same way for composition, through dma-buf export (or the equivalent macOS primitive) and shared resources. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82704

1 0

[PATCH 0/1] MR6527: dinput8: Prefer the native DLL.
by Aida Jonikienė (＠DodoGTA) 19 Sep '24

19 Sep '24

Many mod/ASI loaders hijack this DLL to do their work so accommodate this fairly common case by preferring their library. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6527

9 15

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Elizabeth Figura (＠zfigura) 19 Sep '24

19 Sep '24

> > VK_KHR_present_wait isn't equivalent, because it signals the event on first pixel out, which is too soon. > > That's unfortunate, I was thinking VK_KHR_present_wait will solve these problems (which are real WRT games too in some cases) until we have a "direct composition" implementation. Are you sure that this is supposed and actual behaviour? It's the spec behaviour, actually. I didn't test whether it works in practice, and it's not unlikely that it does work in practice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82702

1 0

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Paul Gofman (＠gofman) 19 Sep '24

19 Sep '24

> VK_KHR_present_wait isn't equivalent, because it signals the event on first pixel out, which is too soon. That's unfortunate, I was thinking VK_KHR_present_wait will solve these problems (which are real WRT games too in some cases) until we have a "direct composition" implementation. Are you sure that this is supposed and actual behaviour? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82701

1 0

[PATCH 0/1] MR6531: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 19 Sep '24

19 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6531

2 1

Re: [PATCH v3 0/5] MR6524: tools: Replace sprintf with snprintf to avoid deprecation warnings on macOS. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6524

1 0

Re: [PATCH v2 0/10] MR6529: desk.cpl: Introduce new control panel applet. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6529

1 0

Re: [PATCH v4 0/1] MR6372: winewayland: Make the pointer protocols optional. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6372

1 0

Re: [PATCH v2 0/1] MR6530: ntdll: Ensure Unix path strings are wrapped with debugstr_a in traces. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6530

1 0

2025

2024

2023

2022

wine-gitlab