- wine-gitlab - winehq.org

[PATCH 0/4] MR8097: server: Remove redundant `frame` parameter from redraw_window().
by Jinoh Kang (＠iamahuman) 20 May '25

20 May '25

Related: !8095 and !8013. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8097

3 6

Re: [PATCH v2 0/5] MR8093: msado15: Add support for obtaining base tables and views in _Recordset_Open. - approved
by Alexandre Julliard (＠julliard) 20 May '25

20 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8093

1 0

[PATCH v8 0/5] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon (＠rbernon) 20 May '25

20 May '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v8: server: Use an event sync for fd objects. server: Introduce a new event sync object. server: Redirect fd-based objects sync to the fd. server: Add an operation to retrieve an object sync. server: Move object grab/release out of (add|remove)_queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

3 7

Re: [PATCH v17 0/1] MR6199: winewayland: Fix release_all_keys's modifier filtering.
by Yuri Hérouard (＠yurih) 20 May '25

20 May '25

@rbernon @afrantzis anything wrong with this ? It is just a one liner. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6199#note_104022

1 0

[PATCH v5 0/1] MR8094: wbemprox: Return the SMBIOSTableData[] when querying SMBiosData.
by Louis Lenders (＠xe) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58243 -- v5: wbemprox: Return the SMBIOSTableData[] when querying SMBiosData. https://gitlab.winehq.org/wine/wine/-/merge_requests/8094

3 2

[PATCH v2 0/7] MR8090: amstream: Implement the custom ddraw stream allocator.
by Elizabeth Figura (＠zfigura) 20 May '25

20 May '25

-- v2: amstream: Return error when calling SetFormat with allocated samples. amstream: Implement the custom ddraw stream allocator. https://gitlab.winehq.org/wine/wine/-/merge_requests/8090

3 8

[PATCH v5 0/10] MR8047: dxcore: Implement IDXCoreAdapter::GetProperty(HardwareID).
by Mohamad Al-Jaf (＠maljaf) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58133 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58192 -- v5: dxcore: Implement IDXCoreAdapter::GetProperty(HardwareID). dxcore/tests: Add IDXCoreAdapter::GetProperty() tests. dxcore: Implement IDXCoreAdapterList::GetAdapter(). dxcore/tests: Add IDXCoreAdapterList::GetAdapter() tests. dxcore: Implement IDXCoreAdapterList::GetAdapterCount(). dxcore: Partially implement IDXCoreAdapterFactory::CreateAdapterList(). dxcore/tests: Add IDXCoreAdapterFactory::CreateAdapterList() tests. dxcore: Implement DXCoreCreateAdapterFactory(). dxcore/tests: Add DXCoreCreateAdapterFactory() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/8047

3 13

[PATCH v4 0/2] MR8094: wbemprox: Return the SMBIOSTableData[] when querying SMBiosData.
by Louis Lenders (＠xe) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58243 -- v4: v3 https://gitlab.winehq.org/wine/wine/-/merge_requests/8094

2 2

[PATCH v5 0/4] MR8095: server: Update full window invalidate rect with window resize.
by Rémi Bernon (＠rbernon) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58210 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38975 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8013 -- v5: server: Update fill window invalidate rect with window resize. server: Pass NULL as child region if region is NULL. server: Get rid of unnecessary frame parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/8095

4 6

Re: [PATCH v3 0/1] MR7982: winebus: Ignore mouse / keyboard hidraw devices by default.
by Matthew Tran (＠0e4ef622) 20 May '25

20 May '25

This broke some [mouse configuration software](https://www.endgamegear.com/en-us/downloads/op1w-4k) that uses HID to talk to the mouse. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7982#note_103984

1 0

[PATCH v4 0/4] MR8095: server: Update full window invalidate rect with window resize.
by Rémi Bernon (＠rbernon) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58210 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38975 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8013 -- v4: server: Update fill window invalidate rect with window resize. server: Pass NULL as child region if region is NULL. server: Get rid of unnecessary frame parameter. user32/tests: Add tests for NULL invalidated rect with window resize. https://gitlab.winehq.org/wine/wine/-/merge_requests/8095

4 11

[PATCH 0/1] MR8089: include: Add missing extern "C++" to guiddef.h
by Alfred Agrell (＠Alcaro) 20 May '25

20 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8089

3 3

[PATCH 0/1] MR8096: ntdll: Pass exception code to exception handlers in __C_specific_handler.
by Jacek Caban (＠jacek) 20 May '25

20 May '25

Fixes _exception_code() inside exception handlers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8096

2 1

[PATCH 0/1] MR8058: nsiproxy: Avoid buffer overflow in ipv4_neighbour_enumerate_all.
by Bernhard Übelacker (＠bernhardu) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57613 By writing beyond the end of the buffer some heap block list pointer gets partially overwritten, and therefore crashes on a later call to `RtlAllocateHeap`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8058

3 2

[PATCH v3 0/1] MR8094: wbemprox: Return the SMBIOSTableData[] when querying SMBiosData.
by Louis Lenders (＠xe) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58243 -- v3: wbemprox: Return the SMBIOSTableData[] when querying SMBiosData. https://gitlab.winehq.org/wine/wine/-/merge_requests/8094

3 2

[PATCH v2 0/4] MR8095: server: Update full window invalidate rect with window resize.
by Rémi Bernon (＠rbernon) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58210 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38975 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8013 -- v2: server: Update fill window invalidate rect with window resize. server: Pass NULL as child region if region is NULL. server: Get rid of unnecessary frame parameter. user32/tests: Add tests for NULL invalidated rect with window resize. https://gitlab.winehq.org/wine/wine/-/merge_requests/8095

4 9

[PATCH 0/4] MR8095: server: Update full window invalidate rect with window resize.
by Rémi Bernon (＠rbernon) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58210 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38975 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8013 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8095

4 8

[PATCH 0/2] MR8075: windows.networking.connectivity: Implement NetworkInformation IActivationFactory::GetRuntimeClassName().
by Mohamad Al-Jaf (＠maljaf) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58239 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8075

3 4

Re: [PATCH v2 0/1] MR8088: winebus: Fix detection of devices with no axis. - approved
by Rémi Bernon (＠rbernon) 20 May '25

20 May '25

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8088

1 0

[PATCH 0/1] MR8094: wbemprox: Return the SMBIOSTableData[] when querying SMBiosData.
by Louis Lenders (＠xe) 20 May '25

20 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58243 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8094

3 2

[PATCH 0/1] MR8023: gitlab: Skip d3d10core:d3d10core tests.
by Rémi Bernon (＠rbernon) 20 May '25

20 May '25

The test is often crashing since 11/04, possibly from an address space exhaustion on win32. We could perhaps include it instead with the 64bit tests, but it's also occasionally crashing there according to https://test.winehq.org/data/patterns.html#d3d10core:d3d10core and some other d3d tests are disabled already. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8023

3 4

Re: [PATCH v2 0/2] MR8045: comctl32: Implement EVENT_OBJECT_VALUECHANGE for trackbars.
by Rémi Bernon (＠rbernon) 20 May '25

20 May '25

The test is broken on most windows versions, see https://test.winehq.org/data/patterns.html#comctl32:trackbar -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8045#note_103934

1 0

[PATCH 0/1] MR8086: wbemprox: Only use IOCTL_DISK_GET_DRIVE_GEOMETRY_EX if GetDiskFreeSpaceExW() fails.
by Paul Gofman (＠gofman) 20 May '25

20 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8086

3 3

[PATCH 0/1] MR8076: dbghelpi,imagehlp: Don't dupe some exports on 64bit compilation.
by eric pouech (＠epo) 20 May '25

20 May '25

For a 32bit DLL, dbghelp exports both the 32bit and the 64bit variant of some APIs (eg. StackWalk, SymLoadModule...). For a 64bit DLL, only the 64bit variant is implemented and exported (the two names point to the same address in the export table). This patch: - uses the same function for both names (as native does) in .spec file for 64bit architecture - removes the 32bit variant from 64bit compilation, - adapts also the corresponding import:s in imagehlp from dbghelp. This mostly fixes 64bit apps, getting eg "StackWalk" address with GetProcAddress() and expecting a 64bit code path. (reported & tested by Stefan). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8076

3 6

[PATCH 0/5] MR8093: msado15: Add support for obtaining base tables and views in _Recordset_Open.
by Piotr Caban (＠piotr) 20 May '25

20 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8093

2 5

[PATCH 0/7] MR8090: amstream: Implement the custom ddraw stream allocator.
by Elizabeth Figura (＠zfigura) 20 May '25

20 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8090

4 9

[PATCH 0/1] MR8088: winebus: Fix detection of devices with no axis.
by Oleg Makarenko (＠JacKeTUs) 20 May '25

20 May '25

Currently Wine does not create device with no axis. They are detected by SDL. Such devices do exist, for example, shifters, button-boxes for various simulation games. Bug was introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/181, it doesn't enter in cycle if `axis_count` is 0. Changed cycle from `for` to `do while`, allowing device creation run at least once. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8088

2 1

[PATCH v2 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) 20 May '25

20 May '25

1. For %fs/fsbase the patch follows the macOS logic with LDT descriptor registration and Linux with switching. One notable difference is that on 32->64 transition we set %fs to GSEL(GUFS32_SEL, SEL_UPL) before restoring fsbase, otherwise FreeBSD will just revert it by reloading the selector [at the first opportunity](https://github.com/freebsd/freebsd-src/blob/5673462af5330df207…. GSEL(GUFS32_SEL, SEL_UPL) is the default %fs value on FreeBSD and is special-cased to save/restore actual fsbase value to/from PCB. 2. I was told we could get rid of fsbase glitches in signal handlers by blocking signals with [sigfastblock(2)](https://man.freebsd.org/cgi/man.cgi?query=sigfastblock) between %fs reset to the default value and fsbase reset to pthread_teb. This is currently a part of internal API for libthr, which could be exposed as pthread_signal_block_np for Wine. I'm on the fence whether it's worth it. 3. I fully admit I have no idea what registers are worth preserving around fallback sysarch(AMD64_SET_FSBASE) syscalls and whether it's appropriate to push those registers to stack. ("Kernel" stack should be fine, I assume?) Syscalls definitely clobber r8-r11. 4. For %ss see https://lkml.org/lkml/2015/4/24/216. FreeBSD doesn't have a similar workaround in the kernel, so it goes into Wine. -- v2: ntdll: Unbreak new wow64 mode on FreeBSD. https://gitlab.winehq.org/wine/wine/-/merge_requests/8073

2 1

[PATCH 0/1] MR8087: mountmgr.sys: Fill DiskNumber and ExtentLength for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS.
by Paul Gofman (＠gofman) 20 May '25

20 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8087

2 1

[PATCH 0/1] MR8068: makedep: Build implib code with guest compiler.
by Sasha Finkelstein (＠chaos_princess) 19 May '25

19 May '25

Some implibs contain code that indirectly includes winnt.h, which in turn contains NtGetCurrentTeb. On arm64 that is implemented by reading a global register variable. Gcc is perfectly fine with that, but clang complains that x18 is not a reserved register on linux. Signed-off-by: Sasha Finkelstein <fnkl.kernel(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8068

3 7

Re: [PATCH v7 0/1] MR8051: timeout/tests: Move the ctrl-c tests below an intermediate process. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8051

1 0

Re: [PATCH v4 0/2] MR8067: Fixes for compiler __try/__except support - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8067

1 0

Re: [PATCH v3 0/1] MR8035: user32: Restore the previous thread DPI awareness context before leaving CalcChildScroll(). - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8035

1 0

Re: [PATCH v2 0/1] MR8084: comctl32/taskdialog: Protect WM_COMMAND handler from partially initialized dialog. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8084

1 0

Re: [PATCH v2 0/2] MR8045: comctl32: Implement EVENT_OBJECT_VALUECHANGE for trackbars. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8045

1 0

Re: [PATCH v2 0/1] MR8081: opengl32: Move legacy extensions fixup from winex11. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8081

1 0

Re: [PATCH v2 0/1] MR8080: winex11: Remove unnecessary mutable_pf member. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8080

1 0

Re: [PATCH v3 0/1] MR8071: ucrtbase/tests: Avoid reading behind buffer in test_swprintf (ASan). - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8071

1 0

Re: [PATCH v7 0/1] MR8017: wined3d: Swap wined3d_resource.heap_pointer on swapchain present. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8017

1 0

Re: [PATCH v2 0/5] MR7973: wined3d: Move FFP extra states away from STATE_RENDER, part 4/4. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7973

1 0

Re: [PATCH v2 0/1] MR8069: gdiplus: Remove repeated points before widening paths. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8069

1 0

Re: [PATCH v3 0/5] MR8070: msado15: Recordset ActiveConnection related changes. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8070

1 0

Re: [PATCH v4 0/1] MR8072: oledb32: Skip whitespaces around properties names and values in datainit_GetDataSource. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8072

1 0

Re: [PATCH v2 0/1] MR8074: include: Avoid a C++ keyword. - approved
by Alexandre Julliard (＠julliard) 19 May '25

19 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8074

1 0

[PATCH v4 0/10] MR8047: dxcore: Implement IDXCoreAdapter::GetProperty( HardwareID ).
by Mohamad Al-Jaf (＠maljaf) 19 May '25

19 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58133 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58192 -- v4: dxcore: Implement IDXCoreAdapter::GetProperty( HardwareID ). dxcore/tests: Add IDXCoreAdapter::GetProperty() tests. dxcore: Implement IDXCoreAdapterList::GetAdapter(). dxcore/tests: Add IDXCoreAdapterList::GetAdapter() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/8047

4 12

[PATCH v3 0/6] MR8079: winex11: Serialize fullscreen/maximized and config changes.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- v3: winex11: Serialize managed window config change requests. winex11: Track pending_state.rect position / size independently. winex11: Serialize fullscreen/maximized and config changes. winex11: Serialize individual _NET_WM_STATE bit changes. winex11: Move managed window check to window_set_net_wm_state. winex11: Trace more window change request serials. https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

2 7

[PATCH 0/1] MR8085: oleaut32:Fix hdcBmp direct use pixels draw
by Maotong Zhang (＠xiaotong) 19 May '25

19 May '25

Convert HIMETRIC to pixels, hdcBmp direct use pixels draw -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8085

2 1

[PATCH v5 0/5] MR7997: windows.device.enumeration: Implement initial device enumeration for DeviceWatcher.
by Vibhav Pant (＠vibhavp) 19 May '25

19 May '25

After `DeviceWatcher::Start()` gets called, `DeviceWatcher` enumerates through a list of all `DeviceInformation` objects on the current system through the `Added` event handlers, dispatching `EnumerationCompleted` once this has finished. This MR implements this functionality. -- v5: windows.devices.enumeration: Implement initial device enumeration for DeviceWatcher::Start(). windows.devices.enumeration: Implement EnumerationCompleted handler for DeviceWatcher. windows.devices.enumeration: Implement CreateWatcher. windows.devices.enumeration: Implement Added handler for DeviceWatcher. windows.devices.enumeration: Add tests for initial device enumeration in DeviceWatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/7997

3 7

[PATCH v2 0/1] MR8035: misc: Fix two instances where the thread DPI awareness context is not saved/restored.
by Conor McCarthy (＠cmccarthy) 19 May '25

19 May '25

I'm pretty sure the user32 patch fixes a bug, but there may be a reason I'm not aware of for not saving/restoring in win32u `process_mouse_message()`. -- v2: https://gitlab.winehq.org/wine/wine/-/merge_requests/8035

3 2

[PATCH 0/1] MR8084: comctl32/taskdialog: Protect WM_COMMAND handler from partially initialized dialog.
by Nikolay Sivov (＠nsivov) 19 May '25

19 May '25

It's possible to get WM_COMMAND(BN_CLICKED) during initialization in taskdialog_init(), when window property is not yet set. Exceptions are swallowed on win32u transition. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8084

3 2

[PATCH v3 0/4] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) 19 May '25

19 May '25

-- v3: libs/ldap: Encrypted buffer layout is different for NTLM and Kerberos. libs/ldap: sasl_decode() should treat intput buffer as data + token. libs/ldap: sasl_encode() should construct output buffer as data + token. libs/ldap: When initializing security context ask for mutual authentication. https://gitlab.winehq.org/wine/wine/-/merge_requests/8020

4 8

[PATCH v3 0/2] MR8067: Fixes for compiler __try/__except support
by Jacek Caban (＠jacek) 19 May '25

19 May '25

This change allows building with compiler exception support enabled (`-DUSE_COMPILER_EXCEPTIONS`) on non-i386 targets. On i386, `_except_handler3` needs to be available. While we provide it as an import from the msvcrt DLLs, that's not sufficient for modules like kernel32. Making this work would likely require moving `_except_handler3` to `winecrt0`. In practice, this fixes the build with Clang, although the resulting binaries do not appear to be fully correct yet. Further investigation is needed, likely on the LLVM side. -- v3: https://gitlab.winehq.org/wine/wine/-/merge_requests/8067

2 2

[PATCH v2 0/3] MR8067: Fixes for compiler __try/__except support
by Jacek Caban (＠jacek) 19 May '25

19 May '25

This change allows building with compiler exception support enabled (`-DUSE_COMPILER_EXCEPTIONS`) on non-i386 targets. On i386, `_except_handler3` needs to be available. While we provide it as an import from the msvcrt DLLs, that's not sufficient for modules like kernel32. Making this work would likely require moving `_except_handler3` to `winecrt0`. In practice, this fixes the build with Clang, although the resulting binaries do not appear to be fully correct yet. Further investigation is needed, likely on the LLVM side. -- v2: winecrt0: Undefine USE_COMPILER_EXCEPTIONS in exception.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/8067

4 7

[PATCH 0/1] MR8078: windows.ui: Fix a double free.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

The object reference is actually held by ref_weak. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8078

5 10

[PATCH 0/3] MR8020: libs/ldap: Make GSS-SPNEGO SASL plugin work with LDAP server that uses Kerberos authentication.
by Dmitry Timoshkov (＠dmitry) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8020

3 45

[PATCH 0/2] MR8045: comctl32: Implement EVENT_OBJECT_VALUECHANGE for trackbars.
by Esme Povirk (＠madewokherd) 19 May '25

19 May '25

Unfortunately, this can't be properly tested because of todo's in the message sequence. The event does show up in response to TPM_SETPOS, at least. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8045

3 5

[PATCH 0/1] MR8081: opengl32: Move legacy extensions fixup from winex11.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8081

2 1

[PATCH 0/1] MR8080: winex11: Remove unnecessary mutable_pf member.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8080

2 1

[PATCH v2 0/1] MR8071: ucrtbase/tests: Avoid reading behind buffer in test_swprintf (ASan).
by Bernhard Übelacker (＠bernhardu) 19 May '25

19 May '25

The test `test_swprintf` creates an un-terminated buffer and calls `WideCharToMultiByte` without explicit srclen on it. This patch wraps the buffer into a struct providing a termination without modifying the test itself. <details> <summary>ASan output:</summary> ``` ================================================================= ==ucrtbase_test.exe==532==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ffac0 at pc 0x6ffffe845638 bp 0x7ffffe1ff030 sp 0x7ffffe1ff078 READ of size 24 at 0x7ffffe1ffac0 thread T0 #0 0x6ffffe845637 in wcslen C:/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/../sanitizer_common\sanitizer_common_interceptors.inc:7215:3 #1 0x6fffff7d1eff in lstrlenW .../wine/include/winbase.h:2574:5 #2 0x6fffff7d2a33 in WideCharToMultiByte .../wine/dlls/kernelbase/locale.c:7382:30 #3 0x000140016e6c in test_swprintf .../wine/dlls/ucrtbase/tests/printf.c:196:9 #4 0x000140015f3e in func_printf .../wine/dlls/ucrtbase/tests/printf.c:891:5 #5 0x00014002da0e in run_test .../wine/include/wine/test.h:765:5 #6 0x00014002d53a in main .../wine/include/wine/test.h:884:12 #7 0x00014002f005 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #8 0x6fffffc355be in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #9 0x6fffffdbbcc2 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004bcc2) Address 0x7ffffe1ffac0 is located in stack of thread T0 at offset 256 in frame #0 0x000140016b6f in test_swprintf .../wine/dlls/ucrtbase/tests/printf.c:176 This frame has 8 object(s): [32, 44) 'str_short' (line 177) [64, 80) 'str_justfit' (line 178) [96, 114) 'str_justfits' (line 179) [160, 182) 'str_muchlonger' (line 180) [224, 226) 'str_empty' (line 181) [240, 256) 'buffer' (line 184) [272, 280) 'narrow' (line 185) <== Memory access at offset 256 partially underflows this variable [304, 320) 'narrow_fmt' (line 185) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/include/winbase.h:2574:5 in lstrlenW Shadow bytes around the buggy address: 0x7ffffe1ff800: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff880: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff980: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 04 f2 f2 0x7ffffe1ffa00: 00 00 f2 f2 00 00 02 f2 f2 f2 f2 f2 00 00 06 f2 =>0x7ffffe1ffa80: f2 f2 f2 f2 02 f2 00 00[f2]f2 00 f2 f2 f2 00 00 0x7ffffe1ffb00: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffb80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 f8 f8 f8 f8 0x7ffffe1ffd00: f8 f8 f8 f8 f3 f3 f3 f3 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ``` </details> -- v2: ucrtbase/tests: Avoid reading behind buffer in test_swprintf (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/8071

3 4

[PATCH v2 0/2] MR8079: winex11: Serialize fullscreen/maximized and config changes.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- v2: winex11: Serialize fullscreen/maximized and config changes. winex11: Trace more window change request serials. https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

2 2

[PATCH 0/2] MR8079: winex11: Serialize fullscreen/maximized and config changes.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

2 2

[PATCH v6 0/1] MR8017: wined3d: Swap wined3d_resource.heap_pointer on swapchain present.
by Panayiotis Talianos (＠panintended) 19 May '25

19 May '25

wined3d_resource_free_sysmem() uses wined3d_resource.heap_pointer to deallocate wined3d_resource.heap_memory. Preserve pairing of heap_pointer/heap_memory to prevent deallocation of incorrect heap_memory. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57387 -- v6: wined3d: Swap wined3d_resource.heap_pointer on swapchain present. https://gitlab.winehq.org/wine/wine/-/merge_requests/8017

3 3

[PATCH 0/5] MR7973: wined3d: Move FFP extra states away from STATE_RENDER, part 4/4.
by Elizabeth Figura (＠zfigura) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7973

3 6

Re: [PATCH v2 0/2] MR8053: windows.ui: Implement IWeakReferenceSource for IUISettings.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Mon May 19 08:50:06 2025 +0000, Zhiyi Zhang wrote: > I will fix this. Thanks for spotting this. https://gitlab.winehq.org/wine/wine/-/merge_requests/8078 should fix it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8053#note_103801

1 0

Re: [PATCH v2 0/2] MR8053: windows.ui: Implement IWeakReferenceSource for IUISettings.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Mon May 19 08:23:31 2025 +0000, Nikolay Sivov wrote: > I don't think this works, see [1]. You're freeing the same thing using > two separate counters. My guess is that weak reference has to be a > separate object, main object would keep a regular reference to it, once > main thing is released it would clear itself from weak ref object. That > will be an indication to fail Resolve(). I doesn't seem necessary to > have multiple weak reference objects, that simplifies things. > [1] https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-05-06_wine-10.… I will fix this. Thanks for spotting this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8053#note_103799

1 0

Re: [PATCH v2 0/2] MR8053: windows.ui: Implement IWeakReferenceSource for IUISettings.
by Nikolay Sivov (＠nsivov) 19 May '25

19 May '25

Nikolay Sivov (@nsivov) commented about dlls/windows.ui/uisettings.c: > IUISettings3 IUISettings3_iface; > IUISettings4 IUISettings4_iface; > IUISettings5 IUISettings5_iface; > - LONG ref; > + IWeakReferenceSource IWeakReferenceSource_iface; > + IWeakReference IWeakReference_iface; > + LONG ref_strong; > + LONG ref_weak; > }; I don't think this works, see [1]. You're freeing the same thing using two separate counters. My guess is that weak reference has to be a separate object, main object would keep a regular reference to it, once main thing is released it would clear itself from weak ref object. That will be an indication to fail Resolve(). I doesn't seem necessary to have multiple weak reference objects, that simplifies things. [1] https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-05-06_wine-10.… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8053#note_103796

1 0

Re: [PATCH v45 0/2] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 May '25

19 May '25

Latest changes pushed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103790

1 0

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Mon May 19 00:58:42 2025 +0000, Zhiyi Zhang wrote: > I will send a fix. Thanks for spotting this. https://gitlab.winehq.org/wine/wine/-/merge_requests/8074 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060#note_103774

1 0

[PATCH 0/1] MR8074: include: Avoid a C++ keyword.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8074

2 1

[PATCH 0/1] MR8073: ntdll: Unbreak new wow64 mode on FreeBSD.
by Alexander Shaikhulin (＠shkhln) 19 May '25

19 May '25

1. For %fs/fsbase the patch follows the macOS logic with LDT descriptor registration and Linux with switching. One notable difference is that on 32->64 transition we set %fs to GSEL(GUFS32_SEL, SEL_UPL) before restoring fsbase, otherwise FreeBSD will just revert it by reloading the selector [at the first opportunity](https://github.com/freebsd/freebsd-src/blob/5673462af5330df207…. GSEL(GUFS32_SEL, SEL_UPL) is the default %fs value on FreeBSD and is special-cased to save/restore actual fsbase value to/from PCB. 2. I was told we could get rid of fsbase glitches in signal handlers by blocking signals with [sigfastblock(2)](https://man.freebsd.org/cgi/man.cgi?query=sigfastblock) between %fs reset to the default value and fsbase reset to pthread_teb. This is currently a part of internal API for libthr, which could be exposed as pthread_signal_block_np for Wine. I'm on the fence whether it's worth it. 3. I fully admit I have no idea what registers are worth preserving around fallback syscalls to sysarch(AMD64_SET_FSBASE) and whether it's appropriate to push those to stack. ("Kernel" stack should be fine, I assume?) They definitely clobber r8-r11. 4. For %ss see https://lkml.org/lkml/2015/4/24/216. We don't have a similar workaround in the kernel, so it goes into Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8073

2 2

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Sun May 18 07:29:08 2025 +0000, Biswapriyo Nath wrote: > This causes error in C++ > ``` > error: invalid parameter name: 'namespace' is a keyword > ``` I will send a fix. Thanks for spotting this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060#note_103770

1 0

[PATCH v3 0/1] MR8072: oledb32: Skip whitespaces around properties names and values in datainit_GetDataSource.
by Piotr Caban (＠piotr) 18 May '25

18 May '25

-- v3: oledb32: Remove leading whitespaces from property name in datainit_GetDataSource. https://gitlab.winehq.org/wine/wine/-/merge_requests/8072

2 1

[PATCH 0/1] MR8071: ucrtbase/tests: Avoid reading behind buffer in test_swprintf (ASan).
by Bernhard Übelacker (＠bernhardu) 18 May '25

18 May '25

The test `test_swprintf` creates an un-terminated buffer and calls `WideCharToMultiByte` without explicit srclen on it. This patch wraps the buffer into a struct providing a termination without modifying the test itself. <details> <summary>ASan output:</summary> ``` ================================================================= ==ucrtbase_test.exe==532==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ffac0 at pc 0x6ffffe845638 bp 0x7ffffe1ff030 sp 0x7ffffe1ff078 READ of size 24 at 0x7ffffe1ffac0 thread T0 #0 0x6ffffe845637 in wcslen C:/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/../sanitizer_common\sanitizer_common_interceptors.inc:7215:3 #1 0x6fffff7d1eff in lstrlenW .../wine/include/winbase.h:2574:5 #2 0x6fffff7d2a33 in WideCharToMultiByte .../wine/dlls/kernelbase/locale.c:7382:30 #3 0x000140016e6c in test_swprintf .../wine/dlls/ucrtbase/tests/printf.c:196:9 #4 0x000140015f3e in func_printf .../wine/dlls/ucrtbase/tests/printf.c:891:5 #5 0x00014002da0e in run_test .../wine/include/wine/test.h:765:5 #6 0x00014002d53a in main .../wine/include/wine/test.h:884:12 #7 0x00014002f005 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #8 0x6fffffc355be in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #9 0x6fffffdbbcc2 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004bcc2) Address 0x7ffffe1ffac0 is located in stack of thread T0 at offset 256 in frame #0 0x000140016b6f in test_swprintf .../wine/dlls/ucrtbase/tests/printf.c:176 This frame has 8 object(s): [32, 44) 'str_short' (line 177) [64, 80) 'str_justfit' (line 178) [96, 114) 'str_justfits' (line 179) [160, 182) 'str_muchlonger' (line 180) [224, 226) 'str_empty' (line 181) [240, 256) 'buffer' (line 184) [272, 280) 'narrow' (line 185) <== Memory access at offset 256 partially underflows this variable [304, 320) 'narrow_fmt' (line 185) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/include/winbase.h:2574:5 in lstrlenW Shadow bytes around the buggy address: 0x7ffffe1ff800: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff880: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff980: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 04 f2 f2 0x7ffffe1ffa00: 00 00 f2 f2 00 00 02 f2 f2 f2 f2 f2 00 00 06 f2 =>0x7ffffe1ffa80: f2 f2 f2 f2 02 f2 00 00[f2]f2 00 f2 f2 f2 00 00 0x7ffffe1ffb00: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffb80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 f8 f8 f8 f8 0x7ffffe1ffd00: f8 f8 f8 f8 f3 f3 f3 f3 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8071

3 2

[PATCH 0/1] MR8072: oledb32: Skip whitespaces around properties names and values in datainit_GetDataSource.
by Piotr Caban (＠piotr) 18 May '25

18 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8072

2 1

[PATCH 0/5] MR8070: msado15: Recordset ActiveConnection related changes.
by Piotr Caban (＠piotr) 18 May '25

18 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8070

2 5

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about include/consoleapi.h: > ULONG nLength; > ULONG nInitialChars; > ULONG dwCtrlWakeupMask; > - ULONG dwConsoleKeyState; this change (and the other ones using the correct field name) should be in a separate patch (inside the same merge request) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103751

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + > +static void set_cursor_visible(const HANDLE hOutput, const BOOL visible) > +{ > + CONSOLE_CURSOR_INFO cursorInfo; > + > + if (GetConsoleCursorInfo(hOutput, &cursorInfo)) { > + cursorInfo.bVisible = visible; > + SetConsoleCursorInfo(hOutput, &cursorInfo); > + } > +} > + > +static void build_search_string(WCHAR *inputBuffer, int len, SEARCH_CONTEXT *sc) > +{ > + int cc = 0, nn = 0; > + WCHAR *param = NULL, *last_param, *stripped_copy = NULL; > + WCHAR last_stripped_copy[MAX_PATH] = L"\0"; you likely want MAXSTRING here (native definitively works on strings longer than 260 chars) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103750

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + > +static void build_search_string(WCHAR *inputBuffer, int len, SEARCH_CONTEXT *sc) > +{ > + int cc = 0, nn = 0; > + WCHAR *param = NULL, *last_param, *stripped_copy = NULL; > + WCHAR last_stripped_copy[MAX_PATH] = L"\0"; > + BOOL need_wildcard = TRUE; > + > + sc->searchstr[0] = L'\0'; > + > + /* If inputBuffer ends in a space then the user hit tab beyond the last > + * parameter, so use that as the search pos (i.e. a wildcard search). > + * Otherwise, parse the buffer to find the last parameter in the buffer, > + * where tab was pressed. > + */ > + if (inputBuffer[len-1] == L' ') { len can be zero here (if \<tab\> is pressed at beg of line) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103749

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + clear_console_characters(hOutput, maxLen - len, lastConsoleInfo.dwSize.X); /* width at time of last console update */ > + } > + set_cursor_visible(hOutput, TRUE); > + > + /* Remember current dimensions in case user resizes console window. */ > + GetConsoleScreenBufferInfo(hOutput, &lastConsoleInfo); > + > + inputControl.nLength = sizeof(inputControl); > + inputControl.nInitialChars = len; > + inputControl.dwCtrlWakeupMask = (1 << '\t'); > + inputControl.dwControlKeyState = 0; > + > + /* Allow room for NULL terminator. inputBufferLength is at least 1 due to check above. */ > + ret = ReadConsoleW(hInput, inputBuffer, inputBufferLength - 1, numRead, &inputControl); > + > + if (ret) { I'd rather do `if (!ret) break;` so that you gain an indentation level afterwards -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103748

1 0

Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 18 May '25

18 May '25

eric pouech (@epo) commented about programs/cmd/wcmdmain.c: > + sc.have_quotes = FALSE; > + sc.user_specified_quotes = FALSE; > + sc.search_pos = 0; > + sc.insert_pos = 0; > + > + build_search_string(inputBuffer, curPos, &sc); > + TRACE("***** New search: [%s]\n", wine_dbgstr_w(sc.searchstr)); > + > + sc.is_dir_search = is_directory_operation(inputBuffer); > + > + free_directory_entry_list(&sc); > + build_directory_entry_list(&sc); > + } > + > + if (sc.entry_count) { > + get_next_matching_directory_entry(&sc, (inputControl.dwControlKeyState & SHIFT_PRESSED) ? TRUE : FALSE); when starting a new iteration ,you start on second element (index 1) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103747

1 0

[PATCH v6 0/1] MR8051: timeout/tests: Move the ctrl-c tests below an intermediate process.
by Bernhard Übelacker (＠bernhardu) 18 May '25

18 May '25

Failing gitlab CI examples are: - [job #157583](https://gitlab.winehq.org/wine/wine/-/jobs/157583#L2282) - [job #157314](https://gitlab.winehq.org/wine/wine/-/jobs/157314#L1957) - [job #157131](https://gitlab.winehq.org/wine/wine/-/jobs/157131#L2052) - [job #157068](https://gitlab.winehq.org/wine/wine/-/jobs/157068#L1955) - [job #157032](https://gitlab.winehq.org/wine/wine/-/jobs/157032#L2150) - [job #156785](https://gitlab.winehq.org/wine/wine/-/jobs/156785#L2112) - [job #156713](https://gitlab.winehq.org/wine/wine/-/jobs/156713#L2048) - [job 156677#](https://gitlab.winehq.org/wine/wine/-/jobs/156677#L2030) So happens just a few times per day. The value -1073741510 in `timeout.exe:timeout:06b4 done (-1073741510) in 5s 177B` equals to 0xC000013A, STATUS_CONTROL_C_EXIT. Therefore the assumption the ctrl-c from the test reaches sometimes the parent process. -- v6: timeout/tests: Move the ctrl-c tests below an intermediate process. https://gitlab.winehq.org/wine/wine/-/merge_requests/8051

3 3

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph.
by Biswapriyo Nath (＠Biswa96) 18 May '25

18 May '25

Biswapriyo Nath (@Biswa96) commented about include/d3d11shader.h: > +#undef INTERFACE > + > +DEFINE_GUID(IID_ID3D11FunctionLinkingGraph, 0x54133220, 0x1ce8, 0x43d3, 0x82, 0x36, 0x98, 0x55, 0xc5, 0xce, 0xec, 0xff); > + > +#define INTERFACE ID3D11FunctionLinkingGraph > +DECLARE_INTERFACE_(ID3D11FunctionLinkingGraph, IUnknown) > +{ > + STDMETHOD(QueryInterface)(THIS_ REFIID iid, void **out) PURE; > + STDMETHOD_(ULONG, AddRef)(THIS) PURE; > + STDMETHOD_(ULONG, Release)(THIS) PURE; > + > + /* ID3D11FunctionLinkingGraph methods */ > + STDMETHOD(CreateModuleInstance)(THIS_ ID3D11ModuleInstance **instance, ID3DBlob **error) PURE; > + STDMETHOD(SetInputSignature)(THIS_ const D3D11_PARAMETER_DESC *parameter_desc, UINT parameter_count, ID3D11LinkingNode **input_node) PURE; > + STDMETHOD(SetOutputSignature)(THIS_ const D3D11_PARAMETER_DESC *parameter_desc, UINT parameter_count, ID3D11LinkingNode **output_node) PURE; > + STDMETHOD(CallFunction)(THIS_ LPCSTR namespace, ID3D11Module *module, LPCSTR function_name, ID3D11LinkingNode **call_node) PURE; This causes error in C++ ``` error: invalid parameter name: 'namespace' is a keyword ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060#note_103738

1 0

[PATCH v3 0/10] MR8047: Draft: dxcore: Implement IDXCoreAdapterList::GetAdapterCount().
by Mohamad Al-Jaf (＠maljaf) 18 May '25

18 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58133 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58192 -- v3: dxcore: Implement IDXCoreAdapter::GetProperty( HardwareID ). dxcore/tests: Add IDXCoreAdapter::GetProperty() tests. dxcore: Implement IDXCoreAdapterList::GetAdapter(). dxcore/tests: Add IDXCoreAdapterList::GetAdapter() tests. dxcore: Implement IDXCoreAdapterList::GetAdapterCount(). dxcore: Partially implement IDXCoreAdapterFactory::CreateAdapterList(). dxcore/tests: Add IDXCoreAdapterFactory::CreateAdapterList() tests. dxcore: Implement DXCoreCreateAdapterFactory(). dxcore/tests: Add DXCoreCreateAdapterFactory() tests. include: Add dxcore C interface macros. https://gitlab.winehq.org/wine/wine/-/merge_requests/8047

2 11

[PATCH 0/1] MR8069: gdiplus: Remove repeated points before widening paths.
by Esme Povirk (＠madewokherd) 17 May '25

17 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58203 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8069

2 1

[PATCH 0/1] MR7920: winecoreaudio: Fallback to pre-per-channel audio if the audio device does not support it
by Ada Ahmed (＠yretenai) 17 May '25

17 May '25

I was able to replicate the issue seen in [Bug 58113](https://bugs.winehq.org/show_bug.cgi?id=58113) on my M1. The issue stems from the usage of AudioDevicePropertyVolumeScalar, which the audio driver for the M1 does not support (at least so it appears.) Using AudioObjectIsPropertySettable allows for fast checking for this situation, including preemptively disabling main channel audio if it appears to be unsupported. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7920

4 11

[PATCH 0/1] MR8031: winex11: Ensure initialized thread data in X11DRV_get_ic.
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 May '25

17 May '25

Intends to replace: https://gitlab.winehq.org/wine/wine-staging/-/blob/master/patches/winex11-i… This patch has been in proton for almost 2 years now, never realized the same code existed upstream, lol -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8031

3 4

[PATCH 0/3] MR8067: Fixes for compiler __try/__except support
by Jacek Caban (＠jacek) 17 May '25

17 May '25

This change allows building with compiler exception support enabled (`-DUSE_COMPILER_EXCEPTIONS`) on non-i386 targets. On i386, `_except_handler3` needs to be available. While we provide it as an import from the msvcrt DLLs, that's not sufficient for modules like kernel32. Making this work would likely require moving `_except_handler3` to `winecrt0`. In practice, this fixes the build with Clang, although the resulting binaries do not appear to be fully correct yet. Further investigation is needed, likely on the LLVM side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8067

3 4

Re: [PATCH v4 0/2] MR8006: windowscodecs/tests: Add some tests for multi-frame tiffs vs SUBFILETYPE tag.
by Nikolay Sivov (＠nsivov) 17 May '25

17 May '25

On Wed May 14 09:56:09 2025 +0000, Nikolay Sivov wrote: > Thank you. Hopefully !8040 helps. Looks like results are clean now, thanks again for letting me know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8006#note_103716

1 0

Re: [PATCH v5 0/1] MR8017: wined3d: Swap wined3d_resource.heap_pointer on swapchain present. - approved
by Elizabeth Figura (＠zfigura) 17 May '25

17 May '25

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8017

1 0

[PATCH v2 0/6] MR8047: dxcore: Implement IDXCoreAdapterList::GetAdapterCount().
by Mohamad Al-Jaf (＠maljaf) 17 May '25

17 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58133 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58192 -- v2: dxcore: Implement IDXCoreAdapterList::GetAdapterCount(). dxcore: Partially implement IDXCoreAdapterFactory::CreateAdapterList(). dxcore/tests: Add IDXCoreAdapterFactory::CreateAdapterList() tests. dxcore: Implement DXCoreCreateAdapterFactory(). dxcore/tests: Add DXCoreCreateAdapterFactory() tests. include: Add dxcore C interface macros. https://gitlab.winehq.org/wine/wine/-/merge_requests/8047

5 11

[PATCH v3 0/1] MR8063: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller
by Lorenzo Ferrillo (＠llde) 16 May '25

16 May '25

Application using Delphi runtime with Virtual-TreeView module, like xEdit, pass a NULL IDropSource to SHDoDragDrop, prevnting the drag and drop to works at all, when used in Windos Vista and above compatiblity mode, while windows xp compatibility mode works (as it use a dfferent system). Documentation stated that Windows Vista and above will create an internal IDropSource in this case. Creating a dummy IDropSource with minimal functionality allow the drag and drop to works using the default cursor. In case of xEdit it won't show the cell that it's being dragged like on windows, a functionality that require a full implementation of IDropSource::GiveFeedback and DragSourceHelper2::InitializeFromBitmap. Solve the functional part of #54923 I'm unsure on how to write tests for this. -- v3: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller https://gitlab.winehq.org/wine/wine/-/merge_requests/8063

2 1

[PATCH v2 0/1] MR8063: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller
by Lorenzo Ferrillo (＠llde) 16 May '25

16 May '25

Application using Delphi runtime with Virtual-TreeView module, like xEdit, pass a NULL IDropSource to SHDoDragDrop, prevnting the drag and drop to works at all, when used in Windos Vista and above compatiblity mode, while windows xp compatibility mode works (as it use a dfferent system). Documentation stated that Windows Vista and above will create an internal IDropSource in this case. Creating a dummy IDropSource with minimal functionality allow the drag and drop to works using the default cursor. In case of xEdit it won't show the cell that it's being dragged like on windows, a functionality that require a full implementation of IDropSource::GiveFeedback and DragSourceHelper2::InitializeFromBitmap. Solve the functional part of #54923 I'm unsure on how to write tests for this. -- v2: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller https://gitlab.winehq.org/wine/wine/-/merge_requests/8063

2 2

[PATCH 0/1] MR8063: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller
by Lorenzo Ferrillo (＠llde) 16 May '25

16 May '25

Application using Delphi runtime with Virtual-TreeView module, like xEdit, pass a NULL IDropSource to SHDoDragDrop, prevnting the drag and drop to works at all, when used in Windos Vista and above compatiblity mode, while windows xp compatibility mode works (as it use a dfferent system). Documentation stated that Windows Vista and above will create an internal IDropSource in this case. Creating a dummy IDropSource with minimal functionality allow the drag and drop to works using the default cursor. In case of xEdit it won't show the cell that it's being dragged like on windows, a functionality that require a full implementation of IDropSource::GiveFeedback and DragSourceHelper2::InitializeFromBitmap. Solve the functional part of #54923 I'm unsure on how to write tests for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8063

3 24

Re: [PATCH v2 0/4] MR8065: msado15: Make Fields part of rowset structure. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8065

1 0

Re: [PATCH v2 0/1] MR8064: winevulkan: Update to VK spec version 1.4.315. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8064

1 0

Re: [PATCH v2 0/1] MR8062: winebus: Skip device stop if it wasn't started. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8062

1 0

Re: [PATCH v2 0/1] MR7962: ntdll: Also relocate entry point for builtin modules. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7962

1 0

Re: [PATCH v2 0/2] MR8057: server: Support removing port from completion job. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8057

1 0

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph. - approved
by Alexandre Julliard (＠julliard) 16 May '25

16 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060

1 0

[PATCH 0/4] MR8065: msado15: Make Fields part of rowset structure.
by Piotr Caban (＠piotr) 16 May '25

16 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8065

2 4

2025

2024

2023

2022

wine-gitlab