- wine-gitlab - winehq.org

[PATCH v6 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 13 Aug '24

13 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v6: comctl32/tests: Add rebar chevron visibility test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

3 2

Re: [PATCH v9 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 13 Aug '24

13 Aug '24

On Mon Aug 12 13:09:54 2024 +0000, Zhiyi Zhang wrote: > Not all of the comments are addressed. > Also, please add an 's' at the end of "comctl32/test" so it becomes > "comctl32/tests: Add rebar chevron visibility test.". Fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78519

1 0

Re: [PATCH v9 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 13 Aug '24

13 Aug '24

On Tue Aug 13 07:07:08 2024 +0000, Ilia Docin wrote: > changed this line in [version 6 of the diff](/wine/wine/-/merge_requests/6075/diffs?diff_id=126213&start_sha=606f2f040764d020301d07abaa1e02fb21049343#382007f113cc98a69ffe5bb3875a73e4727dad0c_1217_1217) Fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78518

1 0

[PATCH v13 0/1] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Ilia Docin (＠IDocin) 13 Aug '24

13 Aug '24

-- v13: comctl32/listview: Add LVM_GETNEXTITEM test. https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

2 1

[PATCH v2 0/3] MR6114: odbc32: Addig basic support for ODBC v2.0 drivers.
by Alistair Leslie-Hughes (＠alesliehughes) 13 Aug '24

13 Aug '24

SQLFreeSTMT doesn't use the generic function as it cause a crash when the FreeHandle was called (mysql). -- v2: odbc32: Support Allocating SQL handles for ODBC v2 drivers. odbc32: SQLSetEnvAttr isnt supported in ODBC v2.0 odbc32: Support freeing SQL handles for ODBC v2 drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/6114

2 4

[PATCH 0/2] MR6247: odbc32 fix regressions
by Alistair Leslie-Hughes (＠alesliehughes) 13 Aug '24

13 Aug '24

This fixes two regression with the latest ODBC32 updates. - SQLAllocStmt is an ODBC v2 function, so use the SQLAllocHandle (odbc v3) by default. - SQLBindCol call the actual driver function (appears to be a copy paste mistake). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6247

3 4

Re: [PATCH v9 0/2] MR6186: comctl32/progress: Add states for progress bar. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

1 0

Re: [PATCH v2 0/5] MR6259: include: Add IWICStreamProvider definition. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6259

1 0

Re: [PATCH v6 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216

1 0

Re: [PATCH v2 0/1] MR6242: include: Move arm64ec_shared_info to winternl and point to it in the PEB. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6242

1 0

[PATCH v2 0/1] MR6253: win32u: Avoid crashing with nulldrv when creating offscreen surface.
by Rémi Bernon (＠rbernon) 12 Aug '24

12 Aug '24

-- v2: win32u: Avoid crashing with nulldrv when creating offscreen surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6253

3 2

Re: [PATCH v2 0/10] MR6257: mshtml: Add support for event prototype objects. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6257

1 0

Re: [PATCH v2 0/5] MR6258: ODBC improvements - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6258

1 0

Re: [PATCH v3 0/1] MR6256: win32u: Don't request a host window surface for child windows. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6256

1 0

Re: [PATCH v3 0/4] MR6165: widl: Propagate attrs to inner pointer types. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6165

1 0

Re: [PATCH v2 0/3] MR6003: win32u: Do not embolden heavy fonts. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6003

1 0

Re: [PATCH v3 0/4] MR6022: qcap: Delay setting v4l device format. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6022

1 0

Re: [PATCH v2 0/1] MR6250: user32: Implement EVENT_OBJECT_STATECHANGE for BM_SETSTYLE. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6250

1 0

Re: [PATCH v4 0/1] MR6119: printdlg: Allow button id psh1 for "Properties" button. - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6119

1 0

Re: [PATCH v2 0/3] MR6046: More Robust Child Font List Creation - approved
by Alexandre Julliard (＠julliard) 12 Aug '24

12 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6046

1 0

[PATCH v8 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 12 Aug '24

12 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v8: comctl32/treeview: Allow treeview parent to deny treeview expansion. comctl32/tests: Add test to check if treeview expansion can be denied. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

2 2

[PATCH 0/5] MR6259: include: Add IWICStreamProvider definition.
by Nikolay Sivov (＠nsivov) 12 Aug '24

12 Aug '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6259

4 7

[PATCH v5 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Tom Helander (＠thelande) 12 Aug '24

12 Aug '24

This merge request implements the `httpapi.dll` `HttpResponseSendEntityBody` function and associated tests. API documentation was written by me by paraphrasing/re-writing what I had read for the function from the MSDN documentation. I am adding this function to enable the remote API component of the Space Engineers Dedicated Server. Implementation notes: - I mainly copied the relevant portion of `HttpSendHttpResponse` for `HttpResponseSendEntityBody`. - I updated the `http_response` struct to add a field `response_flags` - This field tracks the flags passed in to `HttpSendHttpResponse` and `HttpResponseSendEntityBody`. - This was needed because the clean-up steps in `http.sys` need to be skipped when `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` is set. - I updated `HttpSendHttpResponse` to handle the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag by omitting the `Content-Length` header and setting the `response_flags` field in the `response` object passed to `http.sys`. - The `Content-Length` header is omitted by the Windows implementation and thus I omitted it here for conformance purposes. - I updated `http_send_response` in `http.sys` to skip the connection clean up steps if the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag was set. This works for both `HttpSendHttpResponse` and `HttpResponseSendEntityBody` as either could set the flag to continue to send more data. - It is not 100% clear to me what the cleanup steps are doing. In particular, I am uncertain what lines 1011-1016 and 1023-1027 are doing, but based on context it seemed appropriate to keep them with the other connection cleanup steps. For testing, I duplicated the existing `HttpSendHttpResponse` test but modified it to set the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag and then followed up with a call to `HttpResponseSendEntityBody` with new data. The validation ensures that data from both the initial response and follow up response are contained in the final response obtained via `recv()`. On Windows 11 this happens immediately without any delay, but in Wine I had to add a `Sleep(100)` to give enough time for the follow up response to be received in the socket buffer by the time the `recv()` call was made in the test. I could have looped the `recv()` call to collect all of the response, but that felt more complicated than adding a minor delay. The tests were verified against Windows 11 Pro (build 22621.3880). -- v5: httpapi: Implement HttpSendResponseEntityBody httpapi: Handle HTTP_SEND_RESPONSE_FLAG_MORE_DATA flag http.sys: Skip clean up if HTTP_SEND_RESPONSE_FLAG_MORE_DATA is set httpapi: Add tests for HttpResponseSendEntityBody https://gitlab.winehq.org/wine/wine/-/merge_requests/6216

4 7

[PATCH 0/4] MR6260: mshtml: Misc improvements and fixes.
by Gabriel Ivăncescu (＠insn) 12 Aug '24

12 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6260

2 4

[PATCH v7 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 12 Aug '24

12 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v7: comctl32/treeview: Allow treeview parent to deny treeview expansion. comctl32/tests: Add test to check if treeview expansion can be denied. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

3 5

Re: [PATCH v5 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Zhiyi Zhang (＠zhiyi) 12 Aug '24

12 Aug '24

On Fri Aug 9 19:33:22 2024 +0000, Ilia Docin wrote: > Sorry for the late response. Changed. Not all of the comments are addressed. Also, please add an 's' at the end of "comctl32/test" so it becomes "comctl32/tests: Add rebar chevron visibility test.". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78420

1 0

[PATCH 0/10] MR6257: mshtml: Add support for event prototype objects.
by Jacek Caban (＠jacek) 12 Aug '24

12 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6257

3 11

[PATCH 0/5] MR6258: ODBC improvements
by Hans Leidekker (＠hans) 12 Aug '24

12 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6258

2 5

[PATCH v2 0/1] MR6256: win32u: Don't request a host window surface for child windows.
by Rémi Bernon (＠rbernon) 12 Aug '24

12 Aug '24

Fixes: b9879d5adc1cd98a6ceb7d087c4533fdd487bedb Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6248 -- v2: win32u: Don't request a host window surface for child windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6256

2 1

[PATCH v7 0/2] MR4405: gdi32: Implement FixBrushOrgEx according to test.
by Bartosz Kosiorek (＠gang65) 12 Aug '24

12 Aug '24

More information about different Windows versions: https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversio… Verified with: https://testbot.winehq.org/JobDetails.pl?Key=139906 -- v7: win32u: Fix ExtCreateRegion when parameters are wrong. https://gitlab.winehq.org/wine/wine/-/merge_requests/4405

4 4

[PATCH 0/1] MR6256: win32u: Don't request a host window surface for child windows.
by Rémi Bernon (＠rbernon) 12 Aug '24

12 Aug '24

Fixes: b9879d5adc1cd98a6ceb7d087c4533fdd487bedb Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6248 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6256

2 1

[PATCH 0/3] MR6003: win32u: Do not embolden heavy fonts.
by Paul Gofman (＠gofman) 12 Aug '24

12 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6003

4 8

[PATCH v2 0/1] MR6249: dinput: Use the correct array index in keyboard_create_device().
by Aida Jonikienė (＠DodoGTA) 12 Aug '24

12 Aug '24

This fixes a segfault when launching NFS Underground. Fixes: f434ea12b83 ("dinput: Implement DIPROP_SCANCODE.") -- v2: dinput: Use the correct array index in keyboard_create_device(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6249

3 6

[PATCH 0/5] MR6254: win32u: Introduce a new window_rects struct.
by Rémi Bernon (＠rbernon) 12 Aug '24

12 Aug '24

Aggregating all the rects of a window, instead of storing and passing them separately. This is in order to make future changes easier, where we would pass monitor DPI rects in addition to window DPI rects to the drivers for DPI scaling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6254

2 5

[PATCH 0/1] MR6253: win32u: Avoid crashing with nulldrv when creating offscreen surface.
by Rémi Bernon (＠rbernon) 12 Aug '24

12 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6253

2 1

[PATCH v2 0/4] MR6233: winex11: Fix systray docked icons display.
by Rémi Bernon (＠rbernon) 12 Aug '24

12 Aug '24

And avoid triggering X11 errors with foreign windows. -- v2: winex11: Don't call X11DRV_SET_DRAWABLE with invalid drawable. winex11: Avoid moving embedded windows in the systray dock. win32u: Fix CreateWindowSurface call when updating layered surfaces. winex11: Check whether the window surface needs to be re-created. https://gitlab.winehq.org/wine/wine/-/merge_requests/6233

2 5

[PATCH v2 0/4] MR6022: qcap: Delay setting v4l device format.
by Paul Gofman (＠gofman) 12 Aug '24

12 Aug '24

-- v2: qcap: Delay setting v4l device format until stream start. quartz: Propagate graph start error in MediaControl_Run(). qcap/tests: Add a test for simultaneous video capture usage. qcap/tests: Fix test failure in testsink_Receive() on some hardware. https://gitlab.winehq.org/wine/wine/-/merge_requests/6022

3 8

[PATCH 0/1] MR6251: wineoss.drv: Fix work with synth devices
by Ivan Rozhuk (＠Ivan_83) 11 Aug '24

11 Aug '24

Same code used for synth and for MIDI devices, but it try to count Synth or MIDI device id from wine driver ID. After this change device id is stored in struct and always correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6251

3 3

[PATCH v2 0/4] MR6165: widl: Propagate attrs to inner pointer types.
by Elizabeth Figura (＠zfigura) 11 Aug '24

11 Aug '24

-- v2: widl: Propagate attrs to inner pointer types. widl: Ignore strings in is_embedded_complex(). widl: Get rid of the write_embedded_types() helper. widl: Explicitly check for top-level parameters before adding FC_ALLOCED_ON_STACK. https://gitlab.winehq.org/wine/wine/-/merge_requests/6165

4 8

[PATCH 0/1] MR6249: dinput: Use the correct array index in keyboard_create_device().
by Aida Jonikienė (＠DodoGTA) 11 Aug '24

11 Aug '24

This fixes a segfault when launching NFS Underground. Fixes: f434ea12b83 ("dinput: Implement DIPROP_SCANCODE.") -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6249

3 4

[PATCH 0/1] MR6250: user32: Implement EVENT_OBJECT_STATECHANGE for BM_SETSTYLE.
by Esme Povirk (＠madewokherd) 10 Aug '24

10 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6250

3 2

[PATCH 0/1] MR6248: winewayland: Add missing default surface fallback in WindowPosChanging().
by Aida Jonikienė (＠DodoGTA) 10 Aug '24

10 Aug '24

This fixes a blank window content issue that happens even with basic Wine programs. Fixes: b9879d5adc1 ("winewayland: Remove now unnecessary WindowPosChanging checks.") -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6248

3 2

[PATCH v3 0/1] MR6119: printdlg: Allow button id psh1 for "Properties" button.
by Fabian Maurer (＠DarkShadow44) 10 Aug '24

10 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55841 -- v3: printdlg: Allow button id psh1 for "Properties" button. https://gitlab.winehq.org/wine/wine/-/merge_requests/6119

4 4

Re: [PATCH v3 0/1] MR6198: gdi32: Bounds check EMF handle tables. - approved
by Alexandre Julliard (＠julliard) 10 Aug '24

10 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6198

1 0

[PATCH v2 0/1] MR6119: printdlg: Allow button id psh1 for "Properties" button.
by Fabian Maurer (＠DarkShadow44) 10 Aug '24

10 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55841 -- v2: printdlg: Allow button id psh1 for "Properties" button. https://gitlab.winehq.org/wine/wine/-/merge_requests/6119

3 3

[PATCH 0/3] MR6046: More Robust Child Font List Creation
by Danyil Blyschak (＠blyss) 10 Aug '24

10 Aug '24

In win32u/font.c's `create_child_font_list` function: - We remove the `ansi_cp` `MaximumCharacterSize` check since this is the current locale's codepage, not the font's codepage. This was preventing certain child fonts from being loaded when they should have been. - We include Microsoft Sans Serif as a child font, whereas previously we were only including its linked fonts as child font. - As a backup, we also add Tahoma (which should ship with Wine) and its linked fonts as child fonts in case Microsoft Sans Serif is not available. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6046

4 5

[PATCH v2 0/1] MR6198: gdi32: Bounds check EMF handle tables.
by Esme Povirk (＠madewokherd) 10 Aug '24

10 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45106 -- v2: gdi32: Bounds check EMF handle tables. https://gitlab.winehq.org/wine/wine/-/merge_requests/6198

4 4

Re: [PATCH v12 0/2] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Zhiyi Zhang (＠zhiyi) 10 Aug '24

10 Aug '24

On Fri Aug 9 21:57:26 2024 +0000, Ilia Docin wrote: > Sorry for the late response. But how does it pass without fix if the > feature branch has that fix and the pipeline runs on the feature branch? > Besides, I checked locally that without fix the test failed with: > listview.c:7262: Test failed: Expected -1, got 3 You should add the tests and mark the tests that are failing on wine with todo_wine. Then in the next patch that fixes the bug, remove those todo_wines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78275

1 0

[PATCH v4 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Tom Helander (＠thelande) 10 Aug '24

10 Aug '24

This merge request implements the `httpapi.dll` `HttpResponseSendEntityBody` function and associated tests. API documentation was written by me by paraphrasing/re-writing what I had read for the function from the MSDN documentation. I am adding this function to enable the remote API component of the Space Engineers Dedicated Server. Implementation notes: - I mainly copied the relevant portion of `HttpSendHttpResponse` for `HttpResponseSendEntityBody`. - I updated the `http_response` struct to add a field `response_flags` - This field tracks the flags passed in to `HttpSendHttpResponse` and `HttpResponseSendEntityBody`. - This was needed because the clean-up steps in `http.sys` need to be skipped when `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` is set. - I updated `HttpSendHttpResponse` to handle the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag by omitting the `Content-Length` header and setting the `response_flags` field in the `response` object passed to `http.sys`. - The `Content-Length` header is omitted by the Windows implementation and thus I omitted it here for conformance purposes. - I updated `http_send_response` in `http.sys` to skip the connection clean up steps if the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag was set. This works for both `HttpSendHttpResponse` and `HttpResponseSendEntityBody` as either could set the flag to continue to send more data. - It is not 100% clear to me what the cleanup steps are doing. In particular, I am uncertain what lines 1011-1016 and 1023-1027 are doing, but based on context it seemed appropriate to keep them with the other connection cleanup steps. For testing, I duplicated the existing `HttpSendHttpResponse` test but modified it to set the `HTTP_SEND_RESPONSE_FLAG_MORE_DATA` flag and then followed up with a call to `HttpResponseSendEntityBody` with new data. The validation ensures that data from both the initial response and follow up response are contained in the final response obtained via `recv()`. On Windows 11 this happens immediately without any delay, but in Wine I had to add a `Sleep(100)` to give enough time for the follow up response to be received in the socket buffer by the time the `recv()` call was made in the test. I could have looped the `recv()` call to collect all of the response, but that felt more complicated than adding a minor delay. The tests were verified against Windows 11 Pro (build 22621.3880). -- v4: httpapi: Implement HttpSendResponseEntityBody httpapi: Handle HTTP_SEND_RESPONSE_FLAG_MORE_DATA flag http.sys: Skip clean up if HTTP_SEND_RESPONSE_FLAG_MORE_DATA is set httpapi: Add tests for HttpResponseSendEntityBody https://gitlab.winehq.org/wine/wine/-/merge_requests/6216

3 8

Re: [PATCH v2 0/1] MR6245: user32: Implement EVENT_OBJECT_STATECHANGE for BM_SETCHECK. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6245

1 0

Re: [PATCH v2 0/1] MR6229: winegstreamer/quartz_parser: Handle 0 size in read_thread. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6229

1 0

Re: [PATCH v15 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

1 0

Re: [PATCH v2 0/2] MR6240: dinput: Implement DIPROP_SCANCODE. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6240

1 0

Re: [PATCH v2 0/5] MR6237: win32u: Remove now unnecessary WindowPosChanging checks and UpdateLayeredWindow params. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6237

1 0

Re: [PATCH v2 0/11] MR6239: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 5). - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6239

1 0

Re: [PATCH v2 0/10] MR6236: mshtml: Add support for style objects prototypes. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6236

1 0

Re: [PATCH v2 0/5] MR6235: include: Add codecapi defines. - approved
by Alexandre Julliard (＠julliard) 09 Aug '24

09 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6235

1 0

[PATCH v4 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v4: comctl32/test: Add rebar chevron visibility test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

3 6

[PATCH v3 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v3: comctl32/rebar: Add chevron test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

3 2

[PATCH v11 0/2] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

-- v11: comctl32/listview: Do not return items count on getting next item for last one. comctl32/listview: Add LVM_GETNEXTITEM test. https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

2 3

[PATCH v10 0/2] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

-- v10: comctl32/listview: Do not return items count on getting next item for last one. comctl32/listview: Add LVM_GETNEXTITEM test. https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

2 4

[PATCH 0/1] MR6246: ntdll: Call the exception preparation callback on ARM64EC.
by Billy Laws (＠bylaws) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6246

3 2

[PATCH 0/1] MR6198: gdi32: Bounds check EMF handle tables.
by Esme Povirk (＠madewokherd) 09 Aug '24

09 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45106 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6198

4 4

[PATCH 0/1] MR6245: user32: Implement EVENT_OBJECT_STATECHANGE for BM_SETCHECK.
by Esme Povirk (＠madewokherd) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6245

2 1

[PATCH v41 0/8] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 09 Aug '24

09 Aug '24

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v41: win32u: Handle dbus notification balloons from system_tray_call win32u: Handle notification balloons through org.freedesktop.Notifications dbus interface win32u: Add a ShowBalloon driver interface win32u: Handle StatusNotifierItem management from system_tray_call win32u: Handle StatusNotifierWatcher owner changing and registering objects to a new watcher win32u: Add SNI driver for systray handling win32u: Add DBus event loop for SNI handling win32u: Add a SystrayRunLoop driver interface https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

5 19

[PATCH 0/1] MR6229: winegstreamer/quartz_parser: Handle 0 size in read_thread.
by Ziqing Hui (＠zhui) 09 Aug '24

09 Aug '24

Calling IAsyncReader_SyncRead() with 0 size may fails, but we should not return error with 0 size, so we handle it earlier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6229

3 2

Re: [PATCH v3 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Elizabeth Figura (＠zfigura) 09 Aug '24

09 Aug '24

Thanks for the patch! Other than a couple of style nitpicks it looks good. > I could have looped the `recv()` call to collect all of the response, but that felt more complicated than adding a minor delay. The tests were verified against Windows 11 Pro (build 22621.3880). I think it'd still be preferable, though. 100 ms isn't a lot, but those kinds of sleeps can build up, and we do want our tests to be as quick as possible. Perhaps more concerningly, if the timing is particularly bad, and 100 ms isn't enough, we'll get intermittent failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216#note_78212

1 0

Re: [PATCH v3 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Elizabeth Figura (＠zfigura) 09 Aug '24

09 Aug '24

Elizabeth Figura (@zfigura) commented about dlls/http.sys/http.c: > { > if (send(conn->socket, response->buffer, response->len, 0) >= 0) > { > - if (conn->content_len) > - { > - /* Discard whatever entity body is left. */ > - memmove(conn->buffer, conn->buffer + conn->content_len, conn->len - conn->content_len); > - conn->len -= conn->content_len; > + /* Clean up the connection if we are not sending more response data. */ > + if (response->response_flags != HTTP_SEND_RESPONSE_FLAG_MORE_DATA) { Brace on a new line, please, to match the existing style. There's another instance in 4/4. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216#note_78211

1 0

[PATCH v5 0/1] MR6191: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux
by Haoran Wang (＠Low-power) 09 Aug '24

09 Aug '24

Tested using C&C Red Alert 2; selection of interface and network communication worked as expected. IPX traffic correctly sent to the selected interface only, as confirmed by **tcpdump(8)**. ![ra2-on-linux-with-multiple-ipx-interfaces](/uploads/7755db6a7b82a21050623d3ccd9ec37e/ra2-on-linux-with-multiple-ipx-interfaces.png) -- v5: ws2_32: Fully implement socket options IPX_ADDRESS and IPX_MAX_ADAPTER_NUM on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/6191

4 4

[PATCH 0/1] MR6242: include: Move arm64ec_shared_info to winternl and point to it in the PEB.
by Billy Laws (＠bylaws) 09 Aug '24

09 Aug '24

From phnt headers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6242

3 2

[PATCH 0/1] MR6241: ntdll: Initialize dll search paths before WOW64 init.
by Billy Laws (＠bylaws) 09 Aug '24

09 Aug '24

GetModuleHandle succeeds when called from WOW64 module callbacks on Windows but without this it would crash on wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6241

2 1

[PATCH v14 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v14: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 4

[PATCH 0/2] MR6240: dinput: Implement DIPROP_SCANCODE.
by Rémi Bernon (＠rbernon) 09 Aug '24

09 Aug '24

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6223. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6240

3 4

[PATCH v13 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v13: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

3 3

[PATCH v6 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v6: comctl32/treeview: Allow treeview parent to deny treeview expansion. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

4 4

Re: [PATCH v2 0/2] MR6223: dinput: Implement DIPROP_SCANCODE. - closed
by Rémi Bernon (＠rbernon) 09 Aug '24

09 Aug '24

This merge request was closed by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6223

1 0

Re: [PATCH v2 0/2] MR6223: dinput: Implement DIPROP_SCANCODE.
by Rémi Bernon (＠rbernon) 09 Aug '24

09 Aug '24

Thanks, I've made a couple of adjustments and opened https://gitlab.winehq.org/wine/wine/-/merge_requests/6240 instead. The mapping looks completely straightforward, regardless of the keyboard layout, and I changed it to simplify the changes. This is the case at least for standard keyboard types. We have supposedly some support of JP106 keyboard types but I don't think this is working enough to worry about it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6223#note_78188

1 0

[PATCH v8 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 09 Aug '24

09 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- v8: comctl32/progress: Add states for progress bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

3 3

[PATCH 0/11] MR6239: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 5).
by Hans Leidekker (＠hans) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6239

2 11

[PATCH 0/5] MR6237: win32u: Remove now unnecessary WindowPosChanging checks and UpdateLayeredWindow params.
by Rémi Bernon (＠rbernon) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6237

2 5

Re: [PATCH v3 0/10] MR6230: mshtml: Support more node prototype objects.
by Jacek Caban (＠jacek) 09 Aug '24

09 Aug '24

On Fri Aug 9 00:00:38 2024 +0000, Nicholas Ansell wrote: > ```suggestion:-0+0 > .name = "CharacterData", > ``` Good catch, thanks. I sent a patch in !6236 that allows skipping the name for objects that have IDs, which should prevent such typos in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6230#note_78155

1 0

[PATCH 0/10] MR6236: mshtml: Add support for style objects prototypes.
by Jacek Caban (＠jacek) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6236

2 10

[PATCH 0/5] MR6235: include: Add codecapi defines.
by Ziqing Hui (＠zhui) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6235

3 8

[PATCH v12 0/1] MR5957: win32u: fix random crash without libfreetype
by Fan WenJie (＠fanwenjie) 09 Aug '24

09 Aug '24

without freetype, some calling return failed, so some value may not be initialized (it initialize by some failed calling and pass argument by point of it), it would cause random crash! Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v12: win32u: fix random crash without libfreetype https://gitlab.winehq.org/wine/wine/-/merge_requests/5957

2 1

Re: [PATCH v3 0/10] MR6230: mshtml: Support more node prototype objects.
by Nicholas Ansell (＠roadrunnerto) 09 Aug '24

09 Aug '24

Nicholas Ansell (@roadrunnerto) commented about dlls/mshtml/htmltextnode.c: > .clone = HTMLDOMTextNode_clone > }; > > -static const dispex_static_data_vtbl_t HTMLDOMTextNode_dispex_vtbl = { > +dispex_static_data_t CharacterData_dispex = { > + .name = "CharactedData", ```suggestion:-0+0 .name = "CharacterData", ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6230#note_78148

1 0

Re: [PATCH v2 0/2] MR6228: win32u: Always enumerate the primary source first. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6228

1 0

Re: [PATCH v2 0/1] MR6234: win32u: Always use the dummy surface if a surface isn't needed. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6234

1 0

Re: [PATCH v3 0/10] MR6230: mshtml: Support more node prototype objects. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6230

1 0

Re: [PATCH v2 0/1] MR6232: ntdll: Use the module debug channel in virtual_map_builtin_module(). - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6232

1 0

Re: [PATCH v2 0/1] MR6205: d3dx9/effect: Return creator string from GetDesc(). - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6205

1 0

Re: [PATCH v4 0/9] MR6157: d3dx9: More miscellaneous fixes. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6157

1 0

Re: [PATCH v2 0/7] MR6231: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 4). - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6231

1 0

Re: [PATCH v2 0/2] MR6226: mmdevapi: Implement control_GetSessionIdentifier / control_GetSessionInstanceIdentifier. - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6226

1 0

Re: [PATCH v2 0/1] MR6224: mmdevapi: Unlock session in create_session_enumerator(). - approved
by Alexandre Julliard (＠julliard) 08 Aug '24

08 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6224

1 0

[PATCH v2 0/1] MR2657: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth..
by Aleksey Komarov (＠q4a) 08 Aug '24

08 Aug '24

General idea of this test is to show that a lot of factors influence the fog when transformed and untransformed vertex format was used: - Directly changing z and w (which is not equal in the corners). - Changing projection matrix that change z and w. - Using different programmable/ff vs/ps shader. - Using different depth bias. - Chaging depth in pixel shader (oDepth) may or may not affect to colors depending on the vendor implementation. - And various combinations of above. This gives `succ` in all cases on this configs: - Windows 10 with Radeon HD 8400 or Ivy Bridge GT1 (Intel HD Graphics). - Windows 7 with Radeon HD 6450. - Windows XP with GeForce Go 7300. -- v2: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth.. https://gitlab.winehq.org/wine/wine/-/merge_requests/2657

8 17

[PATCH 0/1] MR6234: win32u: Always use the dummy surface if a surface isn't needed.
by Rémi Bernon (＠rbernon) 08 Aug '24

08 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57033 We don't need a surface when the drawing rect is empty, and it can even FPE if we use one. Release any previously created surface in this case and use the dummy surface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6234

2 1

[PATCH 0/5] MR6233: winex11: Fix systray docked icons display.
by Rémi Bernon (＠rbernon) 08 Aug '24

08 Aug '24

And avoid triggering X11 errors with foreign windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6233

2 5

[PATCH 0/1] MR6232: ntdll: Use the module debug channel in virtual_map_builtin_module().
by Sven Baars (＠sbaars) 08 Aug '24

08 Aug '24

Not sure if this is useful for anyone else, but this is the second time this warn would have saved me at least an hour. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6232

3 2

[PATCH 0/1] MR6205: d3dx9/effect: Return creator string from GetDesc().
by Nikolay Sivov (＠nsivov) 08 Aug '24

08 Aug '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6205

4 3

[PATCH v3 0/9] MR6157: d3dx9: More miscellaneous fixes.
by Connor McAdams (＠cmcadams) 08 Aug '24

08 Aug '24

-- v3: d3dx9: Validate filter argument in texture from file functions. d3dx9: Validate filter argument in D3DXLoadSurfaceFrom{Surface,FileInMemory,Memory}(). d3dx9: Validate filter argument in D3DXLoadVolumeFrom{Volume,FileInMemory,Memory}(). d3dx9: Further validate filter argument passed to D3DXFilterTexture(). d3dx9: Introduce helper function for retrieving the mip filter value in texture from file functions. d3dx9/tests: Add d3dx filter argument value tests. d3dx9: Return failure from D3DXLoadSurfaceFromMemory() if d3dx_load_pixels_from_pixels() fails. d3dx9: Return success in D3DXLoadSurfaceFromMemory() for multisampled destination surfaces. d3dx9/tests: Add tests for D3DXLoadSurfaceFromMemory() with a multisampled surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6157

4 16

2025

2024

2023

2022

wine-gitlab