- wine-gitlab - winehq.org

Re: [PATCH v4 0/1] MR6087: iphlpapi: Add stub for SetCurrentThreadCompartmentId. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6087

1 0

Re: [PATCH v2 0/1] MR6110: gdi32: Fix out-of-bounds write in EMR_ALPHABLEND handling. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6110

1 0

Re: [PATCH v2 0/2] MR6139: ntdll: Optimize NtReadVirtualMemory for in-process reads. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6139

1 0

Re: [PATCH v2 0/1] MR6197: maintainers: Remove shdocvw from WebBrowser control section. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6197

1 0

Re: [PATCH v2 0/1] MR6196: msvcrt: Reuse standard streams after they are closed. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6196

1 0

Re: [PATCH v2 0/1] MR6196: msvcrt: Reuse standard streams after they are closed. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6196

1 0

Re: [PATCH v2 0/9] MR6195: mshtml: Initial constructors and prototypes implementation. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6195

1 0

Re: [PATCH v2 0/7] MR6194: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 3). - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6194

1 0

Re: [PATCH v2 0/3] MR6193: mmdevapi: Implement IAudioSessionEnumerator. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6193

1 0

Re: [PATCH v2 0/1] MR6192: jscript: Implement arguments.caller. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6192

1 0

Re: [PATCH v10 0/2] MR6160: comctl32: Fix sorting for listview. - approved
by Alexandre Julliard (＠julliard) 02 Aug '24

02 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

1 0

[PATCH v2 0/9] MR6157: d3dx9: More miscellaneous fixes.
by Connor McAdams (＠cmcadams) 02 Aug '24

02 Aug '24

-- v2: d3dx9: Introduce helper function for retrieving the mip filter value in texture from file functions. d3dx9: Validate filter argument value in texture from file functions. d3dx9: Handle default filter value in texture from file functions. d3dx9: Validate filter argument in D3DXLoadSurfaceFrom{Surface,FileInMemory,Memory}(). d3dx9: Validate filter argument in D3DXLoadVolumeFrom{Volume,FileInMemory,Memory}(). d3dx9/tests: Add d3dx filter argument value tests. d3dx9: Return failure from D3DXLoadSurfaceFromMemory() if d3dx_load_pixels_from_pixels() fails. d3dx9: Return success in D3DXLoadSurfaceFromMemory() for multisampled destination surfaces. d3dx9/tests: Add tests for D3DXLoadSurfaceFromMemory() with a multisampled surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6157

3 16

[PATCH 0/1] MR6197: maintainers: Remove shdocvw from WebBrowser control section.
by Jacek Caban (＠jacek) 02 Aug '24

02 Aug '24

It's not longer a part of WebBrowser control since it was moved to ieframe. It's more related to shell32/shlwapi, but we don't have a section for them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6197

2 1

[PATCH 0/1] MR6192: jscript: Implement arguments.caller.
by Gabriel Ivăncescu (＠insn) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6192

3 5

[PATCH 0/1] MR5960: ntdll: Remove superflous null check (coverity)
by Fabian Maurer (＠DarkShadow44) 02 Aug '24

02 Aug '24

It's dereferenced later in create_window_handle anyways -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5960

3 4

[PATCH 0/1] MR6196: msvcrt: Reuse standard streams after they are closed.
by Piotr Caban (＠piotr) 02 Aug '24

02 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57008 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6196

3 2

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Fan WenJie (＠fanwenjie) 02 Aug '24

02 Aug '24

On Fri Aug 2 13:21:13 2024 +0000, Zhiyi Zhang wrote: > Did you figure out why it's not working as expected? virtual monitor is different than physical monitor,it has no builtin resolution. it is a window on host. for example, wine explorer.exe /desktop=123x456 can also show. so it has no need for apply builtin mode. we can chat by weixin, my weixinhao fan-wenjie -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77674

1 0

[PATCH v2 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- v2: comctl32/progress: Add states for progress bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

4 10

[PATCH 0/9] MR6195: mshtml: Initial constructors and prototypes implementation.
by Jacek Caban (＠jacek) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6195

3 10

[PATCH v3 0/1] MR6087: iphlpapi: Add stub for SetCurrentThreadCompartmentId.
by Fabian Maurer (＠DarkShadow44) 02 Aug '24

02 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56494 -- v3: iphlpapi: Add stub for SetCurrentThreadCompartmentId. https://gitlab.winehq.org/wine/wine/-/merge_requests/6087

3 3

[PATCH 0/1] MR6060: mmdevapi: Remove unused critical section from MMDevice.
by Brendan Shanks (＠bshanks) 02 Aug '24

02 Aug '24

This was added in the [original MMDevice stub](9924b40eb99e13a653f9d2a32d26d97abc5de06c) in 2010, but was never used as far as I can tell. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6060

4 3

[PATCH 0/3] MR6193: mmdevapi: Implement IAudioSessionEnumerator.
by Paul Gofman (＠gofman) 02 Aug '24

02 Aug '24

Fixes Owl Observatory Demo failing to start. It looks like just a stub interface might be enough for the game to work but it probably won't hurt to implement the interface at once. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6193

4 5

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Zhiyi Zhang (＠zhiyi) 02 Aug '24

02 Aug '24

On Fri Aug 2 07:08:22 2024 +0000, Fan WenJie wrote: > There is no need for parsing, because parse resolution is doing by > explorer.exe, explorer.exe parse resolution by arguments and setting by NtUserChangeDisplaySetting Did you figure out why it's not working as expected? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77662

1 0

[PATCH 0/1] MR6110: gdi32: Fix out-of-bounds write in EMR_ALPHABLEND handling.
by Esme Povirk (＠madewokherd) 02 Aug '24

02 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45105 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6110

4 3

[PATCH v9 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v9: comctl32: Fix sorting for listview. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 5

[PATCH v5 0/2] MR6146: comctl32/propsheet: Create pages with PSP_PREMATURE on initialization.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The UK Kalender program was crashing when a new event was created as stated in the bug report. The fix is to create all the property sheet pages from the beginning instead of when they are selected. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54861 -- v5: comctl32/propsheet: Create pages with PSP_PREMATURE on initialization. comctl32/tests: Add test for propsheet page creation when propsheet gets initialized. https://gitlab.winehq.org/wine/wine/-/merge_requests/6146

4 4

[PATCH v9 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v9: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 7

[PATCH 0/7] MR6194: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 3).
by Hans Leidekker (＠hans) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6194

3 8

[PATCH v5 0/3] MR6189: shell32: make SHGetStockIconInfo() attempt to set hIcon.
by Kieran (＠oh-ok) 02 Aug '24

02 Aug '24

Since LoadIconW returns NULL on an error anyway, we should try LoadIconW. This fixes a crash with the Affinity V2 installers. -- v5: shell32: check for SHGSI_ICON flag before attempting to load the icon https://gitlab.winehq.org/wine/wine/-/merge_requests/6189

2 3

[PATCH v4 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Brendan McGrath (＠redmcg) 02 Aug '24

02 Aug '24

Send INVALIDATEMEDIATYPE to allow the transform type to be set before retrying PROCESSINPUTNOTIFY. -- v4: mf: Send MEError when IMFStreamSink_ProcessSample fails. mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned. https://gitlab.winehq.org/wine/wine/-/merge_requests/6059

3 4

[PATCH v6 0/2] MR2875: shell32: add support for balloon icon copying
by Cherser-s (＠Cherser-s) 02 Aug '24

02 Aug '24

Currently shell32 only transfers the plain icon for `Shell_NotifyIcon` calls, ignoring balloon icons. This patch allows transferring both images to explorer.exe tray. -- v6: shell32: add support for balloon icon copying shell32: refactor notify_icon to allow copying multiple icons https://gitlab.winehq.org/wine/wine/-/merge_requests/2875

3 3

[PATCH v2 0/1] MR6087: iphlpapi: Add stub for SetCurrentThreadCompartmentId.
by Fabian Maurer (＠DarkShadow44) 02 Aug '24

02 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56494 -- v2: iphlpapi: Add stub for SetCurrentThreadCompartmentId. https://gitlab.winehq.org/wine/wine/-/merge_requests/6087

3 3

[PATCH v8 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v8: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

3 3

[PATCH v8 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v8: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 5

[PATCH v4 0/2] MR6189: shell32: make SHGetStockIconInfo() attempt to set hIcon.
by Kieran (＠oh-ok) 02 Aug '24

02 Aug '24

Since LoadIconW returns NULL on an error anyway, we should try LoadIconW. This fixes a crash with the Affinity V2 installers. -- v4: shell32: Use szPath when getting module handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/6189

3 3

[PATCH 0/1] MR6187: nsiproxy.sys: Only get owning pid when needed in udp_endpoint_enumerate_all().
by Paul Gofman (＠gofman) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6187

5 5

[PATCH 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

3 3

[PATCH v4 0/2] MR6146: comctl32/propsheet: Create pages with PSP_PREMATURE on initialization.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The UK Kalender program was crashing when a new event was created as stated in the bug report. The fix is to create all the property sheet pages from the beginning instead of when they are selected. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54861 -- v4: comctl32/propsheet: Create pages with PSP_PREMATURE on initialization. comctl32/tests: Add test for propsheet page creation when propsheet gets initialized. https://gitlab.winehq.org/wine/wine/-/merge_requests/6146

4 4

[PATCH v7 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v7: comctl32: Fix sorting for listview. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 5

[PATCH v6 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v6: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

3 3

[PATCH 0/1] MR6185: include: Add gdiplus effect parameter structs.
by Vijay Kiran Kamuju (＠infyquest) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6185

3 2

[PATCH 0/8] MR6184: mshtml: Use JS bindings for style objects.
by Jacek Caban (＠jacek) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6184

3 9

[PATCH 0/1] MR6183: nsiproxy.sys: Fix the build on non-Apple, non-Linux systems
by Gerald Pfeifer (＠gerald) 02 Aug '24

02 Aug '24

commit 5261811d471 revamped the code around pcblist structures, alas assumes a variable mib is always present on non-Apple, non-Linux systems when it is not. And in any case, ARRAY_SIZE should be used for the actual structure it applies to, not a similar one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6183

4 3

[PATCH 0/1] MR6182: atl: Correct comment above AtlModuleRegisterTypeLib function.
by Alex Henrie (＠alexhenrie) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6182

3 2

[PATCH 0/1] MR6181: atl: Only warn in AtlModuleGetClassObject if the class was not found.
by Alex Henrie (＠alexhenrie) 02 Aug '24

02 Aug '24

A warning should only be printed if something went wrong, not every time the function is run. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6181

3 2

[PATCH 0/2] MR6180: gdiplus: Fixes when compiling against wine headers.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6180

3 3

[PATCH 0/1] MR6179: include: Ensure that x86_64 syscall thunks have a consistent length when built with Clang.
by Brendan Shanks (＠bshanks) 02 Aug '24

02 Aug '24

GCC always assembles `jmp 1f` to `eb 01`, as does Clang when using -O1 or higher optimization. But with -O0, Clang outputs `e9 01 00 00 00`. The `subq $0xb,0x70(%rcx)` line in __wine_syscall_dispatcher relies on `jmp 1f` being 2 bytes. Since Wine defaults to `-g -O2` for `CFLAGS`, this wouldn't show up with a default Clang build. But the FreeBSD `wine-devel` port must override `CFLAGS`, it uses Clang for PE and was crashing on launch. See <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280000>. Here are compiler explorer links to see the difference: [PE](https://godbolt.org/z/35TxW8dK9) and [ELF](https://godbolt.org/z/1h3j4c4ja). Adding -O1 to the clang side will make them equivalent. I may also report this as an LLVM bug, it doesn't seem like there's any reason why Clang would prefer the long form at `-O0`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6179

3 3

[PATCH 0/3] MR6178: ntdll: Use environ/_NSGetEnviron() directly rather than caching it in main_envp.
by Brendan Shanks (＠bshanks) 02 Aug '24

02 Aug '24

Fixes an unpredictable use-after-free crash on launch on macOS. Also, use `_NSGetEnviron()` instead of `environ` in `msv1_0` and `ntdll`. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57005 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6178

3 4

[PATCH v2 0/1] MR6174: comctl32: Handle WM_GETOBJECT in tab control.
by Esme Povirk (＠madewokherd) 02 Aug '24

02 Aug '24

-- v2: comctl32: Handle WM_GETOBJECT in tab control. https://gitlab.winehq.org/wine/wine/-/merge_requests/6174

4 4

[PATCH v5 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v5: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 10

[PATCH 0/8] MR6177: mshtml: Use JS bindings for more objects.
by Jacek Caban (＠jacek) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6177

3 9

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Fan WenJie (＠fanwenjie) 02 Aug '24

02 Aug '24

On Wed Jul 31 13:55:13 2024 +0000, Zhiyi Zhang wrote: > I don't think you're going in the right direction. Why did you remove > all this code? You should be able to parse the resolution from the > command line and set it as the resolution for the virtual desktop window > and resolve the regression. There is no need for parsing, because parse resolution is doing by explorer.exe, explorer.exe parse resolution by arguments and setting by NtUserChangeDisplaySetting -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77582

1 0

[PATCH v6 0/3] MR4405: gdi32: Implement FixBrushOrgEx according to test.
by Bartosz Kosiorek (＠gang65) 02 Aug '24

02 Aug '24

More information about different Windows versions: https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversio… Verified with: https://testbot.winehq.org/JobDetails.pl?Key=139906 -- v6: win32u: Fix ExtCreateRegion when parameters are wrong. gdi32/tests: Add wrong parameters ExtCreateRegion tests. gdi32: Implement FixBrushOrgEx according to test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4405

3 4

[PATCH v3 0/1] MR6053: d3dx9/effect: Trace the pass count header field.
by Nikolay Sivov (＠nsivov) 02 Aug '24

02 Aug '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: d3dx9/effect: Document one remaining header field. https://gitlab.winehq.org/wine/wine/-/merge_requests/6053

3 2

[PATCH 0/1] MR6176: sechost: Check both lpServiceName and lpServiceProc for NULL in StartServiceCtrlDispatcher().
by Dmitry Timoshkov (＠dmitry) 02 Aug '24

02 Aug '24

An application I'm working on calls StartServiceCtrlDispatcher() with only lpServiceProc set to NULL in last element. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6176

3 2

[PATCH v2 0/1] MR6175: ntdll: Raise exception on failed CS wait.
by Paul Gofman (＠gofman) 02 Aug '24

02 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57011 -- v2: ntdll: Raise exception on failed CS wait. https://gitlab.winehq.org/wine/wine/-/merge_requests/6175

3 2

[PATCH 0/1] MR6190: d3dx9/tests: Add some tests for D3DXEFFECT_DESC fields.
by Nikolay Sivov (＠nsivov) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6190

4 5

Re: [PATCH v2 0/1] MR6190: d3dx9/tests: Add some tests for D3DXEFFECT_DESC fields. - approved
by Alexandre Julliard (＠julliard) 01 Aug '24

01 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6190

1 0

Re: [PATCH v3 0/3] MR6121: propsys: Initially implement VariantToPropVariant. - approved
by Alexandre Julliard (＠julliard) 01 Aug '24

01 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6121

1 0

Re: [PATCH v4 0/8] MR6081: win32u: Merge drivers CreateLayeredWindow with CreateWindowSurface. - approved
by Alexandre Julliard (＠julliard) 01 Aug '24

01 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6081

1 0

Re: [PATCH v2 0/2] MR6171: odbc32: In get_drivers fix error path and In simplify loop condition - approved
by Alexandre Julliard (＠julliard) 01 Aug '24

01 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6171

1 0

Re: [PATCH v2 0/1] MR6187: nsiproxy.sys: Only get owning pid when needed in udp_endpoint_enumerate_all(). - approved
by Alexandre Julliard (＠julliard) 01 Aug '24

01 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6187

1 0

Re: [PATCH v2 0/1] MR6183: nsiproxy.sys: Fix the build on non-Apple, non-Linux systems - approved
by Alexandre Julliard (＠julliard) 01 Aug '24

01 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6183

1 0

Re: [PATCH v2 0/3] MR6121: propsys: Initially implement VariantToPropVariant. - approved
by Huw Davies (＠huw) 01 Aug '24

01 Aug '24

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6121

1 0

[PATCH v7 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 01 Aug '24

01 Aug '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v7: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

3 5

Re: [PATCH v2 0/3] MR6121: propsys: Initially implement VariantToPropVariant.
by Ziqing Hui (＠zhui) 01 Aug '24

01 Aug '24

rebased -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6121#note_77517

1 0

[PATCH v3 0/8] MR6081: win32u: Merge drivers CreateLayeredWindow with CreateWindowSurface.
by Rémi Bernon (＠rbernon) 01 Aug '24

01 Aug '24

-- v3: win32u: Merge drivers CreateLayeredWindow with CreateWindowSurface. win32u: Avoid sending WM_PAINT to layered window surfaces. winemac: Rely on win32u previous surface reuse. winemac: Remove unnecessary old window surface bounds copy. winewayland: Rely on win32u previous surface reuse. wineandroid: Rely on win32u previous surface reuse. winex11: Rely on win32u previous surface reuse. win32u: Simplify offscreen surface previous surface reuse check. https://gitlab.winehq.org/wine/wine/-/merge_requests/6081

3 10

[PATCH 0/2] MR6171: odbc32: In get_drivers fix error path and In simplify loop condition
by Fabian Maurer (＠DarkShadow44) 01 Aug '24

01 Aug '24

They will always be true, since we exit the loop manually if they are not -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6171

3 3

[PATCH 0/1] MR6087: iphlpapi: Add stub for SetCurrentThreadCompartmentId.
by Fabian Maurer (＠DarkShadow44) 01 Aug '24

01 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56494 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6087

3 3

[PATCH v8 0/51] MR6166: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 31 Jul '24

31 Jul '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- v8: ntdll: main:envp has been replaced by environ This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

1 0

[PATCH v7 0/50] MR6166: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 31 Jul '24

31 Jul '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- v7: msv1_0: Use _NSGetEnviron() instead of environ on macOS. ntdll: Use _NSGetEnviron() instead of environ when spawning the server on macOS. ntdll: Use environ/_NSGetEnviron() directly rather than caching it in main_envp. include: Ensure that x86_64 syscall thunks have a consistent length when built with Clang. include: Forward declare all gdiplus classes. include: Add *_SHIFT macros. include: Add gdiplus effect parameter structs. atl: Only warn in AtlModuleGetClassObject if the class was not found. atl: Correct comment above AtlModuleRegisterTypeLib function. mshtml: Use host object script bindings for style objects. mshtml: Use get_prop_desc for legacy function object implementation. mshtml: Use host object script bindings for HTMLStyleSheetRule. mshtml: Use host object script bindings for HTMLStyleSheetRulesCollection. mshtml: Use host object script bindings for HTMLStyleSheet. mshtml: Use host object script bindings for HTMLStyleSheetsCollection. mshtml: Use host object script bindings for HTMLDOMChildrenCollection. mshtml: Use dispex_index_prop_desc for HTMLElementCollection. comctl32: Handle WM_GETOBJECT in tab control. wined3d: Feed modelview matrices through a push constant buffer. wined3d: Do not use the normal or modelview matrices when drawing pretransformed vertices. wined3d: Feed the projection matrix through a push constant buffer. wined3d: Move get_projection_matrix() to glsl_shader.c. wined3d: Feed the material through a push constant buffer. wined3d: Invalidate push constant flags only for the primary stateblock. include: Added IEventTrigger declaration. include: Add ISessionStateChangeTrigger declaration. include: Add more Task Scheduler Trigger interface definitions. shell32: Fix FO_MOVE when destination has conflicting directory. shell32/tests: Add tests for moving dir(s) to destination(s) with conflicting dir. mshtml: Use host object script bindings for HTMLAttributeCollection. mshtml: Use dispex_index_prop_desc for HTMLFiltersCollection. mshtml: Use host object script bindings for DOMTokenList. mshtml: Use host object script bindings for HTMLRect. mshtml: Use host object script bindings for select elements. mshtml: Use host object script bindings for object elements. mshtml: Store property name in HTMLPluginContainer. mshtml: Use HTMLPluginContainer for DispatchEx functions in object element. sechost: Check both lpServiceName and lpServiceProc for NULL in StartServiceCtrlDispatcher(). d3dx9/effect: Document one remaining header field. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

1 0

Re: [PATCH v2 0/3] MR6178: ntdll: Use environ/_NSGetEnviron() directly rather than caching it in main_envp. - approved
by Alexandre Julliard (＠julliard) 31 Jul '24

31 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6178

1 0

Re: [PATCH v2 0/1] MR6179: include: Ensure that x86_64 syscall thunks have a consistent length when built with Clang. - approved
by Alexandre Julliard (＠julliard) 31 Jul '24

31 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6179

1 0

Re: [PATCH v2 0/2] MR6180: gdiplus: Fixes when compiling against wine headers. - approved
by Alexandre Julliard (＠julliard) 31 Jul '24

31 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6180

1 0

Re: [PATCH v2 0/1] MR6185: include: Add gdiplus effect parameter structs. - approved
by Alexandre Julliard (＠julliard) 31 Jul '24

31 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6185

1 0

Re: [PATCH v2 0/1] MR6181: atl: Only warn in AtlModuleGetClassObject if the class was not found. - approved
by Alexandre Julliard (＠julliard) 31 Jul '24

31 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6181

1 0

Re: [PATCH v2 0/1] MR6182: atl: Correct comment above AtlModuleRegisterTypeLib function. - approved
by Alexandre Julliard (＠julliard) 31 Jul '24

31 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6182

1 0

Re: [PATCH v2 0/8] MR6184: mshtml: Use JS bindings for style objects. - approved
by Alexandre Julliard (＠julliard) 31 Jul '24

31 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6184

1 0

Re: [PATCH v3 0/1] MR6174: comctl32: Handle WM_GETOBJECT in tab control. - approved
by Alexandre Julliard (＠julliard) 31 Jul '24

31 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6174

1 0

Re: [PATCH v2 0/6] MR6136: wined3d: Feed FFP shader constants through push constant buffers, part 5. - approved
by Alexandre Julliard (＠julliard) 31 Jul '24

31 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6136

1 0

[PATCH v6 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 31 Jul '24

31 Jul '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v6: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

2 2

[PATCH v9 0/6] MR6004: comctl32: A NULL string fix.
by Aida Jonikienė (＠DodoGTA) 31 Jul '24

31 Jul '24

-- v9: user32/edit: Add some WM_ASKCBFORMATNAME tests. user32/tests: Add tests for NULL strings with edit control GETTEXT message. comctl32/tests: Add tests for NULL strings with edit control GETTEXT message. user32: Correctly handle NULL string in GETTEXT/CBFORMAT AtoW wrapper. user32: Fail on NULL string for edit control WM_GETTEXT message. comctl32: Fail on NULL string for edit control WM_GETTEXT message. https://gitlab.winehq.org/wine/wine/-/merge_requests/6004

4 12

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 31 Jul '24

31 Jul '24

On Wed Jul 31 16:19:30 2024 +0000, Nikolay Sivov wrote: > If this is coming from analyzer report, I wouldn't bother. Yeah, it's from an analyzer. But I don't see the harm in making it NULL safe, it seems like a simple change to me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_77432

1 0

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Nikolay Sivov (＠nsivov) 31 Jul '24

31 Jul '24

If this is coming from analyzer report, I wouldn't bother. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_77430

1 0

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 31 Jul '24

31 Jul '24

@huw Sorry for the random ping, but I'm still looking for someone to review this change, would you mind taking a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_77429

1 0

[PATCH 0/6] MR6136: wined3d: Feed FFP shader constants through push constant buffers, part 5.
by Elizabeth Figura (＠zfigura) 31 Jul '24

31 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6136

4 8

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Zhiyi Zhang (＠zhiyi) 31 Jul '24

31 Jul '24

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c: > return STATUS_SUCCESS; > } > > -/* parse the desktop size specification */ > -static BOOL parse_size( const WCHAR *size, DWORD *width, DWORD *height ) I don't think you're going in the right direction. Why did you remove all this code? You should be able to parse the resolution from the command line and set it as the resolution for the virtual desktop window and resolve the regression. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77420

1 0

[PATCH v5 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 31 Jul '24

31 Jul '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v5: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 5

[PATCH v3 0/2] MR6146: comctl32: Create all prop sheet pages on initialization.
by Jacob Czekalla (＠JacobCzekalla) 31 Jul '24

31 Jul '24

Fixes bug 54861. The UK Kalender program was crashing when a new event was created as stated in the bug report. The fix is to create all the property sheet pages from the beginning instead of when they are selected. -- v3: comctl32: Create all prop sheet pages on initialization. comctl32/tests: Add test for propsheet page creation when propsheet gets initialized. https://gitlab.winehq.org/wine/wine/-/merge_requests/6146

3 7

[PATCH v6 0/1] MR5523: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW().
by Vijay Kiran Kamuju (＠infyquest) 31 Jul '24

31 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56576 -- v6: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5523

2 1

Re: [PATCH v2 0/1] MR6170: programs/cmd: Fix test failures for SET /P command.
by eric pouech (＠epo) 31 Jul '24

31 Jul '24

1) It's not a high priority for me to fix white space discrepancies in printing (unless there's a program in the wild that makes use of it) (I would be more worried about a space before the = as it wwould impact the saved environment variable) 2) would you mind adding a test case for this so that we don't lose this use case? 3) I strongly believe SET (and not only SET /P) shall rely on parsing the parameters with the usual helper functions instead of doing their own parsing 4) there's also a more annoying issue like not expanding in SET the potential variables inside quotes (like SET "%foo%=bar", and IIRC Wine doesn't expand %foo%, but it does expand in SET %foo%=bar) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170#note_77392

1 0

Re: [PATCH v10 0/3] MR5104: include: Add missing Task Scheduler Trigger definitions - approved
by Alexandre Julliard (＠julliard) 30 Jul '24

30 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5104

1 0

Re: [PATCH v6 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory. - approved
by Alexandre Julliard (＠julliard) 30 Jul '24

30 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

1 0

Re: [PATCH v2 0/8] MR6177: mshtml: Use JS bindings for more objects. - approved
by Alexandre Julliard (＠julliard) 30 Jul '24

30 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6177

1 0

Re: [PATCH v2 0/1] MR6176: sechost: Check both lpServiceName and lpServiceProc for NULL in StartServiceCtrlDispatcher(). - approved
by Alexandre Julliard (＠julliard) 30 Jul '24

30 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6176

1 0

Re: [PATCH v4 0/1] MR6053: d3dx9/effect: Trace the pass count header field. - approved
by Alexandre Julliard (＠julliard) 30 Jul '24

30 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6053

1 0

Re: [PATCH v2 0/1] MR6170: programs/cmd: Fix test failures for SET /P command.
by Vijay Kiran Kamuju (＠infyquest) 30 Jul '24

30 Jul '24

We are missing spaces in wine, if have spaces after = and before ' or ". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170#note_77379

1 0

[PATCH v3 0/1] MR6175: ntdll: Raise exception on failed CS wait.
by Paul Gofman (＠gofman) 30 Jul '24

30 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57011 -- v3: ntdll: Raise exception on failed CS wait. https://gitlab.winehq.org/wine/wine/-/merge_requests/6175

2 3

[PATCH 0/8] MR6151: mshtml: window.performance improvements.
by Gabriel Ivăncescu (＠insn) 30 Jul '24

30 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6151

3 12

Re: [PATCH v2 0/1] MR6170: programs/cmd: Fix test failures for SET /P command.
by eric pouech (＠epo) 30 Jul '24

30 Jul '24

- are we missing new lines? (assuming new test cases that don't pass) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170#note_77370

1 0

2025

2024

2023

2022

wine-gitlab