- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR6170: programs/cmd: Fix test failures for SET /P command.
by eric pouech (＠epo) 30 Jul '24

30 Jul '24

- are we missing new lines? (assuming new test cases that don't pass) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170#note_77370

1 0

Re: [PATCH v2 0/1] MR6170: programs/cmd: Fix test failures for SET /P command.
by Vijay Kiran Kamuju (＠infyquest) 30 Jul '24

30 Jul '24

The following tests fail: set /p abc= 'Value=' 'Value=' set /p abc= "Value=" Value= on wine: ../../wine cmd.exe.so Z:\home\admin\devel\wineiq64-build\programs\cmd>set /p abc= 'Value=' 'Value=' Z:\home\admin\devel\wineiq64-build\programs\cmd>set /p abc= "Value=" "Value=" -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170#note_77369

1 0

[PATCH v4 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 30 Jul '24

30 Jul '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v4: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 6

[PATCH v3 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Brendan McGrath (＠redmcg) 30 Jul '24

30 Jul '24

Send INVALIDATEMEDIATYPE to allow the transform type to be set before retrying PROCESSINPUTNOTIFY. -- v3: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned. mf/tests: Add tests for custom evr presenter. https://gitlab.winehq.org/wine/wine/-/merge_requests/6059

3 3

[PATCH v2 0/1] MR6053: d3dx9/effect: Trace the pass count header field.
by Nikolay Sivov (＠nsivov) 30 Jul '24

30 Jul '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: d3dx9/effect: Document one remaining header field. https://gitlab.winehq.org/wine/wine/-/merge_requests/6053

4 6

[PATCH 0/1] MR6174: comctl32: Handle WM_GETOBJECT in tab control.
by Esme Povirk (＠madewokherd) 30 Jul '24

30 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6174

4 4

[PATCH 0/1] MR6175: ntdll: Raise exception on failed CS wait.
by Paul Gofman (＠gofman) 30 Jul '24

30 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57011 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6175

3 3

Re: [PATCH v2 0/1] MR6173: d3dx9: Don't silently ignore d3dx_calculate_pixel_size() errors. - approved
by Alexandre Julliard (＠julliard) 29 Jul '24

29 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6173

1 0

Re: [PATCH v2 0/1] MR6172: kernel32: Add SetFirmwareEnvironmentVariableA stub. - approved
by Alexandre Julliard (＠julliard) 29 Jul '24

29 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6172

1 0

Re: [PATCH v2 0/11] MR6167: mshtml: Use JS bindings for window objects. - approved
by Alexandre Julliard (＠julliard) 29 Jul '24

29 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6167

1 0

Re: [PATCH v2 0/1] MR6170: programs/cmd: Fix test failures for SET /P command. - approved
by Alexandre Julliard (＠julliard) 29 Jul '24

29 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170

1 0

Re: [PATCH v2 0/1] MR6168: gdiplus: fixed second order adding offset and result ternary operator - approved
by Alexandre Julliard (＠julliard) 29 Jul '24

29 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6168

1 0

[PATCH 0/1] MR6173: d3dx9: Don't silently ignore d3dx_calculate_pixel_size() errors.
by Matteo Bruni (＠Mystral) 29 Jul '24

29 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6173

2 2

[PATCH 0/1] MR6138: crypt32: When importing certificates to Root store set 'done' flag before entering semaphore.
by Dmitry Timoshkov (＠dmitry) 29 Jul '24

29 Jul '24

CSP is loaded for each imported certificate, and if CSP accesses Root store it deadlocks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6138

4 10

[PATCH 0/1] MR6172: kernel32: Add SetFirmwareEnvironmentVariableA stub.
by Fabian Maurer (＠DarkShadow44) 29 Jul '24

29 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57012 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6172

3 2

[PATCH v3 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 29 Jul '24

29 Jul '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v3: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 5

[PATCH 0/1] MR6168: gdiplus: fixed second order adding offset and result ternary operator
by Herman Semenov (＠GermanAizek) 29 Jul '24

29 Jul '24

I'm sorry that I didn't notice this problem earlier and didn't squash commits. I found exactly same misprint in same file as in this PR: https://gitlab.winehq.org/wine/wine/-/merge_requests/6161 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6168

4 3

[PATCH v2 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 29 Jul '24

29 Jul '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v2: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

3 3

[PATCH v2 0/1] MR6146: comctl32: Create all prop sheet pages on initialization.
by Jacob Czekalla (＠JacobCzekalla) 29 Jul '24

29 Jul '24

Fixes bug 54861. The UK Kalender program was crashing when a new event was created as stated in the bug report. The fix is to create all the property sheet pages from the beginning instead of when they are selected. -- v2: comctl32: Create all prop sheet pages on initialization. https://gitlab.winehq.org/wine/wine/-/merge_requests/6146

2 2

[PATCH v5 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) 29 Jul '24

29 Jul '24

-- v5: shell32: Fix FO_MOVE when destination has conflicting directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

2 2

[PATCH 0/1] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 29 Jul '24

29 Jul '24

The listview wine bug 56140 is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 4

[PATCH 0/1] MR6170: programs/cmd: Fix test failures for SET /P command.
by eric pouech (＠epo) 29 Jul '24

29 Jul '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170

2 1

[PATCH v9 0/3] MR5104: include: Add missing Task Scheduler Trigger definitions
by Vijay Kiran Kamuju (＠infyquest) 29 Jul '24

29 Jul '24

This is a prerequisite for stub implementation of ILogonTrigger interface, which is needed for https://bugs.winehq.org/show_bug.cgi?id=47152 -- v9: include: Added IEventTrigger declaration. include: Add ISessionStateChangeTrigger declaration. include: Add more Task Scheduler Trigger interface definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/5104

3 4

[PATCH 0/1] MR6169: comctl32: fixed first we check index then array access by index is safe
by Herman Semenov (＠GermanAizek) 29 Jul '24

29 Jul '24

I think this PR changes will protect against situation if out-of-bounds access array. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6169

3 2

[PATCH v5 0/2] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Kevin Martinez (＠kevinrmartinez) 29 Jul '24

29 Jul '24

Stub added for the IEnumObjects and IObjectCollection interfaces, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56891 -- v5: shell32: Added stub for IObjectCollection interface. shell32: Added stub for IEnumObjects interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

5 20

[PATCH v5 0/11] MR6166: Draft: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 28 Jul '24

28 Jul '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- v5: remove is_dynamic_env_var(...) because it is not needed anymore https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

8 12

[PATCH v3 0/10] MR6166: Draft: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 28 Jul '24

28 Jul '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- v3: Release 9.14. opengl32: Fix match criteria for WGL_DRAW_TO_PBUFFER_ARB. winex11: Query proper GLX attribute for pbuffer bit. gdiplus: Fixed order of adding offset and result ternary operator. nsiproxy.sys: Use the pcblist64 sysctl to enumerate UDP connections on macOS. nsiproxy.sys: Use the pcblist64 sysctl to enumerate TCP connections on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

8 11

Re: [PATCH v2 0/2] MR6164: opengl32: Fix wglChoosePixelFormatARB support for pbuffer. - approved
by Alexandre Julliard (＠julliard) 28 Jul '24

28 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6164

1 0

Re: [PATCH v2 0/1] MR6161: gdiplus: fixed order adding offset and result ternary operator - approved
by Alexandre Julliard (＠julliard) 28 Jul '24

28 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6161

1 0

Re: [PATCH v9 0/2] MR6021: nsiproxy.sys: Use pcblist64 sysctl to enumerate TCP & UDP connections on macOS. - approved
by Alexandre Julliard (＠julliard) 28 Jul '24

28 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

1 0

[PATCH 0/4] MR6157: d3dx9: More miscellaneous fixes.
by Connor McAdams (＠cmcadams) 28 Jul '24

28 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6157

3 10

[PATCH v27 0/6] MR5503: Fix initialization of the handler_fd_ops
by Ruslan Garipov (＠ruslangaripov) 28 Jul '24

28 Jul '24

This lists all fields of the `struct fd_ops` when object of that type -- `handler_fd_ops` in server/signal.c -- is being initialized. It looks like field list in initialization of the `handler_fd_ops` in server/signal.c was out-of-sync for a long time. Take a look, for example, on patches ad1e0609a0f (server: Get rid of no loner used cancel_async from fd_ops., 2016-12-01) (which removed "reference" to the `cancel_async` field correctly, but did not add "references" to the `read` and `write` fields, for example), or 837b39b2028 (server: Add read and write fd member functions., 2015-05-05) (which updated `struct fd_ops` but did not change initialization of the `handler_fd_ops` at all). Because the main purpose of initialization of the `handler_fd_ops` made in server/signal.c is to assign address of the `handler_poll_event()` function to the `poll_event` field, while making all other fields `NULL`ed, lacking some fields in that initialization is not an error according to C standard: > 6.7.11 Initialization > > 11 ... If an object that has static or thread storage duration is not > initialized explicitly, or any object is initialized with an empty > initializer, then it is subject to default initialization, which > initializes an object as follows: > > - if it has pointer type, it is initialized to a null pointer; > > ... > > 22 If there are fewer initializers in a brace-enclosed list than there > are elements or members of an aggregate, or fewer characters in a > string literal used to initialize an array of known size than there > are elements in the array, the remainder of the aggregate is subject > to default initialization. But to maintain code consistency I believe initialization of the `handler_fd_ops` object should enumerate all fields of the `struct fd_ops` type. No functional changes intended. ```shell $ ./configure ... $ make ... $ ./wine --version wine-9.6-74-g6a1dab2af04 ``` -- v27: Fix initialization of the msg_queue_fd_ops Fix initialization of the process_fd_ops Fix initialization of the thread_fd_ops Fix initialization of the inotify_fd_ops Fix initialization of the master_socket_fd_ops Fix initialization of the handler_fd_ops https://gitlab.winehq.org/wine/wine/-/merge_requests/5503

2 6

[PATCH v4 0/1] MR6123: shdocvw: Add IEParseDisplayNameWithBCW semi-stub.
by Dmitry Timoshkov (＠dmitry) 28 Jul '24

28 Jul '24

-- v4: shdocvw: Add IEParseDisplayNameWithBCW semi-stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6123

4 7

[PATCH 0/11] MR6167: mshtml: Use JS bindings for window objects.
by Jacek Caban (＠jacek) 28 Jul '24

28 Jul '24

Based on patch by Gabriel Ivăncescu. The part allowing properties to disappear as part of enumeration (as well as similar changes from previous MR) is not quite optimal. I think we will want to avoid it once host prototypes are supported. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6167

3 12

[PATCH 0/2] MR6164: Draft: opengl32: Fix wglChoosePixelFormatARB support for pbuffer.
by Alexandros Frantzis (＠afrantzis) 28 Jul '24

28 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56984 Fixes: 272c55ac257315ef8393df357a79aac4e0d6cd76 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6164

3 5

[PATCH v2 0/4] MR6166: Draft: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 28 Jul '24

28 Jul '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- v2: remove unused vars https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

4 5

[PATCH v6 0/1] MR5957: win32u: fix random crash without libfreetype
by Fan WenJie (＠fanwenjie) 28 Jul '24

28 Jul '24

without freetype, some calling return failed, so some value may not be initialized (it initialize by some failed calling and pass argument by point of it), it would cause random crash! Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v6: win32u: fix random crash without libfreetype https://gitlab.winehq.org/wine/wine/-/merge_requests/5957

2 2

[PATCH v9 0/9] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v9: userenv: Fix GetProfilesDirectoryA return value kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. kernel32: Rework ExpandEnvironmentStringsW error handling. ntdll: Rework RtlExpandEnvironmentStrings/_U to account for corner cases. kernel32: Add ExpandEnvironmentStringsA tests for japanese. kernel32: Add more tests for ExpandEnvironmentStringsA. kernel32: Add tests for ExpandEnvironmentStringsW. ntdll: Add more tests for RtlExpandEnvironmentStrings/_U. userenv: Add another test for GetProfilesDirectoryA https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

2 9

[PATCH 0/3] MR6166: Draft: separate env for windows applications (WINENV) from env for wine processes (NIXENV)
by Alois Schloegl (＠schloegl) 27 Jul '24

27 Jul '24

Because WINENV is limited (32767 bytes), and HOSTENV can be much larger, a whitelisting approach is used to keep WINENV as small as possible. Currently, only the following envvars are propagated from the host env to WINENV WINEPATH, WINEPWD, WINEHOME, WINETEMP, WINETMP, WINEQT_, WINEVK_, WINEXDG_SESSION_TYPE Moreover, the NIXENV (env for running wine processes - not applications) on the host system is not produced from WINENV anymore, but the global ENV is propagated to all wine processes and threads. This might be an alternative approach to MR!5231, MR!6140, bug #56941 and should provide a more deterministic behaviour of wine, because unrelated envvars do have no influence on the env for running windows applications. Initial tests (winemine, notepad, cmd, etc) seem to run fine, but some envvars might need additional consideration. XVDK_* was mentioned, WINE*, MESA_*, VK_*, QT_*, LIBGL_* are other suspects. Moreover, this is my first merge request, so your feedback is highly appreciated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6166

4 4

[PATCH 0/1] MR6140: ntdll: Exclude biggest envars to fit 32767 chars limit in get_initial_environment.
by Martino Fontana (＠tinozzo123) 27 Jul '24

27 Jul '24

Windows has a limit of 32767 characters in the environment block. https://superuser.com/questions/1070272/why-does-windows-have-a-limit-on-en… Wine doesn't attempt to respect that at all. Do some programs actually depend on this? Unfortunately yes. With this patch, during initialization, if the block size would exceed (or be close to) the limit, the biggest environment variables will be excluded. This is useful when a user has very long environment variables in their system for reasons unrelated to Wine. Do note that there's still nothing done to make sure that the limit isn't exceeded after initialization. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56941 Signed-off-by: Martino Fontana <tinozzo123(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6140

7 10

[PATCH 0/3] MR6165: widl: Propagate attrs to inner pointer types.
by Elizabeth Figura (＠zfigura) 27 Jul '24

27 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6165

3 4

[PATCH v7 0/7] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v7: kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. kernel32: Rework ExpandEnvironmentStringsW error handling. ntdll: Rework RtlExpandEnvironmentStrings/_U to account for corner cases. kernel32: Add ExpandEnvironmentStringsA tests for japanese. kernel32: Add more tests for ExpandEnvironmentStringsA. kernel32: Add tests for ExpandEnvironmentStringsW. ntdll: Add more tests for RtlExpandEnvironmentStrings/_U. https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 8

[PATCH v6 0/7] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v6: kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 9

Re: [PATCH v3 0/1] MR5957: win32u: fix random crash without libfreetype
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

Fabian Maurer (@DarkShadow44) commented about dlls/win32u/sysparams.c: > 'r','s','t','u','v','w','x','y','z','A','B','C','D','E','F','G','H', > 'I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'}; > > - if (metric && !NtGdiGetTextMetricsW( hdc, metric, 0 )) return 0; > + if (metric && !NtGdiGetTextMetricsW( hdc, metric, 0 )) goto fail; > > if (!NtGdiGetTextExtentExW( hdc, abcdW, ARRAYSIZE(abcdW), 0, NULL, NULL, &sz, 0 )) > - return 0; > + goto fail; > > if (height) *height = sz.cy; > return (sz.cx / 26 + 1) / 2; > +fail: > + if (height) *height = 1; > + return 0; Just curious, but why `1`? Also, wouldn't it be easier to have `if (height) *height = 1;` at the beginning of the function? Then you could keep the rest the same. And maybe that function could zero the `metrics` as well? Not sure where it would be required, I find a setup without freetype strange to begin with. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5957#note_77190

1 0

[PATCH v3 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) 27 Jul '24

27 Jul '24

-- v3: shell32: Fix FO_MOVE when destination has conflicting directory. shell32/tests: Add tests for moving dir(s) to destination(s) with conflicting dir. https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

3 3

[PATCH v4 0/1] MR5586: configure: Test PE compilers after setting their target argument.
by Billy Laws (＠bylaws) 27 Jul '24

27 Jul '24

clang will default to the host if no target is specified, which causes compile test failures if arch-specific CFLAGS are used for a non-host arch. -- v4: configure: Test PE compilers after setting their target argument. https://gitlab.winehq.org/wine/wine/-/merge_requests/5586

3 4

[PATCH 0/1] MR6161: gdiplus: fixed order adding offset and result ternary operator
by Herman Semenov (＠GermanAizek) 27 Jul '24

27 Jul '24

Reference: https://en.cppreference.com/w/c/language/operator_precedence -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6161

3 2

[PATCH 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) 26 Jul '24

26 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

2 2

Re: [PATCH v8 0/2] MR6021: nsiproxy.sys: Use pcblist64 sysctl to enumerate TCP & UDP connections on macOS. - approved
by Huw Davies (＠huw) 26 Jul '24

26 Jul '24

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

1 0

[PATCH v6 0/2] MR6021: nsiproxy.sys: Use pcblist64 sysctl to enumerate TCP & UDP connections on macOS.
by Tim Clem (＠tclem) 26 Jul '24

26 Jul '24

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for the pcblist64 sysctls, so I'm caching the result of sysctlnametomib. -- v6: nsiproxy.sys: Use the pcblist64 sysctl to enumerate UDP connections on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

2 2

Re: [PATCH v9 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Alfred Agrell (＠Alcaro) 26 Jul '24

26 Jul '24

On Fri Jul 26 15:36:35 2024 +0000, Fan WenJie wrote: > test-linux-32 always failed, can you see the reason for the failure? Just open [it](https://gitlab.winehq.org/fanwenjie/wine/-/jobs/89772) and scroll around until you find a colored block, then look for red lines in that block. If it has nothing to do with your changes (for example because it's about sockets or batch files), then it's broken on master too, and is someone else's problem. Just ignore it, it won't block merging. Don't rerun it, it'll just fail again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77150

1 0

Re: [PATCH v9 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Fan WenJie (＠fanwenjie) 26 Jul '24

26 Jul '24

On Fri Jul 26 15:36:35 2024 +0000, Fan WenJie wrote: > OK test-linux-32 always failed, can you see the reason for the failure? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77149

1 0

[PATCH 0/1] MR3047: ntdll: hook mmap for force allocate low 32-bit memory on wow64
by Fan WenJie (＠fanwenjie) 26 Jul '24

26 Jul '24

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3047

5 5

[PATCH v3 0/1] MR4984: wineandroid.drv: fix incorrent path of device and init device in ANDROID_CreateDesktop
by Fan WenJie (＠fanwenjie) 26 Jul '24

26 Jul '24

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v3: wineandroid.drv: fix incorrent path of device and init device in ANDROID_CreateDesktop https://gitlab.winehq.org/wine/wine/-/merge_requests/4984

2 2

[PATCH v6 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) 26 Jul '24

26 Jul '24

fix: https://bugs.winehq.org/show_bug.cgi?id=56993 Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v6: win32u: fix a regression bug that virtual desktop not effective. https://gitlab.winehq.org/wine/wine/-/merge_requests/6150

3 2

[PATCH v7 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) 26 Jul '24

26 Jul '24

fix: https://bugs.winehq.org/show_bug.cgi?id=56993 Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v7: win32u: fix a regression bug that virtual desktop not effective. https://gitlab.winehq.org/wine/wine/-/merge_requests/6150

2 3

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) 26 Jul '24

26 Jul '24

On Fri Jul 26 10:09:51 2024 +0000, Rémi Bernon wrote: > Fwiw, on Windows, all desktops are of the same size, which only depends > on the set of monitors which are plugged in. > IMO we should implement support for multiple virtual monitors, rather > than going back to the old virtual desktop logic. desktop is not equals to monitor, currently wine supports multiply desktops (mutiply host window) on a virtual monitor. only need one virtual monitor because it is only a virtual device. In virtual desktop mode desktop = host platform window virtual monitor=dummy host monitor device -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77129

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Rémi Bernon (＠rbernon) 26 Jul '24

26 Jul '24

Fwiw, on Windows, all desktops are of the same size, which only depends on the set of monitors which are plugged in. IMO we should implement support for multiple virtual monitors, rather than going back to the old virtual desktop logic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77123

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Zhiyi Zhang (＠zhiyi) 26 Jul '24

26 Jul '24

You can add Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56993 at the end of your commit message body. Also, the wrong commit is b86cc9e6, not fecfb442 ``` (b86cc9e6589...)|BISECTING:wine/win32-build$ git bisect bad b86cc9e658959cee47e6e587fec4f7c26350ed76 is the first bad commit commit b86cc9e658959cee47e6e587fec4f7c26350ed76 Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Feb 13 15:05:37 2024 +0100 winex11: Let win32u decide when to force update the display cache. dlls/winex11.drv/window.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77120

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Zhiyi Zhang (＠zhiyi) 26 Jul '24

26 Jul '24

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c: > struct monitor *monitor; You can add Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56993 at the end of your commit message body. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77118

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Zhiyi Zhang (＠zhiyi) 26 Jul '24

26 Jul '24

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c: > struct monitor *monitor; > struct gpu *gpu; > > - if (list_head( &monitors ) == &virtual_monitor.entry) Please don't add irrelevant changes in the same commit. If you want to fix explorer.exe not starting up with a user-specified resolution, focus on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77119

1 0

[PATCH v4 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 26 Jul '24

26 Jul '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. -- v4: comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 14

[PATCH 0/1] MR6162: ddraw: SecureZeroMemory did not reset to zero entire size obj, only size ptr
by Herman Semenov (＠GermanAizek) 26 Jul '24

26 Jul '24

Maybe it's just typo who added this function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6162

4 6

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) 25 Jul '24

25 Jul '24

On Thu Jul 25 23:39:50 2024 +0000, Fabian Maurer wrote: > Why do you remove all that virtual source logic? I mean, I'm not an > export, but it looks off. virtual_source should remove，2 reason in function is_monitor_active ` static BOOL is_monitor_active( struct monitor *monitor ) { struct source *source; /* services do not have any adapters, only a virtual monitor */ if (!(source = monitor->source)) return TRUE; if (!(source->state_flags & DISPLAY_DEVICE_ATTACHED_TO_DESKTOP)) return FALSE; return !IsRectEmpty( &monitor->rc_monitor ); } ` virual_monitor do not need source. virtual monitor is a temporary setting，should not write registry， It is a feature only for wine, so have no effect for global setting. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77094

1 0

[PATCH 0/3] MR6159: Taking strlen outside loop if possible
by Herman Semenov (＠GermanAizek) 25 Jul '24

25 Jul '24

Example with gcc and -O3 maximum optimization flag. Before: ![screen_before](/uploads/d02727ad61da60e320d25e86bd0457ff/screen_before.jpg) After: ![screen_after](/uploads/bae74909dd904232b2dc8cced7028036/screen_after.jpg) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6159

4 7

Re: [PATCH v15 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command. - approved
by Alexandre Julliard (＠julliard) 25 Jul '24

25 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

1 0

Re: [PATCH v2 0/1] MR6153: dplayx: fixed check structure before copy - approved
by Alexandre Julliard (＠julliard) 25 Jul '24

25 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6153

1 0

Re: [PATCH v2 0/1] MR6154: dbghelp: fixed misprint access to struct with invalid case - approved
by Alexandre Julliard (＠julliard) 25 Jul '24

25 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6154

1 0

Re: [PATCH v2 0/3] MR6155: msvcrt: _ctime*_s and mbstowcs improvements. - approved
by Alexandre Julliard (＠julliard) 25 Jul '24

25 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6155

1 0

Re: [PATCH v2 0/9] MR6156: mshtml: Use new bindings for document nodes. - approved
by Alexandre Julliard (＠julliard) 25 Jul '24

25 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6156

1 0

[PATCH v4 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) 25 Jul '24

25 Jul '24

fix: https://bugs.winehq.org/show_bug.cgi?id=56993 Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v4: win32u: virtual desktop for explorer.exe support different resolutions https://gitlab.winehq.org/wine/wine/-/merge_requests/6150

4 4

[PATCH 0/2] MR6158: Replaced with simpler functions with the char, wchar_t parameter if possible
by Herman Semenov (＠GermanAizek) 25 Jul '24

25 Jul '24

Example my assembly with gcc -02 flag Before: ![screen_before](/uploads/f2bf5f4c793c159c31ac42b635c46d5a/screen_before.jpg) After: ![screen_after](/uploads/051315ad1e3c064046446782d36e1a29/screen_after.jpg) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6158

3 3

Re: [PATCH v3 0/1] MR6158: Replaced on simpler functions with char, wchar_t parameter if possible
by Matteo Bruni (＠Mystral) 25 Jul '24

25 Jul '24

You probably want to split this into two separate patches, possibly two separate MRs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6158#note_77056

1 0

[PATCH v3 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 25 Jul '24

25 Jul '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. -- v3: comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

2 2

[PATCH 0/9] MR6156: mshtml: Use new bindings for document nodes.
by Jacek Caban (＠jacek) 25 Jul '24

25 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6156

3 10

[PATCH 0/3] MR6155: msvcrt: _ctime*_s and mbstowcs improvements.
by Piotr Caban (＠piotr) 25 Jul '24

25 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6155

3 4

[PATCH 0/1] MR6152: msvcrt, winex11, mountmgr: fixed memleaks
by Herman Semenov (＠GermanAizek) 25 Jul '24

25 Jul '24

I think such catches will be useful to you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6152

6 9

[PATCH v2 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) 25 Jul '24

25 Jul '24

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. -- v2: comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 4

[PATCH 0/1] MR6154: dbghelp: fixed misprint access to struct with invalid case
by Herman Semenov (＠GermanAizek) 25 Jul '24

25 Jul '24

Typo is immediately noticeable here, since the case value has postfix digit 2. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6154

3 3

Re: [PATCH v14 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command. - approved
by eric pouech (＠epo) 25 Jul '24

25 Jul '24

This merge request was approved by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

1 0

[PATCH v13 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 25 Jul '24

25 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v13: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

3 3

[PATCH 0/1] MR6153: dplayx: fixed check structure before copy
by Herman Semenov (＠GermanAizek) 25 Jul '24

25 Jul '24

It seems to me that this is minor fix, but logically it is worth checking availability structure first before copying. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6153

3 3

[PATCH v4 0/2] MR6130: Added stubs for the EnumerableObjectCollection COM class.
by Kevin Martinez (＠kevinrmartinez) 25 Jul '24

25 Jul '24

Stub added for the IEnumObjects and IObjectCollection interfaces, so that programs won't crash when calling it. Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=53620 https://bugs.winehq.org/show_bug.cgi?id=56891 -- v4: shell32: Added stub for IObjectCollection interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

3 8

[PATCH v3 0/2] MR6130: shell32: Added stub for IEnumObjects interface.
by Kevin Martinez (＠kevinrmartinez) 24 Jul '24

24 Jul '24

Stub added for the IEnumObjects interface, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 -- v3: shell32: Added stub for IObjectCollection interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

4 14

[PATCH v2 0/1] MR6130: shell32: Added stub for IEnumObjects interface.
by Kevin Martinez (＠kevinrmartinez) 24 Jul '24

24 Jul '24

Stub added for the IEnumObjects interface, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 -- v2: shell32: Added stub for IEnumObjects interface https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

3 2

Re: [PATCH v3 0/8] MR6040: d3dx9: Use shared code for loading cube textures from files. - approved
by Alexandre Julliard (＠julliard) 24 Jul '24

24 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6040

1 0

Re: [PATCH v2 0/1] MR6147: wineboot: Downgrade the wineprefix update message to a trace. - approved
by Alexandre Julliard (＠julliard) 24 Jul '24

24 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6147

1 0

Re: [PATCH v2 0/6] MR6149: mshtml: Tweak protocol references handling, use new bindings for HTMLRectCollection. - approved
by Alexandre Julliard (＠julliard) 24 Jul '24

24 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6149

1 0

[PATCH 0/6] MR6149: mshtml: Tweak protocol references handling, use new bindings for HTMLRectCollection.
by Jacek Caban (＠jacek) 24 Jul '24

24 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6149

3 7

[PATCH 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) 24 Jul '24

24 Jul '24

fix: https://bugs.winehq.org/show_bug.cgi?id=56993 Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150

3 4

Re: [PATCH v7 0/1] MR6133: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
by Đorđe Mančić (＠djordjem) 24 Jul '24

24 Jul '24

On Wed Jul 24 16:08:05 2024 +0000, Elizabeth Figura wrote: > Gitlab seems to claim that when it's actually not true, unfortunately. I > don't know if there's anything we can do about it. > I don't think merge requests need to be rebased unless there are > actually merge conflicts. I see, thanks for letting me know about that! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6133#note_76955

1 0

Re: [PATCH v7 0/1] MR6133: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
by Elizabeth Figura (＠zfigura) 24 Jul '24

24 Jul '24

On Wed Jul 24 10:05:49 2024 +0000, Đorđe Mančić wrote: > My bad, sorry. I'm new to contributing to Wine and the GitLab site said > that the merge request can't be approved if I don't rebase, so that's > why I did it. Gitlab seems to claim that when it's actually not true, unfortunately. I don't know if there's anything we can do about it. I don't think merge requests need to be rebased unless there are actually merge conflicts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6133#note_76952

1 0

[PATCH v11 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 24 Jul '24

24 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v11: comclt32: Allow hotkeys for propsheet navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 5

[PATCH 0/2] MR6093: user32/tests: Test repeated AttachThreadInput() calls.
by Zhiyi Zhang (＠zhiyi) 24 Jul '24

24 Jul '24

For example, attaching thread A and B twice but detach them only once, then these two threads should still be attached. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6093

4 8

Re: [PATCH v7 0/1] MR6133: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
by Đorđe Mančić (＠djordjem) 24 Jul '24

24 Jul '24

On Wed Jul 24 10:05:49 2024 +0000, Fabian Maurer wrote: > FWIW, I don't think you need to rebase it, unless there is conflicts. My bad, sorry. I'm new to contributing to Wine and the GitLab site said that the merge request can't be approved if I don't rebase, so that's why I did it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6133#note_76935

1 0

Re: [PATCH v7 0/1] MR6133: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
by Fabian Maurer (＠DarkShadow44) 24 Jul '24

24 Jul '24

FWIW, I don't think you need to rebase it, unless there is conflicts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6133#note_76934

1 0

[PATCH 0/5] MR6148: include/codecapi.h: Add encoder defines.
by Ziqing Hui (＠zhui) 24 Jul '24

24 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6148

3 6

[PATCH 0/3] MR6121: propsys: Initially implement VariantToPropVariant.
by Ziqing Hui (＠zhui) 24 Jul '24

24 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6121

3 8

[PATCH 0/1] MR6147: wineboot: Downgrade the wineprefix update message to a trace.
by Francois Gouget (＠fgouget) 23 Jul '24

23 Jul '24

There is no reason for Wine to unconditionally pollute stderr. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6147

2 1

[PATCH v2 0/8] MR6040: d3dx9: Use shared code for loading cube textures from files.
by Connor McAdams (＠cmcadams) 23 Jul '24

23 Jul '24

Also some patches to address comments made on the last MR. :) -- v2: d3dx9: Add support for loading non-square cubemap DDS files into cube textures. d3dx9: Add support for specifying which array layer to get pixel data from to d3dx_image_get_pixels(). d3dx9: Use d3dx_image structure inside of D3DXCreateCubeTextureFromFileInMemoryEx(). d3dx9: Cleanup texture value argument handling in D3DXCreateCubeTextureFromFileInMemoryEx(). d3dx9: Refactor texture creation and cleanup in D3DXCreateCubeTextureFromFileInMemoryEx(). d3dx9/tests: Add more D3DXCreateCubeTextureFromFileInMemory{Ex}() tests. d3dx9/tests: Reorder test structure members. d3dx9/tests: Make some test structures static const. https://gitlab.winehq.org/wine/wine/-/merge_requests/6040

4 15

2025

2024

2023

2022

wine-gitlab