Fixes bug 54861. The UK Kalender program was crashing when a new event was created as stated in the bug report. The fix is to create all the property sheet pages from the beginning instead of when they are selected.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6146
Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6145
--
v4: mshtml: Implement style msTransform.
mshtml: Implement style msTransition.
mshtml: Compactify the style_props expose tests for each style object into
mshtml/tests: Add more tests with invalid CSS props for
mshtml: Don't use -moz prefix for box-sizing CSS property.
mshtml: Use bitfields for the event BOOL fields.
mshtml: Fix special case between stopImmediatePropagation and setting
mshtml: Implement HTMLEventObj's cancelBubble on top of the underlying
mshtml: Implement event.cancelBubble.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6096
--
v3: mshtml: Implement style msTransform.
mshtml: Implement style msTransition.
mshtml: Compactify the style_props expose tests for each style object into
mshtml/tests: Add more tests with invalid CSS props for
mshtml: Fix box-sizing CSS property.
mshtml: Use bitfields for the event BOOL fields.
mshtml: Fix special case between stopImmediatePropagation and setting
mshtml: Implement HTMLEventObj's cancelBubble on top of the underlying
mshtml: Implement event.cancelBubble.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6096
Overriding the SDL_VIDEODRIVER variable (for Wayland support as an example)
on the Linux side can lead to some games under Wine failing to load (so treat
that variable as special).
--
v5: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5231
On Wed Jul 17 17:16:20 2024 +0000, theofficialgman wrote:
> The issue I am having is when fully emulating x86_64 wine on arm64 using
> the likes of box64/fex/qemu. So the hardcode makes sense why the problem
> is happening. Thanks for the info, I'll look into using
> `get_host_addr_space_limit` for all architectures.
That resolved the issue
@julliard please consider using the `get_host_addr_space_limit` for all architectures as is done with this patch
```
diff --git a/dlls/ntdll/unix/virtual.c b/dlls/ntdll/unix/virtual.c
index 0d88315..87b27fb 100644
--- a/dlls/ntdll/unix/virtual.c
+++ b/dlls/ntdll/unix/virtual.c
@@ -2436,8 +2436,6 @@ static NTSTATUS map_pe_header( void *ptr, size_t size, int fd, BOOL *removable )
return STATUS_SUCCESS; /* page protections will be updated later */
}
-#ifdef __aarch64__
-
/***********************************************************************
* get_host_addr_space_limit
*/
@@ -2464,6 +2462,7 @@ static void *get_host_addr_space_limit(void)
return (void *)((addr << 1) - (granularity_mask + 1));
}
+#ifdef __aarch64__
/***********************************************************************
* alloc_arm64ec_map
@@ -3296,12 +3295,8 @@ void virtual_init(void)
pthread_mutex_init( &virtual_mutex, &attr );
pthread_mutexattr_destroy( &attr );
-#ifdef __aarch64__
host_addr_space_limit = get_host_addr_space_limit();
TRACE( "host addr space limit: %p\n", host_addr_space_limit );
-#else
- host_addr_space_limit = address_space_limit;
-#endif
if (preload_info && *preload_info)
for (i = 0; (*preload_info)[i].size; i++)
```
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76805
This fixes various corner cases.
This is not motivated by any particular application. However, the server-side
code seems at least as simple as the existing client-side code, is more
accurate, and removes a potential source of complication from any future work
involving asyncs.
--
v5: server: Reimplement mailslots using server-side I/O.
ntdll: Respect the "options" argument to NtCreateMailslotFile.
server: Treat completion with error before async_handoff() as error.
kernel32/tests: Add more mailslot tests.
server: Make pipe ends FD_TYPE_DEVICE.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6045
--
v2: mshtml: Implement style msTransform.
mshtml: Implement style msTransition.
mshtml: Compactify the style_props expose tests for each style object into
mshtml: Don't allow vendor prefixed CSS props for style prop operations.
mshtml: Fix box-sizing CSS property.
mshtml: Use bitfields for the event BOOL fields.
mshtml: Fix special case between stopImmediatePropagation and setting
mshtml: Implement HTMLEventObj's cancelBubble on top of the underlying
mshtml: Implement event.cancelBubble.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6096
If a DSN is System wide, we need to write to the HKEY_LOCAL_MACHINE
part of the registry not HKEY_CURRENT_USER which it's currently doing.
--
v6: odbccp32: SQLWritePrivateProfileStringW simplify creating registry keys.
odbccp32: SQLWritePrivateProfileStringW check for existing DSN first.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5812
This fixes various corner cases.
This is not motivated by any particular application. However, the server-side
code seems at least as simple as the existing client-side code, is more
accurate, and removes a potential source of complication from any future work
involving asyncs.
--
v4: server: Reimplement mailslots using server-side I/O.
ntdll: Respect the "options" argument to NtCreateMailslotFile.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6045
If a DSN is System wide, we need to write to the HKEY_LOCAL_MACHINE
part of the registry not HKEY_CURRENT_USER which it's currently doing.
--
v5: odbccp32: SQLWritePrivateProfileStringW simplify creating registry keys.
odbccp32: SQLWritePrivateProfileStringW check for existing DSN first.
odbccp32: SQLGetPrivateProfileString use ConfigMode to determine key retrieval.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5812
Implements GetTempPath2A() and GetTempPath2W() functions without special functionality when a system process calls them.
--
v5: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
https://gitlab.winehq.org/wine/wine/-/merge_requests/6133
Implements GetTempPath2A() and GetTempPath2W() functions without special functionality when a system process calls them.
--
v4: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
https://gitlab.winehq.org/wine/wine/-/merge_requests/6133
Implements GetTempPath2A() and GetTempPath2W() functions without special functionality when a system process calls them.
--
v2: kernelbase: Implement GetTempPath2A() and GetTempPath2W().
https://gitlab.winehq.org/wine/wine/-/merge_requests/6133
Tested with my FEX windows port by setting cpsr bits before rethrowing an exception and observing the resulting eflags in an x86 program with an exception filter. There are no additional mappings (though this could be extended using reserved bits to pass through pf/af)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6128
--
v3: odbc32: Find the driver filename through the ODBCINST.INI key.
odbc32: Fix setting the Driver registry value.
odbc32/tests: Add tests for SQLTransact().
odbc32: Get rid of the wrappers for SQLGetDiagRecA() and SQLDataSourcesA().
odbc32: Avoid a clang warning.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6122
At the moment GL/VK content can only be presented in top-level windows, since child windows are not backed by Wayland surfaces. This MR adds support for such scenarios, in a few gradual steps:
1. Create Wayland (sub)surfaces for all child windows, anchoring them to their parent surface, which may also be a child window surface (i.e., we support GL/VK in nested child windows). This approach works, but it pollutes the compositor with mostly unused, and possibly nested (sub)surfaces. We will deal with this later in the MR.
2. Ensure that the child window (sub)surfaces are properly updated and reconfigured, and support WS_POPUP <-> WS_CHILD style changes (reparenting etc).
3. In the last commit, improve efficiency by creating (sub)surfaces only for the child windows needed by GL/VK, and anchor them directly to the parent toplevel. This removes (sub)surface bloat and unnecessary nesting, the trade-off being some extra complexity when dealing with updates.
Note that this MR doesn't clip GL/VK child window contents at the moment.
The subsurface mechanism introduced in this MR could also handle other kinds of windows in the future, for example display and properly position transient windows, menus etc.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6107
Fixes Bug 23029 (Devil May Cry® 3 Special Edition) (6550) Intro Video is covered by green, transparent square for a majority of it.
Before these patches, surface data for planar formats is not copied
correctly when the application uses a custom allocator-presenter and
allocates a surface of different size than the VMR9 source.
Patch 2/2 adds support for performing this copy correctly when the
source dimensions are less or equal than the rendering surface
dimensions.
---
I have some questions:
- Should I also make it work for when the dst is smaller than the src?
- If not, should the FIXME() in 1/2 be promoted to an error? Otherwise we might have segfaults, writing out of scope.
- Should I use copy_plane(), introduced in 2/2 also in the implementation of the other formats? Changing what needs to be changed to preserve behavior of course.
--
v4: quartz: Properly copy data to render surfaces of planar formats in VMR9.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6069
This is part XXII of cmd.exe engine rewrite.
It tackles bug id 55151. The root cause is that native doesn't
keep the batch/command file opened while processing each command
in that file.
This allows:
- the batch file to delete itself (described in here above mentionned
bug report)
- but also to modify the batch file on the fly...
Quite a bit of refactoring to no longer depend on the file handle as
a reference the batch file.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6116
Attempt to add support for multi [toplevel-collections](https://learn.microsoft.com/en-us/windows-hardware/dr… (TLCs) in HID descriptors.
TLCs are found by iterating over the descriptor once. HID descriptor parser is then called for each TLC individually (no changes in the parser itself). HID reports are bound to their TLC.
A child-pdo is created for each TLC. Each child-pdo registers its input report-id for `pending_reads` in winbus.sys.
--
v2: winebus.sys: Store pending reads per report-id.
hidclass.sys: Create child-pdo per TLC.
hidparse.sys: Pre-process descriptor to find toplevel-collections (TLCs), parse TLCs into CollectionDesc array.
dinput/tests: remove todo for HID multi-tlc tests
https://gitlab.winehq.org/wine/wine/-/merge_requests/6074
Attempt to add support for multi toplevel-collections (TLCs) in HID descriptors.
TLCs are found by iterating over the descriptor once. HID descriptor parser is then called for each TLC individually (no changes in the parser itself). HID reports are bound to their TLC.
A child-pdo is created for each TLC. Each child-pdo registers its input report-id for `pending_reads` in winbus.sys.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6074
--
v8: user32/edit: Add some WM_ASKCBFORMATNAME tests.
user32/tests: Add tests for NULL strings with edit control GETTEXT message.
comctl32/tests: Add tests for NULL strings with edit control GETTEXT message.
user32: Correctly handle NULL string in GETTEXT/CBFORMAT AtoW wrapper.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6004