- wine-gitlab - winehq.org

[PATCH 0/1] MR6095: dwrite: Return correct rendering and gridfit modes from ::GetRecommendedRenderingMode().
by Dmitry Timoshkov (＠dmitry) 18 Jul '24

18 Jul '24

This patch fixes a copy/paste error introduced in 75635053fc810ecd2eaa12a6cd6418d04b301118. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6095

4 3

[PATCH v2 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 18 Jul '24

18 Jul '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v2: comctl32/rebar: Add chevron test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

4 8

[PATCH v9 0/3] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Ilia Docin (＠IDocin) 18 Jul '24

18 Jul '24

-- v9: comctl32/listview: Do not return items count on getting next item for last one. ddraw: Mark failing tests as todo_wine. comctl32/listview: Add LVM_GETNEXTITEM test. https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

5 8

[PATCH 0/1] MR6112: light.msstyles: Add Explorer::ListView subclass.
by Zhiyi Zhang (＠zhiyi) 18 Jul '24

18 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56861 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6112

2 1

[PATCH 0/1] MR6108: gdiplus: Support string alignment in GdipMeasureString.
by Santino Mazza (＠tati1454) 18 Jul '24

18 Jul '24

I tried just using the bound box position calculated by gdip_format_string but I couldn't find a way to get tests to pass. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6108

3 2

[PATCH v4 0/6] MR6042: d3d: Miscellaneous tests/fixes.
by Connor McAdams (＠cmcadams) 17 Jul '24

17 Jul '24

The first two patches here address an issue I encountered when using Wine's d3dx9 with DXVK in the game Command and Conquer 3. The game calls `D3DXLoadSurfaceFromMemory` on a multisampled render target. This ends up going through the `lock_surface()` helper in d3dx9, which eventually calls `UpdateSurface()` in `unlock_surface()` to copy the staging surface back to the multisampled render target. This succeeds on wined3d even though it shouldn't, and fails on DXVK like it should. The second two patches address an issue reported in Empires: Dawn of the Modern World, where the game expects a device reset to reset the scene state. -- v4: wined3d: Clear scene state on device state reset. d3d8/tests: Add a test for device reset after beginning a scene. d3d9/tests: Add a test for device reset after beginning a scene. ddraw/tests: Add tests for preserving d3d scene state during primary surface creation. d3d9: Return failure if a multisampled surface is passed to IDirect3DDevice9::UpdateSurface(). d3d9/tests: Add tests for IDirect3DDevice9::UpdateSurface() with a multisampled surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6042

4 8

Re: [PATCH v2 0/2] MR6099: msado15: Report success in a few functions. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6099

1 0

Re: [PATCH v2 0/1] MR6109: win32u: Implement EVENT_OBJECT_STATECHANGE for WS_DISABLED. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6109

1 0

Re: [PATCH v2 0/1] MR6094: server: Mark the socket as cacheable when it is an accepted or accepted-into socket. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6094

1 0

Re: [PATCH v2 0/1] MR6101: mshtml: Add application/pdf MIME type. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6101

1 0

Re: [PATCH v2 0/6] MR6080: wined3d: Feed FFP shader constants through push constant buffers, part 3. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6080

1 0

Re: [PATCH v3 0/2] MR6026: winemac: Use the new surface shape helper to update window shape. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6026

1 0

Re: [PATCH v3 0/7] MR6036: win32u: Use the thread input and desktop shared memory for reading keyboard state. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6036

1 0

Re: [PATCH v2 0/1] MR6105: winex11: Reset empty window shape even without a window surface. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6105

1 0

Re: [PATCH v2 0/2] MR6106: winhttp test fixes - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6106

1 0

Re: [PATCH v2 0/1] MR6103: odbc32: Return success for handled attributes in SQLSetConnectAttrW. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6103

1 0

Re: [PATCH v3 0/1] MR6102: odbc32: Handle NULL attribute in SQLColAttributeW. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6102

1 0

Re: [PATCH v2 0/1] MR6055: ddraw/tests: Make sure the window is restored after some minimize tests. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6055

1 0

Re: [PATCH v2 0/2] MR6098: odbc32 fixes transact - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6098

1 0

Re: [PATCH v2 0/1] MR6104: light.msstyles: Use slightly darker color for GrayText to make text more readable. - approved
by Alexandre Julliard (＠julliard) 17 Jul '24

17 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6104

1 0

[PATCH 0/1] MR6109: win32u: Implement EVENT_OBJECT_STATECHANGE for WS_DISABLED.
by Esme Povirk (＠madewokherd) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6109

3 2

[PATCH v3 0/4] MR6089: setupapi: Fixes for get_source_info().
by Elizabeth Figura (＠zfigura) 17 Jul '24

17 Jul '24

-- v3: setupapi: Fix testing for a non-empty string in get_source_info(). setupapi/tests: Test installing an INF file with architecture-specific SourceDisks* sections. setupapi: Use SetupGetSourceInfo() in get_source_info(). setupapi: Use SetupGetSourceFileLocation() in get_source_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6089

2 4

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by theofficialgman (＠theofficialgman) 17 Jul '24

17 Jul '24

On Wed Jul 17 17:12:01 2024 +0000, Tim Clem wrote: > Filing a bug is probably the right thing to do. I don't know offhand who > would know best - I'm not very familiar with that area myself. In > ntdll/unix/virtual.c, the address space limit is hardcoded to > 0x7fffffff0000 for x86_64, but on ARM it looks like we try to detect it > (see `get_host_addr_space_limit`). For the bug, it would be interesting > to attach a +virtual log, so we can see what `get_host_addr_space_limit` returned. The issue I am having is when fully emulating x86_64 wine on arm64 using the likes of box64/fex/qemu. So the hardcode makes sense why the problem is happening. Thanks for the info, I'll look into using `get_host_addr_space_limit` for all architectures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76437

1 0

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by Tim Clem (＠tclem) 17 Jul '24

17 Jul '24

On Wed Jul 17 17:12:01 2024 +0000, theofficialgman wrote: > Thanks Tim. Should I file a bug for this then or are you aware of who > might be more knowledgeable about the allocation system and why its > attempting to allocate memory outside of address limit? Filing a bug is probably the right thing to do. I don't know offhand who would know best - I'm not very familiar with that area myself. In ntdll/unix/virtual.c, the address space limit is hardcoded to 0x7fffffff0000 for x86_64, but on ARM it looks like we try to detect it (see `get_host_addr_space_limit`). For the bug, it would be interesting to attach a +virtual log, so we can see what `get_host_addr_space_limit` returned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76436

1 0

[PATCH v2 0/1] MR6097: dxdiagn: Fill szHardwareId for sound render devices.
by Paul Gofman (＠gofman) 17 Jul '24

17 Jul '24

Somehow the field is not present for sound capture devices, at least on my Win11. Fixes Tom Clancy's Splinter Cell: Conviction not finding any sound devices and refusing to start. -- v2: dxdiagn: Fill szHardwareId for sound render devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/6097

2 2

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by theofficialgman (＠theofficialgman) 17 Jul '24

17 Jul '24

Thanks Tim. Should I file a bug for this then or are you aware of who might be more knowledgeable about the allocation system and why its attempting to allocate memory outside of address limit? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76427

1 0

[PATCH 0/4] MR6096: mshtml: event.cancelBubble and some ms* styles implementation.
by Gabriel Ivăncescu (＠insn) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6096

3 8

[PATCH 0/1] MR6101: mshtml: Add application/pdf MIME type.
by Daniel Lehman (＠dlehman25) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6101

3 2

[PATCH 0/6] MR6090: Cmd engine rewrite (part XXI)
by eric pouech (＠epo) 17 Jul '24

17 Jul '24

This is part XX1 of cmd engine rewrite. It covers: - tests & fixes for success/failure of changing current drive, - tests & fixes for success/failure when using pipes, - new implementation of CHOICE command. Notes: - CHOICE is not a builtin command in native cmd.exe, but I kept it builtin for simplicity, - CHOICE was (partially) implemented using syntax from MS-DOS days; it has been moved to use Windows' syntax. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6090

3 7

[PATCH 0/1] MR6094: server: Mark the socket as cacheable when it is an accepted or accepted-into socket.
by Jinoh Kang (＠iamahuman) 17 Jul '24

17 Jul '24

Should fix DJMAX RESPECT V. Fixes: 89f77a93a6c96896d90c943bc3e82139114cf58c Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56977 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6094

5 5

[PATCH 0/6] MR6080: wined3d: Feed FFP shader constants through push constant buffers, part 3.
by Elizabeth Figura (＠zfigura) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6080

4 8

[PATCH 0/2] MR6106: winhttp test fixes
by Hans Leidekker (＠hans) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6106

3 3

[PATCH 0/6] MR6032: include: Convert d3d8.h and d3d9.h to IDLs.
by Elizabeth Figura (＠zfigura) 17 Jul '24

17 Jul '24

This does break compatibility in a few subtle ways. For example, the native headers do not require COBJMACROS, and they include objbase.h. It's not clear to me that these differences matter, but if they do, we can add widl extensions to account for them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6032

6 12

[PATCH 0/1] MR6103: odbc32: Return success for handled attributes in SQLSetConnectAttrW.
by Daniel Lehman (＠dlehman25) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6103

3 2

[PATCH v2 0/1] MR6102: odbc32: Handle NULL attribute in SQLColAttributeW.
by Daniel Lehman (＠dlehman25) 17 Jul '24

17 Jul '24

-- v2: odbc32: Handle NULL attribute in SQLColAttribute[W]. https://gitlab.winehq.org/wine/wine/-/merge_requests/6102

4 3

[PATCH 0/1] MR6055: ddraw/tests: Make sure the window is restored after some minimize tests.
by Rémi Bernon (＠rbernon) 17 Jul '24

17 Jul '24

Similar to f5ee314270d7bc0b476b3c64840b52bcc1853a13 for ddraw1 tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6055

4 3

[PATCH v3 0/6] MR6042: d3d: Miscellaneous tests/fixes.
by Connor McAdams (＠cmcadams) 17 Jul '24

17 Jul '24

The first two patches here address an issue I encountered when using Wine's d3dx9 with DXVK in the game Command and Conquer 3. The game calls `D3DXLoadSurfaceFromMemory` on a multisampled render target. This ends up going through the `lock_surface()` helper in d3dx9, which eventually calls `UpdateSurface()` in `unlock_surface()` to copy the staging surface back to the multisampled render target. This succeeds on wined3d even though it shouldn't, and fails on DXVK like it should. The second two patches address an issue reported in Empires: Dawn of the Modern World, where the game expects a device reset to reset the scene state. -- v3: wined3d: Clear scene state on device state reset. d3d8/tests: Add a test for device reset after beginning a scene. d3d9/tests: Add a test for device reset after beginning a scene. https://gitlab.winehq.org/wine/wine/-/merge_requests/6042

4 10

[PATCH 0/2] MR6098: odbc32 fixes transact
by Alistair Leslie-Hughes (＠alesliehughes) 17 Jul '24

17 Jul '24

Wine doesn't handle Pooling as yet and in my scenario it's set to 0 (No Pooling), so not an issue but requires a successful return value. SQLTransact incorrectly assumed that if either handle was NULL an error occurred. I'm seeing a call where the Environment handle is NULL, even unixODBC handles this scenario. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6098

3 3

[PATCH v2 0/7] MR6036: win32u: Use the thread input and desktop shared memory for reading keyboard state.
by Rémi Bernon (＠rbernon) 17 Jul '24

17 Jul '24

-- v2: win32u: Use the thread input shared memory for GetKeyState. server: Expose the thread input keystate lock through shared memory. server: Make the get_key_state request key code mandatory. win32u: Use the desktop shared memory in get_async_keyboard_state. win32u: Use the thread input shared memory in GetKeyboardState. win32u: Introduce a new NtUserGetAsyncKeyboardState call. server: Expose the thread input keystate through shared memory. https://gitlab.winehq.org/wine/wine/-/merge_requests/6036

3 10

[PATCH 0/1] MR6105: winex11: Reset empty window shape even without a window surface.
by Rémi Bernon (＠rbernon) 17 Jul '24

17 Jul '24

And invalidate the window surface shape if any, so that it gets updated again in update_surface_region if the window is actually shaped. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56972 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6105

2 1

[PATCH 0/1] MR6104: light.msstyles: Use slightly darker color for GrayText to make text more readable.
by Dmitry Timoshkov (＠dmitry) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6104

4 3

[PATCH v2 0/2] MR6026: winemac: Use the new surface shape helper to update window shape.
by Rémi Bernon (＠rbernon) 17 Jul '24

17 Jul '24

-- v2: winemac: Use window surface shape for window shape region. winemac: Use window surface shape for color key transparency. https://gitlab.winehq.org/wine/wine/-/merge_requests/6026

2 3

[PATCH v2 0/2] MR6084: opengl32: Serialize debug callbacks message string.
by Rémi Bernon (＠rbernon) 17 Jul '24

17 Jul '24

-- v2: opengl32: Serialize debug callbacks message string. opengl32: Use integer types in debug callbacks parameter structs. https://gitlab.winehq.org/wine/wine/-/merge_requests/6084

2 3

[PATCH v2 0/3] MR6083: winevulkan: Serialize debug callbacks parameter structures.
by Rémi Bernon (＠rbernon) 17 Jul '24

17 Jul '24

-- v2: winevulkan: Serialize debug callbacks parameter structures. winevulkan: Use integer types in debug callbacks parameter structs. winevulkan: Fix incorrect 32->64 conversion of debug callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/6083

2 4

[PATCH 0/1] MR6102: odbc32: Handle NULL attribute in SQLColAttributeW.
by Daniel Lehman (＠dlehman25) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6102

2 1

Re: [PATCH v2 0/1] MR5979: Draft: mfreadwrite: Use GPU copy when available.
by Brendan McGrath (＠redmcg) 17 Jul '24

17 Jul '24

Marking this as draft for now, as I need to revisit it at some point. If removing the copy is possible, that would be even better than optimizing it. In which case the final solution may look very different to the one here (resulting in the closure of this MR). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5979#note_76372

1 0

[PATCH 0/2] MR6099: msado15: Report success in a few functions.
by Alistair Leslie-Hughes (＠alesliehughes) 17 Jul '24

17 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6099

3 3

Re: [PATCH v2 0/5] MR6064: Fix GCC14 warnings. - approved
by Alexandre Julliard (＠julliard) 16 Jul '24

16 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6064

1 0

Re: [PATCH v5 0/1] MR5852: win32u: Implement EVENT_OBJECT_DESTROY. - approved
by Alexandre Julliard (＠julliard) 16 Jul '24

16 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5852

1 0

Re: [PATCH v3 0/1] MR6088: include: Fix return type of IXAudio2MasteringVoice::GetChannelMask in xaudio2.idl - approved
by Alexandre Julliard (＠julliard) 16 Jul '24

16 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6088

1 0

Re: [PATCH v2 0/1] MR5959: ntdll: Prevent double close in error case (coverity) - approved
by Alexandre Julliard (＠julliard) 16 Jul '24

16 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5959

1 0

Re: [PATCH v2 0/6] MR6090: Cmd engine rewrite (part XXI) - approved
by Alexandre Julliard (＠julliard) 16 Jul '24

16 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6090

1 0

Re: [PATCH v8 0/1] MR6063: odbc32 fixes - approved
by Alexandre Julliard (＠julliard) 16 Jul '24

16 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

1 0

Re: [PATCH v2 0/10] MR6092: mshtml: Use new bindings for DOM nodes. - approved
by Alexandre Julliard (＠julliard) 16 Jul '24

16 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6092

1 0

Re: [PATCH v2 0/2] MR6091: winhttp/tests: Add some more tests for string options in WinHttpQueryOption(). - approved
by Alexandre Julliard (＠julliard) 16 Jul '24

16 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6091

1 0

[PATCH 0/1] MR6097: dxdiagn: Fill szHardwareId for sound render devices.
by Paul Gofman (＠gofman) 16 Jul '24

16 Jul '24

Somehow the field is not present for sound capture devices, at least on my Win11. Fixes Tom Clancy's Splinter Cell: Conviction not finding any sound devices and refusing to start. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6097

3 2

[PATCH v2 0/4] MR6089: setupapi: Fixes for get_source_info().
by Elizabeth Figura (＠zfigura) 16 Jul '24

16 Jul '24

-- v2: setupapi: Use SetupGetIntField() in SetupGetSourceFileLocation(). setupapi: Return the file's relative path from SetupGetSourceFileLocation(). setupapi: Correctly interpret the INFCONTEXT parameter in SetupGetSourceFileLocation(). setupapi/tests: Add more tests for SetupGetSourceFileLocation(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6089

3 5

[PATCH v2 0/1] MR6088: include: Fix return type of IXAudio2MasteringVoice::GetChannelMask in xaudio2.idl
by Biswapriyo Nath (＠Biswa96) 16 Jul '24

16 Jul '24

-- v2: include: Fix return type of IXAudio2MasteringVoice::GetChannelMask in xaudio2.idl https://gitlab.winehq.org/wine/wine/-/merge_requests/6088

3 2

[PATCH 0/1] MR6088: include: Fix return type of IXAudio2MasteringVoice::GetChannelMask in xaudio2.idl
by Biswapriyo Nath (＠Biswa96) 16 Jul '24

16 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6088

3 4

Re: [PATCH v3 0/5] MR5946: Feed FFP shader constants through push constant buffers, part 2.
by Elizabeth Figura (＠zfigura) 16 Jul '24

16 Jul '24

On Tue Jul 16 16:03:49 2024 +0000, Rémi Bernon wrote: > Fwiw 65165cf8520f85ac327115536749cda1aabef77b causes some ddraw tests failures. Yep, already addressed in 6080. Sorry, I don't know how this one slipped past me, I know I ran the tests... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5946#note_76331

1 0

[PATCH 0/1] MR5959: ntdll: Prevent double close in error case (coverity)
by Fabian Maurer (＠DarkShadow44) 16 Jul '24

16 Jul '24

If we do a break, fd might be closed again -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5959

3 3

[PATCH 0/10] MR6092: mshtml: Use new bindings for DOM nodes.
by Jacek Caban (＠jacek) 16 Jul '24

16 Jul '24

Except for nodes with custom properties, those still need more work on the infrastructure. jscript change is just minimum needed to allow objects with only builtin properties to preserve their current behavior, I have more tweaks for that area queued for "async" custom properties. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6092

3 11

[PATCH 0/2] MR6091: winhttp/tests: Add some more tests for string options in WinHttpQueryOption().
by Nikolay Sivov (＠nsivov) 16 Jul '24

16 Jul '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6091

4 4

[PATCH v7 0/1] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 16 Jul '24

16 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- v7: odbc32: SQLError/W handle NULL handles https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

4 3

Re: [PATCH v3 0/5] MR5946: Feed FFP shader constants through push constant buffers, part 2.
by Rémi Bernon (＠rbernon) 16 Jul '24

16 Jul '24

Fwiw 65165cf8520f85ac327115536749cda1aabef77b causes some ddraw tests failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5946#note_76313

1 0

[PATCH v6 0/1] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 16 Jul '24

16 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- v6: odbc32: SQLError/W handle NULL handles https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

3 2

[PATCH 0/4] MR6089: setupapi: Fixes for get_source_info().
by Elizabeth Figura (＠zfigura) 16 Jul '24

16 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6089

3 5

[PATCH v3 0/2] MR6069: quartz: Properly copy data to render surfaces of planar formats in VMR9.
by Francisco Casas (＠fcasas) 15 Jul '24

15 Jul '24

Fixes Bug 23029 (Devil May Cry® 3 Special Edition) (6550) Intro Video is covered by green, transparent square for a majority of it. Before these patches, surface data for planar formats is not copied correctly when the application uses a custom allocator-presenter and allocates a surface of different size than the VMR9 source. Patch 2/2 adds support for performing this copy correctly when the source dimensions are less or equal than the rendering surface dimensions. --- I have some questions: - Should I also make it work for when the dst is smaller than the src? - If not, should the FIXME() in 1/2 be promoted to an error? Otherwise we might have segfaults, writing out of scope. - Should I use copy_plane(), introduced in 2/2 also in the implementation of the other formats? Changing what needs to be changed to preserve behavior of course. -- v3: quartz: Properly copy data to render surfaces of planar formats in VMR9. https://gitlab.winehq.org/wine/wine/-/merge_requests/6069

3 4

[PATCH v3 0/4] MR6045: server: Reimplement mailslots using server-side I/O.
by Elizabeth Figura (＠zfigura) 15 Jul '24

15 Jul '24

This fixes various corner cases. This is not motivated by any particular application. However, the server-side code seems at least as simple as the existing client-side code, is more accurate, and removes a potential source of complication from any future work involving asyncs. -- v3: server: Reimplement mailslots using server-side I/O. server: Treat completion with error before async_handoff() as error. kernel32/tests: Add more mailslot tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6045

3 5

Re: [PATCH v2 0/2] MR6065: Dump comment streams from minidump. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6065

1 0

Re: [PATCH v3 0/4] MR6078: setupapi: Fixes for SetupGetSourceFileLocation(). - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6078

1 0

Re: [PATCH v2 0/7] MR6082: mshtml: Use new bindings for more objects. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6082

1 0

Re: [PATCH v2 0/1] MR6071: shell32: Put temp directory in %LOCALAPPDATA%\Temp by default. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6071

1 0

Re: [PATCH v2 0/1] MR6086: odbc32: Correct 'WINAPI' placement for function pointers. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6086

1 0

Re: [PATCH v2 0/8] MR6085: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 1). - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6085

1 0

Re: [PATCH v3 0/1] MR6068: mshtml: Make sure we aren't detached before setting interactive ready state. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6068

1 0

Re: [PATCH v4 0/1] MR6067: jscript: Make JS_COUNT_OPERATION a no-op. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6067

1 0

Re: [PATCH v3 0/1] MR6070: mshtml: Zero output iface on failure in get_document_node(). - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6070

1 0

[PATCH v2 0/2] MR6069: quartz: Properly copy data to render surfaces of planar formats in VMR9.
by Francisco Casas (＠fcasas) 15 Jul '24

15 Jul '24

Fixes Bug 23029 (Devil May Cry® 3 Special Edition) (6550) Intro Video is covered by green, transparent square for a majority of it. Before these patches, surface data for planar formats is not copied correctly when the application uses a custom allocator-presenter and allocates a surface of different size than the VMR9 source. Patch 2/2 adds support for performing this copy correctly when the source dimensions are less or equal than the rendering surface dimensions. --- I have some questions: - Should I also make it work for when the dst is smaller than the src? - If not, should the FIXME() in 1/2 be promoted to an error? Otherwise we might have segfaults, writing out of scope. - Should I use copy_plane(), introduced in 2/2 also in the implementation of the other formats? Changing what needs to be changed to preserve behavior of course. -- v2: quartz: Properly copy data to render surfaces of planar formats in VMR9. quartz: Emit FIXME when the rendering surface is smaller than the source in VMR9. https://gitlab.winehq.org/wine/wine/-/merge_requests/6069

3 3

[PATCH v2 0/6] MR6042: d3d9: Miscellaneous tests/fixes.
by Connor McAdams (＠cmcadams) 15 Jul '24

15 Jul '24

The first two patches here address an issue I encountered when using Wine's d3dx9 with DXVK in the game Command and Conquer 3. The game calls `D3DXLoadSurfaceFromMemory` on a multisampled render target. This ends up going through the `lock_surface()` helper in d3dx9, which eventually calls `UpdateSurface()` in `unlock_surface()` to copy the staging surface back to the multisampled render target. This succeeds on wined3d even though it shouldn't, and fails on DXVK like it should. The second two patches address an issue reported in Empires: Dawn of the Modern World, where the game expects a device reset to reset the scene state. -- v2: wined3d: Clear scene state on device state reset. d3d8/tests: Add a test for device reset after beginning a scene. d3d9/tests: Add a test for device reset after beginning a scene. ddraw/tests: Add tests for preserving d3d scene state during primary surface creation. d3d9: Return failure if a multisampled surface is passed to IDirect3DDevice9::UpdateSurface(). d3d9/tests: Add tests for IDirect3DDevice9::UpdateSurface() with a multisampled surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6042

4 10

[PATCH 0/1] MR6079: shell32: Strip trailing spaces from lpFile in SHELL_execute.
by Louis Lenders (＠xe) 15 Jul '24

15 Jul '24

https://bugs.winehq.org/show_bug.cgi?id=56940 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6079

4 3

[PATCH v2 0/1] MR6068: mshtml: Make sure we aren't detached before setting interactive ready state.
by Gabriel Ivăncescu (＠insn) 15 Jul '24

15 Jul '24

-- v2: mshtml: Make sure we aren't detached before setting interactive ready state. https://gitlab.winehq.org/wine/wine/-/merge_requests/6068

3 2

[PATCH v3 0/1] MR6067: jscript: Make JS_COUNT_OPERATION a no-op.
by Gabriel Ivăncescu (＠insn) 15 Jul '24

15 Jul '24

-- v3: jscript: Make JS_COUNT_OPERATION a no-op. https://gitlab.winehq.org/wine/wine/-/merge_requests/6067

3 2

[PATCH v2 0/1] MR6070: mshtml: Zero output iface on failure in get_document_node().
by Paul Gofman (＠gofman) 15 Jul '24

15 Jul '24

The interface is later checked for NULL, this avoids crashes in case of failure here. -- v2: mshtml: Check get_document_node() result in get_node(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6070

3 3

[PATCH v3 0/6] MR6072: server, kernelbase: Force WoW sharing on HKCU/Software key.
by Paul Gofman (＠gofman) 15 Jul '24

15 Jul '24

-- v3: ntdll/tests: Add tests for WoW shared HKCU/Software key. https://gitlab.winehq.org/wine/wine/-/merge_requests/6072

2 7

[PATCH 0/1] MR6086: odbc32: Correct 'WINAPI' placement for function pointers.
by Dmitry Timoshkov (＠dmitry) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6086

2 1

[PATCH 0/8] MR6085: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 1).
by Hans Leidekker (＠hans) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6085

3 9

[PATCH v2 0/7] MR6081: win32u: Merge drivers CreateLayeredWindow with CreateWindowSurface.
by Rémi Bernon (＠rbernon) 15 Jul '24

15 Jul '24

-- v2: win32u: Merge drivers CreateLayeredWindow with CreateWindowSurface. win32u: Avoid sending WM_PAINT to layered window surfaces. winemac: Rely on win32u previous surface reuse. winewayland: Rely on win32u previous surface reuse. wineandroid: Rely on win32u previous surface reuse. winex11: Rely on win32u previous surface reuse. win32u: Simplify offscreen surface previous surface reuse check. https://gitlab.winehq.org/wine/wine/-/merge_requests/6081

2 9

[PATCH v5 0/1] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 15 Jul '24

15 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- v5: odbc32: SQLError/W handle NULL handles https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

4 3

[PATCH 0/2] MR6084: opengl32: Serialize debug callbacks message string.
by Rémi Bernon (＠rbernon) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6084

2 2

[PATCH 0/2] MR6083: winevulkan: Serialize debug callbacks parameter structures.
by Rémi Bernon (＠rbernon) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6083

2 2

[PATCH v2 0/2] MR6067: jscript: Use actual object disp for the return value when defining property.
by Gabriel Ivăncescu (＠insn) 15 Jul '24

15 Jul '24

-- v2: jscript: Use actual object disp for the return value when defining property. jscript: Make JS_COUNT_OPERATION a no-op. https://gitlab.winehq.org/wine/wine/-/merge_requests/6067

3 4

[PATCH 0/7] MR6082: mshtml: Use new bindings for more objects.
by Jacek Caban (＠jacek) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6082

2 7

Re: [PATCH v3 0/3] MR6076: oleaut32: Convert 32-bit or 16-bit color bitmaps to 24-bit color DIBs when saving.
by Akihiro Sagawa (＠sgwaki) 15 Jul '24

15 Jul '24

v2: Fix a handle leak on error path v3: Rebased -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6076#note_76217

1 0

[PATCH 0/7] MR6081: win32u: Merge drivers CreateLayeredWindow with CreateWindowSurface.
by Rémi Bernon (＠rbernon) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6081

2 7

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 14 Jul '24

14 Jul '24

Any news? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_76155

1 0

Re: [PATCH v3 0/1] MR5340: maintainers: Remove MF GStreamer section. - approved
by Alexandre Julliard (＠julliard) 14 Jul '24

14 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5340

1 0

Re: [PATCH v2 0/1] MR6077: ucrtbase: Fix FILE no buffering flag value. - approved
by Alexandre Julliard (＠julliard) 14 Jul '24

14 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6077

1 0

Re: [PATCH v2 0/1] MR6073: msv1_0: Set mode in ntlm_check_version - approved
by Alexandre Julliard (＠julliard) 14 Jul '24

14 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6073

1 0

[PATCH 0/4] MR6078: setupapi: Fixes for SetupGetSourceFileLocation().
by Elizabeth Figura (＠zfigura) 14 Jul '24

14 Jul '24

Preparation for fixing bug 48455. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6078

3 5

2025

2024

2023

2022

wine-gitlab