- wine-gitlab - winehq.org

[PATCH 0/1] MR5959: ntdll: Prevent double close in error case (coverity)
by Fabian Maurer (＠DarkShadow44) 16 Jul '24

16 Jul '24

If we do a break, fd might be closed again -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5959

3 3

[PATCH 0/10] MR6092: mshtml: Use new bindings for DOM nodes.
by Jacek Caban (＠jacek) 16 Jul '24

16 Jul '24

Except for nodes with custom properties, those still need more work on the infrastructure. jscript change is just minimum needed to allow objects with only builtin properties to preserve their current behavior, I have more tweaks for that area queued for "async" custom properties. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6092

3 11

[PATCH 0/2] MR6091: winhttp/tests: Add some more tests for string options in WinHttpQueryOption().
by Nikolay Sivov (＠nsivov) 16 Jul '24

16 Jul '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6091

4 4

[PATCH v7 0/1] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 16 Jul '24

16 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- v7: odbc32: SQLError/W handle NULL handles https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

4 3

Re: [PATCH v3 0/5] MR5946: Feed FFP shader constants through push constant buffers, part 2.
by Rémi Bernon (＠rbernon) 16 Jul '24

16 Jul '24

Fwiw 65165cf8520f85ac327115536749cda1aabef77b causes some ddraw tests failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5946#note_76313

1 0

[PATCH v6 0/1] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 16 Jul '24

16 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- v6: odbc32: SQLError/W handle NULL handles https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

3 2

[PATCH 0/4] MR6089: setupapi: Fixes for get_source_info().
by Elizabeth Figura (＠zfigura) 16 Jul '24

16 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6089

3 5

[PATCH v3 0/2] MR6069: quartz: Properly copy data to render surfaces of planar formats in VMR9.
by Francisco Casas (＠fcasas) 15 Jul '24

15 Jul '24

Fixes Bug 23029 (Devil May Cry® 3 Special Edition) (6550) Intro Video is covered by green, transparent square for a majority of it. Before these patches, surface data for planar formats is not copied correctly when the application uses a custom allocator-presenter and allocates a surface of different size than the VMR9 source. Patch 2/2 adds support for performing this copy correctly when the source dimensions are less or equal than the rendering surface dimensions. --- I have some questions: - Should I also make it work for when the dst is smaller than the src? - If not, should the FIXME() in 1/2 be promoted to an error? Otherwise we might have segfaults, writing out of scope. - Should I use copy_plane(), introduced in 2/2 also in the implementation of the other formats? Changing what needs to be changed to preserve behavior of course. -- v3: quartz: Properly copy data to render surfaces of planar formats in VMR9. https://gitlab.winehq.org/wine/wine/-/merge_requests/6069

3 4

[PATCH v3 0/4] MR6045: server: Reimplement mailslots using server-side I/O.
by Elizabeth Figura (＠zfigura) 15 Jul '24

15 Jul '24

This fixes various corner cases. This is not motivated by any particular application. However, the server-side code seems at least as simple as the existing client-side code, is more accurate, and removes a potential source of complication from any future work involving asyncs. -- v3: server: Reimplement mailslots using server-side I/O. server: Treat completion with error before async_handoff() as error. kernel32/tests: Add more mailslot tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6045

3 5

Re: [PATCH v2 0/2] MR6065: Dump comment streams from minidump. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6065

1 0

Re: [PATCH v3 0/4] MR6078: setupapi: Fixes for SetupGetSourceFileLocation(). - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6078

1 0

Re: [PATCH v2 0/7] MR6082: mshtml: Use new bindings for more objects. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6082

1 0

Re: [PATCH v2 0/1] MR6071: shell32: Put temp directory in %LOCALAPPDATA%\Temp by default. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6071

1 0

Re: [PATCH v2 0/1] MR6086: odbc32: Correct 'WINAPI' placement for function pointers. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6086

1 0

Re: [PATCH v2 0/8] MR6085: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 1). - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6085

1 0

Re: [PATCH v3 0/1] MR6068: mshtml: Make sure we aren't detached before setting interactive ready state. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6068

1 0

Re: [PATCH v4 0/1] MR6067: jscript: Make JS_COUNT_OPERATION a no-op. - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6067

1 0

Re: [PATCH v3 0/1] MR6070: mshtml: Zero output iface on failure in get_document_node(). - approved
by Alexandre Julliard (＠julliard) 15 Jul '24

15 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6070

1 0

[PATCH v2 0/2] MR6069: quartz: Properly copy data to render surfaces of planar formats in VMR9.
by Francisco Casas (＠fcasas) 15 Jul '24

15 Jul '24

Fixes Bug 23029 (Devil May Cry® 3 Special Edition) (6550) Intro Video is covered by green, transparent square for a majority of it. Before these patches, surface data for planar formats is not copied correctly when the application uses a custom allocator-presenter and allocates a surface of different size than the VMR9 source. Patch 2/2 adds support for performing this copy correctly when the source dimensions are less or equal than the rendering surface dimensions. --- I have some questions: - Should I also make it work for when the dst is smaller than the src? - If not, should the FIXME() in 1/2 be promoted to an error? Otherwise we might have segfaults, writing out of scope. - Should I use copy_plane(), introduced in 2/2 also in the implementation of the other formats? Changing what needs to be changed to preserve behavior of course. -- v2: quartz: Properly copy data to render surfaces of planar formats in VMR9. quartz: Emit FIXME when the rendering surface is smaller than the source in VMR9. https://gitlab.winehq.org/wine/wine/-/merge_requests/6069

3 3

[PATCH v2 0/6] MR6042: d3d9: Miscellaneous tests/fixes.
by Connor McAdams (＠cmcadams) 15 Jul '24

15 Jul '24

The first two patches here address an issue I encountered when using Wine's d3dx9 with DXVK in the game Command and Conquer 3. The game calls `D3DXLoadSurfaceFromMemory` on a multisampled render target. This ends up going through the `lock_surface()` helper in d3dx9, which eventually calls `UpdateSurface()` in `unlock_surface()` to copy the staging surface back to the multisampled render target. This succeeds on wined3d even though it shouldn't, and fails on DXVK like it should. The second two patches address an issue reported in Empires: Dawn of the Modern World, where the game expects a device reset to reset the scene state. -- v2: wined3d: Clear scene state on device state reset. d3d8/tests: Add a test for device reset after beginning a scene. d3d9/tests: Add a test for device reset after beginning a scene. ddraw/tests: Add tests for preserving d3d scene state during primary surface creation. d3d9: Return failure if a multisampled surface is passed to IDirect3DDevice9::UpdateSurface(). d3d9/tests: Add tests for IDirect3DDevice9::UpdateSurface() with a multisampled surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6042

4 10

[PATCH 0/1] MR6079: shell32: Strip trailing spaces from lpFile in SHELL_execute.
by Louis Lenders (＠xe) 15 Jul '24

15 Jul '24

https://bugs.winehq.org/show_bug.cgi?id=56940 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6079

4 3

[PATCH v2 0/1] MR6068: mshtml: Make sure we aren't detached before setting interactive ready state.
by Gabriel Ivăncescu (＠insn) 15 Jul '24

15 Jul '24

-- v2: mshtml: Make sure we aren't detached before setting interactive ready state. https://gitlab.winehq.org/wine/wine/-/merge_requests/6068

3 2

[PATCH v3 0/1] MR6067: jscript: Make JS_COUNT_OPERATION a no-op.
by Gabriel Ivăncescu (＠insn) 15 Jul '24

15 Jul '24

-- v3: jscript: Make JS_COUNT_OPERATION a no-op. https://gitlab.winehq.org/wine/wine/-/merge_requests/6067

3 2

[PATCH v2 0/1] MR6070: mshtml: Zero output iface on failure in get_document_node().
by Paul Gofman (＠gofman) 15 Jul '24

15 Jul '24

The interface is later checked for NULL, this avoids crashes in case of failure here. -- v2: mshtml: Check get_document_node() result in get_node(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6070

3 3

[PATCH v3 0/6] MR6072: server, kernelbase: Force WoW sharing on HKCU/Software key.
by Paul Gofman (＠gofman) 15 Jul '24

15 Jul '24

-- v3: ntdll/tests: Add tests for WoW shared HKCU/Software key. https://gitlab.winehq.org/wine/wine/-/merge_requests/6072

2 7

[PATCH 0/1] MR6086: odbc32: Correct 'WINAPI' placement for function pointers.
by Dmitry Timoshkov (＠dmitry) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6086

2 1

[PATCH 0/8] MR6085: odbc32: Forward ANSI functions to their Unicode counterpart if needed (part 1).
by Hans Leidekker (＠hans) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6085

3 9

[PATCH v2 0/7] MR6081: win32u: Merge drivers CreateLayeredWindow with CreateWindowSurface.
by Rémi Bernon (＠rbernon) 15 Jul '24

15 Jul '24

-- v2: win32u: Merge drivers CreateLayeredWindow with CreateWindowSurface. win32u: Avoid sending WM_PAINT to layered window surfaces. winemac: Rely on win32u previous surface reuse. winewayland: Rely on win32u previous surface reuse. wineandroid: Rely on win32u previous surface reuse. winex11: Rely on win32u previous surface reuse. win32u: Simplify offscreen surface previous surface reuse check. https://gitlab.winehq.org/wine/wine/-/merge_requests/6081

2 9

[PATCH v5 0/1] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 15 Jul '24

15 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- v5: odbc32: SQLError/W handle NULL handles https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

4 3

[PATCH 0/2] MR6084: opengl32: Serialize debug callbacks message string.
by Rémi Bernon (＠rbernon) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6084

2 2

[PATCH 0/2] MR6083: winevulkan: Serialize debug callbacks parameter structures.
by Rémi Bernon (＠rbernon) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6083

2 2

[PATCH v2 0/2] MR6067: jscript: Use actual object disp for the return value when defining property.
by Gabriel Ivăncescu (＠insn) 15 Jul '24

15 Jul '24

-- v2: jscript: Use actual object disp for the return value when defining property. jscript: Make JS_COUNT_OPERATION a no-op. https://gitlab.winehq.org/wine/wine/-/merge_requests/6067

3 4

[PATCH 0/7] MR6082: mshtml: Use new bindings for more objects.
by Jacek Caban (＠jacek) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6082

2 7

Re: [PATCH v3 0/3] MR6076: oleaut32: Convert 32-bit or 16-bit color bitmaps to 24-bit color DIBs when saving.
by Akihiro Sagawa (＠sgwaki) 15 Jul '24

15 Jul '24

v2: Fix a handle leak on error path v3: Rebased -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6076#note_76217

1 0

[PATCH 0/7] MR6081: win32u: Merge drivers CreateLayeredWindow with CreateWindowSurface.
by Rémi Bernon (＠rbernon) 15 Jul '24

15 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6081

2 7

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 14 Jul '24

14 Jul '24

Any news? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_76155

1 0

Re: [PATCH v3 0/1] MR5340: maintainers: Remove MF GStreamer section. - approved
by Alexandre Julliard (＠julliard) 14 Jul '24

14 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5340

1 0

Re: [PATCH v2 0/1] MR6077: ucrtbase: Fix FILE no buffering flag value. - approved
by Alexandre Julliard (＠julliard) 14 Jul '24

14 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6077

1 0

Re: [PATCH v2 0/1] MR6073: msv1_0: Set mode in ntlm_check_version - approved
by Alexandre Julliard (＠julliard) 14 Jul '24

14 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6073

1 0

[PATCH 0/4] MR6078: setupapi: Fixes for SetupGetSourceFileLocation().
by Elizabeth Figura (＠zfigura) 14 Jul '24

14 Jul '24

Preparation for fixing bug 48455. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6078

3 5

[PATCH 0/1] MR6077: ucrtbase: Fix FILE no buffering flag value.
by Piotr Caban (＠piotr) 14 Jul '24

14 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56956 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6077

3 2

[PATCH 0/3] MR6076: oleaut32: Convert 32-bit or 16-bit color bitmaps to 24-bit color DIBs when saving.
by Akihiro Sagawa (＠sgwaki) 14 Jul '24

14 Jul '24

Instead of 32-bit or 16-bit per pixel format with BI_BITFIELDS. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56246 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6076

3 4

Re: [PATCH v5 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script.
by Akihiro Sagawa (＠sgwaki) 14 Jul '24

14 Jul '24

I created a vertical writing demo and attached it to the bug report --- https://bugs.winehq.org/show_bug.cgi?id=56658#c4 . I hope this helps you to test my patch in your environment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633#note_76093

1 0

[PATCH v4 0/1] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 14 Jul '24

14 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- v4: odbc32: SQLError/W handle NULL handles https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

4 3

[PATCH 0/3] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 14 Jul '24

14 Jul '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

4 5

[PATCH 0/1] MR6070: mshtml: Zero output iface on failure in get_document_node().
by Paul Gofman (＠gofman) 13 Jul '24

13 Jul '24

The interface is later checked for NULL, this avoids crashes in case of failure here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6070

3 2

[PATCH v2 0/5] MR6072: server, kernelbase: Force WoW sharing on HKCU/Software key.
by Paul Gofman (＠gofman) 13 Jul '24

13 Jul '24

-- v2: advapi32/tests: Add tests for WoW shared HKCU/Software key. kernelbase: Force WoW sharing on HKCU/Software key. https://gitlab.winehq.org/wine/wine/-/merge_requests/6072

3 7

[PATCH v8 0/3] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Ilia Docin (＠IDocin) 13 Jul '24

13 Jul '24

-- v8: comctl32/listview: Do not return items count on getting next item for last one ddraw: Mark failing tests todo_wine comctl32/listview: Add LVM_GETNEXTITEM test https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

3 4

[PATCH v7 0/5] MR6004: comctl32: A NULL string fix.
by Aida Jonikienė (＠DodoGTA) 13 Jul '24

13 Jul '24

-- v7: user32/edit: Add some WM_ASKCBFORMATNAME tests. user32/tests: Add tests for NULL strings with edit control GETTEXT message. comctl32/tests: Add tests for NULL strings with edit control GETTEXT message. user32: Fail on NULL string for edit control WM_GETTEXT message. comctl32: Fail on NULL string for edit control WM_GETTEXT message. https://gitlab.winehq.org/wine/wine/-/merge_requests/6004

2 5

[PATCH v6 0/5] MR6004: comctl32: A NULL string fix.
by Aida Jonikienė (＠DodoGTA) 13 Jul '24

13 Jul '24

-- v6: user32/edit: Add some WM_ASKCBFORMATNAME tests. user32/tests: Add tests for NULL strings with edit control GETTEXT message. comctl32/tests: Add tests for NULL strings with edit control GETTEXT message. user32: Fail on NULL string for edit control WM_GETTEXT message. comctl32: Fail on NULL string for edit control WM_GETTEXT message. https://gitlab.winehq.org/wine/wine/-/merge_requests/6004

2 5

[PATCH 0/1] MR6073: msv1_0: Set mode in ntlm_check_version
by Fabian Maurer (＠DarkShadow44) 13 Jul '24

13 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56954 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6073

3 2

[PATCH v5 0/4] MR6004: comctl32: A NULL string fix.
by Aida Jonikienė (＠DodoGTA) 13 Jul '24

13 Jul '24

-- v5: user32/edit: Add some WM_ASKCBFORMATNAME tests. comctl32/user32: Add tests for NULL strings with edit control GETTEXT message. user32: Correctly handle NULL string in GETTEXT/CBFORMAT AtoW wrapper. comctl32/user32: Fail on NULL string for edit control WM_GETTEXT message. https://gitlab.winehq.org/wine/wine/-/merge_requests/6004

3 10

Re: [PATCH v7 0/1] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Zhiyi Zhang (＠zhiyi) 13 Jul '24

13 Jul '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } > > +static void test_LVM_GETNEXTITEM(void) Please add the tests first and put them in a separate commit. You can mark the tests that are failing on Wine with a todo_wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_76062

1 0

[PATCH v3 0/1] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 13 Jul '24

13 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- v3: odbc32: SQLError handle NULL handles https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

3 3

[PATCH 0/5] MR6072: server, kernelbase: Force WoW sharing on HKCU/Software key.
by Paul Gofman (＠gofman) 12 Jul '24

12 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6072

2 6

[PATCH 0/1] MR6071: shell32: Put temp directory in %LOCALAPPDATA%\Temp by default.
by Alex Henrie (＠alexhenrie) 12 Jul '24

12 Jul '24

Wine renamed the "Application Data" directory to "AppData" in commit 4111801ab31 ("shell32: Use winvista+ AppData paths.", 2021-05-27), so we can use it for the temp directory now without having to worry about spaces in the path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6071

2 1

[PATCH v4 0/1] MR5852: win32u: Implement EVENT_OBJECT_DESTROY.
by Esme Povirk (＠madewokherd) 12 Jul '24

12 Jul '24

-- v4: win32u: Implement EVENT_OBJECT_DESTROY. https://gitlab.winehq.org/wine/wine/-/merge_requests/5852

2 1

[PATCH 0/2] MR6069: quartz: Properly copy data to render surfaces of planar formats in VMR9.
by Francisco Casas (＠fcasas) 12 Jul '24

12 Jul '24

Fixes Bug 23029 (Devil May Cry® 3 Special Edition) (6550) Intro Video is covered by green, transparent square for a majority of it. Before these patches, surface data for planar formats is not copied correctly when the application uses a custom allocator-presenter and allocates a surface of different size than the VMR9 source. Patch 2/2 adds support for performing this copy correctly when the source dimensions are less or equal than the rendering surface dimensions. --- I have some questions: - Should I also make it work for when the dst is smaller than the src? - If not, should the FIXME() in 1/2 be promoted to an error? Otherwise we might have segfaults, writing out of scope. - Should I use copy_plane(), introduced in 2/2 also in the implementation of the other formats? Changing what needs to be changed to preserve behavior of course. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6069

3 3

[PATCH 0/1] MR6068: mshtml: Make sure we aren't detached before setting interactive ready state.
by Gabriel Ivăncescu (＠insn) 12 Jul '24

12 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6068

2 1

[PATCH 0/4] MR6042: d3d9: Miscellaneous tests/fixes.
by Connor McAdams (＠cmcadams) 12 Jul '24

12 Jul '24

The first two patches here address an issue I encountered when using Wine's d3dx9 with DXVK in the game Command and Conquer 3. The game calls `D3DXLoadSurfaceFromMemory` on a multisampled render target. This ends up going through the `lock_surface()` helper in d3dx9, which eventually calls `UpdateSurface()` in `unlock_surface()` to copy the staging surface back to the multisampled render target. This succeeds on wined3d even though it shouldn't, and fails on DXVK like it should. The second two patches address an issue reported in Empires: Dawn of the Modern World, where the game expects a device reset to reset the scene state. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6042

4 8

[PATCH v4 0/2] MR5625: Fixes for GCC 14 warnings (in winedump)
by Aida Jonikienė (＠DodoGTA) 12 Jul '24

12 Jul '24

The `-Wstringop-overread` fix feels a bit questionable (so I'll add Eric as a reviewer to clarify the MSC structs details) -- v4: winedump: Initialize size variable in dump_dir_exceptions(). winedump: Use offsetof() for string position calculations. https://gitlab.winehq.org/wine/wine/-/merge_requests/5625

5 6

[PATCH 0/2] MR6065: Dump comment streams from minidump.
by eric pouech (＠epo) 12 Jul '24

12 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6065

3 3

[PATCH 0/5] MR6064: Fix GCC14 warnings.
by eric pouech (＠epo) 12 Jul '24

12 Jul '24

GCC 14.1 emits a bunch of warning when compiling (winedump & dbghelp). This stems from some of the structures attempting to reflect file layout (after serialisation), whereas the variable length of some contiguous fields make it impossible (in C). So use flexible array members for variable length arrays, and use an FAM as well for packing the more complicated bits. This keeps these data blocks as C structures for the fields that can be directly mapped, and leave to the caller the responsability of deserializing the rest. This seem to be enough to get rid of these GCC warnings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6064

3 6

Re: [PATCH v2 0/1] MR6061: win32u: Use the dummy surface for empty layered window surfaces. - approved
by Alexandre Julliard (＠julliard) 12 Jul '24

12 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6061

1 0

Re: [PATCH v2 0/1] MR6062: win32u: Fix initial value when checking whether WS_EX_LAYERED changes. - approved
by Alexandre Julliard (＠julliard) 12 Jul '24

12 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6062

1 0

Re: [PATCH v3 0/5] MR5946: Feed FFP shader constants through push constant buffers, part 2. - approved
by Alexandre Julliard (＠julliard) 12 Jul '24

12 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5946

1 0

Re: [PATCH v3 0/11] MR6050: Various ODBC fixes - approved
by Alexandre Julliard (＠julliard) 12 Jul '24

12 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6050

1 0

Re: [PATCH v5 0/2] MR6043: winebus.sys: Fix angle conversions for FFB direction/phase - approved
by Alexandre Julliard (＠julliard) 12 Jul '24

12 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6043

1 0

[PATCH v4 0/2] MR6043: winebus.sys: Fix angle conversions for FFB direction/phase
by Matthias Gorzellik (＠gotzl) 12 Jul '24

12 Jul '24

Fixed rotation of angles < 90deg in bus_sdl. Align logical max of angles to physical max defined in dinput (35900). Before, a polar angle of eg 90deg would end up in bus_sdl/bus_udev as 90.25deg. -- v4: winebus.sys: Align logical max of angles to physical max defined in dinput winebus.sys: Fix rotation for angles < 90deg https://gitlab.winehq.org/wine/wine/-/merge_requests/6043

3 3

[PATCH v2 0/1] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 12 Jul '24

12 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- v2: https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

3 6

[PATCH 0/2] MR6063: odbc32 fixes
by Alistair Leslie-Hughes (＠alesliehughes) 12 Jul '24

12 Jul '24

The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset. The other is just a fix for when parameters are NULL when passed in (Same the the W version). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6063

3 3

[PATCH v6 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Ilia Docin (＠IDocin) 12 Jul '24

12 Jul '24

-- v6: comctl32/listview: Do not return items count on getting next item for last one https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

2 2

Re: [PATCH v2 0/5] MR5946: Feed FFP shader constants through push constant buffers, part 2. - approved
by Jan Sikorski (＠jsikorski) 12 Jul '24

12 Jul '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5946

1 0

[PATCH v5 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Ilia Docin (＠IDocin) 12 Jul '24

12 Jul '24

-- v5: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

3 2

[PATCH v2 0/11] MR6050: Various ODBC fixes
by Hans Leidekker (＠hans) 12 Jul '24

12 Jul '24

-- v2: odbc32: Use SQLSetConnectAttrW() instead of SQLSetConnectAttr() if possible. odbc32: Use SQLFreeHandle() instead of SQLFreeEnv/Connect(). odbc32: Set parent functions before creating the environment handle. odbc32: Accept SQL_FETCH_NEXT in SQLDataSources/Drivers() if the key has not been opened. odbc32: Factor out helpers to create driver environment and connection handles. odbc32: Implement SQLGetInfo(SQL_ODBC_VER). odbc32: Default to ODBC version 2. odbc32: Handle options in SQLFreeStmt(). odbc32: Stub SQLGetEnvAttr(SQL_ATTR_CONNECTION_POOLING). odbc32: Implement SQLGet/SetConnectAttr(SQL_ATTR_CONNECTION_TIMEOUT). odbc32: Implement SQLGet/SetConnectAttr(SQL_ATTR_LOGIN_TIMEOUT). https://gitlab.winehq.org/wine/wine/-/merge_requests/6050

4 15

Re: [PATCH v2 0/2] MR6043: winebus.sys: Fix angle conversions for FFB direction/phase - approved
by Rémi Bernon (＠rbernon) 12 Jul '24

12 Jul '24

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6043

1 0

[PATCH 0/1] MR6062: win32u: Fix initial value when checking whether WS_EX_LAYERED changes.
by Rémi Bernon (＠rbernon) 12 Jul '24

12 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6062

2 1

[PATCH 0/1] MR6061: win32u: Use the dummy surface for empty layered window surfaces.
by Rémi Bernon (＠rbernon) 12 Jul '24

12 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56958 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6061

2 1

[PATCH v2 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Brendan McGrath (＠redmcg) 12 Jul '24

12 Jul '24

Send INVALIDATEMEDIATYPE to allow the transform type to be set before retrying PROCESSINPUTNOTIFY. -- v2: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned. mf/tests: Add tests for custom evr presenter. https://gitlab.winehq.org/wine/wine/-/merge_requests/6059

3 3

[PATCH 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Brendan McGrath (＠redmcg) 12 Jul '24

12 Jul '24

Send INVALIDATEMEDIATYPE to allow the transform type to be set before retrying PROCESSINPUTNOTIFY. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6059

3 3

[PATCH v6 0/8] MR6031: Draft: wine: Use atomic locks insted pthread_mutex.
by Grigory Vasilyev (＠h0tc0d3) 12 Jul '24

12 Jul '24

I'm not sure about the need for this solution, so it's a **DRAFT**. For me it is an academic interest to check whether atomic locks will give advantages over pthread_mutex in games. First impressions are that games have become smoother, but need to think about tests that can actually be measured. Before build need define `WINE_USE_ATOMIC_LOCKS`. ```bash export CFLAGS="${CFLAGS} -DWINE_USE_ATOMIC_LOCKS" ``` -- v6: ws2_32: Add atomic lock support. wine32u: Add atomic lock support. winevulkan: Add atomic lock support. ntdll: Add atomic lock support. winewayland: Add atomic lock support. include: Define custom mutex macroses. msxml3: Fix compilation errors with Clang 18. configure: Change C standard to C17. https://gitlab.winehq.org/wine/wine/-/merge_requests/6031

3 11

[PATCH v4 0/2] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Ilia Docin (＠IDocin) 12 Jul '24

12 Jul '24

-- v4: comctl32/listview: Add test for LVM_GETNEXTITEM comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

3 4

[PATCH v3 0/3] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 11 Jul '24

11 Jul '24

This merge request implements the third name format ("[NameDisplay](https://learn.microsoft.com/en-us/windows/win32/api/secext/ne-…") of the GetUserNameExW method. -- v3: secur32: GetUserNameExW(3) is supposed to return ERROR_MORE_DATA if the buffer is too small, not ERROR_INSUFFICIENT_BUFFER secur32/tests: Add GetUserNameExW(3) specific test cases https://gitlab.winehq.org/wine/wine/-/merge_requests/6002

3 5

[PATCH 0/7] MR6050: Various ODBC fixes
by Hans Leidekker (＠hans) 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6050

4 14

[PATCH v5 0/8] MR6031: Draft: wine: Use atomic locks insted pthread_mutex.
by Grigory Vasilyev (＠h0tc0d3) 11 Jul '24

11 Jul '24

I'm not sure about the need for this solution, so it's a **DRAFT**. For me it is an academic interest to check whether atomic locks will give advantages over pthread_mutex in games. First impressions are that games have become smoother, but need to think about tests that can actually be measured. Before build need define `WINE_USE_ATOMIC_LOCKS`. ```bash export CFLAGS="${CFLAGS} -DWINE_USE_ATOMIC_LOCKS" ``` -- v5: ws2_32: Add atomic lock support. wine32u: Add atomic lock support. winevulkan: Add atomic lock support. ntdll: Add atomic lock support. winewayland: Add atomic lock support. include: Define custom mutex macroses. msxml3: Fix compilation errors with Clang 18. configure: Change C standard to C17. https://gitlab.winehq.org/wine/wine/-/merge_requests/6031

6 19

Re: [PATCH v2 0/3] MR6057: Cmd engine rewrite (part XX) - approved
by Alexandre Julliard (＠julliard) 11 Jul '24

11 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6057

1 0

Re: [PATCH v2 0/1] MR6054: mf/tests: Reduce the mute threshold for the transform tests. - approved
by Alexandre Julliard (＠julliard) 11 Jul '24

11 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6054

1 0

Re: [PATCH v4 0/2] MR5990: mfreadwrite/reader: Fix seeking and playback loop when using decoders. - approved
by Alexandre Julliard (＠julliard) 11 Jul '24

11 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5990

1 0

Re: [PATCH v2 0/1] MR6056: include: Fix typo with X3DAUDIO_EMITTER structure in x3daudio.h - approved
by Alexandre Julliard (＠julliard) 11 Jul '24

11 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6056

1 0

Re: [PATCH v2 0/6] MR6051: win32u: Move layered window attributes update out of the drivers. - approved
by Alexandre Julliard (＠julliard) 11 Jul '24

11 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6051

1 0

Re: [PATCH v2 0/2] MR6049: ntdll: Double-null-terminate registry multi-strings in RtlQueryRegistryValues. - approved
by Alexandre Julliard (＠julliard) 11 Jul '24

11 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6049

1 0

Re: [PATCH v2 0/1] MR6044: crypt32: Make CertFindCertificateInStore(CERT_FIND_ISSUER_NAME) work. - approved
by Alexandre Julliard (＠julliard) 11 Jul '24

11 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6044

1 0

Re: [PATCH v2 0/9] MR6052: mshtml: Improve script global object handling and use new bindings for more objects. - approved
by Alexandre Julliard (＠julliard) 11 Jul '24

11 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6052

1 0

[PATCH 0/1] MR6058: hal: Add HalSetBusDataByOffset stub.
by Aida Jonikienė (＠DodoGTA) 11 Jul '24

11 Jul '24

The kernel-mode component of MSI Afterburner (RTCore64.sys) calls this function (possibly for GPU overclocking stuff). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6058

2 1

[PATCH v3 0/1] MR6007: ntdll: Don't use CLOCK_REALTIME_COARSE
by Tatsuyuki Ishi (＠ishitatsuyuki) 11 Jul '24

11 Jul '24

This reverts commit 5c8ea25014f ("ntdll: Use CLOCK_REALTIME_COARSE for NtQuerySystemTime() if it has sufficient resolution.") CLOCK_*_COARSE only provides up to 1ms resolution at CONFIG_HZ=1000. OTOH, there are several ways to get up to 0.5ms resolution on modern Windows (high resolution waitable timers, NtSetTimerResolution with 0.5ms). This code path therefore has a possibility of behaving worse than native. Since COARSE resolution is HZ dependent, this code path only runs if the kernel is configured with CONFIG_HZ=1000. Most distro ships does not ship with this. Therefore, this code path is rarely tested, and is more of a recipe for surprise. If any application rely on fast NtQuerySystemTime they are likely already broken for majority of Wine users. Given the above reason, don't use CLOCK_REALTIME_COARSE. Use gettimeofday which is internally hooked to CLOCK_REALTIME. -- v3: ntdll: Don't use CLOCK_REALTIME_COARSE https://gitlab.winehq.org/wine/wine/-/merge_requests/6007

6 12

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by Tim Clem (＠tclem) 11 Jul '24

11 Jul '24

Apologies for it spamming the log. My intention was, as my comment describes, to be louder about cases where we're running out of memory. Often such allocation failures are indeed fatal, since many applications (and internal Wine code) does not expect them. I didn't intend for there to be, nor did I write, any requirements around the bits of address space. It raises the question for me of why we're trying to allocate memory that high if we know it's above the address limit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_75958

1 0

[PATCH v5 0/2] MR6021: nsiproxy.sys: Use pcblist64 sysctl to enumerate TCP & UDP connections on macOS.
by Tim Clem (＠tclem) 11 Jul '24

11 Jul '24

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for the pcblist64 sysctls, so I'm caching the result of sysctlnametomib. -- v5: nsiproxy.sys: Use the pcblist64 sysctl to enumerate UDP connections on macOS. nsiproxy.sys: Use the pcblist64 sysctl to enumerate TCP connections on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

2 3

[PATCH v3 0/2] MR5990: mfreadwrite/reader: Fix seeking and playback loop when using decoders.
by Rémi Bernon (＠rbernon) 11 Jul '24

11 Jul '24

-- v3: mfreadwrite/reader: Send MFT_MESSAGE_NOTIFY_START_OF_STREAM on start or seek. winegstreamer/video_decoder: Generate timestamps relative to the first input sample. https://gitlab.winehq.org/wine/wine/-/merge_requests/5990

3 7

[PATCH 0/3] MR6057: Cmd engine rewrite (part XX)
by eric pouech (＠epo) 11 Jul '24

11 Jul '24

This is part XX of cmd engine rewrite. It provides: - a couple of more internal cleanups, - avoids leaks on some error paths, - fixes a couple of redirection related issues -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6057

3 4

[PATCH v2 0/1] MR6007: ntdll: Don't use CLOCK_REALTIME_COARSE
by Tatsuyuki Ishi (＠ishitatsuyuki) 11 Jul '24

11 Jul '24

This reverts commit 5c8ea25014f ("ntdll: Use CLOCK_REALTIME_COARSE for NtQuerySystemTime() if it has sufficient resolution.") CLOCK_*_COARSE only provides up to 1ms resolution at CONFIG_HZ=1000. OTOH, there are several ways to get up to 0.5ms resolution on modern Windows (high resolution waitable timers, NtSetTimerResolution with 0.5ms). This code path therefore has a possibility of behaving worse than native. Since COARSE resolution is HZ dependent, this code path only runs if the kernel is configured with CONFIG_HZ=1000. Most distro ships does not ship with this. Therefore, this code path is rarely tested, and is more of a recipe for surprise. If any application rely on fast NtQuerySystemTime they are likely already broken for majority of Wine users. Given the above reason, don't use CLOCK_REALTIME_COARSE. Use gettimeofday which is internally hooked to CLOCK_REALTIME. -- v2: ntdll: Don't use CLOCK_REALTIME_COARSE https://gitlab.winehq.org/wine/wine/-/merge_requests/6007

4 11

2025

2024

2023

2022

wine-gitlab