- wine-gitlab - winehq.org

[PATCH 0/1] MR6056: include: Fix typo with X3DAUDIO_EMITTER structure in x3daudio.h
by Biswapriyo Nath (＠Biswa96) 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6056

3 2

[PATCH 0/1] MR6054: Draft: mf/tests: Reduce the mute threshold for the transform tests.
by Rémi Bernon (＠rbernon) 11 Jul '24

11 Jul '24

It constantly fails on Gitlab because of output overflow. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6054

2 1

[PATCH v11 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 11 Jul '24

11 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v11: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

3 2

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

On Thu Jul 11 10:43:10 2024 +0000, Egor Poleshko wrote: > I will. Also, take a look at this: > ![GetUserNameExW](/uploads/786f1b0d12cc9dffb024bb0a65e328ee/GetUserNameExW.mp4) Videos usually provide no technical information and lead to pure speculations. Actual code sounds more convincing: https://testbot.winehq.org/JobDetails.pl?Key=147012 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75897

1 0

[PATCH 0/9] MR6052: mshtml: Improve script global object handling and use new bindings for more objects.
by Jacek Caban (＠jacek) 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6052

3 10

Re: [PATCH v5 0/4] MR5237: Use futexes on macOS for thread-ID alerts.
by Marc-Aurel Zent (＠mzent) 11 Jul '24

11 Jul '24

On Thu Jul 11 10:51:43 2024 +0000, Elizabeth Figura wrote: > Sorry for the late approval; I missed that I had been assigned. > As far as I can tell from the documentation this is correct and matches > the semantics we need. > There are a couple trailing whitespace errors in the last patch though. No worries, and thanks the review! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5237#note_75894

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 11 Jul '24

11 Jul '24

On Thu Jul 11 10:08:54 2024 +0000, Dmitry Timoshkov wrote: > I'd suggest to add a test. That test most likely will show that > GetUserNameEx(NameDisplay) returns an error ERROR_NONE_MAPPED on every > VM in the Testbot. That means that your assumptions about > GetUserNameEx() behaviour are incorrect, and the code in your plugin > software won't work on at least some (I'd guess on most) of the Windows > computers. Therefore your implementation is incorrect as well. I will. Also, take a look at this: ![GetUserNameExW](/uploads/786f1b0d12cc9dffb024bb0a65e328ee/GetUserNameExW.mp4) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75893

1 0

[PATCH 0/1] MR6044: crypt32: Make CertFindCertificateInStore(CERT_FIND_ISSUER_NAME) work.
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6044

4 3

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

On Thu Jul 11 09:52:04 2024 +0000, Egor Poleshko wrote: > Nevermind, I apologise. I misunderstood how do the username values work > on local accounts. > From your and my observations, GetUserNameExW(3) performs several checks > before returning a result: > - If the user is connected to an Active Directory domain, return the > `displayName` value from the domain LDAP database. > - If the local user is linked to a Microsoft account, return the name > specified in it. > - Else, return `ERROR_NONE_MAPPED`. > The Microsoft Account part is tricky, because, as far as I know, Wine > doesn't provide a way to link the local user to a Microsoft account... > Maybe, my implementation will suffice? I'd suggest to add a test. That test most likely will show that GetUserNameEx(NameDisplay) returns an error ERROR_NONE_MAPPED on every VM in the Testbot. That means that your assumptions about GetUserNameEx() behaviour are incorrect, and the code in your plugin software won't work on at least some (I'd guess on most) of the Windows computers. Therefore your implementation is incorrect as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75890

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 11 Jul '24

11 Jul '24

On Thu Jul 11 09:01:15 2024 +0000, Dmitry Timoshkov wrote: > What do you mean? Nevermind, I apologise. I misunderstood how do the username values work on local accounts. From your and my observations, GetUserNameExW(3) performs several checks before returning a result: - If the user is connected to an Active Directory domain, return the `displayName` value from the domain LDAP database. - If the local user is linked to a Microsoft account, return the name specified in it. - Else, return `ERROR_NONE_MAPPED`. The Microsoft Account part is tricky, because, as far as I know, Wine doesn't provide a way to link the local user to a Microsoft account... Maybe, my implementation will suffice? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75889

1 0

[PATCH v10 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 11 Jul '24

11 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v10: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

3 3

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

On Thu Jul 11 08:58:24 2024 +0000, Egor Poleshko wrote: > Does the user on that computer have an offline display name? > ![image](/uploads/c9944139127ec71cac7d2b2d1e19c834/image.png){width=318 height=100} What do you mean? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75886

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 11 Jul '24

11 Jul '24

On Tue Jul 9 18:18:29 2024 +0000, Egor Poleshko wrote: > Hm, interesting. I'll experiment with this and make changes to my branch > accordingly. Thank you. Does the user on that computer have an offline display name? ![image](/uploads/c9944139127ec71cac7d2b2d1e19c834/image.png){width=318 height=100} -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75885

1 0

[PATCH v4 0/2] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) 11 Jul '24

11 Jul '24

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for pcblist64, so I had to fetch it with sysctlbyname. -- v4: nsiproxy.sys: Use the pcblist64 sysctl to enumerate UDP connections on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

5 7

[PATCH 0/6] MR6051: win32u: Move layered window attributes update out of the drivers.
by Rémi Bernon (＠rbernon) 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6051

2 6

[PATCH 0/2] MR6049: ntdll: Double-null-terminate registry multi-strings in RtlQueryRegistryValues.
by Alex Henrie (＠alexhenrie) 11 Jul '24

11 Jul '24

This reverts most of commit 2821a850d401dfabc5d76a4f40b0d6a42045fc5e which was a partial and ultimately improper solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6049

2 2

[PATCH v2 0/4] MR6045: server: Reimplement mailslots using server-side I/O.
by Elizabeth Figura (＠zfigura) 11 Jul '24

11 Jul '24

This fixes various corner cases. This is not motivated by any particular application. However, the server-side code seems at least as simple as the existing client-side code, is more accurate, and removes a potential source of complication from any future work involving asyncs. -- v2: server: Reimplement mailslots using server-side I/O. server: Treat completion with error before async_handoff() as error. kernel32/tests: Add more mailslot tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6045

3 5

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by theofficialgman (＠theofficialgman) 11 Jul '24

11 Jul '24

@tclem would you might providing a brief explanation on the thought process behind this? In the usecase where the host has below 48bits of address space (commonly the case on arm64 linux kernels which might use 39bit or even 36bit address space) this results in the following similar lines of text being basically spammed in the log during process creation ``` 002c:err:virtual:map_fixed_area out of memory for 0x6fffffcd0000-0x6ffffffef000 002c:err:virtual:try_map_free_area mmap() error Cannot allocate memory, range 0x7fffffcd0000-0x7ffffffef000, unix_prot 0x7. ``` Are 48bits of address space really a requirement for most applications and cause fatal errors without it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_75871

1 0

[PATCH v2 0/4] MR6047: server: Deny opening handles to objects with zero access.
by Paul Gofman (＠gofman) 11 Jul '24

11 Jul '24

-- v2: server: Skip inaccessible threads in (get_next_thread). server: Do not allow zero access mask when opening some objects. ntoskrnl.exe/tests: Open directory object with nonzero access in test_permanent(). ntdll/tests: Add tests for opening some objects with zero access. https://gitlab.winehq.org/wine/wine/-/merge_requests/6047

3 5

[PATCH 0/4] MR6047: server: Deny opening handles to objects with zero access.
by Paul Gofman (＠gofman) 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6047

3 6

[PATCH v2 0/7] MR6041: Cmd engine rewrite (part XIX)
by eric pouech (＠epo) 10 Jul '24

10 Jul '24

This is part XIX of cmd engine rewrite. It's the last MR (for now) for setting success/failure return code on internal commands. The remaining todo in this area are due to: - incompletly implemented builtin (eg: TYPE not handling multiple files, not wildcards; CHOICE missing a bunch of features; ...), - some commands (like START) being implemented as external executables, hence forcing RETURN CODE = ERRORLEVEL which is not always wanted, -- v2: cmd: Cleanup transition bits. cmd: Improve return code/errorlevel support for external commands. cmd: Move empty batch command handling to WCMD_batch() callers. cmd: Set success/failure return code for START command. cmd: Set success/failure return code for MKLINK command. cmd: Add more tests for return codes in builtin commands. cmd: Get rid of CTTY command. https://gitlab.winehq.org/wine/wine/-/merge_requests/6041

4 9

Re: [PATCH v3 0/1] MR6037: server: Use a shared_object_t for the dummy object. - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6037

1 0

Re: [PATCH v3 0/8] MR6039: jscript: Add support for host functions. - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6039

1 0

Re: [PATCH v3 0/2] MR5044: ntdll: Fix some threadpool races. - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5044

1 0

Re: [PATCH v5 0/4] MR5237: Use futexes on macOS for thread-ID alerts. - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5237

1 0

Re: [PATCH v2 0/1] MR6038: odbc32: Implement SQLSetEnvAttr(SQL_ATTR_ODBC_VERSION). - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6038

1 0

Re: [PATCH v4 0/5] MR6023: winegstreamer/wg_transform: Support creating encoder transform. - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6023

1 0

Re: [PATCH v2 0/1] MR6035: winhttp: Implement WinHttpQueryOption(WINHTTP_OPTION_URL). - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6035

1 0

Re: [PATCH v2 0/1] MR6034: include: Fix typo with XINPUT_DEVSUBTYPE_FLIGHT_STICK name in xinput.h. - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6034

1 0

Re: [PATCH v7 0/5] MR5559: include: Fix another 8 typoed GUIDs - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5559

1 0

Re: [PATCH v2 0/5] MR6033: include: Fix another 5 typoed GUIDs - approved
by Alexandre Julliard (＠julliard) 10 Jul '24

10 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6033

1 0

[PATCH v4 0/8] MR6031: Draft: wine: Use atomic locks insted pthread_mutex.
by Grigory Vasilyev (＠h0tc0d3) 10 Jul '24

10 Jul '24

I'm not sure about the need for this solution, so it's a **DRAFT**. For me it is an academic interest to check whether atomic locks will give advantages over pthread_mutex in games. First impressions are that games have become smoother, but need to think about tests that can actually be measured. Before build need define `WINE_USE_ATOMIC_LOCKS`. ```bash export CFLAGS="${CFLAGS} -DWINE_USE_ATOMIC_LOCKS" ``` -- v4: ws2_32: Add atomic lock support. wine32u: Add atomic lock support. winevulkan: Add atomic lock support. ntdll: Add atomic lock support. winewayland: Add atomic lock support. include: Define custom mutex macroses. https://gitlab.winehq.org/wine/wine/-/merge_requests/6031

5 14

Re: [PATCH v11 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 10 Jul '24

10 Jul '24

On Wed Jul 10 19:12:40 2024 +0000, Fabian Maurer wrote: > Is there a specific reason those two functions are separate instead of > RegGetValueA calling RegGetValueW? I don't know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5969#note_75808

1 0

[PATCH v9 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 10 Jul '24

10 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v9: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

2 1

[PATCH v3 0/8] MR6031: Draft: wine: Use atomic locks insted pthread_mutex.
by Grigory Vasilyev (＠h0tc0d3) 10 Jul '24

10 Jul '24

I'm not sure about the need for this solution, so it's a **DRAFT**. For me it is an academic interest to check whether atomic locks will give advantages over pthread_mutex in games. First impressions are that games have become smoother, but need to think about tests that can actually be measured. Before build need define `WINE_USE_ATOMIC_LOCKS`. ```bash export CFLAGS="${CFLAGS} -DWINE_USE_ATOMIC_LOCKS" ``` -- v3: ws2_32: Add atomic lock support. wine32u: Add atomic lock support. winevulkan: Add atomic lock support. ntdll: Add atomic lock support. winewayland: Add atomic lock support. include: Define custom mutex macroses. https://gitlab.winehq.org/wine/wine/-/merge_requests/6031

4 12

[PATCH v3 0/5] MR6023: winegstreamer/wg_transform: Support creating encoder transform.
by Ziqing Hui (＠zhui) 10 Jul '24

10 Jul '24

-- v3: winegstreamer/wg_transform: Support creating encoder transform. winegstreamer/wg_transform: Introduce transform_create_converter_elements. winegstreamer/wg_transform: Introduce transform_create_decoder_elements. https://gitlab.winehq.org/wine/wine/-/merge_requests/6023

5 9

[PATCH 0/4] MR6045: server: Reimplement mailslots using server-side I/O.
by Elizabeth Figura (＠zfigura) 10 Jul '24

10 Jul '24

This fixes various corner cases. This is not motivated by any particular application. However, the server-side code seems at least as simple as the existing client-side code, is more accurate, and removes a potential source of complication from any future work involving asyncs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6045

3 5

[PATCH v2 0/2] MR5044: ntdll: Fix some threadpool races.
by Paul Gofman (＠gofman) 10 Jul '24

10 Jul '24

That seems to fix some (difficult to reproduce) crashes in EA Desktop / CEF, usually on shutdown but sometimes during starting up. Currently TpSetWait can set (or clear) the event, while waitqueue_thread_proc() gets woken from NtWaitForMultipleObjects by previously set wait object and call the callback as if new set (or cleared) wait object is signaled. The crashes I was reproducing were always happening when RtlDeregisterWaitEx call is racing with waking the wait and calling the callback. -- v2: ntdll: Make sure wakeups from already unset events are ignored in waitqueue_thread_proc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5044

3 5

[PATCH v4 0/4] MR5237: Use futexes on macOS for thread-ID alerts.
by Marc-Aurel Zent (＠mzent) 10 Jul '24

10 Jul '24

This also bumps the minimum supported version of macOS to 10.12 to unconditionally assume the ulock syscalls are present. As discussed with @Gcenx this shouldn't be an issue, as the current minimum support version of 10.8 does not work anyways at the moment with only 10.10+ being useable and even then virtually no-one using wine on versions < 10.12 (and also being unsupported by the prebuilt binaries). Bumping to 10.12 would also have the side-benefit of allowing some cleanup of deprecated functions or legacy codepaths (like `mach_continuous_time` vs `mach_absolute_time` and probably much more). In my testing ulock futexes are about 2x faster for synchronization than kevents. Using the syscall wrappers here should provide protection against changing syscall numbers, and given that ulock is also directly used by libc++, the probability of an incompatible API change here is basically zero imo. By default ulock is also process-private, similar to the current linux implementation, cross-process synchronization would require darwin 19+ (macOS 10.15+) with `UL_COMPARE_AND_WAIT_SHARED`. The diff is a bit bigger than it actually is in effect, since https://gitlab.winehq.org/mzent/wine/-/commit/28a8a991c165f0d37dbf78ca3cdee… is only moving some code around and not actually changing anything. -- v4: ntdll: Implement futex_wait() and futex_wake_one() on macOS. ntdll: Simplify futex interface from futex_wake() to futex_wake_one(). ntdll: Use USE_FUTEX to indicate futex support. ntdll: Prefer futex for thread-ID alerts over kqueue. https://gitlab.winehq.org/wine/wine/-/merge_requests/5237

3 6

[PATCH 0/7] MR6041: Cmd engine rewrite (part XIX)
by eric pouech (＠epo) 10 Jul '24

10 Jul '24

This is part XIX of cmd engine rewrite. It's the last MR (for now) for setting success/failure return code on internal commands. The remaining todo in this area are due to: - incompletly implemented builtin (eg: TYPE not handling multiple files, not wildcards; CHOICE missing a bunch of features; ...), - some commands (like START) being implemented as external executables, hence forcing RETURN CODE = ERRORLEVEL which is not always wanted, -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6041

3 9

[PATCH v2 0/8] MR6039: jscript: Add support for host functions.
by Jacek Caban (＠jacek) 10 Jul '24

10 Jul '24

And use new bindings for more MSHTML objects. -- v2: mshtml: Use host object script bindings for Performance class. mshtml: Use host object script bindings for PerformanceTiming class. mshtml: Use host object script bindings for PerformanceNavigation class. mshtml: Use host object script bindings for History class. mshtml: Use host object script bindings for DOMImplementation class. mshtml/tests: Make todo_wine explicit in builtin_toString tests. jscript: Add support for host functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/6039

3 9

[PATCH v4 0/3] MR6004: comctl32: A NULL string fix.
by Aida Jonikienė (＠DodoGTA) 10 Jul '24

10 Jul '24

-- v4: comctl32/tests: Add tests for NULL strings with edit control WM_GETTEXT message. user32: Correctly handle NULL string in WM_GETTEXT AtoW wrapper. https://gitlab.winehq.org/wine/wine/-/merge_requests/6004

3 11

Re: [PATCH v5 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Arek Hiler (＠ivyl) 10 Jul '24

10 Jul '24

On Mon Jul 8 21:43:03 2024 +0000, Etaash Mathamsetty wrote: > cracked the mystery, im pretty sure AUDCLNT_STREAMFLAGS_RATEADJUST is > needed for GetService to work :) This explains things, thanks! I'll amend the tests and add support in `GetService()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_75784

1 0

Re: [PATCH v5 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Arek Hiler (＠ivyl) 10 Jul '24

10 Jul '24

On Tue Jul 9 19:55:30 2024 +0000, Davide Beatrici wrote: > Since the operations are more or less the same as in > `pulse_create_stream()`, could you create a helper function in a > separate commit (that will be first in the list), please? I've been looking into this when originally implementing the function. I had another look now. The only shared parts that I think we could extract are ```c new_bufsize_frames = ceil((stream->duration / 10000000.) * new_ss.rate); size = new_bufsize_frames * 2 * pa_frame_size(&stream->ss); if (NtAllocateVirtualMemory(GetCurrentProcess(), (void **)&new_buffer, zero_bits, &size, MEM_COMMIT, PAGE_READWRITE)) hr = E_OUTOFMEMORY; ``` but I couldn't make it not overly awkward, mostly because of when the variables have to be set and the failure paths / cleanup. I can do two helpers, one for `bufsize_frames` and `size` each unless you have a more detailed suggestion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_75783

1 0

[PATCH v2 0/8] MR6031: Draft: wine: Use atomic locks insted pthread_mutex.
by Grigory Vasilyev (＠h0tc0d3) 10 Jul '24

10 Jul '24

I'm not sure about the need for this solution, so it's a **DRAFT**. For me it is an academic interest to check whether atomic locks will give advantages over pthread_mutex in games. First impressions are that games have become smoother, but need to think about tests that can actually be measured. Before build need define `WINE_USE_ATOMIC_LOCKS`. ```bash export CFLAGS="${CFLAGS} -DWINE_USE_ATOMIC_LOCKS" ``` -- v2: ws2_32: Add atomic lock support. wine32u: Add atomic lock support. winevulkan: Add atomic lock support. ntdll: Add atomic lock support. winewayland: Add atomic lock support. include: Define custom mutex macroses. msxml3: Fix compilation errors with Clang 18. configure: Change C standard to C17. https://gitlab.winehq.org/wine/wine/-/merge_requests/6031

4 15

[PATCH v13 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Mohamad Al-Jaf (＠maljaf) 10 Jul '24

10 Jul '24

Needed by Orbiter Space Flight Simulator and Train Simulator Classic. -- v13: d3d9/tests: Add Direct3DCreate9On12() tests. d3d9: Implement Direct3DCreate9On12(). include: Add d3d9on12.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/4915

5 22

[PATCH 0/8] MR6039: jscript: Add support for host functions.
by Jacek Caban (＠jacek) 10 Jul '24

10 Jul '24

And use new bindings for more MSHTML objects. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6039

2 8

[PATCH v2 0/2] MR5990: mfreadwrite/reader: Fix seeking and playback loop when using decoders.
by Rémi Bernon (＠rbernon) 10 Jul '24

10 Jul '24

-- v2: mfreadwrite/reader: Send MFT_MESSAGE_NOTIFY_START_OF_STREAM on start or seek. winegstreamer/video_decoder: Generate timestamps relative to the first input sample. https://gitlab.winehq.org/wine/wine/-/merge_requests/5990

2 4

[PATCH v2 0/10] MR5998: winegstreamer: Introduce a new demuxer interface for the MF media source.
by Rémi Bernon (＠rbernon) 10 Jul '24

10 Jul '24

First part of a series introducing a separate unix interface for the MF media source. The goal is to use a synchronous demuxing-only interface, similar to native, which will be simpler and faster and better fitted to most MF media source use cases. -- v2: winegstreamer/media_source: Handle GST_QUERY_SCHEDULING on wg_source src pad. winegstreamer/media_source: Handle GST_QUERY_DURATION on wg_source src pad. winegstreamer/media_source: Handle GST_QUERY_URI on wg_source src pad. winegstreamer/media_source: Push a stream and segment event to the wg_source. winegstreamer/media_source: Create a demuxer element in wg_source_create. winegstreamer/media_source: Create a source pad on the wg_source. winegstreamer/media_source: Prefer MF_BYTESTREAM_ORIGIN_NAME for source URL. winegstreamer/media_source: Provide first block of data and stream URL to wg_source. winegstreamer/media_source: Call (Begin|End)Read to read the byte stream header. winegstreamer/media_source: Introduce a new wg_source interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/5998

4 17

[PATCH 0/7] MR3606: winegstreamer: Introduce a new wg_source internal interface.
by Rémi Bernon (＠rbernon) 10 Jul '24

10 Jul '24

This is the first batch of a series implementing faster media source resolution required to workaround an Unreal Engine race condition present in some games, and deterministic stream ordering that decodebin / parsebin cannot provide, which is required to expose the streams in native order, for compatibility in several other applications. I pushed the full series as a branch here: https://gitlab.winehq.org/rbernon/wine/-/commits/mr/wg-source-part-one Note that this full series is also a first step in the direction of having a simpler demuxer interface, which will be required in the future for compatibility with applications that build MF or DirectShow pipelines directly and expect the relevant components to behave as a demuxer and expose compressed media types. For now it only delays the use of wg_parser to whenever the media source is started, and matches the non-ordered streams using their media types and tags. This is a best effort solution but I don't think we can do much better for the moment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3606

6 29

[PATCH v2 0/7] MR5138: winegstreamer: Support and expose generic audio/video MFT decoders.
by Rémi Bernon (＠rbernon) 10 Jul '24

10 Jul '24

-- v2: winegstreamer: Expose the generic video decoder transform. winegstreamer: Introduce a generic audio decoder transform. winegstreamer: Rename aac_decoder to audio_decoder. winegstreamer: Translate generic unknown audio / video media types. winegstreamer: Support generic audio / video unknown formats. winegstreamer: Call gst_video_info_from_caps for all video formats. winegstreamer: Call gst_audio_info_from_caps for all audio formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/5138

4 12

[PATCH v2 0/1] MR5340: maintainers: Remove MF GStreamer section.
by Rémi Bernon (＠rbernon) 10 Jul '24

10 Jul '24

-- v2: maintainers: Remove MF GStreamer section. https://gitlab.winehq.org/wine/wine/-/merge_requests/5340

2 2

[PATCH 0/7] MR6036: win32u: Use the thread input and desktop shared memory for reading keyboard state.
by Rémi Bernon (＠rbernon) 10 Jul '24

10 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6036

2 8

[PATCH 0/1] MR6038: odbc32: Implement SQLSetEnvAttr(SQL_ATTR_ODBC_VERSION).
by Hans Leidekker (＠hans) 10 Jul '24

10 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6038

3 2

[PATCH 0/3] MR6031: Draft: winewayland: Use fast atomic locks insted pthread_mutex.
by Grigory Vasilyev (＠h0tc0d3) 10 Jul '24

10 Jul '24

I'm not sure about the need for this solution, so it's a **DRAFT**. For me it is an academic interest to check whether atomic locks will give advantages over pthread_mutex in games. First impressions are that games have become smoother, but need to think about tests that can actually be measured. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6031

3 20

[PATCH v2 0/1] MR6037: server: Use a shared_object_t for the dummy object.
by Rémi Bernon (＠rbernon) 10 Jul '24

10 Jul '24

The sequence lives in the object header, and the object is containing the shm struct. The code was reading before the dummy_shm variable and sometimes asserted that the sequence isn't initialized to zero. Fixes a random wineserver crash, sorry about that. -- v2: server: Use a shared_object_t for the dummy object. https://gitlab.winehq.org/wine/wine/-/merge_requests/6037

2 2

[PATCH 0/1] MR6037: server: Use a shared_object_t for the dummy object.
by Rémi Bernon (＠rbernon) 10 Jul '24

10 Jul '24

The sequence lives in the object header, which is containing the shm struct. The code was reading before the dummy_shm variable and sometimes asserted that the sequence isn't initialized to zero. Fixes a random wineserver crash, sorry about that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6037

2 1

Re: [PATCH v3 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Zhiyi Zhang (＠zhiyi) 10 Jul '24

10 Jul '24

On Thu Jun 27 01:11:28 2024 +0000, Zhiyi Zhang wrote: > > It fails on asserting return value of sending LVM_GETNEXTITEM message > In that case, please also add a test checking the same thing. Hi, could you add a test? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_75710

1 0

[PATCH v10 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 10 Jul '24

10 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v10: comclt32: Allow hotkeys for propsheet navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 4

[PATCH v2 0/5] MR6023: winegstreamer/wg_transform: Support creating encoder transform.
by Ziqing Hui (＠zhui) 10 Jul '24

10 Jul '24

-- v2: winegstreamer/wg_transform: Support creating encoder transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/6023

4 7

[PATCH 0/1] MR6035: winhttp: Implement WinHttpQueryOption(WINHTTP_OPTION_URL).
by Hans Leidekker (＠hans) 10 Jul '24

10 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6035

3 2

[PATCH 0/5] MR6023: winegstreamer/wg_transform: Support creating encoder transform.
by Ziqing Hui (＠zhui) 10 Jul '24

10 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6023

4 8

[PATCH 0/1] MR6034: include: Fix typo with XINPUT_DEVSUBTYPE_FLIGHT_STICK name in xinput.h.
by Biswapriyo Nath (＠Biswa96) 10 Jul '24

10 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6034

3 2

[PATCH v6 0/5] MR5559: include: Fix another 8 typoed GUIDs
by Alfred Agrell (＠Alcaro) 09 Jul '24

09 Jul '24

Same bug class as https://gitlab.winehq.org/wine/wine/-/merge_requests/5550. None of them are referenced by anything (not counting mfplat/main.c's debugstr_attr(), which names the two in mfapi.h - better debug output, yay I guess). -- v6: include: Fix typoed value of CLSID_WICXMPMetadataReader. include: Fix typoed value of MEDIASUBTYPE_P408. include: Fix typoed values of IID_IPropertyEnumType2 and CLSID_PropertySystem. include: Fix typoed values of IID_IMimeWebDocument and IID_IMimeMessageCallback. include: Fix typoed values of MF_MT_VIDEO_3D and MF_MT_AUDIO_FOLDDOWN_MATRIX. https://gitlab.winehq.org/wine/wine/-/merge_requests/5559

4 9

Re: [PATCH v11 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Fabian Maurer (＠DarkShadow44) 09 Jul '24

09 Jul '24

Is there a specific reason those two functions are separate instead of RegGetValueA calling RegGetValueW? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5969#note_75667

1 0

Re: [PATCH v2 0/1] MR6024: ntoskrnl.exe: add a stub for KeQueryGroupAffinity - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6024

1 0

Re: [PATCH v2 0/6] MR5999: d3dx9: Miscellaneous fixes. - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5999

1 0

Re: [PATCH v3 0/11] MR6029: jscript: Introduce new MSHTML bindings. - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6029

1 0

Re: [PATCH v2 0/2] MR6030: msi: Handle failure from MSI_RecordGetInteger(). - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6030

1 0

Re: [PATCH v2 0/8] MR6028: Cmd engine rewrite (part XVIII) - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6028

1 0

Re: [PATCH v3 0/2] MR6014: winhttp/tests: Add some tests for querying string options with NULL buffer. - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6014

1 0

Re: [PATCH v3 0/5] MR5995: win32u: Use the thread input shared memory for GetForegroundWindow, GetCursorInfo and GetGUIThreadInfo. - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5995

1 0

Re: [PATCH v2 0/2] MR5987: ddraw/tests: Workaround some X11 ConfigureNotify event race condition. - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5987

1 0

Re: [PATCH v6 0/9] MR6012: Support Windows ODBC drivers - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6012

1 0

Re: [PATCH v11 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW]. - approved
by Alexandre Julliard (＠julliard) 09 Jul '24

09 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

1 0

[PATCH v5 0/5] MR5559: include: Fix another 8 typoed GUIDs
by Alfred Agrell (＠Alcaro) 09 Jul '24

09 Jul '24

Same bug class as https://gitlab.winehq.org/wine/wine/-/merge_requests/5550. None of them are referenced by anything (not counting mfplat/main.c's debugstr_attr(), which names the two in mfapi.h - better debug output, yay I guess). -- v5: include: Fix typoed value of CLSID_WICXMPMetadataReader. include: Fix typoed value of MEDIASUBTYPE_P408. include: Fix typoed values of IID_IPropertyEnumType2 and CLSID_PropertySystem. include: Fix typoed values of IID_IMimeWebDocument and IID_IMimeMessageCallback. include: Fix typoed values of MF_MT_VIDEO_3D and MF_MT_AUDIO_FOLDDOWN_MATRIX. https://gitlab.winehq.org/wine/wine/-/merge_requests/5559

4 9

[PATCH 0/5] MR6033: include: Fix another 5 typoed GUIDs
by Alfred Agrell (＠Alcaro) 09 Jul '24

09 Jul '24

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5559 because The Process™ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6033

4 8

Re: [PATCH v5 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Davide Beatrici (＠davidebeatrici) 09 Jul '24

09 Jul '24

Davide Beatrici (@davidebeatrici) commented about dlls/winepulse.drv/pulse.c: > + > + stream->clock_lastpos = stream->clock_written = 0; > + stream->pa_offs_bytes = stream->lcl_offs_bytes = 0; > + stream->held_bytes = stream->pa_held_bytes = 0; > + stream->period_bytes = pa_frame_size(&new_ss) * muldiv(stream->mmdev_period_usec, new_ss.rate, 1000000); > + stream->real_bufsize_bytes = size; > + stream->bufsize_frames = new_bufsize_frames; > + stream->ss = new_ss; > + > + size = 0; > + NtFreeVirtualMemory(GetCurrentProcess(), (void **)&stream->local_buffer, &size, MEM_RELEASE); > + > + silence_buffer(new_ss.format, new_buffer, size); > + stream->local_buffer = new_buffer; > + } > + } Since the operations are more or less the same as in `pulse_create_stream()`, could you create a helper function in a separate commit (that will be first in the list), please? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_75624

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 09 Jul '24

09 Jul '24

On Tue Jul 9 18:18:30 2024 +0000, Dmitry Timoshkov wrote: > Hans is correct. I have a computer that is part of the AD domain, and > before logging into the domain GetUserNameEx(3) returns error 1332 > (ERROR_NONE_MAPPED). After entering the domain GetUserNameEx(3) returns > name that is equal to the displayName field in the LDAP database. > Behaviour is the same for Windows 7 and Windows 10. Hm, interesting. I'll experiment with this and make changes to my branch accordingly. Thank you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75599

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 09 Jul '24

09 Jul '24

On Tue Jul 9 18:14:36 2024 +0000, Hans Leidekker wrote: > Can you add a test case for this in dlls/secur32/tests/secur32.c? Yes, I can. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75598

1 0

[PATCH 0/2] MR5935: winemac.drv: Use ScreenCaptureKit for grabbing window snapshots
by Tim Clem (＠tclem) 09 Jul '24

09 Jul '24

The old method will trigger a permission prompt in Sequoia. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5935

5 11

[PATCH v2 0/1] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) 09 Jul '24

09 Jul '24

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for pcblist64, so I had to fetch it with sysctlbyname. -- v2: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

3 3

Re: [PATCH v3 0/2] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) 09 Jul '24

09 Jul '24

On Tue Jul 9 16:44:32 2024 +0000, Tim Clem wrote: > Whoa, whoops. Thanks, missed that when I was cleaning up the patch. I'm > now caching the mib, which cleans things up a bit as well. Also added the UDP version while I'm at it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021#note_75586

1 0

[PATCH v2 0/11] MR6029: jscript: Introduce new MSHTML bindings.
by Jacek Caban (＠jacek) 09 Jul '24

09 Jul '24

This MR adds a very minimal support for new MSHTML objects bindings that will ultimately allow implementing IE9+ behavior. The plan is to have something testable that we can increment on. It's enabled only for the `Screen` object for now (which is an example of an object without custom properties with no functions). The next step is to work incrementally on enabling it for all MSHTML objects. A few comments on the approach: - The object and its jscript representation share reference counter. This may not be optimal, but it essentially preserves the current behavior where MSHTML is responsible for tracking it. I expect that we will want to revisit that when integrating cycle collector with jscript. - Deleting properties is not yet supported; this will need another function in the interface, but it's not yet needed as we currently don't allow deleting builtin properties anyway (and custom properties are skipped in this MR as they are not needed for the `Screen` object). - Functions are not yet supported, only old-style properties (not accessor properties yet). They are straightforward to support on top of it by extending `property_info` struct to pass iid and implementing them as jscript function. - This does not yet allow host properties to appear and disappear without notifications. This is a limitation of jscript's `dispex.c` (not the interface), which will need to be tweaked before we use new bindings for objects that require it. -- v2: mshtml: Use IWineJSDispatch for screen object script bindings. mshtml: Support using IWineJSDispatch for DispatchEx implementation. mshtml: Pass an optional script global window to init_dispatch. mshtml: Implement jscript IWineJSDispatchHost. jscript: Use jsdisp_t internally for host objects that support it. jscript: Support host objects in disp_cmp. jscript: Support converting host objects to string. https://gitlab.winehq.org/wine/wine/-/merge_requests/6029

3 13

[PATCH 0/2] MR6030: msi: Handle failure from MSI_RecordGetInteger().
by Hans Leidekker (＠hans) 09 Jul '24

09 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56952 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6030

2 2

[PATCH 0/11] MR6029: jscript: Introduce new MSHTML bindings.
by Jacek Caban (＠jacek) 09 Jul '24

09 Jul '24

This MR adds a very minimal support for new MSHTML objects bindings that will ultimately allow implementing IE9+ behavior. The plan is to have something testable that we can increment on. It's enabled only for the `Screen` object for now (which is an example of an object without custom properties with no functions). The next step is to work incrementally on enabling it for all MSHTML objects. A few comments on the approach: - The object and its jscript representation share reference counter. This may not be optimal, but it essentially preserves the current behavior where MSHTML is responsible for tracking it. I expect that we will want to revisit that when integrating cycle collector with jscript. - Deleting properties is not yet supported; this will need another function in the interface, but it's not yet needed as we currently don't allow deleting builtin properties anyway (and custom properties are skipped in this MR as they are not needed for the `Screen` object). - Functions are not yet supported, only old-style properties (not accessor properties yet). They are straightforward to support on top of it by extending `property_info` struct to pass iid and implementing them as jscript function. - This does not yet allow host properties to appear and disappear without notifications. This is a limitation of jscript's `dispex.c` (not the interface), which will need to be tweaked before we use new bindings for objects that require it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6029

3 12

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) 09 Jul '24

09 Jul '24

Hans is correct. I have a computer that is part of the AD domain, and before logging into the domain GetUserNameEx(3) returns error 1332 (ERROR_NONE_MAPPED). After entering the domain GetUserNameEx(3) returns name that is equal to the displayName field in the LDAP database. Behaviour is the same for Windows 7 and Windows 10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75556

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Hans Leidekker (＠hans) 09 Jul '24

09 Jul '24

Can you add a test case for this in dlls/secur32/tests/secur32.c? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75555

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 09 Jul '24

09 Jul '24

> It seems that the Windows machine needs to be joined to a Windows domain for this call to return something sensible. That's... weird, because it doesn't seem to be the case with my Windows installations, nor do Microsoft's docs specify this. (See [https://learn.microsoft.com/en-us/windows/win32/api/secext/nf-secext-getuse…) > Do you have an application that depends [on] this? Yes, I do. It's a game modification called "[OneShot: Fading Memory](https://store.steampowered.com/app/1569440/OneShot_Fading_Memory/)", which I am one of the developers of. It has been released two years ago and has always relied on the GetUserNameEx method. We've received no bug reports related to the game querying the player's name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75551

1 0

[PATCH 0/8] MR6028: Cmd engine rewrite (part XVIII)
by eric pouech (＠epo) 09 Jul '24

09 Jul '24

This is part XVIII of cmd engine rewrite. It mainly focuses on setting the expected return code for some builtin functions. Includes also a fix for pipe inside a redirection (spotted by the added tests). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6028

2 8

[PATCH v2 0/2] MR6014: winhttp/tests: Add some tests for querying string options with NULL buffer.
by Nikolay Sivov (＠nsivov) 09 Jul '24

09 Jul '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: winhttp: Fix error handling when returning string options. winhttp/tests: Add some tests for querying string options with NULL buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/6014

4 4

[PATCH v35 0/9] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 09 Jul '24

09 Jul '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v35: advapi32: Fake the SeLockMemoryPrivilege right in LsaEnumerateAccountRights. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 10

[PATCH 0/2] MR5987: ddraw/tests: Workaround some X11 ConfigureNotify event race condition.
by Rémi Bernon (＠rbernon) 09 Jul '24

09 Jul '24

Somehow more likely to be triggered with https://gitlab.winehq.org/wine/wine/-/merge_requests/5970. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5987

4 4

[PATCH 0/2] MR6026: winemac: Use the new surface shape helper to update window shape.
by Rémi Bernon (＠rbernon) 09 Jul '24

09 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6026

2 2

[PATCH v9 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v9: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

[PATCH v8 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v8: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Hans Leidekker (＠hans) 09 Jul '24

09 Jul '24

In my tests GetUserNameEx(NameDisplay) returns ERROR_NONE_MAPPED on Windows. It seems that the Windows machine needs to be joined to a Windows domain for this call to return something sensible. Do you have an application that depends this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75538

1 0

[PATCH 0/1] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) 09 Jul '24

09 Jul '24

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for pcblist64, so I had to fetch it with sysctlbyname. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

4 4

[PATCH v10 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v10: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

2 2

[PATCH 0/1] MR6024: ntoskrnl.exe: add a stub for KeQueryGroupAffinity
by Austin English (＠austin987) 09 Jul '24

09 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56948 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6024

2 1

2025

2024

2023

2022

wine-gitlab