- wine-gitlab - winehq.org

[PATCH v7 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v7: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

[PATCH v6 0/2] MR5969: Draft: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 09 Jul '24

09 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v6: kernelbase: Ensure null termination in RegGetValue[AW]. windowscodecs: Use RegQueryValueExW in ComponentInfo_GetStringValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

2 2

[PATCH 0/6] MR5999: d3dx9: Miscellaneous fixes.
by Connor McAdams (＠cmcadams) 09 Jul '24

09 Jul '24

This MR contains patches with a few small fixes for things that have been found while working on the usual shared code patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5999

3 11

Re: [PATCH v5 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Etaash Mathamsetty (＠etaash.mathamsetty) 08 Jul '24

08 Jul '24

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/mmdevapi/tests/render.c: > + NULL, (void**)&ac); > + ok(hr == S_OK, "Activation failed with %08lx\n", hr); > + if(hr != S_OK) > + return; > + > + hr = IAudioClient_GetMixFormat(ac, &pwfx); > + ok(hr == S_OK, "GetMixFormat failed: %08lx\n", hr); > + > + hr = IAudioClient_Initialize(ac, AUDCLNT_SHAREMODE_SHARED, 0, 5000000, > + 0, pwfx, NULL); > + ok(hr == S_OK, "Initialize failed: %08lx\n", hr); > + > + CoTaskMemFree(pwfx); > + > + /* contrary to what MSDN says this interface should be obtained via QueryInterface() */ > + hr = IAudioClient_GetService(ac, &IID_IAudioClockAdjustment, (void**)&aca); cracked the mystery, im pretty sure AUDCLNT_STREAMFLAGS_RATEADJUST is needed for GetService to work :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_75515

1 0

Re: [PATCH v3 0/1] MR6019: kerberos: Add support for SECPKG_CRED_BOTH. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6019

1 0

Re: [PATCH v2 0/1] MR6020: msv1_0: Add support for SECPKG_CRED_BOTH. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6020

1 0

Re: [PATCH v2 0/3] MR6016: mshtml: Refactor InvokeEx implementation. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6016

1 0

Re: [PATCH v3 0/3] MR5970: win32u: Use the thread message queue shared memory in peek_message. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5970

1 0

Re: [PATCH v2 0/1] MR6017: mf/tests: Remove static specifier on variables referencing other variables. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6017

1 0

Re: [PATCH v2 0/1] MR6018: winex11: Reset window shape whenever window surface is created. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6018

1 0

Re: [PATCH v2 0/7] MR6015: jscript: Refactor indexed properties handling. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6015

1 0

Re: [PATCH v2 0/1] MR6001: advapi32/tests: Drop security test workarounds for Windows <= 2000. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6001

1 0

Re: [PATCH v2 0/1] MR6008: advapi32/tests: Test RegGetValue[AW] null termination. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6008

1 0

Re: [PATCH v2 0/1] MR6013: msi: Avoid infinite recursion while processing the DrLocator table. - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6013

1 0

Re: [PATCH v2 0/1] MR5619: win32u: Use FT_LOAD_PEDANTIC on first load try in freetype_get_glyph_outline(). - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5619

1 0

Re: [PATCH v2 0/7] MR6010: Cmd engine rewrite (part XVII) - approved
by Alexandre Julliard (＠julliard) 08 Jul '24

08 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6010

1 0

[PATCH v2 0/1] MR6019: kerberos: Add support for SECPKG_CRED_BOTH.
by Dmitry Timoshkov (＠dmitry) 08 Jul '24

08 Jul '24

-- v2: kerberos: Add support for SECPKG_CRED_BOTH. https://gitlab.winehq.org/wine/wine/-/merge_requests/6019

4 4

[PATCH 0/1] MR6019: kerberos: Add support for SECPKG_CRED_BOTH.
by Dmitry Timoshkov (＠dmitry) 08 Jul '24

08 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6019

4 6

[PATCH 0/1] MR6020: msv1_0: Add support for SECPKG_CRED_BOTH.
by Dmitry Timoshkov (＠dmitry) 08 Jul '24

08 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6020

4 3

[PATCH v4 0/2] MR5976: Acquire filesystem labels from dbus
by Alfred Agrell (＠Alcaro) 08 Jul '24

08 Jul '24

-- v4: kernelbase: Delete now-inaccurate 'FS volume label not available' message. https://gitlab.winehq.org/wine/wine/-/merge_requests/5976

3 3

[PATCH 0/7] MR6015: jscript: Refactor indexed properties handling.
by Jacek Caban (＠jacek) 08 Jul '24

08 Jul '24

In preparation for host properties support. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6015

4 10

[PATCH v3 0/2] MR5976: Acquire filesystem labels from dbus
by Alfred Agrell (＠Alcaro) 08 Jul '24

08 Jul '24

-- v3: kernelbase: Silence 'read access denied' message if the device has a label, or if it's not expected to have one. https://gitlab.winehq.org/wine/wine/-/merge_requests/5976

4 13

[PATCH v4 0/4] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Arek Hiler (＠ivyl) 08 Jul '24

08 Jul '24

This is based on work done by Andrew Eikum. It has been in some form in Proton for the last 4 years. If server's sampling rate is not 48kHz **DOOM Eternal** will try to set it 48kHz for the streams using the implemented interface. There's a whole class of audio devices that use 44.1kHz sampling rate and at least PulseAudio / PipeWire tends to inherit the value from the hardware to avoid resampling. The value can also be overridden by the user via the audio server's config files. In such cases, if the interface is not present or stubbed, this results in **audio underruns and noticeable crackling**. It's easy to test with pipewire-pulse: ``` $ cat /etc/pipewire/pipewire.conf.d/sample-rate.conf context.properties = { default.clock.rate = 41100 } ``` With PulseAudio this should be doable via setting `default-sample-rate = 41100` in `/etc/pulse/daemon.conf`. -- v4: winepulse.drv: Implement set_sample_rate. mmdevapi: Implement AudioClockAdjustment_SetSampleRate. mmdevapi: Add stub IAudioClockAdjustment implementation. mmdevapi/tests: Add more IAudioClock tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5585

4 5

[PATCH 0/1] MR6018: winex11: Reset window shape whenever window surface is created.
by Rémi Bernon (＠rbernon) 08 Jul '24

08 Jul '24

When the window was empty, it may have been set an empty shape, we need to reset it or the window may stay invisible if the window shape isn't changed. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56945 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6018

2 1

[PATCH 0/1] MR6017: mf/tests: Remove static specifier on variables referencing other variables.
by Rémi Bernon (＠rbernon) 08 Jul '24

08 Jul '24

Supersedes: https://gitlab.winehq.org/wine/wine/-/merge_requests/5965 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6017

2 1

[PATCH 0/1] MR5979: mfreadwrite: Use GPU copy when available.
by Brendan McGrath (＠redmcg) 08 Jul '24

08 Jul '24

If both buffers are DXGI buffers, they can be copied on the GPU. They are currently transferred to the CPU, copied by the CPU and then transferred back to the GPU. Performing a GPU copy produces ~25% faster playback on 4K video. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5979

6 10

[PATCH 0/3] MR6016: mshtml: Refactor InvokeEx implementation.
by Jacek Caban (＠jacek) 08 Jul '24

08 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6016

3 4

[PATCH v4 0/9] MR6012: Support Windows ODBC drivers
by Hans Leidekker (＠hans) 08 Jul '24

08 Jul '24

-- v4: odbc32/tests: Add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6012

3 10

[PATCH v2 0/2] MR6009: Allow building modules with C++ source
by Grigory Vasilyev (＠h0tc0d3) 08 Jul '24

08 Jul '24

I believe that using CPP files in core Wine code is not a good idea. But it would be nice to have the option to compile C++ modules. For example, lsteamclient from Proton is written partially in C++. Based on @rbernon patch. -- v2: tools/makedep: Allow building modules with C++ sources. https://gitlab.winehq.org/wine/wine/-/merge_requests/6009

4 5

[PATCH 0/1] MR6014: winhttp/tests: Add some tests for querying string options with NULL buffer.
by Nikolay Sivov (＠nsivov) 08 Jul '24

08 Jul '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6014

3 2

[PATCH 0/1] MR6013: msi: Avoid infinite recursion while processing the DrLocator table.
by Hans Leidekker (＠hans) 08 Jul '24

08 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56938 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6013

3 2

[PATCH 0/9] MR6012: Support Windows ODBC drivers
by Hans Leidekker (＠hans) 08 Jul '24

08 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6012

3 10

[PATCH v2 0/5] MR5995: win32u: Use the thread input shared memory for GetForegroundWindow, GetCursorInfo and GetGUIThreadInfo.
by Rémi Bernon (＠rbernon) 08 Jul '24

08 Jul '24

-- v2: win32u: Use the thread input shared memory for NtUserGetGUIThreadInfo. win32u: Use the thread input shared memory for NtUserGetCursorInfo. win32u: Use the thread input shared memory for NtUserGetForegroundWindow. server: Add cursor handle and count to desktop shared memory. server: Add a foreground flag to the thread input shared memory. https://gitlab.winehq.org/wine/wine/-/merge_requests/5995

4 8

[PATCH 0/1] MR6011: mf/session: Fix commands not being accepted anymore
by Torge Matthies (＠tmatthies) 08 Jul '24

08 Jul '24

mf/session: Ensure that the command callback does not return without clearing SESSION_FLAG_PENDING_COMMAND. Leaving SESSION_FLAG_PENDING_COMMAND set results in no more work items being queued by session_submit_command, and even if they were, callback would return immediately due to a check at the start of the function. Thus, it is never valid to leave the function without clearing the SESSION_FLAG_PENDING_COMMAND flag. This case can be hit by SESSION_CMD_START, and leaves the session unable to process any commands. Fix this by ensuring that SESSION_FLAG_PENDING_COMMAND is always cleared before the command callback returns. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6011

3 2

[PATCH 0/1] MR5619: win32u: Use FT_LOAD_PEDANTIC on first load try in freetype_get_glyph_outline().
by Paul Gofman (＠gofman) 08 Jul '24

08 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5619

4 9

[PATCH 0/7] MR6010: Cmd engine rewrite (part XVII)
by eric pouech (＠epo) 08 Jul '24

08 Jul '24

This is part XVII of cmd engine rewrite. Mostly ensuring that another bunch of internal commands set return code / error level. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6010

3 8

[PATCH 0/2] MR6009: Allow building modules with C++ source
by Grigory Vasilyev (＠h0tc0d3) 08 Jul '24

08 Jul '24

I believe that using CPP files in core Wine code is not a good idea. But it would be nice to have the option to compile C++ modules. For example, lsteamclient from Proton is written partially in C++. Based on @rbernon patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6009

3 3

[PATCH v6 0/2] MR5869: winewayland.drv: Add mouse rawinput support
by Grigory Vasilyev (＠h0tc0d3) 08 Jul '24

08 Jul '24

Adds the registry key HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\rawinput witch allows mouse raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing mouse DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, but sensitivity curves in libinput are more difficult to calculate than mouse sensitivity in the games. Implementation of ideas written in the comments: https://gitlab.winehq.org/wine/wine/-/merge_requests/4698 -- v6: winewayland.drv: Add mouse rawinput support https://gitlab.winehq.org/wine/wine/-/merge_requests/5869

3 4

[PATCH 0/1] MR6008: advapi32/tests: Test RegGetValue[AW] null termination.
by Alex Henrie (＠alexhenrie) 08 Jul '24

08 Jul '24

Split from !5969 because fixing this is going to require more invasive changes than I thought. It'd be easier to review the tests and then review the fix separately. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6008

2 1

[PATCH v2 0/1] MR5052: krnl386: Restore simulated real mode interrupts.
by Alex Henrie (＠alexhenrie) 08 Jul '24

08 Jul '24

This partially reverts commit ed6bdb3c51cd4b8c94f9839806321703e7aa9765 and commit 526b245237b9571beebac8a4653e7dd74c62c7de. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56225 -- v2: krnl386: Restore simulated real mode interrupts. https://gitlab.winehq.org/wine/wine/-/merge_requests/5052

3 2

[PATCH 0/1] MR6007: ntdll: Don't use CLOCK_REALTIME_COARSE
by Tatsuyuki Ishi (＠ishitatsuyuki) 07 Jul '24

07 Jul '24

This reverts commit 5c8ea25014f ("ntdll: Use CLOCK_REALTIME_COARSE for NtQuerySystemTime() if it has sufficient resolution.") CLOCK_*_COARSE only provides up to 1ms resolution at CONFIG_HZ=1000. OTOH, there are several ways to get up to 0.5ms resolution on modern Windows (high resolution waitable timers, NtSetTimerResolution with 0.5ms). This code path therefore has a possibility of behaving worse than native. Since COARSE resolution is HZ dependent, this code path only runs if the kernel is configured with CONFIG_HZ=1000. Most distro ships does not ship with this. Therefore, this code path is rarely tested, and is more of a recipe for surprise. If any application rely on fast NtQuerySystemTime they are likely already broken for majority of Wine users. Given the above reason, don't use CLOCK_REALTIME_COARSE. Use gettimeofday which is internally hooked to CLOCK_REALTIME. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6007

3 3

Re: [PATCH v4 0/8] MR5962: win32u: Implement common window surface shape logic with a 1bpp bitmap.
by Chunhao Hung (＠otakuxtom) 07 Jul '24

07 Jul '24

After this is merged, there are a regression I have report a bug https://bugs.winehq.org/show_bug.cgi?id=56945 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5962#note_75375

1 0

[PATCH 0/2] MR6006: dwmapi: Simulate DwmFlush blocking behavior.
by Grazvydas Ignotas (＠notaz) 06 Jul '24

06 Jul '24

The documentation states it's a blocking call. There are reports of it being used for WaitForVBlank-like purposes [1]. Without blocking Softube VST plugin logic breaks and they never update their UIs. [1] https://news.ycombinator.com/item?id=34501612 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56935 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6006

3 3

[PATCH v3 0/3] MR6004: comctl32: A NULL string fix.
by Aida Jonikienė (＠DodoGTA) 06 Jul '24

06 Jul '24

-- v3: comctl32/tests: Add tests for NULL strings with edit control WM_GETTEXT message. user32: Correctly handle NULL string in WM_GETTEXT AtoW wrapper. https://gitlab.winehq.org/wine/wine/-/merge_requests/6004

2 4

[PATCH v2 0/3] MR6004: comctl32: A NULL string fix.
by Aida Jonikienė (＠DodoGTA) 06 Jul '24

06 Jul '24

-- v2: comctl32/tests: Add tests for NULL strings with edit control WM_GETTEXT message. user32: Fail on NULL string in WM_GETTEXT AtoW wrapper. comctl32: Fail on NULL string for edit control WM_GETTEXT message. https://gitlab.winehq.org/wine/wine/-/merge_requests/6004

2 4

Re: [PATCH v7 0/2] MR5692: shell32: Fix ShellExecute for non-filespec paths
by Louis Lenders (＠xe) 06 Jul '24

06 Jul '24

Hi Yuxuan, This introduces a regression i reported here: https://bugs.winehq.org/show_bug.cgi?id=56940 As it seems you don't have a bugilla account, i report the regression here. regards -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5692#note_75368

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 06 Jul '24

06 Jul '24

Weird. The `build-linux` job cannot continue, because `git rebase` fails.\ Why is it even trying to rebase? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75256

1 0

[PATCH 0/34] MR6005: Introduce fast synchronization in using NTsync
by Alexis Peypelut (＠IroAlexis) 05 Jul '24

05 Jul '24

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6005

1 2

Re: [PATCH v3 0/1] MR5687: ddraw: Set dwMaxVertexCount to 2048. - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5687

1 0

Re: [PATCH v2 0/1] MR6000: kernel32/tests: Fix CompareStringW test crash when linguistic compressions are used. - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6000

1 0

Re: [PATCH v3 0/1] MR5996: wineboot: Correct size argument to SetupDiSetDeviceRegistryPropertyA. - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5996

1 0

Re: [PATCH v3 0/1] MR5958: d3dx9_36: Remove superflous nullcheck (coverity) - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5958

1 0

Re: [PATCH v3 0/7] MR5997: Cmd engine rewrite (part XVI) - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5997

1 0

Re: [PATCH v2 0/1] MR5989: mfreadwrite/reader: Look for a matching output type if setting it failed. - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5989

1 0

Re: [PATCH v7 0/1] MR5706: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706

1 0

Re: [PATCH v4 0/8] MR5962: win32u: Implement common window surface shape logic with a 1bpp bitmap. - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5962

1 0

Re: [PATCH v3 0/5] MR5991: winegstreamer/video_encoder: More of h264 encoder transform implementations (2). - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5991

1 0

Re: [PATCH v3 0/7] MR5992: windows.web: Implement IJsonValueStatics::CreateStringValue(). - approved
by Alexandre Julliard (＠julliard) 05 Jul '24

05 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5992

1 0

[PATCH 0/2] MR6004: comctl32: A NULL string fix.
by Aida Jonikienė (＠DodoGTA) 05 Jul '24

05 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6004

2 2

[PATCH 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 05 Jul '24

05 Jul '24

This merge request implements the third name format ("[NameDisplay](https://learn.microsoft.com/en-us/windows/win32/api/secext/ne-…") of the GetUserNameExW method. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002

2 1

[PATCH 0/1] MR6001: advapi32/tests: Drop security test workarounds for Windows <= 2000.
by Alex Henrie (＠alexhenrie) 05 Jul '24

05 Jul '24

Dropping the workarounds for Windows versions that we don't care about anymore makes it easier to understand what these tests are doing and what's going wrong when they fail. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6001

2 2

[PATCH v2 0/1] MR5687: ddraw: Set dwMaxVertexCount to 2048.
by Stefan Dösinger (＠stefan) 05 Jul '24

05 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44863 The bug has been fixed already by moving ddraw4 vertex buffers into system memory. Changing this value makes the game create a smaller buffer, which makes the game fast on video memory buffers. I think we should stay close to what Windows drivers report even though we mitigated the original issue in a different way. -- v2: ddraw: Set dwMaxVertexCount to 2048. https://gitlab.winehq.org/wine/wine/-/merge_requests/5687

3 3

[PATCH v2 0/3] MR5970: win32u: Use the thread message queue shared memory in peek_message.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

-- v2: win32u: Simplify the logic for driver messages polling. win32u: Use the thread message queue shared memory in peek_message. win32u: Allocate heap in peek_message only when necessary. https://gitlab.winehq.org/wine/wine/-/merge_requests/5970

2 4

Re: [PATCH v2 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Elizabeth Figura (＠zfigura) 05 Jul '24

05 Jul '24

> Onimusha: Warlords doesn't even use H264 and has several other problems. None of these games need H264 to be explicitly exposed, they only need compressed output. This merge request isn't about H.264; it's about compressed samples in general. 1/3 and 2/3 are here because H.264 needs slightly special treatment. > This is also only making my work on upstreaming Proton changes more difficult and I don't really understand what you are trying to achieve here. The purpose of 3/3 is to fix bugs related to applications explicitly or implicitly assuming that the media source outputs compressed samples. What changes does it make more difficult to upstream? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988#note_75210

1 0

[PATCH 0/1] MR6000: kernel32/tests: Fix CompareStringW test crash when linguistic compressions are used.
by Piotr Caban (＠piotr) 05 Jul '24

05 Jul '24

The test crashes in Polish locale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6000

2 1

[PATCH v2 0/1] MR5996: wineboot: Correct size argument to SetupDiSetDeviceRegistryPropertyA.
by Alex Henrie (＠alexhenrie) 05 Jul '24

05 Jul '24

This bug is the cause of at least some of the Linux test failures on !5969. -- v2: wineboot: Correct size argument to SetupDiSetDeviceRegistryPropertyA. https://gitlab.winehq.org/wine/wine/-/merge_requests/5996

2 1

[PATCH 0/4] MR5970: win32u: Use the thread message queue shared memory in peek_message.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5970

4 8

[PATCH v2 0/1] MR5958: d3dx9_36: Remove superflous nullcheck (coverity)
by Fabian Maurer (＠DarkShadow44) 05 Jul '24

05 Jul '24

Since we return when the factory creation fails, it can't be null here -- v2: d3dx9: Remove superflous nullcheck (coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/5958

3 3

[PATCH v2 0/7] MR5992: windows.web: Implement IJsonValueStatics::CreateStringValue().
by Mohamad Al-Jaf (＠maljaf) 05 Jul '24

05 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56914 This is also needed by Adobe Premiere Pro 2024. -- v2: windows.web: Implement IJsonValueStatics::CreateStringValue(). windows.web/tests: Add IJsonValueStatics::CreateStringValue() tests. windows.web: Add IJsonValueStatics stub interface. include: Add IJsonValueStatics interface definition. windows.web: Implement IActivationFactory::ActivateInstance(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5992

4 10

[PATCH v2 0/7] MR5997: Cmd engine rewrite (part XVI)
by eric pouech (＠epo) 05 Jul '24

05 Jul '24

This is part XVI of cmd engine rewrite. Nothing fancy, mainly setting success/failure return code for a bunch of commands. Some code cleanup. -- v2: programs/cmd: Set success/failure return code for LABEL command. programs/cmd: Set success/failure return code for VOL command. programs/cmd: Set success/failure return code for VERIFY command. programs/cmd: Set success/failure return code for VER command. programs/cmd: Set success/failure return code for DATE TIME commands. programs/cmd: Set success/failure return code for SETLOCAL/ENDLOCAL commands. programs/cmd/tests: Test success / failure for more commands. https://gitlab.winehq.org/wine/wine/-/merge_requests/5997

2 8

[PATCH 0/1] MR5989: mfreadwrite/reader: Look for a matching output type if setting it failed.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

The source reader accepts incomplete output types that decoders don't. This is for instance the case with audio types with only a subtype but no MF_MT_AUDIO_BITS_PER_SAMPLE attribute specified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5989

3 2

[PATCH v6 0/1] MR5706: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper
by Ilia Docin (＠IDocin) 05 Jul '24

05 Jul '24

-- v6: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5706

4 4

[PATCH 0/7] MR5997: Cmd engine rewrite (part XVI)
by eric pouech (＠epo) 05 Jul '24

05 Jul '24

This is part XVI of cmd engine rewrite. Nothing fancy, mainly setting success/failure return code for a bunch of commands. Some code cleanup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5997

3 8

[PATCH 0/10] MR5998: winegstreamer: Introduce a new demuxer interface for the MF media source.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

First part of a series introducing a separate unix interface for the MF media source. The goal is to use a synchronous demuxing-only interface, similar to native, which will be simpler and faster and better fitted to most MF media source use cases. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5998

2 10

[PATCH 0/1] MR5996: wineboot: Correct size argument to SetupDiSetDeviceRegistryPropertyA.
by Alex Henrie (＠alexhenrie) 05 Jul '24

05 Jul '24

This bug is the cause of at least some of the Linux test failures on !5969. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5996

2 1

[PATCH 0/5] MR5995: win32u: Use the thread input shared memory for GetForegroundWindow, GetCursorInfo and GetGUIThreadInfo.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5995

2 5

[PATCH v3 0/8] MR5962: win32u: Implement common window surface shape logic with a 1bpp bitmap.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

Used for winex11 and later will be used in winemac and winewayland. -- v3: win32u: Pass the shape bitmap info and bits to window_surface flush. win32u: Update the window surface shape with color key and alpha. win32u: Use a 1bpp bitmap to store the window surface shape bits. win32u: Introduce a new window surface helper to set window shape. win32u: Pass whether window is shaped to drivers WindowPosChanging. win32u: Pass the window surface rect for CreateLayeredWindow. win32u: Split a new create_window_surface helper from apply_window_pos. win32u: Move offscreen window surface creation fallback. https://gitlab.winehq.org/wine/wine/-/merge_requests/5962

3 10

[PATCH v2 0/5] MR5991: winegstreamer/video_encoder: More of h264 encoder transform implementations (2).
by Ziqing Hui (＠zhui) 05 Jul '24

05 Jul '24

-- v2: winegstreamer/video_encoder: Implement ProcessMessage. winegstreamer/video_encoder: Implement ProcessInput. winegstreamer/video_encoder: Create wg_transform. winegstreamer/video_encoder: Clear input type when setting output type. winegstreamer/video_encoder: Rename create_input_type to video_encoder_create_input_type. https://gitlab.winehq.org/wine/wine/-/merge_requests/5991

3 6

[PATCH 0/6] MR5991: h264 encoder transform implementations.
by Ziqing Hui (＠zhui) 05 Jul '24

05 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5991

3 11

Re: [PATCH v3 0/8] MR5881: d3dx9: Use shared code for loading volumes/volume textures from files. - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5881

1 0

Re: [PATCH v2 0/1] MR5954: dinput: Call handle_foreground_lost() synchronously in cbt_hook_proc(). - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5954

1 0

Re: [PATCH v2 0/1] MR5929: winemac.drv: Remove the clear OpenGL views to black hack. - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5929

1 0

Re: [PATCH v2 0/6] MR5993: Cmd engine rewrite (part XV) - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5993

1 0

Re: [PATCH v2 0/1] MR5980: mscoree: Pass size in bytes to RegGetValueW. - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5980

1 0

Re: [PATCH v2 0/6] MR5985: server: Create a thread input shared object and use it for NtUserGetGUIThreadInfo. - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5985

1 0

[PATCH 0/1] MR5958: d3dx9_36: Remove superflous nullcheck (coverity)
by Fabian Maurer (＠DarkShadow44) 04 Jul '24

04 Jul '24

Since we return when the factory creation fails, it can't be null here -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5958

3 2

[PATCH v2 0/8] MR5881: d3dx9: Use shared code for loading volumes/volume textures from files.
by Connor McAdams (＠cmcadams) 04 Jul '24

04 Jul '24

-- v2: d3dx9: Add support for mipmap generation to D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9: Use d3dx_image structure inside of D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9: Cleanup texture value argument handling in D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9: Refactor texture creation and cleanup in D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9/tests: Add more tests for D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9: Use shared code in D3DXLoadVolumeFromFileInMemory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5881

3 16

[PATCH 0/1] MR5954: dinput: Call handle_foreground_lost() synchronously in cbt_hook_proc().
by Shaun Ren (＠shaunren) 04 Jul '24

04 Jul '24

mouse_unacquire() needs to be called on the same thread as mouse_acquire(), otherwise the cursor hidden by mouse_unacquire() will not be restored. Fixes an issue with [the cursor disappearing in the game IL-2: Cliffs of Dover Blitz Edition](https://github.com/ValveSoftware/Proton/issues/5007#issuecomment-2…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5954

3 2

[PATCH 0/1] MR5929: winemac.drv: Remove the clear OpenGL views to black hack.
by Zhiyi Zhang (＠zhiyi) 04 Jul '24

04 Jul '24

Fix black screen issues for Active Trader Pro and Assetto Corsa. This reverts commit 4124478b. For Active Trader Pro, the hack ends up clearing a context that was previously drawn to to black, possibly because multiple OpenGL contexts are involved according to Henri's investigation. Assetto Corsa creates a D3D device for a window but doesn't actually do any rendering with it. After ceefcca7, having an OpenGL context for a window clears its OpenGL surface to black after its view becomes visible. The OpenGL surface is on top of other layers for the window so the window becomes black after that. The blackness is originally from glDrawBuffer(GL_FRONT_AND_BACK), which presumably prepares a zero-initialized OpenGL front draw buffer. This also suggests that 4124478b is no longer necessary. I could delay the clearToBlackIfNeeded() call so it uses the behavior before ceefcca7, but now that it seems the hack is no longer necessary and might cause more errors. CrossOver has disabled the hack for a while and it seems fine. I think it's time to remove the hack. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5929

3 3

[PATCH 0/1] MR5978: winegstreamer: Optimise copy to DXGI buffer.
by Brendan McGrath (＠redmcg) 04 Jul '24

04 Jul '24

Using IMF2DBuffer2_Lock2DSize with LockFlags_Write dramatically improves performance over IMFMediaBuffer_Lock when using a DXGI buffer. IMFMediaBuffer_Lock does not know that this buffer will not be read and therefore performs an unnecessary transfer of the texture from GPU to CPU before it is overwritten. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5978

4 5

Re: [PATCH v2 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

On Thu Jul 4 10:45:58 2024 +0000, Chunhao Hung wrote: > After test on the actually game Rune Factory 5 it shown, and stock > there. no audio. > ``` > 079c:fixme:process:SetProcessShutdownParameters (000003ff, 00000000): > partial stub. > 0604:fixme:mmdevapi:control_UnregisterAudioSessionNotification > (00007FFFFF2DD810)->(0000488C0007D5A0) - stub > (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:17.574: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > winegstreamer error: qtdemux0: Internal data stream error. > winegstreamer error: qtdemux0: ../gst/isomp4/qtdemux.c(6749): > gst_qtdemux_loop (): /GstBin:bin0/GstDecodeBin:decodebin0/GstQTDemux:qtdemux0: > streaming stopped, reason not-linked (-1) > (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:19.499: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > winegstreamer error: qtdemux1: Internal data stream error. > winegstreamer error: qtdemux1: ../gst/isomp4/qtdemux.c(6749): > gst_qtdemux_loop (): /GstBin:bin1/GstDecodeBin:decodebin1/GstQTDemux:qtdemux1: > streaming stopped, reason not-linked (-1) > ``` > Without this patch, some of audio in video are normal, just no video is shown. > here is log with +mfplat > [stdout.xz](/uploads/db4cea226cffe3f8a582d3ac39539c39/stdout.xz) This fails because for some reason your GStreamer setup doesn't have h264parse. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988#note_75116

1 0

[PATCH 0/7] MR5992: windows.web: Implement IJsonValueStatics::CreateStringValue().
by Mohamad Al-Jaf (＠maljaf) 04 Jul '24

04 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56914 This is also needed by Adobe Premiere Pro 2024. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5992

3 11

[PATCH 0/7] MR5388: Draft: RFC: WGL_ARB_pixel_format logic in opengl32
by Alexandros Frantzis (＠afrantzis) 04 Jul '24

04 Jul '24

As mentioned in https://gitlab.winehq.org/wine/wine/-/merge_requests/5264, the next step for OpenGL in the Wayland driver is support for WGL_ARB_pixel_format. It seems possible, at least in theory, to move a large part of the logic involved in this extension outside the drivers for common use by all of them (or ones that want to opt-in). The goal of this RFC MR is, through experimentation and discussion/feedback, evaluate: 1. Whether making such functionality available outside the drivers (likely in an opt-in manner to begin with) is a productive way forward, or the complexity and platform specific decisions favor the current per-driver approach. 2. If we think that (1) is a worthy goal, what's the best mechanism to achieve it. Note that the focus of this MR is currently on being a proof-of-concept, rather providing ready-for-detailed-review code (although I have done my best to keep the code decent). This MR currently (roughly in commit order): * Introduces a new wgl driver callback to allow drivers to provide to opengl32/unix a list of formats and many details about them. * Uses the information in that list to implement wglGetPixelFormatAttrib*. * Uses the information in that list plus format sorting rules from WineX11 (effectively GLX rules plus tweaks) to implement wglChoosePixelFormatARB. * Implements the get_pixel_formats callback for the Wayland driver. * Hacks the get_pixel_formats callback for WineX11, and to allow me to run some experiments to compare the output of native WineX11 and get_pixel_formats-WineX11. In the admittedly not too many games I tried the sort order is the same, so at least that's encouraging. My thoughts and notes so far: * Using this approach for wglGetPixelFormatAttrib* works well, and we can also implement wglDescribePixelFormat in this way. * It's not at all clear what the "right" sorting rules are for wglChoosePixelFormatARB. * WineX11 uses GLX + tweaks (e.g., changes depth sorting). This means that larger formats tend to be preferred, at least according to the GLX spec. For example, asking for a r5, g6, b5 in the attributes is supposed to give back rgb888 (or even higher if available) as the top format in the list. Interestingly, and to confuse things even more, I haven't been able to make GLX return non-888(8) configs at all to actually test this more, so perhaps that's what saves it here? However, eglChooseConfig works similarly and there I was able to verify this behavior (e.g., got a nice surprise 10-bit format when asking for 5551 :)). * Winemac has its own custom logic. * Mesa's WGL implementation uses a different approach, closer to Wine's normal (wgl)ChoosePixelFormat, where proximity to the target format is strongly rewarded (so it seems asking for r5g6b5 is much more likely to actually get you that). * Of course, the "gold standard" here would be to try to infer and use the rules used by some windows driver. Looking forward to thoughts/feedback! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5388

3 14

[PATCH 0/6] MR5993: Cmd engine rewrite (part XV)
by eric pouech (＠epo) 04 Jul '24

04 Jul '24

This is part XV of cmd engine rewrite. This MR deals with returning the proper success/failure return code for POPD and RMDIR. However, these commands never set ERRORLEVEL (all the commands we've handled so far always set ERRORLEVEL in case of failure, and some reset ERRORLEVEL in case of successs). So this MR on top of returning the expected success/failure return code for these two commands, also: - extend tests to show that ERRORLEVEL isn't set - tweak internal call path to better handle return code vs ERRORLEVEL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5993

2 6

[PATCH 0/3] MR5990: mfreadwrite/reader: Fix seeking and playback loop when using decoders.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5990

2 4

[PATCH 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Elizabeth Figura (＠zfigura) 04 Jul '24

04 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988

3 4

[PATCH v3 0/10] MR5055: winegstreamer: Support input video frame padding and cropping.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

On the client side, frame aperture may be included or omitted. This can be used to include or drop the frame padding, and the VideoProcessor MFT supports it. On GStreamer side, we can only use the unpadded frame size in the caps, because this is how decoders work, and padding needs to be added as a property of the input/output video buffers. Then, frame size needs to be adjusted to be consistent between input and output, and any difference considered as extra padding to be added on one side or the other. -- v3: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Exclude padding from wg_format video frame size. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Update the output_format when stream format changes. winegstreamer: Pass optional GstVideoInfo to read_transform_output_data. winegstreamer: Split read_transform_output_data in two helpers. winegstreamer: Introduce a new sample_needs_copy_buffer helper. winegstreamer: Introduce a new sample_set_flags_from_buffer helper. mf/tests: Add more video processor tests with aperture. https://gitlab.winehq.org/wine/wine/-/merge_requests/5055

4 15

Re: [PATCH v2 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

Onimusha: Warlords doesn't even use H264 and has several other problems. None of these games need H264 to be explicitly exposed, they only need compressed output. This is also only making my work on upstreaming Proton changes more difficult and I don't really understand what you are trying to achieve here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988#note_75084

1 0

Re: [PATCH v2 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Chunhao Hung (＠otakuxtom) 04 Jul '24

04 Jul '24

After test on the actually game Rune Factory 5 it shown, and stock there. no audio. ``` 079c:fixme:process:SetProcessShutdownParameters (000003ff, 00000000): partial stub. 0604:fixme:mmdevapi:control_UnregisterAudioSessionNotification (00007FFFFF2DD810)->(0000488C0007D5A0) - stub (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed (wine:112100): GStreamer-CRITICAL **: 13:05:17.574: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed winegstreamer error: qtdemux0: Internal data stream error. winegstreamer error: qtdemux0: ../gst/isomp4/qtdemux.c(6749): gst_qtdemux_loop (): /GstBin:bin0/GstDecodeBin:decodebin0/GstQTDemux:qtdemux0: streaming stopped, reason not-linked (-1) (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed (wine:112100): GStreamer-CRITICAL **: 13:05:19.499: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed winegstreamer error: qtdemux1: Internal data stream error. winegstreamer error: qtdemux1: ../gst/isomp4/qtdemux.c(6749): gst_qtdemux_loop (): /GstBin:bin1/GstDecodeBin:decodebin1/GstQTDemux:qtdemux1: streaming stopped, reason not-linked (-1) ``` Without this patch, some of audio in video are normal, just no video is shown. here is log with +mfplat [stdout.xz](/uploads/db4cea226cffe3f8a582d3ac39539c39/stdout.xz) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988#note_75083

1 0

[PATCH 0/1] MR5980: mscoree: Pass size in bytes to RegGetValueW.
by Alex Henrie (＠alexhenrie) 04 Jul '24

04 Jul '24

Split from !5969 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5980

3 2

2025

2024

2023

2022

wine-gitlab