- wine-gitlab - winehq.org

[PATCH 0/1] MR6001: advapi32/tests: Drop security test workarounds for Windows <= 2000.
by Alex Henrie (＠alexhenrie) 05 Jul '24

05 Jul '24

Dropping the workarounds for Windows versions that we don't care about anymore makes it easier to understand what these tests are doing and what's going wrong when they fail. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6001

2 2

[PATCH v2 0/1] MR5687: ddraw: Set dwMaxVertexCount to 2048.
by Stefan Dösinger (＠stefan) 05 Jul '24

05 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44863 The bug has been fixed already by moving ddraw4 vertex buffers into system memory. Changing this value makes the game create a smaller buffer, which makes the game fast on video memory buffers. I think we should stay close to what Windows drivers report even though we mitigated the original issue in a different way. -- v2: ddraw: Set dwMaxVertexCount to 2048. https://gitlab.winehq.org/wine/wine/-/merge_requests/5687

3 3

[PATCH v2 0/3] MR5970: win32u: Use the thread message queue shared memory in peek_message.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

-- v2: win32u: Simplify the logic for driver messages polling. win32u: Use the thread message queue shared memory in peek_message. win32u: Allocate heap in peek_message only when necessary. https://gitlab.winehq.org/wine/wine/-/merge_requests/5970

2 4

Re: [PATCH v2 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Elizabeth Figura (＠zfigura) 05 Jul '24

05 Jul '24

> Onimusha: Warlords doesn't even use H264 and has several other problems. None of these games need H264 to be explicitly exposed, they only need compressed output. This merge request isn't about H.264; it's about compressed samples in general. 1/3 and 2/3 are here because H.264 needs slightly special treatment. > This is also only making my work on upstreaming Proton changes more difficult and I don't really understand what you are trying to achieve here. The purpose of 3/3 is to fix bugs related to applications explicitly or implicitly assuming that the media source outputs compressed samples. What changes does it make more difficult to upstream? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988#note_75210

1 0

[PATCH 0/1] MR6000: kernel32/tests: Fix CompareStringW test crash when linguistic compressions are used.
by Piotr Caban (＠piotr) 05 Jul '24

05 Jul '24

The test crashes in Polish locale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6000

2 1

[PATCH v2 0/1] MR5996: wineboot: Correct size argument to SetupDiSetDeviceRegistryPropertyA.
by Alex Henrie (＠alexhenrie) 05 Jul '24

05 Jul '24

This bug is the cause of at least some of the Linux test failures on !5969. -- v2: wineboot: Correct size argument to SetupDiSetDeviceRegistryPropertyA. https://gitlab.winehq.org/wine/wine/-/merge_requests/5996

2 1

[PATCH 0/4] MR5970: win32u: Use the thread message queue shared memory in peek_message.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5970

4 8

[PATCH v2 0/1] MR5958: d3dx9_36: Remove superflous nullcheck (coverity)
by Fabian Maurer (＠DarkShadow44) 05 Jul '24

05 Jul '24

Since we return when the factory creation fails, it can't be null here -- v2: d3dx9: Remove superflous nullcheck (coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/5958

3 3

[PATCH v2 0/7] MR5992: windows.web: Implement IJsonValueStatics::CreateStringValue().
by Mohamad Al-Jaf (＠maljaf) 05 Jul '24

05 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56914 This is also needed by Adobe Premiere Pro 2024. -- v2: windows.web: Implement IJsonValueStatics::CreateStringValue(). windows.web/tests: Add IJsonValueStatics::CreateStringValue() tests. windows.web: Add IJsonValueStatics stub interface. include: Add IJsonValueStatics interface definition. windows.web: Implement IActivationFactory::ActivateInstance(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5992

4 10

[PATCH v2 0/7] MR5997: Cmd engine rewrite (part XVI)
by eric pouech (＠epo) 05 Jul '24

05 Jul '24

This is part XVI of cmd engine rewrite. Nothing fancy, mainly setting success/failure return code for a bunch of commands. Some code cleanup. -- v2: programs/cmd: Set success/failure return code for LABEL command. programs/cmd: Set success/failure return code for VOL command. programs/cmd: Set success/failure return code for VERIFY command. programs/cmd: Set success/failure return code for VER command. programs/cmd: Set success/failure return code for DATE TIME commands. programs/cmd: Set success/failure return code for SETLOCAL/ENDLOCAL commands. programs/cmd/tests: Test success / failure for more commands. https://gitlab.winehq.org/wine/wine/-/merge_requests/5997

2 8

[PATCH 0/1] MR5989: mfreadwrite/reader: Look for a matching output type if setting it failed.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

The source reader accepts incomplete output types that decoders don't. This is for instance the case with audio types with only a subtype but no MF_MT_AUDIO_BITS_PER_SAMPLE attribute specified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5989

3 2

[PATCH v6 0/1] MR5706: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper
by Ilia Docin (＠IDocin) 05 Jul '24

05 Jul '24

-- v6: comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5706

4 4

[PATCH 0/7] MR5997: Cmd engine rewrite (part XVI)
by eric pouech (＠epo) 05 Jul '24

05 Jul '24

This is part XVI of cmd engine rewrite. Nothing fancy, mainly setting success/failure return code for a bunch of commands. Some code cleanup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5997

3 8

[PATCH 0/10] MR5998: winegstreamer: Introduce a new demuxer interface for the MF media source.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

First part of a series introducing a separate unix interface for the MF media source. The goal is to use a synchronous demuxing-only interface, similar to native, which will be simpler and faster and better fitted to most MF media source use cases. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5998

2 10

[PATCH 0/1] MR5996: wineboot: Correct size argument to SetupDiSetDeviceRegistryPropertyA.
by Alex Henrie (＠alexhenrie) 05 Jul '24

05 Jul '24

This bug is the cause of at least some of the Linux test failures on !5969. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5996

2 1

[PATCH 0/5] MR5995: win32u: Use the thread input shared memory for GetForegroundWindow, GetCursorInfo and GetGUIThreadInfo.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5995

2 5

[PATCH v3 0/8] MR5962: win32u: Implement common window surface shape logic with a 1bpp bitmap.
by Rémi Bernon (＠rbernon) 05 Jul '24

05 Jul '24

Used for winex11 and later will be used in winemac and winewayland. -- v3: win32u: Pass the shape bitmap info and bits to window_surface flush. win32u: Update the window surface shape with color key and alpha. win32u: Use a 1bpp bitmap to store the window surface shape bits. win32u: Introduce a new window surface helper to set window shape. win32u: Pass whether window is shaped to drivers WindowPosChanging. win32u: Pass the window surface rect for CreateLayeredWindow. win32u: Split a new create_window_surface helper from apply_window_pos. win32u: Move offscreen window surface creation fallback. https://gitlab.winehq.org/wine/wine/-/merge_requests/5962

3 10

[PATCH v2 0/5] MR5991: winegstreamer/video_encoder: More of h264 encoder transform implementations (2).
by Ziqing Hui (＠zhui) 05 Jul '24

05 Jul '24

-- v2: winegstreamer/video_encoder: Implement ProcessMessage. winegstreamer/video_encoder: Implement ProcessInput. winegstreamer/video_encoder: Create wg_transform. winegstreamer/video_encoder: Clear input type when setting output type. winegstreamer/video_encoder: Rename create_input_type to video_encoder_create_input_type. https://gitlab.winehq.org/wine/wine/-/merge_requests/5991

3 6

[PATCH 0/6] MR5991: h264 encoder transform implementations.
by Ziqing Hui (＠zhui) 05 Jul '24

05 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5991

3 11

Re: [PATCH v3 0/8] MR5881: d3dx9: Use shared code for loading volumes/volume textures from files. - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5881

1 0

Re: [PATCH v2 0/1] MR5954: dinput: Call handle_foreground_lost() synchronously in cbt_hook_proc(). - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5954

1 0

Re: [PATCH v2 0/1] MR5929: winemac.drv: Remove the clear OpenGL views to black hack. - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5929

1 0

Re: [PATCH v2 0/6] MR5993: Cmd engine rewrite (part XV) - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5993

1 0

Re: [PATCH v2 0/1] MR5980: mscoree: Pass size in bytes to RegGetValueW. - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5980

1 0

Re: [PATCH v2 0/6] MR5985: server: Create a thread input shared object and use it for NtUserGetGUIThreadInfo. - approved
by Alexandre Julliard (＠julliard) 04 Jul '24

04 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5985

1 0

[PATCH 0/1] MR5958: d3dx9_36: Remove superflous nullcheck (coverity)
by Fabian Maurer (＠DarkShadow44) 04 Jul '24

04 Jul '24

Since we return when the factory creation fails, it can't be null here -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5958

3 2

[PATCH v2 0/8] MR5881: d3dx9: Use shared code for loading volumes/volume textures from files.
by Connor McAdams (＠cmcadams) 04 Jul '24

04 Jul '24

-- v2: d3dx9: Add support for mipmap generation to D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9: Use d3dx_image structure inside of D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9: Cleanup texture value argument handling in D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9: Refactor texture creation and cleanup in D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9/tests: Add more tests for D3DXCreateVolumeTextureFromFileInMemoryEx(). d3dx9: Use shared code in D3DXLoadVolumeFromFileInMemory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5881

3 16

[PATCH 0/1] MR5954: dinput: Call handle_foreground_lost() synchronously in cbt_hook_proc().
by Shaun Ren (＠shaunren) 04 Jul '24

04 Jul '24

mouse_unacquire() needs to be called on the same thread as mouse_acquire(), otherwise the cursor hidden by mouse_unacquire() will not be restored. Fixes an issue with [the cursor disappearing in the game IL-2: Cliffs of Dover Blitz Edition](https://github.com/ValveSoftware/Proton/issues/5007#issuecomment-2…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5954

3 2

[PATCH 0/1] MR5929: winemac.drv: Remove the clear OpenGL views to black hack.
by Zhiyi Zhang (＠zhiyi) 04 Jul '24

04 Jul '24

Fix black screen issues for Active Trader Pro and Assetto Corsa. This reverts commit 4124478b. For Active Trader Pro, the hack ends up clearing a context that was previously drawn to to black, possibly because multiple OpenGL contexts are involved according to Henri's investigation. Assetto Corsa creates a D3D device for a window but doesn't actually do any rendering with it. After ceefcca7, having an OpenGL context for a window clears its OpenGL surface to black after its view becomes visible. The OpenGL surface is on top of other layers for the window so the window becomes black after that. The blackness is originally from glDrawBuffer(GL_FRONT_AND_BACK), which presumably prepares a zero-initialized OpenGL front draw buffer. This also suggests that 4124478b is no longer necessary. I could delay the clearToBlackIfNeeded() call so it uses the behavior before ceefcca7, but now that it seems the hack is no longer necessary and might cause more errors. CrossOver has disabled the hack for a while and it seems fine. I think it's time to remove the hack. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5929

3 3

[PATCH 0/1] MR5978: winegstreamer: Optimise copy to DXGI buffer.
by Brendan McGrath (＠redmcg) 04 Jul '24

04 Jul '24

Using IMF2DBuffer2_Lock2DSize with LockFlags_Write dramatically improves performance over IMFMediaBuffer_Lock when using a DXGI buffer. IMFMediaBuffer_Lock does not know that this buffer will not be read and therefore performs an unnecessary transfer of the texture from GPU to CPU before it is overwritten. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5978

4 5

Re: [PATCH v2 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

On Thu Jul 4 10:45:58 2024 +0000, Chunhao Hung wrote: > After test on the actually game Rune Factory 5 it shown, and stock > there. no audio. > ``` > 079c:fixme:process:SetProcessShutdownParameters (000003ff, 00000000): > partial stub. > 0604:fixme:mmdevapi:control_UnregisterAudioSessionNotification > (00007FFFFF2DD810)->(0000488C0007D5A0) - stub > (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:17.574: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > winegstreamer error: qtdemux0: Internal data stream error. > winegstreamer error: qtdemux0: ../gst/isomp4/qtdemux.c(6749): > gst_qtdemux_loop (): /GstBin:bin0/GstDecodeBin:decodebin0/GstQTDemux:qtdemux0: > streaming stopped, reason not-linked (-1) > (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:19.499: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > winegstreamer error: qtdemux1: Internal data stream error. > winegstreamer error: qtdemux1: ../gst/isomp4/qtdemux.c(6749): > gst_qtdemux_loop (): /GstBin:bin1/GstDecodeBin:decodebin1/GstQTDemux:qtdemux1: > streaming stopped, reason not-linked (-1) > ``` > Without this patch, some of audio in video are normal, just no video is shown. > here is log with +mfplat > [stdout.xz](/uploads/db4cea226cffe3f8a582d3ac39539c39/stdout.xz) This fails because for some reason your GStreamer setup doesn't have h264parse. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988#note_75116

1 0

[PATCH 0/7] MR5992: windows.web: Implement IJsonValueStatics::CreateStringValue().
by Mohamad Al-Jaf (＠maljaf) 04 Jul '24

04 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56914 This is also needed by Adobe Premiere Pro 2024. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5992

3 11

[PATCH 0/7] MR5388: Draft: RFC: WGL_ARB_pixel_format logic in opengl32
by Alexandros Frantzis (＠afrantzis) 04 Jul '24

04 Jul '24

As mentioned in https://gitlab.winehq.org/wine/wine/-/merge_requests/5264, the next step for OpenGL in the Wayland driver is support for WGL_ARB_pixel_format. It seems possible, at least in theory, to move a large part of the logic involved in this extension outside the drivers for common use by all of them (or ones that want to opt-in). The goal of this RFC MR is, through experimentation and discussion/feedback, evaluate: 1. Whether making such functionality available outside the drivers (likely in an opt-in manner to begin with) is a productive way forward, or the complexity and platform specific decisions favor the current per-driver approach. 2. If we think that (1) is a worthy goal, what's the best mechanism to achieve it. Note that the focus of this MR is currently on being a proof-of-concept, rather providing ready-for-detailed-review code (although I have done my best to keep the code decent). This MR currently (roughly in commit order): * Introduces a new wgl driver callback to allow drivers to provide to opengl32/unix a list of formats and many details about them. * Uses the information in that list to implement wglGetPixelFormatAttrib*. * Uses the information in that list plus format sorting rules from WineX11 (effectively GLX rules plus tweaks) to implement wglChoosePixelFormatARB. * Implements the get_pixel_formats callback for the Wayland driver. * Hacks the get_pixel_formats callback for WineX11, and to allow me to run some experiments to compare the output of native WineX11 and get_pixel_formats-WineX11. In the admittedly not too many games I tried the sort order is the same, so at least that's encouraging. My thoughts and notes so far: * Using this approach for wglGetPixelFormatAttrib* works well, and we can also implement wglDescribePixelFormat in this way. * It's not at all clear what the "right" sorting rules are for wglChoosePixelFormatARB. * WineX11 uses GLX + tweaks (e.g., changes depth sorting). This means that larger formats tend to be preferred, at least according to the GLX spec. For example, asking for a r5, g6, b5 in the attributes is supposed to give back rgb888 (or even higher if available) as the top format in the list. Interestingly, and to confuse things even more, I haven't been able to make GLX return non-888(8) configs at all to actually test this more, so perhaps that's what saves it here? However, eglChooseConfig works similarly and there I was able to verify this behavior (e.g., got a nice surprise 10-bit format when asking for 5551 :)). * Winemac has its own custom logic. * Mesa's WGL implementation uses a different approach, closer to Wine's normal (wgl)ChoosePixelFormat, where proximity to the target format is strongly rewarded (so it seems asking for r5g6b5 is much more likely to actually get you that). * Of course, the "gold standard" here would be to try to infer and use the rules used by some windows driver. Looking forward to thoughts/feedback! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5388

3 14

[PATCH 0/6] MR5993: Cmd engine rewrite (part XV)
by eric pouech (＠epo) 04 Jul '24

04 Jul '24

This is part XV of cmd engine rewrite. This MR deals with returning the proper success/failure return code for POPD and RMDIR. However, these commands never set ERRORLEVEL (all the commands we've handled so far always set ERRORLEVEL in case of failure, and some reset ERRORLEVEL in case of successs). So this MR on top of returning the expected success/failure return code for these two commands, also: - extend tests to show that ERRORLEVEL isn't set - tweak internal call path to better handle return code vs ERRORLEVEL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5993

2 6

[PATCH 0/3] MR5990: mfreadwrite/reader: Fix seeking and playback loop when using decoders.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5990

2 4

[PATCH 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Elizabeth Figura (＠zfigura) 04 Jul '24

04 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988

3 4

[PATCH v3 0/10] MR5055: winegstreamer: Support input video frame padding and cropping.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

On the client side, frame aperture may be included or omitted. This can be used to include or drop the frame padding, and the VideoProcessor MFT supports it. On GStreamer side, we can only use the unpadded frame size in the caps, because this is how decoders work, and padding needs to be added as a property of the input/output video buffers. Then, frame size needs to be adjusted to be consistent between input and output, and any difference considered as extra padding to be added on one side or the other. -- v3: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Exclude padding from wg_format video frame size. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Update the output_format when stream format changes. winegstreamer: Pass optional GstVideoInfo to read_transform_output_data. winegstreamer: Split read_transform_output_data in two helpers. winegstreamer: Introduce a new sample_needs_copy_buffer helper. winegstreamer: Introduce a new sample_set_flags_from_buffer helper. mf/tests: Add more video processor tests with aperture. https://gitlab.winehq.org/wine/wine/-/merge_requests/5055

4 15

Re: [PATCH v2 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

Onimusha: Warlords doesn't even use H264 and has several other problems. None of these games need H264 to be explicitly exposed, they only need compressed output. This is also only making my work on upstreaming Proton changes more difficult and I don't really understand what you are trying to achieve here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988#note_75084

1 0

Re: [PATCH v2 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Chunhao Hung (＠otakuxtom) 04 Jul '24

04 Jul '24

After test on the actually game Rune Factory 5 it shown, and stock there. no audio. ``` 079c:fixme:process:SetProcessShutdownParameters (000003ff, 00000000): partial stub. 0604:fixme:mmdevapi:control_UnregisterAudioSessionNotification (00007FFFFF2DD810)->(0000488C0007D5A0) - stub (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed (wine:112100): GStreamer-CRITICAL **: 13:05:17.574: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed winegstreamer error: qtdemux0: Internal data stream error. winegstreamer error: qtdemux0: ../gst/isomp4/qtdemux.c(6749): gst_qtdemux_loop (): /GstBin:bin0/GstDecodeBin:decodebin0/GstQTDemux:qtdemux0: streaming stopped, reason not-linked (-1) (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed (wine:112100): GStreamer-CRITICAL **: 13:05:19.499: gst_query_set_uri: assertion 'gst_uri_is_valid (uri)' failed winegstreamer error: qtdemux1: Internal data stream error. winegstreamer error: qtdemux1: ../gst/isomp4/qtdemux.c(6749): gst_qtdemux_loop (): /GstBin:bin1/GstDecodeBin:decodebin1/GstQTDemux:qtdemux1: streaming stopped, reason not-linked (-1) ``` Without this patch, some of audio in video are normal, just no video is shown. here is log with +mfplat [stdout.xz](/uploads/db4cea226cffe3f8a582d3ac39539c39/stdout.xz) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988#note_75083

1 0

[PATCH 0/1] MR5980: mscoree: Pass size in bytes to RegGetValueW.
by Alex Henrie (＠alexhenrie) 04 Jul '24

04 Jul '24

Split from !5969 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5980

3 2

Re: [PATCH v12 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value. - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

1 0

Re: [PATCH v3 0/1] MR5977: wined3d: Invalidate the FFP VS when diffuse presence changes. - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5977

1 0

Re: [PATCH v2 0/2] MR5984: win32u: Use the desktop shared memory for is_virtual_desktop. - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5984

1 0

Re: [PATCH v3 0/6] MR5941: xcopy: Handle switch options concatenated with path. - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5941

1 0

[PATCH v6 0/7] MR5972: winegstreamer: Respect video format padding for wg_transform input buffers.
by Rémi Bernon (＠rbernon) 03 Jul '24

03 Jul '24

-- v6: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Normalize video processor and color converter apertures. winegstreamer: Normalize both input and output media types stride at once. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Keep the input caps on the transform. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Only use pool and set buffer meta for raw video frames. https://gitlab.winehq.org/wine/wine/-/merge_requests/5972

3 8

Re: [PATCH v2 0/1] MR5983: twinapi.appcore: Initialize size argument to RegGetValueW. - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5983

1 0

Re: [PATCH v2 0/1] MR5982: shell32: Pass size in bytes to RegGetValueW. - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5982

1 0

Re: [PATCH v3 0/1] MR5981: msi: Initialize size argument to RegGetValueW. - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5981

1 0

Re: [PATCH v2 0/5] MR5986: Cmd engine rewrite (part XIV) - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5986

1 0

Re: [PATCH v5 0/5] MR5971: winegstreamer/video_encoder: More of encoder implementation. - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5971

1 0

Re: [PATCH v2 0/3] MR5975: winhttp: Skip trailing spaces in reply headers. - approved
by Alexandre Julliard (＠julliard) 03 Jul '24

03 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5975

1 0

[PATCH v11 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) 03 Jul '24

03 Jul '24

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v11: winegstreamer: Set 'max_threads' to 4 for 32-bit processors. winegstreamer: Use thread_count to determine 'max-threads' value. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

3 5

[PATCH v10 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) 03 Jul '24

03 Jul '24

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v10: winegstreamer: Set 'max_threads' to 4 for 32-bit processors. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

3 7

[PATCH v9 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) 03 Jul '24

03 Jul '24

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v9: winegstreamer: Set MAX_THREADS to 4 for i386. winegstreamer: Use thread_count to determine 'max-threads' value. winegstreamer: Use process affinity to calculate thread_count. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

2 3

[PATCH v5 0/7] MR5972: winegstreamer: Respect video format padding for wg_transform input buffers.
by Rémi Bernon (＠rbernon) 03 Jul '24

03 Jul '24

-- v5: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Normalize video processor and color converter apertures. winegstreamer: Normalize both input and output media types stride at once. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Keep the input caps on the transform. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Only use pool and set buffer meta for raw video frames. https://gitlab.winehq.org/wine/wine/-/merge_requests/5972

3 9

[PATCH v8 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) 03 Jul '24

03 Jul '24

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v8: winegstreamer: Set MAX_THREADS to 4 for i386. winegstreamer: Use thread_count to determine 'max-threads' value. winegstreamer: Use process affinity to calculate thread_count. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

3 6

[PATCH 0/6] MR5985: server: Create a thread input shared object and use it for NtUserGetGUIThreadInfo.
by Rémi Bernon (＠rbernon) 03 Jul '24

03 Jul '24

Currently for the current thread, later for the foreground or any other thread. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5985

3 7

[PATCH 0/2] MR5984: win32u: Use the desktop shared memory for is_virtual_desktop.
by Rémi Bernon (＠rbernon) 03 Jul '24

03 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5984

3 6

[PATCH v2 0/6] MR5941: xcopy: Handle switch options concatenated with path.
by Piotr Caban (＠piotr) 03 Jul '24

03 Jul '24

-- v2: xcopy: Add support for parsing concatenated switches. xcopy: Handle switch options concatenated with path. xcopy: Introduce get_arg helper that duplicates first argument to new string. xcopy: Strip quotes only from source and destination arguments. xcopy: Exit on invalid command line argument. xcopy: Exit after displaying help message. https://gitlab.winehq.org/wine/wine/-/merge_requests/5941

2 7

[PATCH v2 0/1] MR5981: msi: Initialize size argument to RegGetValueW.
by Alex Henrie (＠alexhenrie) 03 Jul '24

03 Jul '24

Split from !5969 -- v2: msi: Initialize size argument to RegGetValueW. https://gitlab.winehq.org/wine/wine/-/merge_requests/5981

3 2

[PATCH v4 0/5] MR5971: winegstreamer/video_encoder: More of encoder implementation.
by Ziqing Hui (＠zhui) 03 Jul '24

03 Jul '24

-- v4: winegstreamer/video_encoder: Implement GetOutputStreamInfo. https://gitlab.winehq.org/wine/wine/-/merge_requests/5971

4 7

[PATCH v3 0/5] MR5971: winegstreamer/video_encoder: More of encoder implementation.
by Ziqing Hui (＠zhui) 03 Jul '24

03 Jul '24

-- v3: winegstreamer/video_encoder: Implement GetOutputStreamInfo. winegstreamer/video_encoder: Implement GetInputStreamInfo. winegstreamer/video_encoder: Check more attributes in SetInputType. winegstreamer/video_encoder: Introduce create_input_type. mf/tests: Add more tests for h264 encoder type attributes. https://gitlab.winehq.org/wine/wine/-/merge_requests/5971

4 7

[PATCH 0/3] MR5975: winhttp: Skip trailing spaces in reply headers.
by Paul Gofman (＠gofman) 03 Jul '24

03 Jul '24

Fixes Ball at Work: The Ultimate Speedrun Platformer! failing to start (which receives such non-standard headers from the servers). While testing this I found more weird aspects of handling invalid reply header names on Windows: - leading spaces are not skipped, but if the first character is a space then two more spaces added at start of header name and then all the other invalid characters in the name (like '@' or 0xfe) are ignored (otherwise without the space at name start the presence of such header fails request); then such a header saved by failing requests can't be queried with WinHttpQueryHeaders() as the presence of invalid characters (including space) fails that with ERROR_INVALID_PARAMETER; - trailing '\\t' are not skipped but also do not fail the request and the header with tab is present in raw headers. But I suppose we don't need to complicate things by replicating this behaviour precisely until anything depends on that. The specific game motivating the patch only receives spaces in the end of header name which are skipped on Windows while this behaviour has some obvious logic (even if doesn't follow http standard). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5975

4 5

[PATCH 0/5] MR5986: Cmd engine rewrite (part XIV)
by eric pouech (＠epo) 03 Jul '24

03 Jul '24

This is part XIV of cmd engine rewrite. It mainly tests and sets return code for a couple of directory related commands (CD, MKDIR/MD, PUSHD, DIR). It's on purpose that POPD isn't included in this MR: it will require (as RMDIR) some changes not directly related to command itself (more on next MR). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5986

3 6

[PATCH v2 0/5] MR5971: winegstreamer/video_encoder: More of encoder implementation.
by Ziqing Hui (＠zhui) 03 Jul '24

03 Jul '24

-- v2: winegstreamer/video_encoder: Implement GetOutputStreamInfo. winegstreamer/video_encoder: Implement GetInputStreamInfo. winegstreamer/video_encoder: Check more attributes in SetInputType. winegstreamer/video_encoder: Introduce create_input_type. mf/tests: Add more tests for h264 encoder type attributes. https://gitlab.winehq.org/wine/wine/-/merge_requests/5971

4 9

[PATCH 0/1] MR5981: msi: Initialize size argument to GetRegValueW.
by Alex Henrie (＠alexhenrie) 03 Jul '24

03 Jul '24

Split from !5969 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5981

3 2

[PATCH v5 0/6] MR5969: Draft: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 03 Jul '24

03 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v5: kernelbase: Ensure null termination in RegGetValue[AW]. windowscodecs: Use RegQueryValueExW in ComponentInfo_GetStringValue. twinapi.appcore: Initialize size argument to RegGetValueW. shell32: Pass size in bytes to RegGetValueW. msi: Initialize size argument to GetRegValueW. mscoree: Pass size in bytes to RegGetValueW. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 7

[PATCH 0/1] MR5983: twinapi.appcore: Initialize size argument to RegGetValueW.
by Alex Henrie (＠alexhenrie) 03 Jul '24

03 Jul '24

Split from !5969 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5983

2 1

[PATCH 0/1] MR5982: shell32: Pass size in bytes to RegGetValueW.
by Alex Henrie (＠alexhenrie) 03 Jul '24

03 Jul '24

Split from !5969 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5982

2 1

[PATCH v3 0/7] MR5972: winegstreamer: Respect video format padding for wg_transform input buffers.
by Rémi Bernon (＠rbernon) 03 Jul '24

03 Jul '24

-- v3: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Normalize the video processor media types apertures. winegstreamer: Normalize both input and output media types stride at once. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Keep the input caps on the transform. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Only use pool and set buffer meta for raw video frames. https://gitlab.winehq.org/wine/wine/-/merge_requests/5972

2 8

[PATCH 0/5] MR5971: winegstreamer/video_encoder: More of encoder implementation.
by Ziqing Hui (＠zhui) 03 Jul '24

03 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5971

4 11

[PATCH 0/1] MR5977: wined3d: Invalidate the FFP VS when diffuse presence changes.
by Elizabeth Figura (＠zfigura) 03 Jul '24

03 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5977

2 1

[PATCH v2 0/2] MR5976: Acquire filesystem labels from dbus
by Alfred Agrell (＠Alcaro) 03 Jul '24

03 Jul '24

-- v2: kernelbase: Silence 'read access denied' message if the device has a label, or if it's not expected to have one. mountmgr.sys: Read and use disk label from dbus. https://gitlab.winehq.org/wine/wine/-/merge_requests/5976

4 5

[PATCH 0/3] MR5976: Acquire filesystem labels from dbus
by Alfred Agrell (＠Alcaro) 02 Jul '24

02 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5976

4 9

Re: [PATCH v2 0/1] MR5974: ucrtbase: Store exception record in ExceptionInformation[6] during unwinding. - approved
by Alexandre Julliard (＠julliard) 02 Jul '24

02 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5974

1 0

Re: [PATCH v2 0/6] MR5973: Cmd engine rewrite (part XIII) - approved
by Alexandre Julliard (＠julliard) 02 Jul '24

02 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5973

1 0

Re: [PATCH v5 0/9] MR5876: winegstreamer: Implement more Media Foundation compressed format mappings. - approved
by Alexandre Julliard (＠julliard) 02 Jul '24

02 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5876

1 0

Re: [PATCH v3 0/4] MR5933: opengl32: Add default implementation for wglChoosePixelFormatARB. - approved
by Alexandre Julliard (＠julliard) 02 Jul '24

02 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5933

1 0

Re: [PATCH v3 0/3] MR5967: mlang: Return the correct interface in GetGlobalFontLinkObject. - approved
by Alexandre Julliard (＠julliard) 02 Jul '24

02 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5967

1 0

[PATCH v2 0/7] MR5972: winegstreamer: Respect video format padding for wg_transform input buffers.
by Rémi Bernon (＠rbernon) 02 Jul '24

02 Jul '24

-- v2: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Normalize video processor and color converter apertures. winegstreamer: Normalize both input and output media types stride at once. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Keep the input caps on the transform. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Only use pool and set buffer meta for raw video frames. https://gitlab.winehq.org/wine/wine/-/merge_requests/5972

3 12

[PATCH 0/5] MR5972: winegstreamer: Respect video format padding for wg_transform input buffers.
by Rémi Bernon (＠rbernon) 02 Jul '24

02 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5972

3 9

[PATCH 0/1] MR5974: ucrtbase: Store exception record in ExceptionInformation[6] during unwinding.
by Piotr Caban (＠piotr) 02 Jul '24

02 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5974

2 1

[PATCH v4 0/3] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 02 Jul '24

02 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v4: kernelbase: Ensure null termination in RegGetValue[AW]. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 4

[PATCH v3 0/3] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 02 Jul '24

02 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v3: kernelbase: Ensure null termination in RegGetValue[AW]. windowscodecs: Use RegQueryValueExW in ComponentInfo_GetStringValue. advapi32/tests: Drop security test workarounds for Windows <= 2000. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 4

[PATCH v2 0/8] MR5962: win32u: Implement common window surface shape logic with a 1bpp bitmap.
by Rémi Bernon (＠rbernon) 02 Jul '24

02 Jul '24

Used for winex11 and later will be used in winemac and winewayland. -- v2: win32u: Pass the shape bitmap info and bits to window_surface flush. win32u: Update the window surface shape with color key and alpha. win32u: Use a 1bpp bitmap to store the window surface shape bits. win32u: Introduce a new window surface helper to set window shape. win32u: Pass whether window is shaped to drivers WindowPosChanging. win32u: Pass the window surface rect for CreateLayeredWindow. win32u: Split a new create_window_surface helper from apply_window_pos. win32u: Move offscreen window surface creation fallback. https://gitlab.winehq.org/wine/wine/-/merge_requests/5962

2 10

[PATCH 0/6] MR5973: Cmd engine rewrite (part XIII)
by eric pouech (＠epo) 02 Jul '24

02 Jul '24

This is part XIII of the cmd engine rewrite. This serie provides tests and fixes for the success/failure return codes used in file related commands. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5973

3 7

Re: [PATCH v4 0/9] MR5876: winegstreamer: Implement more Media Foundation compressed format mappings. - approved
by Nikolay Sivov (＠nsivov) 02 Jul '24

02 Jul '24

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5876

1 0

[PATCH v5 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 02 Jul '24

02 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v5: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

4 4

[PATCH v4 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 02 Jul '24

02 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v4: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

2 2

[PATCH v3 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 02 Jul '24

02 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v3: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

4 6

Re: [PATCH v2 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 02 Jul '24

02 Jul '24

count is never 0 as WCMD_ReadFile output is not null terminated. Added few tests as of now, thinking about more. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5968#note_74896

1 0

[PATCH v2 0/4] MR5933: opengl32: Add default implementation for wglChoosePixelFormatARB.
by Alexandros Frantzis (＠afrantzis) 02 Jul '24

02 Jul '24

This MR adds a default implementation for `wglChoosePixelFormatARB` (in opengl32.dll) which will be used automatically if the driver populates the wgl_pixel_format ARB fields. Thus winex11 automatically uses this, and this MR removes the driver internal implementation. The second part of this MR adds `WGL_ARB_pixel_format` support for winewayland (we can move this to a separate MR, but I wanted to have another implementation to better assess the behavior). The `wglChoosePixelFormatARB` behavior is loosely modeled after the the AMD driver as discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5388. I tried to keep things simple to begin with, and the results I am getting in various apps/games are sensible, but please try this out so we can refine further. -- v2: winewayland: Support WGL_ARB_pixel_format_float. winewayland: Support WGL_ARB_pixel_format. winex11: Remove driver wglChoosePixelFormatARB implementation. opengl32: Add default implementation for wglChoosePixelFormatARB. https://gitlab.winehq.org/wine/wine/-/merge_requests/5933

4 11

[PATCH v2 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 02 Jul '24

02 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- v2: kernelbase: Ensure null termination in RegGetValue[AW]. windowscodecs: Use RegQueryValueExW in ComponentInfo_GetStringValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 3

Re: [PATCH v2 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by eric pouech (＠epo) 02 Jul '24

02 Jul '24

it seems to me this can be tested with: set /p "myenv=prompt> " < NUL -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5968#note_74869

1 0

[PATCH 0/1] MR5969: kernelbase: Ensure null termination in RegGetValue[AW].
by Alex Henrie (＠alexhenrie) 02 Jul '24

02 Jul '24

I was hoping that the new tests would provide evidence that RtlQueryRegistryValues uses RegGetValue to ensure that multi-strings are double-null-terminated. Instead the tests suggest that my hypothesis was wrong because RegGetValue only ensures single null termination, not double null termination. We should fix RegGetValue anyway for the sake of applications that expect it to null-terminate. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

3 2

[PATCH 0/2] MR4601: winegstreamer: Order output pins based on MPEG system header.
by Anton Baskanov (＠baskanov) 02 Jul '24

02 Jul '24

Fixes in-game video playback in Earth 2150. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4601

5 10

[PATCH 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 01 Jul '24

01 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

3 2

Re: [PATCH v5 0/7] MR5907: ntdll: Optimize NtQueryVirtualMemory(MemoryWorkingSetExInformation). - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5907

1 0

Re: [PATCH v2 0/1] MR5951: ntdll: Report the space completely outside of reserved areas as allocated on i386. - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5951

1 0

Re: [PATCH v2 0/1] MR5961: cmd: Close file opened with popen with correct function (coverity) - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5961

1 0

2025

2024

2023

2022

wine-gitlab