- wine-gitlab - winehq.org

Re: [PATCH v2 0/3] MR5955: winegstreamer/video_encoder: Implement input type functions. - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5955

1 0

Re: [PATCH v4 0/3] MR5805: winegstreamer: Create transforms from MFVIDEOFORMAT / WAVEFORMATEX. - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5805

1 0

Re: [PATCH v2 0/1] MR5963: mf/session: Implement D3D device manager propagation. - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5963

1 0

Re: [PATCH v2 0/1] MR5964: mf/session: Don't update transform output type if not needed. - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5964

1 0

Re: [PATCH v2 0/6] MR5940: server, win32u: Use the message queue shared memory to read the queue status. - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5940

1 0

Re: [PATCH v2 0/1] MR5956: netapi32: add NetGetAadJoinInformation stub - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5956

1 0

Re: [PATCH v2 0/3] MR5953: include: Add symbols for DirectXShaderCompiler project - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5953

1 0

Re: [PATCH v2 0/4] MR5908: misc: Use the correct interface for some COM calls. - approved
by Alexandre Julliard (＠julliard) 01 Jul '24

01 Jul '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5908

1 0

[PATCH v2 0/3] MR5967: mlang: Return the correct interface in GetGlobalFontLinkObject.
by Fabian Maurer (＠DarkShadow44) 01 Jul '24

01 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56600 -- v2: mlang: Return the correct interface in GetGlobalFontLinkObject. https://gitlab.winehq.org/wine/wine/-/merge_requests/5967

3 5

[PATCH 0/3] MR5967: mlang: Return the correct interface in GetGlobalFontLinkObject.
by Fabian Maurer (＠DarkShadow44) 01 Jul '24

01 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56600 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5967

3 4

[PATCH 0/3] MR5955: winegstreamer/video_encoder: Implement input type functions.
by Ziqing Hui (＠zhui) 01 Jul '24

01 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5955

4 5

[PATCH 0/8] MR5962: win32u: Implement common window surface shape logic with a 1bpp bitmap.
by Rémi Bernon (＠rbernon) 01 Jul '24

01 Jul '24

Used for winex11 and later will be used in winemac and winewayland. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5962

2 9

[PATCH 0/1] MR5966: pdh: Add PdhGetFormattedCounterArray(A/W) stub.
by Vijay Kiran Kamuju (＠infyquest) 01 Jul '24

01 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56580 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5966

3 2

[PATCH 0/6] MR5940: server, win32u: Use the message queue shared memory to read the queue status.
by Rémi Bernon (＠rbernon) 01 Jul '24

01 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5940

3 9

[PATCH 0/1] MR5963: mf/session: Implement D3D device manager propagation.
by Rémi Bernon (＠rbernon) 01 Jul '24

01 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5963

3 4

[PATCH v3 0/3] MR5805: winegstreamer: Create transforms from MFVIDEOFORMAT / WAVEFORMATEX.
by Rémi Bernon (＠rbernon) 01 Jul '24

01 Jul '24

Instead of going through a custom intermediate format. -- v3: winegstreamer: Create transforms from MFVIDEOFORMAT / WAVEFORMATEX. winegstreamer: Translate MFVIDEOFORMAT / WAVEFORMATEX directly to GstCaps in wg_transform. winegstreamer: Translate GstCaps directly to MFVIDEOFORMAT / WAVEFORMATEX in wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/5805

2 3

[PATCH 0/3] MR5952: Draft: tools: Some GitLab CI changes.
by Aida Jonikienė (＠DodoGTA) 01 Jul '24

01 Jul '24

I have a question for Julliard before doing additional work: 1. Why do only MR test jobs have the extra-quiet winetest option enabled? I think it exposes test flakiness (which could be insightful in normal Wine jobs too) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5952

3 5

[PATCH 0/1] MR5964: mf/session: Don't update transform output type if not needed.
by Rémi Bernon (＠rbernon) 01 Jul '24

01 Jul '24

This avoids changing pipeline media types when not needed, similarly to what the source reader does. We otherwise create unnecessary spurious format changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5964

3 2

[PATCH 0/39] MR5615: Draft: winegstreamer: Convert media type to GstCaps directly instead of through an internal representation.
by Rémi Bernon (＠rbernon) 01 Jul '24

01 Jul '24

This saves ~1500 LoC, and at the same time allows mapping arbitrary long codec data back and forth GstCaps, which will be required to support arbitrary compressed formats. We can then for instance expose unknown codecs as Wine-specific subtypes, expose generic decoders and pass the backend GstCaps serialized in the codec data. It makes the code simpler by unifying all frontend mappings and only requiring mapping between GstCaps and a unified set of formats. Mapping between IMFMediaType and the AM_MEDIA_TYPE formats is done using the standard MF functions and are tested and validated in mfplat tests. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/5615

3 7

[PATCH v2 0/3] MR5805: winegstreamer: Create transforms from MFVIDEOFORMAT / WAVEFORMATEX.
by Rémi Bernon (＠rbernon) 01 Jul '24

01 Jul '24

Instead of going through a custom intermediate format. -- v2: winegstreamer: Create transforms from MFVIDEOFORMAT / WAVEFORMATEX. winegstreamer: Translate MFVIDEOFORMAT / WAVEFORMATEX directly to GstCaps in wg_transform. winegstreamer: Translate GstCaps directly to MFVIDEOFORMAT / WAVEFORMATEX in wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/5805

2 4

[PATCH v2 0/1] MR5013: msi: Properly select first feature
by Fabian Maurer (＠DarkShadow44) 30 Jun '24

30 Jun '24

We need to select the first feature when all controls are created, otherwise they are not properly updated Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56290 -- v2: msi: Properly select first feature https://gitlab.winehq.org/wine/wine/-/merge_requests/5013

3 4

[PATCH v4 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) 30 Jun '24

30 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v4: user32: Send parent BN_CLICKED notification when a radio button get focused comctl32: Send parent BN_CLICKED notification when a radio button get focused user32/tests: Add tests for radio button WM_SETFOCUS comctl32/tests: Add tests for radio button WM_SETFOCUS https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

3 6

[PATCH 0/1] MR5961: cmd: Close file opened with popen with correct function (coverity)
by Fabian Maurer (＠DarkShadow44) 30 Jun '24

30 Jun '24

Not 100% sure about this, maybe there is a reason it's done like that, but it looks like an oversight. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5961

2 1

[PATCH v34 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 30 Jun '24

30 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v34: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH v33 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 30 Jun '24

30 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v33: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH v32 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 30 Jun '24

30 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v32: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH 0/1] MR5957: win32u: fix random crash without libfreetype
by Fan WenJie (＠fanwenjie) 30 Jun '24

30 Jun '24

without freetype, some calling return failed, so some value may not be initialized (it initialize by some failed calling and pass argument by point of it), it would cause random crash! Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5957

2 1

[PATCH v7 0/1] MR5854: win32u: get_char_dimensions set height to 1 when failed
by Fan WenJie (＠fanwenjie) 30 Jun '24

30 Jun '24

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> when get_char_dimensions failed, width not set, width may be undefined value and cause undefined behaviour -- v7: win32u: fix random crash without libfreetype https://gitlab.winehq.org/wine/wine/-/merge_requests/5854

2 2

Re: [PATCH v2 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present.
by Vijay Kiran Kamuju (＠infyquest) 29 Jun '24

29 Jun '24

On Sat Jun 29 20:07:51 2024 +0000, Loïc Rebmeister wrote: > @infyquest I'm happy you tried to make a fix, I'm happy you have > interest in wine. > > I dont need you to teach me code, Please don't make it personal. > This ain't personal, if someone want to make a fix, they need at least > to understand the code they send, this is the same with everyone. > I know you wanted to do good, but this doesn't change what this code > effectively does. I am contributing to wine for more than 10 years. I admit that I might be wrong in understanding the code. Please try to communicate and present in a decent way as it will rub the people in a wrong way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771#note_74757

1 0

Re: [PATCH v2 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present.
by Loïc Rebmeister (＠Fox2Code) 29 Jun '24

29 Jun '24

@infyquest I'm happy you tried to make a fix, I'm happy you have interest in wine. > I dont need you to teach me code, Please don't make it personal. This ain't personal, if someone want to make a fix, they need at least to understand the code they send, this is the same with everyone. I know you wanted to do good, but this doesn't change what this code effectively does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771#note_74756

1 0

[PATCH v5 0/1] MR4418: cmd: Delay variable substitution until after the if clause is parsed.
by Alex Henrie (＠alexhenrie) 29 Jun '24

29 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55859 -- v5: cmd: Delay variable substitution until after the if clause is parsed. https://gitlab.winehq.org/wine/wine/-/merge_requests/4418

3 4

[PATCH 0/1] MR5956: netapi32: add NetGetAadJoinInformation stub
by Austin English (＠austin987) 29 Jun '24

29 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56617 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5956

3 2

Re: [PATCH v2 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present. - closed
by Vijay Kiran Kamuju (＠infyquest) 29 Jun '24

29 Jun '24

This merge request was closed by Vijay Kiran Kamuju. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771

1 0

Re: [PATCH v2 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present.
by Vijay Kiran Kamuju (＠infyquest) 29 Jun '24

29 Jun '24

I am closing this merge request and wait for the coding teacher to get with a fix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771#note_74752

1 0

Re: [PATCH v2 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present.
by Vijay Kiran Kamuju (＠infyquest) 29 Jun '24

29 Jun '24

Please upload the code to the bug and test it. This was an attempt to fix the bug based on observations. There can be issues, with the code. I dont need you to teach me code, Please don't make it personal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771#note_74751

1 0

Re: [PATCH v2 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present.
by Loïc Rebmeister (＠Fox2Code) 29 Jun '24

29 Jun '24

Your pull request effectively make the code worse, as `{ L"Windows.Foundation.UniversalApiContract", 10, },` means `10` or lower. So `{ L"Windows.Foundation.UniversalApiContract", 7, },` was already included by `{ L"Windows.Foundation.UniversalApiContract", 10, },` But due to how `is_api_contract_present` work, it only take the first element with a name into consideration. This is a simplified pseudo code with comments of `is_api_contract_present` to show the loop stop at first name match: ```java boolean is_api_contract_present(String name,int version) { for (present_contract : present_contracts) // List though all entries if (present_contract.name == name)) // Check is name is equal return version <= present_contract.max_major; // Check if version is lower than max_major, and return return false; // No match found, return that we didn't found anything } ``` Note: the `return` keyword stop code execution, and return the value. (I'm assuming you didn't understood the code you sent there, as I'm pretty sure if you understood that code before sending it you wouldn't have opened this MR) Further more, `Windows.Foundation.UniversalApiContract` is a dotnet 5 feature. (Source: https://github.com/madewokherd/wine-mono/issues/151#issuecomment-1232824011) Wine (and Wine-mono) currently only support up to dotnet 4 on a clean install. If you want I can teach you code for free so you can actually read and understand the code before you are sending it to wine upstream. In the meantime I'll see what I can do to try to get the issue fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771#note_74750

1 0

[PATCH 0/3] MR5953: include: Add symbols for DirectXShaderCompiler project
by Biswapriyo Nath (＠Biswa96) 29 Jun '24

29 Jun '24

Required for https://github.com/microsoft/DirectXShaderCompiler.git -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5953

3 5

[PATCH v9 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 29 Jun '24

29 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v9: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

4 11

[PATCH 0/4] MR5908: misc: Use the correct interface for some COM calls.
by Elizabeth Figura (＠zfigura) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5908

5 9

Re: [PATCH v2 0/3] MR5950: msado15 command properties implementation. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5950

1 0

Re: [PATCH v3 0/9] MR5947: win32u: Factor layered surface attributes out of the drivers. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5947

1 0

Re: [PATCH v2 0/5] MR5949: Cmd engine rewrite (part XII) - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5949

1 0

Re: [PATCH v2 0/6] MR5948: jscript: Always free jsdisp_t in jsdisp_free. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5948

1 0

Re: [PATCH v3 0/6] MR5931: winegstreamer: Implement output type functions. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5931

1 0

Re: [PATCH v4 0/1] MR5816: wined3d: Implement wined3d_check_device_format_conversion(). - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5816

1 0

Re: [PATCH v2 0/1] MR5945: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 28 Jun '24

28 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5945

1 0

[PATCH 0/1] MR5951: ntdll: Report the space completely outside of reserved areas as allocated on i386.
by Paul Gofman (＠gofman) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5951

2 2

[PATCH v31 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 28 Jun '24

28 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v31: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH 0/8] MR5881: d3dx9: Use shared code for loading volumes/volume textures from files.
by Connor McAdams (＠cmcadams) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5881

4 15

[PATCH v30 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 28 Jun '24

28 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v30: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH v29 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 28 Jun '24

28 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v29: psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH 0/3] MR5950: msado15 command properties implementation.
by Alistair Leslie-Hughes (＠alesliehughes) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5950

2 3

[PATCH v2 0/9] MR5947: win32u: Factor layered surface attributes out of the drivers.
by Rémi Bernon (＠rbernon) 28 Jun '24

28 Jun '24

-- v2: winex11: Remove now unnecessary window surface BITMAPINFO. winewayland: Remove now unnecessary window surface BITMAPINFO. wineandroid: Remove now unnecessary window surface BITMAPINFO. winemac: Remove now unnecessary driver surface BITMAPINFO. win32u: Get rid of the unnecessary offscreen window surface struct. win32u: Introduce a new helper to get surface color info and bits. win32u: Pass BITMAPINFO and color bits to window surface flush. win32u: Introduce a new helper to update layered window surface attributes. win32u: Move layered surface attributes to the window_surface struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/5947

3 11

[PATCH 0/5] MR5949: Cmd engine rewrite (part XII)
by eric pouech (＠epo) 28 Jun '24

28 Jun '24

This part XII of cmd engine rewrite. This serie implements proper support for && and || command chaining operators: - implement proper precedence parsing - implement semantics for the operators - for this to work, we need to have expected success/failure from commands; this is supported here for external commands (and calling into a label or another BAT/CMD file), but support has to be added for all builtin commands - that's a big mess as behaviors is far from homogeneous among the builtins: + some builtin set coherent success/failure vs errorlevel information + some report success/failure, but only set errorlevel upon failure (keeping errorlevel from previous commands untouched), + some even report success (even in case of failure) yet set errorlevel in case of failure, - so the next series will now concentrate on testing success/failure and errorlevel for every builtin command (sigh) - for now, to help the transition phase, we can distinguish if a builtin properly reports success/failure; if a builtin with success/failure ability is used in a chaining operator, we implement the intented behavior of the chaining operator; otherwise, we keep old behavior (ie always execute LHS and RHS whatever the success/failure status). This shall be removed when all builtin commands report success/failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5949

2 5

[PATCH 0/6] MR5948: jscript: Always free jsdisp_t in jsdisp_free.
by Jacek Caban (＠jacek) 28 Jun '24

28 Jun '24

Instead of class-specific destructors. Also some other minor clean up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5948

2 6

[PATCH v2 0/6] MR5931: winegstreamer: Implement output type functions.
by Ziqing Hui (＠zhui) 28 Jun '24

28 Jun '24

-- v2: winegstreamer/video_encoder: Implement GetOutputCurrentType. winegstreamer/video_encoder: Implement SetOutputType. https://gitlab.winehq.org/wine/wine/-/merge_requests/5931

3 8

[PATCH 0/9] MR5947: win32u: Factor layered surface attributes out of the drivers.
by Rémi Bernon (＠rbernon) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5947

2 9

[PATCH v3 0/1] MR5816: wined3d: Implement wined3d_check_device_format_conversion().
by Elizabeth Figura (＠zfigura) 28 Jun '24

28 Jun '24

This should reflect what we actually support, while still being a superset of what native drivers actually support. Native driver support varies, but, as the comments document, native drivers (at least as of windows 10) support only RGB -> RGB, YUV -> RGB, and BC -> RGB conversions. The actual formats supported are a more limited subset than exposed (despite that the video cards should be perfectly capable of supporting more conversions) but erring on the side of overreporting seems safer. -- v3: wined3d: Implement wined3d_check_device_format_conversion(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5816

3 2

[PATCH 0/6] MR5931: winegstreamer: Implement output type functions.
by Ziqing Hui (＠zhui) 28 Jun '24

28 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5931

4 14

[PATCH 0/5] MR5946: Feed FFP shader constants through push constant buffers, part 2.
by Elizabeth Figura (＠zfigura) 27 Jun '24

27 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5946

3 6

[PATCH v8 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 27 Jun '24

27 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v8: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 5

[PATCH 0/1] MR5945: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 27 Jun '24

27 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5945

2 1

Re: [PATCH v2 0/1] MR5944: wpcap: Handle different layout of the native packet header structure on 32-bit. - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5944

1 0

Re: [PATCH v2 0/2] MR5943: jscript: Fix PROP_DELETED handling in delete_prop. - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5943

1 0

Re: [PATCH v2 0/1] MR5892: wined3d: Recheck whether a query is active after wined3d_context_vk_get_command_buffer(). - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5892

1 0

Re: [PATCH v3 0/2] MR5872: ddraw: Preserve d3d device state in ddraw_surface_create(). - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5872

1 0

Re: [PATCH v2 0/3] MR5942: Cmd engine rewrite (part XI) - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5942

1 0

Re: [PATCH v3 0/6] MR5926: ntdll: Always fill the 32-bit IOSB when performing I/O on overlapped handles. - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5926

1 0

Re: [PATCH v5 0/5] MR5818: d3d11/tests: Other tests for NV12 textures. - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5818

1 0

Re: [PATCH v2 0/6] MR5815: wined3d: Feed FFP shader constants through push constant buffers, part 1. - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5815

1 0

Re: [PATCH v4 0/1] MR5351: wined3d: Compile the clear compute shaders with D3DCompile(). - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5351

1 0

Re: [PATCH v2 0/7] MR5930: win32u: Factor surface rect computation out of the drivers. - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5930

1 0

Re: [PATCH v2 0/1] MR5939: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 27 Jun '24

27 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5939

1 0

[PATCH v2 0/2] MR5937: Fix hotpatch prologue in GetProcAddress().
by Paul Gofman (＠gofman) 27 Jun '24

27 Jun '24

-- v2: kernelbase: Remove 0x48 prologue from GetProcAddress() on x64. kernel32: Remove 0x48 prologue from GetProcAddress() on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/5937

2 5

[PATCH 0/1] MR5944: wpcap: Handle different layout of the native packet header structure on 32-bit.
by Hans Leidekker (＠hans) 27 Jun '24

27 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56871 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5944

3 2

[PATCH v2 0/1] MR5816: wined3d: Implement wined3d_check_device_format_conversion().
by Elizabeth Figura (＠zfigura) 27 Jun '24

27 Jun '24

This should reflect what we actually support, while still being a superset of what native drivers actually support. Native driver support varies, but, as the comments document, native drivers (at least as of windows 10) support only RGB -> RGB, YUV -> RGB, and BC -> RGB conversions. The actual formats supported are a more limited subset than exposed (despite that the video cards should be perfectly capable of supporting more conversions) but erring on the side of overreporting seems safer. -- v2: wined3d: Implement wined3d_check_device_format_conversion(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5816

4 4

[PATCH 0/4] MR5933: opengl32: Add default implementation for wglChoosePixelFormatARB.
by Alexandros Frantzis (＠afrantzis) 27 Jun '24

27 Jun '24

This MR adds a default implementation for `wglChoosePixelFormatARB` (in opengl32.dll) which will be used automatically if the driver populates the wgl_pixel_format ARB fields. Thus winex11 automatically uses this, and this MR removes the driver internal implementation. The second part of this MR adds `WGL_ARB_pixel_format` support for winewayland (we can move this to a separate MR, but I wanted to have another implementation to better assess the behavior). The `wglChoosePixelFormatARB` behavior is loosely modeled after the the AMD driver as discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5388. I tried to keep things simple to begin with, and the results I am getting in various apps/games are sensible, but please try this out so we can refine further. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5933

4 10

[PATCH 0/1] MR5892: wined3d: Recheck whether a query is active after wined3d_context_vk_get_command_buffer().
by Elizabeth Figura (＠zfigura) 27 Jun '24

27 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5892

3 2

[PATCH v2 0/2] MR5872: ddraw: Preserve d3d device state in ddraw_surface_create().
by Paul Gofman (＠gofman) 27 Jun '24

27 Jun '24

-- v2: ddraw: Preserve d3d device state in ddraw_surface_create(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5872

4 6

[PATCH 0/2] MR5943: jscript: Fix PROP_DELETED handling in delete_prop.
by Jacek Caban (＠jacek) 27 Jun '24

27 Jun '24

Also use designated initializers for builtin_info_t in preparation for further refactoring. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5943

2 2

[PATCH 0/3] MR5942: Cmd engine rewrite (part XI)
by eric pouech (＠epo) 27 Jun '24

27 Jun '24

This is part XI of cmd engine rewrite. This serie moves the IF and FOR instruction into the new CMD_NODE structure. I'm fully aware it's a large change (commit #1). It touches simultaneously at several components: - lexer is no longer trying to handle nested instructions; this is now handled over to parser which will take care of it in a recursive fashion - moving the IF and FOR instructions into CMD_NODE; this impacts the parser and the execution part These three parts are so tightly linked that I can't figure out a simple way to split first commit in smaller bits. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5942

2 3

[PATCH v4 0/5] MR5818: d3d11/tests: Other tests for NV12 textures.
by Giovanni Mascellani (＠giomasce) 27 Jun '24

27 Jun '24

-- v4: d3d11/tests: Test UpdateSubresource() for NV12 textures. d3d11/tests: Test NV12 textures without render target. d3d11/tests: Do not check pitches. d3d11/tests: Check for NV12 texture support before testing them. d3d11/tests: Check the result of compiling HLSL shaders. https://gitlab.winehq.org/wine/wine/-/merge_requests/5818

4 8

[PATCH 0/6] MR5815: wined3d: Feed FFP shader constants through push constant buffers, part 1.
by Elizabeth Figura (＠zfigura) 27 Jun '24

27 Jun '24

This is another step towards getting render states out of wined3d_state. The idea here is similar to the "push constant buffers" used for d3d8/9 flat constants, and reuses the same infrastructure. That is, we pack all of the constants directly into a wined3d_buffer which is bound directly to the wined3d_state as a normal constant buffer. For SPIR-V this buffer is placed in the GPU, and the shader can simply access it directly, with no renderer-specific changes needed other than to determine the buffer's location. Currently this buffer is still stored on the CPU for GLSL, and the contents are pulled back from the sysmem resource pointer, instead of being pulled from state->render_states. Eventually, at least for Vulkan, the idea will be to write a FFP replacement shader which takes structured data (which, given the constraints of SPIR-V, is broadly necessary; we cannot simply upload individual named uniforms as we can with GLSL). In fact this will take the form of an HLSL shader compiled to Shader Model 2 bytecode. This allows us to, once again, reuse pretty much all of the existing infrastructure and avoid writing more backend-specific code, and has the effect that this FFP replacement works not only with SPIR-V but also with GLSL, allowing us to eventually remove the existing GLSL FFP pipeline, and enabling me to develop the HLSL FFP pipeline mainly using the GL renderer [which is useful since the Vulkan renderer is still missing a few other features]. The full branch is available at [1], and passes all tests when using the GL renderer. [1] https://gitlab.winehq.org/zfigura/wine/-/tree/himavant8 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5815

3 7

[PATCH 0/1] MR5367: gitlab: Add gdb to the docker images.
by Rémi Bernon (＠rbernon) 27 Jun '24

27 Jun '24

I'm currently, very unsuccessfully, tracking down a crash on the unix side that only happens on Gitlab, and although I'm still unable to reproduce it, it then would be useful to have gdb to attach on segfault when I will. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5367

3 4

[PATCH v3 0/1] MR5351: wined3d: Compile the clear compute shaders with D3DCompile().
by Giovanni Mascellani (＠giomasce) 27 Jun '24

27 Jun '24

-- v3: wined3d: Compile the clear compute shaders at runtime. https://gitlab.winehq.org/wine/wine/-/merge_requests/5351

4 3

[PATCH v6 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) 27 Jun '24

27 Jun '24

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v6: winegstreamer: Set MAX_THREADS to 4 for i386. winegstreamer: Use thread_count to determine 'max-threads' value. winegstreamer: Use process affinity to calculate thread_count. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

3 5

[PATCH 0/1] MR5941: xcopy: Handle switch options concatenated with path.
by Piotr Caban (＠piotr) 27 Jun '24

27 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5941

2 1

[PATCH 0/7] MR5930: win32u: Factor surface rect computation out of the drivers.
by Rémi Bernon (＠rbernon) 27 Jun '24

27 Jun '24

This clips surface rects which are larger than the virtual screen, keeping full window surfaces for one which are smaller. This makes sure that off-screen windows have valid pixels on overviews like macOS Exposé, or similarly, GNOME shell activities view. Supersedes both https://gitlab.winehq.org/wine/wine/-/merge_requests/5865 and https://gitlab.winehq.org/wine/wine/-/merge_requests/5878. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5930

3 8

Re: [PATCH v5 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Rémi Bernon (＠rbernon) 27 Jun '24

27 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.c: > return true; > } > > +static ULONG popcount( ULONG val ) > +{ > +#if defined(__MINGW32__) > + return __builtin_popcount( val ); > +#else > + val -= val >> 1 & 0x55555555; > + val = (val & 0x33333333) + (val >> 2 & 0x33333333); > + return ((val + (val >> 4)) & 0x0f0f0f0f) * 0x01010101 >> 24; > +#endif > +} > + Well, now the __builtin_popcount path is never taken, because on the unix side it's not built with MinGW. There's a compiler check available already though. (Also mind the style change to match winegstreamer) ```suggestion:-10+0 static ULONG popcount(ULONG val) { #if HAVE___BUILTIN_POPCOUNT return __builtin_popcount(val); #else val -= val >> 1 & 0x55555555; val = (val & 0x33333333) + (val >> 2 & 0x33333333); return ((val + (val >> 4)) & 0x0f0f0f0f) * 0x01010101 >> 24; #endif } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5923#note_74516

1 0

Re: [PATCH v5 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Rémi Bernon (＠rbernon) 27 Jun '24

27 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.c: > return STATUS_UNSUCCESSFUL; > } > > + if (SUCCEEDED(NtQueryInformationProcess( GetCurrentProcess(), > + ProcessAffinityMask, &process_mask, sizeof(process_mask), NULL ))) > + thread_count = popcount(process_mask); > + else > + thread_count = 0; ```suggestion:-4+0 if (!NtQueryInformationProcess(GetCurrentProcess(), ProcessAffinityMask, &process_mask, sizeof(process_mask), NULL))) thread_count = popcount(process_mask); else thread_count = 0; ``` SUCCEEDED is for HRESULT, Nt API returns NTSTATUS and we often just check that it's 0. Also note the style fixes (no space in paren here, continuation indent is 8 spaces). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5923#note_74517

1 0

[PATCH 0/1] MR5939: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 27 Jun '24

27 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5939

2 1

Re: [PATCH v5 0/6] MR5870: mmdevapi: Implement loopback capture with winepulse backend.
by Davide Beatrici (＠davidebeatrici) 27 Jun '24

27 Jun '24

On Thu Jun 27 01:41:40 2024 +0000, Davide Beatrici wrote: > Agreed. We may eventually want to make use of something like [clang-format](https://clang.llvm.org/docs/ClangFormat.html). https://gitlab.winehq.org/wine/wine/-/merge_requests/5938 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5870#note_74514

1 0

[PATCH 0/1] MR5938: Draft: Add clang-format configuration file
by Davide Beatrici (＠davidebeatrici) 27 Jun '24

27 Jun '24

I tried to follow https://wiki.winehq.org/Wine_Developer%27s_Guide/Coding_Practice as closely as possible. Known issues: - No break before brace for assignments. Upstream issue: https://github.com/llvm/llvm-project/issues/79054 - `ContinuationIndentWidth` affects everything. Instead, we want it to be 8 for function arguments and 4 for assignments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5938

2 1

Re: [PATCH v3 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Zhiyi Zhang (＠zhiyi) 27 Jun '24

27 Jun '24

> It fails on asserting return value of sending LVM_GETNEXTITEM message In that case, please also add a test checking the same thing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_74512

1 0

[PATCH v7 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 27 Jun '24

27 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v7: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

4 5

[PATCH 0/2] MR5937: Fix hotpatch prologue in GetProcAddress().
by Paul Gofman (＠gofman) 26 Jun '24

26 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5937

3 3

[PATCH v3 0/3] MR5923: winegstreamer: Use affinity to determine 'max-threads' value.
by Brendan McGrath (＠redmcg) 26 Jun '24

26 Jun '24

GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the Steam Deck, this is configured to be 16 (which is double its number of logical cores). _SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it can create more threads than is useful, which ultimately wastes memory resources. Using affinity to set 'max-threads' addresses both these problems. -- v3: winegstreamer: Set MAX_THREADS to 4 for i386. winegstreamer: Use thread_count to determine 'max-threads' value. winegstreamer: Use process affinity to calculate thread_count. https://gitlab.winehq.org/wine/wine/-/merge_requests/5923

2 8

Re: [PATCH v2 0/1] MR5936: mscoree: Update Wine Mono to 9.2.0. - approved
by Alexandre Julliard (＠julliard) 26 Jun '24

26 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5936

1 0

Re: [PATCH v4 0/7] MR5912: win32u: Create a shared memory object for message queue and read active hooks bitmap from it. - approved
by Alexandre Julliard (＠julliard) 26 Jun '24

26 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5912

1 0

Re: [PATCH v2 0/5] MR5932: Cmd engine rewrite (part X) - approved
by Alexandre Julliard (＠julliard) 26 Jun '24

26 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5932

1 0

2025

2024

2023

2022

wine-gitlab