- wine-gitlab - winehq.org

[PATCH 0/2] MR5819: win32u: Fix DPI conversions in process_mouse_message.
by Rémi Bernon (＠rbernon) 10 Jun '24

10 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5819

2 4

[PATCH v41 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 10 Jun '24

10 Jun '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v41: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open the desktop shared object in NtUserSetThreadDesktop. server: Return the desktop object locator in (get|set)… [View More]

3 10

[PATCH 0/1] MR5817: oledb32: Support Multiple values when parsing the property Mode.
by Alistair Leslie-Hughes (＠alesliehughes) 10 Jun '24

10 Jun '24

The "Mode" can be a mix of any of the flags. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5817

3 2

[PATCH v2 0/2] MR5812: odbccp32: SQLWritePrivateProfileStringW check for existing DSN first
by Alistair Leslie-Hughes (＠alesliehughes) 09 Jun '24

09 Jun '24

If a DSN is System wide, we need to write to the HKEY_LOCAL_MACHINE part of the registry not HKEY_CURRENT_USER which it's currently doing. -- v2: odbccp32: SQLWritePrivateProfileStringW check for existing DSN first odbccp32: Support System wide ODBC DSN keys https://gitlab.winehq.org/wine/wine/-/merge_requests/5812

2 3

[PATCH 0/1] MR5816: wined3d: Implement wined3d_check_device_format_conversion().
by Elizabeth Figura (＠zfigura) 09 Jun '24

09 Jun '24

This should reflect what we actually support, while still being a superset of what native drivers actually support. Native driver support varies, but, as the comments document, native drivers (at least as of windows 10) support only RGB -> RGB, YUV -> RGB, and BC -> RGB conversions. The actual formats supported are a more limited subset than exposed (despite that the video cards should be perfectly capable of supporting more conversions) but erring on the side of overreporting seems … [View More]

3 2

[PATCH 0/1] MR5813: win32u: Implement EVENT_OBJECT_LOCATIONCHANGE.
by Esme Povirk (＠madewokherd) 08 Jun '24

08 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5813

3 2

[PATCH 0/1] MR5811: user32/tests: Print regions in test_swp_paint_regions failure cases.
by Jinoh Kang (＠iamahuman) 08 Jun '24

08 Jun '24

Follow-up to !3989. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5811

4 3

[PATCH 0/2] MR5812: odbccp32: SQLWritePrivateProfileStringW check for existing DSN first
by Alistair Leslie-Hughes (＠alesliehughes) 08 Jun '24

08 Jun '24

If a DSN is System wide, we need to write to the HKEY_LOCAL_MACHINE part of the registry not HKEY_CURRENT_USER which it's currently doing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5812

3 7

Re: [PATCH v7 0/4] MR5741: server: Implement key auto-repeat. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5741

1 0

Re: [PATCH v2 0/5] MR5804: win32u: Support custom DPI in curcor clipping related functions. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5804

1 0

Re: [PATCH v2 0/2] MR5806: odbccp32: Check for full path being supplied before append - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5806

1 0

Re: [PATCH v8 0/1] MR3518: wininet: unify timeout values closer to hInternet - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518

1 0

Re: [PATCH v2 0/1] MR5807: include: Add and fix some WGL prototypes. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5807

1 0

Re: [PATCH v2 0/2] MR5808: winevulkan: Fix size mismatch when writing to return pointer. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5808

1 0

Re: [PATCH v5 0/1] MR5788: d3d11/tests: Add a test for NV12 textures. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5788

1 0

Re: [PATCH v3 0/3] MR5797: wined3d: Miscellaneous. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5797

1 0

Re: [PATCH v3 0/1] MR5803: wined3d: Handle a null vertex declaration in glsl_vertex_pipe_vdecl(). - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5803

1 0

Re: [PATCH v3 0/12] MR5796: kernelbase, ntdll: Implement DOS wildcards matching in NtQueryDirectoryFile and use that in FindFirstFile(). - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5796

1 0

Re: [PATCH v2 0/1] MR5803: wined3d: Handle a null vertex declaration in glsl_vertex_pipe_vdecl(). - approved
by Jan Sikorski (＠jsikorski) 07 Jun '24

07 Jun '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5803

1 0

[PATCH v4 0/1] MR5788: d3d11/tests: Add a test for NV12 textures.
by Giovanni Mascellani (＠giomasce) 07 Jun '24

07 Jun '24

-- v4: d3d11/tests: Add a test for NV12 textures. https://gitlab.winehq.org/wine/wine/-/merge_requests/5788

5 5

Re: [PATCH v2 0/3] MR5797: wined3d: Miscellaneous. - approved
by Jan Sikorski (＠jsikorski) 07 Jun '24

07 Jun '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5797

1 0

[PATCH 0/2] MR5809: winecrt0, msvcrt: Implement static constructor support.
by Rémi Bernon (＠rbernon) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5809

2 2

[PATCH v15 0/6] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 07 Jun '24

07 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be … [View More]

3 7

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 07 Jun '24

07 Jun '24

On Thu Jun 6 19:38:37 2024 +0000, Jacek Caban wrote: > > Well, I expect them to behave like JS functions. If it were a JS > function, it would check to see if the object type matches, and then do > its thing. If you think of it like this, it wouldn't make much sense for > it to use another object type's function. > I'm not talking about another objects' functions, I'm talking about > separate objects having the same prototypes in JS sense but being > otherwise separate … [View More]

1 0

[PATCH 0/2] MR5808: winevulkan: Fix size mismatch when writing to return pointer.
by Rémi Bernon (＠rbernon) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5808

2 2

[PATCH 0/1] MR5807: include: Add and fix some WGL prototypes.
by Rémi Bernon (＠rbernon) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5807

2 1

[PATCH v4 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script.
by Akihiro Sagawa (＠sgwaki) 07 Jun '24

07 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56658 -- v4: win32u: Use the first vertical alternates table regardless of script. gdi32/tests: Add tests for script-independent vertical glyph lookup. https://gitlab.winehq.org/wine/wine/-/merge_requests/5633

2 3

[PATCH 0/2] MR5806: odbccp32: Check for full path being supplied before append
by Alistair Leslie-Hughes (＠alesliehughes) 07 Jun '24

07 Jun '24

Installer can provide a Full path to the Driver, instead of provide the install path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5806

3 3

[PATCH v7 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 07 Jun '24

07 Jun '24

Also: Add new timeouts to NETCON calls impacted by change Timeout values are able to be set on all hInternet handles, so they should be able to set in a unified way. Submitting what I have so far for review. Known TODO: Tests, verify timeouts are set where NETCON is used, verify ULONG vs DWORD usage rules. -- v7: wininet: unify timeout values closer to hInternet https://gitlab.winehq.org/wine/wine/-/merge_requests/3518

4 5

[PATCH 0/5] MR5804: win32u: Support custom DPI in curcor clipping related functions.
by Rémi Bernon (＠rbernon) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5804

2 5

[PATCH v14 0/6] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 07 Jun '24

07 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be … [View More]

3 7

[PATCH 0/1] MR5803: wined3d: Handle a null vertex declaration in glsl_vertex_pipe_vdecl().
by Elizabeth Figura (＠zfigura) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5803

2 1

[PATCH v5 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 06 Jun '24

06 Jun '24

Also: Add new timeouts to NETCON calls impacted by change Timeout values are able to be set on all hInternet handles, so they should be able to set in a unified way. Submitting what I have so far for review. Known TODO: Tests, verify timeouts are set where NETCON is used, verify ULONG vs DWORD usage rules. -- v5: wininet: unify timeout values closer to hInternet https://gitlab.winehq.org/wine/wine/-/merge_requests/3518

2 1

Re: [PATCH v3 0/3] MR5793: server: Inherit the source token's label in token_duplicate(). - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5793

1 0

Re: [PATCH v4 0/7] MR5732: winegstreamer: Get rid of the wg_transform internal output_format. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5732

1 0

Re: [PATCH v4 0/7] MR5717: Improve dmo_wrapper_sink_Receive. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5717

1 0

Re: [PATCH v2 0/1] MR5800: gdi32/text: Handle null partial extents pointer in GetTextExtentExPointW(). - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5800

1 0

Re: [PATCH v2 0/1] MR5802: dwrite/tests: Fix a test failure on some Win10 machines with CJK locales. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5802

1 0

Re: [PATCH v4 0/3] MR5799: winex11: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5799

1 0

Re: [PATCH v3 0/1] MR5777: win32u: Limit GDI object generation by 127 for a 64-bit build. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5777

1 0

Re: [PATCH v3 0/1] MR5789: server: Remove limitation for waiting on idle_event of the current process. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5789

1 0

Re: [PATCH v4 0/5] MR5776: win32u: Parameterize DPI in some driver calls. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5776

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 06 Jun '24

06 Jun '24

On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote: > Setting the timeout on the socket is quite expensive (requires a > wineserver call). Maybe we could store the last set timeout separate > from configure timeout and update socket timeout only when they don't match? Would this proposal be only for `read_more_data` or in the broader scope of any call to `NETCON_set_timeout`? If it is for the latter, it could be tracked in `netconn_t`. I can add that into a separate merge. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72609

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 06 Jun '24

06 Jun '24

On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote: > Do we still need it? I think that with implementation in both > `set_global_option` and `INET_SetOption`, we could simply remove those > cases from `InternetSetOptionW` fallback. If we can assume that `vtbl->SetOption` is guaranteed to handle its own implementation of each timeout (or fallback to `INET_SetOption`), I could see dropping these cases from `InternetSetOptionW`. I'll amend those changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72608

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) 06 Jun '24

06 Jun '24

> Well, I expect them to behave like JS functions. If it were a JS function, it would check to see if the object type matches, and then do its thing. If you think of it like this, it wouldn't make much sense for it to use another object type's function. I'm not talking about another objects' functions, I'm talking about separate objects having the same prototypes in JS sense but being otherwise separate implementations of the same interfaces in C. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72607

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 06 Jun '24

06 Jun '24

On Thu Jun 6 19:05:56 2024 +0000, Jacek Caban wrote: > > In such case, instead of failing, it would call the other function > that was looked up, since it matches in IID and DISPID. It won't crash, > but I don't think it would be quite correct, either. > That's the whole point, the reason it's safe and I don't see why you > think it's incorrect. BTW, IID is intentionally abstract in my proposal; > a bit closer to the actual meaning would be to use something like > … [View More]

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) 06 Jun '24

06 Jun '24

> In such case, instead of failing, it would call the other function that was looked up, since it matches in IID and DISPID. It won't crash, but I don't think it would be quite correct, either. That's the whole point, the reason it's safe and I don't see why you think it's incorrect. BTW, IID is intentionally abstract in my proposal; a bit closer to the actual meaning would be to use something like prototype ID once we have those (interface ID is just already available and close enough). &… [View More]

1 0

[PATCH v2 0/12] MR5796: kernelbase, ntdll: Implement DOS wildcards matching in NtQueryDirectoryFile and use that in FindFirstFile().
by Paul Gofman (＠gofman) 06 Jun '24

06 Jun '24

-- v2: kernelbase: Preprocess wildcarded mask and pass it with NtQueryDirectoryFile(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5796

3 14

[PATCH v36 0/2] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 06 Jun '24

06 Jun '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v36: ucrtbase: Fix incorrect layout of FILE. ucrtbase: Add FILE structure tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 3

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 06 Jun '24

06 Jun '24

On Thu Jun 6 15:55:43 2024 +0000, Gabriel Ivăncescu wrote: > Actually you don't even need to query IID anymore. Just look up the > function by dispid, and then check if it's same func_info_t, that's enough. BTW, is there a reason you renamed `IWineJSDispatchHost` to just `IJSDispatchHost` when it's Wine's own interface? I thought it's better to avoid ambiguity with a native interface, especially if we're to extend it (obviously we can't touch native interfaces), makes it a lot more … [View More]

1 0

[PATCH v3 0/7] MR5732: winegstreamer: Get rid of the wg_transform internal output_format.
by Rémi Bernon (＠rbernon) 06 Jun '24

06 Jun '24

-- v3: winegstreamer: Request the new transform output format explicitly. winegstreamer: Use a caps to store the desired output format. winegstreamer: Only report format changes when frontend supports it. winegstreamer: Rename allow_size_change to allow_format_change. winegstreamer: Enforce default stride presence in the video processor. winegstreamer: Enforce default stride value in the video decoder. winegstreamer: Allow to clear video decoder input/… [View More]

4 10

[PATCH v3 0/7] MR5717: Improve dmo_wrapper_sink_Receive.
by Ziqing Hui (＠zhui) 06 Jun '24

06 Jun '24

This reduce the chance of buffer allocating issue for Kirikiri2 games(eg. Super Naughty Maid) when the game is trying to play videos. -- v3: qasf/dmowrapper: Sync Stop() and Receive() for dmo wrapper filter. qasf/dmowrapper: Return VFW_E_WRONG_STATE in dmo_wrapper_sink_Receive. qasf/dmowrapper: Allocate output samples before calling ProcessInput(). qasf/dmowrapper: Return failure in dmo_wrapper_sink_Receive if samples allocating fails. qasf/dmowrapper: Introduce … [View More]

3 8

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 06 Jun '24

06 Jun '24

On Thu Jun 6 15:51:53 2024 +0000, Gabriel Ivăncescu wrote: > > But then you assume that all objects implementing the interface will > use the same struct layout for that. I can't think of an example inside > MSHTML where it's currently not the case, but that's not generally a > promise that QI gives. > In theory, there's a similar concern when looking up the function via > IID and DISPID, specifically, that it might find a different function. > In practice as you said … [View More]

1 0

[PATCH v3 0/3] MR5799: winex11: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory.
by Rémi Bernon (＠rbernon) 06 Jun '24

06 Jun '24

Didn't notice that it was failing until I did the same for winemac with https://gitlab.winehq.org/wine/wine/-/merge_requests/5798. It was silently falling back to copies while winemac can't do that. -- v3: gdi.exe16: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory. winex11: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory. winex11: Wrap more window surface formats with NtGdiDdDDICreateDCFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/5799

2 3

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 06 Jun '24

06 Jun '24

> But then you assume that all objects implementing the interface will use the same struct layout for that. I can't think of an example inside MSHTML where it's currently not the case, but that's not generally a promise that QI gives. In theory, there's a similar concern when looking up the function via IID and DISPID, specifically, that it might find a different function. In practice as you said it probably doesn't happen but… > So what's the point of it then? Avoiding one argument in … [View More]

1 0

[PATCH 0/3] MR5799: winex11: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory.
by Rémi Bernon (＠rbernon) 06 Jun '24

06 Jun '24

Didn't notice that it was failing until I did the same for winemac with https://gitlab.winehq.org/wine/wine/-/merge_requests/5798. It was silently falling back to copies while winemac can't do that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5799

3 5

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) 06 Jun '24

06 Jun '24

> Yeah, I forgot to validate it in my branch. In BuiltinFuncCall, something like this would work: But then you assume that all objects implementing the interface will use the same struct layout for that. I can't think of an example inside MSHTML where it's currently not the case, but that's not generally a promise that QI gives. > Alternatively, we can pass around `func_info_t` instead of dispid and tid, but still look it up like in your branch. So what's the point of it then? Avoiding … [View More]

1 0

[PATCH v13 0/6] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 06 Jun '24

06 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be … [View More]

3 7

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 06 Jun '24

06 Jun '24

On Wed Jun 5 21:57:54 2024 +0000, Jacek Caban wrote: > > But it was still ambiguous as I explained. > If you mean the "zoom" example, I'd appreciate for some details. That > one should already use `IHTMLCSSStyleDeclaration` interface, not > `IHTMLStyle*` ones. > > But since we pass the mshtml-internal tid (called iid in args) which > is opaque to jscript, I don't really see why this is better than passing > the `func_info_t` directly? Well IMO passing the pair is … [View More]already more > complex and requires more lookups, more args, etc, but that's just me. > `get_dispex_from_this` is one thing, going through the interface take > cares of that. For that part, you could just replace the argument in my branch. > But we should also somehow make sure that the hook is safe to call. By > binding function info to the exact object instance, we guarantee that > it's safe to call `impl_from_*` from hooks. If you accept any function > info as an input, you need to somehow validate that it's safe to call > it. Something like moving QI earlier would only partially mitigate that. > I'm open to other approaches, but unless I'm missing something, there is > no such validation in your current branch. > It seems to me that things like 1ffeaa446613 come from some variation of > solution to that problem. Maybe it was needed in earlier version, but it > shouldn't be needed with "this" being resolved on jscript side. It's no > longer arbitrary when it's used for a `IJSDispatchHost` call. I would > suggest to try removing it. Yeah, I forgot to validate it in my branch. In BuiltinFuncCall, something like this would work: ```c if(func->hook) { hres = IWineJSDispatchHost_QueryInterface(&This->IWineJSDispatchHost_iface, tid_ids[func->tid], (void**)&unk); if(FAILED(hres)) return hres; IUnknown_Release(unk); hres = func->hook(This, setter ? DISPATCH_PROPERTYPUT : DISPATCH_PROPERTYGET, dp, ret, ei, caller); if(hres != S_FALSE) return hres; } ``` Alternatively, we can pass around `func_info_t` instead of dispid and tid, but still look it up like in your branch. We can obtain the dispid and tid from `func_info_t` so that's all that's needed. I'm not sure if that's an improvement over my approach, but I think it's definitely a simplification over yours. What do you think? BTW for `zoom`, the assignment should fail as it does on native (as the test does), are you sure it's supposed to be using `IHTMLCSSStyleDeclaration` which doesn't fail? I mean the test will simply start failing if it picks `IHTMLCSSStyleDeclaration` because the assignment does not throw exception anymore (when it should be!). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72586 [View Less]

1 0

[PATCH v12 0/6] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 06 Jun '24

06 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be … [View More]

3 7

[PATCH 0/1] MR5651: winex11.drv: Use NtUserShowWindow() instead of WM_SYSCOMMAND to synchronize window state.
by Dmitry Timoshkov (＠dmitry) 06 Jun '24

06 Jun '24

DefWindowProc(WM_SYSCOMMAND) handler ignores commands for a WS_DISABLED window which leads to window state/size mismatch on X11 and win32 sides. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5651

4 7

[PATCH 0/1] MR5800: gdi32/text: Handle null partial extents pointer in GetTextExtentExPointW().
by Nikolay Sivov (＠nsivov) 06 Jun '24

06 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56788 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5800

3 2

[PATCH 0/1] MR5802: dwrite/tests: Fix a test failure on some Win10 machines with CJK locales.
by Nikolay Sivov (＠nsivov) 06 Jun '24

06 Jun '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5802

2 1

[PATCH v2 0/1] MR5777: win32u: Limit GDI object generation by 127 for a 64-bit build.
by Dmitry Timoshkov (＠dmitry) 06 Jun '24

06 Jun '24

I have a .Net application that during handling of WM_NCPAINT for one of its windows genarates exception "Arithmetic operation resulted in an overflow.". This happens only in a 64-bit prefix and only for WPARAM that contains an HRGN handle with value over than 0x7fffffff. The application does the following: public static IntPtr GetNativeDC(Message m, IntPtr handle) { if (m.Msg != 0x85) // WM_NCPAINT { return NUser32.GetWindowDC(handle); } int num = 0x200013; // … [View More]

4 6

[PATCH 0/8] MR5801: d3dx9: Use new shared code in D3DXCreateTextureFromFileInMemoryEx().
by Connor McAdams (＠cmcadams) 06 Jun '24

06 Jun '24

This is the first step in moving the various D3DXCreateTextureFromFileInMemory functions over to using shared code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5801

2 8

[PATCH v2 0/1] MR5789: server: Remove limitation for waiting on idle_event of the current process.
by Dmitry Timoshkov (＠dmitry) 06 Jun '24

06 Jun '24

[test_WaitForInputIdle.tar.bz2](/uploads/a20c5b119741cd7b0b4813488854a992/test_WaitForInputIdle.tar.bz2) Attached test replicates the problem. Basically the application does process = OpenProcess(SYNCHRONIZE | PROCESS_QUERY_INFORMATION, FALSE, GetCurrentProcessId()); ret = WaitForInputIdle(process, 0x7fffffff); assert(ret == 0); With current wine.git WaitForInputIdle() returns WAIT_FAILED because the server call get_process_idle_event() refuses to return idle_event for the current process. … [View More]

3 3

[PATCH v2 0/5] MR5798: winemac: Push window surface updates to the main thread.
by Rémi Bernon (＠rbernon) 06 Jun '24

06 Jun '24

Instead of accessing the surface with macdrv_get_surface_display_image. -- v2: winemac: Remove now unnecessary cocoa window surface pointer. winemac: Push window surface image updates to the main thread. winemac: Create window surface CGImageRef on surface flush. winemac: Create a provider for the surface and a HBITMAP wrapping it. winemac: Remove unused macdrv_get_surface_display_image copy_data parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/5798

2 6

[PATCH v5 0/4] MR5741: server: Implement key auto-repeat.
by Alexandros Frantzis (＠afrantzis) 06 Jun '24

06 Jun '24

This is an early draft of an implementation of key auto-repeat in wineserver to get some feedback. Some open questions: 1. queue_keyboard_message requires a `current` thread, but we don't get one in timeout callbacks. At the moment I am manually setting `current` to the foreground thread, but I am wondering if that's acceptable or we should explore other ways forward (also see TODO in code). 2. This draft introduces a new server request to configure auto-repeat (`enable/delay/period`). I am … [View More]

3 6

[PATCH v6 0/4] MR5741: server: Implement key auto-repeat.
by Alexandros Frantzis (＠afrantzis) 06 Jun '24

06 Jun '24

This is an early draft of an implementation of key auto-repeat in wineserver to get some feedback. Some open questions: 1. queue_keyboard_message requires a `current` thread, but we don't get one in timeout callbacks. At the moment I am manually setting `current` to the foreground thread, but I am wondering if that's acceptable or we should explore other ways forward (also see TODO in code). 2. This draft introduces a new server request to configure auto-repeat (`enable/delay/period`). I am … [View More]

2 5

[PATCH 0/5] MR5798: winemac: Push window surface updates to the main thread.
by Rémi Bernon (＠rbernon) 06 Jun '24

06 Jun '24

Instead of accessing the surface with macdrv_get_surface_display_image. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5798

2 6

[PATCH v3 0/5] MR5776: win32u: Parameterize DPI in some driver calls.
by Rémi Bernon (＠rbernon) 06 Jun '24

06 Jun '24

-- v3: win32u: Pass the rect DPI to NtUserIsWindowRectFullScreen. win32u: Introduce a new get_monitor_rect helper. win32u: Pass desired DPI to NtUserGet(Client|Window)Rect. win32u: Introduce NtUserAdjustWindowRect call for AdjustWindowRect*. win32u: Introduce new helpers to convert server rectangle_t. https://gitlab.winehq.org/wine/wine/-/merge_requests/5776

2 7

[PATCH v4 0/1] MR5333: vcruntime140_1: Pass original frame to catch block on stack.
by Daniel Lehman (＠dlehman25) 06 Jun '24

06 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56451 local variables with alignas(32) or higher may cause the unwinding code to fetch the original frame from a different spot on the stack from where the catch block code places it -- v4: vcruntime140_1: Pass original frame to catch block on stack. https://gitlab.winehq.org/wine/wine/-/merge_requests/5333

3 4

[PATCH 0/3] MR5797: wined3d: Miscellaneous.
by Elizabeth Figura (＠zfigura) 06 Jun '24

06 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5797

2 3

[PATCH 0/12] MR5796: kernelbase, ntdll: Implement DOS wildcards matching in NtQueryDirectoryFile and use that in FindFirstFile().
by Paul Gofman (＠gofman) 06 Jun '24

06 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5796

3 15

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacek Caban (＠jacek) 05 Jun '24

05 Jun '24

Jacek Caban (@jacek) commented about dlls/wininet/http.c: > > if (maxlen == -1) maxlen = sizeof(req->read_buf); > > + NETCON_set_timeout(req->netconn, FALSE, req->hdr.receive_timeout); Setting the timeout on the socket is quite expensive (requires a wineserver call). Maybe we could store the last set timeout separate from configure timeout and update socket timeout only when they don't match? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72541

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacek Caban (＠jacek) 05 Jun '24

05 Jun '24

It looks better, thanks. In addition to minor comments, please split it. Additional `NETCON_set_timeout` fix is a separate fix from setting/getting options. Maybe also separate `NETCON_set_timeout` for send and receive. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72542

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacek Caban (＠jacek) 05 Jun '24

05 Jun '24

Jacek Caban (@jacek) commented about dlls/wininet/internet.c: > + if (!lpwhh) > + { > + SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE); > + return FALSE; > + } > + if (!lpBuffer || dwBufferLength != sizeof(ULONG)) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + ret = FALSE; > + } > + else > + { > + lpwhh->connect_timeout = *(ULONG *)… [View More]

1 0

[PATCH v2 0/3] MR5685: Implement MarkupServices_ParseString
by Santino Mazza (＠tati1454) 05 Jun '24

05 Jun '24

-- v2: mshtml: Implement MarkupServices_ParseString. mshtml: Implement MarkupServices_CreateMarkupContainer. mshtml/tests: Test for IMarkupServices. https://gitlab.winehq.org/wine/wine/-/merge_requests/5685

5 11

[PATCH 0/1] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 05 Jun '24

05 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 6

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) 05 Jun '24

05 Jun '24

> But it was still ambiguous as I explained. If you mean the "zoom" example, I'd appreciate for some details. That one should already use `IHTMLCSSStyleDeclaration` interface, not `IHTMLStyle*` ones. > But since we pass the mshtml-internal tid (called iid in args) which is opaque to jscript, I don't really see why this is better than passing the `func_info_t` directly? Well IMO passing the pair is already more complex and requires more lookups, more args, etc, but that's just me. `… [View More]

1 0

Re: [PATCH v2 0/1] MR5758: ntdll: On macOS, check for xattr existence before calling getxattr. - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5758

1 0

Re: [PATCH v6 0/3] MR5737: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name. - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5737

1 0

Re: [PATCH v2 0/1] MR5792: server: Avoid calling set_event from within msg_queue_add_queue. - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5792

1 0

Re: [PATCH v4 0/9] MR5782: win32u: Move UpdateLayeredWindow implementation to win32u. - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5782

1 0

Re: [PATCH v2 0/6] MR5763: wined3d: Fix some corner cases in the FFP pipelines related to unbound streams. - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5763

1 0

Re: [PATCH v3 0/1] MR5786: gdi32: Use an internal NtUser call for D3DKMTOpenAdapterFromGdiDisplayName. - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5786

1 0

Re: [PATCH v2 0/1] MR5795: scrrun/dictionary: Implement putref_Item() method. - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5795

1 0

Re: [PATCH v4 0/1] MR5749: gitlab: Update configuration for the new Mac runner. - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5749

1 0

Re: [PATCH v3 0/1] MR5779: win32u: Send EVENT_OBJECT_FOCUS in more cases. - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5779

1 0

Re: [PATCH v3 0/5] MR5791: wineps.drv: Page size and orientation fixes - approved
by Alexandre Julliard (＠julliard) 05 Jun '24

05 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5791

1 0

[PATCH v33 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 05 Jun '24

05 Jun '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v33: [PATCH] msvcrt: Fix incorrect layout of FILE in ucrt https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 2

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 05 Jun '24

05 Jun '24

On Wed Jun 5 18:25:43 2024 +0000, Jacek Caban wrote: > > Well yes, of course they check for the object type compatibility, but > in the end they should still preserve their "function identity" instead > of being looked up from the object everytime, even if it's completely > detached from it. > I don't know what you mean by that, a pair like (dispid, iid) uniquely > defines a function identity. There is nothing special about dispid > except that we already need its … [View More]lookup implemented, so that seems convenient. > See https://gitlab.winehq.org/jacek/wine/-/commits/func-call for a draft > of what I mean. It implements `call` only for legacy functions, but I > think it would scale to proper prototypes. It implements > bc02a4fe3be595448, but doesn't need unpleasant things like > `get_dispex_from_this` and uses the new interface instead (so committing > something like that would also be a good opportunity to upstream > "boring" parts of 81800d9dfa59f4fd8). > Extending it with accessors support should be straightforward. For > prototypes, we could just have entries for those functions both in the > instance and prototype objects. In instances, they would be not searched > when doing lookups by name, so the only way to use it would be through > `IJSDispatchHost`. For prototypes, they would be looked up, but an > attempt to call it would fail because prototypes don't actually > implement the required interface (so the result of the lookup would be > useful only for instances). It should also allow skipping 1ffeaa446613 > with all its consequences. What do you think? Well yes, a pair does work, but I wasn't passing the IID, only the DISPID after making sure the object implements the required IID, since I was delegating to the standard InvokeEx (well, almost), which only has DISPID. But it was still ambiguous as I explained. But since we pass the mshtml-internal tid (called iid in args) which is opaque to jscript, I don't really see why this is better than passing the `func_info_t` directly? Well IMO passing the pair is already more complex and requires more lookups, more args, etc, but that's just me. I haven't analyzed the rest yet, I'll look tomorrow as I have to go now, but `get_dispex_from_this` is primarily useful for jscript proxies since they can have arbitrary "this" passed. I was using it here (for legacy function.call) mostly to introduce it earlier and have less to add on the proxy patch which was already big enough as it is, but it's not its main purpose. It was just a "split" attempt. Are you sure you can get rid of it with your method? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72511 [View Less]

1 0

[PATCH v4 0/4] MR5741: server: Implement key auto-repeat.
by Alexandros Frantzis (＠afrantzis) 05 Jun '24

05 Jun '24

This is an early draft of an implementation of key auto-repeat in wineserver to get some feedback. Some open questions: 1. queue_keyboard_message requires a `current` thread, but we don't get one in timeout callbacks. At the moment I am manually setting `current` to the foreground thread, but I am wondering if that's acceptable or we should explore other ways forward (also see TODO in code). 2. This draft introduces a new server request to configure auto-repeat (`enable/delay/period`). I am … [View More]

3 12

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) 05 Jun '24

05 Jun '24

> Well yes, of course they check for the object type compatibility, but in the end they should still preserve their "function identity" instead of being looked up from the object everytime, even if it's completely detached from it. I don't know what you mean by that, a pair like (dispid, iid) uniquely defines a function identity. There is nothing special about dispid except that we already need its lookup implemented, so that seems convenient. See https://gitlab.winehq.org/jacek/wine/-/… [View More]

1 0

[PATCH v6 0/6] MR5744: winegstreamer: Fix various Cinepak issues
by Alfred Agrell (＠Alcaro) 05 Jun '24

05 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56698 -- v6: quartz: Allow concurrent calls to AVI decoder qc_Notify and Receive. msvfw32/tests: Test that Cinepak rejects unsupported output types. iccvid: Reject unsupported output types. quartz/tests: Add Cinepak test to avi splitter. winegstreamer: Use end of previous frame if the current frame doesn't have a timestamp. winegstreamer: Implement AM_MEDIA_TYPE to wg_format converter for Cinepak video. https://gitlab.winehq.org/wine/wine/-/merge_requests/5744

4 9

[PATCH v3 0/4] MR5741: Draft: server: Implement key auto-repeat.
by Alexandros Frantzis (＠afrantzis) 05 Jun '24

05 Jun '24

This is an early draft of an implementation of key auto-repeat in wineserver to get some feedback. Some open questions: 1. queue_keyboard_message requires a `current` thread, but we don't get one in timeout callbacks. At the moment I am manually setting `current` to the foreground thread, but I am wondering if that's acceptable or we should explore other ways forward (also see TODO in code). 2. This draft introduces a new server request to configure auto-repeat (`enable/delay/period`). I am … [View More]

3 12

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by Piotr Caban (＠piotr) 05 Jun '24

05 Jun '24

On Wed Jun 5 13:11:29 2024 +0000, cqwrteur wrote: > Of course, there is. The problem is that ucrt can be statically linked > from Microsoft UCRT static ucrt can be put back to FILE* in dynamic > linking. And fast_io library is using that. gitlab is not showing the context very well. I was asking about `stdout == stdin+1` test. Does the library depend on that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72456

1 0

[PATCH v2 0/1] MR5786: gdi32: Use an internal NtUser call for D3DKMTOpenAdapterFromGdiDisplayName.
by Rémi Bernon (＠rbernon) 05 Jun '24

05 Jun '24

Fixes a deadlock with display_device_init mutex and display_lock when trying to open the D3DKMT adapter while holding the mutex in the caller. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56764 -- v2: gdi32: Use an internal NtUser call for D3DKMTOpenAdapterFromGdiDisplayName. https://gitlab.winehq.org/wine/wine/-/merge_requests/5786

3 3

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by Piotr Caban (＠piotr) 05 Jun '24

05 Jun '24

On Wed Jun 5 13:02:30 2024 +0000, cqwrteur wrote: > It is not. The problem is that ucrt can be statically linked from > Microsoft UCRT static ucrt can be put back to FILE* in dynamic linking. > And fast_io library is exploiting that to gain huge performance. The `ok(ptrold + cntold == file->_ptr + file->_cnt, ...);` test is redundant. You're testing `ptrold` and `cntold` values in earlier tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72454

1 0

[PATCH v2 0/5] MR5741: Draft: server: Implement key auto-repeat.
by Alexandros Frantzis (＠afrantzis) 05 Jun '24

05 Jun '24

This is an early draft of an implementation of key auto-repeat in wineserver to get some feedback. Some open questions: 1. queue_keyboard_message requires a `current` thread, but we don't get one in timeout callbacks. At the moment I am manually setting `current` to the foreground thread, but I am wondering if that's acceptable or we should explore other ways forward (also see TODO in code). 2. This draft introduces a new server request to configure auto-repeat (`enable/delay/period`). I am … [View More]

3 17

2025

2024

2023

2022

wine-gitlab