- wine-gitlab - winehq.org

[PATCH v6 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v6: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 13

Re: [PATCH v3 0/4] MR5644: d3dx9: New tests and a compressed image loading bugfix. - approved
by Matteo Bruni (＠Mystral) 28 May '24

28 May '24

This merge request was approved by Matteo Bruni. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5644

1 0

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

On Wed May 15 12:40:06 2024 +0000, Piotr Caban wrote: > Yes I was thinking about something like you have attached first but I > didn't like few things: > - it requires adding new flag > - it's a special marker that is only valid in template, it can't be > used as datatype in other places > - your code is also not eating final '@' correctly but it can be > addressed easily I forgot to mention that native accepts multiple $$V sequences, so e.g. `?AU?$my_iter@H$0A@$$V$$V@@` is also parsed (but probably doesn't make sense and nothing is mangled this way). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70526

1 0

[PATCH 0/6] MR5638: wined3d: Remove texture NPOT fixup.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5638

4 8

[PATCH 0/9] MR5653: wbemprox: Get processor information from the SMBIOS table.
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This fixes the reported information on ARM platforms. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5653

4 11

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

On Wed May 15 12:16:18 2024 +0000, eric pouech wrote: > [err](/uploads/6c39c40a566da58e25661ae18e455f1c/err) Yes I was thinking about something like you have attached first but I didn't like few things: - it requires adding new flag - it's a special marker that is only valid in template, it can't be used as datatype in other places - your code is also not eating final '@' correctly but it can be addressed easily -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70520

1 0

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by eric pouech (＠epo) 28 May '24

28 May '24

On Wed May 15 10:08:14 2024 +0000, Piotr Caban wrote: > I can't see the patch, could you please fix the link? [err](/uploads/6c39c40a566da58e25661ae18e455f1c/err) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70517

1 0

[PATCH v2 0/4] MR5644: d3dx9: New tests and a compressed image loading bugfix.
by Connor McAdams (＠cmcadams) 28 May '24

28 May '24

-- v2: d3dx9: Fix destination rectangles passed from D3DXLoadSurfaceFromMemory() to d3dx_load_image_from_memory(). d3dx9: Only do direct copies of full blocks for compressed formats. d3dx9/tests: Add a new compressed surface loading test. d3dx9/tests: Add a test for negative values in the source rectangle passed to D3DXLoadSurfaceFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/5644

3 7

[PATCH 0/1] MR5650: msvcrt,winedump: Demandle std::nullptr_t datatype.
by eric pouech (＠epo) 28 May '24

28 May '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5650

5 4

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

On Wed May 15 08:07:21 2024 +0000, eric pouech wrote: > that test looks very strange at that place while we already have > handling of other types starting with "$$" in demangle_datatype. > it calls for having a proper identification about end of list (didn't > include the function arg one, but we could well do it) > I think we could rather use something like the attached patch. > [err](/uploads/8c2f1adecffbfe57c3d3bf924bf1755a/ I can't see the patch, could you please fix the link? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70505

1 0

[PATCH v2 0/5] MR5616: win32u: Enumerate and expose vulkan-only GPUs.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This should achieve the same thing as https://github.com/ValveSoftware/wine/commit/e8801e96fedf67b88e6f3f5d9f9e2d… -- v2: win32u: Enumerate offscreen vulkan devices as GPU devices. win32u: Query GPU memory from vulkan physical device. win32u: Match driver GPUs with vulkan GPUS from their ids, or index. win32u: Keep a list of vulkan GPUS in the device manager context. win32u: Fix default_update_display_devices return type to NTSTATUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5616

4 9

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by eric pouech (＠epo) 28 May '24

28 May '24

eric pouech (@epo) commented about dlls/msvcrt/undname.c: > sym->current++; > break; > } > + /* Handle empty list in variadic template */ > + if (!z_term && sym->current[0] == '$' && sym->current[1] == '$' && sym->current[2] == 'V') that test looks very strange at that place while we already have handling of other types starting with "$$" in demangle_datatype. it calls for having a proper identification about end of list (didn't include the function arg one, but we could well do it) I think we could rather use something like the attached patch. [err](/uploads/8c2f1adecffbfe57c3d3bf924bf1755a/ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70497

1 0

[PATCH 0/4] MR5644: d3dx9: New tests and a compressed image loading bugfix.
by Connor McAdams (＠cmcadams) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5644

4 8

Re: [PATCH v2 0/1] MR5636: opengl32: Prefer formats with depth if unspecified in wglChoosePixelFormat(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5636

1 0

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646

1 0

Re: [PATCH v2 0/3] MR5594: winemac.drv: Some display mode fixes - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5594

1 0

Re: [PATCH v2 0/1] MR5645: winebuild: Use .drectve section for exports on ARM64EC. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5645

1 0

Re: [PATCH v3 0/8] MR5640: odbc32: Add Wow64 thunks - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5640

1 0

Re: [PATCH v2 0/1] MR5635: ntdll: Allocate crit section debug info by default for Windows versions before 8. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5635

1 0

Re: [PATCH v3 0/8] MR5607: Link strmbase modules to msvcrt instead of ucrtbase. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5607

1 0

Re: [PATCH v2 0/3] MR5643: winebus: Implement Sony controllers report fixups for the iohid backend. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5643

1 0

Re: [PATCH v2 0/1] MR5637: dinput: Don't include every version of DirectInputCreate in every DLL. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5637

1 0

[PATCH 0/1] MR5634: win32u: Ignore WM_MOUSEMOVE when tracking scrollbar and arrow/track is clicked
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

This fixes a regression from bb496ea8. Also closer mimics windows behavior, moving the mouse should not reset the scrolling timer. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56582 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5634

4 7

[PATCH 0/1] MR5636: opengl32: Prefer formats with depth if unspecified in wglChoosePixelFormat().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Descent 3 depends on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5636

4 4

Re: [PATCH v3 0/6] MR5642: mshtml: Use DISPEX_IDISPATCH_IMPL macro in more places. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5642

1 0

[PATCH 0/3] MR5594: winemac.drv: Some display mode fixes
by Tim Clem (＠tclem) 28 May '24

28 May '24

Fixing up some issues seen with display modes reported from the Apple Studio Display: - It has some pairs of modes that differ only in whether they are "usable for desktop." Switching to one of the modes that isn't results in an error. All other things being equal, we should prefer modes that are "usable for desktop" over those that aren't. - display_get_modes was returning multiple identical DEVMODEs. This is because we consider the kDisplayModeValidFlag and kDisplayModeSafeFlag values as making a display mode unique (and thus not comparable to other modes with the same resolution). Like above, the Studio Display has mode pairs that are identical except that one is "unsafe." We should compare modes with the same resolution, regardless of the safe and valid flags, and prefer safe and valid ones over the alternatives. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5594

3 4

[PATCH v5 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v5: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

2 12

[PATCH v4 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v4: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 13

Re: [PATCH v2 0/1] MR5588: xaudio2: Use FAudioVoice_DestroyVoiceSafeEXT() in destroy_voice().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Oh, it is probably this one: > xaudio2_8 > xaudio2.c:865: Test failed: CreateSubmixVoice failed: 88960001 > 0a44:xaudio2: unhandled exception c0000005 at 00007FF795004307 Thanks, I will take a look now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5588#note_70415

1 0

Re: [PATCH v2 0/1] MR5588: xaudio2: Use FAudioVoice_DestroyVoiceSafeEXT() in destroy_voice().
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This is breaking the tests on Windows, could you please have a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5588#note_70414

1 0

[PATCH 0/6] MR5626: mfreadwrite: Support MFVideoFormat_ABGR32 output.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This format is used by many Unity games, with D3D-enabled source reader. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5626

4 9

[PATCH 0/6] MR5642: mshtml: Use DISPEX_IDISPATCH_IMPL macro in more places.
by Jacek Caban (＠jacek) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5642

4 9

[PATCH 0/1] MR5633: win32u: Fallback to default script if vert/vrt2 is not found.
by Akihiro Sagawa (＠sgwaki) 28 May '24

28 May '24

Also changed to use `DFLT` instead of `dflt` as the default script tag. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56658 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633

4 4

[PATCH 0/1] MR5637: dinput: Don't include every version of DirectInputCreate in every DLL.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

DirectInputCreate(A|W|Ex) is only needed in dinput.dll, and DirectInput8Create is only needed in dinput8.dll. Excluding the unnecessary functions reduces the size of each DLL by about 4 KB. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5637

4 3

[PATCH v2 0/8] MR5640: odbc32: Add Wow64 thunks
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- v2: odbc32/tests: Add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5640

3 10

[PATCH v2 0/2] MR5625: Fixes for GCC 14 warnings (in winedump)
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

The `-Wstringop-overread` fix feels a bit questionable (so I'll add Eric as a reviewer to clarify the MSC structs details) -- v2: winedump: Fail on NULL funcs in dump_dir_exceptions(). winedump: Use offsetof() for string position calculations. https://gitlab.winehq.org/wine/wine/-/merge_requests/5625

5 7

[PATCH 0/5] MR5616: win32u: Enumerate and expose vulkan-only GPUs.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This should achieve the same thing as https://github.com/ValveSoftware/wine/commit/e8801e96fedf67b88e6f3f5d9f9e2d… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5616

3 7

Re: [PATCH v3 0/4] MR5609: Rewrite of cmd command engine (part III). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5609

1 0

Re: [PATCH v3 0/7] MR5622: wined3d: Remove the no longer usable shader and FFP backends. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5622

1 0

Re: [PATCH v2 0/1] MR5624: po: Add a missing \t in the Simplified Chinese translation. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5624

1 0

Re: [PATCH v3 0/1] MR5613: winegstreamer: Pass filename to wg_parser when available. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5613

1 0

Re: [PATCH v4 0/2] MR5611: winegstreamer: Fix audio decoding support checks. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5611

1 0

Re: [PATCH v2 0/3] MR5630: mshtml: Introduce DISPEX_IDISPATCH_IMPL. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5630

1 0

Re: [PATCH v3 0/2] MR5618: mountmgr.sys: Ignore hidden and system volumes on macOS - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5618

1 0

Re: [PATCH v3 0/1] MR5629: d3dx9/tests: Use trace instead of printf. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5629

1 0

[PATCH v36 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v36: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. win32u: Open the global session shared mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 11

[PATCH v3 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v3: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 31

[PATCH v3 0/2] MR5611: winegstreamer: Fix audio decoding support checks.
by Anton Baskanov (＠baskanov) 28 May '24

28 May '24

Fixes: cc82780c22db31fed4da8b84e85c01652a995490 -- v3: winegstreamer: Add missing format fields to WMA support check. winegstreamer: Recognize MFAudioFormat_MPEG and MFAudioFormat_MP3. https://gitlab.winehq.org/wine/wine/-/merge_requests/5611

4 6

[PATCH 0/1] MR5623: po: Add a missing \t in the Simplified Chinese translation.
by Hongxin Zhao (＠zhaohongxin) 28 May '24

28 May '24

Align the Chinese text output of wine cmd before: ![before.png](/uploads/903d871e44394d1ad9e9f032cc6941bd/before.png) after: ![after.png](/uploads/f155f2d59a9663ea67497002e24d7708/after.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5623

4 4

Re: [PATCH v2 0/1] MR5613: winegstreamer: Pass filename to wg_parser when available. - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5613

1 0

[PATCH v2 0/2] MR5618: mountmgr.sys: Ignore hidden and system volumes on macOS
by Tim Clem (＠tclem) 28 May '24

28 May '24

Non-"browsable" volumes or those without filesystem mount points are invisible to users and should not be reflected automatically into Wine. -- v2: mountmgr.sys: Do not add drive letters or volumes for macOS volumes without mount paths. mountmgr.sys: Do not create drive letters or volumes for unbrowsable macOS volumes. https://gitlab.winehq.org/wine/wine/-/merge_requests/5618

4 4

[PATCH 0/3] MR5630: mshtml: Introduce DISPEX_IDISPATCH_IMPL.
by Jacek Caban (＠jacek) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5630

4 6

[PATCH v2 0/1] MR5629: d3dx9/tests: Use trace instead of printf.
by Jacek Caban (＠jacek) 28 May '24

28 May '24

Fixes Clang warning on 32-bit platforms. Clang is more strict about `-Wformat` than GCC. For `%I`, it expects the exact `size_t` type, which is `int` on 32-bit targets, while `SIZE_T` is `long`. For that reason, we currently disable those warnings by not using format attribute on MSVC targets. This is not enough for printf, which is a builtin and has the attribute applied anyway. Using trace, like we do in all other cases, "fixes" it. I plan to make clang less strict about those cases, which would also fix this problem and allow us to enable format attribute in all relevant functions. However, on current versions of clang, this is one of the last few blockers to support `-Werror`, so it would be nice to have it fixed one way or another. If `printf` is preferred here for some reason, we could also just add an explicit `size_t` cast when printing the size. -- v2: d3dx9/tests: Remove xfile dumping functionality. https://gitlab.winehq.org/wine/wine/-/merge_requests/5629

3 4

[PATCH 0/1] MR5629: d3dx9/tests: Use trace instead of printf.
by Jacek Caban (＠jacek) 28 May '24

28 May '24

Fixes Clang warning on 32-bit platforms. Clang is more strict about `-Wformat` than GCC. For `%I`, it expects the exact `size_t` type, which is `int` on 32-bit targets, while `SIZE_T` is `long`. For that reason, we currently disable those warnings by not using format attribute on MSVC targets. This is not enough for printf, which is a builtin and has the attribute applied anyway. Using trace, like we do in all other cases, "fixes" it. I plan to make clang less strict about those cases, which would also fix this problem and allow us to enable format attribute in all relevant functions. However, on current versions of clang, this is one of the last few blockers to support `-Werror`, so it would be nice to have it fixed one way or another. If `printf` is preferred here for some reason, we could also just add an explicit `size_t` cast when printing the size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5629

4 3

[PATCH v35 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v35: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

4 18

[PATCH 0/2] MR5625: Fixes for GCC 14 warnings (in winedump)
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

The `-Wstringop-overread` fix feels a bit questionable (so I'll add Eric as a reviewer to clarify the MSC structs details) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5625

4 7

[PATCH v2 0/5] MR5601: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES)
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

This MR improves the handling of numpad keys for drivers using KBDTABLES (only the Wayland driver at this point). It achieves this by: 1. Allowing drivers to send only the scancode in keyboard events, with win32u performing the scan->vkey mapping internally. A nice side effect of this change is that it fixes a few user32 input test TODOs. 2. Enhancing wineserver to read extended KBD vkey attributes and perform numpad key mapping depending on modifier state. 3. Providing default VK_NUMPAD* -> WCHAR mappings in win32u. -- v2: winewayland.drv: Populate vkey to wchar entry for VK_DECIMAL. server: Send numpad virtual keys if NumLock is active. win32u: Store the full KBD vkey information in kbd_tables_init_vsc2vk. win32u: Allow drivers to send only the scan code for keyboard events. https://gitlab.winehq.org/wine/wine/-/merge_requests/5601

4 12

[PATCH 0/1] MR5624: po: Add a missing \t in the Simplified Chinese translation.
by Hongxin Zhao (＠zhaohongxin) 28 May '24

28 May '24

Align the Chinese text output of wine cmd before: ![before.png](/uploads/aed02f6947ef757cac0c335aed48104f/before.png) after: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5624

4 3

[PATCH v2 0/4] MR5609: Rewrite of cmd command engine (part III).
by eric pouech (＠epo) 28 May '24

28 May '24

This is the third serie related to rewriting cmd's command engine. Currently, cmd stores block of commands as a linked list of CMD_LIST. Even for nested commands (like 'if' command inside a 'for' command), it's parsed as a single list of commands, using a 'depth' attribute and marker for end of block to describe the structure. This leads to several issues: - parsing for nested commands is not 100% robust, - chaining of commands (and its precedence) is not handled, - no separation between parsing and execution (esp. for 'IF' and 'FOR' commands, which behave slightly differently than regular commands when dealing with variables with delayed expansion), - data model doesn't 100% fit native behavior (eg redirections can apply to a block of commands, whereas redirections are attached to individual commands) - ... The final goal is to replace this with: - a tree of commands: + binary nodes for command chaining, + 'IF' and 'FOR' commands being parsed and stored as such + leaf being a command It will require a couple more series to reach that goal, so this series puts in place the basic building bits: - introducing a new structure CMD_NODE to hold that each node of such a tree, - moving the chaining operator into that CMD_NODE (meaning that we move from a linked list to a binary tree degenerated into a list: left is command, right is next node). -- v2: programs/cmd: Move operator from CMD_COMMAND to CMD_NODE. programs/cmd: Add helpers to handle list in degenerated binary tree. programs/cmd: Introduce CMD_NODE structure. programs/cmd: Remove malloc attribute from xrealloc. https://gitlab.winehq.org/wine/wine/-/merge_requests/5609

3 6

[PATCH 0/1] MR5621: Update zh_CN.po to align output text
by Hongxin Zhao (＠zhaohongxin) 28 May '24

28 May '24

The original help info of MKLINK lacks **\\t** which makes the output text of wine cmd not fully aligned. ![before](/uploads/659f487299f8b25ab4211e111323a5c3/before.png){width="587" height="330"} ![after](/uploads/0c3a6b7dc1a5326555fe033fdf522953/after.png){width="586" height="330"} -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5621

3 5

Re: [PATCH v3 0/4] MR5612: d3d9/tests: Various tests related to vertex declarations.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

I've noticed for some time that my merge requests are intermittently not getting assigned to Jan. This is one example. @julliard, is there anything that can be done about this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5612#note_70212

1 0

Re: [PATCH v3 0/4] MR5612: d3d9/tests: Various tests related to vertex declarations. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5612

1 0

Re: [PATCH v2 0/5] MR5617: gdiplus: Removing gdi32 objects from gdiplus objects. (part 2) - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5617

1 0

Re: [PATCH v2 0/1] MR5620: winevulkan: Update to VK spec version 1.3.285. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5620

1 0

Re: [PATCH v2 0/11] MR5614: mfplat: Test and support FORMAT_MPEGVideo and FORMAT_MPEG2Video. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5614

1 0

Re: [PATCH v22 0/3] MR4243: rtworkq: free cancelled work items - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

1 0

Re: [PATCH v3 0/1] MR5608: winex11.drv: Increment mode_idx in xrandr10_get_modes. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5608

1 0

Re: [PATCH v3 0/1] MR5603: win32u: Update last message time in NtUserGetRawInputBuffer(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5603

1 0

Re: [PATCH v2 0/1] MR5542: win32u: Enable dibdrv wglDescribePixelFormat through p_get_pixel_formats. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5542

1 0

Re: [PATCH v2 0/2] MR5610: d2d1/tests: Add a test for effect output image interface query. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5610

1 0

Re: [PATCH v3 0/1] MR5599: msvcrt/tests: Add tests for _wcsicmp_l. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5599

1 0

Re: [PATCH v2 0/5] MR5606: wined3d: Remove code related to backbuffer ORM. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5606

1 0

Re: [PATCH v2 0/1] MR5605: winemac.drv: Fix warning in macdrv_get_pixel_formats. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5605

1 0

Re: [PATCH v2 0/1] MR5595: bcrypt: Support RSA/PKCS1 signatures with unspecified hash algorithm. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5595

1 0

Re: [PATCH v2 0/4] MR5600: Second part of cmd engine rewrite.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

Brendan Shanks (@bshanks) commented about programs/cmd/wcmd.h: > void WCMD_execute (const WCHAR *orig_command, const WCHAR *redirects, > CMD_LIST **cmdList, BOOL retrycall); > > -void *xalloc(size_t) __WINE_ALLOC_SIZE(1) __WINE_DEALLOC(free) __WINE_MALLOC; > +void *xrealloc(void *, size_t) __WINE_ALLOC_SIZE(2) __WINE_DEALLOC(free) __WINE_MALLOC; `realloc` should not use `__WINE_MALLOC`/`attribute((malloc))`. From [the docs](https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html): "functions like realloc do not have this property, as they may return pointers to storage containing pointers to existing objects" -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5600#note_70159

1 0

[PATCH v21 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

-- v21: rtworkq: Release cancelled work items. mfplat/tests: Validate MFCancelWorkItem releases the callback. rtworkq: Avoid use-after-free. https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

4 7

[PATCH 0/11] MR5614: mfplat: Test and support FORMAT_MPEGVideo and FORMAT_MPEG2Video.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5614

3 12

[PATCH 0/5] MR5601: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES)
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

This MR improves the handling of numpad keys for drivers using KBDTABLES (only the Wayland driver at this point). It achieves this by: 1. Allowing drivers to send only the scancode in keyboard events, with win32u performing the scan->vkey mapping internally. A nice side effect of this change is that it fixes a few user32 input test TODOs. 2. Enhancing wineserver to read extended KBD vkey attributes and perform numpad key mapping depending on modifier state. 3. Providing default VK_NUMPAD* -> WCHAR mappings in win32u. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5601

4 8

[PATCH v2 0/1] MR5603: win32u: Update last message time in NtUserGetRawInputBuffer().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v2: win32u: Update last message time in NtUserGetRawInputBuffer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5603

4 3

[PATCH v2 0/2] MR5611: winegstreamer: Recognize MFAudioFormat_MPEG and MFAudioFormat_MP3.
by Anton Baskanov (＠baskanov) 28 May '24

28 May '24

Fixes: 067d4f047247b39a5866c1d7b22b5f16b5187d5b -- v2: winegstreamer: Add missing format fields to WMA support check. https://gitlab.winehq.org/wine/wine/-/merge_requests/5611

2 3

[PATCH v2 0/1] MR5608: winex11.drv: Increment mode_idx in xrandr10_get_modes.
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

This fixes a regression introduced in: f74900ad1a580eda8fd4923cbd4881b42b042733 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56655 -- v2: winex11.drv: Increment mode_idx in {xrandr10,xf86vm}_get_modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/5608

3 3

Re: [PATCH v2 0/8] MR5607: Link strmbase modules to msvcrt instead of ucrtbase.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

I thought some Windows modules are built against ucrtbase? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5607#note_70072

1 0

Re: [PATCH v2 0/8] MR5607: Link strmbase modules to msvcrt instead of ucrtbase.
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Not directly related to this MR, but maybe we could switch all modules to msvcrt, like Windows does it? I'm probably missing a point as to why we deliberately differ in this aspect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5607#note_70068

1 0

[PATCH v2 0/1] MR5599: msvcrt/tests: Add tests for _wcsicmp_l.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

-- v2: msvcrt/tests: Add tests for _wcsicmp_l. https://gitlab.winehq.org/wine/wine/-/merge_requests/5599

3 3

[PATCH v2 0/3] MR5578: Draft: msvcp140_atomic_wait: Partially implement __std_tzdb functions.
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

OpenImageViewer requires all of these functions for the file information menu to work. This implementation references the open-source (Apache 2.0) STL code: https://github.com/microsoft/STL/blob/main/stl/src/tzdb.cpp -- v2: msvcp140_atomic_wait/tests: Add tests for the __std_tzdb functions. msvcp140_atomic_wait: Partially implement __std_tzdb_*_leap_seconds(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5578

3 7

[PATCH 0/1] MR5542: win32u: Enable dibdrv wglDescribePixelFormat through p_get_pixel_formats.
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5542

3 2

[PATCH 0/5] MR5606: wined3d: Remove code related to backbuffer ORM.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5606

3 6

[PATCH 0/1] MR5608: winex11.drv: Increment mode_idx in xrandr10_get_modes.
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

This fixes a regression introduced in: f74900ad1a580eda8fd4923cbd4881b42b042733 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56655 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5608

3 2

[PATCH 0/1] MR5595: bcrypt: Support RSA/PKCS1 signatures with unspecified hash algorithm.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Apex Legends now depends on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5595

4 3

[PATCH 0/1] MR5605: winemac.drv: Fix warning in macdrv_get_pixel_formats.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

Fix a warning introduced with fbf81662ba5b861e52a15c103cfe36a585f718dd: ``` ../dlls/winemac.drv/opengl.c:4605:54: warning: incompatible pointer types passing 'struct wgl_pixel_format *' to parameter of type 'PIXELFORMATDESCRIPTOR *' (aka 'struct tagPIXELFORMATDESCRIPTOR *') [-Wincompatible-pointer-types] describe_pixel_format(&pixel_formats[i], &formats[i]); ^~~~~~~~~~~ ../dlls/winemac.drv/opengl.c:4306:82: note: passing argument to parameter 'descr' here static void describe_pixel_format(const pixel_format *pf, PIXELFORMATDESCRIPTOR *descr) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5605

3 2

[PATCH v4 0/1] MR5509: Add tests to MF Media Engine
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

This MR adds two tests for additional test coverage in preparation of an update to MF Media Engine to use a dedicated Video Sink instead of the Sample Grabber -- v4: mfmediaengine/tests: Add test for audio only. https://gitlab.winehq.org/wine/wine/-/merge_requests/5509

3 3

Re: [PATCH v2 0/1] MR5602: user32/tests: Offset child CS_PARENTDC window from parent to make more bugs visible. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5602

1 0

Re: [PATCH v2 0/4] MR5600: Second part of cmd engine rewrite. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5600

1 0

Re: [PATCH v2 0/1] MR5596: msvcrt/tests: Add result for Turkish_Türkiye.1254. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5596

1 0

Re: [PATCH v2 0/1] MR5598: maintainers: Change the full form of my name. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5598

1 0

Re: [PATCH v2 0/1] MR5597: winegstreamer/video_decoder: Make output_plane_align specific to h264. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5597

1 0

Re: [PATCH v2 0/3] MR5558: winegstreamer: Introduce new check_(audio|video)_transform_support helpers. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5558

1 0

Re: [PATCH v4 0/1] MR5589: ntdll: Don't restore PC from LR after unwinding through frame switches. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5589

1 0

Re: [PATCH v8 0/4] MR5459: mfreadwrite: Implement D3D awareness support with the video processor. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5459

1 0

Re: [PATCH v2 0/5] MR5593: gdiplus: Start bracketing Graphics HDC uses. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5593

1 0

2025

2024

2023

2022

wine-gitlab