- wine-gitlab - winehq.org

[PATCH 0/1] MR5598: maintainers: Change the full form of my name.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

For those concerned, this only reflects the full form of my name, which I use for contributions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5598

3 4

[PATCH 0/1] MR5599: msvcrt/tests: Add tests for _wcsicmp_l.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5599

3 2

[PATCH 0/1] MR5596: msvcrt/tests: Add result for Turkish_Türkiye.1254.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

ran into these on one of my machines: https://test.winehq.org/data/a27b95511be1cb6076b4a91027d14dd139ba3744/win22… https://test.winehq.org/data/a27b95511be1cb6076b4a91027d14dd139ba3744/win22… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5596

3 2

[PATCH 0/1] MR5597: winegstreamer/video_decoder: Make output_plane_align specific to h264.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

If we set output align to wmv decoder, it will fail at copy_video_buffer(). The output size will larger than the sample we provided due to alignment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5597

3 3

[PATCH 0/4] MR5585: Arek Hiler's avatar mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Arek Hiler (＠ivyl) 28 May '24

28 May '24

This is based on work done by Andrew Eikum. It has been in some form in Proton for the last 4 years. If server's sampling rate is not 48kHz **DOOM Eternal** will try to set it 48kHz for the streams using the implemented interface. There's a whole class of audio devices that use 44.1kHz sampling rate and at least PulseAudio / PipeWire tends to inherit the value from the hardware to avoid resampling. The value can also be overridden by the user via the audio server's config files. In such cases, if the interface is not present or stubbed, this results in **audio underruns and noticeable crackling**. It's easy to test with pipewire-pulse: ``` $ cat /etc/pipewire/pipewire.conf.d/sample-rate.conf context.properties = { default.clock.rate = 41100 } ``` With PulseAudio this should be doable via setting `default-sample-rate = 41100` in `/etc/pulse/daemon.conf`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585

4 10

[PATCH 0/1] MR5588: xaudio2: Use FAudioVoice_DestroyVoiceSafeEXT() in destroy_voice().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5588

3 3

Re: [PATCH v2 0/5] MR5592: Rewrite of cmd.exe's command engine (part I) - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5592

1 0

Re: [PATCH v2 0/1] MR5591: winecrt0: Support __os_arm64x_dispatch_call symbol on ARM64EC. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5591

1 0

Re: [PATCH v5 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430

1 0

Re: [PATCH v3 0/2] MR5579: win32u: Write / read available display modes as a single binary blob. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5579

1 0

Re: [PATCH v3 0/5] MR5570: win32u: Some more refactor in preparation for vulkan-only GPU enumeration. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5570

1 0

Re: [PATCH v2 0/1] MR5590: kernelbase: Add support for FileDispositionInfoEx to SetFileInformationByHandle(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5590

1 0

Re: [PATCH v4 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

1 0

Re: [PATCH v3 0/1] MR5553: wined3d: Fix GLSL version comparison. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5553

1 0

[PATCH v4 0/1] MR4418: cmd: Delay variable substitution until after the if clause is parsed.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55859 -- v4: cmd: Delay variable substitution until after the if clause is parsed. https://gitlab.winehq.org/wine/wine/-/merge_requests/4418

3 2

Re: [PATCH v4 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection. - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430

1 0

Re: [PATCH v4 0/2] MR2724: wined3d: Submit command buffers that are built for longer than 2 ms. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2724

1 0

[PATCH v2 0/10] MR5573: win32u: Implement vulkan child / other process surface rendering for winex11.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

I'm not completely sure about the mechanism, but I think it's simple enough to consider having that upstream now. This shows at least how we can leverage win32u surface changes to decide to switch surfaces on/off-screen and fallback to manual blitting. Having the surfaces on-screen makes sure they are presented as efficiently as possible, having them off-screen we use GDI blit to indirectly call XCopyArea and this will be suboptimal, probably with visible tearing, but hopefully not too common. -- v2: win32u: Use GDI blit to implement partial or other process presentation. winex11: Return an offscreen HDC from vulkan_surface_detach. win32u: Pass a HDC parameter to vulkan_surface_detach. winex11: Create a window surface even when there is client window. winex11: Also attach child client windows to their toplevel window. win32u: Make sure vulkan windows have a pixel format selected. win32u: Detach vulkan surfaces that aren't fully visible. win32u: Detach vulkan surfaces that are offscreen or for another process. win32u: Move vulkan surfaces to their new parent when reparenting. win32u: Introduce a new vulkan offscreen surfaces list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5573

5 19

[PATCH v2 0/5] MR5570: win32u: Some more refactor in preparation for vulkan-only GPU enumeration.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

In order to implement the patch discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5491#note_67907 -- v2: win32u: Return STATUS_ALREADY_COMPLETE from UpdateDisplayDevices. win32u: Pass gdi_gpu structure members as add_gpu parameters. win32u: Remove driver-specific id from struct gdi_gpu. win32u: Use struct pci_id in struct gdi_gpu. win32u: Remove now unnecessary reset_display_manager_ctx. https://gitlab.winehq.org/wine/wine/-/merge_requests/5570

3 8

[PATCH v2 0/2] MR5579: win32u: Write / read available display modes as a single binary blob.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Reduces the time needed to write them from 20ms to 2ms and to read them from 10ms to 1ms, as well as reducing the number of wineserver requests by a lot. -- v2: win32u: Read / write source modes as a single registry blob. winex11: Only request display modes driver data when needed. https://gitlab.winehq.org/wine/wine/-/merge_requests/5579

3 7

[PATCH 0/1] MR5586: configure: Test PE compilers after setting their target argument.
by Billy Laws (＠bylaws) 28 May '24

28 May '24

clang will default to the host if no target is specified, which causes compile test failures if arch-specific CFLAGS are used for a non-host arch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5586

3 2

[PATCH v2 0/1] MR5553: wined3d: Fix GLSL version comparison.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- v2: wined3d: Fix GLSL version comparison. https://gitlab.winehq.org/wine/wine/-/merge_requests/5553

5 4

[PATCH v3 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

This fixes a regression introduced by 15d53761a5fbfc12fc5f9974c029dace00eab33d. -- v3: ddraw/tests: Test GetVertexBufferDesc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

5 7

[PATCH 0/2] MR5579: win32u: Write / read available display modes as a single binary blob.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Reduces the time needed to write them from 20ms to 2ms and to read them from 10ms to 1ms, as well as reducing the number of wineserver requests by a lot. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5579

3 5

[PATCH 0/5] MR5570: win32u: Some more refactor in preparation for vulkan-only GPU enumeration.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

In order to implement the patch discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5491#note_67907 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5570

4 8

[PATCH v3 0/2] MR2724: wined3d: Submit command buffers that are built for longer than 2 ms.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

This improves performance for the game "Grounded", on a AMD Radeon RX 6700 XT, with radv from Mesa 22.3.6. Testing was done with the "cb_access_map_w" option enabled, which also improves performance with the game by itself. From my testing, it's possible to raise the threshold from 2 ms up to 5 ms or so, before the driver or GPU seems to reclock back to the lower power level. However, this measurement is questionable for several reasons. It seems to vary depending on the scene being rendered, and of course this will be specific to the game and driver and GPU in question anyway. The game also has a weird approach to vsync that seems to involve it presenting stale frames (and hence artificially inflating the FPS), which I'm not fully sure I accounted for while measuring. And of course, it's hard to be sure that 5 ms is actually the threshold for how long the driver will go before powering down the GPU. In any case, it seems better to err on the side of submitting more often, to make sure the fix affects more drivers. While submission isn't cheap, it seems to me that submitting every 2 ms is unlikely to cause a bottleneck [consider that this is at most 8 (more) submissions per frame]. The maximum of 4 concurrent periodically submitted buffers was chosen arbitrarily. Removing the maximum altogether does not measurably affect performance for this game either way. Credit goes to Philip Rebohle and his work on DXVK for helping me to notice that periodic submission might make a difference. -- v3: wined3d: Submit command buffers after 512 draw or dispatch commands. wined3d: Retrieve the VkCommandBuffer from wined3d_context_vk after executing RTV barriers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2724

4 4

[PATCH v3 0/1] MR5589: ntdll: Don't restore PC from LR after unwinding through frame switches.
by Billy Laws (＠bylaws) 28 May '24

28 May '24

Fixes unwinds from within a consolidation callback on ARM64EC, as the context frame could be x64 with UNWOUND_TO_CALL set, in which case LR contains garbage. See: https://github.com/dotnet/runtime/blob/71abc26cf8f14f5d15665d7f580365ddfa29… -- v3: ntdll: Don't restore PC from LR after unwinding through frame switches. https://gitlab.winehq.org/wine/wine/-/merge_requests/5589

2 2

Re: [PATCH v2 0/1] MR5580: ntdll/unix: Fix building on musl by explicitly including asm/ioctls.h
by Fotios Valasiadis (＠fvalasiad) 28 May '24

28 May '24

@zfigura Whoops, my bad! I see Alexandre fixed it for me, thanks! Best of luck! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5580#note_69737

1 0

[PATCH v3 0/10] MR5559: include: Fix another 13 typoed GUIDs
by Alfred Agrell (＠Alcaro) 28 May '24

28 May '24

Same bug class as https://gitlab.winehq.org/wine/wine/-/merge_requests/5550. None of them are referenced by anything (not counting mfplat/main.c's debugstr_attr(), which names the two in mfapi.h - better debug output, yay I guess). -- v3: include: Fix a typoed GUID include: Fix a typoed GUID include: Fix two typoed GUIDs include: Fix two typoed GUIDs include: Fix two typoed GUIDs include: Fix a typoed GUID include: Fix a typoed GUID include: Fix a typoed GUID include: Fix a typoed GUID include: Fix a typoed GUID https://gitlab.winehq.org/wine/wine/-/merge_requests/5559

3 13

Re: [PATCH v2 0/1] MR5587: ntdll: Allocate wow64 environment block within the 32-bit AS. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5587

1 0

Re: [PATCH v2 0/1] MR5581: include: Fix name conflict with access modifier in mfmediaengine.idl. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5581

1 0

[PATCH 0/1] MR5580: ntdll/unix: Fix building on musl by explicitlyy including asm/ioctls.h
by Fotios Valasiadis (＠fvalasiad) 28 May '24

28 May '24

After commit 898ab8dab19d498c17859f39a55e317ee7e367a5 wine would no longer build on musl. Issue is that apparently TCSETS2 isn't defined when including sys/ioctl.h. A little digging shows that glibc goes ahead and includes asm/ioctls.h in sys/ioctl.h, providing said macro. Musl on the other hand doesn't and relies on bits/ioctl.h, which lacks said macro. Since there is no mention in the manpage about the need to include asm/ioctls.h, uncertain if that's an issue with musl or the manpage, would like some help on that front so I can go open PRs to fix that respectively. Signed-off-by: Fotios Valasiadis <fvalasiad(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5580

3 3

Re: [PATCH v2 0/1] MR5580: ntdll/unix: Fix building on musl by explicitly including asm/ioctls.h - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5580

1 0

[PATCH v34 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v34: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 16

[PATCH 0/1] MR5583: explorer: Fallback to wayland when x11 fails.
by Etaash Mathamsetty (＠etaash.mathamsetty) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5583

2 2

[PATCH v2 0/1] MR5070: win32u: Cache is_virtual_desktop.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

It can be substantially faster in some cases. Notepad++ (with several plugins) start up goes down from around ~1.03 sec to ~0.61 sec on my machine (with wineprefix active). 9b7669592d6f8b40976b571b70f8543777d35167 is what introduced this performance regression. I don't know why exactly, but it made my Notepad++ noticeably slower when launched from a file manager (so it's not just at wineprefix startup overhead), which is very annoying. -- v2: win32u: Cache is_virtual_desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5070

3 7

Re: [PATCH v2 0/2] MR5576: winex11: Avoid leaking foreign window data if it was already created. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5576

1 0

Re: [PATCH v2 0/2] MR5555: mf/tests: Add some broken tests results. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5555

1 0

Re: [PATCH v2 0/1] MR5575: winex11: Don't call x11drv_xinput2_disable for foreign windows. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5575

1 0

Re: [PATCH v3 0/1] MR5577: winhttp: Use GlobalAlloc to allocate lpszProxy in WinHttpGetProxyForUrl. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5577

1 0

Re: [PATCH v4 0/1] MR5562: wined3d: Added missing GTX 3080 & 1070M - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5562

1 0

Re: [PATCH v2 0/1] MR5572: winemac.drv: Fix use-after-free in macdrv_copy_pasteboard_types. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5572

1 0

[PATCH v2 0/1] MR5577: winhttp: Use GlobalAlloc to allocate lpszProxy in WinHttpGetProxyForUrl.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- v2: winhttp: Use GlobalAlloc to allocate lpszProxy in WinHttpGetProxyForUrl. https://gitlab.winehq.org/wine/wine/-/merge_requests/5577

3 3

[PATCH v6 0/4] MR5459: mfreadwrite: Implement D3D awareness support with the video processor.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v6: mfreadwrite/reader: Pass the device manager to the stream transforms. winegstreamer/video_processor: Implement D3D awareness. mf/tests: Test video processor D3D11 awareness. mfreadwrite/tests: Add some source reader D3D11 awareness tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5459

2 5

[PATCH 0/1] MR5577: winhttp: Use GlobalAlloc to allocate lpszProxy in WinHttpGetProxyForUrl.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5577

3 3

[PATCH 0/10] MR5573: win32u: Implement vulkan child / other process surface rendering for winex11.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

I'm not completely sure about the mechanism, but I think it's simple enough to consider having that upstream now. This shows at least how we can leverage win32u surface changes to decide to switch surfaces on/off-screen and fallback to manual blitting. Having the surfaces on-screen makes sure they are presented as efficiently as possible, having them off-screen we use GDI blit to indirectly call XCopyArea and this will be suboptimal, probably with visible tearing, but hopefully not too common. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5573

4 13

[PATCH v4 0/2] MR2120: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications
by Evan Tang (＠etang-cw) 28 May '24

28 May '24

This seems to be relied on by some versions of [this Unreal Engine input plugin](https://www.unrealengine.com/marketplace/en-US/product/wm-input-man… Note: I'm not sure how to deal with `HID_USAGE_GENERIC_KEYPAD`, which (I think) would fall under `RIM_TYPEKEYBOARD`. Do we need to store extra info to differentiate these from `HID_USAGE_GENERIC_KEYBOARD` or is there something in the device info struct that can differentiate them? -- v4: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications user32: Add tests for WM_INPUT_DEVICE_CHANGE messages https://gitlab.winehq.org/wine/wine/-/merge_requests/2120

3 4

[PATCH 0/3] MR5383: oleaut32: Load bitmap as DIB.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5383

3 8

[PATCH 0/1] MR5572: winemac.drv: Fix use-after-free in macdrv_copy_pasteboard_types.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

ObjC dictionary literals are autoreleased, meaning BitmapOutputTypeMap was released at the end of the first call to macdrv_copy_pasteboard_types. Any call after that was liable to crash, depending on whether it was overwritten. More complex objects on the clipboard (like a file copied in the Finder) seemed to trigger a crash, which manifested as explorer.exe taking 100% of CPU (since the main thread crashed, then the SEGV handler crashed because it's not a Wine thread). Fixes a regression from bb2e02ab66c5c602d635722cf3a5820d6b366006. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5572

3 4

[PATCH v3 0/1] MR5523: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW().
by Vijay Kiran Kamuju (＠infyquest) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56576 -- v3: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5523

2 2

[PATCH v3 0/1] MR5333: vcruntime140_1: Pass original frame to catch block on stack.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56451 local variables with alignas(32) or higher may cause the unwinding code to fetch the original frame from a different spot on the stack from where the catch block code places it -- v3: vcruntime140_1: Pass original frame to catch block on stack. https://gitlab.winehq.org/wine/wine/-/merge_requests/5333

3 3

Re: [PATCH v2 0/5] MR5571: win32u: Post device arrival messages in NtUserRegisterRawInputDevices. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5571

1 0

Re: [PATCH v3 0/1] MR5568: windowscodecs: Avoid implicit cast changing value. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5568

1 0

Re: [PATCH v2 0/1] MR5565: msvcp140_atomic_wait: Implement __std_*_crt(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5565

1 0

Re: [PATCH v2 0/1] MR5569: win32u: Fix corrupted list in vulkan_detach_surfaces. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5569

1 0

Re: [PATCH v2 0/1] MR5566: pdh: Add PdhConnectMachineA stub. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5566

1 0

Re: [PATCH v12 0/3] MR5060: win32u, explorer, winex11.drv: Restore display settings on process exit. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5060

1 0

Re: [PATCH v2 0/1] MR5567: shell32: Add SHAssocEnumHandlersForProtocolByApplication stub. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5567

1 0

[PATCH v2 0/1] MR5568: windowscodecs: Avoid implicit cast changing value.
by Alistair Leslie-Hughes (＠alesliehughes) 28 May '24

28 May '24

This appear to be introduced with commit 12f73ed9d851. When This->stride is negative (bottom up image) it converts the multiplication to an UINT. Thus causing the pointer to be incorrect when y > 0. -- v2: windowscodecs: Avoid implicit cast changing value. https://gitlab.winehq.org/wine/wine/-/merge_requests/5568

5 4

[PATCH 0/5] MR5571: win32u: Post device arrival messages in NtUserRegisterRawInputDevices.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Superseding https://gitlab.winehq.org/wine/wine/-/merge_requests/2120 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5571

4 7

[PATCH 0/1] MR5569: win32u: Fix corrupted list in vulkan_detach_surfaces.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5569

3 2

[PATCH 0/1] MR5565: msvcp140_atomic_wait: Implement __std_*_crt().
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

OpenImageViewer also requires some __std_tzdb functions to make the image properties menu work (but that is for another MR). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5565

4 3

[PATCH 0/1] MR5568: windowscodecs: Avoid implicit cast changing value.
by Alistair Leslie-Hughes (＠alesliehughes) 28 May '24

28 May '24

This appear to be introduced with commit 12f73ed9d851. When This->stride is negative (bottom up image) it converts the multiplication to an UINT. Thus causing the pointer to be incorrect when y > 0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5568

3 2

[PATCH 0/5] MR5564: mmdevapi: Adjust timing in AudioClient_Initialize, removing related code from drivers.
by Davide Beatrici (＠davidebeatrici) 28 May '24

28 May '24

Trace output with PulseAudio: ``` 0230:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0230:trace:mmdevapi:adjust_timing Device periods: 100000 default and 30000 minimum 0230:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5564

2 6

Re: [PATCH v4 0/5] MR5551: win32u: Get rid of most drivers vulkan surface wrappers. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5551

1 0

Re: [PATCH v3 0/1] MR5563: mshtml: Move iface_wrapper_t IUnknown implementation to htmlobject.c. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5563

1 0

Re: [PATCH v6 0/2] MR5547: msvcrt: Implement _mbsncpy_s[_l](). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5547

1 0

Re: [PATCH v3 0/1] MR5540: wined3d: Added missing GTX 1650 - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5540

1 0

Re: [PATCH v3 0/1] MR5494: ntdll: Implement NtQuerySystemInformation( SystemProcessIdInformation ). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5494

1 0

Re: [PATCH v4 0/2] MR5560: winegstreamer: Fix wow64 support for wg_parser_connect - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5560

1 0

Re: [PATCH v10 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

1 0

Re: [PATCH v2 0/1] MR5540: wined3d: Added missing GTX 1650 - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5540

1 0

Re: [PATCH v4 0/3] MR5535: advapi32: CryptSetKeyParam() should accept NULL pbData. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5535

1 0

[PATCH 0/1] MR5562: wined3d: Added missing GTX 3080 & 1070M
by Johnson Peter (＠peterjc123) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5562

3 2

[PATCH v5 0/2] MR5547: msvcrt: Implement _mbsncpy_s[_l]().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

ucrtbase._mbsncpy_s is used by Marvel vs Capcom when trying to create multiplayer lobby. The functions are also present in msvcrt (unlike msvcr70, msvcr71) where I didn't add it because it behaves differently: there is at least one weirdness when it doubles the number of characters to copy ('n' parameter, not buffer size). I suppose we don't need to explore and deal with this specific until something needs those functions from msvcrt. -- v5: msvcrt: Implement _mbsncpy_s[_l](). https://gitlab.winehq.org/wine/wine/-/merge_requests/5547

4 5

[PATCH v3 0/5] MR5551: win32u: Get rid of most drivers vulkan surface wrappers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v3: winex11: Remove now unnecessary surface wrapper struct. win32u: Move thread detach from winex11. win32u: Introduce a per-window vulkan surface list. winewayland: Get rid of the now unnecessary surface wrapper. win32u: Return the host surface directly from vulkan_surface_create. https://gitlab.winehq.org/wine/wine/-/merge_requests/5551

4 8

Re: [PATCH v2 0/1] MR5549: winegstreamer/wg_parser: add wow64 func for wg_parser_connect
by Johnson Peter (＠peterjc123) 28 May '24

28 May '24

Included in https://gitlab.winehq.org/wine/wine/-/merge_requests/5560. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5549#note_69336

1 0

Re: [PATCH v9 0/3] MR5400: shell32: Tying up some loose ends
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

On Wed May 1 00:08:18 2024 +0000, Alistair Leslie-Hughes wrote: > That's really not a solution. This was working without issues for many > years. So, forcing our users to upgrade our product isn't always an option. > Also, how backward compatible is that solution going to be? We still > have users on *cough* wine 5, will it work for them? Can you tell me what the actual use case is? I believe the bug report is about `start.exe`, which this MR should fix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5400#note_69335

1 0

Re: [PATCH v2 0/1] MR5549: winegstreamer/wg_parser: add wow64 func for wg_parser_connect - closed
by Johnson Peter (＠peterjc123) 28 May '24

28 May '24

This merge request was closed by Johnson Peter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5549

1 0

[PATCH v9 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v9: win32u: Introduce a new add_virtual_modes helper. winex11: Let win32u decide when to force update the display cache. win32u: Don't force refresh the display cache on thread desktop change. winex11: Report all sources as detached in virtual desktop mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

3 5

[PATCH 0/1] MR5559: include: Fix another 13 typoed GUIDs
by Alfred Agrell (＠Alcaro) 28 May '24

28 May '24

Same bug class as https://gitlab.winehq.org/wine/wine/-/merge_requests/5550. None of them are referenced by anything (not counting mfplat/main.c's debugstr_attr(), which names the two in mfapi.h - better debug output, yay I guess). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5559

4 5

Re: [PATCH v33 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos. - approved
by Huw Davies (＠huw) 28 May '24

28 May '24

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

1 0

[PATCH 0/1] MR5556: msvcr80/tests: Fix errno access in tests.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5556

2 3

[PATCH v4 0/2] MR5547: msvcrt: Implement _mbsncpy_s[_l]().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

ucrtbase._mbsncpy_s is used by Marvel vs Capcom when trying to create multiplayer lobby. The functions are also present in msvcrt (unlike msvcr70, msvcr71) where I didn't add it because it behaves differently: there is at least one weirdness when it doubles the number of characters to copy ('n' parameter, not buffer size). I suppose we don't need to explore and deal with this specific until something needs those functions from msvcrt. -- v4: msvcrt: Implement _mbsncpy_s[_l](). https://gitlab.winehq.org/wine/wine/-/merge_requests/5547

4 5

[PATCH v3 0/3] MR5535: advapi32: CryptSetKeyParam() should accept NULL pbData.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

At least CryptSetKeyParam(KP_X) should accept NULL pbData. -- v3: advapi32: CryptSetKeyParam() should accept NULL pbData. rsaenh: Validate pbData in CPSetKeyParam(). dssenh: Add CPSetKeyParam() stub implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5535

4 6

[PATCH v2 0/3] MR5535: advapi32: CryptSetKeyParam() should accept NULL pbData.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

At least CryptSetKeyParam(KP_X) should accept NULL pbData. -- v2: advapi32: CryptSetKeyParam() should accept NULL pbData. rsaenh: Validate pbData in CPSetKeyParam(). dssenh: Add CPSetKeyParam() stub implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5535

4 6

[PATCH v8 0/5] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v8: win32u: Introduce a new add_virtual_modes helper. winex11: Let win32u decide when to force update the display cache. win32u: Don't force refresh the display cache on thread desktop change. winex11: Report all sources as detached in virtual desktop mode. win32u: Set the virtual desktop display frequency to 60Hz. https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

4 8

Re: [PATCH v9 0/3] MR5400: shell32: Tying up some loose ends
by Alistair Leslie-Hughes (＠alesliehughes) 28 May '24

28 May '24

On Wed Apr 24 13:55:44 2024 +0000, Yuxuan Shui wrote: > Like I said, you need to call `ShellExecute( NULL, NULL, "linuxbinary.", > "1", "C:\Temp\Application\linux", SW_SHOW);`, which is how `start.exe` > would be doing. That's really not a solution. This was working without issues for many years. So, forcing our users to upgrade our product isn't always an option. Also, how backward compatible is that solution going to be? We still have users on *cough* wine 5, will it work for them? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5400#note_69293

1 0

[PATCH v2 0/1] MR5494: ntdll: Implement NtQuerySystemInformation( SystemProcessIdInformation ).
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Should help with Overwatch 2 random crashes after some time of playing. -- v2: ntdll: Implement NtQuerySystemInformation( SystemProcessIdInformation ). https://gitlab.winehq.org/wine/wine/-/merge_requests/5494

3 3

Re: [PATCH v7 0/1] MR5211: ntdll/unix: Use termios2 for serial when possible. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5211

1 0

Re: [PATCH v2 0/1] MR5557: win32u: Set the virtual desktop display frequency to 60Hz. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5557

1 0

Re: [PATCH v9 0/3] MR5400: shell32: Tying up some loose ends - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5400

1 0

Re: [PATCH v2 0/2] MR5552: wineandroid.drv: Enable wglDescribePixelFormat through p_get_pixel_formats. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5552

1 0

Re: [PATCH v2 0/1] MR5554: msi: Install global assemblies after install custom actions and before commit custom actions. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5554

1 0

[PATCH v3 0/2] MR5547: msvcrt: Implement _mbsncpy_s[_l]().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

ucrtbase._mbsncpy_s is used by Marvel vs Capcom when trying to create multiplayer lobby. The functions are also present in msvcrt (unlike msvcr70, msvcr71) where I didn't add it because it behaves differently: there is at least one weirdness when it doubles the number of characters to copy ('n' parameter, not buffer size). I suppose we don't need to explore and deal with this specific until something needs those functions from msvcrt. -- v3: msvcrt: Implement _mbsncpy_s[_l](). msvcr80/tests: Fix errno access in tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5547

5 7

[PATCH v2 0/1] MR5547: msvcrt: Implement _mbsncpy_s[_l]().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

ucrtbase._mbsncpy_s is used by Marvel vs Capcom when trying to create multiplayer lobby. The functions are also present in msvcrt (unlike msvcr70, msvcr71) where I didn't add it because it behaves differently: there is at least one weirdness when it doubles the number of characters to copy ('n' parameter, not buffer size). I suppose we don't need to explore and deal with this specific until something needs those functions from msvcrt. -- v2: msvcrt: Implement _mbsncpy_s[_l](). https://gitlab.winehq.org/wine/wine/-/merge_requests/5547

3 9

[PATCH 0/1] MR5557: win32u: Set the virtual desktop display frequency to 60Hz.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

Fix a regression from ee0aad5c, which changes the virtual desktop display frequency to that of the host display while adding modes of 60Hz. So when the host display is not 60Hz, we might get ChangeDisplaySettings() failures when virtual desktop is on because the target mode is not found because of the frequency difference. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5557

4 4

[PATCH v7 0/5] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v7: win32u: Introduce a new add_virtual_modes helper. winex11: Let win32u decide when to force update the display cache. win32u: Don't force refresh the display cache on thread desktop change. winex11: Report all sources as detached in virtual desktop mode. explorer: Only initialize display settings for attached devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

3 8

[PATCH v2 0/5] MR5551: win32u: Get rid of most drivers vulkan surface wrappers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v2: winex11: Remove now unnecessary surface wrapper struct. win32u: Move thread detach from winex11. win32u: Introduce a per-window vulkan surface list. winewayland: Get rid of the now unnecessary surface wrapper. win32u: Return the host surface directly from vulkan_surface_create. https://gitlab.winehq.org/wine/wine/-/merge_requests/5551

4 7

[PATCH v5 0/4] MR5459: mfreadwrite: Implement D3D awareness support with the video processor.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v5: mfreadwrite/reader: Pass the device manager to the stream transforms. winegstreamer/video_processor: Implement D3D awareness. mf/tests: Test video processor D3D11 awareness. mfreadwrite/tests: Add some source reader D3D11 awareness tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5459

2 5

2025

2024

2023

2022

wine-gitlab