- wine-gitlab - winehq.org

[PATCH v8 0/3] MR5400: shell32: Tying up some loose ends
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

Follow up to !5342. This adds the last missing piece for fixing how `ShellExecute` finds files, and restore the ability of running native unix programs with `ShellExecute` -- v8: shell32: Restore the ability of running native unix programs with ShellExecute https://gitlab.winehq.org/wine/wine/-/merge_requests/5400

3 4

Re: [PATCH v2 0/6] MR5536: mf/tests: Add more video processor tests with aperture changes. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5536

1 0

Re: [PATCH v4 0/6] MR5450: mf/session: Handle and propagate stream format changes. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5450

1 0

Re: [PATCH v2 0/1] MR5533: widl: Use hardcoded build time in TLB custom data. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5533

1 0

Re: [PATCH v5 0/10] MR5508: winegstreamer/video_decoder: Use video_decoder to implement wmv decoder. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5508

1 0

Re: [PATCH v2 0/1] MR5548: windowscodecs: Check for overflow in jpeg_decoder_initialize. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5548

1 0

Re: [PATCH v2 0/1] MR5550: include: Use the correct GUID for DXFILEOBJ_PatchMesh - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5550

1 0

Re: [PATCH v3 0/2] MR5544: Fixes for Wine tests compilation with Visual Studio 10.0 - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5544

1 0

[PATCH 0/4] MR5541: winegstreamer: Expose more aperture attributes for the wmv decoder.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

For https://gitlab.winehq.org/wine/wine/-/merge_requests/5508 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5541

3 7

[PATCH 0/1] MR5550: include: Use the correct GUID for DXFILEOBJ_PatchMesh
by Alfred Agrell (＠Alcaro) 28 May '24

28 May '24

Won't affect any existing program (all PatchMesh related functions are stubs), but could save a bunch of confusion in the future. Could also save some confusion for mingw users, their headers copy plenty of stuff from Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5550

3 2

[PATCH 0/5] MR5551: win32u: Get rid of most drivers vulkan surface wrappers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5551

4 8

[PATCH v7 0/3] MR5400: shell32: Tying up some loose ends
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

Follow up to !5342. This adds the last missing piece for fixing how `ShellExecute` finds files, and restore the ability of running native unix programs with `ShellExecute` -- v7: shell32: Restore the ability of running native unix programs with ShellExecute https://gitlab.winehq.org/wine/wine/-/merge_requests/5400

4 8

[PATCH v32 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v32: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

4 23

[PATCH 0/1] MR5533: widl: Use hardcoded build time in TLB custom data.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

This makes builds reproducible, and matches the current MIDL behavior (except that MIDL's string representation inexplicably varies with the build machine timezone). The new info_string used by WIDL: `Created by WIDL version 9.7 at Tue Jan 19 03:14:07 2038` And the custom data section in a .tlb file created by a recent MIDL: ``` off 0: guid(DE77BA65-517C-11D1-A2DA-0000F8773CE9) value(Created by MIDL version 8.01.0628 at Mon Jan 18 19:14:07 2038) off c: guid(DE77BA63-517C-11D1-A2DA-0000F8773CE9) value(2147483647) off 18: guid(DE77BA64-517C-11D1-A2DA-0000F8773CE9) value(134283892) ``` The only detailed info about this change in MIDL (which happened years ago AFAICT) is from Chromium. They have a script which processes TLB files to compare against previously-built artifacts (or something similar), and mentions the timestamp and timezone: https://chromium.googlesource.com/chromium/src/+/master/build/toolchain/win… They also have a rough Python 2 script to parse/dump TLB files, which is where the above MIDL output comes from: https://chromium-review.googlesource.com/c/chromium/src/+/693223 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5533

4 6

[PATCH 0/2] MR5552: wineandroid.drv: Enable wglDescribePixelFormat through p_get_pixel_formats.
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5552

2 3

[PATCH v3 0/6] MR5450: mf/session: Handle and propagate stream format changes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v3: mf/session: Handle transform format changes and update downstream media types. mf/session: Wrap samples in IMFMediaEvent list instead of IMFSample list. mf/session: Introduce new session_get_topo_node_input helper. mf/session: Introduce new session_get_topo_node_output helper. mf/session: Get session topo_node from their IMFTopologyNode directly. mf/session: Introduce new (allocate|release)_output_samples helpers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5450

3 9

[PATCH 0/6] MR5536: mf/tests: Add more video processor tests with aperture changes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5536

4 9

[PATCH v4 0/10] MR5508: winegstreamer/video_decoder: Use video_decoder to implement wmv decoder.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

based on !5541 -- v4: winegstreamer/video_decoder: Use video_decoder to implement wmv decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/5508

4 11

[PATCH 0/1] MR5549: wg_parser: add wow64 func for wg_parser_connect
by Johnson Peter (＠peterjc123) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5549

2 2

[PATCH v6 0/1] MR5211: ntdll/unix: Use termios2 for serial when possible.
by Kirill Zhumarin (＠kirill.zhumarin) 28 May '24

28 May '24

Termios2 is a modern Linux feature thats allows usage of any custom baudrate instead of hardcoded values from the 1970's. Also, this patch improves compatibility with the win32 api, because windows allow any custom baudrates by design. Example software for which this patch is needed: http://www.vi-soft.com.ua/index_e.htm This software for reading/writing/patch fullflash of Siemens mobile phones, where serial speed is important. V-Klay uses 1600000 baudrate and perfectly works on Linux with termios2 and Prolific PL2303. -- v6: ntdll/unix: Use termios2 for serial when possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/5211

5 10

Re: [PATCH v3 0/10] MR5508: winegstreamer/video_decoder: Use video_decoder to implement wmv decoder.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

based on !5541 now -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5508#note_69010

1 0

[PATCH v2 0/7] MR5508: Draft: winestreamer/video_decoder: Use video_decoder to implement wmv decoder.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

based on !5504 -- v2: winestreamer/video_decoder: Use video_decoder to implement wmv decoder. winegstreamer/video_decoder: Support aggregation. winegstreamer/video_decoder: Add wg_transform_attrs member. winegstreamer/video_decoder: Change decoder attributes. winegstreamer/video_decoder: Set input/output infos in h264_decoder_create. winegstreamer: Implement mf_media_type_to_wg_format_video_wmv. winegstreamer: Introduce new wg_transform_create_quartz helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5508

4 12

Re: [PATCH v4 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

Is this stalled because of the importer struct? It's intended to preserve the behavior of relay/snoop w.r.t. dynamically resolved procedures (GetProcAddress). I'll drop it if the backwards compatibility is unnecessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_69007

1 0

[PATCH v31 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v31: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 28

[PATCH v2 0/2] MR5544: Fixes for Wine tests compilation with Visual Studio 10.0
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

-- v2: include/winnt.h: Move InterlockedExchangeAdd64() definition before its first usage. include/sal.h: Add _Inout_cap_c_(count) macro. https://gitlab.winehq.org/wine/wine/-/merge_requests/5544

2 3

[PATCH 0/1] MR5547: msvcrt: Implement _mbsncpy_s[_l]().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

ucrtbase._mbsncpy_s is used by Marvel vs Capcom when trying to create multiplayer lobby. The functions are also present in msvcrt (unlike msvcr70, msvcr71) where I didn't add it because it behaves differently: there is at least one weirdness when it doubles the number of characters to copy ('n' parameter, not buffer size). I suppose we don't need to explore and deal with this specific until something needs those functions from msvcrt. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5547

3 3

Re: [PATCH v2 0/2] MR5546: user32/tests: Add a flag for messages sent incorrectly on Wine. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5546

1 0

Re: [PATCH v2 0/1] MR5539: winex11.drv: Support _SHIFT_ARB attributes in X11DRV_wglGetPixelFormatAttribivARB(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5539

1 0

Re: [PATCH v3 0/9] MR4652: wined3d: A few more old-GL fixes. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4652

1 0

Re: [PATCH v2 0/1] MR5543: winemac.drv: Enable wglDescribePixelFormat through p_get_pixel_formats. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5543

1 0

Re: [PATCH v6 0/1] MR5497: ntdll: Implement NtQueueApcThreadEx()
by Etaash Mathamsetty (＠etaash.mathamsetty) 28 May '24

28 May '24

On Sat Apr 13 23:12:20 2024 +0000, Isaac Marovitz wrote: > I've tried to add the necessary changes based on what I saw for > `NtQueueApcThread()`, but the compiler isn't happy. Not sure what I'm missing. you probably just need to run ./tools/make_specfiles -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5497#note_68972

1 0

Re: [PATCH v6 0/5] MR5480: ntdll: Support exception reporting flags in contexts. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

1 0

Re: [PATCH v2 0/1] MR5537: win32u: Destroy thread windows before calling driver ThreadDetach. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5537

1 0

[PATCH 0/1] MR5449: Draft: regsvr32: Implement EXE registration.
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

The Sims 2 installer calls regsvr32 with the /regserver flag (which isn't implemented on Wine) so that command fails. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5449

3 2

Re: [PATCH v2 0/1] MR5538: winhttp: Fix parameters validation in WinHttpGetProxyForUrl. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5538

1 0

[PATCH 0/2] MR5544: Fixes for Wine tests compilation with Visual Studio 10.0
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5544

3 3

[PATCH 0/1] MR5545: Fix a typo
by Ruslan Garipov (＠ruslangaripov) 28 May '24

28 May '24

Trivial patch fixing a typo in a comment. Please, review. No functional changes intended. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5545

4 5

[PATCH 0/1] MR5539: winex11.drv: Support _SHIFT_ARB attributes in X11DRV_wglGetPixelFormatAttribivARB().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Akka Arrh is using that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5539

3 4

[PATCH 0/1] MR5540: wined3d: Added missing GTX 1650
by Roland Häder (＠Quix0r) 28 May '24

28 May '24

This adds the NVIDIA GeForce GTX 1650 with 4GB GPU memory -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5540

3 2

[PATCH v2 0/9] MR4652: wined3d: A few more old-GL fixes.
by Matteo Bruni (＠Mystral) 28 May '24

28 May '24

Here are 5 more patches on top of !4624, mostly along the same lines. I realize it's super late, no need to rush reviewing :slight_smile: -- v2: d3d9/tests: Test creating a texture on a NULL HWND device. d3d9/tests: Don't create a vertex shader in test_desktop_window() when unsupported. wined3d: Conditionally allow sRGB writes with the 'none' shader backend. wined3d: Conditionally support WINED3D_FRAGMENT_CAP_SRGB_WRITE on the ffp fragment pipe. d3d9/tests: Skip test_sample_attached_rendertarget() without pixel shaders support. wined3d: Don't override texture parameters for COND_NP2 on multisample textures. wined3d: Don't skip FFP projection transform update. d3d9: Don't do instanced draws in DrawPrimitive() and DrawPrimitiveUP(). wined3d: Rename WINED3DUSAGE_PRIVATE to WINED3DUSAGE_CS. https://gitlab.winehq.org/wine/wine/-/merge_requests/4652

5 13

[PATCH 0/1] MR5543: Draft: winemac.drv: Enable wglDescribePixelFormat through p_get_pixel_formats.
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5543

3 3

[PATCH v3 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection.
by Akihiro Sagawa (＠sgwaki) 28 May '24

28 May '24

RE:D Cherish depends on this. To demonstrate the difference in behavior, we need a special MPEG program stream that is at least 32kB over in size. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56485 -- v3: winegstreamer: Seek to the end after MPEG splitter connection. quartz/tests: Test read position after MPEG splitter connection. https://gitlab.winehq.org/wine/wine/-/merge_requests/5430

3 4

[PATCH 0/1] MR5537: win32u: Destroy thread windows before calling driver ThreadDetach.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

As discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5491#note_67760 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5537

3 2

[PATCH 0/1] MR5538: winhttp: Fix parameters validation in WinHttpGetProxyForUrl.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5538

3 2

[PATCH v6 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v6: win32u: Introduce a new add_virtual_modes helper. winex11: Let win32u decide when to force update the display cache. win32u: Don't force refresh the display cache on thread desktop change. winex11: Report all sources as detached in virtual desktop mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

3 11

Re: [PATCH v2 0/3] MR5529: winegstreamer: Implement input media type enumeration in MPEG splitter. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5529

1 0

Re: [PATCH v5 0/1] MR5528: include: Added atldef.h - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5528

1 0

Re: [PATCH v2 0/2] MR5530: Fake success from (Un)RegisterTouchWindow - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5530

1 0

Re: [PATCH v5 0/2] MR5519: setupapi: use INF parser to read class GUID and class name - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5519

1 0

Re: [PATCH v6 0/1] MR5490: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5490

1 0

Re: [PATCH v7 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

1 0

Re: [PATCH v3 0/2] MR5531: stdole32.tlb: Generate typelib in SLTG format. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5531

1 0

Re: [PATCH v4 0/6] MR5491: win32u: Move most vulkan surface code out of the drivers. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5491

1 0

Re: [PATCH v5 0/1] MR5437: kernelbase: Do not start the debugger if SEM_NOGPFAULTERRORBOX is set. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5437

1 0

Re: [PATCH v2 0/2] MR5534: cryptnet, crypt32: OCSP revocation check improvements. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5534

1 0

Re: [PATCH v2 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection. - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430

1 0

[PATCH 0/3] MR5529: winegstreamer: Implement input media type enumeration in MPEG splitter.
by Akihiro Sagawa (＠sgwaki) 28 May '24

28 May '24

Split from !5430. Patch 2/3 should fix amstream test failures, spotted at https://gitlab.winehq.org/wine/wine/-/merge_requests/5430#note_67851 . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5529

3 4

[PATCH 0/2] MR5530: Fake success from (Un)RegisterTouchWindow
by Etaash Mathamsetty (＠etaash.mathamsetty) 28 May '24

28 May '24

Growtopia shows a popup when this function call fails, faking success gets rid of it. Unreal Editor also prints a warning message that is silenced through this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5530

4 4

[PATCH v4 0/2] MR5519: setupapi: use INF parser to read class GUID and class name
by Tuomas Räsänen (＠tuomasjjrasanen) 28 May '24

28 May '24

Previously, `SetupDiGetINFClassW()` read INF files with `GetPrivateProfileString()`, which does not substitute %strkey% tokens. This caused device installation to fail for devices which had driver INF files using %strkey% tokens in Version section. An example of such device is Vernier LabQuest Mini (08f7:0008) for which Vernier's LoggerPro application includes a driver. The INF file in question adds a new device setup class and has following entries in Version section: ``` Class = %ClassName% ClassGuid = %DeviceClassGUID% ``` Strings section includes following entries: ``` DeviceClassGUID = "{6B8429BF-10AD-4b66-9FBA-2FE72B891721}" ClassName = "VST_WinUSB" ``` Previously, when LoggerPro was installed and LabQuest Mini was hotplugged, device installation failed with the following error: ``` fixme:setupapi:SetupDiGetINFClassW failed to convert "L"%DeviceClassGUID"" into a guid ``` This caused GUID_NULL to be used and Class was not set to the registry for the device. With this commit, correct class GUID and names are set to the device registry entry. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56579 -- v4: setupapi: use INF parser to read class GUID and class name setupapi/tests: add tests for reading INF class with %strkey% tokens https://gitlab.winehq.org/wine/wine/-/merge_requests/5519

3 9

[PATCH v5 0/1] MR5490: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Discovered while investigating Bug 56551. -- v5: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/5490

3 3

[PATCH v11 0/3] MR5060: win32u, explorer, winex11.drv: Restore display settings on process exit.
by Anton Baskanov (＠baskanov) 28 May '24

28 May '24

-- v11: explorer: Restore display settings on process exit. winex11.drv: Process RRNotify events in xrandr14_get_id. user32/tests: Test that display settings are restored on process exit. https://gitlab.winehq.org/wine/wine/-/merge_requests/5060

3 8

[PATCH v3 0/6] MR5491: win32u: Move most vulkan surface code out of the drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v3: win32u: Move host surface destruction out of the drivers. win32u: Pass HWND directly to vulkan surface creation driver callback. win32u: Rename vulkan surface creation/destroy driver callbacks. winevulkan: Pass win32u surface wrappers for each vkQueuePresent swapchain. win32u: Introduce a new VkSurfaceKHR wrapping structure. win32u: Introduce a distinct vulkan interface between win32u and the user drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5491

3 9

[PATCH 0/2] MR5534: cryptnet, crypt32: OCSP revocation check improvements.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5534

3 4

[PATCH 0/2] MR5535: advapi32: CryptSetKeyParam() should accept NULL pbData.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

At least CryptSetKeyParam(KP_X) should accept NULL pbData. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5535

3 3

[PATCH v4 0/1] MR5490: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Discovered while investigating Bug 56551. -- v4: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/5490

3 3

[PATCH v4 0/1] MR5437: kernelbase: Do not start the debugger if SEM_NOGPFAULTERRORBOX is set.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- v4: kernelbase: Do not start the debugger if SEM_NOGPFAULTERRORBOX is set. https://gitlab.winehq.org/wine/wine/-/merge_requests/5437

3 2

[PATCH v66 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 28 May '24

28 May '24

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v66: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

7 22

[PATCH v2 0/11] MR5491: win32u: Move most vulkan surface code out of the drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v2: winex11: Remove now unnecessary surface wrapper struct. win32u: Move thread detach from winex11. win32u: Introduce a per-window vulkan surface list. winewayland: Get rid of the now unnecessary surface wrapper. win32u: Return the host surface directly from vulkan_surface_create. win32u: Move host surface destruction out of the drivers. win32u: Pass HWND directly to vulkan surface creation driver callback. win32u: Rename vulkan surface creation/destroy driver callbacks. winevulkan: Pass win32u surface wrappers for each vkQueuePresent swapchain. win32u: Introduce a new VkSurfaceKHR wrapping structure. win32u: Introduce a distinct vulkan interface between win32u and the user drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5491

4 14

Re: [PATCH v4 0/6] MR5517: Move wglDescribePixelFormat implementation to opengl32 - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5517

1 0

Re: [PATCH v2 0/4] MR5532: mfreadwrite/tests: Tweak tests to run on Win7 and fix some leaks. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5532

1 0

Re: [PATCH v2 0/2] MR3929: ntdll: Remove entries from queue in RtlWakeAddressAll(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3929

1 0

[PATCH v3 0/2] MR5519: setupapi: use INF parser to read class GUID and class name
by Tuomas Räsänen (＠tuomasjjrasanen) 28 May '24

28 May '24

Previously, `SetupDiGetINFClassW()` read INF files with `GetPrivateProfileString()`, which does not substitute %strkey% tokens. This caused device installation to fail for devices which had driver INF files using %strkey% tokens in Version section. An example of such device is Vernier LabQuest Mini (08f7:0008) for which Vernier's LoggerPro application includes a driver. The INF file in question adds a new device setup class and has following entries in Version section: ``` Class = %ClassName% ClassGuid = %DeviceClassGUID% ``` Strings section includes following entries: ``` DeviceClassGUID = "{6B8429BF-10AD-4b66-9FBA-2FE72B891721}" ClassName = "VST_WinUSB" ``` Previously, when LoggerPro was installed and LabQuest Mini was hotplugged, device installation failed with the following error: ``` fixme:setupapi:SetupDiGetINFClassW failed to convert "L"%DeviceClassGUID"" into a guid ``` This caused GUID_NULL to be used and Class was not set to the registry for the device. With this commit, correct class GUID and names are set to the device registry entry. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56579 -- v3: setupapi: use INF parser to read class GUID and class name setupapi/tests: add tests for reading INF class with %strkey% tokens https://gitlab.winehq.org/wine/wine/-/merge_requests/5519

3 10

[PATCH v2 0/1] MR5490: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Discovered while investigating Bug 56551. -- v2: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/5490

3 5

[PATCH v6 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- v6: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

4 6

[PATCH 0/6] MR5450: mf/session: Handle and propagate stream format changes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5450

3 12

[PATCH v2 0/5] MR4624: wined3d: More old-GL fixes.
by Matteo Bruni (＠Mystral) 28 May '24

28 May '24

-- v2: d3d9/tests: Skip test_sample_attached_rendertarget() without pixel shaders support. wined3d: Don't override texture parameters for COND_NP2 on multisample textures. wined3d: Don't skip FFP projection transform update. d3d9: Don't do instanced draws in DrawPrimitive() and DrawPrimitiveUP(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4624

2 8

[PATCH 0/4] MR5532: mfreadwrite/tests: Tweak tests to run on Win7 and fix some leaks.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5459 which is otherwise stalled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5532

3 5

[PATCH v4 0/8] MR5459: mfreadwrite: Implement D3D awareness support with the video processor.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v4: mfreadwrite/reader: Pass the device manager to the stream transforms. winegstreamer/video_processor: Implement D3D awareness. mf/tests: Test video processor D3D11 awareness. mfreadwrite/tests: Add some source reader D3D11 awareness tests. mfreadwrite/reader: Avoid leaking the stream transform service MFT. mfreadwrite/tests: Shutdown the test stream event queues on source shutdown. mfreadwrite/tests: Avoid using MFCreateMediaBufferFromMediaType. mfreadwrite/tests: Do not accept MFVideoFormat_RGB32 in the test transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/5459

3 12

Re: [PATCH v5 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by eric pouech (＠epo) 28 May '24

28 May '24

On Wed Apr 24 15:30:39 2024 +0000, Hans Leidekker wrote: > The entry itself must skipped. The hash should be the same whether the > image is signed or not. right, but this means that you never include in the hash what's after the content of the security directory? (and another nitpick, not sure it does matter so much for real images, but it should be checked against nth->OptionalHeader.NumberOfRvaAndSizes that security header in present) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5516#note_68711

1 0

[PATCH 0/11] MR5491: win32u: Move most vulkan surface code out of the drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5491

6 18

[PATCH v3 0/6] MR5517: Draft: RFC: Move wglDescribePixelFormat implementation to opengl32
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

As an intermediate step on the way to !5388, I wanted to focus on the infrastructure that will allow us to pass pixel format information from the driver to the PE side. This MR introduces the mechanism to perform this information exchange and uses it to implement `wglDescribePixelFormat` on the PE side. In the current RFC state this MR: 1. Introduces `p_get_pixel_format` driver API to allow drivers to provide pixel format information. 2. Implements `wglDescribePixelFormat` on the PE side using the pixel format information. If the driver doesn't implement `p_get_pixel_format` we fall back to the `wglDescribePixelFormat` driver implementation (temporary measure until all drivers are updated). 3. Caches pixel format information in `NtCurrentTeb()->glReserved1[]`. 4. Implements `p_get_pixel_format` API and removes the custom `wglDescribePixelFormat` for winewayland. At this point would like to get some more feedback about this approach and the technical details. If the direction seems promising, here are the next steps to get to a final MR: 1. Implement `p_get_pixel_format` for winex11, winemac and dibdrv and remove their custom `wglDescribePixelFormat` implementations. 2. Remove the `wglDescribePixelFormat` driver API. Thanks! -- v3: winex11.drv: Remove unnecessary parameter from describe_pixel_format. winex11.drv: Enable wglDescribePixelFormat through p_get_pixel_formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/5517

3 12

[PATCH 0/2] MR3929: ntdll: Remove entries from queue in RtlWakeAddressAll().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

This avoids one case of spurious wakeup of WaitOnAddress (which could be triggered by prior race on consequent WakeAddressAll and a thread trying to wake on that, leaving the waking thread in an alerted state). And fixes Resident Evil games randomly crashing due to unhandled spurious SleepConditionVariableCS wakeups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3929

4 8

[PATCH 0/2] MR5509: Add tests to MF Media Engine
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

This MR adds two tests for additional test coverage in preparation of an update to MF Media Engine to use a dedicated Video Sink instead of the Sample Grabber -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5509

5 6

[PATCH v14 0/8] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v14: ntdll: Avoid marking freed block header as undefined for valgrind. ntdll: Force HEAP_TAIL_CHECKING_ENABLED flag with valgrind. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. DEBUG: ntdll: Don't use preloader when running on valgrind. tools: Add gdbunwind.py script with a syscall unwinder. ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose the standard debugging symbols for GDB. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

4 12

Re: [PATCH v2 0/1] MR5515: mfreadwrite: Store result of object activation in stream transform. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5515

1 0

Re: [PATCH v2 0/4] MR5481: widl: Make automatic dispid generation scheme better match what midl does. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5481

1 0

Re: [PATCH v9 0/2] MR5178: winewayland.drv: set wayland app-id from the process name - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178

1 0

Re: [PATCH v2 0/3] MR5505: wined3d: Introduce the "glsl-vkd3d" shader backend. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5505

1 0

Re: [PATCH v2 0/2] MR5511: winegstreamer: Respond to URI query. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5511

1 0

Re: [PATCH v2 0/4] MR5527: d2d1: Update to newer device interfaces. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5527

1 0

Re: [PATCH v2 0/5] MR5504: winegstreamer: Merge wg_format video fields together. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5504

1 0

Re: [PATCH v2 0/1] MR5526: winevulkan: Allocate commited memory for placed mappings. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5526

1 0

[PATCH v6 0/3] MR5400: shell32: Tying up some loose ends
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

Follow up to !5342. This adds the last missing piece for fixing how `ShellExecute` finds files, and restore the ability of running native unix programs with `ShellExecute` -- v6: shell32: Restore the ability of running native unix programs with ShellExecute https://gitlab.winehq.org/wine/wine/-/merge_requests/5400

2 4

[PATCH 0/4] MR5481: widl: Make automatic dispid generation scheme better match what midl does.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5481

4 7

[PATCH v2 0/6] MR5517: Draft: RFC: Move wglDescribePixelFormat implementation to opengl32
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

As an intermediate step on the way to !5388, I wanted to focus on the infrastructure that will allow us to pass pixel format information from the driver to the PE side. This MR introduces the mechanism to perform this information exchange and uses it to implement `wglDescribePixelFormat` on the PE side. In the current RFC state this MR: 1. Introduces `p_get_pixel_format` driver API to allow drivers to provide pixel format information. 2. Implements `wglDescribePixelFormat` on the PE side using the pixel format information. If the driver doesn't implement `p_get_pixel_format` we fall back to the `wglDescribePixelFormat` driver implementation (temporary measure until all drivers are updated). 3. Caches pixel format information in `NtCurrentTeb()->glReserved1[]`. 4. Implements `p_get_pixel_format` API and removes the custom `wglDescribePixelFormat` for winewayland. At this point would like to get some more feedback about this approach and the technical details. If the direction seems promising, here are the next steps to get to a final MR: 1. Implement `p_get_pixel_format` for winex11, winemac and dibdrv and remove their custom `wglDescribePixelFormat` implementations. 2. Remove the `wglDescribePixelFormat` driver API. Thanks! -- v2: winex11.drv: Remove unnecessary parameter from describe_pixel_format. winex11.drv: Enable wglDescribePixelFormat through p_get_pixel_formats. winewayland.drv: Enable wglDescribePixelFormat through p_get_pixel_formats. opengl32: Cache driver pixel format information. opengl32: Implement wglDescribePixelFormat using new driver API get_pixel_formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/5517

3 11

[PATCH v4 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- v4: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

2 2

[PATCH 0/1] MR5515: mfreadwrite: Store result of object activation in stream transform.
by Danyil Blyschak (＠blyss) 28 May '24

28 May '24

In source_reader_create_transform(), store the result of IMFActivate_ActivateObject() so that in the event of failure, resources are freed and an appropriate HRESULT is returned. Previously, if every object's activation failed, the last part of the function was not aware of this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5515

5 5

[PATCH v3 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- v3: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

3 4

[PATCH 0/1] MR5490: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Discovered while investigating Bug 56551. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5490

3 2

[PATCH 0/3] MR5505: wined3d: Introduce the "glsl-vkd3d" shader backend.
by Henri Verbeet (＠hverbeet) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5505

3 4

2025

2024

2023

2022

wine-gitlab