- wine-gitlab - winehq.org

[PATCH 0/2] MR5511: winegstreamer: Respond to URI query.
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

The default behaviour for gstreamer is to use the URI to create the stream-id. Without this, gstreamer creates a random stream-id per pad which can cause inconsistent ordering on the decodebin src pads. This in turn can cause issues, for example, with audio stream selection. The first commit is a partial cherry-pick of eda34f74c6ad from Proton. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5511

3 4

[PATCH 0/5] MR5504: winegstreamer: Merge wg_format video fields together.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5504

3 7

Re: [PATCH v3 0/1] MR5518: windowscodecs: Support 32-bit ABGR bitfields bitmaps. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5518

1 0

Re: [PATCH v2 0/1] MR5525: shell32/shellpath: fix UserPinned and QuickLaunch KnownFolderPaths. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5525

1 0

Re: [PATCH v8 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by Shmerl (＠shmerl) 28 May '24

28 May '24

On Mon Apr 22 09:02:12 2024 +0000, Alexandros Frantzis wrote: > Hi @shmerl, I have already reviewed and approved this MR (and cannot > merge myself). I guess it has fallen through the cracks, or perhaps > @julliard and/or @rbernon would like to review themselves? Yeah, may be some mix up about who can approve it for the final merge. See [here](https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_65890) > It's perhaps instead that approval only show up if the person is assigned as a reviewer, or that it was overlooked. It would be good to merge it for the next release. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_68466

1 0

Re: [PATCH v2 0/1] MR5524: mscoree: Update Wine Mono to 9.1.0. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5524

1 0

[PATCH v2 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- v2: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

3 4

[PATCH 0/4] MR5517: Draft: RFC: Move wglDescribePixelFormat implementation to opengl32
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

As an intermediate step on the way to !5388, I wanted to focus on the infrastructure that will allow us to pass pixel format information from the driver to the PE side. This MR introduces the mechanism to perform this information exchange and uses it to implement `wglDescribePixelFormat` on the PE side. In the current RFC state this MR: 1. Introduces `p_get_pixel_format` driver API to allow drivers to provide pixel format information. 2. Implements `wglDescribePixelFormat` on the PE side using the pixel format information. If the driver doesn't implement `p_get_pixel_format` we fall back to the `wglDescribePixelFormat` driver implementation (temporary measure until all drivers are updated). 3. Caches pixel format information in `NtCurrentTeb()->glReserved1[]`. 4. Implements `p_get_pixel_format` API and removes the custom `wglDescribePixelFormat` for winewayland. At this point would like to get some more feedback about this approach and the technical details. If the direction seems promising, here are the next steps to get to a final MR: 1. Implement `p_get_pixel_format` for winex11, winemac and dibdrv and remove their custom `wglDescribePixelFormat` implementations. 2. Remove the `wglDescribePixelFormat` driver API. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5517

3 7

[PATCH v5 0/3] MR5400: shell32: Tying up some loose ends
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

Follow up to !5342. This adds the last missing piece for fixing how `ShellExecute` finds files, and restore the ability of running native unix programs with `ShellExecute` -- v5: shell32: Restore the ability of running native unix programs with ShellExecute https://gitlab.winehq.org/wine/wine/-/merge_requests/5400

5 11

[PATCH 0/10] MR5508: Draft: winestreamer/video_decoder: Use video_decoder to implement wmv decoder.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

based on !5504 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5508

4 13

Re: [PATCH v8 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

On Mon Apr 22 09:02:12 2024 +0000, Shmerl wrote: > @afrantzis: A gentle ping. Can you please review and merge this? Hi @shmerl, I have already reviewed and approved this MR (and cannot merge myself). I guess it has fallen through the cracks, or perhaps @julliard and/or @rbernon would like to review themselves? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_68401

1 0

[PATCH v2 0/1] MR5518: windowscodecs: Support 32-bit ABGR bitfields bitmaps.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- v2: windowscodecs: Support 32-bit ABGR bitfields bitmaps. https://gitlab.winehq.org/wine/wine/-/merge_requests/5518

3 3

Re: [PATCH v8 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by Shmerl (＠shmerl) 28 May '24

28 May '24

@afrantzis: A gentle ping. Can you please review and merge this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_68246

1 0

[PATCH 0/1] MR5518: windowscodecs: Support 32-bit ABGR bitfields bitmaps.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5518

3 2

[PATCH 0/1] MR5519: setupapi: use INF parser to read class GUID and class name
by Tuomas Räsänen (＠tuomasjjrasanen) 28 May '24

28 May '24

Previously, `SetupDiGetINFClassW()` read INF files with `GetPrivateProfileString()`, which does not substitute %strkey% tokens. This caused device installation to fail for devices which had driver INF files using %strkey% tokens in Version section. An example of such device is Vernier LabQuest Mini (08f7:0008) for which Vernier's LoggerPro application includes a driver. The INF file in question adds a new device setup class and has following entries in Version section: ``` Class = %ClassName% ClassGuid = %DeviceClassGUID% ``` Strings section includes following entries: ``` DeviceClassGUID = "{6B8429BF-10AD-4b66-9FBA-2FE72B891721}" ClassName = "VST_WinUSB" ``` Previously, when LoggerPro was installed and LabQuest Mini was hotplugged, device installation failed with the following error: ``` fixme:setupapi:SetupDiGetINFClassW failed to convert "L"%DeviceClassGUID"" into a guid ``` This caused GUID_NULL to be used and Class was not set to the registry for the device. With this commit, correct class GUID and names are set to the device registry entry. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56579 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5519

3 2

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Matteo Bruni (＠Mystral) 28 May '24

28 May '24

> > > I guess it should perform better with a vidmem buffer if the buffer is holding static data and not locked after the initial upload. > > Maybe, yeah. Though I'd be surprised if a ddraw application did that... That was basically the original idea behind vertex buffers: to hold static data in video memory so that's faster to access by the GPU (mostly in the sense of avoiding data transfers from SYSMEM). Similar idea behind ProcessVertices(). If you wanted to draw with dynamic data, you'd use the non-VB Draw[Indexed]Primitive variant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68209

1 0

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

> It may be worth including a call to GetVertexBufferDesc() in the tests. As Matteo mentioned in an earlier comment, the docs seem to suggest that omitting D3DVBCAPS_SYSTEMMEMORY allows the driver/runtime to place the buffer as it sees fit. I mentioned earlier that GetVertexBufferDesc() never returns anything other than the flags used to create the buffer. That holds for both cards. I'll add a test the the suite. > I guess it should perform better with a vidmem buffer if the buffer is holding static data and not locked after the initial upload. Maybe, yeah. Though I'd be surprised if a ddraw application did that... > Can you check D3DDEVICEDESC.dwMaxVertexCount on these cards? Regardless of what we do with these two patches I think we should reduce it to whatever Windows reports. (1024 in my case on Windows 11) For both cards, the RGB device has 0 in the HAL caps, and 2021 in the HEL caps. The NVidia card has 32768 (both HAL and HEL), and the ATI card has 2048 (both HAL and HEL). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68208

1 0

[PATCH 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

4 5

[PATCH v3 0/1] MR5231: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list.
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

Overriding the SDL_VIDEODRIVER variable (for Wayland support as an example) on the Linux side can lead to some games under Wine failing to load (so treat that variable as special). -- v3: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5231

2 2

Re: [PATCH v4 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

On Thu Apr 18 23:08:03 2024 +0000, Aida Jonikienė wrote: > Has the memory leak been fixed? 🫗️ Patch 4/5 handles it, yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_68162

1 0

Re: [PATCH v2 0/2] MR5514: kernel32/tests: fixes for export forwarder test - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5514

1 0

Re: [PATCH v9 0/1] MR5188: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

1 0

Re: [PATCH v2 0/1] MR5513: ntdll: Use mangled function names in ARM64EC assembly. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5513

1 0

Re: [PATCH v4 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

1 0

Re: [PATCH v2 0/2] MR5510: light.msstyles: Use #fefefe instead of #ffffff for scrollbar parts. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5510

1 0

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Stefan Dösinger (＠stefan) 28 May '24

28 May '24

> At the same time, I haven't seen any evidence that a modern GPU will ever perform better with a vertex buffer not in sysmem unless it's using the streaming pattern I guess it should perform better with a vidmem buffer if the buffer is holding static data and not locked after the initial upload. Can you check D3DDEVICEDESC.dwMaxVertexCount on these cards? Regardless of what we do with these two patches I think we should reduce it to whatever Windows reports. (1024 in my case on Windows 11) Conceptually the two patches have my blessing though, regardless of specifics of what PoP3D is doing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68141

1 0

Re: [PATCH v4 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

On Thu Apr 18 23:08:03 2024 +0000, Jinoh Kang wrote: > @rbernon Thanks for your review! Right now I'm tentatively putting this > MR on hold until I find a solution for a memory leak: a new (redundant) > dependency edge is added every time the application calls > `GetProcAddress()` on a forwarded ref. Has the memory leak been fixed? 🫗️ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_68140

1 0

[PATCH 0/4] MR4424: ntdll: Implement reading multiple entries in NtQueryDirectoryObject. (#52585)
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4424

5 11

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Henri Verbeet (＠hverbeet) 28 May '24

28 May '24

It may be worth including a call to GetVertexBufferDesc() in the tests. As Matteo mentioned in an earlier comment, the docs seem to suggest that omitting D3DVBCAPS_SYSTEMMEMORY allows the driver/runtime to place the buffer as it sees fit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68109

1 0

Re: [PATCH v8 0/1] MR5188: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. - approved
by Sven Baars (＠sbaars) 28 May '24

28 May '24

This merge request was approved by Sven Baars. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

1 0

Re: [PATCH v3 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11. - approved
by Jan Sikorski (＠jsikorski) 28 May '24

28 May '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

1 0

[PATCH 0/2] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

This fixes a regression introduced by 15d53761a5fbfc12fc5f9974c029dace00eab33d. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

6 15

Re: [PATCH v6 0/1] MR5380: netapi32: Add NetRemoteTOD stub. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5380

1 0

Re: [PATCH v6 0/1] MR5497: ntdll: Implement NtQueueApcThreadEx() - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

1 0

Re: [PATCH v2 0/1] MR5506: gdiplus: Fix IWICBitmapFrameDecode reference leak in decode_frame_wic. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5506

1 0

Re: [PATCH v2 0/1] MR5467: ntdll: Return STATUS_NO_YIELD_PERFORMED from NtYieldExecution() on Linux if no yield was performed. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5467

1 0

Re: [PATCH v4 0/6] MR5503: Fix initialization of the handler_fd_ops
by Ruslan Garipov (＠ruslangaripov) 28 May '24

28 May '24

Yet another four files with the same "issue": server/change.c, server/thread.c, server/process.c and server/queue.c. This time found by fgrep(1), so no more similar files left in server directory, I believe. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_68027

1 0

Re: [PATCH v3 0/6] MR5503: Fix initialization of the handler_fd_ops
by Ruslan Garipov (＠ruslangaripov) 28 May '24

28 May '24

It turned out that the `master_socket_fd_ops` in server/request.c has the same "issue". Therefore, 1c68e8ed960 (Fix initialization of the master_socket_fd_ops, 2024-04-17) was added into this merge request. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_68012

1 0

Re: [PATCH v3 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11. - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

1 0

Re: [PATCH v2 0/6] MR5503: Fix initialization of the handler_fd_ops
by Ruslan Garipov (＠ruslangaripov) 28 May '24

28 May '24

I've just get-rebase(1)'d my branch, because it was outdated comparing to the \`master' branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_67986

1 0

[PATCH v6 0/1] MR5369: winegstreamer: Refactor wg_format.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

Since we are adding more and more media formats to wg_format, the current wg_format struct is getting ugly. Everytime we add a video format, we need to duplicate width, height, fps. Everytime we add a audio format, we need to duplicate channels, rate. So it would be better if we could share width, height, fps fields between different video formats, also share channels and rate fields between different audio formats. What makes me found the current wg_format is not in a good shape is when I was writting code for Proton, I found that I need to write some code like this if want to get width/height/fps from a wg_format: ``` static bool get_video_info_from_wg_format(struct wg_format *format, int32_t *width, int32_t *height, uint32_t *fps_n, uint32_t *fps_d) { switch (format->major_type) { case WG_MAJOR_TYPE_VIDEO: *width = format->u.video.width; *height = format->u.video.height; *fps_n = format->u.video.fps_n; *fps_d = format->u.video.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_CINEPAK: *width = format->u.video_cinepak.width; *height = format->u.video_cinepak.height; *fps_n = format->u.video_cinepak.fps_n; *fps_d = format->u.video_cinepak.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_H264: *width = format->u.video_h264.width; *height = format->u.video_h264.height; *fps_n = format->u.video_h264.fps_n; *fps_d = format->u.video_h264.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_WMV: *width = format->u.video_wmv.width; *height = format->u.video_wmv.height; *fps_n = format->u.video_wmv.fps_n; *fps_d = format->u.video_wmv.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_INDEO: *width = format->u.video_indeo.width; *height = format->u.video_indeo.height; *fps_n = format->u.video_indeo.fps_n; *fps_d = format->u.video_indeo.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_MPEG1: *width = format->u.video_mpeg1.width; *height = format->u.video_mpeg1.height; *fps_n = format->u.video_mpeg1.fps_n; *fps_d = format->u.video_mpeg1.fps_d; return true; default: GST_ERROR("Type %d is not a video format.\n", format->major_type); return false; } } ``` Apparently, the code above is ugly. By refactoring wg_format, we can avoid code like this. This patch is a draft now, it only contains unixlib.h code. Zeb, I'd like to confirm that if this refactoring would be acceptable for you. If do, I'll continue finishing the remaining parts. -- v6: winegstreamer: Refactor wg_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/5369

4 8

Re: [PATCH v3 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

On Tue Apr 16 22:41:34 2024 +0000, Elizabeth Figura wrote: > This is now causing a test failure in test_swapchain_resize() due to a > no longer skipped test; I imagine we want to add a todo_wine there (and > possibly change the skip to a win_skip). Thanks, that should be fixed now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484#note_67974

1 0

Re: [PATCH v2 0/2] MR5501: ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) stub. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5501

1 0

Re: [PATCH v3 0/4] MR5471: wined3d: Dynamic pipeline state, part 3: EXT_extended_dynamic_state3. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5471

1 0

Re: [PATCH v8 0/8] MR5419: quartz: Fixes for the BURIKO visual novel engine's videos - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5419

1 0

Re: [PATCH v3 0/1] MR5454: winegstreamer: Ensure stream format change notification on size change in h264 decoder. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5454

1 0

Re: [PATCH v4 0/3] MR5438: winegstreamer: Merge audio field togther. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5438

1 0

Re: [PATCH v2 0/4] MR5476: winegstreamer: Introduce new wg_transform buffer copy helpers. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5476

1 0

Re: [PATCH v2 0/1] MR5495: explorer: Fix font handle leaks in virtual desktop. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5495

1 0

[PATCH v2 0/1] MR5426: user32/tests: Mark test todo only on Mac and X11 drivers.
by Esme Povirk (＠madewokherd) 28 May '24

28 May '24

-- v2: user32/tests: Mark test todo only on Mac and X11 drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5426

4 4

Re: [PATCH 0/6] MR5503: Fix initialization of the handler_fd_ops
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

On Tue Apr 16 19:49:05 2024 +0000, Ruslan Garipov wrote: > > I don't know if there is anything preventing using them in the server > Should I update my patch using designated initializers? That would be a question for @julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_67941

1 0

Re: [PATCH 0/6] MR5503: Fix initialization of the handler_fd_ops
by Ruslan Garipov (＠ruslangaripov) 28 May '24

28 May '24

> I don't know if there is anything preventing using them in the server Should I update my patch using designated initializers? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_67940

1 0

Re: [PATCH 0/6] MR5503: Fix initialization of the handler_fd_ops
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Designated initializers will make this more readable and easier to verify. We are using them in various places now, including parts built as unixlibs. I don't know if there is anything preventing using them in the server, apart from being in different style. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_67938

1 0

[PATCH v4 0/5] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v4: ntdll: Store exception reporting flags for debug events. ntdll: Store exception reporting flags on suspend. ntdll: Store exception reporting flags in server context. ntdll: Set exception reporting flags in NtGetContextThread(). ntdll/tests: Add tests for CONTEXT_EXCEPTION_REQUEST. https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

3 9

[PATCH v2 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v2: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

4 22

Re: [PATCH v2 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection.
by Akihiro Sagawa (＠sgwaki) 28 May '24

28 May '24

On Tue Apr 16 14:47:32 2024 +0000, Elizabeth Figura wrote: > 1/3 is unfortunately causing some (strange) test failures here: > 00f0:fixme:quartz:mpeg_splitter_filter_init_gst unexpected format 5 > 00f0:fixme:quartz:mpeg_splitter_filter_init_gst unexpected format 1 > amstream.c:512: Test failed: Got hr 0. > I see this on the CI too. Got it. I'll take a look. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430#note_67920

1 0

[PATCH v2 0/2] MR5502: notepad: Use wide character string literals
by Isaac Marovitz (＠IsaacMarovitz) 28 May '24

28 May '24

-- v2: notepad: Use wide character string literals in dialog.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/5502

3 3

[PATCH 0/1] MR5495: explorer: Fix font handle leaks in virtual desktop.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56133 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5495

3 2

[PATCH v2 0/4] MR5471: wined3d: Dynamic pipeline state, part 3: EXT_extended_dynamic_state3.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- v2: wined3d: Use dynamic state for rasterizer state if possible. wined3d: Use dynamic state for blend state if possible. wined3d: Use dynamic state for multisample state if possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/5471

4 6

Re: [PATCH v13 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/364

1 0

Re: [PATCH v2 0/5] MR5493: Extend minidump support in winedump. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5493

1 0

Re: [PATCH v4 0/4] MR5488: win32u: Add display device cache modes all at once. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5488

1 0

Re: [PATCH v3 0/1] MR5499: mscms: Add stub for WcsGetDefaultColorProfile. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5499

1 0

Re: [PATCH v2 0/2] MR5492: Embed thread names in minidump. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5492

1 0

Re: [PATCH v2 0/1] MR5489: win32u: Also reset the unnamed values in prepare_devices. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5489

1 0

Re: [PATCH v3 0/1] MR5498: krnl386.exe16: Start DOSVM timer on GET_SYSTEM_TIME - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5498

1 0

Re: [PATCH v3 0/3] MR5438: winegstreamer: Merge audio field togther. - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5438

1 0

[PATCH v2 0/1] MR5454: winegstreamer: Ensure stream format change notification on size change in h264 decoder.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v2: winegstreamer: Destroy wg_transform in video_decoder/transform_SetInputType(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5454

4 4

[PATCH 0/4] MR5476: winegstreamer: Introduce new wg_transform buffer copy helpers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5055. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5476

3 5

Re: [PATCH v2 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

1/3 is unfortunately causing some (strange) test failures here: 00f0:fixme:quartz:mpeg_splitter_filter_init_gst unexpected format 5 00f0:fixme:quartz:mpeg_splitter_filter_init_gst unexpected format 1 amstream.c:512: Test failed: Got hr 0. I see this on the CI too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430#note_67851

1 0

[PATCH v2 0/6] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v2: ntdll: Store exception reporting flags for debug events. ntdll: Store exception reporting flags on suspend. ntdll: Store exception reporting flags in server context. ntdll: Set exception reporting flags in NtGetContextThread(). ntdll/tests: Add tests for CONTEXT_EXCEPTION_REQUEST. ntdll/tests: Work around exception test failures on Wine WoW. https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

3 11

[PATCH 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

Microsoft Flight Simulator (2020) requires IDXGISwapChain4. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

4 5

[PATCH v11 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Mohamad Al-Jaf (＠maljaf) 28 May '24

28 May '24

Needed by Orbiter Space Flight Simulator and Train Simulator Classic. -- v11: d3d9/tests: Add Direct3DCreate9On12() tests. d3d9: Implement Direct3DCreate9On12(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4915

4 6

[PATCH 0/10] MR4652: wined3d: A few more old-GL fixes.
by Matteo Bruni (＠Mystral) 28 May '24

28 May '24

Here are 5 more patches on top of !4624, mostly along the same lines. I realize it's super late, no need to rush reviewing :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4652

4 16

[PATCH 0/1] MR5494: ntdll: Implement NtQuerySystemInformation( SystemProcessIdInformation ).
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Should help with Overwatch 2 random crashes after some time of playing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5494

3 4

Re: [PATCH v3 0/3] MR5500: d3d9: Add a few swapchain tests
by Robin Kertels (＠K0bin) 28 May '24

28 May '24

Thanks for the review. > They fail on my Windows XP box, r250 GPU, see the attached log file. It seems that It doesn't follow the alpha = 0xff behavior of newer GPUs and just returns alpha 0x0 in either case. The window positioning test needlessly depends on it. If I mask out the alpha channel in test_get_front_buffer_data_windowed_positioning() it passes. Interesting. I'd be perfectly fine with dropping the separate alpha test entirely. I also meant to mask out the alpha but I guess I forgot it there or lost it during rebase/cleanup. > if (foo) { something(); } > Please put the { on a new line consistently. Ah, I'm trying. I thought I got it right but I guess old habits die hard. I use the same line { in every other project, so not surprised that I slipped up a couple of times. I'll fix that. > test_swapchain_buffer_swapping() and test_get_front_buffer_data_alpha() leak your initial device, the one you use to populate present_parameters > In the case of test_swapchain_buffer_swapping I don't see why you need to call IDirect3D9::CreateDevice yourself - what prevents you from using the device returned by create_device? Oops, that's a leftover of my original approach. I originally meant to create a new device for each test case and pass the required presentation params but later changed it to just use a single device created using `create_device` and reset that as needed. I meant to get rid of the second device that's created manually. I will also look into using the current monitor resolution for the fullscreen tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5500#note_67838

1 0

[PATCH 0/2] MR5501: ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) stub.
by Vijay Kiran Kamuju (＠infyquest) 28 May '24

28 May '24

Based on a patch by Qian Hong. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44812 Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Refer to !5269 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5501

4 9

Re: [PATCH v3 0/3] MR5500: d3d9: Add a few swapchain tests
by Stefan Dösinger (＠stefan) 28 May '24

28 May '24

The tests pass on my Windows 11 machine with a Radeon 560 GPU. They fail on my Windows XP box, r250 GPU, see the attached log file. It seems that It doesn't follow the alpha = 0xff behavior of newer GPUs and just returns alpha 0x0 in either case. The window positioning test needlessly depends on it. If I mask out the alpha channel in test_get_front_buffer_data_windowed_positioning() it passes. I haven't looked closely at the code yet - I see some style inconsistencies, like if (foo) { something(); } Please put the { on a new line consistently. Rather than hardcoding the positions to check in the windowed mode tests please call GetWindowRect after creating the device and calculate the checked positions relative to it. There are window managers on the Linux side that don't allow applications to decide their placement and will break this kind of test. I suspect fvwm2 will cause you trouble otherwise. test_swapchain_buffer_swapping() and test_get_front_buffer_data_alpha() leak your initial device, the one you use to populate present_parameters. The other unfortunate side effect of initializing present_parameters like that is that you switch the screen to 640x480 fullscreen mode. I recommend to use EnumDisplaySettingsW(ENUM_CURRENT_SETTINGS) to retrieve the current mode and use it to create a fullscreen device that doesn't change the mode. Changing the mode moves around Windows on Windows 10/11 and most Linux desktops. In the case of test_swapchain_buffer_swapping I don't see why you need to call IDirect3D9::CreateDevice yourself - what prevents you from using the device returned by create_device? [r200-xp.txt](/uploads/5f577583ec5703e2a040077de884faf3/r200-xp.txt) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5500#note_67826

1 0

[PATCH v2 0/1] MR5499: mscms: Add stub for WcsGetDefaultColorProfile.
by Vijay Kiran Kamuju (＠infyquest) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56554 -- v2: mscms: Add stub for WcsGetDefaultColorProfile. https://gitlab.winehq.org/wine/wine/-/merge_requests/5499

3 2

[PATCH v3 0/4] MR5488: win32u: Add display device cache modes all at once.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

To make https://gitlab.winehq.org/wine/wine/-/merge_requests/5422 simpler. This will also make it easier to write the mode list to the registry as a single binary blob, although it is a larger change that could be done later. -- v3: win32u: Add all display device source modes at once. win32u: Keep the primary current mode in the device manager context. win32u: Remove fake source creation when adding display mode. win32u: Close device manager source key in write_source_to_registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/5488

3 5

[PATCH 0/6] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

4 9

[PATCH v4 0/2] MR5269: Add NtQueryInformationProcess(ProcessQuotaLimits) stub
by Gijs Vermeulen (＠gverm) 28 May '24

28 May '24

Based on a patch by Qian Hong. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44812 -- v4: ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) tests. ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/5269

5 8

[PATCH v5 0/2] MR5497: ntdll: Implement NtQueueApcThreadEx()
by Isaac Marovitz (＠IsaacMarovitz) 28 May '24

28 May '24

Should resolve a crash in `libogg` in the game "Cabal Online" -- v5: wow64: Add NtQueueApcThreadEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

2 3

[PATCH v3 0/1] MR5497: ntdll: Implement NtQueueApcThreadEx()
by Isaac Marovitz (＠IsaacMarovitz) 28 May '24

28 May '24

Should resolve a crash in `libogg` in the game "Cabal Online" -- v3: ntdll: Implement NtQueueApcThreadEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

3 2

Re: [PATCH v8 0/2] MR2552: wineboot: Add env variable to hide wait window - closed
by Isaac Marovitz (＠IsaacMarovitz) 28 May '24

28 May '24

This merge request was closed by Isaac Marovitz. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2552

1 0

[PATCH 0/10] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

4 26

Re: [PATCH v8 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

v8: - Remove all new TESTDLLs (forward*.dll, sforward.dll) - Generate all test DLLs in runtime -- https://gitlab.winehq.org/wine/wine/-/merge_requests/364#note_67735

1 0

[PATCH v2 0/4] MR5488: win32u: Add display device cache modes all at once.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

To make https://gitlab.winehq.org/wine/wine/-/merge_requests/5422 simpler. This will also make it easier to write the mode list to the registry as a single binary blob, although it is a larger change that could be done later. -- v2: win32u: Add all display device source modes at once. win32u: Keep the primary current mode in the device manager context. win32u: Remove fake source creation when adding display mode. win32u: Close device manager source key in write_source_to_registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/5488

3 6

[PATCH 0/4] MR5488: win32u: Add display device cache modes all at once.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

To make https://gitlab.winehq.org/wine/wine/-/merge_requests/5422 simpler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5488

3 10

[PATCH 0/1] MR5489: win32u: Also reset the unnamed values in prepare_devices.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56551 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5489

3 2

Re: [PATCH v2 0/1] MR5486: makedep: Use hybrid ARM64X images for ARM64EC. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5486

1 0

Re: [PATCH v3 0/1] MR5445: mmdevapi: Implement SAC_IsAudioObjectFormatSupported(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5445

1 0

Re: [PATCH v5 0/3] MR5462: Ucrtbase's stderr is now always unbuffered. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5462

1 0

Re: [PATCH v2 0/2] MR5487: winemac.drv: Update OpenGL context immediately after the window content view is visible. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5487

1 0

Re: [PATCH v2 0/3] MR5485: d2d1: Implement GetEffectProperties(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5485

1 0

Re: [PATCH v2 0/1] MR5479: imm32: Add CtfImmIsCiceroEnabled stub - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5479

1 0

Re: [PATCH v5 0/7] MR5482: winevulkan: Move swapchain wrappers out of the user drivers. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5482

1 0

[PATCH 0/2] MR5487: winemac.drv: Update OpenGL context immediately after the window content view is visible.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

Fix errors such as GL_FRAMEBUFFER_UNDEFINED and GL_INVALID_FRAMEBUFFER_OPERATION for OpenGL functions when the default framebuffer 0 is bound on macOS. These errors happen because the NSOpenGLContext doesn't have a view bound at the time of an OpenGL call. The view could not be set for the NSOpenGLContext because the window or view can still be invisible. Setting an invisible view for the NSOpenGLContext can generate invalid drawable messages as 682ed910 has shown. Thus setting the view could be deferred because the NSOpenGLContext needs a visible view. However, right after the window becomes visible, an OpenGL function that involves the default framebuffer can be called. And when the view is still not set at the time of the OpenGL call, errors such as GL_FRAMEBUFFER_UNDEFINED and GL_INVALID_FRAMEBUFFER_OPERATION could happen and result in rendering errors such as black screen. So we need to set the view for the NSOpenGLContext as soon as the view becomes visible. It's possible that the window and view are still invisible when OpenGL functions involving the default framebuffer get called. In such cases, I think errors like GL_FRAMEBUFFER_UNDEFINED are justified on macOS. Fix Active Trader Pro black screen at launch on macOS. The application creates a d3d9 device with an invisible window. And then it shows the window before calling d3d9_swapchain_Present(). So all the [NSOpenGLContext setView] opportunities are missed and no view is set. Then when glBlitFramebuffer() gets called, GL_FRAMEBUFFER_UNDEFINED happens and so nothing is rendered. The application only renders one frame before login so the window remains black. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5487

3 3

[PATCH v4 0/7] MR5482: winevulkan: Move swapchain wrappers out of the user drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This introduces a custom `VkPresentSurfacesInfoWine` struct to the driver queue present. It could very well be a separate vkQueuePresent parameter, now that the driver interface is manually written. For now it provides the swapchains HWND, for vulkan_surface_presented, which is mostly just for winewayland purposes. Later I intend to change it to pass win32u surfaces wrappers. -- v4: winevulkan: Remove now unnecessary vkCreateSwapchainKHR driver entry. winevulkan: Remove now unnecessary vkDestroySwapchain driver entry. win32u: Move vkQueuePresent implementation out of the user drivers. winewayland: Remove now unnecessary swapchain wrapper. winewayland: Remove now unnecessary swapchain extents checks. win32u: Introduce a new vulkan_surface_presented driver entry. winevulkan: Pass surface info for each vkQueuePresent swapchain to win32u. https://gitlab.winehq.org/wine/wine/-/merge_requests/5482

4 10

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

On Mon Apr 22 12:40:26 2024 +0000, Zhiyi Zhang wrote: > What is this fake source supposed to do now? Virtual desktop has its own > virtual source. Was it ever related to virtual desktop mode? I don't know what it was for, I'm fine dropping it altogether. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67597

1 0

2025

2024

2023

2022

wine-gitlab