- wine-gitlab - winehq.org

[PATCH v5 0/5] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) 26 Apr '24

26 Apr '24

-- v5: ntdll: Store exception reporting flags for debug events. ntdll: Store exception reporting flags on suspend. ntdll: Store exception reporting flags in server context. ntdll: Set exception reporting flags in NtGetContextThread(). ntdll/tests: Add tests for CONTEXT_EXCEPTION_REQUEST. https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

2 5

[PATCH 0/2] MR5546: user32/tests: Add a flag for messages sent incorrectly on Wine.
by Esme Povirk (＠madewokherd) 26 Apr '24

26 Apr '24

I'm likely to add some of these while working on MSAA events, which aren't related to the MSAA events but are caused by other differences in Wine. I thought it'd be better to be able to properly mark todo's, so that we know when they're fixed. This revealed some cases where we have an "optional" message for Wine, but Wine has since been fixed. In a future MR, I plan to also rename winevent_hook_todo and use it more broadly for the opposite case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5546

2 2

[PATCH v2 0/6] MR5450: mf/session: Handle and propagate stream format changes.
by Rémi Bernon (＠rbernon) 24 Apr '24

24 Apr '24

-- v2: mf/session: Handle transform format changes and update downstream media types. mf/session: Wrap samples in IMFMediaEvent list instead of IMFSample list. mf/session: Introduce new session_get_topo_node_input helper. mf/session: Introduce new session_get_topo_node_output helper. mf/session: Get session topo_node from their IMFTopologyNode directly. mf/session: Introduce new (allocate|release)_output_samples helpers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5450

2 6

[PATCH v2 0/2] MR5531: stdole32.tlb: Generate typelib in SLTG format.
by Dmitry Timoshkov (＠dmitry) 24 Apr '24

24 Apr '24

-- v2: stdole32.tlb: Generate typelib in SLTG format. widl: Fix calculation of the SLTG library block size. https://gitlab.winehq.org/wine/wine/-/merge_requests/5531

2 2

[PATCH v4 0/7] MR5319: winemac.drv keyboard layout/dead key fixes
by Marc-Aurel Zent (＠mzent) 24 Apr '24

24 Apr '24

This is a series of commits tackling dead key state handling and scan code to vkey mapping improvements (especially for French and German keyboards). * https://gitlab.winehq.org/mzent/wine/-/commit/6c5c90b746cc341049eec216e3bb9…: Simplifies the logic a bit there and also correctly null-terminates dead keys in ToUnicodeEx * https://gitlab.winehq.org/mzent/wine/-/commit/a05e2fc5068a22cae94bc800b4972…: Windows does not do it and some applications misbehave with this, fully fixed later in https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c… * https://gitlab.winehq.org/mzent/wine/-/commit/4bd96932139a22f2c3b1311e44c43…: MSDN states single keys are always uppercased there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac8e97d7e6a7494672d76f5fc586…: There is a bug in `CFStringCompare` with the flags used there currently, resulting in the comparison of the identical buffers "ß" and "ß" to be false. In any case `UCCompareText` behaves correctly and is much faster there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac5f485a09fbddd39efb8f2c0d87…: I think this was an accidental mistake there, going through all modifiers first per symbol almost always results in the wrong match being made. The logic is adjusted there now to be similar to the other iterations involving `char_matches_string`. * https://gitlab.winehq.org/mzent/wine/-/commit/ffde55df4ae3f6d53198839c58356… https://gitlab.winehq.org/mzent/wine/-/commit/a453d0d4c89c59c3e1ba6c24d2d0f…: Adds additional symbol vkey mappings (now completely maps a German Macintosh and PC keyboard correctly). There are still some minor defects with the French layout (around the ú region), however changing the symbol mapping there will cause issues with other layouts I think, since the wrong match happens very early there in the priority in these cases. With this change at least the number row is now behaving correctly. Additionally the French Macintosh keyboard layout is further complicated by the "=" key being next to right shift, which is in conflict with pretty much any other keyboard layout. To fix this properly would require a partial rewrite of the heuristic being used or a new approach, but most likely more of a long term project. * https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c…: Gives dead keys friendly names in `GetKeyNameFriendlyText`, just like Windows does. I tried to be as exhaustive as possible, but if there are any missing the mapping can be easily extended. All in all the incorrect scan code to vkey mapping is usually not that tragic, since an application would need to be aware of the layout and have its own mapping of scan codes of each (FFXIV does this though). The French layout corrections are now "good enough" to behave correctly for all the hotbar slots being assigned there with these changes now though. -- v4: winemac.drv: Give dead keys a friendly name in GetKeyNameText. winemac.drv: Add additional German symbol vkeys. winemac.drv: Resolve symbol vkeys first without modifiers. winemac.drv: Use UCCompareText in char_matches_string. winemac.drv: Uppercase single keys in GetKeyNameText. winemac.drv: Do not append " dead" to dead keycodes in GetKeyNameText. winemac.drv: Handle length of dead keycodes in ToUnicodeEx correctly. https://gitlab.winehq.org/wine/wine/-/merge_requests/5319

2 7

[PATCH 0/1] MR5531: stdole32.tlb: Generate typelib in SLTG format.
by Dmitry Timoshkov (＠dmitry) 24 Apr '24

24 Apr '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5531

2 1

[PATCH v4 0/1] MR5528: include: Added atldef.h
by Alistair Leslie-Hughes (＠alesliehughes) 24 Apr '24

24 Apr '24

-- v4: include: Added atldef.h https://gitlab.winehq.org/wine/wine/-/merge_requests/5528

2 1

[PATCH v3 0/1] MR5528: include: Added atldef.h
by Alistair Leslie-Hughes (＠alesliehughes) 23 Apr '24

23 Apr '24

-- v3: include: Added atldef.h https://gitlab.winehq.org/wine/wine/-/merge_requests/5528

3 2

[PATCH v2 0/1] MR5528: include: Added atldef.h
by Alistair Leslie-Hughes (＠alesliehughes) 23 Apr '24

23 Apr '24

-- v2: include: Added atldef.h https://gitlab.winehq.org/wine/wine/-/merge_requests/5528

2 1

[PATCH 0/1] MR5528: include: Added atldef.h
by Alistair Leslie-Hughes (＠alesliehughes) 23 Apr '24

23 Apr '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5528

2 1

[PATCH 0/4] MR5527: d2d1: Update to newer device interfaces.
by Nikolay Sivov (＠nsivov) 22 Apr '24

22 Apr '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5527

2 4

[PATCH 0/1] MR5526: winevulkan: Allocate commited memory for placed mappings.
by Billy Laws (＠bylaws) 22 Apr '24

22 Apr '24

This is necessary to prevent virtual_set_force_exec from resetting the permissions of mappings back to --- when a non-NX-compatible module is loaded. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5526

2 1

[PATCH 0/1] MR5525: shell32/shellpath: fix UserPinned and QuickLaunch KnownFolderPaths.
by Michael Bond (＠michael.bond) 22 Apr '24

22 Apr '24

Fix for latest autodesk [fusion360 installer](https://github.com/cryinkfly/Autodesk-Fusion-360-for-Linux/issue… calling SHGetKnownFolderPath against [FOLDERID_UserPinned](https://learn.microsoft.com/lv-lv/windows/win32/shell/… Trace Output pre-patch: ``` 15285.659:057c:05c0:trace:shell:SHGetKnownFolderPath {9e3995ab-1f9c-4f13-b827-48b24b6c7174}, 0x00000000, 0000000000000000, 0000000003FB0D98 15285.659:057c:05c0:trace:shell:SHGetFolderPathAndSubDirW 0000000000000000,0x6c,0000000000000000,0,(null),000000000410E3F0 15285.659:057c:05c0:trace:shell:SHGetFolderPathAndSubDirW returning 0x80070057 (final path is L"") 15285.659:057c:05c0:trace:shell:SHGetKnownFolderPath Failed to get folder path, 0x80070057. 15285.659:057c:05c0:Ret shell32.SHGetKnownFolderPath() retval=80070057 ret=6ffff9774771 ``` SHGetFolderPathAndSubDirW returns 0x57 invalid-parameter error (0x80070057) due to the folder array in shell32/shellpath.c having CSIDL_Type_Disallowed set on UserPinned and QuickLaunch folders. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5525

2 1

[PATCH 0/1] MR5524: mscoree: Update Wine Mono to 9.1.0.
by Esme Povirk (＠madewokherd) 20 Apr '24

20 Apr '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5524

2 1

[PATCH v2 0/2] MR5519: setupapi: use INF parser to read class GUID and class name
by Tuomas Räsänen (＠tuomasjjrasanen) 20 Apr '24

20 Apr '24

Previously, `SetupDiGetINFClassW()` read INF files with `GetPrivateProfileString()`, which does not substitute %strkey% tokens. This caused device installation to fail for devices which had driver INF files using %strkey% tokens in Version section. An example of such device is Vernier LabQuest Mini (08f7:0008) for which Vernier's LoggerPro application includes a driver. The INF file in question adds a new device setup class and has following entries in Version section: ``` Class = %ClassName% ClassGuid = %DeviceClassGUID% ``` Strings section includes following entries: ``` DeviceClassGUID = "{6B8429BF-10AD-4b66-9FBA-2FE72B891721}" ClassName = "VST_WinUSB" ``` Previously, when LoggerPro was installed and LabQuest Mini was hotplugged, device installation failed with the following error: ``` fixme:setupapi:SetupDiGetINFClassW failed to convert "L"%DeviceClassGUID"" into a guid ``` This caused GUID_NULL to be used and Class was not set to the registry for the device. With this commit, correct class GUID and names are set to the device registry entry. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56579 -- v2: setupapi: use INF parser to read class GUID and class name setupapi/tests: add tests for reading INF class with %strkey% tokens https://gitlab.winehq.org/wine/wine/-/merge_requests/5519

2 2

[PATCH v3 0/1] MR5521: wevtapi: Add stub EvtCreateRenderContext().
by Vijay Kiran Kamuju (＠infyquest) 20 Apr '24

20 Apr '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52879 -- v3: wevtapi: Add stub EvtCreateRenderContext(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5521

2 1

[PATCH 0/1] MR5521: wevtapi: Add stub EvtCreateRenderContext().
by Vijay Kiran Kamuju (＠infyquest) 20 Apr '24

20 Apr '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52879 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5521

3 2

[PATCH 0/1] MR5523: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW().
by Vijay Kiran Kamuju (＠infyquest) 19 Apr '24

19 Apr '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56576 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5523

2 1

[PATCH 0/1] MR5522: sppc: Add stub SLInstallLicense().
by Vijay Kiran Kamuju (＠infyquest) 19 Apr '24

19 Apr '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56316 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5522

2 1

[PATCH 0/1] MR5520: Draft: ws2_32: Add stub WSCGetApplicationCategory().
by Vijay Kiran Kamuju (＠infyquest) 19 Apr '24

19 Apr '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52208 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5520

2 1

[PATCH 0/2] MR5512: win32u: Fix calculating viewport size incorrectly.
by Haoyang Chen (＠chenhaoyang) 19 Apr '24

19 Apr '24

Calling either SetViewportExtEx or SetWindowExtEx fixes the viewport(MAPPING_FixIsotropic), but if both are called then it is fixed twice. Then the mapping matrix will be incorrect and will not be calculated using the values of viewport and wnd. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5512

2 2

[PATCH v11 0/4] MR777: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual.
by Conor McCarthy (＠cmccarthy) 16 Apr '24

16 Apr '24

Includes !782 to prevent the 32-bit Windows CI crashing. -- v11: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual. tests/hlsl: Add tests for SV_DepthLessEqual and SV_DepthGreaterEqual. tests/hlsl: Add tests for SV_Depth. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/777

2 4

[PATCH v16 0/6] MR631: vkd3d: Implement UpdateTileMappings().
by Conor McCarthy (＠cmccarthy) 16 Apr '24

16 Apr '24

-- v16: vkd3d: Support aliased tile binding if available. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for textures. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for buffers. vkd3d: Pre-bind sparse texture mip tails. tests/d3d12: Add a test for freeing underlying memory of a reserved resource. tests/d3d12: Add tests for UpdateTileMappings(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/631

2 6

[PATCH v2 0/4] MR788: vkd3d: Support additional packed formats.
by Conor McCarthy (＠cmccarthy) 16 Apr '24

16 Apr '24

-- v2: vkd3d: Support DXGI_FORMAT_B4G4R4A4_UNORM. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/788

2 5

Re: [PATCH v3 0/5] MR781: Avoid HLSL_CLASS_OBJECT, part 4.
by Giovanni Mascellani (＠giomasce) 16 Apr '24

16 Apr '24

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.c: > type->reg_size[HLSL_REGSET_TEXTURES] = 1; > break; > > + case HLSL_CLASS_UAV: > + type->reg_size[HLSL_REGSET_UAVS] = 1; > + break; Maybe you just don't care, but this could be ```c case HLSL_CLASS_SAMPLER: case HLSL_CLASS_TEXTURE: case HLSL_CLASS_UAV: type->reg_size[type_get_regset(type)] = 1; break; ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/781#note_67911

1 0

Re: [PATCH v3 0/5] MR781: Avoid HLSL_CLASS_OBJECT, part 4.
by Giovanni Mascellani (＠giomasce) 16 Apr '24

16 Apr '24

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.c: > return type->reg_size[regset]; > } > > +static struct hlsl_type *hlsl_new_simple_type(struct hlsl_ctx *ctx, const char *name, enum hlsl_type_class class) > +{ > + struct hlsl_type *type; > + > + if (!(type = hlsl_alloc(ctx, sizeof(*type)))) > + return NULL; > + if (!(type->name = hlsl_strdup(ctx, name))) > + { > + vkd3d_free(type); > + return NULL; > + } > + type->class = class; This doesn't set `dimx` and `dimy`, while in the documentation for `struct hlsl_type` we specify them for all classes. Either relaxing the specification or setting them here is fine for me, but at least one of those should happen, I think. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/781#note_67910

1 0

Re: [PATCH v3 0/5] MR781: Avoid HLSL_CLASS_OBJECT, part 4.
by Giovanni Mascellani (＠giomasce) 16 Apr '24

16 Apr '24

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/d3dbc.c: > return D3DXPC_STRUCT; > case HLSL_CLASS_VECTOR: > return D3DXPC_VECTOR; > - default: > - ERR("Invalid class %#x.\n", type->class); > - vkd3d_unreachable(); > + case HLSL_CLASS_VOID: > + /* This shouldn't happen. */ Is the comment useful? Doesn't the following `vkd3d_unreachable()` already convey that information? Also, could you please add a `break`? clang seems to be touchy about it: ``` ../libs/vkd3d-shader/d3dbc.c:1521:30: error: label at end of compound statement: expected statement case HLSL_CLASS_VOID: ^ ; 1 error generated. make[1]: *** [libs/vkd3d-shader/libvkd3d_shader_la-d3dbc.lo] Error 1 ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/781#note_67909

1 0

[PATCH v4 0/10] MR768: Draft: vkd3d-shader/dxil: Tessellation part 2.
by Conor McCarthy (＠cmccarthy) 16 Apr '24

16 Apr '24

Goes atop !767. The last five commits belong here. -- v4: vkd3d-shader/dxil: Implement DX intrinsic OutputControlPointID. vkd3d-shader/dxil: Implement DX intrinsic DomainLocation. vkd3d-shader/dxil: Implement DX intrinsic StorePatchConstant. vkd3d-shader/dxil: Implement DX intrinsics LoadOutputControlPoint and LoadPatchConstant. vkd3d-shader/dxil: Support patch constant functions and signatures. vkd3d-shader/ir: Validate tessellation declarations. vkd3d-shader/dxil: Implement DX intrinsic PrimitiveID. vkd3d-shader/dxil: Load hull shader properties. vkd3d-shader/dxil: Load domain shader properties. tests/hlsl: Add a tessellation test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/768

2 10

[PATCH v3 0/3] MR776: vkd3d-shader: Introduce SPIRV_ENVIRONMENT_VULKAN_1_1.
by Conor McCarthy (＠cmccarthy) 16 Apr '24

16 Apr '24

Shader Model 6 wave ops require instructions not available by extension in SPIR-V 1.0, and device support info is found in VkPhysicalDeviceSubgroupProperties, which also has no equivalent by extension in Vulkan 1.0. -- v3: vkd3d-shader: Introduce a wave ops feature flag. vkd3d: Use Vulkan 1.1 if available. vkd3d-shader: Introduce SPIRV_ENVIRONMENT_VULKAN_1_1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/776

2 3

[PATCH v2 0/1] MR795: tests/hlsl: Add wave op tests.
by Conor McCarthy (＠cmccarthy) 16 Apr '24

16 Apr '24

-- v2: tests/hlsl: Add wave op tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/795

2 1

[PATCH 0/4] MR795: tests/hlsl: Add wave op tests.
by Conor McCarthy (＠cmccarthy) 16 Apr '24

16 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/795

3 4

[PATCH v2 0/3] MR785: vkd3d-shader/ir: Only emit trampolines and launchers when needed.
by Giovanni Mascellani (＠giomasce) 16 Apr '24

16 Apr '24

~~This goes atop !773. The last three commits belong to this MR.~~ Trampolines and launchers allow us to handle code doing multilevel jumps, but they partially virtualize the control flow, which potentially makes the jobs of downstream compilers harder. So we avoid them every time we can. -- v2: vkd3d-shader/ir: Only emit launchers when needed. vkd3d-shader/ir: Only emit trampolines when needed. vkd3d-shader/ir: Swap selection branches if the if branch is empty. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/785

3 4

[PATCH v3 0/5] MR684: tests/shader-runner: Improve test coverage.
by Conor McCarthy (＠cmccarthy) 16 Apr '24

16 Apr '24

These tests cover code paths untested in DXIL, except for the last commit which is to catch any signed int resource issues. -- v3: tests/hlsl: Add tests for texture UAV signed atomics. tests/hlsl: Add tests for texture UAV atomics. tests/hlsl: Add a test for UAV InterlockedExchange(). tests/hlsl: Add a test for a structured UAV scalar store. tests/hlsl: Add tests for min() and integer max(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/684

2 6

[PATCH v8 0/5] MR767: vkd3d-shader/dxil: Tessellation part 1.
by Conor McCarthy (＠cmccarthy) 16 Apr '24

16 Apr '24

Doesn't support tessellation yet, but adds some requirements. -- v8: vkd3d-shader/ir: Validate tessellation declarations. vkd3d-shader/dxil: Implement DX intrinsic PrimitiveID. vkd3d-shader/dxil: Load hull shader properties. vkd3d-shader/dxil: Load domain shader properties. tests/hlsl: Add a tessellation test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/767

2 5

[PATCH 0/4] MR794: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 6.
by Francisco Casas (＠fcasas) 16 Apr '24

16 Apr '24

This should be the last piece of the puzzle for SNK games. Basically, support for "if" conditionals for shader model 3.0 and 4.0. This is achieved through the use of the `if_comp` instruction (VKD3DSIH_IFC), but these are not handled by the cf_flattener. So I wrote `vsir_program_lower_ifc()` as a normalization pass to turn them into VKD3DSIH_IF in 3/4. This requires translating the condition of IFC into a separate vsir comparison instruction. I think I got the mapping right in `get_handler_idx_from_rel_op()` but it would be good if someone with more experience in SPIR-V takes a close look. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/794

2 4

[PATCH v2 0/8] MR787: vkd3d-shader/hlsl: Parse and write default values.
by Francisco Casas (＠fcasas) 15 Apr '24

15 Apr '24

-- v2: vkd3d-shader/hlsl: Reorder default values for matrices. vkd3d-shader/hlsl: Fix numeric register offset for matrix components. tests: Text matrix default value initializers. vkd3d-shader/tpf: Write default values. vkd3d-shader/hlsl: Initialize default values with braceless initializers. vkd3d-shader/hlsl: Record default values for uniforms and constant buffers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/787

3 11

[PATCH 0/5] MR793: hlsl: Parse profile and register space reservations.
by Zebediah Figura (＠zfigura) 15 Apr '24

15 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/793

2 5

[PATCH 0/2] MR5502: notepad: Use wide character string literals
by Isaac Marovitz (＠IsaacMarovitz) 15 Apr '24

15 Apr '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5502

2 2

[PATCH 0/1] MR792: Draft: vkd3d-shader/hlsl: Support expressions as register offsets.
by Victor Chiletto (＠vitorhnn) 15 Apr '24

15 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/792

2 1

Re: [PATCH v2 0/2] MR790: vkd3d: Implement creating compute pipeline states from shaders with embedded root signatures. - approved
by Alexandre Julliard (＠julliard) 15 Apr '24

15 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/790

1 0

Re: [PATCH v2 0/6] MR789: [2/2] vkd3d-shader/d3d-asm: Unify the output generation helpers. - approved
by Alexandre Julliard (＠julliard) 15 Apr '24

15 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/789

1 0

Re: [PATCH v2 0/1] MR782: tests/hlsl: Supply data for all mip levels in calculate-lod.shader_test. - approved
by Alexandre Julliard (＠julliard) 15 Apr '24

15 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/782

1 0

Re: [PATCH v4 0/3] MR779: vkd3d-shader/spirv: Implement MAD in two operations if flagged as precise. - approved
by Alexandre Julliard (＠julliard) 15 Apr '24

15 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/779

1 0

Re: [PATCH v5 0/7] MR778: vkd3d-shader/ir: Prepare the CFG structurizer for handling Hull Shaders. - approved
by Alexandre Julliard (＠julliard) 15 Apr '24

15 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/778

1 0

Re: [PATCH v5 0/3] MR773: vkd3d-shader/ir: Try harder to move `break's to the end of loops. - approved
by Alexandre Julliard (＠julliard) 15 Apr '24

15 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/773

1 0

Re: [PATCH v7 0/2] MR740: Implement hyperbolic trigonometry operations. - approved
by Alexandre Julliard (＠julliard) 15 Apr '24

15 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/740

1 0

[PATCH v3 0/5] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) 15 Apr '24

15 Apr '24

-- v3: ntdll: Store exception reporting flags for debug events. ntdll: Store exception reporting flags on suspend. ntdll: Store exception reporting flags in server context. ntdll: Set exception reporting flags in NtGetContextThread(). ntdll/tests: Add tests for CONTEXT_EXCEPTION_REQUEST. https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

3 6

[PATCH 0/4] MR791: vkd3d: Memory only cache operation
by Stefan Dösinger (＠stefan) 15 Apr '24

15 Apr '24

There is one FIXME left where I need advice: The treatment of not 8 byte aligned inputs in vkd3d_shader_cache_hash_key(), in particular regarding endianness. I think it is fairly theoretical as there are few big endian systems left that matter (and I don't have any), but I am not even sure if I am treating this right on little endian machines. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/791

2 4

[PATCH v21 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Conor McCarthy (＠cmccarthy) 15 Apr '24

15 Apr '24

-- v21: vkd3d-shader/dxil: Implement DX intrinsic RenderTargetGetSampleCount. vkd3d-shader/dxil: Implement DX intrinsics Texture2DMSGetSamplePosition and RenderTargetGetSamplePosition. tests/hlsl: Add tests for GetSamplePosition() and GetSampleCount(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734

2 3

[PATCH v12 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) 15 Apr '24

15 Apr '24

Test module references created by resolving forwarded exports. The following diagram (best viewed in light mode due to fixed colors) explains what happens in bug #52094 under the hood: ```mermaid graph TB subgraph state_00["Initial"] direction LR s00_ida[ida64.dll] ~~~ s00_idapy[idapython64.dll] -. "(import)" .-> s00_py3[python3.dll] -. "(forwards to)" .-> s00_py311[python311.dll] end state_00 -. "1. <code>LoadLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_01 subgraph state_01["python311.dll loaded"] direction LR s01_ida[ida64.dll] ~~~ s01_idapy[idapython64.dll] -. "(import)" .-> s01_py3[python3.dll] -. "(forwards to)" .-> s01_py311[python311.dll] s01_ida -- "dynamic ref" --> s01_py311 end state_01 -. "2. <code>LoadLibrary("</code>idapython64.dll<code>")</code>" .-> state_02 subgraph state_02["idapython64.dll loaded"] direction LR s02_ida[ida64.dll] -- "dynamic ref" --> s02_idapy[idapython64.dll] -- "static ref" --> s02_py3[python3.dll] -. "(forwards to)" .-> s02_py311[python311.dll] s02_ida -- "dynamic ref" --> s02_py311 s02_idapy -- "static forwarded ref" --> s02_py311 end state_02 -. "3. <code>FreeLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_03 subgraph state_03["python311.dll reference removed"] direction LR style s03_py311 color:#f00,stroke:#f00 s03_ida[ida64.dll] -- "dynamic ref" --> s03_idapy[idapython64.dll] -- "static ref" --> s03_py3[python3.dll] -. "(forwards to)" .-> s03_py311[python311.dll] s03_ida -. "<del>dynamic ref (deleted)</del>" .-> s03_py311 s03_idapy -- "static forwarded ref" --> s03_py311 end ``` On Windows, the static forwarded ref keeps `python311.dll` from being unloaded; however, Wine is missing this behavior, causing it to be unloaded and segfault immediately (since further initialization happens just after step 3 FreeLibrary). The tests aim to reproduce this condition. -- v12: kernel32/tests: Test module refcounting with forwarded exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/364

2 1

[PATCH 0/2] MR790: vkd3d: Implement creating compute pipeline states from shaders with embedded root signatures.
by Henri Verbeet (＠hverbeet) 15 Apr '24

15 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/790

2 2

[PATCH 0/6] MR789: [2/2] vkd3d-shader/d3d-asm: Unify the output generation helpers.
by Henri Verbeet (＠hverbeet) 15 Apr '24

15 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/789

2 6

[PATCH v20 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Conor McCarthy (＠cmccarthy) 15 Apr '24

15 Apr '24

-- v20: vkd3d-shader/dxil: Implement DX intrinsic RenderTargetGetSampleCount. vkd3d-shader/dxil: Implement DX intrinsics Texture2DMSGetSamplePosition and RenderTargetGetSamplePosition. tests/hlsl: Add tests for GetSamplePosition() and GetSampleCount(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734

2 3

[PATCH 0/2] MR784: tests: Check that derivatives are still computed after discarding.
by Giovanni Mascellani (＠giomasce) 15 Apr '24

15 Apr '24

A couple of follow-ups to !774. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/784

3 6

[PATCH 0/4] MR788: vkd3d: Support additional packed formats.
by Conor McCarthy (＠cmccarthy) 15 Apr '24

15 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/788

3 6

[PATCH 0/1] MR782: tests/hlsl: Supply data for all mip levels in calculate-lod.shader_test.
by Conor McCarthy (＠cmccarthy) 15 Apr '24

15 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/782

4 3

[PATCH v3 0/3] MR779: vkd3d-shader/spirv: Implement MAD in two operations if flagged as precise.
by Giovanni Mascellani (＠giomasce) 15 Apr '24

15 Apr '24

Based on !723. -- v3: vkd3d-shader/ir: Implement MAD in two operations if flagged as precise. vkd3d-shader/ir: Move DCL_TEMPS removal to the generic instruction lowering pass. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/779

4 5

[PATCH v4 0/7] MR778: vkd3d-shader/ir: Prepare the CFG structurizer for handling Hull Shaders.
by Giovanni Mascellani (＠giomasce) 15 Apr '24

15 Apr '24

Hull Shaders contain two functions instead of just one, so all the algorithms that require computing a CFG need to be run twice. Here we refactor the code so that this can be done more easily. This MR is relatively long, but it is essentially just moving code around, so hopefully it is not too difficult to review anyway. -- v4: vkd3d-shader/ir: Split handling jumps when emitting a structured program. vkd3d-shader/ir: Split handling selections when emitting a structured program. vkd3d-shader/ir: Split handling loops when emitting a structured program. vkd3d-shader/ir: Split handling blocks when emitting a structured program. vkd3d-shader/ir: Refactor declaration emission outside of the CFG structure. vkd3d-shader/ir: Split undominated SSA materialization. vkd3d-shader/ir: Split program structurization. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/778

3 9

[PATCH v4 0/3] MR773: vkd3d-shader/ir: Try harder to move `break's to the end of loops.
by Giovanni Mascellani (＠giomasce) 15 Apr '24

15 Apr '24

~~This goes atop !764. The last three commits belong to this MR.~~ Since we want to get rid of loops and 'break's as much as possible, we try to move 'break's out of selection constructs as much as possible so it's easier to match them with loops. This MR introduces a few other tricks to help that. -- v4: vkd3d-shader/ir: Move breaks out of selections again after having optimized loops. vkd3d-shader/ir: Append code to the non-breaking branch if there is breaking one. vkd3d-shader/ir: Prepare for changing the destination list in vsir_cfg_optimize_recurse(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/773

3 4

[PATCH v6 0/2] MR740: Implement hyperbolic trigonometry operations.
by Petrichor Park (＠petrathekat) 15 Apr '24

15 Apr '24

I'm working on adding all the intrinsics we haven't implemented yet. Here's sinh, cosh, and tanh. Sinh/cosh are implemented in the same commit because they forward to the same backing function (because the identities used only differ by a plus or minus). -- v6: vkd3d-shader/hlsl: Implement tanh. vkd3d-shader/hlsl: Implement hyperbolic sin and cos. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/740

3 4

[PATCH 0/1] MR783: ci: Compile Mesa with X11 support.
by Giovanni Mascellani (＠giomasce) 15 Apr '24

15 Apr '24

Some tests require Vulkan extension VK_KHR_surface, which is not exposed by Mesa unless at least a platform is configured. Hopefully this should at last make llvmpipe 24 not crash in d3d12. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/783

3 3

[PATCH v7 0/5] MR767: vkd3d-shader/dxil: Tessellation part 1.
by Conor McCarthy (＠cmccarthy) 15 Apr '24

15 Apr '24

Doesn't support tessellation yet, but adds some requirements. -- v7: vkd3d-shader/ir: Validate tessellation declarations. vkd3d-shader/dxil: Implement DX intrinsic PrimitiveID. vkd3d-shader/dxil: Load hull shader properties. vkd3d-shader/dxil: Load domain shader properties. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/767

4 7

[PATCH v19 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Conor McCarthy (＠cmccarthy) 15 Apr '24

15 Apr '24

-- v19: vkd3d-shader/dxil: Implement DX intrinsic RenderTargetGetSampleCount. vkd3d-shader/dxil: Implement DX intrinsics Texture2DMSGetSamplePosition and RenderTargetGetSamplePosition. tests/hlsl: Add tests for GetSamplePosition() and GetSampleCount(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734

3 4

[PATCH v10 0/4] MR777: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual.
by Conor McCarthy (＠cmccarthy) 15 Apr '24

15 Apr '24

Includes !782 to prevent the 32-bit Windows CI crashing. -- v10: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual. tests/hlsl: Add tests for SV_DepthLessEqual and SV_DepthGreaterEqual. tests/hlsl: Add tests for SV_Depth. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/777

3 7

[PATCH v2 0/3] MR5500: d3d9: Add a few swapchain tests
by Robin Kertels (＠K0bin) 14 Apr '24

14 Apr '24

Creates test for the following things: - Whether a combination of BackBufferCount + SwapEffect results in another buffer being added that acts as a front buffer. We used to have bugs caused by this in DXVK ages ago. - GetFrontBufferData actually copying data from the front buffer to the target surface and not from one of the back buffers. This is motivated by a DXVK bug with a modded version of Silent Hill 2 we had recently. - GetFrontBufferData produces a specific fixed alpha value depending on whether the swapchain is windowed or fullscreen. That's a TODO for now because neither Wine nor DXVK implements this and it's a bit annoying to implement this while not a single application is known to rely on this. - GetFrontBufferData is supposed to capture a screenshot of the entire monitor. So this MR adds a test to make sure that the application window is positioned correctly in the target surface after calling GetFrontBufferData. Total War Medieval 2 actually hit this issue with DXVK on its loading screen in windowed mode. All the new tests pass on Windows 11 on the Nvidia D3D9 driver. -- v2: d3d9: Add test for GetFrontBufferData window placement. https://gitlab.winehq.org/wine/wine/-/merge_requests/5500

3 4

[PATCH 0/3] MR5500: d3d9: Add a few swapchain tests
by Robin Kertels (＠K0bin) 14 Apr '24

14 Apr '24

Creates test for the following things: - Whether a combination of BackBufferCount + SwapEffect results in another buffer being added that acts as a front buffer. We used to have bugs caused by this in DXVK ages ago. - GetFrontBufferData actually copying data from the front buffer to the target surface and not from one of the back buffers. This is motivated by a DXVK bug with a modded version of Silent Hill 2 we had recently. - GetFrontBufferData produces a specific fixed alpha value depending on whether the swapchain is windowed or fullscreen. That's a TODO for now because neither Wine nor DXVK implements this and it's a bit annoying to implement this while not a single application is known to rely on this. - GetFrontBufferData is supposed to capture a screenshot of the entire monitor. So this MR adds a test to make sure that the application window is positioned correctly in the target surface after calling GetFrontBufferData. Total War Medieval 2 actually hit this issue with DXVK on its loading screen in windowed mode. All the new tests pass on Windows 11 on the Nvidia D3D9 driver. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5500

3 4

[PATCH 0/1] MR5499: mscms: Add stub for WcsGetDefaultColorProfile.
by Vijay Kiran Kamuju (＠infyquest) 14 Apr '24

14 Apr '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56554 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5499

2 1

[PATCH v4 0/1] MR5497: ntdll: Implement NtQueueApcThreadEx()
by Isaac Marovitz (＠IsaacMarovitz) 13 Apr '24

13 Apr '24

Should resolve a crash in `libogg` in the game "Cabal Online" -- v4: ntdll: Implement NtQueueApcThreadEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

3 2

[PATCH v2 0/1] MR5497: ntdll: Implement NtQueueApcThreadEx()
by Isaac Marovitz (＠IsaacMarovitz) 13 Apr '24

13 Apr '24

Should resolve a crash in `libogg` in the game "Cabal Online" -- v2: ntdll: Implement NtQueueApcThreadEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

3 2

[PATCH v2 0/1] MR5498: krnl386.exe16: Start DOSVM timer on GET_SYSTEM_TIME
by Liam Middlebrook (＠liam-middlebrook) 13 Apr '24

13 Apr '24

Start the DOSVM tick timer when the GET_SYSTEM_TIME interrupt (int 1a ah 00) is fired. This fixes a bug when running Sid Meier's CIVILIZATION for Windows 3.1 where the game would appear to hang at the launch screen (although sound would play as expected). This was due to the BIOSDATA.Ticks field never being updated. I originally had written a version of this patch which moved away from using `BIOSDATA.Ticks` until I saw that the timer thread existed and seemed like a more sensible option. -- v2: krnl386.exe16: Start DOSVM timer on GET_SYSTEM_TIME https://gitlab.winehq.org/wine/wine/-/merge_requests/5498

2 1

[PATCH 0/1] MR5497: ntdll: Implement NtQueueApcThreadEx()
by Isaac Marovitz (＠IsaacMarovitz) 13 Apr '24

13 Apr '24

Should resolve a crash in `libogg` in the game "Cabal Online" -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

2 1

[PATCH v9 0/3] MR777: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual.
by Conor McCarthy (＠cmccarthy) 13 Apr '24

13 Apr '24

Includes !782 to prevent the 32-bit Windows CI crashing. -- v9: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual. tests/hlsl: Add pixel shader depth-out tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/777

2 4

[PATCH 0/8] MR787: vkd3d-shader/hlsl: Parse and write default values.
by Francisco Casas (＠fcasas) 13 Apr '24

13 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/787

2 8

[PATCH v2 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 12 Apr '24

12 Apr '24

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. -- v2: ntdll: Properly track refcount with forwarded exports. ntdll: Update current_modref in LdrGetProcedureAddress(). ntdll: De-duplicate module dependency edges. ntdll: Introduce struct dependency_edge as wrapper around LDR_DEPENDENCY. kernel32/tests: Test module refcounting with forwarded exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/7

3 6

[PATCH v4 0/5] MR786: vkd3d-shader/hlsl: Loop unrolling, part 1.
by Victor Chiletto (＠vitorhnn) 12 Apr '24

12 Apr '24

This is a simplified version of !748 that doesn't handle conditional jumps. I'll submit a cleaned up version of that after this. -- v4: vkd3d-shader/hlsl: Implement loop unrolling. vkd3d-shader/hlsl: Parse loop and unroll loop attributes. vkd3d-shader/hlsl: Pull evaluate_static_expression_as_uint upwards. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/786

2 5

[PATCH v3 0/5] MR786: vkd3d-shader/hlsl: Loop unrolling, part 1.
by Victor Chiletto (＠vitorhnn) 12 Apr '24

12 Apr '24

This is a simplified version of !748 that doesn't handle conditional jumps. I'll submit a cleaned up version of that after this. -- v3: vkd3d-shader/hlsl: Implement loop unrolling. vkd3d-shader/hlsl: Parse loop and unroll loop attributes. vkd3d-shader/hlsl: Pull evaluate_static_expression_as_uint upwards. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/786

2 5

[PATCH v2 0/5] MR786: vkd3d-shader/hlsl: Loop unrolling, part 1.
by Victor Chiletto (＠vitorhnn) 12 Apr '24

12 Apr '24

This is a simplified version of !748 that doesn't handle conditional jumps. I'll submit a cleaned up version of that after this. -- v2: vkd3d-shader/hlsl: Implement loop unrolling. vkd3d-shader/hlsl: Parse loop and unroll loop attributes. vkd3d-shader/hlsl: Pull evaluate_static_expression_as_uint upwards. vkd3d-shader/hlsl: Defer bounds checks to after copy propagation. tests/hlsl: Add a test for dynamically indexed multisampled texture loads. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/786

2 5

[PATCH 0/6] MR748: vkd3d-shader/hlsl: Implement loop unrolling.
by Victor Chiletto (＠vitorhnn) 12 Apr '24

12 Apr '24

The general idea is: * Run copy prop initially, save the copy prop state. * Unroll one iteration, substitute all jumps by stores to synthetic control vars, move all instructions after the jumps to checks to those control vars. * Run copy prop on the iteration, using the previous iteration's or the root's state as the parent state. * Probe the copy prop state to check if the "loop_broken" control variable was set, stop unrolling if it true, otherwise continue. Some stuff I'm less sure about and would love comments on: * The way I deferred bounds checking. * Splitting the iter block from the body. This was needed because otherwise copy prop marks variable that are changed in iter blocks (e.g "i++") as invalidated and does not propagate them to subsequent iterations. * Messing around with copy prop internals. I attempted two other similar solutions that were less invasive: running copy prop on the entire block after each unroll and running copy prop once, after unrolling to `max_iterations`, both were too slow to be viable. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/748

5 25

[PATCH 0/5] MR5493: Extend minidump support in winedump.
by eric pouech (＠epo) 12 Apr '24

12 Apr '24

Improve minidump dumping in Wine dump: - support several -j options to only print relevant part of the file - support a bunch of new streams (memory list, token, thread names...) - several other cleanups and homogeinization of output -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5493

2 5

[PATCH 0/2] MR5492: Embed thread names in minidump.
by eric pouech (＠epo) 12 Apr '24

12 Apr '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5492

2 2

[PATCH v11 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) 12 Apr '24

12 Apr '24

Test module references created by resolving forwarded exports. The following diagram (best viewed in light mode due to fixed colors) explains what happens in bug #52094 under the hood: ```mermaid graph TB subgraph state_00["Initial"] direction LR s00_ida[ida64.dll] ~~~ s00_idapy[idapython64.dll] -. "(import)" .-> s00_py3[python3.dll] -. "(forwards to)" .-> s00_py311[python311.dll] end state_00 -. "1. <code>LoadLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_01 subgraph state_01["python311.dll loaded"] direction LR s01_ida[ida64.dll] ~~~ s01_idapy[idapython64.dll] -. "(import)" .-> s01_py3[python3.dll] -. "(forwards to)" .-> s01_py311[python311.dll] s01_ida -- "dynamic ref" --> s01_py311 end state_01 -. "2. <code>LoadLibrary("</code>idapython64.dll<code>")</code>" .-> state_02 subgraph state_02["idapython64.dll loaded"] direction LR s02_ida[ida64.dll] -- "dynamic ref" --> s02_idapy[idapython64.dll] -- "static ref" --> s02_py3[python3.dll] -. "(forwards to)" .-> s02_py311[python311.dll] s02_ida -- "dynamic ref" --> s02_py311 s02_idapy -- "static forwarded ref" --> s02_py311 end state_02 -. "3. <code>FreeLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_03 subgraph state_03["python311.dll reference removed"] direction LR style s03_py311 color:#f00,stroke:#f00 s03_ida[ida64.dll] -- "dynamic ref" --> s03_idapy[idapython64.dll] -- "static ref" --> s03_py3[python3.dll] -. "(forwards to)" .-> s03_py311[python311.dll] s03_ida -. "<del>dynamic ref (deleted)</del>" .-> s03_py311 s03_idapy -- "static forwarded ref" --> s03_py311 end ``` On Windows, the static forwarded ref keeps `python311.dll` from being unloaded; however, Wine is missing this behavior, causing it to be unloaded and segfault immediately (since further initialization happens just after step 3 FreeLibrary). The tests aim to reproduce this condition. -- v11: kernel32/tests: Test module refcounting with forwarded exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/364

3 2

[PATCH v8 0/3] MR777: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual.
by Conor McCarthy (＠cmccarthy) 12 Apr '24

12 Apr '24

Includes !782 to prevent the 32-bit Windows CI crashing. -- v8: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual. tests/hlsl: Add an SV_Depth test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/777

2 3

[PATCH v7 0/3] MR777: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual.
by Conor McCarthy (＠cmccarthy) 12 Apr '24

12 Apr '24

Includes !782 to prevent the 32-bit Windows CI crashing. -- v7: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual. tests/hlsl: Add an SV_Depth test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/777

2 3

[PATCH v10 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) 12 Apr '24

12 Apr '24

Test module references created by resolving forwarded exports. The following diagram (best viewed in light mode due to fixed colors) explains what happens in bug #52094 under the hood: ```mermaid graph TB subgraph state_00["Initial"] direction LR s00_ida[ida64.dll] ~~~ s00_idapy[idapython64.dll] -. "(import)" .-> s00_py3[python3.dll] -. "(forwards to)" .-> s00_py311[python311.dll] end state_00 -. "1. <code>LoadLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_01 subgraph state_01["python311.dll loaded"] direction LR s01_ida[ida64.dll] ~~~ s01_idapy[idapython64.dll] -. "(import)" .-> s01_py3[python3.dll] -. "(forwards to)" .-> s01_py311[python311.dll] s01_ida -- "dynamic ref" --> s01_py311 end state_01 -. "2. <code>LoadLibrary("</code>idapython64.dll<code>")</code>" .-> state_02 subgraph state_02["idapython64.dll loaded"] direction LR s02_ida[ida64.dll] -- "dynamic ref" --> s02_idapy[idapython64.dll] -- "static ref" --> s02_py3[python3.dll] -. "(forwards to)" .-> s02_py311[python311.dll] s02_ida -- "dynamic ref" --> s02_py311 s02_idapy -- "static forwarded ref" --> s02_py311 end state_02 -. "3. <code>FreeLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_03 subgraph state_03["python311.dll reference removed"] direction LR style s03_py311 color:#f00,stroke:#f00 s03_ida[ida64.dll] -- "dynamic ref" --> s03_idapy[idapython64.dll] -- "static ref" --> s03_py3[python3.dll] -. "(forwards to)" .-> s03_py311[python311.dll] s03_ida -. "<del>dynamic ref (deleted)</del>" .-> s03_py311 s03_idapy -- "static forwarded ref" --> s03_py311 end ``` On Windows, the static forwarded ref keeps `python311.dll` from being unloaded; however, Wine is missing this behavior, causing it to be unloaded and segfault immediately (since further initialization happens just after step 3 FreeLibrary). The tests aim to reproduce this condition. -- v10: kernel32/tests: Test module refcounting with forwarded exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/364

2 1

[PATCH v9 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) 12 Apr '24

12 Apr '24

Test module references created by resolving forwarded exports. The following diagram (best viewed in light mode due to fixed colors) explains what happens in bug #52094 under the hood: ```mermaid graph TB subgraph state_00["Initial"] direction LR s00_ida[ida64.dll] ~~~ s00_idapy[idapython64.dll] -. "(import)" .-> s00_py3[python3.dll] -. "(forwards to)" .-> s00_py311[python311.dll] end state_00 -. "1. <code>LoadLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_01 subgraph state_01["python311.dll loaded"] direction LR s01_ida[ida64.dll] ~~~ s01_idapy[idapython64.dll] -. "(import)" .-> s01_py3[python3.dll] -. "(forwards to)" .-> s01_py311[python311.dll] s01_ida -- "dynamic ref" --> s01_py311 end state_01 -. "2. <code>LoadLibrary("</code>idapython64.dll<code>")</code>" .-> state_02 subgraph state_02["idapython64.dll loaded"] direction LR s02_ida[ida64.dll] -- "dynamic ref" --> s02_idapy[idapython64.dll] -- "static ref" --> s02_py3[python3.dll] -. "(forwards to)" .-> s02_py311[python311.dll] s02_ida -- "dynamic ref" --> s02_py311 s02_idapy -- "static forwarded ref" --> s02_py311 end state_02 -. "3. <code>FreeLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_03 subgraph state_03["python311.dll reference removed"] direction LR style s03_py311 color:#f00,stroke:#f00 s03_ida[ida64.dll] -- "dynamic ref" --> s03_idapy[idapython64.dll] -- "static ref" --> s03_py3[python3.dll] -. "(forwards to)" .-> s03_py311[python311.dll] s03_ida -. "<del>dynamic ref (deleted)</del>" .-> s03_py311 s03_idapy -- "static forwarded ref" --> s03_py311 end ``` On Windows, the static forwarded ref keeps `python311.dll` from being unloaded; however, Wine is missing this behavior, causing it to be unloaded and segfault immediately (since further initialization happens just after step 3 FreeLibrary). The tests aim to reproduce this condition. -- v9: kernel32/tests: Test module refcounting with forwarded exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/364

2 1

[PATCH v7 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) 12 Apr '24

12 Apr '24

Test module references created by resolving forwarded exports. The following diagram (best viewed in light mode due to fixed colors) explains what happens in bug #52094 under the hood: ```mermaid graph TB subgraph state_00["Initial"] direction LR s00_ida[ida64.dll] ~~~ s00_idapy[idapython64.dll] -. "(import)" .-> s00_py3[python3.dll] -. "(forwards to)" .-> s00_py311[python311.dll] end state_00 -. "1. <code>LoadLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_01 subgraph state_01["python311.dll loaded"] direction LR s01_ida[ida64.dll] ~~~ s01_idapy[idapython64.dll] -. "(import)" .-> s01_py3[python3.dll] -. "(forwards to)" .-> s01_py311[python311.dll] s01_ida -- "dynamic ref" --> s01_py311 end state_01 -. "2. <code>LoadLibrary("</code>idapython64.dll<code>")</code>" .-> state_02 subgraph state_02["idapython64.dll loaded"] direction LR s02_ida[ida64.dll] -- "dynamic ref" --> s02_idapy[idapython64.dll] -- "static ref" --> s02_py3[python3.dll] -. "(forwards to)" .-> s02_py311[python311.dll] s02_ida -- "dynamic ref" --> s02_py311 s02_idapy -- "static forwarded ref" --> s02_py311 end state_02 -. "3. <code>FreeLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_03 subgraph state_03["python311.dll reference removed"] direction LR style s03_py311 color:#f00,stroke:#f00 s03_ida[ida64.dll] -- "dynamic ref" --> s03_idapy[idapython64.dll] -- "static ref" --> s03_py3[python3.dll] -. "(forwards to)" .-> s03_py311[python311.dll] s03_ida -. "<del>dynamic ref (deleted)</del>" .-> s03_py311 s03_idapy -- "static forwarded ref" --> s03_py311 end ``` On Windows, the static forwarded ref keeps `python311.dll` from being unloaded; however, Wine is missing this behavior, causing it to be unloaded and segfault immediately (since further initialization happens just after step 3 FreeLibrary). The tests aim to reproduce this condition. -- v7: kernel32/tests: Test module refcounting with forwarded exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/364

2 1

[PATCH v6 0/3] MR777: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual.
by Conor McCarthy (＠cmccarthy) 12 Apr '24

12 Apr '24

-- v6: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual. tests/hlsl: Add an SV_Depth test. tests/hlsl: Supply data for all mip levels in calculate-lod.shader_test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/777

3 8

[PATCH 0/6] MR785: Draft: vkd3d-shader/ir: Only emit trampolines and launchers when needed.
by Giovanni Mascellani (＠giomasce) 12 Apr '24

12 Apr '24

This goes atop !773. The last three commits belong to this MR. Trampolines and launchers allow us to handle code doing multilevel jumps, but they partially virtualize the control flow, which potentially makes the jobs of downstream compilers harder. So we avoid them every time we can. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/785

2 7

[PATCH v3 0/7] MR778: vkd3d-shader/ir: Prepare the CFG structurizer for handling Hull Shaders.
by Giovanni Mascellani (＠giomasce) 12 Apr '24

12 Apr '24

Hull Shaders contain two functions instead of just one, so all the algorithms that require computing a CFG need to be run twice. Here we refactor the code so that this can be done more easily. This MR is relatively long, but it is essentially just moving code around, so hopefully it is not too difficult to review anyway. -- v3: vkd3d-shader/ir: Split handling jumps when emitting a structured program. vkd3d-shader/ir: Split handling selections when emitting a structured program. vkd3d-shader/ir: Split handling loops when emitting a structured program. vkd3d-shader/ir: Split handling blocks when emitting a structured program. vkd3d-shader/ir: Refactor declaration emission outside of the CFG structure. vkd3d-shader/ir: Split undominated SSA materialization. vkd3d-shader/ir: Split program structurization. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/778

3 9

Re: [PATCH v2 0/7] MR778: vkd3d-shader/ir: Prepare the CFG structurizer for handling Hull Shaders.
by Giovanni Mascellani (＠giomasce) 12 Apr '24

12 Apr '24

On Fri Apr 12 07:05:03 2024 +0000, Conor McCarthy wrote: > The `Split handling * when emitting a structured program` commits do no > more than move code to helper functions, right? Maybe the commit > messages should state that instead. Yes, that's what they do, and that's what "splitting" means in my mind. I'm not terribly attached to that formulation, though, so if you have another suggestion I can use yours. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/778#note_67687

1 0

[PATCH 0/7] MR778: vkd3d-shader/ir: Prepare the CFG structurizer per handling Hull Shaders.
by Giovanni Mascellani (＠giomasce) 12 Apr '24

12 Apr '24

Hull Shaders contain two functions instead of just one, so all the algorithms that require computing a CFG need to be run twice. Here we refactor the code so that this can be done more easily. This MR is relatively long, but it is essentially just moving code around, so hopefully it is not too difficult to review anyway. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/778

3 11

[PATCH v3 0/3] MR773: vkd3d-shader/ir: Try harder to move `break's to the end of loops.
by Giovanni Mascellani (＠giomasce) 12 Apr '24

12 Apr '24

~~This goes atop !764. The last three commits belong to this MR.~~ Since we want to get rid of loops and 'break's as much as possible, we try to move 'break's out of selection constructs as much as possible so it's easier to match them with loops. This MR introduces a few other tricks to help that. -- v3: vkd3d-shader/ir: Move breaks out of selections again after having optimized loops. vkd3d-shader/ir: Append code to the non-breaking branch if there is breaking one. vkd3d-shader/ir: Prepare for changing the destination list in vsir_cfg_optimize_recurse(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/773

3 5

[PATCH v2 0/3] MR779: vkd3d-shader/spirv: Implement MAD in two operations if flagged as precise.
by Giovanni Mascellani (＠giomasce) 12 Apr '24

12 Apr '24

Based on !723. -- v2: vkd3d-shader/ir: Implement MAD in two operations if flagged as precise. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/779

4 6

[PATCH 0/5] MR781: Avoid HLSL_CLASS_OBJECT, part 4.
by Zebediah Figura (＠zfigura) 12 Apr '24

12 Apr '24

Or: "Get rid of HLSL_CLASS_OBJECT, part 1." -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/781

2 5

[PATCH v5 0/2] MR777: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual.
by Conor McCarthy (＠cmccarthy) 12 Apr '24

12 Apr '24

-- v5: vkd3d-shader/dxil: Support SV_Depth, SV_DepthGreaterEqual and SV_DepthLessEqual. tests/hlsl: Add an SV_Depth test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/777

2 2

[PATCH v5 0/2] MR740: Implement hyperbolic trigonometry operations.
by Petrichor Park (＠petrathekat) 12 Apr '24

12 Apr '24

I'm working on adding all the intrinsics we haven't implemented yet. Here's sinh, cosh, and tanh. Sinh/cosh are implemented in the same commit because they forward to the same backing function (because the identities used only differ by a plus or minus). -- v5: vkd3d-shader/hlsl: Implement tanh. vkd3d-shader/hlsl: Implement hyperbolic sin and cos. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/740

3 4

Re: [PATCH v2 0/1] MR780: configure: Use AC_CHECK_TOOL to check for widl. - approved
by Alexandre Julliard (＠julliard) 11 Apr '24

11 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/780

1 0

Re: [PATCH v3 0/3] MR764: vkd3d-shader/ir: Remove loops that terminate with a `break'. - approved
by Alexandre Julliard (＠julliard) 11 Apr '24

11 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/764

1 0

Re: [PATCH v2 0/1] MR774: tests: Check that side effects do not happen after discard. - approved
by Alexandre Julliard (＠julliard) 11 Apr '24

11 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/774

1 0

Re: [PATCH v4 0/3] MR769: vkd3d-shader/hlsl: Support refract() intrinsic. - approved
by Alexandre Julliard (＠julliard) 11 Apr '24

11 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/769

1 0

2025

2024

2023

2022

wine-gitlab