- wine-gitlab - winehq.org

Re: [PATCH v4 0/1] MR1418: msvcm: add stubs to avoid Athenas ASS and IL-DSP crash.
by Piotr Caban (＠piotr) 30 Nov '22

30 Nov '22

On Wed Nov 30 17:41:13 2022 +0000, Bartosz Kosiorek wrote: > Thanks Piotr for detailed analysis. > I have found following information about `__clrcall`: > https://learn.microsoft.com/en-us/cpp/cpp/clrcall?view=msvc-140 > Unfortunately I don't know how `__clrcall` could be implemented It should be OK to use __fastcall instead (__fastcall is already used in wine). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1418#note_18100

1 0

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Jacek Caban (＠jacek) 30 Nov '22

30 Nov '22

On Wed Nov 30 10:54:56 2022 +0000, Georg Lehmann wrote: > Yes, we can remove it when we stop using direct calls for descriptor set > updates. But at the moment I really don't want to have worse performance > with descriptor buffers compared to descriptor sets caused by wine. > Especially since it's unlikely that Rémi's work will be in 8.0. > This is not just some theoretical problem. With the current non direct > calls, vkd3d-proton's descriptor buffer path regresses performance for > radv users. I'm more optimistic about 8.0. Anyway, I wouldn't mind committing it if we need to. At the same time, since there is an active work on the final solution, we may as well wait a few days and see how it goes. Let me defer that to Alexandre (I think he took over that optimization work). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18096

1 0

[PATCH v2 0/1] MR1614: wined3d: Use unsigned int for "refcount" variables.
by Zebediah Figura (＠zfigura) 30 Nov '22

30 Nov '22

-- v2: wined3d: Use unsigned int for "refcount" variables. https://gitlab.winehq.org/wine/wine/-/merge_requests/1614

4 4

Re: [PATCH v4 0/1] MR1418: msvcm: add stubs to avoid Athenas ASS and IL-DSP crash.
by Bartosz Kosiorek (＠gang65) 30 Nov '22

30 Nov '22

On Wed Nov 30 17:41:13 2022 +0000, Piotr Caban wrote: > I've finally found time to review it properly. Sorry for the delay. > The patch needs lots of cleanup - starting from separating it into > multiple patches (preferably adding one function in every patch) and > changing commit message to describe what the patch implements (instead > of what application it fixes). Taking in account next comments, I would > suggest picking one function first and sending more patches after it > gets in. > I'm worried about adding the stubs (instead of full implementation). The > functions are returning reference to object that can never be NULL on > Windows. I'm expecting it to crash if application tries to use returned object. > On the implementation note, I've done some initial testing of > _Cout_func. It looks like it's almost compatible with msvcr80. The only > difference I have found is that it uses __clrcall calling convention for > virtual functions. I haven't found documentation for it but it seems to > be similar to __fastcall (it additionally allows lazy compilation on > function call but it can be probably ignored). Anyway I think that the > way to go is to either copy implementation from msvcp and change > relevant calling conventions or try to use PARENTSRC (I'm not sure if it > will work well without trying). Thanks Piotr for detailed analysis. I have found following information about `__clrcall`: https://learn.microsoft.com/en-us/cpp/cpp/clrcall?view=msvc-140 Unfortunately I don't know how `__clrcall` could be implemented -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1418#note_18094

1 0

[PATCH v2 0/7] MR1598: jscript/mshtml: More misc fixes.
by Gabriel Ivăncescu (＠insn) 30 Nov '22

30 Nov '22

For the image load event patch, wine-gecko always sends them asynchronously, which is the same behavior as IE9+ modes. See `dom/base/nsImageLoadingContent.cpp: nsImageLoadingContent::FireEvent`. The comment there, funnily enough, is what script56.chm's script protects against (and breaks because of async behavior), but there's no way to selectively override it (because of compat mode), so we have to workaround it on mshtml side. Note that we only hook the gecko events (nsevents) being dispatched, and that's obviously on purpose. We wouldn't want to skip a load event dispatched by some script or app's code. -- v2: include/mshtmhst: Add CGID_ScriptSite and CMDIDs for it. mshtml/tests: Expect UpdateUI, Exec_UPDATECOMMANDS and Exec_SETTITLE in mshtml/tests: Allow BINDINFO_OPTIONS_ENABLE_UTF8 in bind options. mshtml: Don't lock document mode when querying IEventTarget. jscript: Pass correct 'this' to host objects in ES5 mode. mshtml: Send load event synchronously for img elements that loaded instantly mshtml: Keep a ref to the window during the doc nsevent handlers. https://gitlab.winehq.org/wine/wine/-/merge_requests/1598

4 9

[PATCH 0/1] MR1614: wined3d: Use unsigned int for "refcount" variables.
by Zebediah Figura (＠zfigura) 30 Nov '22

30 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1614

3 2

[PATCH 0/1] MR1611: vbscript: Handle "case" statements without separators.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53678 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1611

4 4

[PATCH v3 0/1] MR1602: Draft: rpcrt4: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 30 Nov '22

30 Nov '22

-- v3: rpcrt4: Use standard C functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1602

3 2

Re: [PATCH v4 0/1] MR1418: msvcm: add stubs to avoid Athenas ASS and IL-DSP crash.
by Piotr Caban (＠piotr) 30 Nov '22

30 Nov '22

I've finally found time to review it properly. Sorry for the delay. The patch needs lots of cleanup - starting from separating it into multiple patches (preferably adding one function in every patch) and changing commit message to describe what the patch implements (instead of what application it fixes). Taking in account next comments, I would suggest picking one function first and sending more patches after it gets in. I'm worried about adding the stubs (instead of full implementation). The functions are returning reference to object that can never be NULL on Windows. I'm expecting it to crash if application tries to use returned object. On the implementation note, I've done some initial testing of _Cout_func. It looks like it's almost compatible with msvcr80. The only difference I have found is that it uses __clrcall calling convention for virtual functions. I haven't found documentation for it but it seems to be similar to __fastcall (it additionally allows lazy compilation on function call but it can be probably ignored). Anyway I think that the way to go is to either copy implementation from msvcp and change relevant calling conventions or try to use PARENTSRC (I'm not sure if it will work well without trying). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1418#note_18069

1 0

[PATCH v4 0/4] MR1554: Draft: win32u: Update focused item when removing menu item
by Vladislav Timonin (＠vt) 30 Nov '22

30 Nov '22

Fixes an out of bounds access in `show_popup`. ```c if (menu->FocusedItem != NO_SELECTED_ITEM) { menu->items[menu->FocusedItem].fState &= ~(MF_HILITE|MF_MOUSESELECT); // <- can crash here menu->FocusedItem = NO_SELECTED_ITEM; } ``` Menu resets focused item on show, not on close. If items were later deleted, next time user opens the menu, menu can crash on out of bounds access and won't show up again, as menu thinks it's still on screen. In other words: - open split button dropdown - click on any item - clear dropdown items - open dropdown again Menu borked and won't open again. Source for the testing app for reproduction. [test.c](/uploads/2f703f63891b33e1a0eb0fcd27c912b7/test.c) I guess, the alternative is to reset focused item when menu is closed, but not sure where's the best place to do that, haven't dug deep enough. -- v4: win32u: Reset focused item if it was removed when removing a menu item win32u: Allow select_item to work with off-screen menus win32u: Add deselect to HiliteMenuItem win32u: Return FALSE in HiliteMenuItem when window handle is NULL https://gitlab.winehq.org/wine/wine/-/merge_requests/1554

3 5

[PATCH 0/3] MR1606: d3dx9/preshader: Move register table debug names to the rest of table info.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1606

3 6

[PATCH 0/3] MR1613: kernelbase: More LocalReAlloc tests and fixes with LFH blocks.
by Rémi Bernon (＠rbernon) 30 Nov '22

30 Nov '22

The LFH being automatically enabled after several allocations of the same sizes are done, its reallocation strategy differs from non-LFH blocks and was messing with the tests. I previously removed the HEAP_REALLOC_IN_PLACE_ONLY flag from LocalReAlloc, based on the test results, but the outcome is different when a non-LFH block size is used. This adds more tests and restores the flag to fix the regression. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1613

2 3

[PATCH v12 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 30 Nov '22

30 Nov '22

-- v12: wininet: Partially implement InternetSetFilePointer wininet/tests: Add InternetSetFilePointer tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

3 7

Re: [PATCH v3 0/4] MR1589: Start of enabling long integral types in wined3d.
by eric pouech (＠epo) 30 Nov '22

30 Nov '22

hmm doesn't look good... closing to startup fresh (sorry Jan) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1589#note_18051

1 0

Re: [PATCH v3 0/4] MR1589: Start of enabling long integral types in wined3d. - closed
by eric pouech (＠epo) 30 Nov '22

30 Nov '22

This merge request was closed by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1589

1 0

[PATCH 0/4] MR1589: Start of enabling long integral types in wined3d.
by eric pouech (＠epo) 30 Nov '22

30 Nov '22

This enabling will be done on a file basis (instead of directory) to ease review. This serie contains "simple" file migration (mostly refcount and status/GetLastError()) changes. I likely post afterwards each file change in a single MR to ease up review (and potentially changes) without blocking the others. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1589

5 14

[PATCH v7 0/8] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Sven Baars (＠sbaars) 30 Nov '22

30 Nov '22

This is in preparation of implementing all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v7: kernelbase: Factor creating a subkey out of create_key(). kernelbase: Use open_subkey() in create_key(). kernelbase: Always try to open the Wow6432Node in create_key() kernelbase: Add a fast path to create_key(). kernelbase: Move create_key() below open_key(). kernelbase: Factor opening a subkey out of open_key(). kernelbase: Always try to open the Wow6432Node in open_key(). kernelbase: Restructure the open_key() loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

2 9

[PATCH 0/5] MR1560: d3d10/effect: Preshader instructions support improvements.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1560

4 8

[PATCH v3 0/1] MR1604: vbscript: Make redim fail on fixed-size arrays.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53964 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vbscript: Make redim fail on fixed-size arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/1604

4 4

[PATCH v2 0/1] MR1604: vbscript: Make redim fail on fixed-size arrays.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53964 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vbscript: Make redim fail on fixed-size arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/1604

3 3

[PATCH v3 0/1] MR1556: d3dcompiler: Implement D3DDisassemble() using vkd3d-shader.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46649 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: d3dcompiler: Implement D3DDisassemble() using vkd3d-shader. https://gitlab.winehq.org/wine/wine/-/merge_requests/1556

3 2

[PATCH 0/1] MR1610: kernel32/tests: Add broken results for w7pro64.
by Rémi Bernon (＠rbernon) 30 Nov '22

30 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54012 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1610

2 3

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Georg Lehmann (＠DadSchoorse) 30 Nov '22

30 Nov '22

On Wed Nov 30 10:54:56 2022 +0000, Jacek Caban wrote: > I guess it wouldn't hurt to take this for now, but note that we'd like > to get rid of those direct calls. Rémi is working on improving syscall > dispatcher performance, see !1437 and !1324. Yes, we can remove it when we stop using direct calls for descriptor set updates. But at the moment I really don't want to have worse performance with descriptor buffers compared to descriptor sets caused by wine. Especially since it's unlikely that Rémi's work will be in 8.0. This is not just some theoretical problem. With the current non direct calls, vkd3d-proton's descriptor buffer path regresses performance for radv users. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18011

1 0

[PATCH 0/1] MR1604: vbscript: Make redim fail on fixed-size arrays.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53964 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1604

3 4

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Jacek Caban (＠jacek) 30 Nov '22

30 Nov '22

I guess it wouldn't hurt to take this for now, but note that we'd like to get rid of those direct calls. Rémi is working on improving syscall dispatcher performance, see !1437 and !1324. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18005

1 0

2025

2024

2023

2022

wine-gitlab