- wine-gitlab - winehq.org

[PATCH v16 0/1] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) 15 Nov '22

15 Nov '22

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v16: comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/672

4 4

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Zebediah Figura (＠zfigura) 15 Nov '22

15 Nov '22

Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c: > struct stream *stream = arg; > struct async_reader *reader = stream->reader; > struct sample *sample; > + WCHAR buffer[256]; > HRESULT hr; > > TRACE("reader %p, number %u\n", reader, stream->number); > > + swprintf(buffer, ARRAY_SIZE(buffer), L"wine_wmreader_stream_%u_read", stream->number); > + SetThreadDescription(GetCurrentThread(), buffer); Linux cuts off thread names at 15 characters (not counting the null terminator), which somewhat unfortunately makes all of these identical to each other and the deliver threads. Thus far I think Brendan had been trying to make the thread names distinct, if not per se trying to fit the entire name within 15 characters. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15868

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Zebediah Figura (＠zfigura) 15 Nov '22

15 Nov '22

> We need the read threads to always be running and returning their next sample because we then deliver them in PTS order. Somewhat out of curiosity, did you check whether this still applies when DedicatedDeliveryThread is set? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15869

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Zebediah Figura (＠zfigura) 15 Nov '22

15 Nov '22

On Mon Nov 14 12:05:16 2022 +0000, Rémi Bernon wrote: > I don't think we need to check it here anymore with the latest version. > Deselected streams will never have pending read requests (or they will > shortly complete it after deselection, with either error or a last sample). I guess, but it depends on the fact that "read_result" is zero-initialized and never written, which seems non-obvious and a little fragile. In fact, I think it can already break if a stream was selected and then later becomes deselected, even if the filter was stopped in between. Checking "stream->read_requested" would be more obvious but I think still broken for the same reasons (but simple enough to fix.) Note that if you do that then read_result becomes superfluous and doesn't really need to be stored anywhere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15867

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Zebediah Figura (＠zfigura) 15 Nov '22

15 Nov '22

Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c: > + > + LeaveCriticalSection(&reader->callback_cs); > + hr = IWMSyncReader2_GetNextSample(reader->reader, stream->number, > + &sample->buffer, &sample->pts, &sample->duration, > + &sample->flags, &sample->output, &sample->stream); > + EnterCriticalSection(&reader->callback_cs); > + } > + > + if (SUCCEEDED(stream->read_result = hr)) > + { > + TRACE("Got stream %u buffer with pts %I64d.\n", stream->number, sample->pts); > + stream->next_sample = sample; > + } > + else > + { > + WARN("Failed to get stream %u sample, hr %#lx.\n", stream->number, stream->read_result); Missed this the first time, but: I'd make this an ERR, personally. (An application can trigger it, but it's one of those cases where it's a sign that something went catastrophically wrong, and also we're pretty much guessing how to handle it if not.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15865

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Zebediah Figura (＠zfigura) 15 Nov '22

15 Nov '22

Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c: > } > > if (!first_sample) > - return NS_E_NO_MORE_SAMPLES; > + return pending ? E_PENDING : NS_E_NO_MORE_SAMPLES; What's the point of this? We never check the return code of async_reader_get_next_sample(), only whether it FAILED(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15866

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Zebediah Figura (＠zfigura) 15 Nov '22

15 Nov '22

Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c: > + continue; > + } > + > + while (stream->read_requested) > + { > + stream->read_requested = false; > + > + if (sample->buffer) > + INSSBuffer_Release(sample->buffer); > + sample->buffer = NULL; > + > + LeaveCriticalSection(&reader->callback_cs); > + hr = IWMSyncReader2_GetNextSample(reader->reader, stream->number, > + &sample->buffer, &sample->pts, &sample->duration, > + &sample->flags, &sample->output, &sample->stream); > + EnterCriticalSection(&reader->callback_cs); Similarly to the earlier question about IWMSyncReader locking, do we need to drop the CS here? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15864

1 0

[PATCH v2 0/4] MR1355: opengl32: Implement wow64 thunk for several unix entry points.
by Rémi Bernon (＠rbernon) 15 Nov '22

15 Nov '22

-- v2: opengl32: Implement wow64 thunk for wglMakeCurrent (et al.). opengl32: Implement wow64 thunk for wglGetProcAddress. opengl32: Manually write glPathGlyphIndexRangeNV wow64 thunk. opengl32: Generate wow64 thunks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1355

3 6

[PATCH 0/1] MR1369: d3dx9: Add missing path conversion call in D3DXLoadVolumeFromFileA().
by Nikolay Sivov (＠nsivov) 15 Nov '22

15 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1369

3 3

[PATCH 0/1] MR1351: d3dx9_36/tests: Use standard C functions for memory allocation in mesh.c.
by Alex Henrie (＠alexhenrie) 15 Nov '22

15 Nov '22

The big win here is getting rid of the reimplementation of strdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1351

3 2

[PATCH v2 0/1] MR1370: d2d1: Silently ignore non-default state block implementations.
by Nikolay Sivov (＠nsivov) 15 Nov '22

15 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53915 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: d2d1: Silently ignore non-default state block implementations. https://gitlab.winehq.org/wine/wine/-/merge_requests/1370

3 3

[PATCH 0/1] MR1370: d2d1: Silently ignore non-default state block implementations.
by Nikolay Sivov (＠nsivov) 15 Nov '22

15 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53915 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1370

4 3

[PATCH 0/1] MR1350: comctl32: Fix memory leak on error path in EDIT_MakeUndoFit.
by Alex Henrie (＠alexhenrie) 15 Nov '22

15 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1350

4 3

[PATCH v4 0/1] MR1334: xmllite/writer: Handle surrogate pairs
by David Kahurani (＠kahurani) 15 Nov '22

15 Nov '22

Surrogates have to be written in pairs. Also, handle related errors Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v4: xmllite/writer: Handle surrogate pairs https://gitlab.winehq.org/wine/wine/-/merge_requests/1334

4 5

[PATCH 0/4] MR1361: kernel32: Validate globalmem pointers before calling heap functions.
by Rémi Bernon (＠rbernon) 15 Nov '22

15 Nov '22

Tests show that Global / Local functions are more robust and catch invalid pointers, to the contrary to heap functions. I'd like to relax a bit the heap quick pointer validation, in order to avoid looping over the heap regions on every call, and to reduce the locking requirements, though this would then break the globalmem invalid pointer tests, unless they validate the pointers beforehand. They should maybe use exception handlers rather than pointer validation, but the result is the same. I can change that if it matters. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1361

3 6

[PATCH v2 0/5] MR1371: shell32/tests: Add tests for drag and drop helpers
by Tarcísio Ladeia de Oliveira (＠wyrquill) 15 Nov '22

15 Nov '22

The drag and drop helpers are mainly used for providing visual feedback for drag and drop operations. While they do not actually influence the dragging process, some applications may expect it to succeed before initiating dragging. If the functions are not implemented, however, then dragging may fail. This patch set contains tests for basic functionality of the functions involved. It does not account for displaying the drag-image, it just tests for enough functionality to create a basic implementation and allow dragging operations to carry on. Drag-image handling will be added later. The patch set contains only the tests. The implementation will be added in a separate MR. -- v2: shell32/tests: Add tests for drag and drop helpers shell32/tests: Add, initialize and release new variables shell32/tests: add mock IDataObject instances https://gitlab.winehq.org/wine/wine/-/merge_requests/1371

3 7

[PATCH 0/1] MR1344: d3d11/tests: Introduce a clear_uav() helper.
by eric pouech (＠epo) 15 Nov '22

15 Nov '22

This fixes warnings with gcc 12.2. (Copycat of 5fa25d00 about clear_rtv()) Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1344

4 3

[PATCH 0/7] MR1372: Import OpenLDAP client libraries and use them in wldap32
by Hans Leidekker (＠hans) 15 Nov '22

15 Nov '22

It would be nice to get this in before 8.0. I squashed the OpenLDAP changes into the first commit (see MR !912) which I will try to get upstream. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1372

3 8

[PATCH 0/1] MR1366: winspool.drv: Ignore input in DocumentPropertiesA unless DM_IN_BUFFER is passed.
by Tim Clem (＠tclem) 15 Nov '22

15 Nov '22

The GdiConvertToDevmodeW call can crash if the incoming DEVMODEA has nonsense values. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1366

4 3

[PATCH 0/5] MR1371: shell32/tests: Add tests for drag and drop helpers
by Tarcísio Ladeia de Oliveira (＠wyrquill) 15 Nov '22

15 Nov '22

The drag and drop helpers are mainly used for providing visual feedback for drag and drop operations. While they do not actually influence the dragging process, some applications may expect it to succeed before initiating dragging. If the functions are not implemented, however, then dragging may fail. This patch set contains tests for basic functionality of the functions involved. It does not account for displaying the drag-image, it just tests for enough functionality to create a basic implementation and allow dragging operations to carry on. Drag-image handling will be added later. The patch set contains only the tests. The implementation will be added in a separate MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1371

3 6

[PATCH 0/1] MR1368: vbscript: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 15 Nov '22

15 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1368

3 2

[PATCH v15 0/10] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 15 Nov '22

15 Nov '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v15: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. wineandroid.drv: Route kernel callbacks through user32. opengl32: Route kernel callbacks through user32. winevulkan: Route kernel callbacks through user32. user32: Add NtUserDispatchCallback kernel callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

4 14

[PATCH v4 0/5] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.
by Conor McCarthy (＠cmccarthy) 15 Nov '22

15 Nov '22

Block records are not processed; only the bitcode is validated. -- v4: vkd3d-shader/dxil: Read and validate global abbreviated operands. vkd3d-shader/dxil: Read and validate local abbreviated operands. vkd3d-compiler: Introduce a dxil-asm target type. vkd3d-compiler: Introduce a dxbc-dxil source type. vkd3d-shader/dxil: Read and validate DXIL bitcode unabbreviated blocks. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44

3 7

[PATCH v2 0/6] MR1298: winegstreamer: MPEG layer-3 decoder output media type enumeration and allocator properties.
by Anton Baskanov (＠baskanov) 15 Nov '22

15 Nov '22

v2: Fixed test failures on earlier l3codecx.ax versions. -- v2: winegstreamer: Set allocator properties for MPEG layer-3 decoder source. quartz/tests: Add tests for MPEG layer-3 decoder source allocator. winegstreamer: Check whether transform is supported when creating MPEG layer-3 decoder. winegstreamer: Implement output media type enumeration in MPEG layer-3 decoder. quartz/tests: Add tests for MPEG layer-3 decoder output media type enumeration. quartz/tests: Add tests for MPEG layer-3 decoder sink allocator. https://gitlab.winehq.org/wine/wine/-/merge_requests/1298

4 8

[PATCH 0/1] MR1367: ws2_32: Return success for setting SO_ERROR.
by Paul Gofman (＠gofman) 15 Nov '22

15 Nov '22

As analysis performed in [1] suggests, Microsoft Flight Simulator depends on that. 1. https://github.com/ValveSoftware/Proton/issues/4134#issuecomment-1314432224 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1367

6 7

2025

2024

2023

2022

wine-gitlab