- wine-gitlab - winehq.org

[PATCH v2 0/3] MR7583: ntdll: Stop using chdir() in nt_to_unix_file_name().
by Brendan Shanks (＠bshanks) 17 Mar '25

17 Mar '25

-- v2: ntdll: Stop using chdir() in nt_to_unix_file_name(). ntdll: Use *at() functions in get_dir_case_sensitivity(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7583

2 4

Re: [PATCH v6 0/1] MR6938: Draft: winewayland.drv: Implement support for xdg-toplevel-icon.
by Alex Schwartz (＠alexschwartz01) 17 Mar '25

17 Mar '25

I just tested this on KDE Plasma 6.3 and it works perfectly This would be a great addition to the Wayland driver @etaash.mathamsetty is this still a draft? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6938#note_98123

1 0

[PATCH v2 0/2] MR7601: bluetoothapis: Implement BluetoothGetDeviceInfo.
by Vibhav Pant (＠vibhavp) 17 Mar '25

17 Mar '25

-- v2: bluetoothapis/tests: Add tests for BluetoothGetDeviceInfo. https://gitlab.winehq.org/wine/wine/-/merge_requests/7601

2 2

[PATCH 0/2] MR7601: bluetoothapis: Implement BluetoothGetDeviceInfo.
by Vibhav Pant (＠vibhavp) 17 Mar '25

17 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7601

2 2

[PATCH 0/5] MR7600: PDB rewrite #2
by eric pouech (＠epo) 17 Mar '25

17 Mar '25

- fixes support for <mod>! syntax in source file enumeration - reduces memory usage for types (no longer having both a vector and a hash table as all types are now named) - some code refactoring -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7600

2 5

[PATCH 0/1] MR7592: d3dx9/tests: Skip some shader tests if we can't create a D3D object.
by Matteo Bruni (＠Mystral) 17 Mar '25

17 Mar '25

Hopefully it should help with some crashes on Rémi's test machines -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7592

2 2

[PATCH 0/1] MR7582: comctl32: Implement EVENT_OBJECT_VALUECHANGE for datetime control.
by Esme Povirk (＠madewokherd) 17 Mar '25

17 Mar '25

Windows implemented this event only for comctl32 v6. Making this behavior version-specific in Wine would be difficult, and I don't expect it to matter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7582

3 2

[PATCH v10 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu (＠insn) 17 Mar '25

17 Mar '25

-- v10: server: Handle hardlinks and casefolding when renaming the same file. server: Handle renames to destinations containing trailing slashes. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

3 8

[PATCH v2 0/8] MR7402: comctl32: Implement IAccessible methods.
by Esme Povirk (＠madewokherd) 17 Mar '25

17 Mar '25

-- v2: comctl32: Implement IOleWindow for SysLink. comctl32: Implement accChild for SysLink. comctl32: Implement get_accChildCount for SysLink. comctl32: Implement accLocation for SysLink. comctl32: Implement get_accDefaultAction for SysLink. comctl32: Implement acc_getName for SysLink. comctl32: Implement get_accState for SysLink controls. comctl32: Include only link items as IAccessible children. https://gitlab.winehq.org/wine/wine/-/merge_requests/7402

3 9

Re: [PATCH v2 0/1] MR7594: msvcrt: Add _IONBF flag check in _filbuf to avoid dead loop in application which sets the flag.
by Piotr Caban (＠piotr) 17 Mar '25

17 Mar '25

The patch generally looks good. It needs some changes for ucrtbase (see comment above). Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7594#note_98087

1 0

Re: [PATCH v2 0/1] MR7594: msvcrt: Add _IONBF flag check in _filbuf to avoid dead loop in application which sets the flag.
by Piotr Caban (＠piotr) 17 Mar '25

17 Mar '25

Piotr Caban (@piotr) commented about dlls/msvcrt/file.c: > return EOF; > } > > - if(!(file->_flag & (_IOMYBUF | MSVCRT__USERBUF))) { > + if(!(file->_flag & (_IONBF | _IOMYBUF | MSVCRT__USERBUF))) { ```suggestion:-0+0 if(!(file->_flag & (MSVCRT__NOBUF | _IOMYBUF | MSVCRT__USERBUF))) { ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7594#note_98086

1 0

[PATCH v2 0/5] MR7559: cfgmgr32: Implement CM_Register_Notification and CM_Unregister_Notification.
by Vibhav Pant (＠vibhavp) 17 Mar '25

17 Mar '25

The methods are needed to implement Bluetooth device pairing in `bluetoothapis.dll` without having to create a dummy window for `RegisterDeviceNotification`, as that may break CLI applications. `CM_Register_Notification` is implemented as a thin wrapper over `I_ScRegisterDeviceNotification`, mapping `DBT_*` flags to their associated `CM_NOTIFY_*` constants. -- v2: user32: Remove incorrect FIXME warning while registering for DBT_DEVTYP_HANDLE notifications. cfgmgr32: Implement CM_Register_Notification and CM_Unregister_Notification. dinput/tests: Add tests for CM_Register_Notification. cfgmgr32/tests: Add basic tests for CM_(Un)Register_Notification. https://gitlab.winehq.org/wine/wine/-/merge_requests/7559

2 7

Re: [PATCH v10 0/7] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Vibhav Pant (＠vibhavp) 17 Mar '25

17 Mar '25

On Mon Mar 17 12:34:11 2025 +0000, Rémi Bernon wrote: > This broke some test validation, see > https://test.winehq.org/data/patterns.html#bluetoothapis:device. The > issue is about using skip from a different file than the test module > being executed. You need to either add a "subtest" call with the other > file name, or pass __FILE__ from the executing test module to the skip_ call. Sorry about that, I have created !7598 to fix this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7472#note_98080

1 0

[PATCH 0/1] MR7598: bluetoothapis/tests: Use the correct file name while skipping tests when no radios are found.
by Vibhav Pant (＠vibhavp) 17 Mar '25

17 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7598

2 1

[PATCH v3 0/7] MR7565: windows.system.profile.systemid: Implement ISystemIdentificationInfo::get_Source().
by Mohamad Al-Jaf (＠maljaf) 17 Mar '25

17 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 -- v3: windows.system.profile.systemid: Implement ISystemIdentificationInfo::get_Source(). windows.system.profile.systemid/tests: Add ISystemIdentificationInfo::get_Source() tests. windows.system.profile.systemid: Partially implement ISystemIdentificationStatics::GetSystemIdForPublisher(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7565

3 8

[PATCH 0/4] MR7559: cfgmgr32: Implement CM_Register_Notification and CM_Unregister_Notification.
by Vibhav Pant (＠vibhavp) 17 Mar '25

17 Mar '25

The methods are needed to implement Bluetooth device pairing in `bluetoothapis.dll` without having to create a dummy window for `RegisterDeviceNotification`, as that may break CLI applications. `CM_Register_Notification` is implemented as a thin wrapper over `I_ScRegisterDeviceNotification`, mapping `DBT_*` flags to their associated `CM_NOTIFY_*` constants. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7559

3 8

[PATCH 0/8] MR7597: wintypes: Implement IBufferByteAccess::Buffer().
by Mohamad Al-Jaf (＠maljaf) 17 Mar '25

17 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7597

3 10

Re: [PATCH v10 0/7] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Rémi Bernon (＠rbernon) 17 Mar '25

17 Mar '25

This broke some test validation, see https://test.winehq.org/data/patterns.html#bluetoothapis:device. The issue is about using skip from a different file than the test module being executed. You need to either add a "subtest" call with the other file name, or pass __FILE__ from the executing test module to the skip_ call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7472#note_98062

1 0

[PATCH 0/1] MR7596: wldap32: Also initialize idW.Flags field.
by Dmitry Timoshkov (＠dmitry) 17 Mar '25

17 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7596

3 2

[PATCH 0/1] MR7533: gdi32: Avoid failing FillPath() for a EMF hdc.
by Dmitry Timoshkov (＠dmitry) 17 Mar '25

17 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7533

4 7

[PATCH 0/1] MR7595: comctl32/tests: Add a test for LVM_FINDITEM with LVS_OWNERDATA.
by Nikolay Sivov (＠nsivov) 17 Mar '25

17 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57746 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7595

2 1

Re: [PATCH v3 0/1] MR5052: krnl386: Restore simulated real mode interrupts.
by Alex Henrie (＠alexhenrie) 17 Mar '25

17 Mar '25

On Mon Mar 17 04:39:03 2025 +0000, Alexandre Julliard wrote: > Please let's not reintroduce support for vm86 contexts and pointers. > If necessary, you can add a separate real-mode handler for that specific > call. But I'd suggest to first make sure that the app works without any > actual vm86 support. Now that simulated hardware interrupts for audio processing have been implemented in commit ff0fbb1ff5f76d1d206aea452907ad2dd29206ea, simulated real mode interrupts are the only thing left that's keeping 16-bit Myst from running. When I wrote this patch, I tried to not include anything more than what Myst requires. Could you please clarify which parts of the patch are not strictly necessary? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5052#note_98044

1 0

[PATCH 0/1] MR7594: msvcrt: Add _IONBF flag check in _filbuf to avoid dead loop in application which sets the flag.
by Kun Yang (＠yangkun) 17 Mar '25

17 Mar '25

Signed-off-by: Kun Yang <yangkun(a)uniontech.com> Change-Id: Ia68e11ccb0aa563eeb73a2f5cb93afcd328e1937 [fgetws_test.7z](/uploads/7b706f2c4f639e4260c548d834658b32/fgetws_test.7z) If the application calls setvbuf(.., _IONBF, ..) before fgetws, wine sets the flag. In fgetws, this flag is not checked. read_i is called with paramenter count 1 which is not allowed in read_i implemantion. Function read_i returns -1 and the file stream is not actually read by program. The file pointer is not moved. If the application writes fgetws in a loop, it never reach EOF and falls in dead loop. By adding check for _IONBF in _filbuf, the application will run into another branch(file->_bufsiz=2). Thats's correct. Please checkout the example in my attachment. This application exits normally in Windows but falls in dead loop in wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7594

2 1

[PATCH 0/1] MR7593: ntoskrnl.exe/tests: Improve device properties test, avoid BSOD.
by Alexander Morozov (＠amorozov) 17 Mar '25

17 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57940 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7593

2 1

[PATCH 0/1] MR3857: d3d11/tests: Properly mark the indexed sample position test as succeeding with the Vulkan backend.
by Henri Verbeet (＠hverbeet) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3857

4 4

2025

2024

2023

2022

wine-gitlab