- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR1114: ntdll/tests: Force alignment of output structures.
by eric pouech (＠epo) 21 Oct '22

21 Oct '22

On Thu Oct 20 17:51:23 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 10/20/22 03:54, Eric Pouech wrote: > > From: Eric Pouech <eric.pouech(a)gmail.com> > > > > Some Windows version expect output to be aligned on 4 bytes. > > > > Notes (from i386 and x86_64 tests): > > - MSVC and Mingw/gcc don't layout the two variables (sdki, sdki_ex) > > the same way. > > - MSVC aligns each variable on 4-byte boundary, > > - MingW/GCC stores them in a 8-byte chunk, but starting from the > > end of the buffer: hence none of them is on a 4-byte boundary. > > > > So, fixing the alignment of variables is not sufficient to > > workaround the compilers' discrepancy on all source code. > > > > I didn't find a generic way to align on 4 bytes structures of size > > smaller than 4 bytes (apart from adding the DECLSPEC_ALIGN to > > each of the offending structures, likely not that many though). > > Ideas welcomed. > Should we put those structs in pshpack4/poppack in the header? (They > aren't defined anywhere publicly on Windows, so we can't compare there.) > ``` from the testbot results, it seems that only W8 and early versions of W10 return errors on pointers not aligned on 4-byte; newer versions of W10 happily handle calls with unaligned pointers so I considered that the "default" is to support non aligned access, but this requires adapting the tests to workaround limitations (not to say bug) in W8/early W10 versions rather than to put it inside the structure declaration -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1114#note_11659

1 0

[PATCH v2 0/1] MR14: include: Add missing types in vkd3d_d3d12.idl.
by Biswapriyo Nath (＠Biswa96) 21 Oct '22

21 Oct '22

-- v2: include: Add missing types in vkd3d_d3d12.idl. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/14

4 7

[PATCH v10 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 21 Oct '22

21 Oct '22

-- v10: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v9 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 21 Oct '22

21 Oct '22

-- v9: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v4 0/7] MR871: ntdll: Fill the IOSB only inside the if (alerted) block in multiple functions.
by Zebediah Figura (＠zfigura) 21 Oct '22

21 Oct '22

-- v4: ntdll: Fill the IOSB in sock_transmit() only inside the "if (alerted)" block. ntdll: Combine the "if (alerted)" blocks in sock_send(). ntdll: Fill the IOSB in sock_send() only inside the "if (alerted)" block. ntdll: Combine the "if (alerted)" blocks in sock_recv(). ntdll: Fill the IOSB in sock_recv() only inside the "if (alerted)" block. ntdll: The async handle passed to set_async_direct_result() cannot be NULL. ws2_32/tests: Add more tests for iosb contents while a recv is pending. https://gitlab.winehq.org/wine/wine/-/merge_requests/871

3 8

Re: [PATCH v3 0/1] MR1002: win32u: Fix data race in NtUserGetProcessDpiAwarenessContext. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1002

1 0

Re: [PATCH v2 0/1] MR996: ddraw/tests: Mark tests failing randomly on Windows as flaky. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/996

1 0

Re: [PATCH v3 0/1] MR1095: xinput1_3: Set thread name for hid_update_thread_proc. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1095

1 0

Re: [PATCH v2 0/5] MR1126: Spelling and trailing linefeed fixes. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1126

1 0

Re: [PATCH v2 0/1] MR1112: comctl32/tests: Use a toolbar with TBSTYLE_FLAT in toolbar visual tests. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1112

1 0

Re: [PATCH v2 0/1] MR1114: ntdll/tests: Force alignment of output structures. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1114

1 0

Re: [PATCH v3 0/1] MR1123: winetest: Let the get_subtests() caller report errors. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1123

1 0

Re: [PATCH v3 0/2] MR1113: include: Add _putenv_s. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1113

1 0

Re: [PATCH v2 0/1] MR1127: wintrust: Add a trailing linefeed to an ERR() message. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1127

1 0

Re: [PATCH v2 0/1] MR1124: oleaut32/tests: Fix test failing on UTF-8 locale. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1124

1 0

Re: [PATCH v3 0/1] MR1096: mmdevapi: Set the name of internal threads. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1096

1 0

Re: [PATCH v4 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1089

1 0

Re: [PATCH v2 0/3] MR1118: tests: Add dummy flaky test count. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1118

1 0

Re: [PATCH v9 0/1] MR1065: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64) - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1065

1 0

Re: [PATCH v8 0/1] MR839: ntoskrnl: Use LoadLibraryW for MmGetSystemRoutineAddress - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/839

1 0

Re: [PATCH v8 0/2] MR1016: ntoskrnl.exe: Implement IoCreateNotificationEvent - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1016

1 0

[PATCH v7 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 20 Oct '22

20 Oct '22

-- v7: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v5 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 20 Oct '22

20 Oct '22

-- v5: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 8

[PATCH 0/1] MR1127: wintrust: Add a trailing linefeed to an ERR() message.
by Francois Gouget (＠fgouget) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1127

3 2

[PATCH 0/5] MR1105: comctl32: preparation for HPROPSHEETPAGE structure layout changes
by Piotr Caban (＠piotr) 20 Oct '22

20 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1105

5 8

2025

2024

2023

2022

wine-gitlab