- wine-gitlab - winehq.org

[PATCH 0/2] MR1039: Schannel test
by Hans Leidekker (＠hans) 12 Oct '22

12 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1039

2 2

Re: [PATCH v2 0/2] MR1037: win32u: Add font link for MS UI Gothic.
by Huw Davies (＠huw) 12 Oct '22

12 Oct '22

Could you split the first commit further? Just make the code change with the commit msg something like "win32u: Add mechanism for font specific system links", but don't add the MS UI Gothic entries. A second commit would add the Gothic entries, and a third the additional Tahoma ones. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1037#note_10391

1 0

[PATCH v4 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Rémi Bernon (＠rbernon) 12 Oct '22

12 Oct '22

To avoid direct callbacks from display drivers to win32u while changing display settings. -- v4: winemac.drv: Resize desktop window on WM_DISPLAYCHANGE message. winex11.drv: Resize desktop window on WM_DISPLAYCHANGE message. win32u: Send WM_DISPLAYCHANGE message to the desktop window. winex11.drv: Send WM_X11DRV_CLIP_CURSOR_REQUEST message from the deskop. winex11.drv: Sync window positions in a WM_X11DRV_DESKTOP_RESIZED message. https://gitlab.winehq.org/wine/wine/-/merge_requests/944

3 9

[PATCH v2 0/1] MR962: wined3d: Use a Wine debug channel for vkd3d debug output.
by Alexandre Julliard (＠julliard) 12 Oct '22

12 Oct '22

-- v2: wined3d: Use a Wine debug channel for vkd3d debug output. https://gitlab.winehq.org/wine/wine/-/merge_requests/962

5 8

[PATCH v3 0/5] MR25: vkd3d-shader/hlsl: Implement asuint() and completely move init_node() to hlsl.c.
by Zebediah Figura (＠zfigura) 12 Oct '22

12 Oct '22

-- v3: vkd3d-shader/hlsl: Pass a location pointer to init_node(). vkd3d-shader/hlsl: Introduce a hlsl_new_expr() helper. vkd3d-shader/hlsl: Write SM4 reinterpret instructions. vkd3d-shader/hlsl: Parse the asuint() intrinsic. tests: Add a test for asuint(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/25

4 7

[PATCH 0/7] MR1034: msvcp140: Do not import from msvcp120.
by Paul Gofman (＠gofman) 12 Oct '22

12 Oct '22

The practical aspect of this (besides that msvcp140 just should not probably load msvcp120) is that for an app using VC runtime 140 mspcp140.__ExceptionPtrCurrentException gets the thread data from msvcp120.dll while vcruntime140_1 sets those thread data from ucrtbase.dll which are different data. So the application calling mspcp140.__ExceptionPtrCurrentException in catch block gets NULL exception while it was technically set by vcruntime140_1 before calling the app's catch block handler. After this patchset all the current exception data should end up in ucrtbase for VC runtime 140. There is a bit more to it (not covered by this patchset) when there is a mix of native and builtin VC runtime 140 dlls. From the app behaviour and some tests it looks like with native DLLs msvcp140 and vcruntime140_1 handle current exception data through vcruntime140.dll and vcruntime140.dll does not forward that to ucrtbase. I am not sure if the latter (not forwarding vcruntime140->ucrtbase) is practically important but to avoid the similar problem when mixing native and builtin VC runtime DLLs we should also probably link msvcp140 and vcruntime140_1 to vcruntime140. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1034

4 9

[PATCH 0/2] MR1038: Sapi datakey
by Alistair Leslie-Hughes (＠alesliehughes) 12 Oct '22

12 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1038

3 3

[PATCH 0/1] MR1015: wpcap: use UNIX 98/BSD 4.4 sockaddr header
by Marc-Aurel Zent (＠marzent) 12 Oct '22

12 Oct '22

Interpreting the fist two bytes of the `sockaddr` struct as `sa_family` produces incorrect behaviour on macOS and (presumbly) BSD. This change is however still backwards compatible with Linux since `sa_family` is of effective type `uint8_t` and `sa_len` is currently disregarded. For reference https://www.ibm.com/docs/en/i/7.3?topic=family-af-inet-address and this is from the <sys/socket.h> on macOS ``` /* * [XSI] Structure used by kernel to store most addresses. */ struct sockaddr { __uint8_t sa_len; /* total length */ sa_family_t sa_family; /* [XSI] address family */ char sa_data[14]; /* [XSI] addr value (actually larger) */ }; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015

5 12

Re: [PATCH 0/1] MR74: ntdll: Prevent double free (Coverity)
by Sven Baars (＠sbaars) 12 Oct '22

12 Oct '22

Sven Baars (@sbaars) commented about dlls/ntdll/unix/file.c: > if (size > 0x10000) size = 0x10000; > if ((tmpbuf = malloc( size ))) > { > + if (needs_close) close( fd ); > if (!server_get_unix_fd( handle, FILE_READ_DATA, &fd, &needs_close, NULL, NULL )) > { > int res = recv( fd, tmpbuf, size, MSG_PEEK ); > info->MessagesAvailable = (res > 0); > info->NextMessageSize = (res >= 0) ? res : MAILSLOT_NO_MESSAGE; > if (needs_close) close( fd ); I think you want to remove this one as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/74#note_10372

1 0

[PATCH 0/5] MR1001: winebuild: Reimplement dlltool for import lib and delay import lib generation.
by Rémi Bernon (＠rbernon) 12 Oct '22

12 Oct '22

This is slightly different from dlltool but I think it should be compatible. The transition is done by first replacing dlltool with its bugs, and fixing them in separate changes. I based the ARM / AARCH64 implementation on the existing code around, but I have no idea if it is correct, and dlltool also doesn't include any delay load implementation for ARM. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1001

3 7

[PATCH 0/2] MR1027: windows.devices.enumeration: Create stub DeviceAccessInformation class.
by Paul Gofman (＠gofman) 12 Oct '22

12 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1027

4 6

[PATCH 0/3] MR1036: qcap: Various video capture patches.
by Zebediah Figura (＠zfigura) 12 Oct '22

12 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1036

3 4

[PATCH 0/6] MR971: winegstreamer: Complete transition to using IWMSyncReader2 from the WM async reader.
by Rémi Bernon (＠rbernon) 11 Oct '22

11 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/971

4 9

[PATCH v2 0/5] MR937: winegstreamer: Small refactor of wg_format video formats and major types.
by Rémi Bernon (＠rbernon) 11 Oct '22

11 Oct '22

I'm going to need to add a few more compressed formats, WMV which is straightforward, but also AAC (so MPEG v2/v4 audio), and I think wg_format could be cleaned up a bit like this beforehand. Then, AAC could either be added as a separate `AUDIO_MPEG4` format, or, with an version field, to the (renamed) `AUDIO_MPEG` format, though it doesn't share any of the current `AUDIO_MPEG1` properties. FWIW GStreamer caps is `audio/mpeg` for both, with an `mpegversion` that can be 1, 2 or 4. Could be very well added as `AUDIO_AAC` too, I don't really mind. -- v2: winegstreamer: Reorder video format struct in wg_format. winegstreamer: Rename WG_MAJOR_TYPE_H264 to WG_MAJOR_TYPE_VIDEO_H264. winegstreamer: Rename WG_MAJOR_TYPE_WMA to WG_MAJOR_TYPE_AUDIO_WMA. winegstreamer: Rename WG_MAJOR_TYPE_MPEG1_AUDIO to WG_MAJOR_TYPE_AUDIO_MPEG1. winegstreamer: Move CINEPAK encoded format to a separate major type. https://gitlab.winehq.org/wine/wine/-/merge_requests/937

4 11

[PATCH 0/1] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) 11 Oct '22

11 Oct '22

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. This introduces a regression that makes it possible to use \Device\NamedPipe (note the lack of trailing backslash) as RootDirectory as well, since Wine does not distinguish between \Device\NamedPipe (the device itself) and \Device\NamedPipe\ (the root directory of the filesystem). (Previous iteration of this patch did distinguish between the two, but the method in which it was implemented was deemed hacky.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498

5 11

Re: [PATCH v3 0/2] MR897: oleaut32: dereference VT_RECORD|VT_BYREF in place.
by Kevin Puetz (＠puetzk) 11 Oct '22

11 Oct '22

Revereted in 02ce1008b7876d9f86dfc5844c4be17307b8e055 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/897#note_10350

1 0

[PATCH v2 0/2] MR920: kernel32: Map system heap anywhere if the standard address is unavailable.
by Brendan Shanks (＠bshanks) 11 Oct '22

11 Oct '22

`mscomctl.ocx` (part of the VB6 common controls) calls `HeapCreate(0x04000000,1,0)`, that flag is the old and undocumented `HEAP_SHARED`. `HEAP_CreateSystemHeap()` tries to map memory at `0x80000000`, this fails on Wow64 (and probably should for all 32-bit platforms for non-LAA EXEs). As a workaround, map the memory anywhere if it fails at `0x80000000`. I wasn't able to find much documentation about `HEAP_SHARED`, it dates back to Win9x and I guess Wine may have needed it for some native DLLs. It's not clear whether modern Windows really implements any shared heap functionality any more, every 'shared' heap created returns a different pointer (even in the same process). Maybe Wine should remove the functionality too? -- v2: kernel32: Remove shared heap functionality. ntdll: Remove shared heap functionality. https://gitlab.winehq.org/wine/wine/-/merge_requests/920

3 3

Re: [PATCH v5 0/1] MR1006: gdi32: Fix possible overflow - approved
by Alexandre Julliard (＠julliard) 11 Oct '22

11 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1006

1 0

Re: [PATCH v2 0/1] MR994: gdi32/tests: Mark tests failing randomly on Windows as flaky. - approved
by Alexandre Julliard (＠julliard) 11 Oct '22

11 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/994

1 0

Re: [PATCH v4 0/2] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer. - approved
by Alexandre Julliard (＠julliard) 11 Oct '22

11 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/957

1 0

Re: [PATCH v26 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub - approved
by Alexandre Julliard (＠julliard) 11 Oct '22

11 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778

1 0

Re: [PATCH v2 0/1] MR1029: include: Add missing SP defines - approved
by Alexandre Julliard (＠julliard) 11 Oct '22

11 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1029

1 0

Re: [PATCH v3 0/2] MR1026: shell32: Handle drive letters properly when parsing MyComputer. - approved
by Alexandre Julliard (＠julliard) 11 Oct '22

11 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1026

1 0

Re: [PATCH v2 0/2] MR981: dxgi/tests: Mark tests failing randomly on Windows as flaky. - approved
by Alexandre Julliard (＠julliard) 11 Oct '22

11 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/981

1 0

Re: [PATCH v2 0/3] MR956: Return focus window in swapchain desc from IDirect3DSwapChain9_GetPresentParameters() if hDeviceWindow is NULL. - approved
by Alexandre Julliard (＠julliard) 11 Oct '22

11 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/956

1 0

2025

2024

2023

2022

wine-gitlab