This implements the _RunAndWait member function and the constructor of the _StructuredTaskCollection, which enables the tests for that class to run.
Also adds a throw of a missing_wait exception to the destructor when chores are scheduled and _RunAndWait was not called.
Remaining stuff after this:
- Task collection cancelling + IsCancelling function (next MR)
- Cancellation token support (requires RE'ing the _CancellationTokenState class, currently in progress)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/906
--
v4: mf/tests: Dump image samples with a BMP header and RGB data.
mf/tests: Rename transform frame dumps to BMP.
mf/tests: Check all produced output IMFSample at the same time.
mf/tests: Factor IMFSample attributes checks in check_mf_sample.
mf/tests: Factor IMFSample checks in a check_mf_sample helper.
mf/tests: Introduce a new dump_mf_sample helper.
mf/tests: Introduce a new load_resource helper.
mf/tests: Factor IMFTransform_ProcessOutput checks together.
mf/tests: Use separate variables for input / output samples.
mf: Validate sample copier ProcessOutput count parameter.
winegstreamer: Avoid accessing NULL pointer if transform didn't provide a sample.
https://gitlab.winehq.org/wine/wine/-/merge_requests/887
--
v3: mf/tests: Dump image samples with a BMP header and RGB data.
mf/tests: Rename transform frame dumps to BMP.
mf/tests: Check all produced output IMFSample at the same time.
mf/tests: Factor IMFSample attributes checks in check_mf_sample.
mf/tests: Factor IMFSample checks in a check_mf_sample helper.
mf/tests: Introduce a new dump_mf_sample helper.
mf/tests: Introduce a new load_resource helper.
mf/tests: Factor IMFTransform_ProcessOutput checks together.
mf/tests: Use separate variables for input / output samples.
mf: Validate sample copier ProcessOutput count parameter.
https://gitlab.winehq.org/wine/wine/-/merge_requests/887
Since struct _IAVIStreamImpl has a pointer to a WAVEFORMATEX,
GCC 12.2 emits warning when dereferencing that pointer when
the block has been allocated with sizeof(PCMWAVEFORMAT).
The warning is fixed by always allocating with sizeof(WAVEFORMATEX).
This will overallocate in case of a PCM stream.
The alternative would have been to store in struct _IAVIStreamImpl
a pointer to PCMWAVEFORMAT instead, and add the casting to a
WAVEFORMATEX when needed. That would clutter the code IMO since most
of the ACM APIs expect a LPWAVEFORMATEX.
/home/eric/work/wine/dlls/avifil32/acmstream.c: In function 'AVIFILE_OpenCompressor':
/home/eric/work/wine/dlls/avifil32/acmstream.c:105:24: warning: array subscript 'struct tWAVEFORMATEX[0]' is partly outside array bounds of 'unsigned char[16]' [-Warray-bounds]
105 | This->lpOutFormat->wFormatTag = WAVE_FORMAT_PCM;
| ^~
/home/eric/work/wine/dlls/avifil32/acmstream.c:101:27: note: object of size 16 allocated by 'HeapAlloc'
101 | This->lpOutFormat = HeapAlloc(GetProcessHeap(), 0, This->cbOutFormat);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com>
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/904
On Mon Sep 19 20:51:28 2022 +0000, Alexandre Julliard wrote:
> This should be handled already by LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR. If
> that doesn't work in your case you'll need to investigate why, but we
> can't change the global search path for this.
as far as I can tell LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR is for LoadLibrary not the private search_dll_file function in loader.c (which is where the problem originates from)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/842#note_8876
Map known HRESULT values into their FACILITY_VBS counterparts
Unless the callee provided its own Description (e.g. via SetErrorInfo)
VBscript maps certain well-known HRESULT values into its own error facility
and messages, changing Err.Number and also setting Err.Source to itself
(unless already provided, in which case it is left alone)
e.g. if the invoked method returns E_NOINTERFACE,
The VBScript Err object should show
Err.Number: 0x1AE
Err.Source: Microsoft VBScript runtime error
Err.Description: Class doesn't support Automation
Rather than the original HRESULT
Err.Number: 0x80004002
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/899
Fix bugs in FileSystemObject text-file handling
OpenTextFile(...,ForWriting,True) should either create a new file,
or open and truncate an existing one
OpenTextFile(...,ForAppending,?,True) should write a BOM
if appending to an existing-but-empty file
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/898