- wine-gitlab - winehq.org

[PATCH 0/1] MR890: user32: Fix a memory allocation strategy.
by Akihiro Sagawa (＠sgwaki) 19 Sep '22

19 Sep '22

Otherwise, the function allocates a heap memory when prev_size is enough. What is worse is that it returns the buffer untouched if the prev_size is insufficient. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53703 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/890

3 2

[PATCH v3 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 19 Sep '22

19 Sep '22

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> -- v3: kernelbase: Call NtCancelSynchronousIoFile in CancelSynchronousIo. ntdll: Partially implement NtCancelSynchronousIoFile. ntdll: Add NtCancelSynchronousIoFile stub. kernel32/tests: Add tests for CancelSynchronousIo. https://gitlab.winehq.org/wine/wine/-/merge_requests/47

5 17

[PATCH v2 0/10] MR887: mf/tests: Improve MF transform output checks and dumps.
by Rémi Bernon (＠rbernon) 19 Sep '22

19 Sep '22

-- v2: mf/tests: Dump image samples with a BMP header and RGB data. mf/tests: Rename transform frame dumps to BMP. mf/tests: Check all produced output IMFSample at the same time. mf/tests: Factor IMFSample attributes checks in check_mf_sample. mf/tests: Factor IMFSample checks in a check_mf_sample helper. mf/tests: Introduce a new dump_mf_sample helper. mf/tests: Introduce a new load_resource helper. mf/tests: Factor IMFTransform_ProcessOutput checks together. mf/tests: Use separate variables for input / output samples. mf: Validate sample copier ProcessOutput count parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/887

2 11

[PATCH 0/9] MR887: mf/tests: Improve MF transform output checks and dumps.
by Rémi Bernon (＠rbernon) 19 Sep '22

19 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/887

3 15

[PATCH 0/1] MR889: msvcr100: Fix crash when setting scheduler in schedule_task_proc.
by Piotr Caban (＠piotr) 19 Sep '22

19 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53672 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/889

3 3

[PATCH 0/3] MR13: tests: Various fixes.
by Zebediah Figura (＠zfigura) 19 Sep '22

19 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/13

3 4

[PATCH 0/5] MR874: mfmediaengine: Add tests to exhibit inverted video rendering.
by Rémi Bernon (＠rbernon) 19 Sep '22

19 Sep '22

This shows that media session samples are correctly oriented, but that mfmediaengine renders them upside down. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/874

4 13

[PATCH 0/1] MR886: msvcp90: Fix indentation in concurrent_vector_alloc_segment function.
by Piotr Caban (＠piotr) 19 Sep '22

19 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/886

2 1

[PATCH v2 0/1] MR798: msvcrt: Fix strncmp return value.
by Shaun Ren (＠shaunren) 19 Sep '22

19 Sep '22

Some programs, such as Final Fantasy IV (3D remake), expect strncmp to return exactly +/-1 when the strings are not equal. -- v2: msvcrt: Fix strncmp return value. https://gitlab.winehq.org/wine/wine/-/merge_requests/798

4 4

[PATCH 0/1] MR884: ntdll: Add RtlDosPathNameToRelativeNtPathName_U.
by Gijs Vermeulen (＠gverm) 18 Sep '22

18 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53700 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/884

2 1

[PATCH v2 0/5] MR856: mshtml: url prop for Storage Events and improvements.
by Gabriel Ivăncescu (＠insn) 18 Sep '22

18 Sep '22

-- v2: mshtml: Silence a FIXME when parameter is missing. mshtml: Create non-gecko events properly from type string. mshtml: Implement url prop for StorageEvent. include/mshtml: Move some forward interface declarations to match Windows SDK. mshtml: Override document.URL's name when adding it from the mshtml typelib. https://gitlab.winehq.org/wine/wine/-/merge_requests/856

3 8

[PATCH 0/3] MR883: kernelbase: Add OpenFileMappingFromApp().
by Nikolay Sivov (＠nsivov) 18 Sep '22

18 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/883

2 3

Re: [PATCH v5 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

> You should only call `NtGetCurrentProcessorNumber()` once. Otherwise, the processor number can change if the thread is preempted and then re-scheduled to another processor. This leads to inconsistent values between the return value and the `process_number->Number` output. It's not that `KeGetCurrentProcessorNumberEx()` will be highly useful, since the driver can't block scheduling by raising IRQL to DISPATCH_LEVEL. Still, it's better to at least return consistent values even if they are stale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/824#note_8782

1 0

Re: [PATCH v5 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

Jinoh Kang (@iamahuman) commented about dlls/ntoskrnl.exe/ntoskrnl.c: > > +/*********************************************************************** > + * KeGetCurrentProcessorNumberEx (NTOSKRNL.EXE.@) > + */ > +ULONG WINAPI KeGetCurrentProcessorNumberEx(PPROCESSOR_NUMBER process_number) > +{ > + FIXME("%p semi-stub\n", process_number); > + > + if (process_number) > + { > + process_number->Group = 0; > + process_number->Reserved = 0; > + process_number->Number = NtGetCurrentProcessorNumber(); > + } > + > + return NtGetCurrentProcessorNumber(); You should only call `NtGetCurrentProcessorNumber()` once. Otherwise, the processor number can change if the thread is preempted and then re-scheduled to another processor. This leads to inconsistent values between the return value and the `process_number->Number` output. In general, you should treat `NtGetCurrentProcessorNumber()` as being volatile. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/824#note_8781

1 0

[PATCH 0/1] MR882: concrt140: Use atomic write for releasing threadsafe_queue spin lock.
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

This fixes data race in ARM/ARM64 platforms, and prevents potential memory access reordering by the compiler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/882

2 1

[PATCH 0/1] MR881: kernelbase: Fix reading stale information from IOSB.
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

Ensure IOSB Information (InternalHigh) is loaded after Status (Internal) to avoid reading stale value from the Information (InternalHigh) field. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/881

2 1

[PATCH v5 0/1] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v5: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 1

[PATCH v4 0/1] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) 18 Sep '22

18 Sep '22

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v4: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 1

[PATCH 0/1] MR878: wininet: Use standard HTTP_ADD Flags
by Alistair Leslie-Hughes (＠alesliehughes) 18 Sep '22

18 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/878

3 2

[PATCH 0/1] MR876: jscript: Fix GCC 12.2 warning.
by eric pouech (＠epo) 18 Sep '22

18 Sep '22

When initializing a jsstr_inline_t with a len < 3, the size passed for the allocation is smaller then the size of the structure (as the later is rounded up to the alignment = 4 bytes). GCC 12.2 complains about this when dereferencing the pointer to the structure as the size passed for allocation is smaller than the size of the structure. The warning is fixed by using flexible array member in jsstr_inline_t. Given the rounding behavior in memory allocation, this should not change the size of allocated blocks. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/876

3 2

[PATCH 0/3] MR880: winemac: WoW64 support
by Jacek Caban (＠jacek) 18 Sep '22

18 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/880

2 3

[PATCH v12 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 18 Sep '22

18 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v12: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

3 6

[PATCH 0/1] MR879: oledb32/tests: Free returned property set memory
by Alistair Leslie-Hughes (＠alesliehughes) 18 Sep '22

18 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=36312 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/879

2 1

[PATCH v11 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 17 Sep '22

17 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v11: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

2 5

[PATCH v10 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 17 Sep '22

17 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v10: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

2 5

2025

2024

2023

2022

wine-gitlab