- wine-gitlab - winehq.org

[PATCH 0/1] MR875: glu32: Fix GCC 12.2 warnings.
by eric pouech (＠epo) 16 Sep '22

16 Sep '22

GCC complains about writing 4x4 floats into a pointer to a float. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/875

2 1

Re: [PATCH v5 0/5] MR820: Implement roothandle parameter NtLoadKeyEx
by Huw Davies (＠huw) 16 Sep '22

16 Sep '22

My Windows SDK has `REG_APP_HIVE` defined to 0x10. It also has `REG_PROCESS_PRIVATE` as 0x20, which is presumably what `REG_PROCESS_APPKEY` gets mapped to. If the tests aren't going to work on Win 7, then skip them as soon as the first call returns `STATUS_INVALID_PARAMETER_6`. Since you've found that the key return is only available for an app key, then I don't think it makes sense to split this MR up as I'd previously suggested. That means we need the filename logic back in. A couple of notes on that: When passing strings to the server, we typically don't nul-terminate them and pass the length instead. Also, there is logic there already that copes with loading and saving branches i.e. the `save_branch_info` stuff. Have you looked into adapting that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8694

1 0

[PATCH 0/6] MR856: mshtml: url prop for Storage Events and improvements.
by Gabriel Ivăncescu (＠insn) 16 Sep '22

16 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/856

3 17

[PATCH 0/1] MR837: wininet: Clear cached credentials after the first failed attempt.
by Alistair Leslie-Hughes (＠alesliehughes) 16 Sep '22

16 Sep '22

Windows when using cached credentials will use them on the first challenge, if then a second 403 (ACCESS_DENIED) is received, the user is prompted again but this time with the password and save checkbox cleared. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/837

3 2

Re: [PATCH v5 0/5] MR820: Implement roothandle parameter NtLoadKeyEx
by Santino Mazza (＠tati1454) 16 Sep '22

16 Sep '22

On Fri Sep 16 01:12:18 2022 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=123494 > Your paranoid android. > === debian11 (32 bit report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > === debian11 (32 bit zh:CN report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > === debian11 (32 bit WoW report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > === debian11 (64 bit WoW report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > ``` This test report is from the other force push, now I fixed it with the last push. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8684

1 0

[PATCH v7 0/9] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 16 Sep '22

16 Sep '22

-- v7: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. winecoreaudio: Fix RegEnumKeyExW() call passing wrong unit for the buffer size. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 11

[PATCH 0/1] MR873: xmllite/writer: Enable some more tests for WriteNode().
by Nikolay Sivov (＠nsivov) 16 Sep '22

16 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/873

2 1

[PATCH v6 0/8] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 16 Sep '22

16 Sep '22

-- v6: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 12

[PATCH 0/1] MR867: ntdll: Check for failure from get_initial_environment().
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

Alternatively, since this is early in startup and we don't expect this malloc() to fail, we could simply remove the check from get_initial_environment() itself. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/867

3 2

[PATCH 0/3] MR864: Fixing warnings now spit by GCC 12.2.
by eric pouech (＠epo) 16 Sep '22

16 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/864

3 6

[PATCH 0/1] MR872: winex11: Always initialize escape.drawable in X11DRV_GetDC().
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/872

2 1

[PATCH v2 0/1] MR822: ws2_32: Return a valid value for WSAIoctl SIO_IDEAL_SEND_BACKLOG_QUERY.
by Alistair Leslie-Hughes (＠alesliehughes) 16 Sep '22

16 Sep '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v2: ws2_32: Return a valid value for WSAIoctl SIO_IDEAL_SEND_BACKLOG_QUERY. https://gitlab.winehq.org/wine/wine/-/merge_requests/822

3 2

[PATCH 0/1] MR870: ntdll: Calculate the necessary length after calling snprintf() in SystemWineVersionInformation.
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

This is a gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96367 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/870

2 1

[PATCH 0/1] MR869: win32u: Copy directly into the union pointer in unpack_message().
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

This is a gcc bug; I've filed the following bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106904 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/869

2 1

[PATCH 0/2] MR868: ntdll, libwine: Avoid comparing the result of pointer arithmetic to zero.
by Zebediah Figura (＠zfigura) 16 Sep '22

16 Sep '22

It's not exactly clear to me why gcc warns about this (and it's hard to find reference for this specific flavor of -Waddress), but my understanding is that arithmetic on well-defined pointers will never yield NULL. Of course, we are not dealing with well-defined pointers here, but fortunately gcc does not complain if we cast to intptr_t first. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/868

2 2

[PATCH v5 0/8] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 16 Sep '22

16 Sep '22

-- v5: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 24

Re: [PATCH v3 0/2] MR827: winusb: Add WinUsb_Free stub.
by Mohamad Al-Jaf (＠maljaf) 16 Sep '22

16 Sep '22

On Fri Sep 16 02:11:42 2022 +0000, Huw Davies wrote: > Looks like the app calls `WinUsb_Free(NULL)` on startup. Thank you so much for the review! Yeah, it's quite strange that it calls it with a NULL parameter. What is the purpose of it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/827#note_8654

1 0

[PATCH v4 0/5] MR820: Implement application hives in the registry
by Santino Mazza (＠tati1454) 16 Sep '22

16 Sep '22

-- v4: server: Create \REGISTRY\A hive. ntdll: Implement roothandle parameter for NtLoadKeyEx. ntdll: Rename key variable and file parameter. ntdll/test: Test for NtRegLoadKey roothandle parameter. winnt.h: Create definition for REG_LOAD_APP_KEY. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

3 7

[PATCH 0/5] MR843: wmvcore: More wm async reader refactoring.
by Rémi Bernon (＠rbernon) 15 Sep '22

15 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/843

3 9

[PATCH 0/1] MR754: wined3d: Pass a draw count of 1 to Vulkan indirect draw commands.
by Zebediah Figura (＠zfigura) 15 Sep '22

15 Sep '22

Spotted by Philip Rebohle. This fixes rendering in "Discovery Tour by Assassin's Creed: Ancient Egypt". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/754

5 7

[PATCH 0/1] MR765: wined3d: Do not create larger staging buffers than necessary in adapter_vk_copy_bo_address().
by Zebediah Figura (＠zfigura) 15 Sep '22

15 Sep '22

This greatly increases performance in "Discovery Tour by Assassin's Creed: Ancient Egypt". The application frequently performs small (< 1 kiB) uploads to a large (128 MiB) buffer. Without this patch, we will always create and destroy a new Vulkan memory allocation, and the Vulkan driver will waste time zeroing the entire allocation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/765

4 5

[PATCH 0/1] MR822: ws2_32: Return a valid value for WSAIoctl SIO_IDEAL_SEND_BACKLOG_QUERY.
by Alistair Leslie-Hughes (＠alesliehughes) 15 Sep '22

15 Sep '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/822

3 4

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Bernhard Kölbl (＠besentv) 15 Sep '22

15 Sep '22

> Rebase failed: Rebase locally, resolve all conflicts, then push the branch. Try again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8641

1 0

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 15 Sep '22

15 Sep '22

not sure why this started failing, all I did was click the rebase button in gitlab... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8640

1 0

Re: [PATCH v2 0/3] MR865: d3d10core/tests, d3d11/tests: Fix -Wstringop-overread warnings. - approved
by Alexandre Julliard (＠julliard) 15 Sep '22

15 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/865

1 0

2025

2024

2023

2022

wine-gitlab