- wine-gitlab - winehq.org

Re: [PATCH v2 0/2] MR820: Implement application hives in the registry
by Huw Davies (＠huw) 14 Sep '22

14 Sep '22

On Wed Sep 14 11:53:01 2022 +0000, Santino Mazza wrote: > Because it simplifies the implementation for saving the registry into > the file when NtClose get's called. If I want to keep the object handle > implementation the server should take control for closing the file > handle, and I don't like that idea so much, I think the caller should be > responsible for closing the objects it opens. Ok, let me look into that more. There are a couple more changes you could make in the meantime: - Split the `REG_LOAD_APP_KEY` logic and the return key logic into two commits. - Move the `NtClose()` outside of the `SERVER_START_REQ` block. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8415

1 0

Re: [PATCH v2 0/2] MR820: Implement application hives in the registry
by Santino Mazza (＠tati1454) 14 Sep '22

14 Sep '22

On Wed Sep 14 10:35:23 2022 +0000, Huw Davies wrote: > Why are you now sending the filename, rather than the file object > handle, to the server? Because it simplifies the implementation for saving the registry into the file when NtClose get's called. If I want to keep the object handle implementation the server should take control for closing the file handle, and I don't like that idea so much, I think the caller should be responsible for closing the objects it opens. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8405

1 0

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Bernhard Kölbl (＠besentv) 14 Sep '22

14 Sep '22

On Wed Sep 14 10:36:44 2022 +0000, Alexandre Julliard wrote: > > I bisected the failure and it looks like it's caused instead by > 44d6f2adbcca119faebc095f3cfbeeafc50d04f3, from > https://gitlab.winehq.org/wine/wine/-/merge_requests/657. Reverting it > alone fixes it: > Ah sorry about that, reverting your MR fixed it for me but it's possible > that I screwed up the test. - Just a test message from E-Mail. - Am Mi., 14. Sept. 2022 um 11:05 Uhr schrieb Alexandre Julliard (@julliard) <gitlab(a)winehq.org>: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814#note_8404

1 0

Re: [PATCH v2 0/2] MR820: Implement application hives in the registry
by Huw Davies (＠huw) 14 Sep '22

14 Sep '22

Huw Davies (@huw) commented about server/protocol.def: > > /* Load a registry branch from a file */ > @REQ(load_registry) > - obj_handle_t file; /* file to load from */ > + unsigned int flags; /* flags */ > + unsigned int access; /* wanted access rights */ > VARARG(objattr,object_attributes); /* object attributes */ > + VARARG(filename,string); /* file to load name */ Why are you now sending the filename, rather than the file object handle, to the server? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8403

1 0

Re: [PATCH v2 0/2] MR820: Implement application hives in the registry
by Huw Davies (＠huw) 14 Sep '22

14 Sep '22

Huw Davies (@huw) commented about dlls/advapi32/tests/registry.c: > /* Test simple key load */ > /* Check if the changes are saved */ > ret = RegLoadAppKeyA(hivefilepath, &appkey, KEY_READ | KEY_WRITE, 0, 0); > - ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret); > - ok(appkey != NULL, "got a null key\n"); > + todo_wine ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret); > + todo_wine ok(appkey != NULL, "got a null key\n"); I'd suggest swapping the order of these commits so that you don't end up having to flip-flop these `todo_wine`s. Also note that there's now no need to add the Signed-off-by tags. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8402

1 0

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

> I bisected the failure and it looks like it's caused instead by 44d6f2adbcca119faebc095f3cfbeeafc50d04f3, from https://gitlab.winehq.org/wine/wine/-/merge_requests/657. Reverting it alone fixes it: Ah sorry about that, reverting your MR fixed it for me but it's possible that I screwed up the test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814#note_8398

1 0

Re: [PATCH v2 0/1] MR842: ntdll: add system32/drivers to dll search path
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

This should be handled already by LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR. If that doesn't work in your case you'll need to investigate why, but we can't change the global search path for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/842#note_8397

1 0

Re: [PATCH v2 0/1] MR842: ntdll: add system32/drivers to dll search path - closed
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/842

1 0

Re: [PATCH v2 0/5] MR657: wined3d: Managed texture patches.
by Rémi Bernon (＠rbernon) 14 Sep '22

14 Sep '22

FWIW it looks like this broke ddraw tests, see https://gitlab.winehq.org/wine/wine/-/merge_requests/814#note_8392 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/657#note_8395

1 0

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Rémi Bernon (＠rbernon) 14 Sep '22

14 Sep '22

1 0

[PATCH v13 0/2] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 14 Sep '22

14 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v13: notepad: Track and display line number and column. https://gitlab.winehq.org/wine/wine/-/merge_requests/787

3 3

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic.
by Alexandre Julliard (＠julliard) 14 Sep '22

14 Sep '22

It turns out that it breaks the ddraw tests, could you please have a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814#note_8390

1 0

[PATCH v3 0/9] MR813: mmdevapi: Integrate winecoreaudio's additions in unixlib.h.
by Davide Beatrici (＠davidebeatrici) 14 Sep '22

14 Sep '22

-- v3: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "endpoint" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 13

[PATCH v4 0/2] MR841: ntoskrnl: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 13 Sep '22

13 Sep '22

required for mrac anti cheat -- v4: ntoskrnl: KeDeregisterProcessorChangeCallback stub https://gitlab.winehq.org/wine/wine/-/merge_requests/841

3 3

Re: [PATCH v3 0/6] MR791: mf: Test AAC encoder / decoder presence, begin factoring some transform tests. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/791

1 0

Re: [PATCH v4 0/8] MR814: win32u: Avoid copies in display adapter settings logic. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/814

1 0

Re: [PATCH v2 0/3] MR838: Improvement for inline context debug information. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/838

1 0

Re: [PATCH v3 0/4] MR835: dwrite/layout: Improve trailing empty line metrics. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/835

1 0

Re: [PATCH v2 0/1] MR754: wined3d: Pass a draw count of 1 to Vulkan indirect draw commands. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/754

1 0

Re: [PATCH v2 0/5] MR657: wined3d: Managed texture patches. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/657

1 0

Re: [PATCH v2 0/1] MR765: wined3d: Do not create larger staging buffers than necessary in adapter_vk_copy_bo_address(). - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/765

1 0

Re: [PATCH v2 0/1] MR809: widl: Allow parameterized types in runtimeclass interfaces. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/809

1 0

Re: [PATCH v3 0/9] MR834: Bcrypt algorithm pseudo handles - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/834

1 0

Re: [PATCH v3 0/4] MR833: A few stubs for advapi perf functions. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/833

1 0

Re: [PATCH v3 0/9] MR803: winegstreamer: Refactor wm async reader clock. - approved
by Alexandre Julliard (＠julliard) 13 Sep '22

13 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/803

1 0

2025

2024

2023

2022

wine-gitlab