- wine-gitlab - winehq.org

[PATCH 0/1] MR802: wow64: Don't re-enter cpu_simulate() from exception filter.
by Brendan Shanks (＠bshanks) 07 Sep '22

07 Sep '22

This avoids an eventual stack overflow in exception-heavy applications. Important note: when using the experimental Wow64 support on Linux, this change causes a crash during exception handling when unix_funcs->unwind_builtin_dll is called. The call in dll/ntdll/signal_x86_64.c virtual_unwind() to unix_funcs->unwind_builtin_dll() should be commented out and replaced with 'status = STATUS_UNSUCCESSFUL;'. This is along the same lines as needing to comment out the unix_funcs->init_builtin_dll() call for Wow64. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/802

2 1

Re: [PATCH v2 0/7] MR767: rpcrt4, msvcrt: Add SEH annotations to some functions. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/767

1 0

Re: [PATCH v3 0/1] MR774: msvcp140: Add _ExceptionHolder::ReportUnhandledError stub. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/774

1 0

Re: [PATCH v2 0/1] MR779: msvcrt: Fix the spelling of a comment. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/779

1 0

Re: [PATCH v3 0/2] MR796: include/test.h: Don't use strcasecmp. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/796

1 0

Re: [PATCH v2 0/1] MR800: crypt32/tests: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/800

1 0

Re: [PATCH v2 0/2] MR797: ddraw/tests: Avoid picking a large mode on Win10 in test_coop_level_mode_set_enum_cb. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/797

1 0

Re: [PATCH v3 0/1] MR784: wined3d: Tell vkd3d_shader about dual source blending. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/784

1 0

Re: [PATCH v3 0/8] MR695: winegstreamer: Initial fixes and refactor of the WM async reader. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/695

1 0

[PATCH v2 0/3] MR801: uiautomationcore: Implement basic HWND based HUIANODE behavior.
by Connor McAdams (＠cmcadams) 07 Sep '22

07 Sep '22

Hopefully this patch series is easier to review than the last one. -- v2: uiautomationcore: Implement UiaNodeFromHandle. uiautomationcore: Add get_prop_val method to IWineUiaNode. uiautomationcore: Implement UiaReturnRawElementProvider. https://gitlab.winehq.org/wine/wine/-/merge_requests/801

2 4

[PATCH 0/7] MR767: rpcrt4, msvcrt: Add SEH annotations to some functions.
by Zebediah Figura (＠zfigura) 07 Sep '22

07 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/767

3 8

[PATCH v2 0/1] MR774: msvcp140: Add _ExceptionHolder::ReportUnhandledError stub.
by Gijs Vermeulen (＠gverm) 07 Sep '22

07 Sep '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53614 Signed-off-by: Gijs Vermeulen <gverm(a)inuits.eu> -- v2: msvcp140: Add _ExceptionHolder::ReportUnhandledError stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/774

3 2

[PATCH 0/1] MR779: msvcrt: Fix the spelling of a comment.
by Francois Gouget (＠fgouget) 07 Sep '22

07 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/779

4 3

[PATCH 0/3] MR801: uiautomationcore: Implement basic HWND based HUIANODE behavior.
by Connor McAdams (＠cmcadams) 07 Sep '22

07 Sep '22

Hopefully this patch series is easier to review than the last one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/801

2 3

[PATCH v3 0/3] MR793: uiautomationcore: Implement HWND based HUIANODEs.
by Connor McAdams (＠cmcadams) 07 Sep '22

07 Sep '22

-- v3: uiautomationcore: Implement UiaDisconnectProvider. uiautomationcore: Implement UiaNodeFromHandle. uiautomationcore: Implement UiaReturnRawElementProvider. https://gitlab.winehq.org/wine/wine/-/merge_requests/793

3 7

[PATCH v8 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 07 Sep '22

07 Sep '22

-- v8: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

2 1

[PATCH v7 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 07 Sep '22

07 Sep '22

-- v7: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 2

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/notepad.rc: > MENUITEM "&Search next\tF3", CMD_SEARCH_NEXT > MENUITEM "&Replace...\tCtrl+H", CMD_REPLACE > } > +POPUP "&View" > +{ > + MENUITEM "&Status Bar", CMD_SBAR > + } Another trailing space after `"&View"` and a space before the `}`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7878

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > + > +VOID UpdateStatusBar(VOID) > +{ > + int currentLine; > + int currentCol = -1; > + wchar_t statusTxt[25]; > + int lineIndex; > + DWORD selStart; > + DWORD selEnd; > + > + SendMessageW(Globals.hEdit,EM_GETSEL , (WPARAM)&selStart,(LPARAM)&selEnd); > + if(selStart == selEnd) > + Globals.trackedSel = selStart; > + if(selStart < Globals.trackedSel) > + currentCol = selStart; > + else And this has a trailing space after the `else`. There are other instances below as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7877

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > + CheckMenuItem(GetMenu(Globals.hMainWnd),CMD_SBAR, > + MF_BYCOMMAND | (Globals.bStatusBar ? MF_CHECKED : MF_UNCHECKED)); > + GetClientRect(Globals.hMainWnd, &rc); > + ShowWindow(Globals.hStatusBar,Globals.bStatusBar); > + SendMessageW(Globals.hMainWnd,WM_SIZE,0,MAKELPARAM(rc.right,rc.bottom)); > +} > + > +VOID UpdateStatusBar(VOID) > +{ > + int currentLine; > + int currentCol = -1; > + wchar_t statusTxt[25]; > + int lineIndex; > + DWORD selStart; > + DWORD selEnd; > + This line contains 4 spaces. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7876

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > } > } > > +LRESULT CALLBACK EDIT_CallBackProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + switch (msg) > + { > + case WM_KEYDOWN: > + UpdateStatusBar(); > + break; > + case WM_KEYUP: > + UpdateStatusBar(); > + break; > + case WM_MBUTTONDOWN: > + UpdateStatusBar(); > + break; This could all be simplifed: ```c case WM_KEYDOWN: case WM_KEYUP: case WM_MBUTTONDOWN: ... UpdateStatusBar(); break; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7875

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > return dpi; > } > > +VOID ToggleStatusBar(VOID) > +{ > + RECT rc; > + > + Globals.bStatusBar = !Globals.bStatusBar; > + CheckMenuItem(GetMenu(Globals.hMainWnd),CMD_SBAR, > + MF_BYCOMMAND | (Globals.bStatusBar ? MF_CHECKED : MF_UNCHECKED)); > + GetClientRect(Globals.hMainWnd, &rc); > + ShowWindow(Globals.hStatusBar,Globals.bStatusBar); > + SendMessageW(Globals.hMainWnd,WM_SIZE,0,MAKELPARAM(rc.right,rc.bottom)); Again, call your newly added helper function instead of sending `WM_SIZE`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7874

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/main.c: > return dpi; > } > > +VOID ToggleStatusBar(VOID) `static` (as the function isn't used outside the file). Also, and I know it not the case in this file, but let's use `void` rather than `VOID`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7873

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Huw Davies (@huw) commented about programs/notepad/dialog.c: > Globals.bWrapLongLines = !Globals.bWrapLongLines; > CheckMenuItem(GetMenu(Globals.hMainWnd), CMD_WRAP, > MF_BYCOMMAND | (Globals.bWrapLongLines ? MF_CHECKED : MF_UNCHECKED)); > + SendMessageW(Globals.hMainWnd,WM_SIZE,0,MAKELPARAM(rc.right,rc.bottom)); This looks hacky. You probably want to move the code that you're adding to the main window's WM_SIZE handler to a helper function and call that directly from here. Also, and this applies throughout, please leave a space after each comma. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7872

1 0

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Huw Davies (＠huw) 07 Sep '22

07 Sep '22

Generally I think this MR should be split into two separate ones. That'll give us a chance to get the status bar work in before we worry about the goto dialog box. So, just concentrating on the status bar commit, I'd start off by splitting that into two commits. First add the code that creates and displays the status bar (it doesn't need to display any text at this point). Then add a second commit that updates the status bar with line / col info. As @besentv mentioned, the commit messages are still not quite there - we terminate the subject with a period. I'll comment on some of the code below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7869

1 0

2025

2024

2023

2022

wine-gitlab