- wine-gitlab - winehq.org

Re: [PATCH v3 0/1] MR794: evr/filter: Initial implementation of sample rendering.
by Nikolay Sivov (＠nsivov) 07 Sep '22

07 Sep '22

On Tue Sep 6 20:28:13 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 9/6/22 09:12, Nikolay Sivov wrote: > > +static HRESULT evr_get_service(void *unk, REFGUID service, REFIID > riid, void **obj) > > +{ > > + IMFGetService *gs; > > + HRESULT hr; > > + > > + if (SUCCEEDED(hr = IUnknown_QueryInterface((IUnknown *)unk, > &IID_IMFGetService, (void **)&gs))) > > + { > > + hr = IMFGetService_GetService(gs, service, riid, obj); > > + IMFGetService_Release(gs); > > + } > > + > > + return hr; > > +} > > + > Isn't this MFGetService()? > (It also isn't really evr-specific, so I'd be inclined to omit the evr_ > prefix, but that's a rather minor quibble.) > ``` Yes, it is, but I don't want to link to mf.dll just for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/794#note_7860

1 0

[PATCH 0/1] MR800: crypt32/tests: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 07 Sep '22

07 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/800

2 1

[PATCH v3 0/7] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon (＠rbernon) 07 Sep '22

07 Sep '22

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v3: win32u: Return DISP_CHANGE_SUCCESSFUL from nulldrv_ChangeDisplaySettingsEx. win32u: Read current display settings from the registry if GetCurrentDisplaySettings fails. win32u: Write current display settings to the registry in apply_display_settings. win32u: Force update display cache after NtUserChangeDisplaySettingsEx. win32u: Introduce a new VirtualScreenRectChanged display driver callback. win32u: Broadcast WM_DISPLAYCHANGE message on display settings change. win32u: Move enumeration of available modes out of graphics drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

4 24

[PATCH 0/2] MR798: msvcrt: Fix strncmp return value.
by Shaun Ren (＠shaunren) 06 Sep '22

06 Sep '22

Some programs, such as Final Fantasy IV (3D remake), expect strncmp to return exactly +/-1 when the strings are not equal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/798

3 3

Re: [PATCH v3 0/6] MR788: winevulkan: Move dispatchable handles allocation to PE code. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/788

1 0

Re: [PATCH v2 0/4] MR792: include: Add some more MFT / DMO class ids and WMV media type ids. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/792

1 0

Re: [PATCH v3 0/1] MR794: evr/filter: Initial implementation of sample rendering. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/794

1 0

Re: [PATCH v2 0/2] MR790: scrrun: Store full path in folder object. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/790

1 0

Re: [PATCH v3 0/3] MR783: dwrite: Handle higher planes when setting DWRITE_SCRIPT_SHAPES_NO_VISUAL. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/783

1 0

Re: [PATCH v6 0/1] MR772: tests: Allow marking unreliable tests as flaky. - approved
by Alexandre Julliard (＠julliard) 06 Sep '22

06 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/772

1 0

[PATCH 0/2] MR797: ddraw/tests: Avoid picking a large mode on Win10 in test_coop_level_mode_set_enum_cb.
by Stefan Dösinger (＠stefan) 06 Sep '22

06 Sep '22

--- Example test failure: http://test.winehq.org/data/c1db36686c7adb1f117e2aeecbd024949fc1e6ae/win21H… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/797

4 5

[PATCH v2 0/1] MR794: evr/filter: Initial implementation of sample rendering.
by Nikolay Sivov (＠nsivov) 06 Sep '22

06 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: evr/filter: Initial implementation of sample rendering. https://gitlab.winehq.org/wine/wine/-/merge_requests/794

3 2

[PATCH 0/1] MR782: evr/filter: Notify mixer and presenter on state changes.
by Nikolay Sivov (＠nsivov) 06 Sep '22

06 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/782

3 2

[PATCH v2 0/1] MR784: wined3d: Tell vkd3d_shader about dual source blending.
by Stefan Dösinger (＠stefan) 06 Sep '22

06 Sep '22

Dual source blending implies an additional shader output, which needs to be declared. This improves WoT on high graphics settings on MoltenVK. -- v2: wined3d: Tell vkd3d_shader about dual source blending. https://gitlab.winehq.org/wine/wine/-/merge_requests/784

3 3

[PATCH v2 0/8] MR695: winegstreamer: Initial fixes and refactor of the WM async reader.
by Rémi Bernon (＠rbernon) 06 Sep '22

06 Sep '22

This includes some fixes for obvious mistakes as well as initial cleanup of the WM async reader, in preparation for implementing proper threading support. I'm planning on doing some more refactoring first, ultimately implementing the async reader on top of the sync reader, and removing the need for a private interface. I've checked that it can indeed work on Windows too, and it'll make the code simpler overall. -- v2: winegstreamer: Query IWMReaderCallbackAdvanced interface in Open. winegstreamer: Avoid waiting for callback thread on allocation failure. winegstreamer: Release callback and context in async_reader_close. winegstreamer: Move open_stream / close_stream helpers around. winegstreamer: Leave async reader callback_cs on calloc error. winegstreamer: Leave WM reader CS on invalid output format. winegstreamer: Avoid leaking async ops on release or multiple close. winegstreamer: Rename async reader stream_thread to callback_thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/695

3 10

[PATCH v2 0/6] MR788: winevulkan: Move dispatchable handles allocation to PE code.
by Jacek Caban (＠jacek) 06 Sep '22

06 Sep '22

Instead of leaking "kernel" pointers. -- v2: winevulkan: Separate PE and Unix VkCommandBuffer structs. winevulkan: Wrap VkCommandPool on PE side. winevulkan: Separate PE and Unix VkPhysicalDevice strucrts. winevulkan: Separate PE and Unix VkInstance structs. winevulkan: Separate PE and Unix VkQueue structs. winevulkan: Separate PE and Unix VkDevice structs. https://gitlab.winehq.org/wine/wine/-/merge_requests/788

2 7

Re: [PATCH v22 0/4] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens (＠tobi.goergens) 06 Sep '22

06 Sep '22

On Wed Aug 10 18:46:02 2022 +0000, Tobias G��rgens wrote: > All commits build now and tests run through fine. > What do I need to do next? > Is there still anything I should change? Hey there, I'd really like to get this through, I just need to know what's missing/what I should do next :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_7627

2 1

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Bernhard Kölbl (＠besentv) 06 Sep '22

06 Sep '22

On Tue Sep 6 15:11:41 2022 +0000, Jacob Czekalla wrote: > They should be good now. Thanks. Not quite, please refer to: https://wiki.winehq.org/Submitting_Patches#The_commit_message -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7814

1 0

[PATCH v4 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 06 Sep '22

06 Sep '22

-- v4: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 5

[PATCH 0/6] MR788: winevulkan: Move dispatchable handles allocation to PE code.
by Jacek Caban (＠jacek) 06 Sep '22

06 Sep '22

Instead of leaking "kernel" pointers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/788

3 7

[PATCH 0/2] MR796: include/test.h: Don't use strcasecmp.
by Stefan Dösinger (＠stefan) 06 Sep '22

06 Sep '22

Fixes building tests in Visual Studio with msvc's own crt headers. --- This follows patches in other places that replaced it first with _strnicmp(a, b, -1), and later with _stricmp(a, b), because _strnicmp with size=-1 raises a runtime error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/796

3 3

[PATCH v2 0/6] MR795: mshtml: Implement Storage Events.
by Gabriel Ivăncescu (＠insn) 06 Sep '22

06 Sep '22

This implements sending StorageEvents to the same window/doc from where the storage change happened, which seems to be a thing on native IE. For some reason I was unable to have them actually sent to other windows, so that's not implemented since I've no idea how that even gets triggered to test it, and if it does it will probably be in a follow up MR, even though that's *supposed* to be the use of these events�� localStorage sends for `onstoragecommit` on the doc that did the change, while sessionStorage sends for `onstorage` on the window and doc that did the change, depending on compat mode. Although the event sent to the document's `onstorage` seems to be a legacy/old-style event (as tests show). Tests are on the last patch since events have to be sent properly (else it hangs). -- v2: mshtml/tests: Add tests for StorageEvents. mshtml: Send StorageEvents when removing an existing item. mshtml: Send StorageEvents when setting an item. mshtml: Implement StorageEvent and send it when clearing the storage. mshtml: Move the MessageEvent construction to a helper. include: Add IDOMStorageEvent and DispDOMStorageEvent interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/795

3 8

[PATCH 0/6] MR795: mshtml: Implement Storage Events.
by Gabriel Ivăncescu (＠insn) 06 Sep '22

06 Sep '22

This implements sending StorageEvents to the same window/doc from where the storage change happened, which seems to be a thing on native IE. For some reason I was unable to have them actually sent to other windows, so that's not implemented since I've no idea how that even gets triggered to test it, and if it does it will probably be in a follow up MR, even though that's *supposed* to be the use of these events�� localStorage sends for `onstoragecommit` on the doc that did the change, while sessionStorage sends for `onstorage` on the window and doc that did the change, depending on compat mode. Although the event sent to the document's `onstorage` seems to be a legacy/old-style event (as tests show). Tests are on the last patch since events have to be sent properly (else it hangs). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/795

3 7

[PATCH v3 0/2] MR787: notepad: Add status bar and goto line dialog
by Jacob Czekalla (＠Maaka00524) 06 Sep '22

06 Sep '22

Added a status bar to track line and column number Added a goto line dialog -- v3: notepad: Added goto dialog function notepad: Added status bar to track line number and column https://gitlab.winehq.org/wine/wine/-/merge_requests/787

2 3

[PATCH v2 0/3] MR793: uiautomationcore: Implement HWND based HUIANODEs.
by Connor McAdams (＠cmcadams) 06 Sep '22

06 Sep '22

-- v2: uiautomationcore: Implement UiaDisconnectProvider. uiautomationcore: Implement UiaNodeFromHandle. https://gitlab.winehq.org/wine/wine/-/merge_requests/793

2 4

2025

2024

2023

2022

wine-gitlab