- wine-gitlab - winehq.org

[PATCH v2 0/1] MR726: msvfw32: Use string comparison to determine class name equality.
by Alexandros Frantzis (＠afrantzis) 30 Aug '22

30 Aug '22

The previous version of the code incorrectly assumed that the lpszClass member of CREATESTRUCT passed with WM_CREATE would point to the same memory used for the CreateWindowEx class name parameter, and used a pointer comparison to check for class name equality. As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWND_Create(). This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578 -- v2: msvfw32: Use string comparison to determine class name equality. https://gitlab.winehq.org/wine/wine/-/merge_requests/726

2 1

[PATCH 0/1] MR726: msvfw32: Use string comparison to determine class name equality.
by Alexandros Frantzis (＠afrantzis) 30 Aug '22

30 Aug '22

The previous version of the code incorrectly assumed that the lpszClass member of CREATESTRUCT passed with WM_CREATE would point to the same memory used for the CreateWindowEx class name parameter, and used a pointer comparison to check for class name equality. As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWndCreate(). This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality. Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/726

2 1

[PATCH v11 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) 30 Aug '22

30 Aug '22

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v11: comdlg32: Add missing controls to the common item dialog, only affecting the implementation comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/672

3 4

Re: [PATCH v8 0/9] MR6: Avoid performance degradation due to vDSO unmapping (BZ#52313)
by Olivia/Isabelle Mahadevan (＠doubledge-spec) 30 Aug '22

30 Aug '22

Any update on this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6#note_7189

1 0

Re: [PATCH v3 0/3] MR725: evr/filter: Implement media type testing for QueryAccept().
by Nikolay Sivov (＠nsivov) 30 Aug '22

30 Aug '22

On Mon Aug 29 20:13:37 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 8/29/22 09:39, Nikolay Sivov wrote: > > @@ -296,6 +299,15 @@ static void test_interfaces(void) > > check_interface(filter, &IID_IReferenceClock, FALSE); > > check_interface(filter, &IID_IVideoWindow, FALSE); > > > > + /* The scope of IMediaEventSink */ > > + hr = IBaseFilter_QueryInterface(filter, &IID_IMediaEventSink, > (void **)&unk); > > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > > + hr = IUnknown_QueryInterface(unk, &IID_IBaseFilter, (void **)&filter2); > > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > > + ok(filter == filter2, "Unexpected pointer.\n"); > > + IBaseFilter_Release(filter2); > > + IUnknown_Release(unk); > > + > > ref = IBaseFilter_Release(filter); > > ok(!ref, "Got unexpected refcount %ld.\n", ref); > > } > Somewhat out of curiosity, why this test? > ``` It's done differently in mf/evr.c where this interface is not exposed, except during InitServices(). The test was to show that it's done in a usual way in this case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/725#note_7188

1 0

Re: [PATCH v3 0/3] MR725: evr/filter: Implement media type testing for QueryAccept(). - approved
by Alexandre Julliard (＠julliard) 29 Aug '22

29 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/725

1 0

Re: [PATCH v7 0/5] MR708: windows.media.speech: Fix test breakage and misc changes. - approved
by Alexandre Julliard (＠julliard) 29 Aug '22

29 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/708

1 0

[PATCH v2 0/4] MR710: Fixes for volume size information retrieval
by jhol (＠jhol) 29 Aug '22

29 Aug '22

-- v2: mountmgr.sys: Implemented FileFsSizeInformation and FileFsFullSizeInformation volume queries ntdll: Implemented NtQueryVolumeInformationFile FileFsFullSizeInformation kernel32/tests: Added tests for GetDiskFreeSpaceA/W with volume GUID paths kernel32/tests: GetDiskFreeSpaceA/W test targetted at a real drive https://gitlab.winehq.org/wine/wine/-/merge_requests/710

3 6

[PATCH v2 0/3] MR725: evr/filter: Implement media type testing for QueryAccept().
by Nikolay Sivov (＠nsivov) 29 Aug '22

29 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: evr/filter: Implement media type testing for QueryAccept(). evr/filter: Add IMFTopologyServiceLookup stub. evr/filter: Add IMediaEventSink stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/725

4 5

[PATCH v3 0/7] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface.
by Julian Klemann (＠jklemann) 29 Aug '22

29 Aug '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53328 -- v3: windows.devices.enumeration/tests: Add test for Stopped DeviceWatcher event. windows.devices.enumeration: Add DeviceWatcher class. windows.devices.enumeration: Create private header file. windows.devices.enumeration: Add IDeviceInformationStatics2 interface. windows.devices.enumeration: Replace STDMETHODCALLTYPE with WINAPI. include/windows.devices.enumeration: Update file to newer formatting. widl: Use "cinterface(IInspectable)" for IInspectable signature. https://gitlab.winehq.org/wine/wine/-/merge_requests/716

3 17

[PATCH 0/3] MR725: evr/filter: Implement media type testing for QueryAccept().
by Nikolay Sivov (＠nsivov) 29 Aug '22

29 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/725

3 5

[PATCH v2 0/5] MR720: winemac: Allow enumeration of non-primary display modes.
by Rémi Bernon (＠rbernon) 29 Aug '22

29 Aug '22

In preparation for with https://gitlab.winehq.org/wine/wine/-/merge_requests/576. I think support for changing non-primary display modes in winemac will be easier /after/ the display placement logic is moved to win32u. I also don't really know how to handle the display position on macOS. -- v2: winemac.drv: Support enumerating non-primary adapters display modes. winemac.drv: Support getting non-primary adapter current display mode. winemac.drv: Invalidate mode cache when enum flags changes. winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. winemac.drv: Rename display modes cache variables. https://gitlab.winehq.org/wine/wine/-/merge_requests/720

3 9

Re: [PATCH v6 0/5] MR708: windows.media.speech: Fix test breakage and misc changes.
by Bernhard Kölbl (＠besentv) 29 Aug '22

29 Aug '22

On Mon Aug 29 09:24:17 2022 +0000, Bernhard K��lbl wrote: > Alright Still changed it. :3 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/708#note_7147

1 0

[PATCH 0/2] MR724: d3dx10: Fix stride of block compressed format when creating texture.
by Ziqing Hui (＠zhui) 29 Aug '22

29 Aug '22

A block-compressed texture is encoded in 4x4 blocks. Therefore, pitch is the number of bytes in a block of 4x4 texels. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/724

3 4

[PATCH v5 0/5] MR708: windows.media.speech: Fix test breakage and misc changes.
by Bernhard Kölbl (＠besentv) 29 Aug '22

29 Aug '22

Created a new MR, because the mailing bridge wouldn't trigger on force pushes. -- v5: windows.media.speech/tests: Skip SpeechRecognitionListConstraint tests on Win10 1709 x32 and below. windows.media.speech/tests: Add basic query tests for SpeechSynthesizerOptions. include/windows.media.speechsynthesis.idl: Add missing interfaces to SpeechSynthesizerOptions runtimeclass. windows.media.speech: Add missing async_void_Release implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/708

3 11

[PATCH 0/3] MR710: Fixes for volume size information retrieval
by jhol (＠jhol) 29 Aug '22

29 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/710

4 8

[PATCH v5 0/8] MR717: Implement application hives in the registry
by Santino Mazza (＠tati1454) 28 Aug '22

28 Aug '22

Initial implementation for registry application hives, this is a step forward to get Visual Studio to run. :-) -- v5: server: save app hive into it's file when closing handle. server/registry: pass file name instead of file handle to server. kernelbase: Implement RegLoadAppKey. ntdll: Initial implementation for application hives. ntdll: Move NtLoadKey implementation to NtLoadKeyEx. ntdll/test: Test for application hives. ntdll: Create NtLoadKeyEx syscall stub. advapi32/test: Create tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/717

2 9

[PATCH v4 0/8] MR717: Implement application hives in the registry
by Santino Mazza (＠tati1454) 28 Aug '22

28 Aug '22

Initial implementation for registry application hives, this is a step forward to get Visual Studio to run. :-) -- v4: server: save app hive into it's file when closing handle. server/registry: pass file name instead of file handle to server. kernelbase: Implement RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/717

3 11

Re: [PATCH v4 0/8] MR704: mshtml: sessionStorage implementation. - approved
by Alexandre Julliard (＠julliard) 28 Aug '22

28 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/704

1 0

Re: [PATCH v2 0/7] MR719: user32: win32u conversion clean up - approved
by Alexandre Julliard (＠julliard) 28 Aug '22

28 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/719

1 0

Re: [PATCH v2 0/1] MR718: wow64: Fix another ARM32 machine type. - approved
by Alexandre Julliard (＠julliard) 28 Aug '22

28 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/718

1 0

Re: [PATCH v3 0/3] MR713: mfplat: Partially implement some format description conversion helpers. - approved
by Alexandre Julliard (＠julliard) 28 Aug '22

28 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/713

1 0

Re: [PATCH v3 0/6] MR697: Implement d3dx10 effect creation for compiled shader.
by Ziqing Hui (＠zhui) 27 Aug '22

27 Aug '22

v2: * Move test_fx_source above its byte code. * Correct "texture" typo. * Use "memcmp()" instead of "memcmp() != 0". * Drop last commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/697#note_7096

1 0

[PATCH v2 0/6] MR697: Implement d3dx10 effect creation for compiled shader. Fix pitch of block-compressed texture in texture creation.
by Ziqing Hui (＠zhui) 27 Aug '22

27 Aug '22

Note for patch 7: See https://docs.microsoft.com/en-us/windows/win32/api/d3d10/ns-d3d10-d3d10_map… : > A block-compressed texture is encoded in 4x4 blocks (see virtual size vs physical size) ; therefore, RowPitch is the number of bytes in a block of 4x4 texels. -- v2: d3dx10: Return E_FAIL in D3DX10CreateEffectFromFile for NULL file name. d3dx10: Support effect creation for compiled shader. d3dx10: Introduce create_effect(). d3dx10/tests: Add tests for D3DX10CreateEffectFromResource. d3dx10/tests: Add tests for D3DX10CreateEffectFromFile. d3dx10/tests: Add tests for D3DX10CreateEffectFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/697

2 6

[PATCH 0/7] MR697: Implement d3dx10 effect creation for compiled shader. Fix pitch of block-compressed texture in texture creation.
by Ziqing Hui (＠zhui) 27 Aug '22

27 Aug '22

Note for patch 7: See https://docs.microsoft.com/en-us/windows/win32/api/d3d10/ns-d3d10-d3d10_map… : > A block-compressed texture is encoded in 4x4 blocks (see virtual size vs physical size) ; therefore, RowPitch is the number of bytes in a block of 4x4 texels. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/697

3 18

2025

2024

2023

2022

wine-gitlab