- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR680: maintainers: Remove advice about Cc'ing patches. - approved
by Alexandre Julliard (＠julliard) 19 Aug '22

19 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/680

1 0

Re: [PATCH v3 0/2] MR669: gdi32/tests: Add more tests for GetTextMetrics(). - approved
by Alexandre Julliard (＠julliard) 19 Aug '22

19 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/669

1 0

Re: [PATCH v8 0/2] MR628: win32u: Fix the second_name parsed wrong. - approved
by Alexandre Julliard (＠julliard) 19 Aug '22

19 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/628

1 0

Re: [PATCH v9 0/1] MR677: kerberos: Fix regression in kerberos_SpInitLsaModeContext and kerberos_SpAcceptLsaModeContext - approved
by Alexandre Julliard (＠julliard) 19 Aug '22

19 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677

1 0

Re: [PATCH v2 0/3] MR679: scrrun: Correct string length returned from GetTempName. - approved
by Alexandre Julliard (＠julliard) 19 Aug '22

19 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/679

1 0

[PATCH v2 0/4] MR681: evr: Partially implement GetService() for dshow filter.
by Nikolay Sivov (＠nsivov) 19 Aug '22

19 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: evr/tests: Add a test to show that IMFVideoDisplayControl is accessible. evr: Implement lazy initialization with mixer and presenter instances. evr: Add IMFVideoRenderer stub to the filter. evr: Add IMFGetService stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/681

2 4

[PATCH 0/7] MR675: mciqtz32 window command improvements
by Akihiro Sagawa (＠sgwaki) 19 Aug '22

19 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/675

4 9

[PATCH 0/4] MR681: evr: Partially implement GetService() for dshow filter.
by Nikolay Sivov (＠nsivov) 19 Aug '22

19 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/681

3 6

Re: [PATCH v2 0/5] MR635: Draft: Implement transform graph. Partically implement effect drawing.
by Nikolay Sivov (＠nsivov) 19 Aug '22

19 Aug '22

> Yeah, ID2D1DrawTransform can be implemented for \*Impl object, that's true. But we still need transfrom graph. Implementing ID2D1DrawTransform for \*Impl doesn't means that it will be used automatically without doing anything else. We still need to regard it as a transform node, and add it to transfrom graph. And latter, runtime will call SetDrawInfo for it because it is in transform graph. Yes, you're right, I missed that it's in a chain of draw transform -> transform -> transformnode. MSDN is broken there, it says interface> Nikolay, do you think I can submit first 3 patches in another MR to make you have a full reviewing in order to upstream them? inherits from IUnknown. That's why I thought it's something special. I think there are options still, effect can use SetSingleTransformNode to add it explicitly, but I believe I saw examples somewhere that don't do it, so maybe it's handled by d2d itself. I could be wrong of course. > Nikolay, do you think I can submit first 3 patches in another MR to make you have a full reviewing in order to upstream them? Please do. We should start with single node graph first to get something render first, and have inputs/outputs behaving correctly. I think doing multiple nodes processing in naive way, by drawing each intermediate step, is likely to be a performance problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/635#note_6556

1 0

[PATCH v2 0/2] MR669: gdi32/tests: Add more tests for GetTextMetrics().
by Zhiyi Zhang (＠zhiyi) 19 Aug '22

19 Aug '22

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- v2: win32u: Choose a smaller ppem to avoid exceeding the requested font height. https://gitlab.winehq.org/wine/wine/-/merge_requests/669

3 4

[PATCH 0/1] MR682: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 19 Aug '22

19 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/682

2 1

[PATCH 0/1] MR680: maintainers: Remove advice about Cc'ing patches.
by Huw Davies (＠huw) 19 Aug '22

19 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/680

2 1

[PATCH v7 0/2] MR628: win32u: Fix the second_name parsed wrong.
by Jiajin Cui (＠jin-king1) 19 Aug '22

19 Aug '22

When first parsed to names in english and other non-native languages, after parsing to names in native languages, this will result in second_name not corresponding to names in english. Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- v7: win32u: Don't allow a replaced font to be a replacement. win32u: Ensure that either the primary or secondary name is in English. https://gitlab.winehq.org/wine/wine/-/merge_requests/628

3 4

[PATCH 0/3] MR679: scrrun: Correct string length returned from GetTempName.
by Robert Wilhelm (＠sloper42) 19 Aug '22

19 Aug '22

You have to pass string length without terminal null to SysAllocStringLen. This fixes following vbscript code: Temp_Path = strSystemRoot & "\" & fso.GetTempName() & ".vbs" Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53569 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/679

3 4

Re: [PATCH v8 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext - approved
by Hans Leidekker (＠hans) 19 Aug '22

19 Aug '22

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677

1 0

Re: [PATCH v7 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:54:40 2022 +0000, Hans Leidekker wrote: > In the patch title please replace one occurrence of > kerberos_SpAcceptLsaModeContext with kerberos_SpInitLsaModeContext. > Otherwise the patch looks good. Pushed. Sorry, I did not notice a repetition in title. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6535

1 0

Re: [PATCH v6 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Hans Leidekker (＠hans) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:46:28 2022 +0000, Konstantin wrote: > Pushed In the patch title please replace one occurrence of kerberos_SpAcceptLsaModeContext with kerberos_SpInitLsaModeContext. Otherwise the patch looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6533

1 0

Re: [PATCH v6 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:38:54 2022 +0000, Hans Leidekker wrote: > Yes. Pushed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6532

1 0

Re: [PATCH v4 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Hans Leidekker (＠hans) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:32:04 2022 +0000, Konstantin wrote: > Do you mean this? > ``` > if ( status == SEC_E_OK || status == SEC_I_CONTINUE_NEEDED ) > *new_context = create_context_handle( context_handle, > new_context_handle ); > if (!status) > { > *mapped_context = TRUE; > ``` Yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6529

1 0

Re: [PATCH v4 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:20:50 2022 +0000, Hans Leidekker wrote: > The change should be minimal, so only change the condition for the > new_context update. Please put spaces around operators like in the rest > of the file. > Please also fix the patch title while you're at it :) Do you mean this? ``` if ( status == SEC_E_OK || status == SEC_I_CONTINUE_NEEDED ) *new_context = create_context_handle( context_handle, new_context_handle ); if (!status) { *mapped_context = TRUE; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6528

1 0

Re: [PATCH v4 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Hans Leidekker (＠hans) 19 Aug '22

19 Aug '22

On Fri Aug 19 07:54:25 2022 +0000, Konstantin wrote: > Tested the changes, kerberos auth in our client application work fine. The change should be minimal, so only change the condition for the new_context update. Please put spaces around operators like in the rest of the file. Please also fix the patch title while you're at it :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6527

1 0

Re: [PATCH v4 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 07:19:10 2022 +0000, Konstantin wrote: > @hans, thank you for comment. If I understand correct you are author of > original logic. > I am not sure about changes, your suggestion change existing logic. > Originaly `*mapped_context` and `expiry_to_timestamp( exptime, expiry > );` executed only when status is SEC_E_OK, and `new_context` > modification (independant) internaly in `create_context_handle`. > I try change condition to ` if > (status==SEC_E_OK||status==SEC_I_CONTINUE_NEEDED) ` and test it in our network. Tested the changes, kerberos auth in our client application work fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6526

1 0

Re: [PATCH v6 0/1] MR672: Draft: Common item dialog fixes
by Ben Cottrell (＠bgc) 19 Aug '22

19 Aug '22

On Thu Aug 18 07:09:33 2022 +0000, Zhiyi Zhang wrote: > Do not remove the id property. There should be a id="bitmap:width-depth" > property for the wine's build system to generate the bitmaps from SVGs. > Also, the commit subject is way too long. > And, for the WineHQ bugzilla link. We use the Wine-Bug: tag. OK, id properties have been kept, and have shortened the commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6523

1 0

Re: [PATCH v2 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 06:54:19 2022 +0000, Konstantin wrote: > @hans, thank you for comment. If I understand correct you are author of > original logic. > I am not sure. You sugesstion change existing logic. Originaly > `*mapped_context` and `expiry_to_timestamp( exptime, expiry );` executed > only when status is SEC_E_OK, and `new_context` modification > (independant) internaly in `create_context_handle`. > I can't check side effect of the proposed change. > If you sure that it correct I change condition to ` if > (status==SEC_E_OK||status==SEC_I_CONTINUE_NEEDED) ` What about SEC_I_COMPLETE_NEEDED and SEC_I_COMPLETE_AND_CONTINUE we need also put it to condition? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6521

1 0

Re: [PATCH v2 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Thu Aug 18 14:47:05 2022 +0000, Hans Leidekker wrote: > As I mentioned in the bug report, the new context is updated when > initialize_context() returns SEC_E_OK or SEC_I_CONTINUE_NEEDED. That > should be reflected here. @hans, thank you for comment. If I understand correct you are author of original logic. I am not sure. You sugesstion change existing logic. Originaly `*mapped_context` and `expiry_to_timestamp( exptime, expiry );` executed only when status is SEC_E_OK, and `new_context` modification (independant) internaly in `create_context_handle`. I can't check side effect of the proposed change. If you sure that it correct I change condition to ` if (status==SEC_E_OK||status==SEC_I_CONTINUE_NEEDED) ` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6520

1 0

2025

2024

2023

2022

wine-gitlab