- wine-gitlab - winehq.org

Re: [PATCH v2 0/5] MR635: Draft: Implement transform graph. Partically implement effect drawing.
by Nikolay Sivov (＠nsivov) 15 Aug '22

15 Aug '22

Node manipulation might be fine, I haven't checked it in full. However my impression was that we don't really need it right now? I believe I saw some examples where ID2D1DrawTransform is implemented for *Impl object directly, for which runtime presumably calls SetDrawInfo, letting effect set back shaders and resources. Regarding prototyped drawing, creating render target on every draw seems wrong. It's possible you'll have to recreate something, but only when when parameters or inputs have changed. I certainly don't have a full picture of how this works, but shouldn't we be using MapOutputRectToInputRects() at some point? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/635#note_6266

1 0

[PATCH v2 0/1] MR647: winex11.drv: Make last_cursor per-thread.
by Paul Gofman (＠gofman) 15 Aug '22

15 Aug '22

Cursor (both the cursor itself and its visibility) are per thread on Windows and Wine's implementation outside of winex11.drv seem to agree with that. Using global cursor variable in winex11.drv leads to wrong cursor being set or set visible for a window when the app sets a cursor from the other thread. -- v2: winex11.drv: Set correct cursor when setting cursor from another thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/647

2 2

Re: [PATCH v4 0/9] MR646: win32u: Window messages improvements and wow64 support. - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/646

1 0

Re: [PATCH v2 0/7] MR645: mfsrcsnk: Partially implement WAVE format sink. - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/645

1 0

Re: [PATCH v2 0/1] MR644: vkd3d: Fix the signature of vkd3d_spirv_build_op_type_image - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/644

1 0

Re: [PATCH v2 0/1] MR643: configure: Downgrade -Wincompatible-function-pointer-types to a warning on ARM - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/643

1 0

Re: [PATCH v2 0/2] MR642: msvcp: Fix _Fiopen implementation - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/642

1 0

Re: [PATCH v2 0/2] MR640: Hnetcfg fw rule - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/640

1 0

Re: [PATCH v2 0/2] MR638: wshom: Use signed type for properties ProcessID and ExitCode in IWshExec. - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/638

1 0

Re: [PATCH v2 0/1] MR639: bcrypt: Move symmetric flags check to symmetric section. - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/639

1 0

Re: [PATCH v5 0/6] MR581: d3d8, d3d9: More tests for dirty rects and UpdateTexture(). - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/581

1 0

Re: [PATCH v3 0/1] MR8: vkd3d-shader/spirv: Fix the signature of vkd3d_spirv_build_op_type_image - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/8

1 0

[PATCH 0/1] MR644: vkd3d: Fix the signature of vkd3d_spirv_build_op_type_image
by Martin Storsjö (＠mstorsjo) 15 Aug '22

15 Aug '22

Don't assume that enums and uint32_t parameters are identical. Clang 16 changes the diagonstic for incompatible function pointer types from a warning into an error by default. This fixes the following error, when built (for aarch64, but probably also for other architectures) in MSVC mode: ``` ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:1083:13: error: incompatible function pointer types passing 'uint32_t (struct vkd3d_spirv_builder *, uint32_t, SpvDim, uint32_t, uint32_t, uint32_t, uint32_t, SpvImageFormat)' (aka 'unsigned int (struct vkd3d_spirv_builder *, unsigned int, enum SpvDim_, unsigned int, unsigned int, unsigned int, unsigned int, enum SpvImageFormat_)') to parameter of type 'vkd3d_spirv_build7_pfn' (aka 'unsigned int (*)(struct vkd3d_spirv_builder *, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int)') [-Wincompatible-function-pointer-types] vkd3d_spirv_build_op_type_image); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:612:68: note: passing argument to parameter 'build_pfn' here SpvOp op, const uint32_t *operands, vkd3d_spirv_build7_pfn build_pfn) ^ ``` This backports https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/8 to the bundled copy in wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/644

3 2

[PATCH 0/1] MR647: winex11.drv: Make last_cursor per-thread.
by Paul Gofman (＠gofman) 15 Aug '22

15 Aug '22

Cursor (both the cursor itself and its visibility) are per thread on Windows and Wine's implementation outside of winex11.drv seem to agree with that. Using global cursor variable in winex11.drv leads to wrong cursor being set or set visible for a window when the app sets a cursor from the other thread. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/647

3 2

[PATCH v4 0/3] MR574: mf: Improve session pause / restart handling.
by Paul Gofman (＠gofman) 15 Aug '22

15 Aug '22

Patch 1. The tests on Windows show that when the timer callback is queued behind the clock time it is queued and executed quite soon with 0-15ms delay which corresponds to default timer granularity. The timeout tolerance in the test is quite bigger to avoid a flaky test. Wine currently may execute the callback right away or delay it indefinitely depending on the time difference and current system time. Patch 2. It turns out when the session is paused and then restarted and all the samples were delivered to sample grabber before restart, nothing is going to request the samples again when the session is restarted. I am attaching a test in a patch which hopefully confirms how that should work. I am not including that in the patches as the test involves delays (to make sure all the async events settle at certain points) and inherently flaky. Also, _ IMFStreamSink_GetEvent(stream, ...) in the test crashes on Win7 for some unknown reason. [0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch](/uploads/58c1738d48b3392e7ec430a0757210d0/0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch) -- v4: mf/samplegrabber: Handle samples receieved in paused state. mf/samplegrabber: Process samples in paused state in ignore_clock mode. mf: Handle timer time behind clock time in present_clock_schedule_timer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/574

2 4

[PATCH v3 0/9] MR646: win32u: Window messages improvements and wow64 support.
by Jacek Caban (＠jacek) 15 Aug '22

15 Aug '22

Instead of leaking kernel pointers. -- v3: user32: Always use original parameter values in dispatch_send_message. wow64win: Implement wow64_NtUserMessageCall. wow64win: Implement wow64_NtUserCallWinProc. https://gitlab.winehq.org/wine/wine/-/merge_requests/646

3 11

[PATCH v2 0/9] MR646: win32u: Window messages improvements and wow64 support.
by Jacek Caban (＠jacek) 15 Aug '22

15 Aug '22

Instead of leaking kernel pointers. -- v2: user32: Always use original parameter values in dispatch_send_message. wow64win: Implement wow64_NtUserMessageCall. wow64win: Implement wow64_NtUserCallWinProc. win32u: Remove no longer needed unicode call_hooks argument. win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE. user32: Pass window name as UNICODE_STRING to NtUserCreateWindowEx. win32u: Pack messages sent directly from win32u. https://gitlab.winehq.org/wine/wine/-/merge_requests/646

2 10

[PATCH 0/9] MR646: win32u: Window messages improvements and wow64 support.
by Jacek Caban (＠jacek) 15 Aug '22

15 Aug '22

Instead of leaking kernel pointers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/646

3 13

[PATCH v7 0/6] MR576: win32u: Move display placement logic out of graphics drivers.
by Rémi Bernon (＠rbernon) 15 Aug '22

15 Aug '22

In preparation for nulldrv display modes support. -- v7: win32u: Move display placement logic out of graphics drivers. win32u: Move full display mode lookup out of graphics drivers. win32u: Use current mode position if desired mode doesn't specify it. win32u: Always copy devmode in validate_display_settings. win32u: Read registry or current mode when validation needs it. win32u: Do not keep display modes driver extra in the registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/576

3 9

[PATCH 0/7] MR645: mfsrcsnk: Partially implement WAVE format sink.
by Nikolay Sivov (＠nsivov) 15 Aug '22

15 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/645

2 7

[PATCH 0/1] MR643: configure: Downgrade -Wincompatible-function-pointer-types to a warning on ARM
by Martin Storsjö (＠mstorsjo) 15 Aug '22

15 Aug '22

Clang 16 is defaulting -Wincompatible-function-pointer-types to an error instead of a warning. This isn't an issue for most of Wine, but the error shows up in a lot of cases if doing a non-PE build for ARM (32 bit, 64 has no such issues), in particular around the integration of libxml2 and faudio. The root cause of the issue is that some functions are specified with e.g. __attribute__((pcs("aapcs-vfp"))) - which is equal to the default calling convention when compiling with -mfloat-abi=hard - but Clang's warning doesn't treat such function pointers as equal. (This could maybe be considered a bug or limitation in Clang though.) There's also some smaller amount of cases where our attributes actually do conflict, where we mix __attribute__((pcs("aapcs"))), i.e. arm softfloat calling convention, with the default calling convention (which is set to hardfloat), but they drown in the noise from the other ones. Therefore, on arm, try to downgrade this diagnostic back to a warning, not an error - while keeping the warnings visible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/643

2 1

[PATCH 0/2] MR642: msvcp: Fix _Fiopen implementation
by Piotr Caban (＠piotr) 15 Aug '22

15 Aug '22

Based on a patch by Yeshun Ye. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/642

2 2

[PATCH v2 0/1] MR8: vkd3d-shader/spirv: Fix the signature of vkd3d_spirv_build_op_type_image
by Martin Storsjö (＠mstorsjo) 15 Aug '22

15 Aug '22

Don't assume that enums and uint32_t parameters are identical. Clang 16 changes the diagonstic for incompatible function pointer types from a warning into an error by default. This fixes the following error, when built (for aarch64, but probably also for other architectures) in MSVC mode: ``` ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:1083:13: error: incompatible function pointer types passing 'uint32_t (struct vkd3d_spirv_builder *, uint32_t, SpvDim, uint32_t, uint32_t, uint32_t, uint32_t, SpvImageFormat)' (aka 'unsigned int (struct vkd3d_spirv_builder *, unsigned int, enum SpvDim_, unsigned int, unsigned int, unsigned int, unsigned int, enum SpvImageFormat_)') to parameter of type 'vkd3d_spirv_build7_pfn' (aka 'unsigned int (*)(struct vkd3d_spirv_builder *, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int)') [-Wincompatible-function-pointer-types] vkd3d_spirv_build_op_type_image); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:612:68: note: passing argument to parameter 'build_pfn' here SpvOp op, const uint32_t *operands, vkd3d_spirv_build7_pfn build_pfn) ^ ``` -- v2: vkd3d-shader/spirv: Fix the signature of vkd3d_spirv_build_op_type_image https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/8

3 2

[PATCH 0/1] MR8: vkd3d-shader/spirv: Fix the signature of vkd3d_spirv_build_op_type_image
by Martin Storsjö (＠mstorsjo) 15 Aug '22

15 Aug '22

Don't assume that enums and uint32_t parameters are identical. Clang 16 changes the diagonstic for incompatible function pointer types from a warning into an error by default. This fixes the following error, when built (for aarch64, but probably also for other architectures) in MSVC mode: ``` ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:1083:13: error: incompatible function pointer types passing 'uint32_t (struct vkd3d_spirv_builder *, uint32_t, SpvDim, uint32_t, uint32_t, uint32_t, uint32_t, SpvImageFormat)' (aka 'unsigned int (struct vkd3d_spirv_builder *, unsigned int, enum SpvDim_, unsigned int, unsigned int, unsigned int, unsigned int, enum SpvImageFormat_)') to parameter of type 'vkd3d_spirv_build7_pfn' (aka 'unsigned int (*)(struct vkd3d_spirv_builder *, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int)') [-Wincompatible-function-pointer-types] vkd3d_spirv_build_op_type_image); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:612:68: note: passing argument to parameter 'build_pfn' here SpvOp op, const uint32_t *operands, vkd3d_spirv_build7_pfn build_pfn) ^ ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/8

2 1

[PATCH 0/2] MR640: Hnetcfg fw rule
by Hans Leidekker (＠hans) 15 Aug '22

15 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/640

2 2

2025

2024

2023

2022

wine-gitlab