- wine-gitlab - winehq.org

Re: [PATCH v2 0/4] MR7468: win32u: Move opengl code to a dedicated source.
by Rémi Bernon (＠rbernon) 03 Mar '25

03 Mar '25

v2: Fix macos build (hopefully). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7468#note_96590

1 0

Re: [PATCH v2 0/4] MR7468: win32u: Move opengl code to a dedicated source.
by Rémi Bernon (＠rbernon) 03 Mar '25

03 Mar '25

On Mon Mar 3 16:27:36 2025 +0000, Aida Jonikienė wrote: > Will the move include pbuffer handling too? As much as can be factored together. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7468#note_96588

1 0

[PATCH v3 0/6] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Vibhav Pant (＠vibhavp) 03 Mar '25

03 Mar '25

-- v3: bluetoothapis/tests: Add tests for BluetoothFindNextDevice. https://gitlab.winehq.org/wine/wine/-/merge_requests/7472

2 6

[PATCH 0/6] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Vibhav Pant (＠vibhavp) 03 Mar '25

03 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7472

2 6

[PATCH 0/5] MR7470: include: Add more declarations needed for LLVM libc++
by Jacek Caban (＠jacek) 03 Mar '25

03 Mar '25

Based on @rbernon's [branch](https://gitlab.winehq.org/rbernon/wine/-/tree/wip/libc++-fixes). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7470

4 8

[PATCH 0/4] MR7468: win32u: Move opengl code to a dedicated source.
by Rémi Bernon (＠rbernon) 03 Mar '25

03 Mar '25

The plan is to move as much GL code as possible to win32u, similarly to what's been done with vulkan. While I intend to keep the existing driver-specific GL backend (GLX, macos?), I win32u can use EGL more directly while delegating only the platform specific display and surface creation to the drivers. At the same time, it could also make it possible to use EGL for memory DCs too, as osmesa is being removed from Mesa3D main branch (still going to be present in a separate historical branch iiuc). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7468

3 5

[PATCH 0/1] MR7471: d2d1/tests: Add broken to silence a few float comparisons in windows 7.
by Bernhard Übelacker (＠bernhardu) 03 Mar '25

03 Mar '25

Test d2d1:d2d1 shows a systematic failure with the windows 7 systems: https://test.winehq.org/data/patterns.html#d2d1:d2d1 This patch adds broken statements with a little less strict float comparisons. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7471

3 2

[PATCH v2 0/1] MR7469: winegcc: Don't include host include paths when compiling with MSVCRT.
by Jacek Caban (＠jacek) 03 Mar '25

03 Mar '25

While some host includes may work, we can't assume they will. Additionally, they may interfere with the code being built. In my case, LLVM's libc++ build with winegcc was failing due to an [unexpected `__has_include`](https://github.com/llvm/llvm-project/blob/44607666b3429868bce9f0489715eb367d0e08f8/libcxx/include/__mbstate_t.h#L42). -- v2: winegcc: Don't include host include paths when compiling with MSVCRT. https://gitlab.winehq.org/wine/wine/-/merge_requests/7469

2 2

[PATCH 0/1] MR7469: winegcc: Don't include host include paths when compiling with MSVCRT.
by Jacek Caban (＠jacek) 03 Mar '25

03 Mar '25

While some host includes may work, we can't assume they will. Additionally, they may interfere with the code being built. In my case, LLVM's libc++ build with winegcc was failing due to an [unexpected `__has_include`](https://github.com/llvm/llvm-project/blob/44607666b3429868bce9f0489715eb367d0e08f8/libcxx/include/__mbstate_t.h#L42). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7469

3 2

[PATCH v3 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Dmitry Timoshkov (＠dmitry) 03 Mar '25

03 Mar '25

-- v3: windowscodecs: Make support for WICBitmapTransformRotate270 more explicit. https://gitlab.winehq.org/wine/wine/-/merge_requests/7459

3 3

[PATCH v3 0/10] MR7407: windowscodecs: Implement query strings enumerator.
by Nikolay Sivov (＠nsivov) 03 Mar '25

03 Mar '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: windowscodecs: Implement GetPreferredVendorGUID(). windowscodecs/metadata: Implement GetClassID(). windowscodecs/tests: Add some tests for metadata handler GetClassID(). windowscodecs/metadata: Replicate original stream position when creating writer instances from readers. windowscodecs/metadata: Restore original stream position on GetStream(). windowscodecs/tests: Add some tests for stream position handling when nested readers are used. https://gitlab.winehq.org/wine/wine/-/merge_requests/7407

2 10

Re: [PATCH v2 0/1] MR6805: winewayland: Fix surface scaling with HiDPI compositor.
by 小亨 (＠laichiaheng) 03 Mar '25

03 Mar '25

The icons and texts are too tiny in KDE Plasma 6 with 100% scaling on my 4K monitor, so I adjust it to 200%, and the window of my game just becomes 2x bigger, much bigger than my monitor. This doesn't make any sense! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6805#note_96557

1 0

[PATCH v3 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Bernhard Übelacker (＠bernhardu) 03 Mar '25

03 Mar '25

Tests show test propsys:propsys is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#propsys:propsys It looks like windows 7 processes VT_R4 like VT_R8. (`0.125f / 0x3e000000 (float/4 byte)` becomes `5.1392085562440189e-315 / 0x3e000000 (double/8 byte)`. Is this worth the effort to remove the failures from the test patterns page? -- v3: propsys/tests: Add broken for unexpected value in windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7460

2 3

[PATCH 0/1] MR7467: kernel32/tests: Work around Windows 7 issuing DllNotification even when loading with DONT_RESOLVE_DLL_REFERENCES
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

Testbot result: https://testbot.winehq.org/JobDetails.pl?Key=151596 Fixes: 99e91f1c0fcb840b4840a4a3c2b079bad817b100 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57903 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7467

3 2

[PATCH v2 0/1] MR7451: dlls/shell32: Fix IUnknown::QueryInterface() to meet spec
by Edward OC (＠funfunctor) 03 Mar '25

03 Mar '25

The spec says if the passed pointer is NULL then return E_POINTER and not to just unconditionally deref then set NULL. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v2: dlls/shell32: Fix IUnknown::QueryInterface() to meet spec https://gitlab.winehq.org/wine/wine/-/merge_requests/7451

4 12

[PATCH v2 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Bernhard Übelacker (＠bernhardu) 03 Mar '25

03 Mar '25

Tests show test propsys:propsys is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#propsys:propsys It looks like windows 7 processes VT_R4 like VT_R8. (`0.125f / 0x3e000000 (float/4 byte)` becomes `5.1392085562440189e-315 / 0x3e000000 (double/8 byte)`. Is this worth the effort to remove the failures from the test patterns page? -- v2: propsys/tests: Add broken for unexpected value in windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7460

3 4

Re: [PATCH v26 0/1] MR6884: Iphlpapi.dll: Included SendARP
by Huw Davies (＠huw) 03 Mar '25

03 Mar '25

It would be better to implement `SendARP()` in terms of `ResolveIpNetEntry2()`. Further, `ResolveIpNetEntry2()` should likely use the `Nsi` functions to retrieve the neighbour info from `nsiproxy`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6884#note_96536

1 0

[PATCH v4 0/6] MR7250: ntdll: Properly implement NtFlushProcessWriteBuffers (try 2).
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

Supersedes !741. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_PRIVATE_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms it falls back to calling `NtGetContextThread()` on each thread. The fast path patches from @tmatthies are slightly modified in the following ways: 1. On unsupported platforms, the `try_*()` functions return `FALSE` instead of `0`. 2. `try_exp_membarrier()` is called first, then `try_mach_tgrpvs()`. --- Known applications fixed by this MR: - osu! (rhythm game) song selection menu stuttering - .NET CoreCLR GC - HotSpot JVM (-XX:+UseSystemMemoryBarrier) safepoints -- v4: kernel32/tests: Add a store buffering litmus test involving FlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/7250

3 8

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

On Mon Mar 3 11:04:01 2025 +0000, Jinoh Kang wrote: > My two cents: > This PR is a no-op change except for the test. While this PR improves > readability a little, I guess we could go further and handle flip > horz/vert flags in a more readable way if we want to go that direction? > (Otherwise just keeping the test should be fine too.) In any case, the commit message is misleading and should be reworded on commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96526

1 0

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

On Mon Mar 3 08:08:34 2025 +0000, Dmitry Timoshkov wrote: > It looks like you are right, new tests actually pass with current > implementation. Although the patch makes support for > WICBitmapTransformRotate270 more explicit I'm not opposed to leave the > code intact. I'm open to suggestions. My two cents: This PR is a no-op change except for the test. While this PR improves readability a little, I guess we could go further and handle flip horz/vert flags in a more readable way if we want to go that direction? (Otherwise just keeping the test should be fine too.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96525

1 0

[PATCH v5 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v5: winedmo: Call avformat_find_stream_info for the mp3 format. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 3

[PATCH v4 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v4: winedmo: Call avformat_find_stream_info for the mp3 format. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 2

Re: [PATCH v3 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

Brendan McGrath (@redmcg) commented about dlls/winedmo/unix_demuxer.c: > } > format = demuxer->ctx->iformat; > > - if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE) > + if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE || > + strstr( format->name, "mp3")) > { > if ((ret = avformat_find_stream_info( demuxer->ctx, NULL )) < 0) > { > ERR( "Failed to find stream info, error %s.\n", debugstr_averr(ret) ); > goto failed; > } > - params->duration = get_context_duration( demuxer->ctx ); > + if (params->duration == AV_NOPTS_VALUE) > + params->duration = get_context_duration( demuxer->ctx ); @rbernon I wasn't sure how harmless/harmful this assignment was, so I added a check just in case. If you think it's unnecessary I'll remove. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7439#note_96517

1 0

[PATCH v2 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v2: winedmo: Find mp3 stream info if channel data is missing. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 5

[PATCH v9 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Yuxuan Shui (＠yshui) 03 Mar '25

03 Mar '25

## Context This is a problem discovered when running "Max: The Curse of Brotherhood" under proton. This game writes 4MB a piece into `wg_transform`, which contains about 4 seconds of compressed video. `wg_transform` calls `gst_pad_push` in `transform_ProcessOutput`, which takes \~300ms (i.e. 20 frames @ 60fps) to decode this buffer of video. So the end result is the game hitches every 4 seconds while playing cut scene videos. Proton currently has a special case for this particular game, for which it breaks up the buffer into small chunks to avoid long blocks. This MR adopts that and applies it generally. One concern raised by @redmcg is: > The only issue I can think of is if there are any decoders which don't have a parser; then they might not know how to deal with an arbitrary 4096 byte buffer (the parser is generally responsible for taking arbitrary buffers and producing something the decoder can work with, for example: a full frame). So this MR only enables this strategy when there is a parser element. -- v9: winegstreamer: Avoid large buffer pushes in wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/7288

3 4

2025

2024

2023

2022

wine-gitlab