- wine-gitlab - winehq.org

Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Huw Davies (＠huw) 08 Aug '22

08 Aug '22

On Mon Aug 8 14:11:55 2022 +0000, Francois Gouget wrote: > Ah, right. Well, there is a `memset( &ip_h, 0, sizeof(ip_h) );` earlier on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5818

2 1

Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Francois Gouget (＠fgouget) 08 Aug '22

08 Aug '22

On Mon Aug 8 13:20:50 2022 +0000, **** wrote: > Paul Gofman replied on the mailing list: > ``` > > On 8 Aug 2022, at 02:56, Francois Gouget (@fgouget) > <wine(a)gitlab.winehq.org> wrote: > > > > ��Francois Gouget (@fgouget) commented about dlls/ntdll/unix/socket.c: > >> + req->icmp_seq = icmp_h->un.echo.sequence; > >> + if (!(fixup_status = wine_server_call( req ))) > >> + icmp_h->un.echo.id = reply->icmp_id; > >> + else > >> + WARN( "socket_get_fixup_data returned %#x.\n", > fixup_status ); > >> + } > >> + SERVER_END_REQ; > >> + > >> + if (!fixup_status) > >> + { > >> + icmp_h->checksum = 0; > >> + icmp_h->checksum = chksum( (BYTE *)icmp_h, recv_len - > sizeof(ip_h) ); > >> + } > >> + } > >> + ip_h.checksum = 0; > >> + ip_h.checksum = chksum( (BYTE *)&ip_h, sizeof(ip_h) ); > > Isn't the first assignment redundant? > > > No, it isn��t. checksum field is not excluded anyhow else from checksum > calculation and should be 0 for correct result. > > -- > > https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5796 > > _______________________________________________ > > wine-gitlab mailing list -- wine-gitlab(a)winehq.org > > To unsubscribe send an email to wine-gitlab-leave(a)winehq.org > _______________________________________________ > wine-gitlab mailing list -- wine-gitlab(a)winehq.org > To unsubscribe send an email to wine-gitlab-leave(a)winehq.org > ``` Ah, right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5817

1 0

Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Francois Gouget (＠fgouget) 08 Aug '22

08 Aug '22

Francois Gouget (@fgouget) commented about dlls/ntdll/unix/socket.c: > + req->icmp_seq = icmp_h->un.echo.sequence; > + if (!(fixup_status = wine_server_call( req ))) > + icmp_h->un.echo.id = reply->icmp_id; > + else > + WARN( "socket_get_fixup_data returned %#x.\n", fixup_status ); > + } > + SERVER_END_REQ; > + > + if (!fixup_status) > + { > + icmp_h->checksum = 0; > + icmp_h->checksum = chksum( (BYTE *)icmp_h, recv_len - sizeof(ip_h) ); > + } > + } > + ip_h.checksum = 0; > + ip_h.checksum = chksum( (BYTE *)&ip_h, sizeof(ip_h) ); Isn't the first assignment redundant? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5796

2 1

[PATCH 0/4] MR2: tests: Test float4 UAV buffer load/store.
by Conor McCarthy (＠cmccarthy) 08 Aug '22

08 Aug '22

This currently fails if the shader loads from the UAV, because it causes vkd3d-shader to specify the R32f format instead of Unknown. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/2

4 8

[PATCH 0/8] MR604: user32: Don't include ntuser_private.h.
by Jacek Caban (＠jacek) 08 Aug '22

08 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/604

3 9

[PATCH v8 0/5] MR140: qasf: More ASF reader filter implementation.
by Rémi Bernon (＠rbernon) 08 Aug '22

08 Aug '22

-- v8: qasf: Implement ASF Reader filter pin DecideBufferSize. qasf: Implement ASF Reader filter pin_get_media_type. qasf: Implement ASF Reader filter pin_query_accept. winegstreamer: Implement IWMOutputMediaProps_SetMediaType. wmvcore/tests: Add some IWMOutputMediaProps_SetMediaType tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/140

2 6

[PATCH v7 0/5] MR140: qasf: More ASF reader filter implementation.
by Rémi Bernon (＠rbernon) 08 Aug '22

08 Aug '22

-- v7: qasf: Implement ASF Reader filter pin DecideBufferSize. qasf: Implement ASF Reader filter pin_get_media_type. qasf: Implement ASF Reader filter pin_query_accept. winegstreamer: Implement IWMOutputMediaProps_SetMediaType. wmvcore/tests: Add some IWMOutputMediaProps_SetMediaType tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/140

3 7

Re: [PATCH v2 0/1] MR598: secur32: Define AES-CCM ciphers missing from GNUTLS before 3.4.0. - approved
by Hans Leidekker (＠hans) 08 Aug '22

08 Aug '22

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/598

1 0

[PATCH 0/1] MR4: vkd3d: Remove unused field fence_destruction_cond.
by Giovanni Mascellani (＠giomasce) 08 Aug '22

08 Aug '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/4

3 2

[PATCH v2 0/1] MR3: vkd3d: Unlock fence worker mutex before exiting.
by Giovanni Mascellani (＠giomasce) 08 Aug '22

08 Aug '22

Pthread mandates that a mutex must be unlocker before being destroyed. In pratice I doubt this make a difference on any platform (certainly it doesn't on Linux), but let's comply to standards. -- v2: vkd3d: Unlock fence worker mutex before exiting. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/3

3 2

[PATCH v4 0/6] MR589: winemac: wineandroid: Display settings code cleanup.
by Rémi Bernon (＠rbernon) 08 Aug '22

08 Aug '22

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/576 which is getting long and needs some fixing. -- v4: winemac.drv: Avoid setting DM_POSITION on enumerated modes. wineandroid.drv: Add missing DM_DISPLAYORIENTATION | DM_POSITION flags. win32u: Split EnumDisplaySettingsEx into CurrentDisplaySettings entry. wineandroid.drv: Return early on EnumDisplaySettingsEx error. winemac.drv: Split best display mode lookup to a separate helper. win32u: Ignore DM_POSITION mode fields for available modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/589

3 7

[PATCH v2 0/1] MR600: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi
by Davide Beatrici (＠davidebeatrici) 08 Aug '22

08 Aug '22

This is the very first step for merging the `mmdevdrv.c` files into a single one. The commit strictly focuses on Linux drivers, `wine{oss,coreaudio}` will follow. Huge thanks to @jacek and @huw for making this simple, as they took care of ELF/PE separation. -- v2: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi https://gitlab.winehq.org/wine/wine/-/merge_requests/600

3 4

[PATCH v3 0/6] MR589: winemac: wineandroid: Display settings code cleanup.
by Rémi Bernon (＠rbernon) 08 Aug '22

08 Aug '22

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/576 which is getting long and needs some fixing. -- v3: winemac.drv: Avoid setting DM_POSITION on enumerated modes. wineandroid.drv: Add missing DM_DISPLAYORIENTATION | DM_POSITION flags. win32u: Split EnumDisplaySettingsEx into CurrentDisplaySettings entry. wineandroid.drv: Return early on EnumDisplaySettingsEx error. winemac.drv: Split best display mode lookup to a separate helper. win32u: Ignore DM_POSITION mode fields for available modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/589

4 8

[PATCH v2 0/6] MR589: winemac: wineandroid: Display settings code cleanup.
by Rémi Bernon (＠rbernon) 08 Aug '22

08 Aug '22

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/576 which is getting long and needs some fixing. -- v2: winemac.drv: Avoid setting DM_POSITION on enumerated modes. wineandroid.drv: Add missing DM_DISPLAYORIENTATION | DM_POSITION flags. win32u: Split EnumDisplaySettingsEx into CurrentDisplaySettings entry. wineandroid.drv: Return early on EnumDisplaySettingsEx error. winemac.drv: Split best display mode lookup to a separate helper. win32u: Ignore DM_POSITION mode fields for available modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/589

3 7

[PATCH v7 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) 08 Aug '22

08 Aug '22

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- v7: comctl32/tests: Add more ownerdata listview tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 8

[PATCH 0/1] MR602: ntdll: Also initialize icmp_over_dgram in sock_read().
by Paul Gofman (＠gofman) 07 Aug '22

07 Aug '22

Fixes a regression introduced by commit 1e35966eb57db7060d0c459bc7aaac2f6cad7442. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52429 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/602

2 1

[PATCH 0/1] MR600: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi
by Davide Beatrici (＠davidebeatrici) 07 Aug '22

07 Aug '22

This is the very first step for merging the `mmdevdrv.c` files into a single one. The commit strictly focuses on Linux drivers, `wine{oss,coreaudio}` will follow. Huge thanks to @jacek and @huw for making this simple, as they took care of ELF/PE separation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/600

2 2

[PATCH 0/6] MR575: mf: Use the Video Processor transform for video conversion.
by Rémi Bernon (＠rbernon) 06 Aug '22

06 Aug '22

This should fix the Color Converter transform regression, which cannot actually be used by the topology loader in some cases because it exposes DMO-specific RGB media types. The Video Processor must be used instead (and it has its own quirks). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/575

4 8

[PATCH 0/2] MR574: mf: Improve session pause / restart handling.
by Paul Gofman (＠gofman) 06 Aug '22

06 Aug '22

Patch 1. The tests on Windows show that when the timer callback is queued behind the clock time it is queued and executed quite soon with 0-15ms delay which corresponds to default timer granularity. The timeout tolerance in the test is quite bigger to avoid a flaky test. Wine currently may execute the callback right away or delay it indefinitely depending on the time difference and current system time. Patch 2. It turns out when the session is paused and then restarted and all the samples were delivered to sample grabber before restart, nothing is going to request the samples again when the session is restarted. I am attaching a test in a patch which hopefully confirms how that should work. I am not including that in the patches as the test involves delays (to make sure all the async events settle at certain points) and inherently flaky. Also, _ IMFStreamSink_GetEvent(stream, ...) in the test crashes on Win7 for some unknown reason. [0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch](/uploads/58c1738d48b3392e7ec430a0757210d0/0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/574

3 3

[PATCH v3 0/4] MR596: win32u: Send the total number of registered devices to the server.
by Rémi Bernon (＠rbernon) 06 Aug '22

06 Aug '22

-- v3: win32u: Avoid invalid access when registered device alloc failed. (Coverity) win32u: Send the total number of registered devices to the server. win32u: Avoid reallocating rawinput device array with zero size. server: Avoid reallocating rawinput device array with zero size. https://gitlab.winehq.org/wine/wine/-/merge_requests/596

2 5

Re: [PATCH v3 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) 06 Aug '22

06 Aug '22

On Wed Aug 3 14:09:24 2022 +0000, Akihiro Sagawa wrote: > Got it. Good tip. It turns out that SM_CXMIN is used only when creating an overlapped window. In other words, if a user supplies WS_CHILD or WS_POPUP style, CreateWindow won't adjust the window width to SM_CXMIN. Nevertheless, I'll squash two patches into one to avoid regressions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/557#note_5762

1 0

[PATCH 0/1] MR599: wow64cpu: Use -norelay for BTCpuSimulate.
by Brendan Shanks (＠bshanks) 05 Aug '22

05 Aug '22

With +relay enabled under Wow64, stack unwinding during exception handling was failing when it encountered a frame in the Wow stack. This commit fixes the issue, but I'm not sure if it's correct or if something needs to be fixed in unwinding. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/599

2 1

[PATCH 0/2] MR597: dwrite/fallback: Make sure all consecutively mapped characters belong to the same mapping.
by Nikolay Sivov (＠nsivov) 05 Aug '22

05 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/597

2 2

[PATCH v21 0/110] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens (＠tobi.goergens) 05 Aug '22

05 Aug '22

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- v21: gitlab: Disable building image in forks. gitlab: Build every commit in a merge request. gitlab: Move build steps to the build-all script. include: Add coclass SpMMAudioEnum. sapi: Add AudioInput registry key. webservices: Add support for receiving fault messages. webservices: Address the request message in WsCall. webservices/tests: Add a fault reading test for WsReadBody. webservices: Fill in type description for WS_FAULT_TYPE if necessary in WsReadBody. webservices: Detect when a message contains a fault in read_envelope_start. webservices: Add support for reading WS_FAULT values. winhttp: Avoid invalid memory access in netconn_resolve(). d2d1/commandlist: Implement FillOpacityMask() command. d2d1: Add parameter validation to FillOpacityMask(). user32: Remove USER_CheckNotLock. win32u: Introduce NtUserGetChildRect. user32: Use GetClientRect in EDIT_WM_ContextMenu. user32: Use win32u to get and set MDI client info. user32: Store MDI client info on client heap. win32u: Introduce NtUserGetWindowSysSubMenu. dwrite: Add ff00-ffef range to the fallback configuration. xactengine3_7: Return error on invalid notification value. xactengine3_7: Implement callback for supported messages. xactengine3_7: Record context for each notications. xactengine3_7: Map IXACT3Wave interfaces. xactengine3_7: Map IXACT3Cue interfaces. xactengine3_7: Map SoundBank interfaces. xactengine3_7: Add helper function to add entries. d2d1: Remove warning message for glyph run description. d2d1/commandlist: Fix primitive blend playback. d2d1: Implement setting primitive blend mode. include: Add newer D2D command sink interface definitions. winevulkan: Update to VK spec version 1.3.224. bcrypt: Add AES CFB chaining mode support. winebus.sys/sdl: Use the 8 absolute axes supported by DIJOYSTATE2. winegstreamer: Make IWMReader state transitions asynchronous. winegstreamer: Leave the stream CS while waiting for a sample. winegstreamer: Move IWMReaderCallbackAdvanced *callback_advanced to a local variable. wmvcore/tests: Add more IWMReader_(Open|Start|Stop|Close) async checks. include: Add UI Automation COM client interface definitions. include: Add UI Automation Event ID definitions. ntdll: Fix floating point and extended registers not being restored under Wow64. wow64: Copy floating point and extended registers in copy_context_64to32. tiff: Import upstream release 4.4.0. mpg123: Import upstream release 1.30.2. faudio: Import upstream release 22.08. dwrite: Fix stretch value validation in CreateTextFormat(). ncrypt: Initial implementation for NCryptEncrypt. bcrypt: Initial RSA encryption implementation. bcrypt/tests: Test for BCryptEncrypt with RSA keys. ncrypt/tests: Test for NCryptEncrypt with RSA and PKCS1 padding. webservices: Support faults in error. webservices: Implement error strings. d2d1/commandlist: Update text rendering params on DrawGlyphRun(). d2d1: Add a helper for DrawGlyphRun(). d2d1/commandlist: Implement FillMesh() command. d2d1/commandlist: Implement DrawBitmap() command. d2d1/commandlist: Implement DrawGlyphRun() command. d2d1/commandlist: Handle recording in RestoreDrawingState(). d2d1/commandlist: Implement SetTextRenderingParams() command. d2d1/commandlist: Implement FillRectangle() command. d2d1/commandlist: Implement FillGeometry() command. d2d1/commandlist: Implement DrawRectangle() command. d2d1/commandlist: Implement DrawGeometry() command. d2d1/commandlist: Implement DrawLine() command. d2d1/commandlist: Implement Clear() command. d2d1/commandlist: Implement clipping commands recording. d2d1/commandlist: Implement basic state recording commands. include: Fix ID2D1CommandSink definition. d2d1: Allow setting command list as a target. d2d1: Add a command list object stub. d2d1/tests: Use test context for command list test. webservices: Write the correct headers when a request message is addressed. webservices: Handle in/out parameters properly in WsCall. include: Print "test succeeded" messages in colour. include: Print "test skipped" messages in colour. include: Print "test marked todo" messages in colour. include: Print "succeeded inside todo block" messages in colour. include: Allow printing test failure messages in bright red. ntdll/tests: Add a bunch of tests for creating kernel objects with the names containing '\0'. ntdll/tests: Fix compilation with PSDK. wined3d: Build the device list only once in wined3d_output_find_closest_matching_mode(). dxgi: Build the device list only once in dxgi_output_get_display_mode_list(). d3d8: Cache the output mode list. d3d9: Cache the output mode list. wined3d: Build a list of wined3d_display_mode structures in wined3d_output_get_mode[_count](). wined3d: Factor out mode_matches_filter(). ntdll: Use correct mcontext struct on macOS under Wow64. ddraw/tests: Add some video memory accounting tests. ddraw: Don't account video memory for sysmem surfaces' draw textures. winex11.drv: Constify set_current_mode DEVMODEW parameter. winex11.drv: Iterate display settings using dmDriverExtra. winex11.drv: Use DEVMODEW instead of x11drv_display_setting. winex11.drv: Update devmode dmPosition instead of new_rect. winex11.drv: Use DM_POSITION field bit to mark placed displays. winex11.drv: Use a local desired_rect variable when placing displays. mshtml: Implement MediaQueryList's matches prop. mshtml: Implement MediaQueryList's media prop. mshtml: Implement window.matchMedia() with MediaQueryList stub. user32: Forward more scroll bar messages to win32u. winegstreamer: Use the correct name for WMADecMediaObject DMO. mf: Increase min_buffer_size to MF_MT_AUDIO_AVG_BYTES_PER_SECOND. mf: Implement SAR media type required attributes checks. winegstreamer: Set the MF_MT_AUDIO_AVG_BYTES_PER_SECOND attribute. mf: Return MF_E_NO_MORE_TYPE from AudioRenderer GetMediaTypeByIndex. mf/tests: Add required SAR media type attributes tests. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/564

1 0

[PATCH v20 0/4] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens (＠tobi.goergens) 05 Aug '22

05 Aug '22

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- v20: cabinet/tests: add test for GetDllVersion https://gitlab.winehq.org/wine/wine/-/merge_requests/564

4 11

2025

2024

2023

2022

wine-gitlab