- wine-gitlab - winehq.org

[PATCH 0/3] MR587: d2d: Handle primitive blend correctly in command list playback.
by Nikolay Sivov (＠nsivov) 04 Aug '22

04 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/587

2 3

Re: [PATCH v4 0/11] MR576: win32u: Move display placement logic out of graphics drivers.
by Rémi Bernon (＠rbernon) 04 Aug '22

04 Aug '22

I figured that it currently doesn't pass the tests, I'll fix it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/576#note_5660

1 0

[PATCH 0/1] MR586: winevulkan: Update to VK spec version 1.3.224.
by Georg Lehmann (＠DadSchoorse) 04 Aug '22

04 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/586

2 1

[PATCH 0/7] MR576: win32u: Move display placement logic out of graphics drivers.
by Rémi Bernon (＠rbernon) 04 Aug '22

04 Aug '22

In preparation for nulldrv display modes support. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/576

3 27

[PATCH 0/7] MR583: webservices: Add support for receiving and reading fault messages.
by Shaun Ren (＠shaunren) 04 Aug '22

04 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/583

3 11

[PATCH v8 0/2] MR419: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Giovanni Mascellani (＠giomasce) 04 Aug '22

04 Aug '22

-- v8: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. user32/tests: Check that message-only windows ignore WS_EX_TOPMOST. https://gitlab.winehq.org/wine/wine/-/merge_requests/419

2 2

[PATCH v4 0/7] MR536: xactengine3_7: Add helper function to add entries
by Alistair Leslie-Hughes (＠alesliehughes) 04 Aug '22

04 Aug '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v4: xactengine3_7: Return error on invalid notification value. xactengine3_7: Implement callback for supported messages xactengine3_7: Record context for each notications xactengine3_7: Map IXACT3Wave interfaces xactengine3_7: Map IXACT3Cue interfaces xactengine3_7: Map SoundBank interfaces xactengine3_7: Add helper function to add entries https://gitlab.winehq.org/wine/wine/-/merge_requests/536

3 9

[PATCH v6 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) 04 Aug '22

04 Aug '22

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- v6: comctl32/tests: Add more ownerdata listview tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 8

Re: [PATCH v2 0/1] MR573: winebus.sys/sdl: Use the 8 absolute axes supported by DIJOYSTATE2. - approved
by Alexandre Julliard (＠julliard) 03 Aug '22

03 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/573

1 0

Re: [PATCH v4 0/4] MR393: wmvcore: Asynchronous reader state transitions. - approved
by Alexandre Julliard (＠julliard) 03 Aug '22

03 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/393

1 0

Re: [PATCH v2 0/2] MR569: include: Add more UI Automation definitions. - approved
by Alexandre Julliard (＠julliard) 03 Aug '22

03 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/569

1 0

Re: [PATCH v3 0/2] MR571: ntdll: Fix floating point registers not being restored under Wow64. - approved
by Alexandre Julliard (＠julliard) 03 Aug '22

03 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/571

1 0

Re: [PATCH v2 0/1] MR579: dwrite: Fix stretch value validation in CreateTextFormat(). - approved
by Alexandre Julliard (＠julliard) 03 Aug '22

03 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/579

1 0

Re: [PATCH v5 0/4] MR565: Implement NCryptEncrypt and BCryptEncrypt - approved
by Alexandre Julliard (＠julliard) 03 Aug '22

03 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/565

1 0

Re: [PATCH v4 0/2] MR511: webservices: Support error strings and faults in error. - approved
by Alexandre Julliard (＠julliard) 03 Aug '22

03 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/511

1 0

Re: [PATCH v2 0/19] MR578: d2d1: Add initial command list recording implementation. - approved
by Alexandre Julliard (＠julliard) 03 Aug '22

03 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/578

1 0

[PATCH 0/1] MR573: winebus.sys/sdl: Use the 8 absolute axes supported by DIJOYSTATE2.
by Arek Hiler (＠ivyl) 03 Aug '22

03 Aug '22

Most games use c_dfDIJoystick2 which can support up to 8 absolute axes, 6 directional ones and 2 sliders. With this change we now have 8 usable axes instead of six and we FIXME if device exposes more than that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/573

3 3

[PATCH v9 0/10] MR391: scrrun: Implement MoveFolder().
by Robert Wilhelm (＠sloper42) 03 Aug '22

03 Aug '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v9: scrrun: Return path not found error if no folders were moved in MoveFolder(). scrrun: return path not found error if source ends with path separator in MoveFolder(). scrrun: Move directories only in MoveFolder(). scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

3 11

[PATCH v3 0/4] MR393: wmvcore: Asynchronous reader state transitions.
by Rémi Bernon (＠rbernon) 03 Aug '22

03 Aug '22

Before https://gitlab.winehq.org/wine/wine/-/merge_requests/140, and to avoid a situation in the future where we might decide to implement this, and where the callback would be called asynchronously as they are supposed to, without the ASF reader filter supporting it. -- v3: winegstreamer: Make IWMReader state transitions asynchronous. winegstreamer: Leave the stream CS while waiting for a sample. winegstreamer: Move IWMReaderCallbackAdvanced *callback_advanced to a local variable. wmvcore/tests: Add more IWMReader_(Open|Start|Stop|Close) async checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/393

3 5

Re: [PATCH v3 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) 03 Aug '22

03 Aug '22

On Tue Aug 2 05:14:16 2022 +0000, **** wrote: > Zebediah Figura (she/her) replied on the mailing list: > ``` > On 7/31/22 06:53, Akihiro Sagawa wrote: > > @@ -1573,6 +1575,37 @@ static void test_video_window(void) > > todo_wine_if(i != 3) > > ok(style == expected, "hwnd %p: got %#lx, expected %#lx\n", > video_window, style, expected); > > > > + /* get source video size */ > > + err = mciSendCommandW(wDeviceID, MCI_WHERE, > MCI_DGV_WHERE_SOURCE, (DWORD_PTR)&parm); > > + ok(!err,"mciCommand where source returned %s\n", dbg_mcierr(err)); > > + src_rc = parm.where.rc; > This should just be equal to the whole video rect (0,0)-(64,32) [unless, > I suspect, it is set by MCI_DGV_PUT_SOURCE]; would you mind adding an > explicit test for that? > > + > > + /* test default video destination size */ > > + err = mciSendCommandW(wDeviceID, MCI_WHERE, > MCI_DGV_WHERE_DESTINATION, (DWORD_PTR)&parm); > > + ok(!err,"mciCommand where destination returned %s\n", dbg_mcierr(err)); > > + if (style & (WS_POPUP|WS_CHILD)) > > + rc = src_rc; > > + else > > + GetClientRect(video_window, &rc); > > + todo_wine_if(style & (WS_POPUP|WS_CHILD)) > > + ok(EqualRect(&parm.where.rc, &rc), "got %s, expected %s\n", > wine_dbgstr_rect(&parm.where.rc), wine_dbgstr_rect(&rc)); > And this should too. The test here is a bit awkward as such because the > destination and source rect are *always* equal, and separately, the > client rect will also be equal to the video size if the window is a > popup or child. > > + > > + /* test default video window size */ > > + rc = src_rc; > > + AdjustWindowRect(&rc, WS_OVERLAPPEDWINDOW, FALSE); /* sigh */ > > + OffsetRect(&rc, -rc.left, -rc.top); > > + rc.right = max(rc.right, GetSystemMetrics(SM_CXMIN)); > I gather "sigh" here means "Windows is broken", in the way spelled out > in 8/11, right? It wouldn't hurt to spell that out explicitly ;-) > _______________________________________________ > wine-gitlab mailing list -- wine-gitlab(a)winehq.org > To unsubscribe send an email to wine-gitlab-leave(a)winehq.org > ``` ``` > @@ -1573,6 +1575,37 @@ static void test_video_window(void) > todo_wine_if(i != 3) > ok(style == expected, "hwnd %p: got %#lx, expected %#lx\n", video_window, style, expected); > > + /* get source video size */ > + err = mciSendCommandW(wDeviceID, MCI_WHERE, MCI_DGV_WHERE_SOURCE, (DWORD_PTR)&parm); > + ok(!err,"mciCommand where source returned %s\n", dbg_mcierr(err)); > + src_rc = parm.where.rc; ``` > This should just be equal to the whole video rect (0,0)-(64,32) [unless, > I suspect, it is set by MCI_DGV_PUT_SOURCE]; would you mind adding an > explicit test for that? Not at all. Actually, video rect is (0,0)-(32,24). ``` > + > + /* test default video destination size */ > + err = mciSendCommandW(wDeviceID, MCI_WHERE, MCI_DGV_WHERE_DESTINATION, (DWORD_PTR)&parm); > + ok(!err,"mciCommand where destination returned %s\n", dbg_mcierr(err)); > + if (style & (WS_POPUP|WS_CHILD)) > + rc = src_rc; > + else > + GetClientRect(video_window, &rc); > + todo_wine_if(style & (WS_POPUP|WS_CHILD)) > + ok(EqualRect(&parm.where.rc, &rc), "got %s, expected %s\n", wine_dbgstr_rect(&parm.where.rc), wine_dbgstr_rect(&rc)); ``` > And this should too. The test here is a bit awkward as such because the > destination and source rect are *always* equal, and separately, the > client rect will also be equal to the video size if the window is a > popup or child. Minimum width of video window is SM_CXMIN. So, if the video width less than SM_CXMIN approximately, destination rect isn't identical to the source one. ``` > + > + /* test default video window size */ > + rc = src_rc; > + AdjustWindowRect(&rc, WS_OVERLAPPEDWINDOW, FALSE); /* sigh */ > + OffsetRect(&rc, -rc.left, -rc.top); > + rc.right = max(rc.right, GetSystemMetrics(SM_CXMIN)); ``` > I gather "sigh" here means "Windows is broken", in the way spelled out > in 8/11, right? It wouldn't hurt to spell that out explicitly ;-) Right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/557#note_5586

2 1

Re: [PATCH v3 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) 03 Aug '22

03 Aug '22

On Tue Aug 2 05:14:13 2022 +0000, **** wrote: > Zebediah Figura (she/her) replied on the mailing list: > ``` > On 7/31/22 06:53, Akihiro Sagawa wrote: > > +static BOOL MCIQTZ_CreateWindow(WINE_MCIQTZ* wma, DWORD dwFlags, > LPMCI_DGV_OPEN_PARMSW lpParms) > > +{ > > + HWND parent = NULL; > > + DWORD style = (WS_OVERLAPPEDWINDOW | WS_CLIPCHILDREN) & ~WS_MAXIMIZEBOX; > > + LONG width, height; > > + RECT rc; > > + HRESULT hr; > > + > > + if (dwFlags & MCI_DGV_OPEN_PARENT) parent = lpParms->hWndParent; > > + if (dwFlags & MCI_DGV_OPEN_WS) style = lpParms->dwStyle; > > + > > + hr = IBasicVideo_GetVideoSize(wma->vidbasic, &width, &height); > > + if (hr == E_NOINTERFACE) > > + return TRUE; /* audio file */ > > + else if (FAILED(hr)) > > + return FALSE; > > + > > + /* FIXME: Use video size here */ > > + width = 640; > > + height = 480; > Since this is kind of a regression otherwise (and since patch 8/11 is > pretty much a one-liner) I think it makes more sense just to merge that > patch into this one. Apologies if I said the opposite last review... > > + > > + wma->window = CreateWindowW(MCIQTZ_CLASS, > lpParms->lpstrElementName, style, > > + CW_USEDEFAULT, CW_USEDEFAULT, > > + width, height, > > + parent, 0, MCIQTZ_hInstance, > > + 0); > _______________________________________________ > wine-gitlab mailing list -- wine-gitlab(a)winehq.org > To unsubscribe send an email to wine-gitlab-leave(a)winehq.org > ``` I'll do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/557#note_5585

1 0

Re: [PATCH v3 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) 03 Aug '22

03 Aug '22

On Tue Aug 2 05:14:10 2022 +0000, **** wrote: > Zebediah Figura (she/her) replied on the mailing list: > ``` > On 7/31/22 06:53, Akihiro Sagawa wrote: > > @@ -183,9 +183,13 @@ static BOOL MCIQTZ_CreateWindow(WINE_MCIQTZ* wma, > DWORD dwFlags, LPMCI_DGV_OPEN_ > > else if (FAILED(hr)) > > return FALSE; > > > > - /* FIXME: Use video size here */ > > - width = 640; > > - height = 480; > > + /* Native always assumes an overlapped window > > + when calculating default video window size. */ > > + SetRect(&rc, 0, 0, width, height); > > + AdjustWindowRect(&rc, WS_OVERLAPPEDWINDOW, FALSE); > > + min_width = GetSystemMetrics(SM_CXMIN); > > + width = max(rc.right - rc.left, min_width); > CreateWindow() should automatically enforce the minimum width, so there > should be no need to use SM_CXMIN here. > _______________________________________________ > wine-gitlab mailing list -- wine-gitlab(a)winehq.org > To unsubscribe send an email to wine-gitlab-leave(a)winehq.org > ``` Got it. Good tip. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/557#note_5584

1 0

[PATCH 0/1] MR579: dwrite: Fix stretch value validation in CreateTextFormat().
by Nikolay Sivov (＠nsivov) 03 Aug '22

03 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/579

2 1

[PATCH v4 0/4] MR565: Implement NCryptEncrypt and BCryptEncrypt
by Santino Mazza (＠tati1454) 03 Aug '22

03 Aug '22

Some installers, like the visual studio installer, also make use of this function, instead of just NCryptVerifySignature. -- v4: ncrypt: Initial implementation for NCryptEncrypt. bcrypt: Initial RSA encryption implementation. bcrypt/tests: Test for BCryptEncrypt with RSA keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/565

3 5

[PATCH v3 0/2] MR511: webservices: Support error strings and faults in error.
by Shaun Ren (＠shaunren) 03 Aug '22

03 Aug '22

-- v3: webservices: Support faults in error. webservices: Implement error strings. https://gitlab.winehq.org/wine/wine/-/merge_requests/511

3 4

2025

2024

2023

2022

wine-gitlab