- wine-gitlab - winehq.org

[wine-gitlab] [PATCH 0/3] MR395: win32u: Move reading and writing mode from registry out of graphics drivers.
by Rémi Bernon (＠rbernon) 07 Jul '22

07 Jul '22

What was initially in https://gitlab.winehq.org/wine/wine/-/merge_requests/355, with the test failures hopefully fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/395

3 6

[wine-gitlab] Re: [PATCH v6 0/3] MR302: winegstreamer: Some wg_transform H264 fixes for Mortal Kombat 11 and Yakuza 4. - approved
by Nikolay Sivov (＠nsivov) 07 Jul '22

07 Jul '22

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/302

1 0

[wine-gitlab] [PATCH v2 0/2] MR360: Draft: winepulse.drv: add support for containerId property from sysfs path
by Claire (＠ClearlyClaire) 07 Jul '22

07 Jul '22

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. This MR, together with !359, adds support for exposing such a ContainerId to applications. I marked this MR as a draft because I understand that the way the ��guid�� is generated is far from ideal. Furthermore, I will need to map from sysfs to container Id in other components as well (`winebus` for the HID device, and possibly `winealsa` and other audio drivers), so moving that part elsewhere would make sense. However, I think I will need help with those tasks. -- v2: winepulse: Add support for containerId property from sysfs path winepulse: Store PulseAudio device's sysfs path when available https://gitlab.winehq.org/wine/wine/-/merge_requests/360

2 2

[wine-gitlab] Re: [PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Nikolay Sivov (＠nsivov) 07 Jul '22

07 Jul '22

Nikolay Sivov (@nsivov) commented about include/d2derr.h: > #ifndef __WINE_D2DERR_H > #define __WINE_D2DERR_H > > +#define D2DERR_NOT_FOUND HRESULT_FROM_WIN32(ERROR_NOT_FOUND) I don't see in 10.0.2200.0 SDK. Where does it come from? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388#note_3514

1 0

[wine-gitlab] [PATCH 0/2] MR396: dinput/tests: Fix reported test failures.
by Rémi Bernon (＠rbernon) 07 Jul '22

07 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/396

2 2

[wine-gitlab] Re: [PATCH 0/7] MR391: scrrun: Implement MoveFolder().
by Chip Davis (＠cdavis5e) 07 Jul '22

07 Jul '22

Chip Davis (@cdavis5e) commented about dlls/scrrun/filesystem.c: > if((attrs == INVALID_FILE_ATTRIBUTES) || !(attrs & FILE_ATTRIBUTE_DIRECTORY)) > return CTL_E_PATHNOTFOUND; > > + _wsplitpath(source, src_drive, src_dir, file_name, file_ext); > + len = lstrlenW(destination); > + > + if (destination[len-1] == '\\') { What about `'/'`? I know that's a valid separator to the Win32 API. Is it one to this API? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/391#note_3508

1 0

[wine-gitlab] [PATCH 0/2] MR394: d3d8/tests: Build without -DWINE_NO_LONG_TYPES.
by Zebediah Figura (＠zfigura) 07 Jul '22

07 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/394

2 2

[wine-gitlab] Re: [PATCH v3 0/1] MR367: oleaut32 fix - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/367

1 0

[wine-gitlab] [PATCH v3 0/3] MR392: regedit: Code clean-up and invalid read fix
by Hugh McMaster (＠hmc) 06 Jul '22

06 Jul '22

-- v3: regedit: Directly use RegQueryValueExW() instead of a helper function. regedit: Correctly calculate REG_MULTI_SZ size before reading from the buffer. regedit: Remove unneeded valueDataLen override for DWORD values. https://gitlab.winehq.org/wine/wine/-/merge_requests/392

3 4

[wine-gitlab] Re: [PATCH v8 0/3] MR355: win32u: Move more display mode logic out of graphics drivers. - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/355

1 0

[wine-gitlab] Re: [PATCH v15 0/8] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/337

1 0

[wine-gitlab] Re: [PATCH v2 0/2] MR387: uxtheme/tests: Add more GetThemePartSize() tests in different DPI. - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/387

1 0

[wine-gitlab] Re: [PATCH v2 0/1] MR390: secur32: Validate input buffers in schan_InitializeSecurityContextW(). - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/390

1 0

[wine-gitlab] Re: [PATCH v2 0/2] MR386: d3d9/tests: Build without -DWINE_NO_LONG_TYPES. - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/386

1 0

[wine-gitlab] Re: [PATCH 0/3] MR393: wmvcore: Asynchronous reader state transitions.
by Rémi Bernon (＠rbernon) 06 Jul '22

06 Jul '22

I'll have a look at the time failures, I was seeing them locally but not on the testbot run so I assumed they were flukes caused by some decoder differences, looks like it may be something else after all. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/393#note_3477

1 0

[wine-gitlab] Re: [PATCH v6 0/7] MR140: qasf: More ASF reader filter implementation.
by Rémi Bernon (＠rbernon) 06 Jul '22

06 Jul '22

On Wed Jul 6 17:52:44 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 7/6/22 05:08, R��mi Bernon (@rbernon) wrote: > >> So yes, we could not block in IWMReader::Stop(), but that's not > >> ultimately going to help anything. We do still need to wait for the > >> streaming thread to stop at some point. > > > > Well we could then call `Stop` and wait for the WMT_STOPPED callback > notification with a condition variable, releasing the filter_cs so the > callbacks are free to enter it to make the thread-safety obviously correct. > Unfortunately we can't release the filter CS while waiting for the > thread to stop. We need to protect the whole operation. > ``` I opened https://gitlab.winehq.org/wine/wine/-/merge_requests/393#note_3473 to make WM async reader state transitions asynchronous, so that we can then do the right thing here and wait for the callback notifications while entering the CS and avoiding the deadlock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/140#note_3475

1 0

2025

2024

2023

2022

wine-gitlab