- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR7423: subst: Add basic implementation. - approved
by Alexandre Julliard (＠julliard) 25 Feb '25

25 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7423

1 0

Re: [PATCH v3 0/4] MR7381: imm32: Move the IME UI window to the bottom at creation. - approved
by Alexandre Julliard (＠julliard) 25 Feb '25

25 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7381

1 0

Re: [PATCH v2 0/1] MR7420: comctl32: Fix Alloc/HeapAlloc mismatches. - approved
by Alexandre Julliard (＠julliard) 25 Feb '25

25 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7420

1 0

[PATCH 0/2] MR7417: mfplat: Modify MFCreateWaveFormatExFromMFMediaType to allow MF_MT_AM_FORMAT_TYPE to be missing or set to GUID_NULL.
by Brendan McGrath (＠redmcg) 25 Feb '25

25 Feb '25

This MR: - adds tests for when MF_MT_AM_FORMAT_TYPE is missing or set to GUID_NULL; and - modifies MFCreateWaveFormatExFromMFMediaType to pass these tests -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7417

3 7

[PATCH 0/1] MR4662: properly track refcount and dependencies with forwarded exports.
by YUAN RUI (＠number201724) 25 Feb '25

25 Feb '25

fix: https://bugs.winehq.org/show_bug.cgi?id=52094 tests: ``` #include <Windows.h> #ifdef FROM_IMPORT #pragma comment(lib, "python3.lib") extern "C" int Py_IsInitialized(); #endif int main() { #ifdef FROM_IMPORT // test from import table Py_IsInitialized( ); #else // //Test ref count int (*Py_IsInitialized)(); HMODULE hmod_310 = LoadLibraryA( "C:\\Python310\\python310.dll" ); HMODULE hmod = LoadLibraryA( "C:\\Python310\\python3.dll" ); if ( !hmod ) return 0; *(FARPROC*)&Py_IsInitialized = GetProcAddress( hmod, "Py_IsInitialized" ); FreeLibrary( hmod_310 ); Py_IsInitialized( ); FreeLibrary( hmod ); // test dependencies hmod = LoadLibraryA( "C:\\Python310\\python3.dll" ); if ( !hmod ) return 0; *(FARPROC*)&Py_IsInitialized = GetProcAddress( hmod, "Py_IsInitialized" ); Py_IsInitialized(); FreeLibrary( hmod ); #endif return 0; } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4662

5 5

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Nikolay Sivov (＠nsivov) 25 Feb '25

25 Feb '25

On Tue Feb 25 20:23:00 2025 +0000, Stefan Brüns wrote: > @d1saster - Maybe you could extend the test so all 4 cases (2 fill > modes, intersecting/non-intersecting) are tested (marking the > ALTERNATE-intersecting one as known-fail). This isn't about percentage or how common it is. It's not clear this is the right direction to me, for example groups could contain path geometries with different filling modes, or other groups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_95936

1 0

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Nikolay Sivov (＠nsivov) 25 Feb '25

25 Feb '25

This is included in wine-staging now, you could use that for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_95935

1 0

[PATCH 0/3] MR3124: Move periodic registry save out of wineserver
by Paul Gofman (＠gofman) 25 Feb '25

25 Feb '25

The problem is that registry save is a very heavy operation (scheduled each 30sec in wineserver) during which server doesn't process any requests and the whole prefix is stalled for the duration of the operation. For some reference, the process takes from 50-100ms here up to 1-1.5sec with default initial registry (after some registry modifications which trigger actual registry flush), depending on the filesystem type and state (as huge time may be spent in file close / rename). With the same registry after this patchset the server part (flush_key returning the whole registry data) is taking ~4-5mcs, measured from the client side so that already includes data transfer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3124

5 9

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Stefan Brüns (＠StefanBruens) 25 Feb '25

25 Feb '25

On Tue Feb 25 20:20:12 2025 +0000, Stefan Brüns wrote: > I think the current implementation is only incorrect when the fill mode > is D2D1_FILL_MODE_ALTERNATE (0) (aka Even-Odd), but correct for > D2D1_FILL_MODE_WINDING (1). More specifically, when the fill mode is > ALTERNATE *and* there are intersections - for all of the other three > cases (WINDING with and without intersections, ALTERNATE without), it is correct. > According to my experience, even-odd fill mode is quite uncommon. Having > an implementation which is correct 99% of the time in real-world usage, > and leaving the remainder with an explicit, verbose FIXME is an > definitive improvement. Today, the result is always incorrect. @d1saster - Maybe you could extend the test so all 4 cases (2 fill modes, intersecting/non-intersecting) are tested (marking the ALTERNATE-intersecting one as known-fail). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_95932

1 0

Re: [PATCH v3 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup
by Stefan Brüns (＠StefanBruens) 25 Feb '25

25 Feb '25

On Sat Sep 28 19:59:05 2024 +0000, Nikolay Sivov wrote: > It wouldn't consider it sufficient, it's clear that there is more to it > than copying data from individual geometries. So the question is the > same - what needs to be done to make it work properly, once it's > understood, we could implement it partially if it's too hard to do properly. I think the current implementation is only incorrect when the fill mode is D2D1_FILL_MODE_ALTERNATE (0) (aka Even-Odd), but correct for D2D1_FILL_MODE_WINDING (1). More specifically, when the fill mode is ALTERNATE *and* there are intersections - for all of the other three cases (WINDING with and without intersections, ALTERNATE without), it is correct. According to my experience, even-odd fill mode is quite uncommon. Having an implementation which is correct 99% of the time in real-world usage, and leaving the remainder with an explicit, verbose FIXME is an definitive improvement. Today, the result is always incorrect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_95931

1 0

[PATCH v9 0/1] MR3096: ntdll: Add NtGetNextProcess stub.
by Alex Henrie (＠alexhenrie) 25 Feb '25

25 Feb '25

The stub is enough for TokenViewer.exe to start up and display its user interface. Based on a patch by Nikolay Sivov. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45119 -- v9: ntdll: Add NtGetNextProcess stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3096

2 3

[PATCH v4 0/5] MR7370: winex11: Pass fullscreen flag to is_window_managed.
by Rémi Bernon (＠rbernon) 25 Feb '25

25 Feb '25

Instead of checking for monitor rect. Similar purpose as https://gitlab.winehq.org/wine/wine/-/merge_requests/7362 -- v4: winewayland: Pass fullscreen flag to is_window_managed. winex11: Pass fullscreen flag to is_window_managed. winex11: Check managed window changes in WindowPosChanged. winex11: Request managed/embedded in a new window_set_managed helper. winex11: Initialize window managed flag in create_whole_window. https://gitlab.winehq.org/wine/wine/-/merge_requests/7370

3 7

[PATCH v5 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu (＠insn) 25 Feb '25

25 Feb '25

-- v5: server: When renaming, only fstat the source once. server: Handle hardlinks and casefolding when renaming the same file. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

4 9

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Elizabeth Figura (＠zfigura) 25 Feb '25

25 Feb '25

> No, I think it is desirable. I'm going to move some more tests out, to build with either msxml2.idl or msxml6.idl, and then we'll see what's left. What's the progress on this? Is this something that could be delegated to someone else invested in upstreaming wine-staging patches? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_95923

1 0

[PATCH 0/1] MR7426: include: Add D3DKMT_WDDM_*_CAPS.
by Brendan Shanks (＠bshanks) 25 Feb '25

25 Feb '25

These structs are in the [Windows SDK](https://www.nuget.org/packages/Microsoft.Windows.SDK.CPP), and on MSDN. They are used in downstream patches like https://github.com/ValveSoftware/wine/commit/15c0fcd0ab4d, and sometimes in user-space libraries/applications. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7426

2 1

[PATCH v3 0/8] MR7424: winebth.sys part 5: Update properties for tracked remote devices.
by Vibhav Pant (＠vibhavp) 25 Feb '25

25 Feb '25

This fadds to the basic infrastructure needed for device inquiry/scanning. Also, fixes radio properties being incorrectly updated. -- v3: winebth.sys: Set the device class for remote devices from BlueZ's "Class" property. winebth.sys: Use the "Trusted" property from BlueZ device objects to set BDIF_PERSONAL. winebth.sys: Use the "Name" property of a BlueZ adapter for the local radio name. winebth.sys: Don't iterate over the remaining radios once a local device has been removed. winebth.sys: Initially set numOfDevices to 0 in IOCTL_BTH_GET_DEVICE_INFO. winebth.sys: Use the correct DBus property name in IOCTL_WINEBTH_RADIO_SET_FLAG. winebth.sys: Update properties for tracked remote devices on receiving PropertiesChanged for org.bluez.Device1 objects from BlueZ. https://gitlab.winehq.org/wine/wine/-/merge_requests/7424

2 9

[PATCH v3 0/4] MR7406: winebth.sys: Minor fixes related to device/radio properties.
by Vibhav Pant (＠vibhavp) 25 Feb '25

25 Feb '25

-- v3: winebth.sys: Don't iterate over the remaining radios once a local device has been removed. winebth.sys: Initially set numOfDevices to 0 in IOCTL_BTH_GET_DEVICE_INFO. winebth.sys: Use the correct DBus property name in IOCTL_WINEBTH_RADIO_SET_FLAG. winebth.sys: Only set the updated properties for local radios on BLUETOOTH_WATCHER_EVENT_TYPE_RADIO_PROPERTIES_CHANGED. https://gitlab.winehq.org/wine/wine/-/merge_requests/7406

2 6

[PATCH 0/8] MR7424: winebth.sys part 5: Update properties for tracked remote devices.
by Vibhav Pant (＠vibhavp) 25 Feb '25

25 Feb '25

This adds to the basic infrastructure needed for adding support for device inquiry/scanning. Also, fixes radio properties being incorrectly updated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7424

2 8

[PATCH v6 0/1] MR7374: wine.inf: Add VC runtime version key.
by Bernhard Kölbl (＠besentv) 25 Feb '25

25 Feb '25

The Unreal engine bootstrapper relies on this to detect VC presence since version 5.3. -- v6: wine.inf: Add VC runtime version key. https://gitlab.winehq.org/wine/wine/-/merge_requests/7374

3 3

[PATCH v3 0/4] MR7412: win32u: Use VK_EXT_headless_surface for nulldrv surface.
by Rémi Bernon (＠rbernon) 25 Feb '25

25 Feb '25

Allows running more tests with nulldrv, including some D3D tests with vulkan renderer. -- v3: win32u: Use VK_EXT_headless_surface for nulldrv surface. win32u: Pass a vulkan_instance pointer to vulkan_surface_create. winevulkan: Enable the VK_EXT_headless_surface extension. winevulkan: Generate function pointers for required funcs. https://gitlab.winehq.org/wine/wine/-/merge_requests/7412

3 5

[PATCH v12 0/1] MR7400: cmd: Allow any key to continue past DIR /P pauses.
by Joe Souza (＠JoeS209) 25 Feb '25

25 Feb '25

Current code requires entering a newline character in order to continue past DIR /P prompts. This change allows any key to be pressed instead. Code to handle this was similar to existing WCMD_pause() so we leveraged that code for this purpose as well. Key to the fix was the removal of ENABLE_LINE_INPUT from the console flags, and ENABLE_PROCESSED_INPUT was added in order to preserve the ability to abort the operation via Ctrl-C. -- v12: cmd: Allow any key to continue past DIR /P pauses. https://gitlab.winehq.org/wine/wine/-/merge_requests/7400

2 2

[PATCH 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Yuxuan Shui (＠yshui) 25 Feb '25

25 Feb '25

## Context This is a problem discovered when running "Max: The Curse of Brotherhood" under proton. This game writes 4MB a piece into `wg_transform`, which contains about 4 seconds of compressed video. `wg_transform` calls `gst_pad_push` in `transform_ProcessOutput`, which takes \~300ms (i.e. 20 frames @ 60fps) to decode this buffer of video. So the end result is the game hitches every 4 seconds while playing cut scene videos. Proton currently has a special case for this particular game, for which it breaks up the buffer into small chunks to avoid long blocks. This MR adopts that and applies it generally. One concern raised by @redmcg is: > The only issue I can think of is if there are any decoders which don't have a parser; then they might not know how to deal with an arbitrary 4096 byte buffer (the parser is generally responsible for taking arbitrary buffers and producing something the decoder can work with, for example: a full frame). So this MR only enables this strategy when there is a parser element. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7288

5 14

[PATCH 0/1] MR7418: wininet: Treat Expires value "-1" the same as "0"
by Yongjie Yao (＠yaoyongjie) 25 Feb '25

25 Feb '25

In iis server, use -1 to specify immediate expiration. For detailed documentation, please refer to: https://learn.microsoft.com/en-us/previous-versions/iis/6.0-sdk/ms525906(v=… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7418

4 7

Re: [PATCH v3 0/1] MR7323: wininet: Treat Expires value "-1" the same as "0"
by Jacek Caban (＠jacek) 25 Feb '25

25 Feb '25

I can see that you quoted MSDN page in the other MR, but it's not clear to me if it's relevant. It mentions some IIS APIs, not how HTTP headers look like. I guess adding a test to `test_http_connection()` that would send "-1" "Expires" header and querying `INTERNET_OPTION_CACHE_TIMESTAMPS` on the result would tell us how it works. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7323#note_95883

1 0

[PATCH v2 0/2] MR7412: win32u: Use VK_EXT_headless_surface for nulldrv surface.
by Rémi Bernon (＠rbernon) 25 Feb '25

25 Feb '25

Allows running more tests with nulldrv, including some D3D tests with vulkan renderer. -- v2: win32u: Use VK_EXT_headless_surface for nulldrv surface. winevulkan: Enable VK_EXT_headless_surface extension. https://gitlab.winehq.org/wine/wine/-/merge_requests/7412

3 9

2025

2024

2023

2022

wine-gitlab