- wine-gitlab - winehq.org

[PATCH 0/1] MR8218: gdiplus/tests: Make sure stride is correct for GdipCreateBitmapFromScan0.
by Yuxuan Shui (＠yshui) 06 Jun '25

06 Jun '25

We use 4*3 as the stride for GdipCreateBitmapFromScan0 in all test cases in test_CloneBitmapArea, but bmp_3x3_data_24bpp_rgb only has 9 bytes per row. GdipCreateBitmapFromScan0 also expects the stride to be a multiple of 4, so pad bmp_3x3_data_24bpp_rgb to be 12 bytes per row. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8218

4 7

[PATCH 0/1] MR8223: comctl32/taskdialog: Fix layout when there is no button.
by Zhiyi Zhang (＠zhiyi) 06 Jun '25

06 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8223

3 3

Re: [PATCH v2 0/3] MR8193: Support generating both DWARF and PDB debug info in a single build.
by Jacek Caban (＠jacek) 06 Jun '25

06 Jun '25

On Fri Jun 6 18:17:35 2025 +0000, eric pouech wrote: > @jacek just testing this (yeah a bit late sorry), it looks like the .pdb > file only contains the public symbols. > using: clang version 20.1.5 > do we need a later clang version? I tested mostly with LLVM git, but version 19 seems to work too, unless I'm checking it wrong. For example, I get: ``` $ llvm-pdbutil dump --symbols programs/notepad/x86_64-windows/notepad.pdb |grep NOTEPAD_WndProc 7468 | S_LPROC32 [size = 56] `NOTEPAD_WndProc` ``` Do you not see such symbols in your build or did you mean something else? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8193#note_105685

1 0

[PATCH v3 0/5] MR8222: widl: Add rows for the struct type.
by Hans Leidekker (＠hans) 06 Jun '25

06 Jun '25

-- v3: widl: Add rows for the requires keyword. widl: Add rows for the exclusiveto attribute. widl: Add rows for the uuid attribute. widl: Add rows for the interface type. https://gitlab.winehq.org/wine/wine/-/merge_requests/8222

4 8

[PATCH 0/1] MR8219: gdiplus/tests: Use correctly formatted description.
by Yuxuan Shui (＠yshui) 06 Jun '25

06 Jun '25

According to a comment in emf_create, description is expected to be "App name\0Title\0\0". But in the test cases we only ever passed "winetest\0", so emf_create reads out-of-bound trying to find the title. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8219

3 2

[PATCH 0/1] MR8228: mshtml: Fix misuse of IWinInetHttpInfo_QueryInfo.
by Yuxuan Shui (＠yshui) 06 Jun '25

06 Jun '25

IWinInetHttpInfo_QueryInfo returns a multibyte string, not a wide string. We were also wrongly expecting it to have a NUL terminator. * * * this one doesn't feel good. IWinInetHttpInfo_QueryInfo calls HttpInfo_QueryInfo (urlmon), which calls HttpQueryInfoA (wininet), so it returns char*. but inside, HttpQueryInfoA is calling HttpQueryInfoW and does charset conversion. so we are converting the string to multibyte and back. maybe there's an API that returns wchar* i don't know about. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8228

3 4

[PATCH v2 0/5] MR8225: PDB rewrite #15.
by eric pouech (＠epo) 06 Jun '25

06 Jun '25

This MR does: - improve startup time when loading a large PDB file (a chromium based PDB file (larger than 4G) now loads in 3,5s) (at the begining of this rewrite, loading the very same PDB file ended with a reboot triggered by the Linux OOM after 30 minutes of heavy swap) - finally untie the new PDB backend for the old one (they are now considered as two independant debug formats, so that we can eventually drop the old one at some point) -- v2: dbghelp: Let new PDB reader exist independantly of the old one. dbghelp: Rename declarations for old PBD backend. dbghelp: Simplify signature of PDB unwinders. dbghelp: Get fpo stream information directly in new PDB reader. dbghelp: Speed up global symbols at startup. https://gitlab.winehq.org/wine/wine/-/merge_requests/8225

2 6

[PATCH 0/1] MR8230: inetmib1: Fix table emptiness check.
by Yuxuan Shui (＠yshui) 06 Jun '25

06 Jun '25

getItemAndInstanceFromTable only checks if the table is NULL, but didn't check if it actually contains any entries. It just assumes it does and will return index 1 in some cases, resulting in out-of-bound access of the table down the line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8230

2 1

[PATCH 0/1] MR8229: win32u: Return hwnd from get_full_window_handle when invalid.
by Rémi Bernon (＠rbernon) 06 Jun '25

06 Jun '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58329 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8229

2 1

[PATCH v4 0/4] MR8220: Draft: comdlg32: Don't use a shadow devmode structure in PrintDlg.
by Jacob Czekalla (＠JacobCzekalla) 06 Jun '25

06 Jun '25

If the "Properties" button is clicked in the printdlg it opens the print properties dlg. The problem is the values set in the properties dlg don't get passed through correctly to the final printing stage. This prevents properties like duplex and page size from working. -- v4: comdlg32: Don't use a shadow devmode structure in PrintDlgA. comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgA. comdlg32: Don't use a shadow devmode structure in PrintDlgW. comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgW. https://gitlab.winehq.org/wine/wine/-/merge_requests/8220

3 5

Re: [PATCH v2 0/3] MR8193: Support generating both DWARF and PDB debug info in a single build.
by eric pouech (＠epo) 06 Jun '25

06 Jun '25

@jacek just testing this (yeah a bit late sorry), it looks like the .pdb file only contains the public symbols. using: clang version 20.1.5 do we need a later clang version? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8193#note_105659

1 0

[PATCH v7 0/5] MR8206: windows.devices.bluetooth: Add stubs for (I)BluetoothDeviceStatics.
by Vibhav Pant (＠vibhavp) 06 Jun '25

06 Jun '25

-- v7: windows.devices.bluetooth: Add stub for IBluetoothDeviceStatics. windows.devices.bluetooth/tests: Add tests for BluetoothDeviceStatics. include: Add definitions for Windows.Devices.Bluetooth.BluetoothDevice. include: Add windows.devices.bluetooth.rfcomm.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8206

2 5

[PATCH 0/1] MR8227: find: Support /c switch.
by Hans Leidekker (＠hans) 06 Jun '25

06 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8227

2 1

Re: [PATCH v7 0/2] MR8200: cmd: COPY should output file names as they are copied.
by eric pouech (＠epo) 06 Jun '25

06 Jun '25

please amend the tests in the `---------- Testing copy part` (after line 3387 in test_builtins.cmd), the tests you've amended are meant to test the return codes, not really the final behavior) and likely all these tests up to the ascii/binary part should be amended to check whether the names are printed or not if needed, you can work around builtin find.exe missing the /c switch by using ``` :count_lines @set "lines=0" @for /F %%a in (%1) do set /A lines+=1 @exit /b %lines% ``` using `call :count_lines <file>` and you'll get the number of lines in %errorlevel% variable (but IMO in most of the cases testing for a file name printed should serve the same purpose) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_105647

1 0

[PATCH v3 0/4] MR8220: Draft: comdlg32: Don't use a shadow devmode structure in PrintDlg.
by Jacob Czekalla (＠JacobCzekalla) 06 Jun '25

06 Jun '25

If the "Properties" button is clicked in the printdlg it opens the print properties dlg. The problem is the values set in the properties dlg don't get passed through correctly to the final printing stage. This prevents properties like duplex and page size from working. -- v3: comdlg32: Don't use a shadow devmode structure in PrintDlgA. comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgA. comdlg32: Don't use a shadow devmode structure in PrintDlgW. comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgW. https://gitlab.winehq.org/wine/wine/-/merge_requests/8220

2 4

[PATCH v2 0/5] MR8222: widl: Add rows for the struct type.
by Hans Leidekker (＠hans) 06 Jun '25

06 Jun '25

-- v2: widl: Add rows for the requires keyword. widl: Add rows for the exclusiveto attribute. widl: Add rows for the uuid attribute. widl: Add rows for the interface type. https://gitlab.winehq.org/wine/wine/-/merge_requests/8222

3 9

[PATCH 0/5] MR8225: PDB rewrite #15.
by eric pouech (＠epo) 06 Jun '25

06 Jun '25

This MR does: - improve startup time when loading a large PDB file (a chromium based PDB file (larger than 4G) now loads in 3,5s) (at the begining of this rewrite, loading the very same PDB file ended with a reboot triggered by the Linux OOM after 30 minutes of heavy swap) - finally untie the new PDB backend for the old one (they are now considered as two independant debug formats, so that we can eventually drop the old one at some point) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8225

2 5

[PATCH 0/1] MR8224: hid/tests: Fix stack use-after-return in test_read_device.
by Yuxuan Shui (＠yshui) 06 Jun '25

06 Jun '25

The read loop could exit while a async read request is still in flight, which could complete after test_read_device has returned. This results in a stack use-after-return of `overlapped`. * * * Finally had something caught by the unix side AddressSanitizer, PE ASan wouldn't have caught this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8224

3 2

[PATCH v2 0/2] MR7024: Disable native titlebar while lacking enough space for SM_CYCAPTION.
by Jactry Zeng (＠jactry) 06 Jun '25

06 Jun '25

On Windows, applications can disable titlebar by extending the client rect to a bigger rect which will cover the area of the titlebar from WM_NCCALCSIZE: https://learn.microsoft.com/en-us/windows/win32/dwm/customframe#removing-th… Our current x11 and Mac driver doesn't handle this case. Attached is a test case for reproducing the issue. [hide_caption.c](/uploads/46a725e32569a6a0a929a0f183cf9ed8/hide_caption.c) -- v2: winemac.drv: Disable native titlebar while lacking enough space for SM_CYCAPTION. winex11.drv: Disable native titlebar while lacking enough space for SM_CYCAPTION. https://gitlab.winehq.org/wine/wine/-/merge_requests/7024

2 2

[PATCH v2 0/1] MR8205: comctl32: Make sure line_widths is big enough.
by Yuxuan Shui (＠yshui) 06 Jun '25

06 Jun '25

When button_count is 0, we would allocate 0 bytes for line_widths, but later line_count would be 1 so we would still try to access line_widths[0] which is out-of-bound. -- v2: comctl32: Make sure line_widths is big enough. https://gitlab.winehq.org/wine/wine/-/merge_requests/8205

4 6

[PATCH 0/5] MR8222: widl: Add rows for the struct type.
by Hans Leidekker (＠hans) 06 Jun '25

06 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8222

3 7

[PATCH v5 0/5] MR8206: windows.devices.bluetooth: Add stubs for (I)BluetoothDeviceStatics.
by Vibhav Pant (＠vibhavp) 06 Jun '25

06 Jun '25

-- v5: windows.devices.bluetooth: Add stub for IBluetoothDeviceStatics. windows.devices.bluetooth/tests: Add tests for BluetoothDeviceStatics. include: Add definitions for Windows.Devices.Bluetooth.BluetoothDevice. include: Add windows.devices.bluetooth.rfcomm.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8206

3 14

[PATCH 0/1] MR8221: urlmon: Skip fragment part when checking filenames for file protocol.
by Gabriel Ivăncescu (＠insn) 06 Jun '25

06 Jun '25

I have no idea what the previous test was trying to do, but it was clearly wrong and misleading. First, it placed the fragment for no reason in file_name_buf because it then replaced it with a NUL, making you believe it's part of it but when it really was not. Then, it opened the original index.html to write XXX to it, so the fragment filename never actually existed in the first place, and was never tested. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8221

3 2

[PATCH 0/2] MR8196: winewayland: Ignore text-input "done" events that don't modify state.
by Alexandros Frantzis (＠afrantzis) 06 Jun '25

06 Jun '25

Compositors send a "done" event after every text-input commit, even if the reported state (preedit etc) hasn't changed. Acting on such events is at best wasteful, but can additionally lead to incorrect IME related effects (e.g., deleting the currently selected text), so ignore them, similarly to what Qt and GTK do. The first commit performs some state related cleanups. -- This solves an IME problem I have been experiencing with compositors that support text-input-v3 (e.g., kwin). 1. Run notepad 2. Write some text 3. Try to select text Expected result: text is selected Actual result: text is deleted What happens is that while the user is selecting text the driver gets a series of `SetIMECompositionRect` callback which cause a series of text-input-v3 `set_cursor_rectangle`-`commit` requests. These `commit`s elicit `done` events from the compositor with no state changes, which we interpret as "clear the composition string" (and by extension the active selection), because that's what such states normally means, and forward them to windows IME. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8196

4 4

[PATCH v2 0/4] MR8220: comdlg32: Don't use a shadow devmode structure in PrintDlg.
by Jacob Czekalla (＠JacobCzekalla) 06 Jun '25

06 Jun '25

If the "Properties" button is clicked in the printdlg it opens the print properties dlg. The problem is the values set in the properties dlg don't get passed through correctly to the final printing stage. This prevents properties like duplex and page size from working. -- v2: comdlg32: Don't use a shadow devmode structure in PrintDlgA. comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgA. comdlg32: Don't use a shadow devmode structure in PrintDlgW. comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgW. https://gitlab.winehq.org/wine/wine/-/merge_requests/8220

3 5

2025

2024

2023

2022

wine-gitlab