- wine-gitlab - winehq.org

[PATCH v2 0/2] MR7342: Implement D3D11_FEATURE_D3D9_SIMPLE_INSTANCING_SUPPORT feature check.
by Zhiyi Zhang (＠zhiyi) 18 Feb '25

18 Feb '25

For React Native. -- v2: d3d11: Implement D3D11_FEATURE_D3D9_SIMPLE_INSTANCING_SUPPORT feature check. https://gitlab.winehq.org/wine/wine/-/merge_requests/7342

2 4

[PATCH v3 0/1] MR7179: wined3d: Add some DXT format mappings in the Vulkan renderer.
by Aida Jonikienė (＠DodoGTA) 18 Feb '25

18 Feb '25

This removes some texture errors when using Himavant. -- v3: wined3d: Add DXT format mappings in the Vulkan renderer. https://gitlab.winehq.org/wine/wine/-/merge_requests/7179

4 4

[PATCH v3 0/5] MR7347: ntdll: Avoid process_attach() even indirectly if loaded with `DONT_RESOLVE_DLL_REFERENCES`
by Jinoh Kang (＠iamahuman) 17 Feb '25

17 Feb '25

This cleans up `LDR_DONT_RESOLVE_REFS` checks in preparation for !7. -- v3: ntdlll: Remove redundant LDR_DONT_RESOLVE_REFS checks before calling process_attach(). ntdll: Skip DLL initialization and ldr notification entirely if DONT_RESOLVE_DLL_REFERENCES is set. kernel32/tests: Test for unexpected loader notification for import dependency loaded with DONT_RESOLVE_DLL_REFERENCES. kernel32/tests: Test for unexpected LDR_PROCESS_ATTACHED flag in import dependency loaded with DONT_RESOLVE_DLL_REFERENCES. kernel32/tests: Add basic tests for internal flags of modules loaded with DONT_RESOLVE_DLL_REFERENCES. https://gitlab.winehq.org/wine/wine/-/merge_requests/7347

2 6

[PATCH 0/5] MR4894: setupapi: implement CM_Locate_DevNode
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Feb '25

17 Feb '25

This api is used by libxess on intel GPUs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4894

3 8

Re: [PATCH v8 0/2] MR7060: scrrun/tests: Add drive_get_path test
by Quinn Rafferty (＠ramleejo) 17 Feb '25

17 Feb '25

On Wed Jan 1 16:32:32 2025 +0000, Nikolay Sivov wrote: > @alexhenrie is it possible to create a drive without a letter? Regarding > wine supporting only drives with assigned letters, I don't think it > matters that much if it turns out to be easy to return a correct path. > IDrive has separate properties for paths and letters, so maybe there is > a reason for that. My understanding is that the way to query all available drives is via DriveCollection. Due to this I changed the tests to what Alex Henrie suggested as it will properly verify the functionality of the function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7060#note_94929

1 0

[PATCH v4 0/2] MR7238: winebus,mmdevapi: implement audio device container id
by Harald Sitter (＠sitter) 17 Feb '25

17 Feb '25

This is a bit convoluted because of the amount of pieces involved. I'll try to untangle things a bit. The container id is meant to be globally unique and stable. We therefore need a suitable amount of stable entropy that we can feed into a hash function to get a stable and unique output. This happens in winebus. The corner stone of hash inputs is the linux device topology (sysfs path) obtained via udev. Along with all other possible data we feed this into a hash function to obtain our container id. A bunch of extra wine-specific keys needed to be added to carry the necessary metadata from the driver into the ntoskrnl (where it gets written to the property registry of the relevant device). Separate from this we also ingest the linux device topology (sysfs path) in the winepulse driver. In mmdevapi we then use winepulse's sysfs path to find the matching device in the setupapi and query its container id. We now have the same container id in both the device and the MMDevice, allowing applications (in particular Games) to find the MMDevice for a given device. For practical reasons we always resolve the sysfs path to the root device as early as possible. Container ids are meant to be equal for sub devices inside a "container" anyway. -- v4: containerid: helper to generate a containerid from a sysfs path mmdevapi: correctly read and write containerid as clsid blob https://gitlab.winehq.org/wine/wine/-/merge_requests/7238

2 3

Re: [PATCH v3 0/2] MR7341: shdocvw: Remove two functions. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7341

1 0

Re: [PATCH v2 0/1] MR7346: msvcrt/tests: Add missing parameter pmode to _open call (ASan). - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7346

1 0

Re: [PATCH v3 0/2] MR7343: Add some d2d effect stubs. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7343

1 0

Re: [PATCH v4 0/14] MR7329: windowscodecs/tests: Add some query tests with the Unknown reader. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7329

1 0

Re: [PATCH v11 0/4] MR7241: winewayland: Basic input method support. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7241

1 0

Re: [PATCH v2 0/2] MR7338: Add FlushProcessWriteBuffers() tests - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7338

1 0

Re: [PATCH v2 0/5] MR7195: setuapi: Implement a few cfgmgr functions. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7195

1 0

Re: [PATCH v3 0/1] MR7210: setupapi: Use wide character string literals. - approved
by Alexandre Julliard (＠julliard) 17 Feb '25

17 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7210

1 0

[PATCH v2 0/5] MR7347: ntdll: Avoid attach even as dependency if loaded with `DONT_RESOLVE_DLL_REFERENCES`
by Jinoh Kang (＠iamahuman) 17 Feb '25

17 Feb '25

This cleans up `LDR_DONT_RESOLVE_REFS` checks in preparation for !7. -- v2: ntdlll: Remove redundant LDR_DONT_RESOLVE_REFS checks before calling process_attach(). ntdll: Skip DLL initialization and ldr notification entirely if DONT_RESOLVE_DLL_REFERENCES is set. kernel32/tests: Test for unexpected loader notification for import dependency loaded with DONT_RESOLVE_DLL_REFERENCES. kernel32/tests: Test for unexpected LDR_PROCESS_ATTACHED flag in import dependency loaded with DONT_RESOLVE_DLL_REFERENCES. kernel32/tests: Add basic tests for internal flags of modules loaded with DONT_RESOLVE_DLL_REFERENCES. https://gitlab.winehq.org/wine/wine/-/merge_requests/7347

3 6

[PATCH v13 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 17 Feb '25

17 Feb '25

Allow the user to press Ctrl-C to abort lengthy DIR (or DIR /p, etc.) operations. -- v13: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C. https://gitlab.winehq.org/wine/wine/-/merge_requests/7322

2 2

Re: [PATCH v12 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 17 Feb '25

17 Feb '25

On Mon Feb 17 19:22:08 2025 +0000, eric pouech wrote: > thanks for taking the time to update your patch > unfortunately, it fails on wine regression test > the attached patch should solve this > [patch.ctrlc](/uploads/84ae84d1c5cf3d3dfc19904c673bc906/patch.ctrlc) > also, any reason you changed the ctrl event for and automatic reset? > actually, I was puzzled with the previous versions with a manual reset > (my first guess would have been to implement it with an automatic reset) > I tried things like '(dir /s \\\* || echo aaaaa) && dir \*' (and halting > the first dir command with ctrl-c) on native: > * does break the first dir command, > * executes the RHS of || (as the dir command failed because of the > ctrl-c), > * prints the 'aaaaa' string > * executes the RHS of && (as last command of LHS, eg echo, did succeed), > * outputs just the directory header (but nothing else) for the second dir > which fits better with a manual reset (it could be implemented in native > with something else, like a global variable set in the event handler > -requires atomic ops-) Thank you for the patch. I will try to get that integrated sometime today. I'll be traveling for the next few days and will have limited ability during that time to address further concerns. Automatic vs. manual reset were based on my thinking about whether the function WCMD_ctrlc_status would be called more than once per command iteration. If called only once then ownership of the status passes to the caller and thus automatic reset is cleaner. However, thinking further about this, it probably makes sense to switch back to manual reset, in case future callers (i.e. perhaps for different internal commands, etc.) might want to call it more than once per iteration. That, and the fact that there is a manual reset anyway before command launch in the loop toward the end of wmain suggests that a manual reset would be better, so I will switch back when I submit the changes containing your patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94891

1 0

[PATCH v3 0/1] MR7231: rpcrt4: Change some buffer wrap checks to satisfy Clang 20.
by William Horvath (＠whrvt) 17 Feb '25

17 Feb '25

Soon-to-be-released Clang 20 introduced a [`-Wtautological-compare`](https://github.com/llvm/llvm-project/commit/6d34cfac53b993a6cdf3d6669e017eac3a2296c8) warning which these checks trigger. Update them in a similar fashion to the example shown in the [Clang doc](https://github.com/llvm/llvm-project/blob/release/20.x/clang/docs/Rele… (see "To avoid pointer addition overflow..."). -- v3: rpcrt4: Pointer arithmetic fixes (-Wtautological-compare). https://gitlab.winehq.org/wine/wine/-/merge_requests/7231

2 2

Re: [PATCH v2 0/2] MR7341: shdocvw: Remove two functions.
by Elizabeth Figura (＠zfigura) 17 Feb '25

17 Feb '25

v2: Fix authorship... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7341#note_94888

1 0

[PATCH 0/5] MR7347: ntdll: Avoid attach even as dependency if loaded with `DONT_RESOLVE_DLL_REFERENCES`
by Jinoh Kang (＠iamahuman) 17 Feb '25

17 Feb '25

This cleans up `LDR_DONT_RESOLVE_REFS` checks in preparation for !7. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7347

2 5

Re: [PATCH v12 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by eric pouech (＠epo) 17 Feb '25

17 Feb '25

thanks for taking the time to update your patch unfortunately, it fails on wine regression test the attached patch should solve this [patch.ctrlc](/uploads/84ae84d1c5cf3d3dfc19904c673bc906/patch.ctrlc) also, any reason you changed the ctrl event for and automatic reset? actually, I was puzzled with the previous versions with a manual reset (my first guess would have been to implement it with an automatic reset) I tried things like '(dir /s \\\* || echo aaaaa) && dir \*' (and halting the first dir command with ctrl-c) on native: * does break the first dir command, * executes the RHS of || (as the dir command failed because of the ctrl-c), * prints the 'aaaaa' string * executes the RHS of && (as last command of LHS, eg echo, did succeed), * outputs just the directory header (but nothing else) for the second dir which fits better with a manual reset (it could be implemented in native with something else, like a global variable set in the event handler -requires atomic ops-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94879

1 0

[PATCH 0/5] MR7317: Server-side thread priorities implementation (Part 2)
by Marc-Aurel Zent (＠mzent) 17 Feb '25

17 Feb '25

This adds Mach thread priority support (both in the application and realtime band) and recalculates thread priorities when the process priority changes. Part 3, which is still a bit WIP deals with implementing priority boosts (for main threads and threads which are processing window messages), effectively fully replacing https://gitlab.winehq.org/wine/wine/-/merge_requests/1232. Currently the implementation in this MR already technically overrides what https://gitlab.winehq.org/wine/wine/-/merge_requests/1232 does, if it makes sense I can also revert it here. I added a few comments regarding the Mach thread priority API usage, as there is limited documentation available, and much was inferred from the source or by testing. If this is too verbose I can also remove that... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7317

3 9

[PATCH 0/1] MR7346: msvcrt/tests: Add missing parameter pmode to _open call (ASan).
by Bernhard Übelacker (＠bernhardu) 17 Feb '25

17 Feb '25

Documentation states pmode argument is needed when _O_CREAT is used. ``` dlls/msvcrt/tests/i386-windows/msvcrt_test.exe misc ================================================================= ==544==ERROR: AddressSanitizer: stack-buffer-underflow on address 0x0031e7c0 at pc 0x7a1ed844 bp 0x0031e734 sp 0x0031e730 READ of size 4 at 0x0031e7c0 thread T0 0234:fixme:msvcrt:_set_abort_behavior _WRITE_CALL_REPORTFAULT unhandled 0234:fixme:file:server_get_file_info Unsupported info class e #0 0x7a1ed843 in _open .../wine/dlls/msvcrt/file.c:2663:13 #1 0x00482c05 in test__popen .../wine/dlls/msvcrt/tests/misc.c:367:10 #2 0x00482c05 in func_misc .../wine/dlls/msvcrt/tests/misc.c:767:5 #3 0x0052909e in run_test .../wine/include/wine/test.h:765:5 #4 0x0052909e in main .../wine/include/wine/test.h:884:12 #5 0x0052ae2b in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #6 0x7bb8ea3f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b80ea3f) #7 0x7bd0ce82 in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc0ce82) #8 0x7bd404e4 in call_thread_func .../wine/dlls/ntdll\signal_i386.c:524:9 Address 0x0031e7c0 is located in stack of thread T0 at offset 0 in frame #0 0x0047f73f in func_misc .../wine/dlls/msvcrt/tests/misc.c:742 This frame has 15 object(s): [16, 20) 'num.i' (line 682) [32, 36) 'ctx.i' (line 684) [48, 52) 'key.i' (line 685) [64, 464) 'tab.i' (line 440) [528, 1048) 'small_sort.i' (line 442) [1184, 1704) 'small_sort2.i' (line 442) [1840, 2360) 'quick_sort.i' (line 442) [2496, 3520) 'buf.i270' (line 362) [3648, 3652) 'out.i115' (line 260) [3664, 3668) 'out.i91' (line 235) [3680, 3936) 'buf.i53' (line 189) [4000, 4104) 'out.i' (line 158) [4144, 4148) 'rand.i' (line 77) [4160, 5184) 'buf.i' (line 347) [5312, 5316) 'arg_v' (line 744) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-underflow .../wine/dlls/msvcrt/file.c:2663:13 in _open Shadow bytes around the buggy address: 0x0031e500: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0031e580: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0031e600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0031e680: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0031e700: 00 00 00 00 00 00 00 00 f1 f1 04 f3 00 00 00 00 =>0x0031e780: 00 00 00 00 00 00 00 00[f1]f1 f8 f2 f8 f2 f8 f2 0x0031e800: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x0031e880: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x0031e900: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 0x0031e980: f8 f8 f2 f2 f2 f2 f2 f2 f2 f2 f8 f8 f8 f8 f8 f8 0x0031ea00: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==544==ABORTING ``` Today I was not able to get ASan triggered on this, but I guess this may be related to me using currently `-O1` instead of previously `-O2` and some more different compile options. But I thought this might still worth submitting. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7346

3 2

[PATCH v2 0/1] MR7231: rpcrt4, winedbg, winevulkan: Various small fixes for Clang 20 + -Werror.
by William Horvath (＠whrvth) 17 Feb '25

17 Feb '25

I don't think these are serious problems, but Clang 20's defaults (from llvm-mingw nightly) were resulting in build failures with `--enable-werror` due to `-Wtautological-compare` and `-Wunused-function`. I hope that the buffer wrap checking is somewhat idiomatic/standard. If necessary, I can split off the winevulkan change, but it seems minor enough to be grouped in this MR. -- v2: rpcrt4: Pointer arithmetic fixes (-Wtautological-compare). https://gitlab.winehq.org/wine/wine/-/merge_requests/7231

5 5

[PATCH v2 0/2] MR7343: Add some d2d effect stubs.
by Zhiyi Zhang (＠zhiyi) 17 Feb '25

17 Feb '25

For React Native. -- v2: d2d1: Add D2D1Flood effect stub. d2d1: Add D2D1ColorMatrix effect stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/7343

3 3

2025

2024

2023

2022

wine-gitlab