- wine-gitlab - winehq.org

[PATCH 0/1] MR7325: include: Add IWiaDevMgr2 definition in wia_lh.idl.
by Biswapriyo Nath (＠Biswa96) 13 Feb '25

13 Feb '25

Required for https://github.com/msys2/MINGW-packages/issues/17451 Previous attempt !3025 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7325

2 1

Re: [PATCH v2 0/4] MR7146: windows.ui.xaml: Implement IColorHelperStatics::FromArgb().
by Mohamad Al-Jaf (＠maljaf) 13 Feb '25

13 Feb '25

On Thu Feb 13 05:57:40 2025 +0000, Aida Jonikienė wrote: > Does iCUE even work on Wine though? I think it does direct USB device > access for mice/keyboards (and other peripherals) It's also needed by other programs like PowerToys, but iCUE is the easiest to test since it calls it right away. And Wine has some USB support. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7146#note_94422

1 0

[PATCH v22 0/26] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 13 Feb '25

13 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v22: dlls/oleaut32: Bound ITypeLib2_Constructor_SLTG() loop dlls/oleaut32/connpt.c: Make consistent and validate args This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v21 0/25] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 13 Feb '25

13 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v21: dlls/oleaut32/connpt.c: Make consistent and validate args This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

[PATCH v11 0/7] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 12 Feb '25

12 Feb '25

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. For reference, here's how current_modref is being passed around (before this patch): ```mermaid graph TB fii["fixup_imports_ilonly (directly sets current_modref)"] fi["fixup_imports (directly sets current_modref)"] pa["process_attach (directly sets current_modref)"] ld[load_dll] id["import_dll (directly uses current_modref)"] bin["build_import_name (directly uses current_modref)"] foe["find_ordinal_export (uses current_modref for relay)"] ffe["find_forwarded_export (directly uses current_modref)"] fne[find_named_export] MI[MODULE_InitDLL] fii --> ld fi --> id pa --> MI -.-> DllMain id --> bin id --> ld id --> foe id --> fne --> foe --> ffe --> foe ffe --> fne ffe --> bin style DllMain color:red; ``` -- v11: ntdll: Remove superflous NULL check for importer. ntdll: Properly track refcount on dynamic imports of export forwarders. ntdll: Explicitly ignore dynamic (GetProcAddress) importers as relay/snoop user module. ntdll: Properly track refcount on static imports of export forwarders. ntdll: Register module dependency for export forwarders regardless of whether the dependency is already loaded. ntdll: Don't re-add a module dependency if it already exists. https://gitlab.winehq.org/wine/wine/-/merge_requests/7

2 8

[PATCH v20 0/25] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 12 Feb '25

12 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v20: dlls/oleaut32/connpt.c: Make consistent and validate args dlls/oleaut32: Add missing IID case in ITypeLib2::QueryInterface() dlls/oleaut32: Validate TLB_QueryInterface() params dlls/oleaut32: Fix QueryInterface() to meet spec dlls/shell32: Fix IUnknown::QueryInterface() to meet spec dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Validate arguments in ITypeLibComp interface dlls/oleaut32: Validate arguments in ITypeComp interface dlls/oleaut32: Consistently use TLB_get_bstr() dlls/oleaut32: Invert if stmt for clarity dlls/oleaut32: Fix nonsensical memory access in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Avoid ptr arithmetic in MSFT_DoVars() dlls/oleaut32: Avoid ptr arithmetic in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Shink down ITypeLibComp_fnBind() verbosity some dlls/oleaut32: ptr_size should be a ULONG dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() dlls/oleaut32: Factor out TLB_get_funcdesc_by_name() dlls/oleaut32: Validate args of ITypeLib2_fnIsName() dlls/oleaut32: fn(Is|Find)Name should set szNameBuf with correct case dlls/oleaut32: Use consistent param identifiers in fnFindName dlls/oleaut32: Mostly mirror fnFindName impl in typelib.c dlls/oleaut32: Use common and correct identifiers in typelib.c dlls/oleaut32: Consistently use lstrcmpiW() while looking for names This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

Re: [PATCH v2 0/2] MR7321: server: Ignore WM_MOUSEMOVE with raw input / RIDEV_NOLEGACY.
by Paul Gofman (＠gofman) 12 Feb '25

12 Feb '25

Fixes Indiana Jones and the Great Circle showing system mouse cursor along with its own one after alt-tabbing out and in. The game hides the cursor and sets up rawinput w/RIDEV_NOLEGACY in WM_ACTIVATE handling. Then, whenever it receives WM_SETCURSORPOS it shows the cursor back. WM_SETCURSORPOS is triggered by WM_MOUSEMOVE in DefWIndowProc; WM_MOUSEMOVE is not queued with rawinput/RIDEV_NOLEGACY but prior hardware messages and system messages from set_cursor_pos are present in the queue. That's not the case on Windows. That corresponds to the fact that Windows generates those system WM_MOUSEMOVE message "on demand", that is, when Peek or GetMessage is called (see, e. g., [1]). While Wine generates and queues those in internal messages queue in server/queue.c:set_cursor_pos(). My test confirm Windows behaviour. There are corner case specifics which my patch ignores: - If PeekMesage( PM_NOREMOVE) got the message it will be then delivered even after setting up rawinput; - Delivery of SendInput() under these conditions depends on MOUSEEVENTF_MOVE_NOCOALESCE flag (which we currently don't support at all); my patch just drops any hardware WM_MOUSEMOVE messages under these conditions (which corresponds to Windows behaviour without MOUSEEVENTF_MOVE_NOCOALESCE). 1. https://devblogs.microsoft.com/oldnewthing/20130523-00/?p=4273 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7321#note_94406

1 0

[PATCH v10 0/7] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 12 Feb '25

12 Feb '25

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. For reference, here's how current_modref is being passed around (before this patch): ```mermaid graph TB fii["fixup_imports_ilonly (directly sets current_modref)"] fi["fixup_imports (directly sets current_modref)"] pa["process_attach (directly sets current_modref)"] ld[load_dll] id["import_dll (directly uses current_modref)"] bin["build_import_name (directly uses current_modref)"] foe["find_ordinal_export (uses current_modref for relay)"] ffe["find_forwarded_export (directly uses current_modref)"] fne[find_named_export] MI[MODULE_InitDLL] fii --> ld fi --> id pa --> MI -.-> DllMain id --> bin id --> ld id --> foe id --> fne --> foe --> ffe --> foe ffe --> fne ffe --> bin style DllMain color:red; ``` -- v10: ntdll: Remove superflous NULL check for importer. ntdll: Properly track refcount on dynamic imports of export forwarders. ntdll: Explicitly ignore dynamic (GetProcAddress) importers as relay/snoop user module. ntdll: Properly track refcount on static imports of export forwarders. ntdll: Register module dependency for export forwarders regardless of whether the dependency is already loaded. ntdll: Don't re-add a module dependency if it already exists. ntdll: Register module dependency for export forwarders only after successful resolution. https://gitlab.winehq.org/wine/wine/-/merge_requests/7

2 8

Re: [PATCH v4 0/2] MR7312: msvcp: Avoid explicitly aligning fpos_mbstatet. - approved
by Alexandre Julliard (＠julliard) 12 Feb '25

12 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7312

1 0

Re: [PATCH v4 0/1] MR7154: dlls/mshtml/mshtml.inf: add registry associations for .log files - approved
by Alexandre Julliard (＠julliard) 12 Feb '25

12 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7154

1 0

Re: [PATCH v18 0/4] MR4551: Server-side thread priorities implementation (Part 1)
by Jinoh Kang (＠iamahuman) 12 Feb '25

12 Feb '25

On Wed Feb 12 22:26:29 2025 +0000, Marc-Aurel Zent wrote: > Ah I see, thanks for spotting this. I assume this was already fixed by > https://gitlab.winehq.org/wine/wine/-/merge_requests/7310 ? Yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4551#note_94393

1 0

Re: [PATCH v2 0/1] MR7314: configure: macOS is always darwin*. - approved
by Alexandre Julliard (＠julliard) 12 Feb '25

12 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7314

1 0

Re: [PATCH v2 0/1] MR7309: windowscodecs: Simplify a bit FlipRotator_CopyPixels() implementation. - approved
by Alexandre Julliard (＠julliard) 12 Feb '25

12 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7309

1 0

Re: [PATCH v2 0/8] MR7305: windowscodecs/tests: Add some tests for handler objects enumerator. - approved
by Alexandre Julliard (＠julliard) 12 Feb '25

12 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7305

1 0

Re: [PATCH v2 0/2] MR7311: mshtml: Clear the documents list when detaching inner window. - approved
by Alexandre Julliard (＠julliard) 12 Feb '25

12 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7311

1 0

[PATCH 0/2] MR7318: gdiplus: Use correct format guid for .ico files.
by Fabian Maurer (＠DarkShadow44) 12 Feb '25

12 Feb '25

Adapted from https://github.com/reactos/reactos/pull/7714 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7318

3 3

[PATCH v5 0/10] MR6966: windows.web: Partially implement IJsonValueStatics::Parse().
by Mohamad Al-Jaf (＠maljaf) 12 Feb '25

12 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56914 A full implementation should ideally use a JSON library. -- v5: windows.web/tests: Add IJsonValueStatics::Parse() tests. windows.web: Implement IJsonValue::GetBoolean(). windows.web: Implement IJsonValue::GetNumber(). windows.web: Implement IJsonValue::GetString(). windows.web: Add error handling in IJsonValue::GetObject(). windows.web: Add error handling in IJsonValue::GetArray(). windows.web: Partially implement IJsonValueStatics::Parse(). windows.web: Implement IJsonValue::get_ValueType(). windows.web/tests: Add IJsonValue::get_ValueType() tests. windows.web/tests: Remove superfluous cast. https://gitlab.winehq.org/wine/wine/-/merge_requests/6966

3 12

[PATCH v3 0/2] MR7312: msvcp: Avoid explicitly aligning fpos_mbstatet.
by Jacek Caban (＠jacek) 12 Feb '25

12 Feb '25

Based on Piotr's findings. On MSVC i386 targets, structs requiring alignment greater than 4 are never passed by value. Clang follows the same behavior in MSVC mode (see [1] for details and [2] for a follow-up that applies this logic when fields, not necessarily the entire struct, are aligned). A number of ios functions take fpos_mbstatet as an argument and expect it to be passed by value. [1] https://reviews.llvm.org/D72114 [2] https://github.com/llvm/llvm-project/issues/63257 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57817 -- v3: msvcp60: Avoid explicitly aligning structs passed by value. msvcp: Avoid explicitly aligning structs passed by value. https://gitlab.winehq.org/wine/wine/-/merge_requests/7312

3 4

[PATCH v4 0/4] MR7256: ntdll: monotonic_counter and NtQuerySystemTime performance improvements on macOS.
by Marc-Aurel Zent (＠mzent) 12 Feb '25

12 Feb '25

`mach_continuous_approximate_time()` has the necessary precision for win32 ticks and can be up to 4x faster than `mach_continuous_time()`. Also `clock_gettime( CLOCK_REALTIME, &ts )` calls always end up in `__commpage_gettimeofday( struct timeval *tp )`: ``` * frame #0: 0x00007ff806788763 libsystem_kernel.dylib`__commpage_gettimeofday frame #1: 0x00007ff8066709a3 libsystem_c.dylib`gettimeofday + 45 frame #2: 0x00007ff806678b31 libsystem_c.dylib`clock_gettime + 117 ``` These extra calls, setup and converting from one struct format to another costs another 60 CPU cycles and in my testing makes `NtQuerySystemTime` approximately 30% faster as well with this MR. This is a fairly hot code path (especially when using certain out-of-tree in process synchronization patch sets), so probably worth the optimization here. All of these APIs are available since 10.12. -- v4: ntdll: Replace '0' with 'NULL' in gettimeofday() calls. ntdll: Use gettimeofday in system_time_precise on macOS. ntdll: Use __commpage_gettimeofday in NtQuerySystemTime on macOS. ntdll: Always use mach_continuous_approximate_time on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/7256

2 5

[PATCH v3 0/1] MR7154: dlls/mshtml/mshtml.inf: add registry associations for .log files
by Austin English (＠austin987) 12 Feb '25

12 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=25872 -- v3: mshtml: Add registry association for .log files. https://gitlab.winehq.org/wine/wine/-/merge_requests/7154

3 2

[PATCH v2 0/4] MR7312: msvcp: Avoid explicitly aligning fpos_mbstatet.
by Jacek Caban (＠jacek) 12 Feb '25

12 Feb '25

Based on Piotr's findings. On MSVC i386 targets, structs requiring alignment greater than 4 are never passed by value. Clang follows the same behavior in MSVC mode (see [1] for details and [2] for a follow-up that applies this logic when fields, not necessarily the entire struct, are aligned). A number of ios functions take fpos_mbstatet as an argument and expect it to be passed by value. [1] https://reviews.llvm.org/D72114 [2] https://github.com/llvm/llvm-project/issues/63257 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57817 -- v2: msvcp60/tests: Avoid explicitly aligning structs passed by value. msvcp60: Avoid explicitly aligning structs passed by value. msvcp90/tests: Avoid explicitly aligning structs passed by value. msvcp: Avoid explicitly aligning structs passed by value. https://gitlab.winehq.org/wine/wine/-/merge_requests/7312

2 5

Re: [PATCH v18 0/4] MR4551: Server-side thread priorities implementation (Part 1)
by Marc-Aurel Zent (＠mzent) 12 Feb '25

12 Feb '25

On Wed Feb 12 10:42:55 2025 +0000, Jinoh Kang wrote: > This is causing recent kernel32:loader failures Ah I see, thanks for spotting this. I assume this was already fixed by https://gitlab.winehq.org/wine/wine/-/merge_requests/7310 ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4551#note_94350

1 0

[PATCH 0/3] MR7308: windows.storage: Add error handling in IRandomAccessStreamReferenceStatics::CreateFromStream().
by Mohamad Al-Jaf (＠maljaf) 12 Feb '25

12 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56106 I'm not sure why there's a IRandomAccessStreamReferenceStatics interface in WinTypes. Perhaps it was supposed to be queried from one of the classes there? I've seen something similar with other classes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7308

4 5

[PATCH 0/1] MR7312: msvcp: Avoid explicitly aligning fpos_mbstatet.
by Jacek Caban (＠jacek) 12 Feb '25

12 Feb '25

Based on Piotr's findings. On MSVC i386 targets, structs requiring alignment greater than 4 are never passed by value. Clang follows the same behavior in MSVC mode (see [1] for details and [2] for a follow-up that applies this logic when fields, not necessarily the entire struct, are aligned). A number of ios functions take fpos_mbstatet as an argument and expect it to be passed by value. [1] https://reviews.llvm.org/D72114 [2] https://github.com/llvm/llvm-project/issues/63257 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57817 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7312

3 2

[PATCH 0/1] MR7316: win32u: Avoid using uninitialized variable.
by Ruslan Garipov (＠ruslangaripov) 12 Feb '25

12 Feb '25

When dlls/win32u fails to load/initialize the \`FreeType font library', a device context object ends up with the only GDI driver attached -- `null_driver`. The latter implements the `pGetTextMetrics` callback function as do-nothing code. This causes the `NtGdiGetTextMetricsW()` function to fail not modifying fields of its `metrics` argument. In result the `normalize_nonclientmetrics()` ends up with uninitialized `tm` local variable after call to the `get_text_metr_size()` function. Using uninitialized fields of the `TEXTMETRICW` structure gives unpredictable results. This memset(3)'s the `tm` structure before using. After that, even if we failed to load the \`FreeType font library', the \`CaptionHeight', \`SmCaptionHeight' and \`MenuHeight' metrics keep their current values (the `normalize_nonclientmetrics()` function is called after `get_twips_entry()` callback function, thus value of an entry should not be negative). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7316

2 1

2025

2024

2023

2022

wine-gitlab