- wine-gitlab - winehq.org

[PATCH 0/1] MR7266: light.msstyles: Use light blue as hot tracking color instead of grey.
by Zhiyi Zhang (＠zhiyi) 05 Feb '25

05 Feb '25

Fix erwin Data Modeler header text being grey. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7266

2 1

[PATCH 0/1] MR7265: winhttp: Accept server response without status text.
by Hans Leidekker (＠hans) 05 Feb '25

05 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57794 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7265

3 2

Re: [PATCH v3 0/1] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Hans Leidekker (＠hans) 05 Feb '25

05 Feb '25

posix_fallocate() looks like a better fit when increasing allocation size but you'd need to check the file size first, which introduces a race condition. posix_fallocate() will also increase the file size if the file is truncated by another thread. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7115#note_93690

1 0

[PATCH v2 0/1] MR7262: ieframe: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 05 Feb '25

05 Feb '25

-- v2: ieframe: Use wide character string literals. https://gitlab.winehq.org/wine/wine/-/merge_requests/7262

3 2

[PATCH v2 0/4] MR7260: wined3d: Clean up some FFP settings a bit.
by Elizabeth Figura (＠zfigura) 05 Feb '25

05 Feb '25

-- v2: wined3d: Remove FOGVERTEXMODE handling from find_ps_compile_args(). wined3d: Remove the redundant per_vertex_point_size from vs_compile_args. wined3d: Do not toggle point sprite. wined3d: Do not disable point sprite in wined3d_context_gl_apply_blit_state(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7260

4 6

[PATCH 0/3] MR7222: wined3d: Housekeeping for NV12 support.
by Elizabeth Figura (＠zfigura) 05 Feb '25

05 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7222

4 5

[PATCH 0/1] MR7264: prntvpt: Use Windows 10 version numbers.
by Dmitry Timoshkov (＠dmitry) 05 Feb '25

05 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7264

3 2

[PATCH v11 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 05 Feb '25

05 Feb '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v11: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

3 4

[PATCH v4 0/1] MR7252: cmd: add support for right-to-left handle redirection (2<&1)
by Damjan Jovanovic (＠dj) 05 Feb '25

05 Feb '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57795 Closes #57795 -- v4: cmd: add support for right-to-left handle redirection (2<&1) https://gitlab.winehq.org/wine/wine/-/merge_requests/7252

4 4

[PATCH v22 0/2] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 05 Feb '25

05 Feb '25

"DIR /o" (no order specifier after /o) hasn't functioned the same as it does on Windows. This change makes the functionality of /o by itself equivalent to behavior on Windows. -- v22: programs/cmd: Cleanup DIR /O logic and remove @todo_wine@ from working tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/7131

4 5

[PATCH 0/1] MR7263: hhctrl: Fix window class name in HH_CreateHelpWindow.
by Alex Henrie (＠alexhenrie) 05 Feb '25

05 Feb '25

Fixes: 3358d4d3244570637ed9db24c04faa43cee1f75e -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7263

3 2

[PATCH 0/1] MR7262: ieframe: Use wide char string literals.
by Alex Henrie (＠alexhenrie) 05 Feb '25

05 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7262

2 1

[PATCH 0/6] MR7261: Splay tree part 3
by Zhiyi Zhang (＠zhiyi) 05 Feb '25

05 Feb '25

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7261

3 7

[PATCH v3 0/10] MR7254: windowscodecs: Move component info registry key cleanup to a common failure path.
by Nikolay Sivov (＠nsivov) 05 Feb '25

05 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: windowscodecs: Remove redundant guid-to-string conversion when writing readers registration entries. windowscodecs: Fix a typo in metadata readers registration helper. windowscodecs/metadata: Add a stub for WICIfdMetadataWriter. windowscodecs/metadata: Add a stub for WICExifMetadataWriter. windowscodecs/metadata: Add a stub for WICGpsMetadataWriter. windowscodecs/metadata: Add a stub for WICUnknownMetadataWriter. windowscodecs/metadata: Add registration information for the "Unknown" writer. windowscodecs: Add a stub for IWICMetadataWriterInfo. windowscodecs: Move an hkey handle to the component info base structure. windowscodecs: Move component info registry key cleanup to a common failure path. https://gitlab.winehq.org/wine/wine/-/merge_requests/7254

4 13

[PATCH v20 0/3] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 05 Feb '25

05 Feb '25

"DIR /o" (no order specifier after /o) hasn't functioned the same as it does on Windows. This change makes the functionality of /o by itself equivalent to behavior on Windows. -- v20: programs/cmd: Remove @todo_wine@ from working tests. programs/cmd: Cleanup DIR /O logic. programs/cmd: Add tests patch from @epo. https://gitlab.winehq.org/wine/wine/-/merge_requests/7131

2 3

Re: [PATCH v3 0/3] MR7256: ntdll: monotonic_counter and NtQuerySystemTime performance improvements on macOS.
by Marc-Aurel Zent (＠mzent) 04 Feb '25

04 Feb '25

On Tue Feb 4 17:55:14 2025 +0000, Tim Clem wrote: > I think this calls for a quick comment (or at least a note in the commit > message) as to why we're using this function. Added a comment, explaining the rationale there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7256#note_93649

1 0

[PATCH v2 0/3] MR7256: ntdll: monotonic_counter and NtQuerySystemTime performance improvements on macOS.
by Marc-Aurel Zent (＠mzent) 04 Feb '25

04 Feb '25

`mach_continuous_approximate_time()` has the necessary precision for win32 ticks and can be up to 4x faster than `mach_continuous_time()`. Also `clock_gettime( CLOCK_REALTIME, &ts )` calls always end up in `__commpage_gettimeofday( struct timeval *tp )`: ``` * frame #0: 0x00007ff806788763 libsystem_kernel.dylib`__commpage_gettimeofday frame #1: 0x00007ff8066709a3 libsystem_c.dylib`gettimeofday + 45 frame #2: 0x00007ff806678b31 libsystem_c.dylib`clock_gettime + 117 ``` These extra calls, setup and converting from one struct format to another costs another 60 CPU cycles and in my testing makes `NtQuerySystemTime` approximately 30% faster as well with this MR. This is a fairly hot code path (especially when using certain out-of-tree in process synchronization patch sets), so probably worth the optimization here. All of these APIs are available since 10.12. -- v2: ntdll: Replace '0' with 'NULL' in gettimeofday() calls. ntdll: Use __commpage_gettimeofday in NtQuerySystemTime on macOS. ntdll: Always use mach_continuous_approximate_time on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/7256

2 4

[PATCH 0/2] MR7256: ntdll: monotonic_counter and NtQuerySystemTime performance improvements on macOS.
by Marc-Aurel Zent (＠mzent) 04 Feb '25

04 Feb '25

`mach_continuous_approximate_time()` has the necessary precision for win32 ticks and can be up to 4x faster than `mach_continuous_time()`. Also `clock_gettime( CLOCK_REALTIME, &ts )` calls always end up in `__commpage_gettimeofday( struct timeval *tp )`: ``` * frame #0: 0x00007ff806788763 libsystem_kernel.dylib`__commpage_gettimeofday frame #1: 0x00007ff8066709a3 libsystem_c.dylib`gettimeofday + 45 frame #2: 0x00007ff806678b31 libsystem_c.dylib`clock_gettime + 117 ``` These extra calls, setup and converting from one struct format to another costs another 60 CPU cycles and in my testing makes `NtQuerySystemTime` approximately 30% faster as well with this MR. This is a fairly hot code path (especially when using certain out-of-tree in process synchronization patch sets), so probably worth the optimization here. All of these APIs are available since 10.12. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7256

5 12

Re: [PATCH v3 0/1] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Stéphane Bacri (＠fr33z00) 04 Feb '25

04 Feb '25

@julliard Thanks for taking the time to review. About the file size increase, it sounds like a direct consequence of what this function is supposed to do, since it shall allocate some space for a file. Can you detail your thoughts about it? About the tests, I guess you mean unit tests, right? Or did you mean tests on the parameters (say check that size is aligned with cluster size, or > to current size)? In the first case, I'm gonna try to add something, as digging a bit more the code showed that there is a basis. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7115#note_93641

1 0

Re: [PATCH v7 0/1] MR7068: vbscript: class single line multivar - approved
by Alexandre Julliard (＠julliard) 04 Feb '25

04 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7068

1 0

Re: [PATCH v9 0/3] MR7158: wine.inf: Add UBR key - approved
by Alexandre Julliard (＠julliard) 04 Feb '25

04 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

1 0

Re: [PATCH v2 0/1] MR7253: po: Update some Russian strings. - approved
by Alexandre Julliard (＠julliard) 04 Feb '25

04 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7253

1 0

Re: [PATCH v4 0/1] MR7229: ntdll: Stub NtQuerySystemInformation(SystemLeapSecondInformation). - approved
by Alexandre Julliard (＠julliard) 04 Feb '25

04 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7229

1 0

[PATCH 0/4] MR7260: wined3d: Clean up some FFP settings a bit.
by Elizabeth Figura (＠zfigura) 04 Feb '25

04 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7260

3 5

[PATCH v2 0/9] MR7254: windowscodecs: Move component info registry key cleanup to a common failure path.
by Nikolay Sivov (＠nsivov) 04 Feb '25

04 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: windowscodecs: Fix a typo in metadata readers registration helper. windowscodecs/metadata: Add a stub for WICIfdMetadataWriter. windowscodecs/metadata: Add a stub for WICExifMetadataWriter. windowscodecs/metadata: Add a stub for WICGpsMetadataWriter. windowscodecs/metadata: Add a stub for WICUnknownMetadataWriter. windowscodecs/metadata: Add registration information for the "Unknown" writer. windowscodecs: Add a stub for IWICMetadataWriterInfo. windowscodecs: Move an hkey handle to the component info base structure. windowscodecs: Move component info registry key cleanup to a common failure path. https://gitlab.winehq.org/wine/wine/-/merge_requests/7254

4 11

2025

2024

2023

2022

wine-gitlab