- wine-gitlab - winehq.org

[PATCH v3 0/9] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 30 Jan '25

30 Jan '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v3: dlls/oleaut32: Implement SetHelpStringContext() dlls/oleaut32: Add DeleteTypeInfo() base-cases in typelib.c dlls/oleaut32: Allow TLB_get_typeinfo_by_name() to also return the index dlls/oleaut32: Disambiguate pIndex in typelib.c dlls/oleaut32: Avoid possible infinite loops and invalid mem access dlls/oleaut32: Simplify SLTG_DoRefs() readability dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND dlls/oleaut32: Consistently use lstrcmpiW() while looking for names dlls/oleaut32: Simplify loop in ITypeLib2_Constructor_MSFT() https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

3 10

[PATCH 0/1] MR7229: ntdll: Stub NtQuerySystemInformation(SystemLeapSecondInformation).
by Hans Leidekker (＠hans) 30 Jan '25

30 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7229

4 3

[PATCH 0/1] MR7228: compstui: Add more string resources.
by Dmitry Timoshkov (＠dmitry) 30 Jan '25

30 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7228

3 2

[PATCH v2 0/1] MR7174: mfplat: Introduce a MF startup count.
by Conor McCarthy (＠cmccarthy) 30 Jan '25

30 Jan '25

In cases where MF is already shut down, simply forwarding MFShutdown() to RtwqShutdown() will corrupt the Rtwq lock count if async result objects still exist, because they hold a lock. JR East Train Simulator does this. -- v2: mf: Release the sample if stream sink processing fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/7174

3 2

[PATCH v9 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 30 Jan '25

30 Jan '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v9: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

3 5

[PATCH v8 0/3] MR7158: wine.inf.in: Add UBR key
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Jan '25

30 Jan '25

Required by Logitech G Hub -- v8: twinapi/tests: Fix broken registry query. https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

3 4

Re: [PATCH v7 0/3] MR7158: wine.inf.in: Add UBR key
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Jan '25

30 Jan '25

turns out twinapi test failed because of a silly mistake in the test lol -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7158#note_93247

1 0

[PATCH v5 0/2] MR7158: wine.inf.in: Add UBR key
by Etaash Mathamsetty (＠etaash.mathamsetty) 29 Jan '25

29 Jan '25

Required by Logitech G Hub -- v5: winecfg: add support for UBR key. https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

3 3

[PATCH v4 0/1] MR7158: wine.inf.in: Add UBR key
by Etaash Mathamsetty (＠etaash.mathamsetty) 29 Jan '25

29 Jan '25

Required by Logitech G Hub -- v4: wine.inf.in: Add UBR key. https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

3 2

[PATCH v8 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 29 Jan '25

29 Jan '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v8: ntdll: Update NtQueryDirectoryFile to purge cache if scan is reset with a new mask ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

4 22

Re: [PATCH v3 0/5] MR7225: msvcr120: Add _FCbuild, cimag, cimags and crealf implementation. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7225

1 0

Re: [PATCH v2 0/1] MR7220: winex11.drv: Update window shape before putting surface image. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7220

1 0

Re: [PATCH v3 0/1] MR7172: win32u: Implement a couple of syscalls. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7172

1 0

Re: [PATCH v3 0/2] MR7224: wbemprox: Implement Win32_PnPEntity.Service. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7224

1 0

Re: [PATCH v2 0/1] MR7218: crypt32/tests: Avoid use after free in testEmptyStore(). - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7218

1 0

Re: [PATCH v2 0/8] MR7215: crypt32: Improve support for CMSGs. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7215

1 0

Re: [PATCH v2 0/1] MR7207: d3d9: Fix IUnknown delegation in IDirect3DDevice9On12. - approved
by Alexandre Julliard (＠julliard) 29 Jan '25

29 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7207

1 0

Re: [PATCH v7 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

I have cleaned up the patches and created !7225 since I can't push to your branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109#note_93216

1 0

Re: [PATCH v7 0/85] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf - closed
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

This merge request was closed by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109

1 0

Re: [PATCH v2 0/5] MR7225: msvcr120: Add _FCbuild, cimag, cimags and crealf implementation. - approved
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

This merge request was approved by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7225

1 0

Re: [PATCH v8 0/1] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 29 Jan '25

29 Jan '25

OK, I just submitted an updated change. I spent a lot of time yesterday and today getting the logic right, testing various /O options, side by side with Windows. This looks right to me. I did abstain from cleaning up the use of the global variables. This change at least does not add any. Cleaning those up will be an exercise for (another person at) another time. Let me know what you think of the change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_93212

1 0

[PATCH 0/5] MR7225: msvcr120: Add _FCbuild, cimag, cimags and crealf implementation.
by Piotr Caban (＠piotr) 29 Jan '25

29 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7225

4 6

[PATCH 0/1] MR7220: winex11.drv: Update window shape before putting surface image.
by Paul Gofman (＠gofman) 29 Jan '25

29 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7220

4 7

[PATCH v2 0/1] MR7223: urlmon: Make security zone names and descriptions translatable.
by Alex Henrie (＠alexhenrie) 29 Jan '25

29 Jan '25

GetZoneAttributes ignores the names and descriptions in the registry for the first five zones. Do the same in Wine. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=27245 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/7084 -- v2: urlmon: Make security zone names and descriptions translatable. https://gitlab.winehq.org/wine/wine/-/merge_requests/7223

3 2

[PATCH v4 0/4] MR7216: winebth.sys part 3: Introduce IOCTLs related to radio discoverability, connectability and device inquiry.
by Vibhav Pant (＠vibhavp) 29 Jan '25

29 Jan '25

The Windows Bluetooth stack uses private IOCTLs in order to set the [discoverability](https://learn.microsoft.com/en-us/windows/win32/api/blueto… and [connectability](https://learn.microsoft.com/en-us/windows/win32/api/bluetoo… status of a local radio, and to start/stop the device inquiry procedure. This MR introduces 3 wine-specific IOCTL codes for the same purposes, as most applications seem to the Win32 API itself for these operations: * IOCTL_WINBTH_RADIO_SET_FLAG * IOCTL_WINEBTH_RADIO_START_DISCOVERY * IOCTL_WINEBTH_RADIO_STOP_DISCOVERY -- v4: winebth.sys: Call bluez_watcher_close as part of bluetooth_shutdown. https://gitlab.winehq.org/wine/wine/-/merge_requests/7216

3 5

2025

2024

2023

2022

wine-gitlab