- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR7156: winex11: Keep track of whether the window has been moved offscreen by the WM. - approved
by Alexandre Julliard (＠julliard) 21 Jan '25

21 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7156

1 0

Re: [PATCH v2 0/1] MR7159: ntdll: Don't wow64-offset NULL TEB. - approved
by Alexandre Julliard (＠julliard) 21 Jan '25

21 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7159

1 0

[PATCH v2 0/1] MR7161: dinput: Clamp FFB effect report value to the field range.
by Oleg Makarenko (＠JacKeTUs) 21 Jan '25

21 Jan '25

If application sends out-of-range values for FFB effects, they become -1, which is undesireable, when -1 is in the physical range of the field and being sent to the device. This patch fixes it, clamping values to the field range. Clamping was earlier implemented [here](https://gitlab.winehq.org/wine/wine/-/blob/wine-6.19/dlls/dinput/effe… in 6.19. Windows does this clamping silently, and doesn't fail `SetParameters` call when values is out of range. Affected application is Assetto Corsa EVO, which with default settings sends out ConstantForce magnitude under/over [documented](https://learn.microsoft.com/en-us/previous-versions/ms835644(v=… \[-10000, 10000\]. [Link to the discussion with some investigation on Steam](https://steamcommunity.com/app/3058630/discussions/0/756142145462617…. In this submission scaling and clamping were moved to the separate `scale_and_clamp_value` function, which is now called every time from `set_parameter_value`. To avoid regression with sending `-1` for the infinite duration effects, separate function `set_parameter_value_no_scaling` created. Gain values in `hid_joystick_send_device_gain` are also scaled and clamped. -- v2: dinput: Clamp FFB effect report value to the field range. https://gitlab.winehq.org/wine/wine/-/merge_requests/7161

5 6

[PATCH 0/1] MR7156: winex11: Keep track of whether the window has been moved offscreen by the WM.
by Rémi Bernon (＠rbernon) 21 Jan '25

21 Jan '25

Instead of relying on the current X window rect, which may be offscreen for other reasons. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57689 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7156

2 2

[PATCH 0/1] MR7161: dinput: Clamp FFB effect report value to the field range.
by Oleg Makarenko (＠JacKeTUs) 21 Jan '25

21 Jan '25

If application sends out-of-range values for FFB effects, they become -1, which is undesireable, when -1 is in the physical range of the field and being sent to the device. This patch fixes it, clamping values to the field range. Clamping was earlier implemented [here](https://gitlab.winehq.org/wine/wine/-/blob/wine-6.19/dlls/dinput/effe… in 6.19. Windows does this clamping silently, and doesn't fail `SetParameters` call when values is out of range. Affected application is Assetto Corsa EVO, which with default settings sends out ConstantForce magnitude under/over [documented](https://learn.microsoft.com/en-us/previous-versions/ms835644(v=… \[-10000, 10000\]. [Link to the discussion with some investigation on Steam](https://steamcommunity.com/app/3058630/discussions/0/756142145462617…. In this submission scaling and clamping were moved to the separate `scale_and_clamp_value` function, which is now called every time from `set_parameter_value`. To avoid regression with sending `-1` for the infinite duration effects, separate function `set_parameter_value_no_scaling` created. Gain values in `hid_joystick_send_device_gain` are also scaled and clamped. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7161

3 2

[PATCH 0/1] MR7159: ntdll: Don't wow64-offset NULL TEB.
by Paul Gofman (＠gofman) 21 Jan '25

21 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57690 Fixes a regression introduced by commit de23dfc5b1eac6e111cd66540ad9a97b61a3fe28. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7159

3 3

[PATCH v2 0/1] MR7158: wine.inf.in: Add UBR key
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Jan '25

20 Jan '25

Required by Logitech G Hub -- v2: wine.inf.in: Add UBR key. https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

3 4

[PATCH v2 0/2] MR7151: server: Don't send WM_MOUSEMOVE for zero movement in queue_mouse_message().
by Paul Gofman (＠gofman) 20 Jan '25

20 Jan '25

-- v2: server: Don't send WM_MOUSEMOVE for zero movement in queue_mouse_message(). win32u: Generate mouse events in the server when releasing capture. https://gitlab.winehq.org/wine/wine/-/merge_requests/7151

4 8

[PATCH v2 0/1] MR7157: winex11: Only erase the desktop window pixels on expose events.
by Rémi Bernon (＠rbernon) 20 Jan '25

20 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57665 --- The issue is that The Medium launcher uses a dialog window procedure, and implements its background by doing a StretchBlt call on WM_PAINT in the dialog procedure call, which happens before the window message loop. It then itself calls InvalidateRect(hwnd, NULL, 0), which queues a WM_PAINT as well but with only the RDW_INVALIDATE flag. Next, when the window message loop is executed, the WM_PAINT message is being processed as it should, but as we've invalidate the window with RDW_ERASE ourselves from the expose event, the WM_NCPAINT handler erases the entire window, clearing the pixels that the launcher has just painted. This regressed since the window surface clipping region logic changed, as the expose event handling was previously not calling `NtUserRedrawWindow` on windows with a surface and without a clipping region. The clipping region was also previously not always set, or set later, and we're setting it more consistently since 51b16963f6e0e8df43118deac63f640aee4698b7, even when it matches the window rect, for compatibility with some old wineandroid logic (where I believe it was used to clip window surfaces to their proper sizes). -- v2: winex11: Only erase the desktop window pixels on expose events. https://gitlab.winehq.org/wine/wine/-/merge_requests/7157

2 2

[PATCH 0/1] MR7157: winex11: Use RDW_ERASENOW flag in expose events.
by Rémi Bernon (＠rbernon) 20 Jan '25

20 Jan '25

This ensures that the induced non-client redraw are sent and executed right away, and before the WM_PAINT messages are sent. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57665 --- The issue is that The Medium launcher uses a dialog window procedure, and implements its background by doing a StretchBlt call on WM_PAINT in the dialog procedure call, which happens before the window message loop. It then itself calls InvalidateRect(hwnd, NULL, 0), which queues a WM_PAINT as well but with only the RDW_INVALIDATE flag. Next, when the window message loop is executed, the WM_PAINT message is being processed as it should, but as we've invalidate the window with RDW_ERASE ourselves from the expose event, the WM_NCPAINT handler erases the entire window, clearing the pixels that the launcher has just painted. Using RDW_ERASENOW we make sure that the erase happens right away on expose, and before the WM_PAINT message is being processed. This regressed since the window surface clipping region logic changed, as the expose event handling was previously not calling `NtUserRedrawWindow` on windows with a surface and without a clipping region. The clipping region was also previously not always set, or set later, and we're setting it more consistently since 51b16963f6e0e8df43118deac63f640aee4698b7, even when it matches the window rect, for compatibility with some old wineandroid logic (where I believe it was used to clip window surfaces to their proper sizes). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7157

2 2

Re: [PATCH v4 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 20 Jan '25

20 Jan '25

Tests run via your command line fail to run for me, certainly due to lack of dependencies in my build. I'll work on addressing those, to see if I can get the tests to run. ./wine programs/winetest/x86_64-windows/winetest.exe -o - cmd.exe 0050:err:vulkan:vulkan_init_once Wine was built without Vulkan support. 00c4:err:ntoskrnl:ZwLoadDriver failed to create driver L"\\Registry\\Machine\\System\\CurrentControlSet\\Services\\winebth": c00000e5 003c:fixme:service:scmdatabase_autostart_services Auto-start service L"winebth" failed to start: 1359 wine: failed to open "programs/winetest/x86_64-windows/winetest.exe": c0000135 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_92190

1 0

[PATCH v2 0/5] MR7150: crypt32: Do not delete root certs which were not imported from host.
by Paul Gofman (＠gofman) 19 Jan '25

19 Jan '25

Currently the logic of syncing of certificates with host effectively assumes that all the root certificates come from host and doesn't mind the certificates added by the app (those erroneously get deleted during host sync). That fixes Battle.net being unable to complete game installs / update after Battle net update on 14 Jan 2025. This is not for code freeze obviously. The issue is that Battle.net fails to verify certificate chain which depends on an ephemeral certificate marked valid for DNS:localbattle.net (which resolves to 127.0.0.1) server auth. The certificate is self signed and is added to system root storage by Battle.bet setup (and also possibly later if it is missing). The addition of certificate to system root storage works per se, but then upon syncing host root certificates (in another process or new prefix start) the certificate gets wiped from registry. -- v2: crypt32: Do not delete root certs which were not imported from host in sync_trusted_roots_from_known_locations(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7150

4 8

[PATCH 0/1] MR7109: Added missing functions _FCbuild, cimag, crealf and cimagf
by Stéphane Bacri (＠fr33z00) 19 Jan '25

19 Jan '25

This MR intends to add the complex numbers related functions: * cimag * _FCbuild * crealf * cimagf These functions are defined in dlls/msvcr120/math.c and mapped in dlls/msvcr120/msvcr120.spec and dlls/ucrbase/ucrbase.spec. The related tests were added in dlls/mscr120/tests/msvcr120.c and result were checked. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7109

4 3

[PATCH 0/1] MR7153: msvcrt: fixed potential syntax misprint
by Herman Semenov (＠GermanAizek) 19 Jan '25

19 Jan '25

Is this a mistake? are the brackets very strangely located, or was the condition accidentally deleted there? Maybe legacy code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7153

4 3

Re: [PATCH v4 0/4] MR5830: dxgi: Fix some d3d12 swapchain issues.
by Giovanni Mascellani (＠giomasce) 17 Jan '25

17 Jan '25

On Fri Jun 21 06:04:13 2024 +0000, Conor McCarthy wrote: > I replaced this with a wait for the blit before returning from > `d3d12_swapchain_present()`. After a call to Present() returns, the > client can render to the next buffer in sequence, so we must wait for > completion of the blit read of that buffer. The old version using > `vkAcquireNextImageKHR()` is not strict enough. HZD with vsync has frame > pacing issues in some parts of the benchmark even on the old > implementation, and this makes it a little bit worse. We can't really > avoid that though, and the best fix is to improve frame times in vkd3d. Sorry it took so much time to react, but I don't think that's correct, at least not in general. I did some research on how maximum frame latency and `Present()` timing is supposed to work and this is what I could gather so far: * I'll assume that we're using a flip presentation model (the only one that is allowed for D3D12; the blt model is restricted to D3D11 and previous) and assume that `Present()` is always called with sync interval 1. * Partially repealing an earlier comment by me, it doesn't seem that `Present()` cares at all about `BufferCount`. The swapchain images are basically treated like a ring buffer of `BufferCount` elements. Each time `Present()` is called a presentation operation is queued; each time a presentation operation is dequeued (following the timing expressed by the sync interval), the next image is selected from the ring buffer (adding one to the read counter and wrapping it around) and presented. If you didn't synchronize correctly and write on an image before it is presented (or even while it is presented), bad for you, but the presentation engine doesn't care. You'll probably miss frames or have tearing. * So your only hope to not step on the presentation engine's feet is to make judicious use of frame latency commands. There the swapchain behaves differently depending of whether it was created with `DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT` or not. * The legacy behavior is without `DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT`. In this case the swapchain automatically manages the frame latency waits, so the application can just relay on `Present()` waiting appropriately. The maximum latency has to be set with `IDXGIDevice1::SetMaximumFrameLatency()`, but `IDXGIDevice` is not available for D3D12 devices, as far as I can tell; so we can only keep the default value, which is 3 in the docs (and that value aligns with my timing observations). In practice not having `DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT` isn't a lot different than having it: the only difference is that at the end of each `Present()` call a wait on the latency waitable is done by D3D12 on behalf of the client (other minor differences is that you can't retrive the waitable itself or change the latency number). * Instead, if the swapchain is created with `DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT` then some cooperation from the application is expected: the application has to retrieve the waitable object (which in practice behaves like a semaphore, even if the docs never seem to explicitly mention that). This is already tested in `test_frame_latency_event()`, even if the waitable is not an event: the semaphore starts at the default maximum latency (which is 1) and is released each time a frame is presented (for real, not when `Present()` is called). When `IDXGISwapChain2::SetMaximumFrameLatency()` and the new value is larger than the previous one, then the semaphore is released a number of times equal to the difference between the new and old value. If the new value is smaller, the semaphore is not touched (i.e., `SetMaximumFrameLatency()` never waits). The application is supposed to wait on the semaphore before starting rendering; if it doesn't, `Present()` will happily keep queuei ng presentation operations even if the ring buffer overflows and/or the set maximum latency is exceeded. I wrote an alternative implementation which should fix the same problem. It's in !7152 (it replaces only the last commit here, the first three make sense on their own). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5830#note_92165

1 0

Re: [PATCH v4 0/4] MR5830: dxgi: Fix some d3d12 swapchain issues.
by Giovanni Mascellani (＠giomasce) 17 Jan '25

17 Jan '25

On Fri Jun 21 06:04:13 2024 +0000, Conor McCarthy wrote: > I do see a small but measurable performance gain in HZD. It's only 0.7%, > but that shoud be weighed that against the very simple change needed to > gain it. That's indeed a lot for such a simple change. Good! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5830#note_92164

1 0

[PATCH 0/1] MR7151: server: Don't send WM_MOUSEMOVE for zero movement in queue_mouse_message().
by Paul Gofman (＠gofman) 17 Jan '25

17 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7151

3 4

[PATCH 0/5] MR7150: crypt32: Do not delete root certs which were not imported from host.
by Paul Gofman (＠gofman) 16 Jan '25

16 Jan '25

Currently the logic of syncing of certificates with host effectively assumes that all the root certificates come from host and doesn't mind the certificates added by the app (those erroneously get deleted during host sync). That fixes Battle.net being unable to complete game installs / update after Battle net update on 14 Jan 2025. This is not for code freeze obviously. The issue is that Battle.net fails to verify certificate chain which depends on an ephemeral certificate marked valid for DNS:localbattle.net (which resolves to 127.0.0.1) server auth. The certificate is self signed and is added to system root storage by Battle.bet setup (and also possibly later if it is missing). The addition of certificate to system root storage works per se, but then upon syncing host root certificates (in another process or new prefix start) the certificate gets wiped from registry. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7150

3 6

Re: [PATCH v3 0/1] MR7149: gdiplus: Check for MapFont result in generate_font_link_info. - approved
by Alexandre Julliard (＠julliard) 16 Jan '25

16 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7149

1 0

Re: [PATCH v3 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by eric pouech (＠epo) 16 Jan '25

16 Jan '25

from the top directory where you compiled Wine ./wine programs/winetest/x86_64-windows/winetest.exe -o - cmd.exe -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_92048

1 0

Re: [PATCH v3 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 16 Jan '25

16 Jan '25

Thank you. I know nothing about running these tests. I just opened a command prompt via "wine cmd" and then just launched the test .cmd file. When I have some time I'll research how to run the tests, assuming that it's in the dev docs here somewhere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_92045

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Patrick Laimbock (＠Patrick) 16 Jan '25

16 Jan '25

> I don't want to break something else this late. That makes total sense :smiley: I'm happy to test anything so feel free to ping me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_92038

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Rémi Bernon (＠rbernon) 16 Jan '25

16 Jan '25

On Thu Jan 16 11:31:22 2025 +0000, Patrick Laimbock wrote: > Hi Rémi. With the change below (bug51357.patch) from > https://bugs.winehq.org/show_bug.cgi?id=51357 the wrong mouse offset is > fixed in the VST plugin's main window titled 'Spire'. But, e.g. clicking > the 'menu' button shows the menu in the wrong place. See screenshot. The > menu should appear below the 'menu' button (top row) in the window > titled 'Spire'. So the change above does not fix the issue but hopefully > it gives you an idea what the problem might be. If you need more > information please let me know. Thanks! > [bug51357.patch](/uploads/dea8a1e711846f7e7642c16eacd284b4/bug51357.patch) > ![Screenshot_From_2025-01-16_11-49-56](/uploads/decbb70d2abc1b99d3fd28e0b6382080/Screenshot_From_2025-01-16_11-49-56.png) Thank you! Yes, I think we could consider doing something like and use window-relative coordinates all the time, now that we're better tracking the X window tree position, and stopped using XTranslateCoordinates. It would have to wait until Wine 10 is released though, I don't want to break something else this late. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_92037

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Patrick Laimbock (＠Patrick) 16 Jan '25

16 Jan '25

On Sat Dec 7 21:33:25 2024 +0000, Rémi Bernon wrote: > I don't know for sure but there are probably some ways to make it work. > It works already more or less well with embedded systray windows, so > maybe doing something similar could be enough. > Alternatively mouse input is mapped in `map_event_coords` and we > preferred event root/x_root/y_root values when available because it > avoided some inconsistencies when moving windows, but window positioning > has been refactored lately, and maybe this isn't necessary anymore. > Using window-relative mouse input could solve your case too (or we could > also perhaps consider a winecfg option to prefer it over absolute positions). Hi Rémi. With the change below (bug51357.patch) from https://bugs.winehq.org/show_bug.cgi?id=51357 the wrong mouse offset is fixed in the VST plugin's main window titled 'Spire'. But, e.g. clicking the 'menu' button shows the menu in the wrong place. See screenshot. The menu should appear below the 'menu' button (top row) in the window titled 'Spire'. So the change above does not fix the issue but hopefully it gives you an idea what the problem might be. If you need more information please let me know. Thanks! [bug51357.patch](/uploads/dea8a1e711846f7e7642c16eacd284b4/bug51357.patch) ![Screenshot_From_2025-01-16_11-49-56](/uploads/decbb70d2abc1b99d3fd28e0b6382080/Screenshot_From_2025-01-16_11-49-56.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_92034

1 0

Re: [PATCH v3 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by eric pouech (＠epo) 16 Jan '25

16 Jan '25

if you can start cmd.exe and notepad.exe from your installation, that should be sufficient to run the tests are you running the tests with winetest or make test? the later can sometimes have issues with some symlinks from the build directory. using the former is safer -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_92028

1 0

2025

2024

2023

2022

wine-gitlab