- wine-gitlab - winehq.org

Re: [PATCH v3 0/1] MR7047: xmllite/tests: Avoid buffer overflow by using LONG_PTR. (ASan)
by Alfred Agrell (＠Alcaro) 19 Dec '24

19 Dec '24

I'd change line 581 to something with the high half nonzero (-1, for example), to verify how many bytes native actually writes. (It writes a LONG_PTR, I checked.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7047#note_90899

1 0

Re: [PATCH v3 0/1] MR7047: xmllite/tests: Avoid buffer overflow by using LONG_PTR. (ASan)
by Bernhard Übelacker (＠bernhardu) 19 Dec '24

19 Dec '24

v2: - Instead of casting to the smaller enum type do reserve memory of size LONG_PTR in the test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7047#note_90898

1 0

[PATCH v2 0/1] MR7047: xmllite/tests: Avoid buffer overflow by using LONG_PTR. (ASan)
by Bernhard Übelacker (＠bernhardu) 19 Dec '24

19 Dec '24

This appeared by running tests with PE-side ASan enabled, just with x86_64. The enum DtdProcessing seems to have just a size of four bytes, but dereferencing `LONG_PTR *value` writes 8 bytes. ``` ================================================================= ==560==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ff8c0 at pc 0x6ffff7b33f83 bp 0x7ffffe1fed00 sp 0x7ffffe1fed48 WRITE of size 8 at 0x7ffffe1ff8c0 thread T0 05c0:fixme:file:server_get_file_info Unsupported info class e #0 0x6ffff7b33f82 in xmlreader_GetProperty .../wine/dlls/xmllite/reader.c:2807:20 #1 0x000140002254 in IXmlReader_GetProperty .../obj\include\xmllite.h:331:12 #2 0x000140002254 in test_reader_create .../wine/dlls/xmllite/tests/reader.c:582:10 #3 0x000140002254 in func_reader .../wine/dlls/xmllite/tests/reader.c:2676:5 #4 0x00014006bad1 in run_test .../wine/include/wine/test.h:765:5 #5 0x00014006bad1 in main .../wine/include/wine/test.h:884:12 #6 0x00014006d94f in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #7 0x6ffffbdc4808 in BaseThreadInitThunk .../wine/dlls/kernel32\thread.c:61:5 #8 0x6ffffad1fa1a in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17000fa1a) Address 0x7ffffe1ff8c0 is located in stack of thread T0 at offset 2784 in frame #0 0x00014000100f in func_reader .../wine/dlls/xmllite/tests/reader.c:2675 This frame has 113 object(s): [32, 36) 'd.i439.i' (line 824) [48, 52) 'd.i412.i' (line 824) [64, 68) 'd.i385.i' (line 824) [80, 84) 'd.i358.i' (line 824) ... [2672, 2676) 'nodetype.i2' (line 620) [2688, 2696) 'resolver.i' (line 515) [2720, 2728) 'unk.i' (line 516) [2752, 2760) 'reader.i' (line 517) [2784, 2788) 'dtd.i' (line 518) <== Memory access at offset 2784 partially overflows this variable [2800, 2804) 'nodetype.i' (line 519) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/dlls/xmllite/reader.c:2807:20 in xmlreader_GetProperty Shadow bytes around the buggy address: 0x7ffffe1ff600: f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 0x7ffffe1ff680: f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 f8 f2 0x7ffffe1ff700: f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 f8 f2 f8 f2 f8 f2 0x7ffffe1ff780: f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 0x7ffffe1ff800: f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 00 f2 f2 f2 =>0x7ffffe1ff880: 00 f2 f2 f2 00 f2 f2 f2[04]f2 04 f3 00 00 00 00 0x7ffffe1ff900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffb00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==560==ABORTING 05c0:fixme:kernelbase:AppPolicyGetProcessTerminationMethod FFFFFFFFFFFFFFFA, 00007FFFFEA8FE80 make: *** [Makefile:471569: dlls/xmllite/tests/x86_64-windows/reader.ok] Fehler 1 ``` -- v2: xmllite/tests: Avoid buffer overflow by using LONG_PTR. (ASan) https://gitlab.winehq.org/wine/wine/-/merge_requests/7047

2 1

[PATCH 0/1] MR7048: dinput: Copy the device format if the user format is a subset of it.
by Rémi Bernon (＠rbernon) 19 Dec '24

19 Dec '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52738 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7048

2 1

[PATCH 0/1] MR7046: mshtml: Ignore Gecko events on detached nodes.
by Jacek Caban (＠jacek) 19 Dec '24

19 Dec '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57248 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7046

3 2

[PATCH 0/1] MR7047: xmllite: Avoid buffer overflow by casting to DtdProcessing. (ASan)
by Bernhard Übelacker (＠bernhardu) 19 Dec '24

19 Dec '24

This appeared by running tests with PE-side ASan enabled, just with x86_64. The enum DtdProcessing seems to have just a size of four bytes, but dereferencing `LONG_PTR *value` writes 8 bytes. ``` ================================================================= ==560==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ff8c0 at pc 0x6ffff7b33f83 bp 0x7ffffe1fed00 sp 0x7ffffe1fed48 WRITE of size 8 at 0x7ffffe1ff8c0 thread T0 05c0:fixme:file:server_get_file_info Unsupported info class e #0 0x6ffff7b33f82 in xmlreader_GetProperty .../wine/dlls/xmllite/reader.c:2807:20 #1 0x000140002254 in IXmlReader_GetProperty .../obj\include\xmllite.h:331:12 #2 0x000140002254 in test_reader_create .../wine/dlls/xmllite/tests/reader.c:582:10 #3 0x000140002254 in func_reader .../wine/dlls/xmllite/tests/reader.c:2676:5 #4 0x00014006bad1 in run_test .../wine/include/wine/test.h:765:5 #5 0x00014006bad1 in main .../wine/include/wine/test.h:884:12 #6 0x00014006d94f in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #7 0x6ffffbdc4808 in BaseThreadInitThunk .../wine/dlls/kernel32\thread.c:61:5 #8 0x6ffffad1fa1a in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17000fa1a) Address 0x7ffffe1ff8c0 is located in stack of thread T0 at offset 2784 in frame #0 0x00014000100f in func_reader .../wine/dlls/xmllite/tests/reader.c:2675 This frame has 113 object(s): [32, 36) 'd.i439.i' (line 824) [48, 52) 'd.i412.i' (line 824) [64, 68) 'd.i385.i' (line 824) [80, 84) 'd.i358.i' (line 824) ... [2672, 2676) 'nodetype.i2' (line 620) [2688, 2696) 'resolver.i' (line 515) [2720, 2728) 'unk.i' (line 516) [2752, 2760) 'reader.i' (line 517) [2784, 2788) 'dtd.i' (line 518) <== Memory access at offset 2784 partially overflows this variable [2800, 2804) 'nodetype.i' (line 519) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/dlls/xmllite/reader.c:2807:20 in xmlreader_GetProperty Shadow bytes around the buggy address: 0x7ffffe1ff600: f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 0x7ffffe1ff680: f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 f8 f2 0x7ffffe1ff700: f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 f8 f2 f8 f2 f8 f2 0x7ffffe1ff780: f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 0x7ffffe1ff800: f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 00 f2 f2 f2 =>0x7ffffe1ff880: 00 f2 f2 f2 00 f2 f2 f2[04]f2 04 f3 00 00 00 00 0x7ffffe1ff900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffb00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==560==ABORTING 05c0:fixme:kernelbase:AppPolicyGetProcessTerminationMethod FFFFFFFFFFFFFFFA, 00007FFFFEA8FE80 make: *** [Makefile:471569: dlls/xmllite/tests/x86_64-windows/reader.ok] Fehler 1 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7047

3 2

[PATCH v2 0/1] MR7042: dwrite/tests: Avoid stack-use-after-scope in test_GetOverhangMetrics. (ASan)
by Bernhard Übelacker (＠bernhardu) 19 Dec '24

19 Dec '24

This moves the stack variable to the outer scope, because it gets accessed in the call to `IDWriteTextLayout_Release` a few lines below. ``` ================================================================= ==1792==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffffe1fd0c0 at pc 0x6ffff84f74f6 bp 0x7ffffe1fcad0 sp 0x7ffffe1fcb18 READ of size 8 at 0x7ffffe1fd0c0 thread T0 0704:fixme:file:server_get_file_info Unsupported info class e #0 0x6ffff84f74f5 in IDWriteInlineObject_Release .../wine-build/build-asan-pe/64/obj\include\dwrite.h:2815:18 #1 0x6ffff84f74f5 in free_layout_range .../wine/dlls/dwrite/layout.c:2487:13 #2 0x6ffff84f74f5 in free_layout_ranges_list .../wine/dlls/dwrite/layout.c:2514:9 #3 0x6ffff84f74f5 in dwritetextlayout_Release .../wine/dlls/dwrite/layout.c:2949:9 #4 0x0001400ec179 in IDWriteTextLayout_Release .../wine-build/build-asan-pe/64/obj\include\dwrite.h:4211:12 #5 0x0001400ec179 in test_GetOverhangMetrics .../wine/dlls/dwrite/tests/layout.c:6288:5 #6 0x0001400ec179 in func_layout .../wine/dlls/dwrite/tests/layout.c:7118:5 #7 0x00014013a4bc in run_test .../wine/include/wine/test.h:765:5 #8 0x00014013a4bc in main .../wine/include/wine/test.h:884:12 #9 0x00014013c36f in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #10 0x6ffffbdc4808 in BaseThreadInitThunk /usr/src/packages/BUILD\dlls/kernel32\thread.c:61:5 #11 0x6ffffaeffa1a in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17000fa1a) Address 0x7ffffe1fd0c0 is located in stack of thread T0 at offset 1280 in frame #0 0x0001400a823f in func_layout .../wine/dlls/dwrite/tests/layout.c:7069 This frame has 224 object(s): [32, 392) 'metrics.i6891' (line 6965) [464, 472) 'inlineobj.i6892' (line 6966) [496, 520) 'line.i' (line 6967) [560, 568) 'format.i6893' (line 6968) ... [1136, 1144) 'layout.i5988' (line 6239) [1168, 1184) 'overhang_metrics.i' (line 6254) [1200, 1236) 'metrics.i5989' (line 6256) [1280, 1320) 'obj.i' (line 6257) <== Memory access at offset 1280 is inside this variable [1360, 1368) 'format2.i5721' (line 6136) [1392, 1400) 'layout.i5722' (line 6137) [1424, 1432) 'format.i5723' (line 6138) [1456, 1476) 'spacing.i5724' (line 6176) ... [10320, 10328) 'format.i' (line 1269) [10352, 10360) 'layout1.i' (line 1335) [10384, 10392) 'format1.i' (line 1336) [10416, 10424) 'format117.i' (line 1337) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-use-after-scope .../wine-build/build-asan-pe/64/obj\include\dwrite.h:2815:18 in IDWriteInlineObject_Release Shadow bytes around the buggy address: 0x7ffffe1fce00: f2 f2 f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 f8 f2 f2 f2 0x7ffffe1fce80: f8 f2 f2 f2 f8 f8 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 0x7ffffe1fcf00: f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 0x7ffffe1fcf80: f8 f8 f8 f8 f2 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 0x7ffffe1fd000: f8 f2 00 f2 f2 f2 00 f2 f2 f2 f8 f8 f2 f2 f8 f8 =>0x7ffffe1fd080: f8 f8 f8 f2 f2 f2 f2 f2[f8]f8 f8 f8 f8 f2 f2 f2 0x7ffffe1fd100: f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f8 0x7ffffe1fd180: f8 f2 f2 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 0x7ffffe1fd200: f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f8 0x7ffffe1fd280: f8 f8 f2 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 0x7ffffe1fd300: f8 f8 f8 f2 f2 f2 f2 f2 f8 f2 f2 f2 f8 f8 f8 f8 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==1792==ABORTING make: *** [Makefile:162532: dlls/dwrite/tests/x86_64-windows/layout.ok] Fehler 1 ``` -- v2: dwrite/tests: Allocate test inline objects dynamically. https://gitlab.winehq.org/wine/wine/-/merge_requests/7042

3 4

[PATCH 0/3] MR7045: Draft: win32u: Misc tweaks for vulkan surface offscreening.
by Rémi Bernon (＠rbernon) 19 Dec '24

19 Dec '24

Similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/7034 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7045

2 3

[PATCH v2 0/2] MR7014: winex11: Move GL/VK offscreen if the clipping region is NULLREGION.
by Rémi Bernon (＠rbernon) 19 Dec '24

19 Dec '24

NULLREGION means that the entire window should be clipped out, and its children displayed instead. The change broke some offscreening decisions when both parent and children have a GL drawable created but drawing actually happens on the child window. (Found while trying to reproduce otherwise unrelated regression in https://bugs.winehq.org/show_bug.cgi?id=52738, the game there uses ddraw and doesn't display anything after 786d9d1685ac220081b10cc779d4d331ddd2fc52) Fixes: 786d9d1685ac220081b10cc779d4d331ddd2fc52 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57503 -- v2: winex11: Move GL/VK offscreen if the clipping region is NULLREGION. winex11: Use DCX_USESTYLE when checking DC clipping regions. https://gitlab.winehq.org/wine/wine/-/merge_requests/7014

2 2

[PATCH v2 0/1] MR7044: comctl32/tests: Initialize hwnd = NULL before rebuild_toolbar(&hwnd).
by Alanas Tebuev (＠BZZZZ) 19 Dec '24

19 Dec '24

https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86205 -- v2: comctl32/tests: Initialize hwnd to NULL before calling rebuild_toolbar(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7044

3 2

[PATCH 0/1] MR7044: comctl32/tests: Initialize hwnd = NULL before rebuild_toolbar(&hwnd).
by Alanas Tebuev (＠BZZZZ) 19 Dec '24

19 Dec '24

https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86205 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7044

4 3

[PATCH v3 0/1] MR7040: capstone: Avoid GCC being treated as old VisualStudio
by Gerald Pfeifer (＠gerald) 19 Dec '24

19 Dec '24

The preprocessor condition to cover pre-2013 VisualStudio around C99 support actually also admitted current versions of GCC and breaks GCC in C23 mode. Address this by explicitly checking for GCC which, by definition, then does not qualify as VisualStudio. -- v3: capstone: Avoid GCC being treated as old VisualStudio https://gitlab.winehq.org/wine/wine/-/merge_requests/7040

3 2

[PATCH v2 0/419] MR7040: capstone: Avoid GCC being treated as old VisualStudio
by Gerald Pfeifer (＠gerald) 19 Dec '24

19 Dec '24

The preprocessor condition to cover pre-2013 VisualStudio around C99 support actually also admitted current versions of GCC and breaks GCC in C23 mode. Address this by explicitly checking for GCC which, by definition, then does not qualify as VisualStudio. -- v2: capstone: Avoid GCC being treated as old VisualStudio winex11: Use NtUserReleaseDC() with hdc. ntdll: Align heap virtual allocations to a multiple of the page size. msxml3: Correct looping of Document Element node map. server: Avoid crash when handle table is allocated but not yet filled. Revert "wined3d: Use bindless textures for GLSL shaders if possible.". wined3d: Add nop state entries for states now invalidated on the client side. windowscodecs/tests: Check persist options after Load(). windowscodecs/tests: Add loading tests for the writers. windowscodecs/tests: Add some tests for metadata stream objects handling. windowscodecs/tests: Add some tests for CreateMetadataWriter(). windowscodecs/tests: Add some tests for CreateMetadataWriterFromReader(). windowscodecs/tests: Added some tests for Exif and Gps IFDs embedded in App1 blob. gdiplus: GdipPathAddRectangle should close the path. kernelbase: Don't try to print the path in the FIXME in GetTempPath2. cmd: Fix regression in variable search in expansion. cmd/tests: Add more tests about variable expansion. winex11: Sync gl drawable outside of the win_data mutex. po: Update Japanese translation. odbc32: Add null pointer checks to update_result_lengths helpers. odbc32: Avoid crashing if str is null in debugstr_sqlstr. Release 10.0-rc2. winetest: Filter out color escapes for junit output. winex11: Fix inconsistent coordinates when reparenting host window. server: Allow merging WM_MOUSEMOVE across internal messages. windowscodecs/tests: Add some tests for the App1 reader. windowscodecs/tests: Add some tests for the Gps reader. windowscodecs/tests: Run data test on the Exif reader. windowscodecs/tests: Move IFD data tests to a helper. windowscodecs/tests: Remove endianess compile time checks from the tests. windowscodecs/tests: Use a helper instead of a macro. windowscodecs/tests: Add some tests for GetContainerFormats(). windowscodecs/tests: Use test context in a few metadata tests. explorer: Avoid hiding the taskbar if it's enabled. shell32: Remove trailing spaces in SHELL_execute. win32u: Check for driver events more often. dinput: Queue the relative wheel motion as event data. winex11: Skip offscreening if the children don't require clipping. winex11: Always check if the GL drawable offscreen state needs to be changed. winex11: Fixup window config size back to 0x0 if we've requested 1x1. win32u: Use width and height to check if the display mode is vertical. dbghelp: Lower vector allocation for local variables. dbghelp: Fix error handling in PDB/FPO unwinder. wineboot: Scale the wait dialog icon with the dialog size. wineboot: Resize the wait dialog to accommodate the text size. wineboot: Always wrap the wait dialog text. mshtml: Remove unused MutationObserver DISPID and related hook. dmloader: Remove redundant flag. include: Use inline assembly on Clang MSVC mode in YieldProcessor(). configure: Define _load_config_used symbol in the cross-compiler test program. winebus: Wait until the device is started before processing reports. winex11: Request window config when it needs to be raised. ntoskrnl: Fix off-by-one error in buffer size. ntoskrnl: Support relative driver paths. user32: Fixup forwarded functions on 32-bit. win32u: Use the winstation monitor update serial to detect updates. server: Add a winstation monitor update serial counter. win32u: Extend display_lock CS around winstation check. server: Force surface region update when window region is modified. win32u: Copy the shape from the old surface when surface is recreated. winebth.sys: Use the correct byte-ordering for setting the radio's address property. winebth.sys: Set the Information field in the IRP's STATUS_BLOCK after handling IOCTL_BTH_GET_LOCAL_INFO. win32u: Release the Win16 mutex when yielding in peek_message. msvcrt: Don't leak find handle or error in _findfirst(). ucrtbase/tests: Use correct size to GetEnvironmentVariableW. webservices: Rename a struct member from bool to boolean. winebth.sys: Fix new bluetooth events being incorrect set due to variable shadowing. mscoree: Use correct variable for codebase path. win32u: Skip updating the cache on driver load if we're already updating it. Release 10.0-rc1. winebth.sys: Implement IOCTL_BTH_GET_LOCAL_INFO. winebth.sys: Update radio PDO properties on receiving PropertiesChanged for an org.bluez.Adapter1 object. winebth.sys: Remove the corresponding radio PDO on receiving InterfacesRemoved for a org.bluez.Adapter1 object. winebth.sys: Create new radio PDOs on receiving InterfacesAdded for objects that implement org.bluez.Adapter1. winebth.sys: Set radio PDO properties from the device's corresponding org.bluez.Adapter1 object properties. ucrtbase: Always use CP_ACP when converting environment block. winedbg: Add support for dynamic debug channel. ntdll: Force redirect all ARM64EC indirect calls until the JIT is ready. ntdll: Add arm64ec_get_module_metadata helper. ntdll: Move update_hybrid_metadata() to the ARM64EC backend. quartz/dsoundrender: Use send_sample_data() to fill the buffer with silence at EOS. quartz/dsoundrender: Queue samples and render them on a separate thread. quartz/dsoundrender: Do not ignore preroll samples. quartz/dsoundrender: Do not provide time to the passthrough. quartz/tests: Test whether the DirectSound renderer provides a position. quartz/dsoundrender: Play non-discontinuous samples consecutively. quartz/dsoundrender: Remove the unused "tStop" argument to send_sample_data(). quartz/dsoundrender: Always treat samples as continuous if they are late or out of order. winex11: Listen to root window _NET_SUPPORTED property changes. winex11: Move the _NET_SUPPORTED information to the thread data. winegstreamer: Send media source shutdown notification via IMFMediaShutdownNotify. mf: Introduce IMFMediaShutdownNotify for notification of media source shutdown. mf: Handle media source Start() failure due to source shutdown. mf: Handle media source event subscription failure due to source shutdown. mf: Handle media source BeginGetEvent() failure due to shutdown. mf: Handle media source EndGetEvent() failure due to shutdown. mf/tests: Add tests for shutting down a media source used in a session. winegstreamer: Return the result code from media_source_Pause(). server: Work around macOS W^X limitations in write_process_memory. server: Do not page-align address in write_process_memory. server: Do not suspend mach task in write_process_memory. server: Use mach_vm_read_overwrite in get_selector_entry. server: Do not suspend mach task in get_selector_entry. server: Use mach_vm_read_overwrite in read_process_memory. server: Do not suspend mach task in read_process_memory. jscript: Add support for deleting host properties. jscript: Move property allocation to update_external_prop. include: Add SQL_C_TCHAR define. include: Add DB_VARNUMERIC struct. include: Add _WIN32_WINNT_ version defines. server: Ensure in pending delete on close that path to unlink are unique. winegstreamer: Handle null transform in WMA IMediaObject::Flush(). winegstreamer: Handle null transform in video IMFTransform::ProcessMessage() FLUSH. winegstreamer: Handle null transform in video IMFTransform::ProcessMessage() DRAIN. winegstreamer: Handle null transform in video IMediaObject::Flush(). ucrtbase: Enable utf8 support. msvcrt: Prepare remaining process creation functions to handle utf-8 encoded arguments. msvcrt: Prepare _execle to handle utf-8 encoded arguments. msvcrt: Prepare _spawnl to handle utf-8 encoded arguments. msvcrt: Prepare _loaddll to handle utf-8 encoded path. msvcrt: Prepare freopen to handle utf-8 encoded path. msvcrt: Prepare _sopen_dispatch to handle utf-8 encoded path. msvcrt: Return error on NULL path parameter in _wsopen_dispatch. msvcrt: Add putenv() utf-8 tests. msvcrt: Call _wfindnext64i32 in _findnext64i32 function. msvcrt: Call _wfindfirst64i32 in _findfirst64i32 function. server: Print signal names in traces. wrc: Use the correct error function for syntax errors. winebuild: Remove support for .def files as import libraries. winegcc: Remove support for .def files as import libraries. configure: Correctly check the --enable-build-id option. bcrypt: Trace returned handles. include: Use inline assembly on Clang MSVC mode in exception helpers. windows.networking.connectivity: Use %I64d instead of %llu. mfmediaengine: Fallback to sample copy if scaling is required. mfmediaengine: Implement D3D-aware video frame sink. mfmediaengine: Implement the Simple Video Renderer. ntdll: Use sched_getcpu instead of the getcpu syscall. win32u: Hold the display_lock when checking the cache update time. win32u: Remove recursive lock_display_devices calls. win32u: Implement update_display_cache with lock_display_devices. win32u: Add a force parameter to lock_display_devices. ntdll: Implement NtGetCurrentProcessorNumber for macOS on x86_64. qasf: Correctly return failure in process_output. qasf/tests: Add more tests for dmo_wrapper_sink_Receive. windowscodecs: Implement CreateMetadataReader(). windowscodecs/metadata: Add a helper to iterate over components. windowscodecs/tests: Add a basic test for CreateComponentEnumerator(). windowscodecs/tests: Add some tests for CreateMetadataReader(). windowscodecs/tests: Use string literals in the metadata tests. mshtml: Get rid of unused HTMLElement_toString_dispids. mshtml: Expose respective props from StyleSheetPrototype. mshtml: Don't expose toString from styles in IE9+ modes. mshtml: Don't expose the *Expression methods from styles in IE9+ modes. mshtml: Don't expose the clip* props from style declaration or properties in IE9+ modes. mshtml: Don't expose 'behavior' prop from styles in IE11 mode. mshtml: Move 'filter' prop to MSCSSPropertiesPrototype in IE9 mode. mshtml: Prefer builtins for style aliases that have the same name. mshtml: Expose respective props from MSCSSPropertiesPrototype. mshtml/tests: Add more tests for the style aliased prop names. msvcrt: Call _wfindnext64 in _findnext64 function. msvcrt: Call _wfindfirst64 in _findfirst64 function. msvcrt: Call _wfindnext32 in _findnext32 function. msvcrt: Call _wfindfirst32 in _findfirst32 function. include: Cleanup corecrt_io.h file and use it in io.h. msvcrt: Prepare _searchenv_s() for utf-8 encoded filename. msvcrt: Don't return success on GetFullPathName error in _wsearchenv_s. msvcrt: Call _wtempnam in _tempnam function. msvcrt: Call _wrename in rename function. msvcrt: Call _wstat64 in _stat64 function. d3dcompiler/tests: Test the 'double' HLSL data type. d3dx9/tests: Test the 'double' HLSL data type. d3dx9/tests: Add d3dx9_43 tests. d3dx9_43: Generate an import library. d3dcompiler/tests: Clean up further tests fixed by vkd3d merges. d3dx11/tests: Clean up tests fixed by vkd3d merges. d3d10_1/tests: Clean up tests fixed by vkd3d merges. d3dcompiler/tests: Clean up tests fixed by vkd3d merges. kernelbase: Improve logging of information classes in GetTokenInformation. Revert "win32u: Create explorer with the thread effective access token.". explorer: Apply a default admin token when running for the desktop. widl: Avoid unused variable warning. wbemprox: Avoid unused variable warning. vbscript: Avoid unused variable warning. msxml: Avoid unused variable warning. msi: Avoid unused variable warning. jscript: Avoid unused variable warning. windows.networking.connectivity: Implement IConnectionProfile::GetNetworkConnectivityLevel(). windows.networking.connectivity/tests: Add some INetworkInformationStatics::GetInternetConnectionProfile() tests. windows.networking.connectivity: Implement INetworkInformationStatics::GetInternetConnectionProfile(). windows.networking.connectivity: Add INetworkInformationStatics stub interface. windows.networking.connectivity: Add stub dll. dbghelp: Search debug info with buildid for RSDS debug entry w/o filenames. dbghelp: Extend search for buildid in system directories. ntdll: Use %fs/%gs prefixes instead of a separate .byte 0x64/.byte 0x65. include: Use %fs/%gs prefixes instead of a separate .byte 0x64/.byte 0x65. server: Only store a Unix name for regular files. taskmgr: Only list dynamically settable debug channels. quartz/dsoundrender: Make trace messages more consistent. quartz/dsoundrender: Use a consistent style for method names. quartz/dsoundrender: Make brace placement consistent. quartz/dsoundrender: Add missing static qualifier to IDispatch methods. quartz/dsoundrender: Rename "This" to "filter". qasf: Return failure in dmo_wrapper_sink_Receive if process_output fails. qasf/tests: Test dmo_wrapper_sink_Receive if downstream fail to receive. qasf: Return S_FALSE for flushing in dmo_wrapper_sink_Receive. msvcrt: Prepare _mktemp_s to handle UTF-8 strings. msvcrt: Prepare _mktemp to handle UTF-8 strings. msvcrt: Call _wunlink in _wremove function. msvcrt: Call _unlink in remove function. msvcrt: Call _wchmod in _chmod function. msvcrt: Call _waccess in _access function. msvcrt: Call _wunlink in _unlink function. msvcrt: Prepare _fsopen to handle UTF-8 strings. gdiplus: Cast enums to unsigned type when validating its value. winevulkan: Use WINE_UNIX_LIB instead of WINE_VK_HOST. winevulkan: Mirror function handling in vk_is_available_instance_function32(). ntdll: Make a debug channel dynamically settable only if there's no specified class. loader: Add Default, Failed, and LastKnownGood values to HKLM\System\Select. advapi32/tests: Add test for CurrentControlSet link. winevulkan: Update to VK spec version 1.4.303. msvcp140: Add a version resource. winex11: Use bilinear filtering in xrender_blit. win32u: Let fullscreen windows cover entire monitors, keeping aspect ratio. winex11: Set a non-transparent window background pixel color. configure: Don't add -Wl,--build-id linker option to CFLAGS. configure: Use -Wl,--build-id unconditionally if requested. winegcc: Remap build-id linker option for clang. configure: Properly test clang for dwarf support. gdiplus: Use the FormatID of the source image when cloning. winex11: Do not use desired_state when computing state updates. explorer: Prevent apps from showing Wine specific shell tray window with no icons. ntdll/tests: Fix format warning with clang. ntdll: Fix reported exception code for some brk immediates. ntdll: Test more ARM64 brk instruction exception behaviour. winex11: Don't update Win32 window position for offscreen windows. d2d1/effect: Improve handling of blob properties. kernelbase: Add test for EnumSystemFirmwareTables on missing provider. kernelbase: Properly return 0 from EnumSystemFirmwareTable on error. kernel32: Use a proper import for HeapFree. win32u: Move surface and swapchain wrappers from winevulkan. winevulkan: Keep the host function pointers in devices and instances. winevulkan: Use the vulkan object as the wrapper tree node. winevulkan: Get rid of unnecessary *to_handle helpers. winevulkan: Avoid changing client command buffer pointer. winevulkan: Fix incorrect client queue pointers. winevulkan: Introduce a new vulkan_object_init helper. winevulkan: Use the result to decide if creation failed. server: Make CurrentControlSet a symlink in new prefixes. include: Enable format attributes for debug traces in Clang MSVC mode. mmdevapi/tests: Use %u format for unsigned int arguments. imagehlp: Cast AddressOfData to size_t in debug traces. ole32/tests: Add more FMTID_UserDefinedProperties property storage tests. ole32: Read property storage section from correct location. ole32/tests: Add FMTID_UserDefinedProperties property storage tests. ole32: Fix unsupported vector elements detection in PropertyStorage_ReadProperty. msvcrt: Call _wfullpath in _fullpath function. msvcrt: Call _wgetdcwd in _getdcwd function. msvcrt: Call _wgetcwd in _getcwd function. msvcrt: Call _wchdir in _chdir function. msvcrt: Call _wrmdir in _rmdir function. msvcrt: Call _wmkdir in _mkdir function. bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose. bluetoothapis/tests: Add tests for BluetoothFindRadioClose. bluetoothapis/tests: Add tests for BluetoothFindNextRadio. bluetoothapis/tests: Add tests for BluetoothFindFirstRadio. bluetoothapis/tests: Fix potential test failure from memcmp'ing uninitialized bytes. msxml3: Accept the domdoc MaxElementDepth property. ntdll: Add NtFlushBuffersFileEx() semi-stub. win32u: Add some access rights when creating a desktop object. server: Use the correct handle allocation pattern for all object types. mshtml: Don't expose some props from document prototype depending on mode. mshtml: Expose the right props from document fragments. mshtml: Use DocumentPrototype as the document's prototype for modes prior to IE11. mshtml: Move HTMLDocument prototype props to the Document prototype. mscoree: Update Wine Mono to 9.4.0. wined3d: Implement vertex fog in the HLSL FFP pipeline. wined3d: Implement lighting in the HLSL FFP pipeline. wined3d: Take the depth buffer into account for HLSL pretransformed draws. wined3d: Implement pretransformed varyings in the HLSL FFP pipeline. wined3d: Beginnings of an HLSL FFP pixel shader implementation. winevulkan: Use a vulkan_object header for other wrappers. winevulkan: Introduce a new vulkan_swapchain base structure. winevulkan: Introduce a new vulkan_surface base structure. winevulkan: Introduce a new vulkan_queue base structure. winevulkan: Restore some wine_*_from_handle helpers. winevulkan: Introduce a new vulkan_device base structure. winevulkan: Name wine_device parameters and variables more consistently. wined3d: Use wined3d_texture_download_from_texture() even if the dst texture map binding is not valid. ddraw/tests: Always use a format string in winetest_push_context calls. d3d11/tests: Always use a format string in winetest_push_context calls. msvcp60/tests: Add wcsrtombs tests. msvcp60: Improve wcsrtombs implementation. msi: Dynamically determine supported package architectures. msi: Assume PLATFORM_INTEL if the template property is missing. d3dx9: Remove superfluous null check (Coverity). win32u: Allow unsetting the user driver. msvcp140: Call into fopen from _Fiopen. msvcp140/tests: Add tests for _Fiopen. ucrtbase/tests: Add tests for _fsopen. include: Add ___lc_codepage_func() declaration. comctl32/edit: Scroll caret on Ctrl+A. vkd3d: Import upstream release 1.14. uxtheme: Check DrawThemeEdge() content rectangle pointer. include: Use format attribute on Clang in MSVC mode. include: Use LONG_PTR format hack on Clang in MSVC mode. include: Apply LONG_PTR format hack only to Wine build. msvcrt/tests: Silence -Wformat-security Clang warning in test_snprintf. mshtml: Get rid of HTMLELEMENT_TIDS. mshtml: Add IHTMLDOMNode2 in every mode in node's init_dispex_info. mshtml: Move HTMLTableDataCellElement prototype props to the HTMLTableCellElement prototype. mshtml: Don't expose some props from elements in IE11 mode. mshtml: Don't expose some props from elements in IE10+ modes. mshtml: Don't expose expression methods from elements in IE9+ modes. mshtml: Don't expose onpage from elements in IE9+ modes. mshtml: Move normalize from HTMLElement to HTMLDOMNode in IE9+ modes. mshtml: Move hasAttributes from HTMLElement to HTMLDOMNode in IE9+ modes. mshtml: Move toString from HTMLElement to HTMLAnchorElement or HTMLAreaElement in IE9+ modes. mshtml: Don't expose onmspointerhover from elements in IE11 mode. mshtml: Don't expose fireEvent from elements in IE11 mode. mshtml: Expose respective props from Element prototype. user32: Add EvaluateProximityToRect stub. user32: Add PackTouchHitTestingProximityEvaluation stub. msvcp120/tests: Add tests for _Fiopen. msvcr120/tests: Add tests for _fsopen. comctl32: Make CBS_NOINTEGRALHEIGHT only set minimum combobox height. comctl32/tests: Add tests for a small number of items but big size to the combobox dropdown size tests. mmdevapi: Do not modify buffer size after sample rate change. mmdevapi/tests: Test for IAudioClockAdjustment. winevulkan: Introduce a new vulkan_physical_device base structure. winevulkan: Introduce a new vulkan_instance base structure. winevulkan: Hoist physical device array and client instance handle. winevulkan: Name wine_instance parameters and variables more consistently. winevulkan: Move vulkan_client_object header to wine/vulkan_driver.h. winevulkan: Generate ALL_VK_(DEVICE|INSTANCE)_FUNCS in wine/vulkan.h. winevulkan: Get rid of the instance/device funcs structs. win32u: Use PFN_* typedefs for vulkan function pointers. winevulkan: Add missing wine_vkGetPhysicalDeviceSurfaceFormatsKHR manual wrapper. winebth.sys: Register and enable BTHPORT_DEVICE and BLUETOOTH_RADIO interfaces for radio PDOs. winebth.sys: Derive a unique hardware ID for radio PDOs from their corresponding BlueZ object path. winebth.sys: Create radio PDOs from the list of org.bluez.Adapter1 objects on BlueZ. winebth.sys: Add a basic unixlib stub using DBus. winebth.sys: Add base winebth.sys driver. oleaut32: Remove unneeded null checks. oleaut32: Make OleCreateFontIndirect return error if font name is missing. user32: Send parent BN_CLICKED notification when a radio button get focused. user32/tests: Add tests for radio button WM_SETFOCUS. comctl32: Send parent BN_CLICKED notification when a radio button get focused. comctl32/tests: Add tests for radio button WM_SETFOCUS. win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. user32/tests: Check that message-only windows ignore WS_EX_TOPMOST. dsound: Add non-NaN value tests for SetOrientation(). dsound/tests: Add NaN tests for floating-point 3D functions. dsound: Add an angle check for SetOrientation(). dsound: Handle NaN values in the 3D code. ntdll/tests: Add tests for opening objects with zero access. ntdll/tests: Remove some workarounds for old Windows versions. server: Fix a token reference leak. server: Do not allow to open an existing mailslot in NtCreateMailslotFile. ntdll: Always return the handle from NtCreateIoCompletion(). winhlp32: Drop unused member of struct lexret. winex11: Only request the supported _NET_WM_STATE atoms. winex11: Read _NET_SUPPORTED atom list on process attach. winebus: Ignore reports with unexpected IDs. appwiz.cpl: Fix wine_get_version() function pointer check. dwrite/gdiinterop: Apply dpi scaling to the whole target transform. dwrite/gdiinterop: Always return valid bounds from DrawGlyphRun on success. dwrite/tests: Add a test for DrawGlyphRun() bounds. dsound: Fix SetNotificationPositions at end of nonlooping buffer. dsound/tests: Add nonlooping SetNotificationPositions test. mshtml: Make ProgressEvent constructor only available in IE10+ modes. mshtml: Make PageTransitionEvents only available in IE11 mode. mshtml: Expose ie9_char as char for KeyboardEvent. mshtml: Implement get_data for legacy DOCTYPE comment elements. mshtml: Don't expose element props from comment nodes in IE9+ modes. mshtml: Don't expose 'atomic' prop from comment nodes in IE9+ modes. mshtml: Expose IHTMLCommentElement2 interface for comment elements. mshtml: Don't expose toString from text nodes in IE9+ mode. mshtml: Expose the props from the IWineHTMLCharacterData interface for CharacterDataPrototype. mshtml: Add an internal IWineHTMLCharacterData interface and forward text node methods to it. mshtml: Move htmlcomment.c contents into htmltextnode.c. ntdll: Initial version of NtContinueEx(). ntdll/tests: Unify APC test functions. msxml3/tests: Add indentation test. kernelbase: Fix exit code for default ctrl-c handler. kernel32: Add tests for checking the exit code of default ctrl-c handlers. msi: Use mybool instead of bool as variable name. dplayx: Support DPMESSAGEQUEUE_RECEIVE in GetMessageQueue(). dplayx/tests: Test client side of GetMessageQueue() separately. dplayx: Add a few more locks (Coverity). Release 9.22. dplayx: Reimplement DP_LoadSP() using DP_GetConnections(). dplayx: Reimplement DirectPlayEnumerateAW() using DP_GetConnections(). dplayx: Use DP_GetRegValueW() to read SP GUID. dplayx: Read connection name from descriptionW and descriptionA when available. dplayx: Cache connections. winex11: Remove now unnecessary WindowPosChanged re-entry guards. winex11: Update the Win32 window state outside of event handlers. user32/tests: Workaround a FVWM maximized window state bug. winex11: Delay window config request when restoring from fullscreen/maximized. winex11: Avoid sending WM_WINDOWPOSCHANGING when applying window manager config. winex11: Generate GravityNotify events instead of ConfigureNotify. winex11: Introduce a new get_window_state_updates helper. wininet: Parse multi-token Connection strings for Keep-Alive. urlmon/tests: Expect "Upgrade, Keep-Alive" connection string. secur32/tests: Update the tests to expect HTTP/2 headers. win32u: Map cursor pos to raw DPI before calling drivers SysCommand. win32u: Check if parent is the desktop window in get_win_monitor_dpi. gitlab: Wait for the fvwm process to start. kernel32/tests: Check for the _SW_INVALID bit presence only. wtsapi32: Handle WTSSessionInfo class in WTSQuerySessionInformationW(). server: Use an explicit struct instead of a typedef for rectangles. server: Use an explicit struct instead of a typedef for register contexts. server: Use an explicit struct instead of a typedef for object locators. server: Use an explicit union instead of a typedef for UDP endpoints. server: Use an explicit union instead of a typedef for TCP connections. win32u: Reimplement list_window_children() using NtUserBuildHwndList(). server: Add a new request to find sibling windows by class name. win32u: Don't use bool as member of a union type This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7040

1 1

[PATCH 0/1] MR7043: include: Add signbit declarations for c++.
by Daniel Lehman (＠dlehman25) 19 Dec '24

19 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7043

3 2

Re: [PATCH v2 0/1] MR7018: Revert "wined3d: Use bindless textures for GLSL shaders if possible."
by Brendan Shanks (＠bshanks) 19 Dec '24

19 Dec '24

> …separate samplers are a d3d10-level feature, and any d3d10-level GPU should be capable of supporting Vulkan You’d think so, but NVIDIA never supported Vulkan on Fermi (their 2010 to 2012 uarch) or earlier GPUs. I don’t think it’s worth expending effort to support those though. They require the 390 legacy driver branch, last updated 2 years ago so doesn’t work with current kernels or toolchains. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7018#note_90847

1 0

Re: [PATCH v2 0/1] MR7041: crypt32: Avoid stack-use-after-scope in CSignedEncodeMsg_GetParam. (ASan)
by Zhiyi Zhang (＠zhiyi) 19 Dec '24

19 Dec '24

On Wed Dec 18 16:32:46 2024 +0000, Bernhard Übelacker wrote: > Having PE-ASan in CI at the end would be great, but unfortunately my > attempt involved building llvm-mingw/llvm-project with a few patches, > which I attempted upstreaming for quite some time. > Then building wine with it needs also a few patches, and running it > involves currently an ugly mix of a non-ASan and an ASan build. Some > more old/outdated details are > [here](https://gitlab.winehq.org/wine/wine/-/merge_requests/6791#note_86908), > for running just the executables below wine/programs. > But running the tests locally produced quite a few unfinished > [patches](https://gitlab.winehq.org/bernhardu/wine/-/commits/asan-pe_2024-12… > where I try to get the more obvious and hopefully freeze-compatible ones > in, while waiting on progress with llvm-project. I see, thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7041#note_90845

1 0

[PATCH 0/1] MR7042: dwrite/tests: Avoid stack-use-after-scope in test_GetOverhangMetrics. (ASan)
by Bernhard Übelacker (＠bernhardu) 19 Dec '24

19 Dec '24

This moves the stack variable to the outer scope, because it gets accessed in the call to `IDWriteTextLayout_Release` a few lines below. ``` ================================================================= ==1792==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffffe1fd0c0 at pc 0x6ffff84f74f6 bp 0x7ffffe1fcad0 sp 0x7ffffe1fcb18 READ of size 8 at 0x7ffffe1fd0c0 thread T0 0704:fixme:file:server_get_file_info Unsupported info class e #0 0x6ffff84f74f5 in IDWriteInlineObject_Release .../wine-build/build-asan-pe/64/obj\include\dwrite.h:2815:18 #1 0x6ffff84f74f5 in free_layout_range .../wine/dlls/dwrite/layout.c:2487:13 #2 0x6ffff84f74f5 in free_layout_ranges_list .../wine/dlls/dwrite/layout.c:2514:9 #3 0x6ffff84f74f5 in dwritetextlayout_Release .../wine/dlls/dwrite/layout.c:2949:9 #4 0x0001400ec179 in IDWriteTextLayout_Release .../wine-build/build-asan-pe/64/obj\include\dwrite.h:4211:12 #5 0x0001400ec179 in test_GetOverhangMetrics .../wine/dlls/dwrite/tests/layout.c:6288:5 #6 0x0001400ec179 in func_layout .../wine/dlls/dwrite/tests/layout.c:7118:5 #7 0x00014013a4bc in run_test .../wine/include/wine/test.h:765:5 #8 0x00014013a4bc in main .../wine/include/wine/test.h:884:12 #9 0x00014013c36f in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #10 0x6ffffbdc4808 in BaseThreadInitThunk /usr/src/packages/BUILD\dlls/kernel32\thread.c:61:5 #11 0x6ffffaeffa1a in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17000fa1a) Address 0x7ffffe1fd0c0 is located in stack of thread T0 at offset 1280 in frame #0 0x0001400a823f in func_layout .../wine/dlls/dwrite/tests/layout.c:7069 This frame has 224 object(s): [32, 392) 'metrics.i6891' (line 6965) [464, 472) 'inlineobj.i6892' (line 6966) [496, 520) 'line.i' (line 6967) [560, 568) 'format.i6893' (line 6968) ... [1136, 1144) 'layout.i5988' (line 6239) [1168, 1184) 'overhang_metrics.i' (line 6254) [1200, 1236) 'metrics.i5989' (line 6256) [1280, 1320) 'obj.i' (line 6257) <== Memory access at offset 1280 is inside this variable [1360, 1368) 'format2.i5721' (line 6136) [1392, 1400) 'layout.i5722' (line 6137) [1424, 1432) 'format.i5723' (line 6138) [1456, 1476) 'spacing.i5724' (line 6176) ... [10320, 10328) 'format.i' (line 1269) [10352, 10360) 'layout1.i' (line 1335) [10384, 10392) 'format1.i' (line 1336) [10416, 10424) 'format117.i' (line 1337) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-use-after-scope .../wine-build/build-asan-pe/64/obj\include\dwrite.h:2815:18 in IDWriteInlineObject_Release Shadow bytes around the buggy address: 0x7ffffe1fce00: f2 f2 f8 f2 f2 f2 f8 f2 f8 f2 f2 f2 f8 f2 f2 f2 0x7ffffe1fce80: f8 f2 f2 f2 f8 f8 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 0x7ffffe1fcf00: f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 0x7ffffe1fcf80: f8 f8 f8 f8 f2 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 0x7ffffe1fd000: f8 f2 00 f2 f2 f2 00 f2 f2 f2 f8 f8 f2 f2 f8 f8 =>0x7ffffe1fd080: f8 f8 f8 f2 f2 f2 f2 f2[f8]f8 f8 f8 f8 f2 f2 f2 0x7ffffe1fd100: f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f8 0x7ffffe1fd180: f8 f2 f2 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 0x7ffffe1fd200: f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f8 0x7ffffe1fd280: f8 f8 f2 f2 f2 f2 f8 f2 f2 f2 f8 f2 f2 f2 f8 f2 0x7ffffe1fd300: f8 f8 f8 f2 f2 f2 f2 f2 f8 f2 f2 f2 f8 f8 f8 f8 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==1792==ABORTING make: *** [Makefile:162532: dlls/dwrite/tests/x86_64-windows/layout.ok] Fehler 1 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7042

3 2

Re: [PATCH v2 0/1] MR7020: include: Add methods arguments annotations for DirectWrite types. - approved
by Alexandre Julliard (＠julliard) 18 Dec '24

18 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7020

1 0

Re: [PATCH v2 0/1] MR7038: d3dx9_36/tests: Fix logging of expected bytes in check_vertex_components. (ASan) - approved
by Alexandre Julliard (＠julliard) 18 Dec '24

18 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7038

1 0

Re: [PATCH v2 0/1] MR7041: crypt32: Avoid stack-use-after-scope in CSignedEncodeMsg_GetParam. (ASan) - approved
by Alexandre Julliard (＠julliard) 18 Dec '24

18 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7041

1 0

Re: [PATCH v2 0/1] MR7036: windowscodecs: Fix a typo in interface name. - approved
by Alexandre Julliard (＠julliard) 18 Dec '24

18 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7036

1 0

[PATCH 0/1] MR7022: configure: Add /usr/lib64/pkgconfig to the 32-bit search path.
by Elizabeth Figura (＠zfigura) 18 Dec '24

18 Dec '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53953 This is not what I would do. Bug 53953 amounts to "some users didn't install 32-bit headers, so we used the wrong ones, which are usually identical so it doesn't matter". From the perspective of using the software as intended, this is unilaterally user error. From a more utilitarian perspective, this is a regression, and ensuring that we're not using the *functionally* incorrect headers is a problem we have to solve anyway. (Cf. GStreamer, which may be the only interesting case.) On the other hand, it's a regression that's already been in two major versions. Anyone building Wine on Fedora has surely already installed the right headers by now. I'm submitting this patch in an attempt to garner a decreed resolution to the bug, one way or another, but again, this solution is not the one I would prescribe if it were my choice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7022

5 6

[PATCH 0/1] MR7041: crypt32: Avoid stack-use-after-scope in CSignedEncodeMsg_GetParam. (ASan)
by Bernhard Übelacker (＠bernhardu) 18 Dec '24

18 Dec '24

This moves the stack variable to the outer scope, because it gets stored in the variable info and used below the call to `CRYPT_AsnEncodeCMSSignedInfo` a few lines below. ``` ================================================================= ==1032==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffffe1ff133 at pc 0x6ffff821dbd1 bp 0x7ffffe1fe700 sp 0x7ffffe1fe748 READ of size 1 at 0x7ffffe1ff133 thread T0 0430:fixme:file:server_get_file_info Unsupported info class e #0 0x6ffff821dbd0 in CRYPT_AsnEncodeOid .../wine/dlls/crypt32/encode.c:839:13 #1 0x6ffff821a98a in CRYPT_AsnEncodeSequence .../wine/dlls/crypt32/encode.c:185:15 #2 0x6ffff821e456 in CRYPT_AsnEncodePKCSContentInfoInternal .../wine/dlls/crypt32/encode.c:1942:12 #3 0x6ffff821a98a in CRYPT_AsnEncodeSequence .../wine/dlls/crypt32/encode.c:185:15 #4 0x6ffff821f3b9 in CRYPT_AsnEncodeCMSSignedInfo .../wine/dlls/crypt32/encode.c:4400:12 #5 0x6ffff82576bc in CSignedEncodeMsg_GetParam .../wine/dlls/crypt32/msg.c:1281:19 #6 0x6ffff82570a0 in CryptMsgGetParam .../wine/dlls/crypt32/msg.c:3720:12 #7 0x6ffff82570a0 in CSignedEncodeMsg_GetParam .../wine/dlls/crypt32/msg.c:1217:15 #8 0x6ffff824750e in CryptSignMessage .../wine/dlls/crypt32/message.c:508:19 #9 0x0001400e11ad in test_sign_message .../wine/dlls/crypt32/tests/message.c:1015:11 #10 0x0001400e11ad in func_message .../wine/dlls/crypt32/tests/message.c:1310:5 #11 0x00014015ecb1 in run_test .../wine/include/wine/test.h:765:5 #12 0x00014015ecb1 in main .../wine/include/wine/test.h:884:12 #13 0x000140160bbf in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #14 0x6ffffbdc4808 in BaseThreadInitThunk .../wine/dlls/kernel32\thread.c:61:5 #15 0x6ffffad1fa1a in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17000fa1a) Address 0x7ffffe1ff133 is located in stack of thread T0 at offset 275 in frame #0 0x6ffff8256f4f in CSignedEncodeMsg_GetParam .../wine/dlls/crypt32/msg.c:1207 This frame has 5 object(s): [32, 56) 'info' (line 1215) [96, 117) 'oid_rsa_signed' (line 1228) [160, 240) 'info22' (line 1243) [272, 293) 'oid_rsa_data' (line 1249) <== Memory access at offset 275 is inside this variable [336, 352) 'blob' (line 1258) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-use-after-scope .../wine/dlls/crypt32/encode.c:839:13 in CRYPT_AsnEncodeOid Shadow bytes around the buggy address: 0x7ffffe1fee80: 00 f2 f2 f2 f2 f2 00 00 00 00 00 00 f3 f3 f3 f3 0x7ffffe1fef00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1fef80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff000: 00 00 00 00 f1 f1 f1 f1 f8 f8 f8 f2 f2 f2 f2 f2 0x7ffffe1ff080: f8 f8 f8 f2 f2 f2 f2 f2 00 00 00 00 00 00 00 00 =>0x7ffffe1ff100: 00 00 f2 f2 f2 f2[f8]f8 f8 f2 f2 f2 f2 f2 f8 f8 0x7ffffe1ff180: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff200: 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1 0x7ffffe1ff280: 00 00 00 f2 f2 f2 f2 f2 f8 f8 f8 f2 f2 f2 f2 f2 0x7ffffe1ff300: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f2 f2 f2 f2 f8 f8 0x7ffffe1ff380: f8 f2 f2 f2 f2 f2 f8 f8 f3 f3 f3 f3 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==1032==ABORTING make: *** [Makefile:36953: dlls/crypt32/tests/x86_64-windows/message.ok] Fehler 1 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7041

3 3

[PATCH 0/1] MR7039: server: Destroy global hook table in desktop_close_handle().
by Paul Gofman (＠gofman) 18 Dec '24

18 Dec '24

Commit f784374bcb5195c918754b1da6142a618a0da7dd introduced a cyclic reference between desktop and global hook through global hook table. So now if a hook was set and then not explicitly unset and the process was just terminated the hook, desktop, thread and some other related objects are leaked (which is displayed by wineserver on prefix shutdown in this case). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7039

3 3

[PATCH 0/1] MR7040: capstone: Avoid GCC being treated as old VisualStudio
by Gerald Pfeifer (＠gerald) 18 Dec '24

18 Dec '24

The preprocessor condition to cover pre-2013 VisualStudio around C99 support actually also admitted current versions of GCC and breaks GCC in C23 mode. Address this by explicitly checking for GCC which, by definition, then does not qualify as VisualStudio. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7040

4 4

2025

2024

2023

2022

wine-gitlab