- wine-gitlab - winehq.org

[PATCH v2 0/2] MR825: winex11.drv: optimize repeated ClipCursor calls
by Jan Klötzke (＠jkloetzke) 18 Dec '24

18 Dec '24

At least Doom 64 calls ClipCursor() with identical parameters repeatedly, which seems to cause a considerable overhead. Together with high polling rate mouse input this causes the game to almost freeze while the mouse is being moved. So if the clipping did not change we can bail out early because it will not cause any observable difference anyway. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46976 Signed-off-by: Jan Klötzke <jan(a)kloetzke.net> -- v2: winex11.drv: optimize repeated ClipCursor calls winex11.drv: create win32 clipping window only once https://gitlab.winehq.org/wine/wine/-/merge_requests/825

5 8

[PATCH 0/1] MR7038: d3dx9_36/tests: Fix logging of expected bytes in check_vertex_components. (ASan)
by Bernhard Übelacker (＠bernhardu) 17 Dec '24

17 Dec '24

This appeared by running tests with PE-side ASan enabled. ``` ================================================================= ==1116==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1f8794 at pc 0x00014015dd3b bp 0x7ffffe1ef9b0 sp 0x7ffffe1ef9f8 READ of size 2 at 0x7ffffe1f8794 thread T0 04a0:fixme:file:server_get_file_info Unsupported info class e #0 0x00014015dd3a in check_vertex_components .../wine/dlls/d3dx9_36/tests/mesh.c:6858:137 #1 0x0001401173ef in test_weld_vertices .../wine/dlls/d3dx9_36/tests/mesh.c:8702:13 #2 0x0001401173ef in func_mesh .../wine/dlls/d3dx9_36/tests/mesh.c:11869:5 #3 0x000140224057 in run_test .../wine/include/wine/test.h:765:5 #4 0x000140224057 in main .../wine/include/wine/test.h:884:12 #5 0x000140225faf in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #6 0x6ffffbfd4808 in BaseThreadInitThunk .../wine/dlls/kernel32\thread.c:61:5 #7 0x6ffffacefa1a in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17000fa1a) Address 0x7ffffe1f8794 is located in stack of thread T0 at offset 35796 in frame #0 0x0001400ead6f in func_mesh .../wine/dlls/d3dx9_36/tests/mesh.c:11843 This frame has 590 object(s): [32, 104) 'adjacency.i2700' (line 11782) [144, 216) 'adjacency_out.i' (line 11782) [256, 264) 'buffer.i' (line 11785) [288, 296) 'mesh.i2701' (line 11786) [320, 328) 'data.i' (line 11790) [352, 872) 'declaration.i2526' (line 11593) ... [34928, 34952) 'adjacency23.i' (line 7796) [34992, 35072) 'exp_vertices23.i' (line 7797) [35104, 35128) 'exp_indices23.i' (line 7806) [35168, 35176) 'exp_face_remap23.i' (line 7807) [35200, 35224) 'exp_vertex_remap23.i' (line 7808) [35264, 35384) 'vertices24.i' (line 7811) [35424, 35448) 'indices24.i' (line 7821) [35488, 35496) 'attributes24.i' (line 7822) [35520, 35588) 'epsilons24.i' (line 7826) [35632, 35656) 'adjacency24.i' (line 7827) [35696, 35796) 'exp_vertices24.i' (line 7828) <== Memory access at offset 35796 overflows this variable [35840, 35864) 'exp_indices24.i' (line 7837) [35904, 35912) 'exp_face_remap24.i' (line 7838) [35936, 35960) 'exp_vertex_remap24.i' (line 7839) [36000, 36120) 'vertices25.i' (line 7844) [36160, 36184) 'indices25.i' (line 7854) [36224, 36232) 'attributes25.i' (line 7855) [36256, 36324) 'epsilons25.i' (line 7859) [36368, 36392) 'adjacency25.i' (line 7860) [36432, 36532) 'exp_vertices25.i' (line 7861) [36576, 36600) 'exp_indices25.i' (line 7870) [36640, 36648) 'exp_face_remap25.i' (line 7871) ... [57216, 57276) 'vertex.i27' (line 536) [57312, 57316) 'got_rad.i' (line 537) [57328, 57340) 'got_max.i' (line 469) [57360, 57372) 'got_min.i' (line 469) [57392, 57452) 'vertex.i' (line 469) [57488, 57500) 'bottom_point.i' (line 376) [57520, 57532) 'center.i' (line 376) [57552, 57564) 'top_point.i' (line 376) [57584, 57596) 'raydirection.i' (line 376) [57616, 57628) 'rayposition.i' (line 376) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/dlls/d3dx9_36/tests/mesh.c:6858:137 in check_vertex_components Shadow bytes around the buggy address: 0x7ffffe1f8500: f2 f2 f2 f2 00 f2 f2 f2 00 00 00 f2 f2 f2 f2 f2 0x7ffffe1f8580: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f2 0x7ffffe1f8600: f2 f2 f2 f2 00 00 00 f2 f2 f2 f2 f2 00 f2 f2 f2 0x7ffffe1f8680: 00 00 00 00 00 00 00 00 04 f2 f2 f2 f2 f2 00 00 0x7ffffe1f8700: 00 f2 f2 f2 f2 f2 00 00 00 00 00 00 00 00 00 00 =>0x7ffffe1f8780: 00 00[04]f2 f2 f2 f2 f2 00 00 00 f2 f2 f2 f2 f2 0x7ffffe1f8800: 00 f2 f2 f2 00 00 00 f2 f2 f2 f2 f2 00 00 00 00 0x7ffffe1f8880: 00 00 00 00 00 00 00 00 00 00 00 f2 f2 f2 f2 f2 0x7ffffe1f8900: 00 00 00 f2 f2 f2 f2 f2 00 f2 f2 f2 00 00 00 00 0x7ffffe1f8980: 00 00 00 00 04 f2 f2 f2 f2 f2 00 00 00 f2 f2 f2 0x7ffffe1f8a00: f2 f2 00 00 00 00 00 00 00 00 00 00 00 00 04 f2 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==1116==ABORTING 04a0:fixme:kernelbase:AppPolicyGetProcessTerminationMethod FFFFFFFFFFFFFFFA, 00007FFFFEA8FE80 make: *** [Makefile:106354: dlls/d3dx9_36/tests/x86_64-windows/mesh.ok] Fehler 1 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7038

2 1

[PATCH 0/1] MR7036: windowscodecs: Fix a typo in interface name.
by Nikolay Sivov (＠nsivov) 17 Dec '24

17 Dec '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7036

3 2

Re: [PATCH v3 0/1] MR7016: winex11.drv: Use NtUserReleaseDC() with hdc in X11DRV_vulkan_surface_presented(). - approved
by Alexandre Julliard (＠julliard) 17 Dec '24

17 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7016

1 0

Re: [PATCH v5 0/1] MR6993: msxml3: Correct looping of Document Element node map. - approved
by Alexandre Julliard (＠julliard) 17 Dec '24

17 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6993

1 0

Re: [PATCH v3 0/1] MR7035: server: Avoid crash when handle table is allocated but not yet filled. - approved
by Alexandre Julliard (＠julliard) 17 Dec '24

17 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7035

1 0

Re: [PATCH v2 0/1] MR7018: Revert "wined3d: Use bindless textures for GLSL shaders if possible." - approved
by Alexandre Julliard (＠julliard) 17 Dec '24

17 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7018

1 0

Re: [PATCH v2 0/1] MR7021: wined3d: Add nop state entries for states now invalidated on the client side. - approved
by Alexandre Julliard (＠julliard) 17 Dec '24

17 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7021

1 0

Re: [PATCH v3 0/6] MR7033: windowscodecs/tests: Added some tests for Exif and Gps IFDs embedded in App1 blob. - approved
by Alexandre Julliard (＠julliard) 17 Dec '24

17 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7033

1 0

[PATCH v5 0/2] MR7032: Add embeddedbrowserwebview aka. WebView2 DLL stub.
by Bernhard Kölbl (＠besentv) 17 Dec '24

17 Dec '24

(For after the code freeze.) I think we want to have this DLL living in Wine for easier development, and probably dynamically load our custom Chromium fork from here. (just like MSHTML and wine-Gecko) The code for that fork could then be created in its own repo. -- v5: embeddedbrowserwebview: Create CreateWebViewEnvironmentWithOptionsInternal stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/7032

2 2

[PATCH v4 0/2] MR7032: Add embeddedbrowserwebview aka. WebView2 DLL stub.
by Bernhard Kölbl (＠besentv) 17 Dec '24

17 Dec '24

(For after the code freeze.) I think we want to have this DLL living in Wine for easier development, and probably dynamically load our custom Chromium fork from here. (just like MSHTML and wine-Gecko) The code for that fork could then be created in its own repo. -- v4: embeddedbrowserwebview: Create CreateWebViewEnvironmentWithOptionsInternal stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/7032

2 4

[PATCH v3 0/2] MR7032: Add embeddedbrowserwebview aka. WebView2 DLL stub.
by Bernhard Kölbl (＠besentv) 17 Dec '24

17 Dec '24

(For after the code freeze.) I think we want to have this DLL living in Wine for easier development, and probably dynamically load our custom Chromium fork from here. (just like MSHTML and wine-Gecko) The code for that fork could then be created in its own repo. -- v3: embeddedbrowserwebview: Create CreateWebViewEnvironmentWithOptionsInternal stub. embeddedbrowserwebview: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/7032

2 2

[PATCH 0/3] MR7037: ddraw: Clear sysmem textures on the CPU.
by Elizabeth Figura (＠zfigura) 17 Dec '24

17 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7037

3 4

[PATCH v2 0/1] MR7016: winex11.drv: Use NtUserReleaseDC() with hdc in X11DRV_vulkan_surface_presented().
by Paul Gofman (＠gofman) 17 Dec '24

17 Dec '24

-- v2: winex11.drv: Use NtUserReleaseDC() with hdc. https://gitlab.winehq.org/wine/wine/-/merge_requests/7016

3 3

Re: [PATCH v4 0/1] MR6993: msxml3: Correct looping of Document Element node map. - approved
by Nikolay Sivov (＠nsivov) 17 Dec '24

17 Dec '24

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6993

1 0

[PATCH v2 0/1] MR7035: server: Avoid crash when handle table is allocated but not yet filled.
by Bernhard Übelacker (＠bernhardu) 17 Dec '24

17 Dec '24

I was experimenting with a Wine tree built with ASan enabled at PE side. With it I tried to run the test suite, but every now and then I received a crash in wineserver. Because the management structure for the ASan shadow makes each wine process using several gigabytes memory I had a taskmgr.exe running all the time. I think this crash is a result of this taskmgr calling `NtQuerySystemInformation(SystemHandleInformation)` in conjunction with having many new processes created by the tests. This patch leaves `enum_handles` early if the last member has still the value -1 from `alloc_handle_table`. ``` Program received signal SIGSEGV, Segmentation fault. enum_handles (process=0x55ec0db97780, user=0x7ffce90cee30) at .../wine/wine/server/handle.c:846 846 if (!entry->ptr) continue; 1: x/i $pc => 0x55ec0b25ae6e <enum_handles+158>: cmpq $0x0,(%rdx) (rr) bt #0 enum_handles (process=0x55ec0db97780, user=0x7ffce90cee30) at .../wine/wine/server/handle.c:846 #1 0x000055ec0b268908 in enum_processes (cb=cb@entry=0x55ec0b25add0 <enum_handles>, user=user@entry=0x7ffce90cee30) at .../wine/wine/server/process.c:1112 #2 0x000055ec0b25c868 in req_get_system_handles (req=<optimized out>, reply=0x7ffce90cee90) at .../wine/wine/server/handle.c:875 #3 0x000055ec0b27d6eb in call_req_handler (thread=thread@entry=0x55ec0db62c10) at .../wine/wine/server/request.c:304 #4 0x000055ec0b27e62a in read_request (thread=thread@entry=0x55ec0db62c10) at .../wine/wine/server/request.c:338 #5 0x000055ec0b2896c0 in thread_poll_event (fd=<optimized out>, event=1) at .../wine/wine/server/thread.c:389 #6 0x000055ec0b2560b7 in fd_poll_event (event=<optimized out>, fd=<optimized out>) at .../wine/wine/server/fd.c:503 #7 main_loop_epoll () at .../wine/wine/server/fd.c:597 #8 0x000055ec0b25633e in main_loop () at .../wine/wine/server/fd.c:953 #9 0x000055ec0b246aa2 in main (argc=3, argv=0x7ffce90cf6c8) at .../wine/wine/server/main.c:238 (rr) print table->last $38 = -1 (rr) print table->count $39 = 32 ``` -- v2: server: Avoid crash when handle table is allocated but not yet filled. https://gitlab.winehq.org/wine/wine/-/merge_requests/7035

2 2

[PATCH 0/1] MR7035: server: Avoid crash when handle table is allocated but not yet filled.
by Bernhard Übelacker (＠bernhardu) 17 Dec '24

17 Dec '24

I was experimenting with a Wine tree built with ASan enabled at PE side. With it I tried to run the test suite, but every now and then I received a crash in wineserver. Because the management structure for the ASan shadow makes each wine process using several gigabytes memory I had a taskmgr.exe running all the time. I think this crash is a result of this taskmgr calling `NtQuerySystemInformation(SystemHandleInformation)` in conjunction with having many new processes created by the tests. This patch leaves `enum_handles` early if the last member has still the value -1 from `alloc_handle_table`. ``` Program received signal SIGSEGV, Segmentation fault. enum_handles (process=0x55ec0db97780, user=0x7ffce90cee30) at .../wine/wine/server/handle.c:846 846 if (!entry->ptr) continue; 1: x/i $pc => 0x55ec0b25ae6e <enum_handles+158>: cmpq $0x0,(%rdx) (rr) bt #0 enum_handles (process=0x55ec0db97780, user=0x7ffce90cee30) at .../wine/wine/server/handle.c:846 #1 0x000055ec0b268908 in enum_processes (cb=cb@entry=0x55ec0b25add0 <enum_handles>, user=user@entry=0x7ffce90cee30) at .../wine/wine/server/process.c:1112 #2 0x000055ec0b25c868 in req_get_system_handles (req=<optimized out>, reply=0x7ffce90cee90) at .../wine/wine/server/handle.c:875 #3 0x000055ec0b27d6eb in call_req_handler (thread=thread@entry=0x55ec0db62c10) at .../wine/wine/server/request.c:304 #4 0x000055ec0b27e62a in read_request (thread=thread@entry=0x55ec0db62c10) at .../wine/wine/server/request.c:338 #5 0x000055ec0b2896c0 in thread_poll_event (fd=<optimized out>, event=1) at .../wine/wine/server/thread.c:389 #6 0x000055ec0b2560b7 in fd_poll_event (event=<optimized out>, fd=<optimized out>) at .../wine/wine/server/fd.c:503 #7 main_loop_epoll () at .../wine/wine/server/fd.c:597 #8 0x000055ec0b25633e in main_loop () at .../wine/wine/server/fd.c:953 #9 0x000055ec0b246aa2 in main (argc=3, argv=0x7ffce90cf6c8) at .../wine/wine/server/main.c:238 (rr) print table->last $38 = -1 (rr) print table->count $39 = 32 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7035

3 2

[PATCH 0/1] MR7018: Revert "wined3d: Use bindless textures for GLSL shaders if possible."
by Elizabeth Figura (＠zfigura) 17 Dec '24

17 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7018

4 4

[PATCH 0/1] MR7021: wined3d: Add nop state entries for states now invalidated on the client side.
by Elizabeth Figura (＠zfigura) 17 Dec '24

17 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7021

4 3

[PATCH v2 0/6] MR7033: windowscodecs/tests: Added some tests for Exif and Gps IFDs embedded in App1 blob.
by Nikolay Sivov (＠nsivov) 17 Dec '24

17 Dec '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: windowscodecs/tests: Check persist options after Load(). windowscodecs/tests: Add loading tests for the writers. windowscodecs/tests: Add some tests for metadata stream objects handling. windowscodecs/tests: Add some tests for CreateMetadataWriter(). windowscodecs/tests: Add some tests for CreateMetadataWriterFromReader(). windowscodecs/tests: Added some tests for Exif and Gps IFDs embedded in App1 blob. https://gitlab.winehq.org/wine/wine/-/merge_requests/7033

3 7

[PATCH 0/6] MR7033: windowscodecs/tests: Added some tests for Exif and Gps IFDs embedded in App1 blob.
by Nikolay Sivov (＠nsivov) 16 Dec '24

16 Dec '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7033

3 10

Re: [PATCH v2 0/1] MR7019: gdiplus: GdipPathAddRectangle should close the path. - approved
by Alexandre Julliard (＠julliard) 16 Dec '24

16 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7019

1 0

Re: [PATCH v2 0/1] MR7030: kernelbase: Don't try to print the path in the FIXME in GetTempPath2. - approved
by Alexandre Julliard (＠julliard) 16 Dec '24

16 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7030

1 0

Re: [PATCH v2 0/2] MR7029: Fix regression in variable expansion. - approved
by Alexandre Julliard (＠julliard) 16 Dec '24

16 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7029

1 0

Re: [PATCH v2 0/1] MR7025: winex11: Sync gl drawable outside of the win_data mutex. - approved
by Alexandre Julliard (＠julliard) 16 Dec '24

16 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7025

1 0

2025

2024

2023

2022

wine-gitlab