- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR8173: xmllite/tests: Add more writer tests. - approved
by Alexandre Julliard (＠julliard) 01 Jun '25

01 Jun '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8173

1 0

Re: [PATCH v2 0/1] MR8167: xmllite/tests: Fix out-of-bound read. - approved
by Alexandre Julliard (＠julliard) 01 Jun '25

01 Jun '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8167

1 0

[PATCH v3 0/8] MR8184: Draft: mf: Implement thinning.
by Charlotte Pabst (＠CharlottePabst) 01 Jun '25

01 Jun '25

Marked as WIP since it depends on !8175 for the test to run reliably (and currently includes its commits). Tests should be run both with HKCU\\Software\\Wine\\MediaFoundation\\DisableGstByteStreamHandler enabled and disabled. -- v3: mfsrcsnk: Support thinning. winedmo: Support thinning. winegstreamer: Support thinning in media source. winegstreamer: Support thinning in wg_parser. mf: Support thinning in media session. mf/tests: Add tests for thinning. https://gitlab.winehq.org/wine/wine/-/merge_requests/8184

3 11

[PATCH 0/2] MR8186: winebth.sys, bluetoothapis: Minor memory related fixes.
by Vibhav Pant (＠vibhavp) 01 Jun '25

01 Jun '25

Fix an incorrect decref in the winebth.sys DBus code leading to memory corruption, and a potential HANDLE leak in bluetoothapis. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8186

3 4

[PATCH v55 0/2] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 01 Jun '25

01 Jun '25

Over the past several weeks I've been working on and off on this. I didn't track the hours but I'm sure that I've spent 80+ hours on the feature. I've tested and retested all known scenarios and it seems to be working as expected. -- v55: cmd: Implement tab completion for command line entry. include: Fix mistitled field in CONSOLE_READCONSOLE_CONTROL. https://gitlab.winehq.org/wine/wine/-/merge_requests/7843

2 3

[PATCH 0/1] MR8182: ws2_32: Keep parameters in traces for bind() synchronized with connect()
by Ralf Habacker (＠rhabacker) 01 Jun '25

01 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8182

3 2

Re: [PATCH v54 0/2] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 01 Jun '25

01 Jun '25

thanks for all the effort. LGTM please just modify change log of first patch... something like: include: Fix mistitled field in CONSOLE_READCONSOLE_CONTROL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_105044

1 0

[PATCH v2 0/8] MR8184: Draft: mf: Implement thinning.
by Charlotte Pabst (＠CharlottePabst) 31 May '25

31 May '25

Marked as WIP since it depends on !8175 for the test to run reliably (and currently includes its commits). Tests should be run both with HKCU\\Software\\Wine\\MediaFoundation\\DisableGstByteStreamHandler enabled and disabled. -- v2: mfsrcsnk: Support thinning. winedmo: Support thinning. winegstreamer: Support thinning in media source. https://gitlab.winehq.org/wine/wine/-/merge_requests/8184

2 12

[PATCH 0/8] MR8184: Draft: mf: Implement thinning.
by Charlotte Pabst (＠CharlottePabst) 31 May '25

31 May '25

Marked as WIP since it depends on !8175 for the test to run reliably (and currently includes its commits). Tests should be run both with HKCU\\Software\\Wine\\MediaFoundation\\DisableGstByteStreamHandler enabled and disabled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8184

3 19

[PATCH v19 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 31 May '25

31 May '25

-- v19: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

5 15

[PATCH v3 0/5] MR8129: widl: Write the table stream.
by Hans Leidekker (＠hans) 31 May '25

31 May '25

-- v3: widl Implement the AssemblyRef table. widl: Implement the Assembly table. widl: Implement the TypeDef table. widl: Implement the Module table. widl: Write the table stream. https://gitlab.winehq.org/wine/wine/-/merge_requests/8129

4 8

[PATCH 0/2] MR8185: mf/samplegrabber: Initialize state -> event map in a more robust way.
by Nikolay Sivov (＠nsivov) 30 May '25

30 May '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8185

2 2

[PATCH 0/4] MR8183: mf: Read byte streams in chunks of 256KiB.
by Charlotte Pabst (＠CharlottePabst) 30 May '25

30 May '25

I'm dealing with a game that relies on this constant. Tagging @rbernon since this is using a proton commit of his. Tests should be run both with HKCU\\Software\\Wine\\MediaFoundation\\DisableGstByteStreamHandler enabled and disabled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8183

4 13

Re: [PATCH v5 0/12] MR8148: opengl32: Implement wglShareLists directly.
by Rémi Bernon (＠rbernon) 30 May '25

30 May '25

v4: Fix some missing harmless make_opengl changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8148#note_104979

1 0

[PATCH 0/1] MR8181: po: Update Polish translation
by Adam Markowski (＠AMark) 30 May '25

30 May '25

Newest strings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8181

2 1

[PATCH v3 0/5] MR8174: winebth.sys part 12: Introduce support for Low Energy GATT services
by Vibhav Pant (＠vibhavp) 30 May '25

30 May '25

Generic ATTribute Profile (GATT) is a protocol used by BLE devices for data exchange. Broadly, every LE device contains one or more GATT services, with each service having multiple characteristics, which contain the actual piece of data to be exchanged. The Win32 BLE api is defined in [`bluetoothleapis.h`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/), and operates on `HANDLE`s to PDOs created by the driver to remote devices and services, using the `GUID_BLUETOOTHLE_DEVICE_INTERFACE` and `GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE` class interfaces respectively. This MR introduces initial support for accessing GATT services on LE devices: * Create PDOs for remote devices that we discover GATT services on, and enabling `GUID_BLUETOOTHLE_DEVICE_INTERFACE` for them. * Because the driver also creates PDOs for bluetooth radios, a tagged union is used to distinguish between device extension values to dispatch IOCTL and PnP IRPs appropriately. * Enumerate through all `org.bluez.GattService1` objects on BlueZ, and store them on the PE driver inside the associated devices. * Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES for device PDOs. * Use the newly added IOCTL to implement [`BluetoothGATTGetServices`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/nf-bluetoothleapis-bluetoothgattgetservices). -- v3: bluetoothapis/tests: Add tests for BluetoothGATTGetServices. bluetoothapis: Implement BluetoothGATTGetServices. https://gitlab.winehq.org/wine/wine/-/merge_requests/8174

2 6

[PATCH 0/1] MR8171: wintrust: Initialize all cert fields in WINTRUST_AddCert.
by Alex Henrie (＠alexhenrie) 30 May '25

30 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58293 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8171

3 2

[PATCH v2 0/1] MR8179: crypt32: Fix invalid access of list head.
by Yuxuan Shui (＠yshui) 30 May '25

30 May '25

At the end of LIST_FOR_EACH_ENTRY, assuming no matches are found, `provider` will point to the list head, not NULL, as a result we call IsEqualGUID on invalid memory. -- v2: crypt32: Fix invalid access of list head. https://gitlab.winehq.org/wine/wine/-/merge_requests/8179

2 1

[PATCH v4 0/2] MR7920: winecoreaudio: revert unix_set_volumes
by Ada Ahmed (＠yretenai) 30 May '25

30 May '25

I was able to replicate the issue seen in [Bug 58113](https://bugs.winehq.org/show_bug.cgi?id=58113) on my M1. The issue stems from the usage of AudioDevicePropertyVolumeScalar, which the audio driver for the M1 does not support (at least so it appears.) Using AudioObjectIsPropertySettable allows for fast checking for this situation, including preemptively disabling main channel audio if it appears to be unsupported. -- v4: winecoreaudio: quality improvements Revert "winecoreaudio: Implement per-channel volume control." https://gitlab.winehq.org/wine/wine/-/merge_requests/7920

2 3

[PATCH v6 0/3] MR8095: server: Update full window invalidate rect with window resize.
by Rémi Bernon (＠rbernon) 30 May '25

30 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58210 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38975 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/8013 -- v6: server: Update fill window invalidate rect with window resize. server: Pass NULL as child region if region is NULL. https://gitlab.winehq.org/wine/wine/-/merge_requests/8095

4 8

[PATCH 0/1] MR8178: user32: Fix the number of characters processed by DrawTextExW.
by JiangYi Chen (＠meshine) 30 May '25

30 May '25

@alexhenrie @zhiyi Description: When flags does not include DT_CALCRECT, since len is calculated in the middle, it will be reduced to zero. Resulting in the length of the processed string that is finally returned to zero and the non-processing string length is unchanged. But some application taking the non-processing string length to zero as the loop end condition. The test case's merge request number is 8177. Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8178

2 1

[PATCH 0/1] MR8177: user32/tests: Add tests for DrawTextExW.
by JiangYi Chen (＠meshine) 30 May '25

30 May '25

@alexhenrie @zhiyi The corresponding Windows test demo is as follows: [test_DrawTextExW.exe](/uploads/ff1eafc9c58ac03b598699a93136484c/test_DrawTextExW.exe) [test_DrawTextExW.c](/uploads/a41719a33c2ee0e057c911933bf55180/test_DrawTextExW.c) Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: I64052ba8aa8161ad83c1811d642aedbe462ef5ea -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8177

2 1

[PATCH v2 0/2] MR8172: mfreadwrite: Fix media type output when video processor is used.
by Brendan McGrath (＠redmcg) 30 May '25

30 May '25

This is required to fix video playback in Crashlands 2 on Proton 10. -- v2: mfreadwrite: Fix media type output when video processor is used. mfreadwrite/tests: Check DEFAULT_STRIDE is not always present. https://gitlab.winehq.org/wine/wine/-/merge_requests/8172

2 3

[PATCH v3 0/2] MR7920: winecoreaudio: revert unix_set_volumes
by Ada Ahmed (＠yretenai) 29 May '25

29 May '25

I was able to replicate the issue seen in [Bug 58113](https://bugs.winehq.org/show_bug.cgi?id=58113) on my M1. The issue stems from the usage of AudioDevicePropertyVolumeScalar, which the audio driver for the M1 does not support (at least so it appears.) Using AudioObjectIsPropertySettable allows for fast checking for this situation, including preemptively disabling main channel audio if it appears to be unsupported. -- v3: winecoreaudio: Fixed outdated params, improvements Revert "winecoreaudio: Implement per-channel volume control." https://gitlab.winehq.org/wine/wine/-/merge_requests/7920

3 4

Re: [PATCH v3 0/2] MR7880: combase: Fix refcount leak fix in apartment_hostobject
by Kevin Puetz (＠puetzk) 29 May '25

29 May '25

On Tue Apr 22 19:17:10 2025 +0000, Kevin Puetz wrote: > Yes, but not as rebased to master (we're quite a bit behind, so I just > ran things through testbot.winehq.org before submitting rather than > doing a full local build of 10.6). I'll mark as draft for now and do > some more testing... Ok, my apologies that this took so long to get back to. The fix was sound, but the test was completely flawed and I'm not sure how it seemed to work the first time. The key problem is that, since the whole scenario involves a hostapartment, the class factory will be a proxy. And to keep cross-thread traffic down, proxies keep their own refcount, with the proxy owning a single refcount to the stub, which owns a single refcount to the real implementing object. So observing the refcount of the proxy could never have shown whether the actual implementation had been leaked. So now the test instead checks the way we observed the problem in real life - we put a "real" CLSID in to testlib.dll, and notice that the existence of any external refcounts on the class factory object has caused testlib.dll's DllCanUnloadNow to return S_FALSE. So now the compobj test I added seems OK ole32:compobj start dlls/ole32/tests/compobj.c ole32:compobj:0c0c done (0) in 2s 1498B However, pipeline is still showing VM failure on mac > no IP address found, is your VM running And a failure on linux-32, not in the test I changed: > ole32:clipboard:0bf8 done (0) in 0s 5076B > ole32:compobj start dlls/ole32/tests/compobj.c which is where my new test is - the failure is later > ole32:marshal start dlls/ole32/tests/marshal.c > marshal.c:4214:0.026 Test failed: got 0 > marshal.c:4223:0.027 Test failed: Number of locks should be 0, but actually is 2 These marshal.c failures seem to be present in other PRs too (including ones that merged last night), so I assume they are unrelated... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7880#note_104932

1 0

2025

2024

2023

2022

wine-gitlab