- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR7058: programs/cmd: Skip trailing white spaces in FOR's option.
by eric pouech (＠epo) 07 Jan '25

07 Jan '25

@julliard anything wrong with this patch? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7058#note_91575

1 0

[PATCH 0/1] MR7108: tools: Add manual-run job for new-style wow64.
by Jinoh Kang (＠iamahuman) 07 Jan '25

07 Jan '25

The new job is only triggered when a developer manually starts it. Before run, it initially appears as a "skipped" job when the pipeline starts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7108

2 1

[PATCH v2 0/2] MR7079: ddraw: Invalidate the window when the primary surface is released.
by Anton Baskanov (＠baskanov) 07 Jan '25

07 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57599 -- v2: ddraw: Invalidate the window when the primary surface is released. ddraw/tests: Test that releasing a primary surface invalidates the window. https://gitlab.winehq.org/wine/wine/-/merge_requests/7079

4 6

[PATCH v4 0/3] MR7056: ddraw: Correctly apply state on multiple devices.
by Paul Gofman (＠gofman) 07 Jan '25

07 Jan '25

-- v4: ddraw: Correctly apply state when multiple devices are used. ddraw: Factor out d3d_device_apply_state(). ddraw/test: Test state application on multiple devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/7056

5 8

[PATCH v2 0/3] MR7037: ddraw: Clear sysmem textures on the CPU.
by Elizabeth Figura (＠zfigura) 07 Jan '25

07 Jan '25

-- v2: ddraw: Clear sysmem textures on the CPU. https://gitlab.winehq.org/wine/wine/-/merge_requests/7037

4 6

[PATCH v3 0/1] MR7106: winex11: Use the win32 client rect in needs_client_window_clipping.
by William Horvath (＠whrvth) 07 Jan '25

07 Jan '25

After the change to move the sync_gl_drawable call outside the win_data mutex in 54d82ed4, the X11 client rect used for determining whether we need to composite/clip the drawable can be out of sync with the win32 side. This would result in offscreening when unnecessary and vice-versa. -- v3: winex11: Use the win32 client rect in needs_client_window_clipping. https://gitlab.winehq.org/wine/wine/-/merge_requests/7106

3 2

[PATCH v2 0/1] MR7106: winex11: Update window pos before syncing gl drawable.
by William Horvath (＠whrvth) 07 Jan '25

07 Jan '25

Otherwise, the client rect in [needs_client_window_clipping](https://gitlab.winehq.org/wine/wine/-/blob/3f… is outdated, which can result in offscreening when it's not necessary or vice-versa. This keeps the intention of 54d82ed4d5483f7569871219acc485b3cb5a224e while restoring the previous behavior. -- v2: winex11: Use the win32 client rect in needs_client_window_clipping. https://gitlab.winehq.org/wine/wine/-/merge_requests/7106

3 6

[PATCH v4 0/2] MR7088: win32u: Use a color table with default palette for 8bpp window surfaces.
by Rémi Bernon (＠rbernon) 07 Jan '25

07 Jan '25

NtGdiCreateDIBSection will allocate a color table for 8bpp bitmap anyway and if biClrUsed isn't set, we will later fail any color lookup. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57584 -- v4: winex11: Always fill the window surface color info. win32u: Initialize dibdrv info from the surface color bitmap. https://gitlab.winehq.org/wine/wine/-/merge_requests/7088

2 3

Re: [PATCH v3 0/2] MR7088: win32u: Use a color table with default palette for 8bpp window surfaces.
by Rémi Bernon (＠rbernon) 07 Jan '25

07 Jan '25

v3: Use the surface bitmap directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7088#note_91553

1 0

[PATCH 0/1] MR7106: winex11: Update window pos before syncing gl drawable.
by William Horvath (＠whrvth) 07 Jan '25

07 Jan '25

Otherwise, the client rect in [needs_client_window_clipping](https://gitlab.winehq.org/wine/wine/-/blob/3f… is outdated, which can result in offscreening when it's not necessary or vice-versa. This keeps the intention of 54d82ed4d5483f7569871219acc485b3cb5a224e while restoring the previous behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7106

4 3

[PATCH v3 0/1] MR7082: ntdll: Return an error if count is zero in NtRemoveIoCompletionEx.
by Alex Henrie (＠alexhenrie) 07 Jan '25

07 Jan '25

Without this check, the return value is undefined. -- v3: ntdll: Return an error if count is zero in NtRemoveIoCompletionEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/7082

2 2

[PATCH v2 0/1] MR7068: vbscript: class single line multivar
by Francis De Brabandere (＠francisdb) 06 Jan '25

06 Jan '25

closes https://bugs.winehq.org/show_bug.cgi?id=53644 * This applies the patch [provided by](https://bugs.winehq.org/show_bug.cgi?id=53644) @sloper42 and adds tests. * I left a TODO for accessing class variables of type array for a later mr. -- v2: vbscript: class single line multivar https://gitlab.winehq.org/wine/wine/-/merge_requests/7068

3 3

Re: [PATCH v3 0/10] MR7101: win32u: Revert transformed arc support. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7101

1 0

Re: [PATCH v2 0/2] MR7102: winex11: Map mouse/touch event coordinates even without a hwnd. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7102

1 0

Re: [PATCH v2 0/1] MR7104: winex11: Check window region instead of forcing offscreen on parent. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7104

1 0

Re: [PATCH v2 0/1] MR7103: po: Update Simplified Chinese translation. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7103

1 0

Re: [PATCH v2 0/1] MR7015: mmdevapi/test: Fix audio clock adjustment tests failing in testbot. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7015

1 0

Re: [PATCH v2 0/1] MR7067: gdi32: Explicitly check for negative text length in GetTextExtentExPointW(). - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7067

1 0

Re: [PATCH v2 0/1] MR7086: include: Fix method arguments annotations in dwrite.idl. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7086

1 0

Re: [PATCH v5 0/1] MR7009: ntdll: Emulate mrs xN, CurrentEL instructions. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7009

1 0

Re: [PATCH v2 0/2] MR7100: Finnish translation - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7100

1 0

Re: [PATCH v2 0/1] MR7096: d3dx9_36/tests: Fix test data buffer underflow (ASan). - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7096

1 0

Re: [PATCH v4 0/1] MR7052: vbscript: implement Join()
by Jacek Caban (＠jacek) 06 Jan '25

06 Jan '25

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > + str = V_BSTR(&data[i]); > + > + if (i > lbound) { > + string_len = SysStringLen(string); > + tmp = SysAllocStringLen(string, string_len + delimiter_len); > + memcpy(tmp + string_len, delimiter, delimiter_len * sizeof(WCHAR)); > + SysFreeString(string); > + string = tmp; > + } > + > + string_len = … [View More]

1 0

Re: [PATCH v4 0/1] MR7052: vbscript: implement Join()
by Jacek Caban (＠jacek) 06 Jan '25

06 Jan '25

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > + return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); > + if(V_VT(args+1) != VT_BSTR) > + { > + hres = to_string(args+1, &delimiter); > + if(FAILED(hres)) { > + return hres; > + } > + } > + else > + delimiter = V_BSTR(args+1); > + } > + else > + delimiter = SysAllocString(L" "); > + &… [View More]

1 0

Re: [PATCH v6 0/1] MR7049: vbscript: fix Mid() empty and null handling
by Jacek Caban (＠jacek) 06 Jan '25

06 Jan '25

The code looks good, but it would be better to split the test refactoring into a separate commit. Specifically, the first commit should focus on updating existing tests to use the new helpers, and the second should include the implementation changes and any new tests. Sorry for the delay. We're currently in a code freeze, so merging this will have to wait for the 11 cycle, but we can make sure it's ready in the meantime. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7049#note_91498

1 0

2025

2024

2023

2022

wine-gitlab