- wine-gitlab - winehq.org

Re: [PATCH v12 0/2] MR419: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. - approved
by Alexandre Julliard (＠julliard) 26 Nov '24

26 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/419

1 0

Re: [PATCH v5 0/4] MR6289: dsound: Some 3D fixes. - approved
by Alexandre Julliard (＠julliard) 26 Nov '24

26 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6289

1 0

Re: [PATCH v2 0/1] MR6901: winhlp32: Drop unused member of struct lexret - approved
by Alexandre Julliard (＠julliard) 26 Nov '24

26 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6901

1 0

Re: [PATCH v2 0/2] MR6907: winex11: Only request the supported _NET_WM_STATE atoms. - approved
by Alexandre Julliard (＠julliard) 26 Nov '24

26 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6907

1 0

Re: [PATCH v2 0/1] MR6906: winebus: Ignore reports with unexpected IDs. - approved
by Alexandre Julliard (＠julliard) 26 Nov '24

26 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6906

1 0

Re: [PATCH v2 0/1] MR6905: appwiz.cpl: Fix wine_get_version() function pointer check. - approved
by Alexandre Julliard (＠julliard) 26 Nov '24

26 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6905

1 0

Re: [PATCH v2 0/3] MR6903: dwrite/tests: Add a test for DrawGlyphRun() bounds. - approved
by Alexandre Julliard (＠julliard) 26 Nov '24

26 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6903

1 0

Re: [PATCH v3 0/2] MR6873: dsound: Fix SetNotificationPositions at end of nonlooping buffer - approved
by Alexandre Julliard (＠julliard) 26 Nov '24

26 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6873

1 0

[PATCH 0/1] MR5041: ntdll/tests: Unify APC test functions
by Dāvis Mosāns (davispuh) (＠davispuh) 26 Nov '24

26 Nov '24

Currently there are several places that test APC but they use duplicated/similar `apc_func()` so merge all those into single implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5041

3 3

[PATCH v6 0/9] MR6427: winevulkan: Introduce a vulkan object structure.
by Rémi Bernon (＠rbernon) 26 Nov '24

26 Nov '24

I'm starting to consider wrapping more vulkan objects in win32u, I think it'll be useful to implement compositing (and incidentally shared resources with interop with the D3DKMT/NtGdi API), starting with nulldrv/offscreen swapchains. Alternatively we could export more functions from win32u and keep all the wrappers in winevulkan, but having access to win32u internals with a generic vulkan object wrapping mechanism seems to be more interesting. Right now this is not very convenient because the vulkan object hierarchy is only available in winevulkan. This introduces shared structures and API between win32u and winevulkan so they can manipulate the wrapped objects from both side. The interface would only expose what is necessary, ie: the object hierarchy and wrapped handles, the instance and device functions, and the objects rbtree for debugging, so win32u can insert its wrapper there as well. After moving the surface and swapchain wrappers to win32u, the interface would look like this: https://gitlab.winehq.org/rbernon/wine/-/blob/65ca1280d46a2dff792e298c22242… (I pushed a complete WIP branch to https://gitlab.winehq.org/rbernon/wine/-/commits/wip/vulkan-win32u-driver?r…). We can also consider moving all the winevulkan wrappers to win32u but it's not clear whether it's necessary or desirable, and we can also do that later using this interface. -- v6: winevulkan: Introduce a new vulkan_physical_device base structure. winevulkan: Introduce a new vulkan_instance base structure. winevulkan: Hoist physical device array and client instance handle. winevulkan: Name wine_instance parameters and variables more consistently. winevulkan: Move vulkan_client_object header to wine/vulkan_driver.h. winevulkan: Generate ALL_VK_(DEVICE|INSTANCE)_FUNCS in wine/vulkan.h. winevulkan: Get rid of the instance/device funcs structs. win32u: Use PFN_* typedefs for vulkan function pointers. winevulkan: Add missing wine_vkGetPhysicalDeviceSurfaceFormatsKHR manual wrapper. https://gitlab.winehq.org/wine/wine/-/merge_requests/6427

3 11

[PATCH v5 0/9] MR6427: winevulkan: Introduce a vulkan object structure.
by Rémi Bernon (＠rbernon) 26 Nov '24

26 Nov '24

I'm starting to consider wrapping more vulkan objects in win32u, I think it'll be useful to implement compositing (and incidentally shared resources with interop with the D3DKMT/NtGdi API), starting with nulldrv/offscreen swapchains. Alternatively we could export more functions from win32u and keep all the wrappers in winevulkan, but having access to win32u internals with a generic vulkan object wrapping mechanism seems to be more interesting. Right now this is not very convenient because the vulkan object hierarchy is only available in winevulkan. This introduces shared structures and API between win32u and winevulkan so they can manipulate the wrapped objects from both side. The interface would only expose what is necessary, ie: the object hierarchy and wrapped handles, the instance and device functions, and the objects rbtree for debugging, so win32u can insert its wrapper there as well. After moving the surface and swapchain wrappers to win32u, the interface would look like this: https://gitlab.winehq.org/rbernon/wine/-/blob/65ca1280d46a2dff792e298c22242… (I pushed a complete WIP branch to https://gitlab.winehq.org/rbernon/wine/-/commits/wip/vulkan-win32u-driver?r…). We can also consider moving all the winevulkan wrappers to win32u but it's not clear whether it's necessary or desirable, and we can also do that later using this interface. -- v5: winevulkan: Introduce a new vulkan_physical_device base structure. winevulkan: Introduce a new vulkan_instance base structure. winevulkan: Pass physical device array params to some helpers. winevulkan: Name wine_instance parameters and variables more consistently. winevulkan: Move vulkan_client_object header to wine/vulkan_driver.h. winevulkan: Generate ALL_VK_(DEVICE|INSTANCE)_FUNCS in wine/vulkan.h. winevulkan: Get rid of the instance/device funcs structs. win32u: Use PFN_* typedefs for vulkan function pointers. winevulkan: Add missing wine_vkGetPhysicalDeviceSurfaceFormatsKHR manual wrapper. https://gitlab.winehq.org/wine/wine/-/merge_requests/6427

3 13

[PATCH v2 0/2] MR6900: oleaut32: Make OleCreateFontIndirect return error if font name is missing
by Fabian Maurer (＠DarkShadow44) 26 Nov '24

26 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57457 -- v2: oleaut32: Remove a new unneeded null checks oleaut32: Make OleCreateFontIndirect return error if font name is missing https://gitlab.winehq.org/wine/wine/-/merge_requests/6900

2 4

[PATCH 0/1] MR6908: win32u: Allow unsetting the user driver.
by Sven Baars (＠sbaars) 26 Nov '24

26 Nov '24

The wayland driver does this during initialization. This fixes a regression when running wine without a desktop. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6908

3 2

[PATCH 0/1] MR4851: kernelbase: Add naive SystemTimeToTzSpecificLocalTimeEx implementation
by Russell Greene (＠russelltg) 26 Nov '24

26 Nov '24

The cast there seems safe from looking at the struct definitions, and is also used elsewhere in the codebase (dlls/kernelbase/locale.c:5682). It's obviously not a full implementation, but works well enough for my usecase and maybe others as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4851

3 3

[PATCH v4 0/8] MR6427: winevulkan: Introduce a vulkan object structure.
by Rémi Bernon (＠rbernon) 26 Nov '24

26 Nov '24

I'm starting to consider wrapping more vulkan objects in win32u, I think it'll be useful to implement compositing (and incidentally shared resources with interop with the D3DKMT/NtGdi API), starting with nulldrv/offscreen swapchains. Alternatively we could export more functions from win32u and keep all the wrappers in winevulkan, but having access to win32u internals with a generic vulkan object wrapping mechanism seems to be more interesting. Right now this is not very convenient because the vulkan object hierarchy is only available in winevulkan. This introduces shared structures and API between win32u and winevulkan so they can manipulate the wrapped objects from both side. The interface would only expose what is necessary, ie: the object hierarchy and wrapped handles, the instance and device functions, and the objects rbtree for debugging, so win32u can insert its wrapper there as well. After moving the surface and swapchain wrappers to win32u, the interface would look like this: https://gitlab.winehq.org/rbernon/wine/-/blob/65ca1280d46a2dff792e298c22242… (I pushed a complete WIP branch to https://gitlab.winehq.org/rbernon/wine/-/commits/wip/vulkan-win32u-driver?r…). We can also consider moving all the winevulkan wrappers to win32u but it's not clear whether it's necessary or desirable, and we can also do that later using this interface. -- v4: winevulkan: Introduce a new vulkan_physical_device base structure. https://gitlab.winehq.org/wine/wine/-/merge_requests/6427

3 11

Re: [PATCH v24 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by eric pouech (＠epo) 26 Nov '24

26 Nov '24

On Tue Nov 26 09:45:58 2024 +0000, Michele Dionisio wrote: > I remove the check as you request. but in my opinion now the test fails > on linux and windows too they fail on linux when run from a unix console, I don't see failure on windows you can add the attached patch to work around this [patch-timeout](/uploads/e311af5c8318f780aad5ff66a714ba26/patch-timeout) I let you fix the remaining failure Note: since MR!6888 has been merged, you don't need to take care of returning STATUS_CONTROL_C_EXIT, it's done by the default handlers now Note2: the SetStdHandle() call between FreeConsole() and AllocConsole() in this patch looks suspicious : it's not needed under Windows, so likely another Wine bug (but it's needed for now, esp. when running the tests under Wine from a unix console) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6869#note_88940

1 0

Re: [PATCH v2 0/2] MR6736: Do not modify audio client buffer size when changing sample rate
by Arek Hiler (＠ivyl) 26 Nov '24

26 Nov '24

just a minor nitpick with indent, thanks for improving the implementation! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6736#note_88937

1 0

Re: [PATCH v2 0/2] MR6736: Do not modify audio client buffer size when changing sample rate - approved
by Arek Hiler (＠ivyl) 26 Nov '24

26 Nov '24

This merge request was approved by Arek Hiler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6736

1 0

Re: [PATCH v2 0/2] MR6736: Do not modify audio client buffer size when changing sample rate
by Arek Hiler (＠ivyl) 26 Nov '24

26 Nov '24

Arek Hiler (@ivyl) commented about dlls/mmdevapi/tests/render.c: > + ok(hr == S_OK, "SetSampleRate failed: %08lx\n", hr); > + > + /* Wait for frame processing */ > + WaitForSingleObject(event, 1000); > + > + hr = IAudioClient_GetBufferSize(ac, &bufsize); > + ok(bufsize == expected_bufsize, "unexpected bufsize %d expected %d\n", bufsize, expected_bufsize); > + > + hr = IAudioClockAdjustment_SetSampleRate(aca, 22050.00f); > + ok(hr == S_OK, "SetSampleRate failed: %08lx\n", hr); > + > + /* Wait for frame processing */ > + WaitForSingleObject(event, 1000); > + > + hr = IAudioClient_GetBufferSize(ac, &bufsize); > + todo_wine ok(bufsize == expected_bufsize, "unexpected bufsize %d expected %d\n", bufsize, expected_bufsize); bad indent -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6736#note_88936

1 0

[PATCH v10 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) 26 Nov '24

26 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v10: user32: Send parent BN_CLICKED notification when a radio button get focused. user32/tests: Add tests for radio button WM_SETFOCUS. comctl32: Send parent BN_CLICKED notification when a radio button get focused. comctl32/tests: Add tests for radio button WM_SETFOCUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

4 7

[PATCH v11 0/2] MR419: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Giovanni Mascellani (＠giomasce) 26 Nov '24

26 Nov '24

-- v11: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. user32/tests: Check that message-only windows ignore WS_EX_TOPMOST. https://gitlab.winehq.org/wine/wine/-/merge_requests/419

4 5

[PATCH v10 0/2] MR419: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Giovanni Mascellani (＠giomasce) 26 Nov '24

26 Nov '24

-- v10: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. user32/tests: Check that message-only windows ignore WS_EX_TOPMOST. https://gitlab.winehq.org/wine/wine/-/merge_requests/419

3 3

[PATCH v2 0/2] MR6898: comctl32: Update combobox dropdown size.
by Orin Varley (＠ovarley1) 26 Nov '24

26 Nov '24

When the combobox height is to be set by the application (as the CBS_NOINTEGRALHEIGHT style is on), and when a large size is specified but only a small number of items in the list, the height of the combobox should be set by the number of items rather than the size specified to avoid empty lines. The first commit fixes this and the second is a test for this behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57360 Closes #7 -- v2: comctl32: Make CBS_NOINTEGRALHEIGHT only set minimum combobox height. comctl32/tests: Add tests for a small number of items but big size to the combobox dropdown size tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6898

2 2

[PATCH v4 0/4] MR6289: dsound: Some 3D fixes.
by Aida Jonikienė (＠DodoGTA) 26 Nov '24

26 Nov '24

-- v4: dsound: Add non-NaN value tests for SetOrientation(). dsound/tests: Add NaN tests for floating-point 3D functions. dsound: Add an angle check for SetOrientation(). dsound: Handle NaN values in the 3D code. https://gitlab.winehq.org/wine/wine/-/merge_requests/6289

3 9

[PATCH v4 0/6] MR6680: msvcp140: Use current locale to convert path in _Fiopen.
by Daniel Lehman (＠dlehman25) 26 Nov '24

26 Nov '24

-- v4: msvcp140: Call into fopen from _Fiopen. ucrtbase: Handle utf-8 in _fsopen. msvcp140/tests: Add tests for _Fiopen. msvcp120/tests: Add tests for _Fiopen. ucrtbase/tests: Add tests for _fsopen. msvcr120/tests: Add tests for _fsopen. https://gitlab.winehq.org/wine/wine/-/merge_requests/6680

4 17

2025

2024

2023

2022

wine-gitlab