- wine-gitlab - winehq.org

Re: [PATCH v2 0/2] MR6861: nls: Set alpha bit on some Thai and Mongolian codes. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6861

1 0

Re: [PATCH v2 0/8] MR6860: dplayx: GROUPDATACHANGED handling and UNICODE support in EnumConnections() and EnumSessions(). - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6860

1 0

Re: [PATCH v2 0/1] MR6853: windowscodecs/tests: Always use a format string in winetest_push_context calls. - approved
by Alexandre Julliard (＠julliard) 20 Nov '24

20 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6853

1 0

Re: [PATCH v2 0/1] MR5792: server: Avoid calling set_event from within msg_queue_add_queue.
by Elizabeth Figura (＠zfigura) 20 Nov '24

20 Nov '24

What was the reason for this change? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5792#note_88204

1 0

[PATCH v4 0/6] MR6850: mshtml: Expose the props properly for Node prototype chain.
by Gabriel Ivăncescu (＠insn) 20 Nov '24

20 Nov '24

This is just nodes for now. The tests in the last patch may seem a bit overkill now, but it will be used for all the other prototypes, so they'll only need extra entries in the array/table, making it way simpler and less redundant. -- v4: mshtml: Don't expose swapNode from NodePrototype. mshtml: Don't expose replaceNode from NodePrototype. mshtml: Don't expose removeNode from NodePrototype. mshtml: Expose ownerDocument from NodePrototype. mshtml/tests: Add initial tests for prototype chain props. mshtml: Enumerate all own builtin props from host object's NextProperty. https://gitlab.winehq.org/wine/wine/-/merge_requests/6850

3 7

[PATCH v3 0/6] MR6850: mshtml: Expose the props properly for Node prototype chain.
by Gabriel Ivăncescu (＠insn) 20 Nov '24

20 Nov '24

This is just nodes for now. The tests in the last patch may seem a bit overkill now, but it will be used for all the other prototypes, so they'll only need extra entries in the array/table, making it way simpler and less redundant. -- v3: mshtml: Don't expose swapNode from NodePrototype. mshtml: Don't expose replaceNode from NodePrototype. mshtml: Don't expose removeNode from NodePrototype. mshtml: Expose ownerDocument from NodePrototype. mshtml/tests: Add initial tests for prototype chain props. mshtml: Enumerate all own builtin props from host object's NextProperty. https://gitlab.winehq.org/wine/wine/-/merge_requests/6850

3 7

[PATCH 0/1] MR6865: jscript: Don't use bool as a variable name.
by Gerald Pfeifer (＠gerald) 20 Nov '24

20 Nov '24

This is a reserved identifier in C23 and would break with GCC 15 moving to -std=gnu23 (which is C23 plus extensions). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6865

4 3

[PATCH v3 0/2] MR4392: server: Don't crash when opening null path with a console handle as RootDirectory.
by Jinoh Kang (＠iamahuman) 20 Nov '24

20 Nov '24

Preparatory patch for revival of https://gitlab.winehq.org/wine/wine/-/merge_requests/498. -- v3: server: Don't crash when opening null path with a console server as RootDirectory. server: Don't crash when opening null path with a console handle as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4392

3 3

[PATCH v2 0/1] MR6864: mshtml: Don't use cycle collection for nsChannel.
by Gabriel Ivăncescu (＠insn) 20 Nov '24

20 Nov '24

Tested and doesn't seem to be leaking anything extra. -- v2: mshtml: Don't use cycle collection for nsChannel. https://gitlab.winehq.org/wine/wine/-/merge_requests/6864

3 2

[PATCH 0/1] MR6864: mshtml: Don't use cycle collection for nsChannel.
by Gabriel Ivăncescu (＠insn) 20 Nov '24

20 Nov '24

Tested and doesn't seem to be leaking anything extra. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6864

2 1

Re: [PATCH v3 0/3] MR5970: win32u: Use the thread message queue shared memory in peek_message.
by sagi trashbin (＠trashbin) 20 Nov '24

20 Nov '24

Does the new throttling mechanism introduce input lag? Testing with a simple SDL2 app polling for events, input delay is 9.8ms averaged over 100 clicks, but native application build is only 1.05ms. I implemented the mechanism used before with 200 message count and the input lag is only 1.2ms, but I suppose in real game there would be a big CPU usage spike -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5970#note_88177

1 0

[PATCH 0/1] MR6859: mshtml: Copy POST data in BindStatusCallback_GetBindInfo().
by Paul Gofman (＠gofman) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6859

5 12

Re: [PATCH v7 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Nikolay Sivov (＠nsivov) 20 Nov '24

20 Nov '24

Nikolay Sivov (@nsivov) commented about dlls/mf/evr.c: > } > > if (SUCCEEDED(IMFTransform_ProcessInput(stream->parent->mixer, stream->id, sample, 0))) > - IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_PROCESSINPUTNOTIFY, 0); > + { > + while (hr == S_OK && (hr = IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_PROCESSINPUTNOTIFY, 0)) == MF_E_TRANSFORM_TYPE_NOT_SET) > + hr = IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_INVALIDATEMEDIATYPE, 0); > + } If it works like that, sure. But could we turn "hr == S_OK" to a loop break condition, after ProcessMessage. Or simply as "if ((hr == ProcessMessage()) != S_OK) break;. I think that would be more readable and easy to follow. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6059#note_88170

1 0

[PATCH v8 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) 20 Nov '24

20 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v8: user32: Send parent BN_CLICKED notification when a radio button get focused. user32/tests: Add tests for radio button WM_SETFOCUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

4 7

[PATCH v5 0/5] MR6783: winegstreamer: Fix memory/resource leaks in media sources.
by Conor McCarthy (＠cmccarthy) 20 Nov '24

20 Nov '24

Streams hold a reference to the source, but this reference should not be taken until `Start()` is called because freeing the media source depends on release in `Shutdown()` of the stream's reference to the source. We could create the streams in `media_source_create()` and take source refs for them in `Start()`, but that's potentially confusing and fragile. Streams can persist after the media source is destroyed. In that case, they cannot access the source object and it should be released and set to null. Windows behaviour is to release references to the source in `Shutdown()`. If we don't do this and a buggy app were to leak a stream object, the media source object would also leak and `wg_parser_destroy()` would not be called. -- v5: winegstreamer: Release stream references to the media source in Shutdown(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6783

5 11

[PATCH v12 0/3] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 20 Nov '24

20 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v12: comctl32/toolbar: Forward WM_NOTIFY CBEN_ENDEDITW. comctl32: Move WM_NOTIFY unicode to ansi conversion code from pager.c to commctrl.c. comctl32/tests: Test WM_NOTIFY CBEN_ENDEDITW conversion and forwarding in toolbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

3 4

[PATCH v11 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 20 Nov '24

20 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v11: comctl32/toolbar: Forward WM_NOTIFY CBEN_ENDEDITW. comctl32/tests: Test WM_NOTIFY CBEN_ENDEDITW conversion and forwarding in toolbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

4 10

[PATCH 0/1] MR6856: msi: Don't use bool as a variable name.
by Gerald Pfeifer (＠gerald) 20 Nov '24

20 Nov '24

This is a reserved identifier in C23 and would break with GCC 15 moving to -std=gnu23 (based on C23). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6856

4 3

[PATCH 0/1] MR6839: msi: Also set x64 properties for arm64 hosts.
by Billy Laws (＠bylaws) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6839

4 4

[PATCH 0/1] MR6838: msi: Dynamically determine supported package architectures.
by Billy Laws (＠bylaws) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6838

4 4

[PATCH 0/5] MR6863: winex11: Use more of the new state tracker and make initial window properties changes asynchronous too.
by Rémi Bernon (＠rbernon) 20 Nov '24

20 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6863

2 5

Re: [PATCH v3 0/2] MR6787: wineps.drv: Use locale aware variants _sprintf_l and _sscanf_l. (ASan)
by Bernhard Übelacker (＠bernhardu) 20 Nov '24

20 Nov '24

On Wed Nov 20 10:02:28 2024 +0000, Huw Davies wrote: > @bernhardu, I'd requested access to your repo so that I could make some > cosmetic changes to the commit. Hello Huw, sorry, did not realize this needs an action from my side, just confirmed it now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6787#note_88137

1 0

[PATCH 0/1] MR6862: win32u: Print the correct index when source_enum_display_settings() fails.
by Zhiyi Zhang (＠zhiyi) 20 Nov '24

20 Nov '24

When source_enum_display_settings() fails to find a display mode because the index is out of range, the index number in the log is always 0 because the same variable is decreased in the for loop to find the display mode, giving the impression that it fails to find the first display mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6862

3 2

[PATCH v5 0/3] MR4794: comctl32/combo: Add tests for keypresses showing search functionality
by Fabian Maurer (＠DarkShadow44) 20 Nov '24

20 Nov '24

In preparation to fix https://bugs.winehq.org/show_bug.cgi?id=56104 and https://bugs.winehq.org/show_bug.cgi?id=42898 -- v5: comctl32/listbox: Add tests for keypresses showing search functionality. comctl32/combo: Add tests for keypresses showing search functionality. comctl32/listbox: Close a few leaked window handles. https://gitlab.winehq.org/wine/wine/-/merge_requests/4794

4 6

Re: [PATCH v3 0/2] MR6787: wineps.drv: Use locale aware variants _sprintf_l and _sscanf_l. (ASan)
by Huw Davies (＠huw) 20 Nov '24

20 Nov '24

@bernhardu, I'd requested access to your repo so that I could make some cosmetic changes to the commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6787#note_88134

1 0

2025

2024

2023

2022

wine-gitlab