This is just nodes for now. The tests in the last patch may seem a bit overkill now, but it will be used for all the other prototypes, so they'll only need extra entries in the array/table, making it way simpler and less redundant.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6850
Ensure that the specified CROSSCFLAGS (or its default value) is applied consistently during
toolchain checks. Also fixes debug format recognition.
The regression was introduced in commit 471d7178ae01.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6851
Before this fix, the regex engine would run into an infinite loop and OOM when encountering a
quantifier allowing a zero amount of items in a REG_GLOB regex.
This fixes a freeze/crash in the Final Fantasy XIV Launcher during the registration process.
--
v2: jscript/tests: Add tests for star and opt operators in global regex.
jscript: Handle star and opt operators while matching global regex properly.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6840
The code looks reasonable to me, but my driver does not like it. I get that when running dxgi tests:
```
radv/amdgpu: The CS has been rejected, see dmesg for more information (-22). // nothing shows up in dmesg
0264:err:dxgi:d3d12_swapchain_queue_present Failed to blit swapchain buffer, vr -4.
0264:err:dxgi:d3d12_swapchain_op_present_execute Failed to queue present, vr -4.
0264:fixme:dxgi:hresult_from_vk_result Unhandled VkResult -4.
0264:err:dxgi:d3d12_swapchain_queue_present Failed to blit swapchain buffer, vr -4.
0264:err:dxgi:d3d12_swapchain_op_present_execute Failed to queue present, vr -4.
0264:fixme:dxgi:hresult_from_vk_result Unhandled VkResult -4.
0264:err:dxgi:d3d12_swapchain_queue_present Failed to blit swapchain buffer, vr -4.
0264:err:dxgi:d3d12_swapchain_op_present_execute Failed to queue present, vr -4.
0264:fixme:dxgi:hresult_from_vk_result Unhandled VkResult -4.
0264:err:dxgi:d3d12_swapchain_queue_present Failed to blit swapchain buffer, vr -4.
0264:err:dxgi:d3d12_swapchain_op_present_execute Failed to queue present, vr -4.
0264:fixme:dxgi:hresult_from_vk_result Unhandled VkResult -4.
```
(By the way, I think the moved wakes is the right way to do it.)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5830#note_88034
Minimizing the window might trigger a focus change to the dummy window,
while restoring and setting foreground should change the foreground
back to the focus window.
However, the X window manager will instead send WM_TAKE_FOCUS event to
the dummy window and to the focus window concurrently, and the dummy
window might reply to it *after* we've restored the foreground to the
focus window. This will later cause the device window to fail to get
foreground, and the tests to randomly fail.
(This works around a foreground window race condition that will be difficult
to fix otherwise, as it can happen in a cross-process context as well)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6821
Before this fix, the regex engine would run into an infinite loop and OOM when encountering a
quantifier allowing a zero amount of items in a REG_GLOB regex.
This fixes a freeze/crash in the Final Fantasy XIV Launcher during the registration process.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6840
On Mon Nov 18 14:44:04 2024 +0000, Vibhav Pant wrote:
> Well, from our conversation on IRC, I had merged them to reduce the MR
> from 10 commits to 7.
Let's keep it small for this MR. ~5 should be best. 8 is a bit too much. Having more patches in one MR makes it harder to review.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_87995
On Mon Nov 18 15:27:34 2024 +0000, Vibhav Pant wrote:
> `Iterable` has two separate implementations. One is derived from
> `MapView<HSTRING, IInspectable *>`, while the other is from the
> `IPropertySet`'s `Map<HSTRING, IInspectable *>` interface. Using
> `DEFINE_IINSPECTABLE` for both would create a conflict for the
> `impl_from_IIterable_IKeyValuePair_HSTRING_IInspectable` function.
Ok, I see.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_87994